Re: [PATCH] Fix tree-call-cdce.c (PR tree-optimization/58165)

2013-08-16 Thread Richard Biener
Jakub Jelinek ja...@redhat.com wrote: Hi! On the following testcase we ICE because the builtin fn prototype doesn't have throw () on it (glibc headers provide it, but some other C libraries apparently don't) and thus we can have EH edges out of the builtin, and call-cdce unconditionally split the

Re: [PATCH] Fix ICEs with bogus computed goto (PR tree-optimization/58164)

2013-08-16 Thread Richard Biener
Jakub Jelinek ja...@redhat.com wrote: Hi! gimple_goto_dest is is_gimple_val, so can be ADDR_EXPR (though just for bad testcases), and in that case we weren't walking it in some cases. I've tried to reject ADDR_EXPRs in gimple_goto_dest, but that turned out to be much larger patch and still

libtool update for powerpc64le-linux

2013-08-16 Thread Alan Modra
I'd like to apply the following patch to the gcc repository (well, excluding the libgo part which I'm hoping someone will apply for me to the master go repository). I know the normal procedure for autotools is to submit upstream then update when the patch is in the upstream autotools repository,

Re: Two regex testcases failing for check-debug

2013-08-16 Thread Paolo Carlini
On 08/16/2013 02:40 AM, Tim Shen wrote: Could you please commit this patch for me? Done. Paolo.

Re: [patch] [python libstdc++ printers] Fix gdb/15195

2013-08-16 Thread Phil Muldoon
On 23/07/13 15:23, Tom Tromey wrote: Phil == Phil Muldoon pmuld...@redhat.com writes: Phil On 03/07/13 08:33, Phil Muldoon wrote: This new patch replaces and obsoletes the previous. On further inspection of some other pretty printer related bugs, it seems that all of the printers need to

Clean up pretty printers [7/n]

2013-08-16 Thread Gabriel Dos Reis
Same topic as previous patch in this series. -- Gaby 2013-08-16 Gabriel Dos Reis g...@integrable-solutions.net * sched-vis.c (rtl_slim_pp_initialized): Remove. (rtl_slim_pp): Likewise. (init_rtl_slim_pretty_print): Likewise. (dump_value_slim): Don't call it.

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-16 Thread Jan Hubicka
Thanks, this is version I commited after testing at ppc64-linux. The difference is that it also updates code suffering from the same problem in gimple_extract_devirt_binfo_from_cst. I originally intended to rewrite the function but after yesterday discussion with Martin I think it will take me

Re: [PATCH] Fix bad interaction between GTY((user)) and incomplete declarations

2013-08-16 Thread David Malcolm
On Fri, 2013-08-16 at 07:12 +0300, Laurynas Biveinis wrote: * gengtype.c (create_user_defined_type): Ensure that the kind is set to TYPE_USER_STRUCT, fixing a bug seen when an incomplete declaration is seen before the GTY((user)) marking. This is OK, thank you.

Re: [PATCH] Redesign pthread in LIB_SPEC for systems without libpthread

2013-08-16 Thread Pavel Chupin
On Fri, Aug 16, 2013 at 3:21 AM, Maxim Kuvyrkov ma...@kugelworks.com wrote: On 15/08/2013, at 10:49 PM, Alexander Ivchenko wrote: Could anybody please take a look? This is important for building gcc for android. ping^4 [Sorry for being cranky] There is a reason why people are ignoring

Re: [PATCH,ARM] fix testsuite failures for arm-none-linux-gnueabihf

2013-08-16 Thread Charles Baylis
Hi Kyrylo Thanks for the comments. I've done version 2 of the patch with the changes incorporated 2013-08-16 Charles Baylis charles.bay...@linaro.org * gcc.dg/builtin-apply2.c: skip test on arm hardfloat ABI targets * gcc.dg/tls/pr42894.c: Use -mfloat-abi=soft as Thumb1 does

Re: [patch] [python libstdc++ printers] Fix gdb/15195

2013-08-16 Thread Tom Tromey
Phil == Phil Muldoon pmuld...@redhat.com writes: Phil Anyway, I have regenerated the patch with the fixes requested. Thanks. Phil 2013-08-16 Phil Muldoon pmuld...@redhat.com Phil PR gcc/53477 I think this should say PR libstdc++/53477 Other than this nit, it looks good to me. I can't

v3 of patch (was Re: [PATCH 11/11] Make opt_pass and gcc::pipeline be GC-managed)

2013-08-16 Thread David Malcolm
On Mon, 2013-08-05 at 06:59 -1000, Richard Henderson wrote: On 08/05/2013 05:18 AM, David Malcolm wrote: So I *think* the most efficient traversal is to do this first (with a suitable comment): for (int i = passes_by_id_size ; i 0; ) ::gt_ggc_mx (passes_by_id[--i]); That

[PING]RE: [PATCH] Fix for PR c/57490

2013-08-16 Thread Iyer, Balaji V
Has anyone had a chance to look at this patch? Is it OK for trunk? Thanks, -Balaji V. Iyer. -Original Message- From: Iyer, Balaji V Sent: Monday, August 12, 2013 1:17 PM To: Rainer Orth Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org; Marek Polacek (pola...@redhat.com) Subject: RE:

[PATCH, rs6000, generic builtins] Fix unary TDmode patterns and add DFP ABS builtins

2013-08-16 Thread Peter Bergner
The following patch fixes a bug in the rs6000 DFP handling of some _Decimal128 patterns, namely the unary patterns neg, abs and nabs. These patterns use the legacy binary floating point instructions fneg, fabs and fnabs to twiddle the signbit. However, these instructions only operate on the

Re: [PATCH, rs6000, generic builtins] Fix unary TDmode patterns and add DFP ABS builtins

2013-08-16 Thread Jakub Jelinek
On Fri, Aug 16, 2013 at 12:06:56PM -0500, Peter Bergner wrote: --- gcc/config/rs6000/dfp.md (revision 201779) +++ gcc/config/rs6000/dfp.md (working copy) @@ -135,8 +135,15 @@ (define_insn *negtd2_fpr [(set (match_operand:TD 0 gpc_reg_operand =d) (neg:TD (match_operand:TD 1

Re: [PATCH, rs6000, generic builtins] Fix unary TDmode patterns and add DFP ABS builtins

2013-08-16 Thread Peter Bergner
On Fri, 2013-08-16 at 19:11 +0200, Jakub Jelinek wrote: On Fri, Aug 16, 2013 at 12:06:56PM -0500, Peter Bergner wrote: --- gcc/config/rs6000/dfp.md(revision 201779) +++ gcc/config/rs6000/dfp.md(working copy) @@ -135,8 +135,15 @@ (define_insn *negtd2_fpr [(set

Re: [PATCH] Fix for PR c/57490

2013-08-16 Thread Jason Merrill
On 08/12/2013 01:16 PM, Iyer, Balaji V wrote: + /* If it is a built-in array notation function, then the return type of + the function is the type of the array passed in as array notation. */ How can the function return an array? Jason

RE: [PATCH] Fix for PR c/57490

2013-08-16 Thread Iyer, Balaji V
-Original Message- From: Jason Merrill [mailto:ja...@redhat.com] Sent: Friday, August 16, 2013 2:08 PM To: Iyer, Balaji V; Rainer Orth Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org; Marek Polacek (pola...@redhat.com) Subject: Re: [PATCH] Fix for PR c/57490 On 08/12/2013 01:16 PM,

[GOOGLE] bug in discriminator assignment

2013-08-16 Thread Dehao Chen
This patch fixes a bug in assigning discrminator. We should explicitly call the hash function when finding the next discriminator. Bootstrapped and passed regression tests. OK for google branches? Thanks, Dehao Index: gcc/tree-cfg.c

Re: [PATCH 09/11] Support gcc namespace in gengtype

2013-08-16 Thread David Malcolm
On Thu, 2013-08-01 at 11:01 -1000, Richard Henderson wrote: On 07/26/2013 05:04 AM, David Malcolm wrote: +/* Types with a \gcc::\ prefix have the prefix stripped\n + during gengtype parsing. Provide a \using\ directive\n + to ensure that the fully-qualified

[PATCH] Fix PR58139 but correctly initializing reg_raw_mode[]

2013-08-16 Thread Peter Bergner
PR58139 shows a case where sched2 is scheduling the definition of a volatile VSX register across a call. The volatile VSX register (62) is actually made up the non-volatile FPR30 and another volatile doubleword, so it is actually partially volatile. Since FPR30 is defined by the PPC{,64} ABIs as

[Google] fix a bug in lipo varpool node linking

2013-08-16 Thread Rong Xu
This patch fixed a bug in lipo varpool node linking. C++ FE drops the initializer if it's not used in this TU. For current varpool linking may resolve the varpool node to the one with null initializer. -Rong Index: l-ipo.c === ---

[patch, google] Update powerpc64 xfail file.

2013-08-16 Thread Brooks Moses
I fixed the bits in our DejaGNU powerpc64 board file to transfer profile output back to the build system from the remote target, which means that a bunch of test failures now go away, and we uncover a small handful of new ones. This patch updates the xfail file accordingly. Committed as obvious.

Re: [PATCH, rs6000, generic builtins] Fix unary TDmode patterns and add DFP ABS builtins

2013-08-16 Thread Peter Bergner
On Fri, 2013-08-16 at 19:11 +0200, Jakub Jelinek wrote: On Fri, Aug 16, 2013 at 12:06:56PM -0500, Peter Bergner wrote: --- gcc/config/rs6000/dfp.md(revision 201779) +++ gcc/config/rs6000/dfp.md(working copy) @@ -135,8 +135,15 @@ (define_insn *negtd2_fpr [(set

Re: [PATCH, rs6000, generic builtins] Fix unary TDmode patterns and add DFP ABS builtins

2013-08-16 Thread Jakub Jelinek
On Fri, Aug 16, 2013 at 04:18:18PM -0500, Peter Bergner wrote: --- gcc/config/rs6000/dfp.md (revision 201779) +++ gcc/config/rs6000/dfp.md (working copy) @@ -132,11 +132,14 @@ (define_expand negtd2 ) (define_insn *negtd2_fpr - [(set (match_operand:TD 0 gpc_reg_operand =d) -

Re: [Google] fix a bug in lipo varpool node linking

2013-08-16 Thread Xinliang David Li
ok. David On Fri, Aug 16, 2013 at 1:28 PM, Rong Xu x...@google.com wrote: This patch fixed a bug in lipo varpool node linking. C++ FE drops the initializer if it's not used in this TU. For current varpool linking may resolve the varpool node to the one with null initializer. -Rong

Re: [PATCH, rs6000, generic builtins] Fix unary TDmode patterns and add DFP ABS builtins

2013-08-16 Thread Peter Bergner
On Fri, 2013-08-16 at 23:25 +0200, Jakub Jelinek wrote: On Fri, Aug 16, 2013 at 04:18:18PM -0500, Peter Bergner wrote: --- gcc/config/rs6000/dfp.md(revision 201779) +++ gcc/config/rs6000/dfp.md(working copy) @@ -132,11 +132,14 @@ (define_expand negtd2 )

Re: [PATCH] MIPS/libgcc: Avoid the PLT in MIPS16 stub calls

2013-08-16 Thread Maciej W. Rozycki
On Wed, 7 Aug 2013, Richard Sandiford wrote: /* Define a function NAME that moves a return value of mode MODE from FPRs to GPRs. */ -#define RET_FUNCTION(NAME, MODE) \ +#define _RET_FUNCTION(NAME, MODE) \ STARTFN (NAME);\ MOVE_##MODE##_RET

Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-16 Thread Caroline Tice
OK, I *think* I have done as you requested. I have to try the environment variable before falling back on stderr (there's a program we want to use this on that disables the ability to write to stderr). I have added the secure_getenv stuff as you requested. The fixed patch is attached. Please

Re: [PATCH, rs6000, generic builtins] Fix unary TDmode patterns and add DFP ABS builtins

2013-08-16 Thread Peter Bergner
On Fri, 2013-08-16 at 23:25 +0200, Jakub Jelinek wrote: On Fri, Aug 16, 2013 at 04:18:18PM -0500, Peter Bergner wrote: --- gcc/config/rs6000/dfp.md(revision 201779) +++ gcc/config/rs6000/dfp.md(working copy) @@ -132,11 +132,14 @@ (define_expand negtd2 )

[GOOGLE] Emit linkage_name when built with -gmlt and for abstract decls

2013-08-16 Thread Dehao Chen
This patch emits linkage_name at -gmlt. It also make sure abstract decls' linkage_names are emitted so that inlined functions can also find linkage name. Bootstrapped and passed regression test. OK for google branches? Thanks, Dehao Index: gcc/dwarf2out.c

[GOOGLE] Add discriminator for inlined callsite

2013-08-16 Thread Dehao Chen
This patch emits discriminator for inlined callsite. This is important when there are two inlined callsites in the same line. Bootstrapped, testing on going. OK for google branches? Thanks, Dehao Index: gcc/dwarf2out.c === ---

Re: [PATCH, rs6000, generic builtins] Fix unary TDmode patterns and add DFP ABS builtins

2013-08-16 Thread Peter Bergner
On Fri, 2013-08-16 at 17:32 -0500, Peter Bergner wrote: Ok, updated to switch the order of the alternatives. This works...just like the previous one. I created two versions of the TD test case to test both alternatives and to make sure we get fmrs on the one and no fmrs on the other. FYI,

Re: [patch] Make cxxfilt demangle internal-linkage templates

2013-08-16 Thread Paul Pluzhnikov
Ping? On Wed, Aug 7, 2013 at 11:51 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: The following source: templatetypename T static void f(); void g() { fint(); } results in _Z1fIiEvv under g++, but in _ZL1fIiEvv under clang. Richard Smith says: The ABI doesn't cover manglings

Re: Fix class type lookup from OBJ_TYPE_REF

2013-08-16 Thread David Edelsohn
This patch causes an ICE when building libobjc, which is part of normal bootstrap. PR 58179 /nasfarm/edelsohn/src/src/libobjc/accessors.m: In function 'objc_getProperty': /nasfarm/edelsohn/src/src/libobjc/accessors.m:127:11: internal compiler error: in obj_type_ref_class, at tree.c:11876

Re: [wwwdocs] Add link to @gnutools on Twitter

2013-08-16 Thread Alexandre Oliva
On Aug 12, 2013, Gerald Pfeifer ger...@pfeifer.com wrote: Based on another suggestion by David I also added a link to the gnutools account on Google+. Patch below, gcc.gnu.org updated. I don't think it's good for the GNU project to direct people towards proprietary spying networks. How about

Re: [PATCH] Fix for PR c/57490

2013-08-16 Thread Jason Merrill
On 08/16/2013 02:13 PM, Iyer, Balaji V wrote: + /* If it is a built-in array notation function, then the return type of + the function is the type of the array passed in as array notation. */ How can the function return an array? float x, A[10]; x = __sec_reduce_add (A[:]); // The

Re: [PATCH] Redesign pthread in LIB_SPEC for systems without libpthread

2013-08-16 Thread Maxim Kuvyrkov
On 17/08/2013, at 3:07 AM, Pavel Chupin wrote: ... It's late to change subj I think to avoid producing new thread but I got your point. Problem is that all 3 Android compilers (arm, x86, mips) are failed to build on trunk due to libgomp and libatomic configure errors like (arm example):