Re: Ada PATCH: Fix ada/58239 by linking with xg++, not xgcc

2013-09-01 Thread Iain Sandoe
On 31 Aug 2013, at 22:42, Gabriel Dos Reis wrote: Eric Botcazou ebotca...@adacore.com writes: | This patch fixes that by introducing GXX_LINK which is GCC_LINK except | that CXX (e.g. xg++) instead of CC (e.g. xgcc) is invoked. | | Eric, are there other executables that need to be

Re: [PATCH i386 1/8] [AVX512] Adjust register classes.

2013-09-01 Thread Iain Sandoe
Hi Kirill, On 23 Aug 2013, at 08:35, Kirill Yukhin wrote: On 22 Aug 12:06, Richard Henderson wrote: Ok. I've updated ChangeLog (thanks, HJ!) and checked in to main trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-08/msg00545.html This patch [actually the change at 201915] also broke X86 Darwin

Re: Ubsan merged into trunk

2013-09-01 Thread Jakub Jelinek
On Sat, Aug 31, 2013 at 04:04:03PM +0100, Iain Sandoe wrote: OK for trunk? Ok with the suggested s/sanitise/sanitize/g change. gcc: * config/darwin.h (LINK_COMMAND_SPEC_A): Revise sanitiser specs to include sanitise(undefined). libsanitiser: * ubsan/Makefile.am

Re: Ubsan merged into trunk

2013-09-01 Thread Jakub Jelinek
On Sat, Aug 31, 2013 at 05:15:55PM +0200, Marek Polacek wrote: I see, sorry. Will commit the following fix as obvious in a bit. 2013-08-31 Marek Polacek pola...@redhat.com * ubsan.c: Include tm_p.h. You need to add $(TM_P_H) to ubsan.o dependencies in Makefile.in too. Ok with that

Re: Ubsan merged into trunk

2013-09-01 Thread Marek Polacek
On Sun, Sep 01, 2013 at 01:36:37PM +0200, Jakub Jelinek wrote: On Sat, Aug 31, 2013 at 05:15:55PM +0200, Marek Polacek wrote: I see, sorry. Will commit the following fix as obvious in a bit. 2013-08-31 Marek Polacek pola...@redhat.com * ubsan.c: Include tm_p.h. You need to

Re: [patch 4/4] -fstrict-volatile-bitfields cleanup v3: remove from defaults on all targets

2013-09-01 Thread Bernd Edlinger
On Fri, 30 Aug 2013 11:47:21, Richard Biener wrote: On Tue, Jul 2, 2013 at 7:33 PM, DJ Delorie d...@redhat.com wrote: The choice appears to be to continue to have broken volatile bitfields on ARM with no way for users to make them conform to the ABI, or to change things so that they conform

Type inheritance graph analysis speculative devirtualization, part 7/7 (speculative devirtualizatoin)

2013-09-01 Thread Jan Hubicka
Hi, this patch implement speculative devirtualization. It is a trivial pass that asks for targets of every polymorphic call in a program and if the list contains one likely target, it produces an speculative call. No context sensitive analysis is done at the moment. This call may or may not

Re: Type inheritance graph analysis speculative devirtualization, part 7/7 (speculative devirtualizatoin)

2013-09-01 Thread Xinliang David Li
Missing test cases? Have you tested the optimization with SPEC2k and SPEC06? There are a couple of benchmarks benefit greatly from devirtualization, such as eon, povray etc. I believe astar will probably improve with this optimization at O2 (it has hot virtual functions that are not overridden

Re: [ping] Fix error recovery issue with alias

2013-09-01 Thread Eric Botcazou
The test still fails with the following change: --- /opt/gcc/_clean/gcc/testsuite/gnat.dg/specs/linker_alias.ads2013-08-18 17:39:22.0 +0200 +++ /opt/gcc/work/gcc/testsuite/gnat.dg/specs/linker_alias.ads2013-08-19 08:52:35.0 +0200 @@ -5,5 +5,6 @@ package Linker_Alias is

Re: Type inheritance graph analysis speculative devirtualization, part 7/7 (speculative devirtualizatoin)

2013-09-01 Thread Jan Hubicka
Missing test cases? Good point. The testcases I have needs rest of the patches from the series to hit the mainline. For now I have added the following to test the basic scenario * g++.dg/ipa/devirt-15.C: New testcase. Index: g++.dg/ipa/devirt-15.C

Re: [PATCH i386 1/8] [AVX512] Adjust register classes.

2013-09-01 Thread Kirill Yukhin
Hello, This patch [actually the change at 201915] also broke X86 Darwin bootstrap/ABI: pr59269 - ISTM that SSE_REGNO_P() now returns true for a different set of registers than before the patch, I've attached a starting-point to fix to the PR - but would welcome any additional inputs folks

Re: Ada PATCH: Fix ada/58239 by linking with xg++, not xgcc

2013-09-01 Thread Eric Botcazou
It seems the patch needs a couple of minor amendments to work with Darwin - and I've added an updated version to the PR which passes bootstrap and make check-ada on x86_64-darwin12. Iain Thanks, here is the final patch I just installed. 2013-09-01 Eric Botcazou ebotca...@adacore.com

Re: [patch, fortran, docs] Unformatted sequential and special files

2013-09-01 Thread Thomas Koenig
Hi Janne, I have tried to answer your points in the attached patch. The unformatted sequential format part looks Ok, but the special files section is lacking. E.g. what about - The REWIND statement? Not supported. - The ENDFILE statement? Not supported. - ACCESS='stream' and the POS=

[C++ Patch] PR 21682 (DR 565)

2013-09-01 Thread Paolo Carlini
Hi, this patch resolves the bug by implementing the resolution of DR 565 (DRWP): for template functions, in order to establish that the program is ill-formed we want to check return type and template parameter list too. Thus, in practice, we want to accept the reduced testcase which came

[committed] Accept const_int 0 operand 1 in PA scc insns

2013-09-01 Thread John David Anglin
This pattern fixes the following ICE found compiling ArabicShaping.cpp: g++-4.7 -D_REENTRANT -I. -I./.. -I../common -I./unicode - DU_ATTRIBUTE_DEPRECATED= -DU_LAYOUT_IMPLEMENTATION -D__NO_MATH_INLINES -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DNDEBUG - D_FORTIFY_SOURCE=2

Re: Ada PATCH: Fix ada/58239 by linking with xg++, not xgcc

2013-09-01 Thread Gabriel Dos Reis
Eric Botcazou ebotca...@adacore.com writes: | It seems the patch needs a couple of minor amendments to work with Darwin - | and I've added an updated version to the PR which passes bootstrap and make | check-ada on x86_64-darwin12. Iain | | Thanks, here is the final patch I just installed.

Move ipa-profile pass into separate file

2013-09-01 Thread Jan Hubicka
Hi, once simple pass has grown up into set of not-so-trivial profile based transformations. This patch merely moves it to separate file. I intend to add toplevel comment and fix interesting problem Martin Liska noticed in followup patch. I did some basic housekeeping of include files and

Re: [C++ Patch] PR 21682 (DR 565)

2013-09-01 Thread Paolo Carlini
.. consider this withdrawn, I have to fix another very similar check elsewhere. Paolo.

Re: wide-int branch now up for public comment and review

2013-09-01 Thread Richard Sandiford
Mike Stump mikest...@comcast.net writes: @@ -643,12 +653,14 @@ equality. */ __FUNCTION__); \ _rtx-u.hwint[_n]; })) -#define XHWIVEC_ELT(HWIVEC, I) __extension__ \ -(*({ __typeof (HWIVEC) const _hwivec =

Re: [RFA] Type inheritance graph analysis speculative devirtualization, part 4/7, ODR at LTO time

2013-09-01 Thread Jason Merrill
On 08/19/2013 10:01 AM, Jan Hubicka wrote: + /* All equivalent types, if more than one. */ + vectree, va_gc *types; + /* Set of all equivalent types, if NON-NULL. */ + pointer_set_t * GTY((skip)) types_set; Why do you need both a vector and a pointer set? Can't you drop the vector

Re: [RFA] Type inheritance graph analysis speculative devirtualization, part 4/7, ODR at LTO time

2013-09-01 Thread Jan Hubicka
On 08/19/2013 10:01 AM, Jan Hubicka wrote: + /* All equivalent types, if more than one. */ + vectree, va_gc *types; + /* Set of all equivalent types, if NON-NULL. */ + pointer_set_t * GTY((skip)) types_set; Why do you need both a vector and a pointer set? Can't you drop the

Re: Lambda templates and implicit function templates.

2013-09-01 Thread Jason Merrill
On 08/27/2013 03:42 PM, Adam Butcher wrote: Unfortunately, due to errors being thrown 'early' in grokdeclarator, I haven't been able to get 'auto...' (or reference/qualified variants) working yet. I think I need to defer processing the parameter pack internals of grokdeclarator until I have the

Re: [PATCH 1/4] Support lambda templates.

2013-09-01 Thread Jason Merrill
On 08/27/2013 03:42 PM, Adam Butcher wrote: + vec_safe_push (argvec, arg); I bet we want convert_from_reference in the non-generic lambda case, too. OK with that change. Jason

Re: [PATCH 2/4] Don't generate lambda conversion op if arglist has parameter pack.

2013-09-01 Thread Jason Merrill
On 08/27/2013 03:42 PM, Adam Butcher wrote: + if (FUNCTION_PARAMETER_PACK_P (src)) + return; Yeah, in the case of a parameter pack we want to pass a pack expansion. Jason

Re: [PATCH 4/4] Support using 'auto' in a function parameter list to introduce an implicit template parameter.

2013-09-01 Thread Jason Merrill
On 08/27/2013 03:42 PM, Adam Butcher wrote: + else // extend current template parameter list + // pop the innermost template parms into tparms Most comments should start with a capital letter and end with a period. + for (size_t n = 0, end = TREE_VEC_LENGTH (inner_vec); n end;

[C++ Patch] PR 21682 (DR 565) (Take 2)

2013-09-01 Thread Paolo Carlini
Hi again, ... thus Take 2: the extended comparison per DR 565 must be used in push_overloaded_decl_1 too, in order to handle correctly the case of an using decl *followed* by a decl. I added a testcase too. Again booted and tested x86_64-linux. Thanks, Paolo. // /cp

Re: [PATCH]: Fix PR middle-end/56382 -- Only move MODE_COMPLEX_FLOAT by parts if we can create pseudos

2013-09-01 Thread John David Anglin
On 30-Aug-13, at 6:38 AM, Eric Botcazou wrote: Let's avoid trying to do something general since this seems to be really a corner case. Can't we simply deal with hard registers specially? /* Move floating point as parts if splitting is easy. */ if (GET_MODE_CLASS (mode) ==

Re: [RFC] Changes to the wide-int classes

2013-09-01 Thread Kenneth Zadeck
My main discomfort is the double-int part. At this point in time the only usage of double-int left on the branch is because the fixed ints use it as their underlying representation. I think that rather than doing a lot of work to accommodate this, it would be better to just change the fixed

Re: [RFC] Changes to the wide-int classes

2013-09-01 Thread Mike Stump
On Sep 1, 2013, at 7:37 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 09/01/2013 03:21 PM, Richard Sandiford wrote: * As Richard requested, the main wide int class is parameterised by the storage: template typename storage class GTY(()) generic_wide_int : public storage