RE: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread bin.cheng
-Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Monday, September 23, 2013 8:08 PM To: Bin Cheng Cc: GCC Patches Subject: Re: [PATCH]Construct canonical scaled address expression in IVOPT On Fri, Sep 20, 2013 at 12:00 PM, bin.cheng

Re: [PATCH] Bug fix: *var and MEM[(const int *)var] (var has int* type) are not treated as the same data ref.

2013-09-24 Thread Jakub Jelinek
Hi! On Mon, Sep 23, 2013 at 05:26:13PM -0700, Cong Hou wrote: Missing ChangeLog entry. --- gcc/testsuite/gcc.dg/alias-14.c (revision 0) +++ gcc/testsuite/gcc.dg/alias-14.c (revision 0) Vectorizer tests should go into gcc.dg/vect/ instead, or, if they are for a single target (but there is no

Re: [C++1y] [PATCH 3/4] ... canonical type workaround and refactoring

2013-09-24 Thread Adam Butcher
On 23.09.2013 08:15, Adam Butcher wrote: On 22.09.2013 18:57, Adam Butcher wrote: The following solves the canonical type issue in the general case (pointers and refs) and makes it equivalent to the explicit template case -- in terms of canonical type at least. for (tree t = TREE_TYPE

Re: [PATCH] Bug fix: *var and MEM[(const int *)var] (var has int* type) are not treated as the same data ref.

2013-09-24 Thread Richard Biener
On Tue, 24 Sep 2013, Jakub Jelinek wrote: Hi! On Mon, Sep 23, 2013 at 05:26:13PM -0700, Cong Hou wrote: Missing ChangeLog entry. --- gcc/testsuite/gcc.dg/alias-14.c (revision 0) +++ gcc/testsuite/gcc.dg/alias-14.c (revision 0) Vectorizer tests should go into gcc.dg/vect/ instead,

[PATCH, ARM] Fix assembly scan test.

2013-09-24 Thread Yvan Roux
Hi, this patch fix the scan-assembler pattern of gcc.target/arm/atomic-comp-swap-release-acquire.c, which didn't allowed aliases register and failed when enabling LRA where 'ip' is used in the ldaex instruction. Thanks, Yvan 2013-09-24 Yvan Roux yvan.r...@linaro.org *

Re: [PATCH, RTL] Prepare ARM build with LRA

2013-09-24 Thread Yvan Roux
Ping On 16 September 2013 10:57, Yvan Roux yvan.r...@linaro.org wrote: Adding Eric and Steven in the loop as it is RTL related. Thanks Yvan On 11 September 2013 21:08, Yvan Roux yvan.r...@linaro.org wrote: Here is the new patch discussed in the other thread. Thanks Yvan 2013-09-11

Re: [PATCH, ARM] Fix assembly scan test.

2013-09-24 Thread Ramana Radhakrishnan
On 09/24/13 09:27, Yvan Roux wrote: Hi, this patch fix the scan-assembler pattern of gcc.target/arm/atomic-comp-swap-release-acquire.c, which didn't allowed aliases register and failed when enabling LRA where 'ip' is used in the ldaex instruction. Ok - The changelog could just read :

RE: [PR58463][Backport to 4.8] Adjust dumping for ref nodes

2013-09-24 Thread Paulo Matos
Ping on this patch. Note I don't have write access. Paulo Matos -Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: 23 September 2013 09:00 To: Paulo Matos Cc: gcc-patches@gcc.gnu.org Subject: Re: [PR58463][Backport to 4.8] Adjust dumping for ref

Re: [PATCH] Bug fix: *var and MEM[(const int *)var] (var has int* type) are not treated as the same data ref.

2013-09-24 Thread Richard Biener
On Tue, 24 Sep 2013, Richard Biener wrote: On Tue, 24 Sep 2013, Jakub Jelinek wrote: Hi! On Mon, Sep 23, 2013 at 05:26:13PM -0700, Cong Hou wrote: Missing ChangeLog entry. --- gcc/testsuite/gcc.dg/alias-14.c (revision 0) +++ gcc/testsuite/gcc.dg/alias-14.c (revision 0)

Re: [gomp4] Dumping gimple for offload.

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 3:29 PM, Ilya Tocar tocarip.in...@gmail.com wrote: Hi, I've rebased my patch. Is it ok for gomp4 Passing through is_omp looks bad - please find a more suitable place to attach this meta-information. From a quick look you only need it to produce an alternate section

Re: [PATCH] Fix typo in check for null

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 4:03 PM, Paulo Matos pma...@broadcom.com wrote: This is a patch for master, where in number_of_loops, we want to check if the loops (returned by loops_for_fn) is non-null but instead we are using fn, which is the function argument. I haven't opened a bug report, please

Re: [PATCH i386 3/8] [AVX512] [1/n] Add AVX-512 patterns: VF iterator extended.

2013-09-24 Thread Kirill Yukhin
Hello, On 18 Sep 11:17, Kirill Yukhin wrote: Hello, On 13 Sep 14:28, Kirill Yukhin wrote: Hello, On 09 Sep 15:11, Kirill Yukhin wrote: Hello, On 06 Sep 17:41, Kirill Yukhin wrote: Hello, PING. PING. PING. PING PING. -- Thanks, K

[PATCH, LRA, AARCH64] Switching LRA on for AArch64

2013-09-24 Thread Yvan Roux
Hi, The following patch switch LRA on for AArch64. The patch introduces an undocumented option -mlra to use LRA instead of reload, for a testing purpose. Please notice that this patch is dependent on the one submitted in the thread below:

[PATCH]Fix computation of offset in ivopt

2013-09-24 Thread bin.cheng
Hi, This patch fix two minor bugs when computing offset in IVOPT. 1) Considering below example: #define MAX 100 struct tag { int i; int j; } struct tag arr[MAX] int foo (int len) { int i = 0; for (; i len; i++) { access arr[i].j; } } Without this patch, the offset computed by

Re: RFC: patch to build GCC for arm with LRA

2013-09-24 Thread Yvan Roux
Hi, Fair enough - we should just fix the test and move on. Done. I would suggest in addition a transitional command-line option to switch between LRA and reload as a temporary measure so that folks can do some more experimenting for AArch32. I've a patch which fixes the REG_NOTE issues,

Re: Fix PR middle-end/57393

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 5:56 PM, Easwaran Raman era...@google.com wrote: Ping. On Mon, Sep 16, 2013 at 4:42 PM, Easwaran Raman era...@google.com wrote: There are two separate root causes for the problem reported in PR 57393. This patch attempts to fix both. First is due to newly created

Re: Fix PR middle-end/57393

2013-09-24 Thread Jakub Jelinek
On Tue, Sep 24, 2013 at 11:26:16AM +0200, Richard Biener wrote: + if (iters = MAX_UNASSIGNED_UIDS || uid == 0) +renumber_gimple_stmt_uids_in_blocks (bb, 1); so this will renumber uids whenever we have trailing zero-UID stmts at the end of a basic-block? Trailing zero-UIDs at the end of

Re: RFA: Store the REG_BR_PROB probability directly as an int

2013-09-24 Thread Andreas Schwab
Richard Sandiford rdsandif...@googlemail.com writes: REG_BR_PROB notes are stored as: (expr_list:REG_BR_PROB (const_int prob) chain) but a full const_int rtx seems a bit heavweight when all we want is a plain int. This patch uses: (int_list:REG_BR_PROB prob chain) instead. I think

Re: gimple build interface

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 7:16 PM, Andrew MacLeod amacl...@redhat.com wrote: On 09/23/2013 01:05 PM, David Malcolm wrote: On Mon, 2013-09-23 at 12:21 -0400, Andrew MacLeod wrote: On 09/20/2013 04:08 AM, Richard Biener wrote: On Thu, Sep 19, 2013 at 6:56 PM, Andrew MacLeod amacl...@redhat.com

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 10:34 PM, Eric Botcazou ebotca...@adacore.com wrote: I have committed it for you (rev 202831), with a few modifications (ChangeLog formatting, typos). Here is what I have committed: 2013-09-23 Kugan Vivekanandarajah kug...@linaro.org * gimple-pretty-print.c

Re: [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 4:52 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, with the attached patch the read-side of the out of bounds accesses are fixed. There is a single new test case pr57748-3.c that is derived from Martin's test case. The test case does only test the read

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-24 Thread Kugan
On 24/09/13 19:23, Richard Biener wrote: On Mon, Sep 23, 2013 at 10:34 PM, Eric Botcazou ebotca...@adacore.com wrote: I have committed it for you (rev 202831), with a few modifications (ChangeLog formatting, typos). Here is what I have committed: 2013-09-23 Kugan Vivekanandarajah

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 8:20 AM, bin.cheng bin.ch...@arm.com wrote: -Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Monday, September 23, 2013 8:08 PM To: Bin Cheng Cc: GCC Patches Subject: Re: [PATCH]Construct canonical scaled address expression

Re: [PR58463][Backport to 4.8] Adjust dumping for ref nodes

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 10:42 AM, Paulo Matos pma...@broadcom.com wrote: Ping on this patch. Note I don't have write access. Please get yourself write access (I suppose you do have a copyright assignment), you can name me as sponsor. Richard. Paulo Matos -Original Message- From:

Re: [PATCH]Fix computation of offset in ivopt

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 11:13 AM, bin.cheng bin.ch...@arm.com wrote: Hi, This patch fix two minor bugs when computing offset in IVOPT. 1) Considering below example: #define MAX 100 struct tag { int i; int j; } struct tag arr[MAX] int foo (int len) { int i = 0; for (; i len;

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-24 Thread Richard Biener
On Tue, 24 Sep 2013, Richard Biener wrote: On Mon, Sep 23, 2013 at 10:34 PM, Eric Botcazou ebotca...@adacore.com wrote: I have committed it for you (rev 202831), with a few modifications (ChangeLog formatting, typos). Here is what I have committed: 2013-09-23 Kugan Vivekanandarajah

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Richard Earnshaw
On 24/09/13 11:12, Richard Biener wrote: Or even [reg*scale] (not sure about that). But yes, at least reg*scale + offset and reg*scale + reg. I can't conceive of a realistic case where one would want to scale the base address. Scaling the offset is fine, but never the base. So

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Eric Botcazou
Here is the new patch discussed in the other thread. Thanks Yvan 2013-09-11 Yvan Roux yvan.r...@linaro.org Vladimir Makarov vmaka...@redhat.com * rtlanal.c (lsb_bitfield_op_p): New predicate for bitfield operations from the least significant bit.

Re: expand_expr tweaks to fix PR57134

2013-09-24 Thread Alan Modra
On Fri, Sep 13, 2013 at 12:37:20PM +0930, Alan Modra wrote: PR middle-end/57586 * stmt.c (expand_asm_operands): Call expand_expr with EXPAND_MEMORY for output operands that disallow regs. Don't use EXPAND_WRITE on inout operands. Ping? -- Alan Modra Australia

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 12:36 PM, Richard Earnshaw rearn...@arm.com wrote: On 24/09/13 11:12, Richard Biener wrote: Or even [reg*scale] (not sure about that). But yes, at least reg*scale + offset and reg*scale + reg. I can't conceive of a realistic case where one would want to scale the

Re: expand_expr tweaks to fix PR57134

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 12:43 PM, Alan Modra amo...@gmail.com wrote: On Fri, Sep 13, 2013 at 12:37:20PM +0930, Alan Modra wrote: PR middle-end/57586 * stmt.c (expand_asm_operands): Call expand_expr with EXPAND_MEMORY for output operands that disallow regs. Don't use

[PATCH] Refactor type handling in get_alias_set, fix PR58513

2013-09-24 Thread Richard Biener
As noted in PR58513 the alias type comparison in operand_equal_p for MEM_REF and TARGET_MEM_REF is overly restrictive. The following adds a new alias_ptr_types_compatible_p helper for a less conservative comparison and refactors get_alias_set and reference_alias_ptr_type to share code and behave

Re: Ping patch to enable *.cc files in gengtype

2013-09-24 Thread Basile Starynkevitch
On Fri, Sep 20, 2013 at 05:56:22PM +0200, Jakub Jelinek wrote: On Fri, Sep 20, 2013 at 05:52:38PM +0200, Basile Starynkevitch wrote: On Fri, Sep 20, 2013 at 09:53:10AM -0400, Diego Novillo wrote: On 2013-09-16 04:19 , Basile Starynkevitch wrote: Hello all, I'm pinging the patch (of

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Yvan Roux
Hi Eric, Thanks for the review. +/* Return true if X is a sign_extract or zero_extract from the least + significant bit. */ + +static bool +lsb_bitfield_op_p (rtx x) +{ + if (GET_RTX_CLASS (GET_CODE (x)) == RTX_BITFIELD_OPS) +{ + enum machine_mode mode = GET_MODE(x); +

Re: New GCC options for loop vectorization

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 10:37 PM, Xinliang David Li davi...@google.com wrote: Thanks. I modified the patch so that the max allowed peel iterations can be specified via a parameter. Testing on going. Ok for trunk ? +DEFPARAM(PARAM_VECT_MAX_PEELING_FOR_ALIGNMENT, +

Re: [PATCH, PR 57748] Check for out of bounds access

2013-09-24 Thread Richard Biener
On Tue, Sep 17, 2013 at 2:08 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: On Tue, 17 Sep 2013 12:45:40, Richard Biener wrote: On Tue, Sep 17, 2013 at 12:00 PM, Richard Biener richard.guent...@gmail.com wrote: On Sun, Sep 15, 2013 at 6:55 PM, Bernd Edlinger bernd.edlin...@hotmail.de

Re: gimple build interface

2013-09-24 Thread Andrew MacLeod
On 09/24/2013 05:50 AM, Richard Biener wrote: Did you forget to attach the patch? Of course not! :-P Oh how I hate mondays. Old patch attached? Richard. Errr. no. that last one has gimple-builder.[ch] and the ssa_replace_lhs renamed to gimple_replace_ssa_lhs.. I'll also wait

Re: gimple build interface

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 1:31 PM, Andrew MacLeod amacl...@redhat.com wrote: On 09/24/2013 05:50 AM, Richard Biener wrote: Did you forget to attach the patch? Of course not! :-P Oh how I hate mondays. Old patch attached? Richard. Errr. no. that last one has gimple-builder.[ch]

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Bin.Cheng
On Tue, Sep 24, 2013 at 6:12 PM, Richard Biener richard.guent...@gmail.com wrote: On Tue, Sep 24, 2013 at 8:20 AM, bin.cheng bin.ch...@arm.com wrote: -Original Message- Or even [reg*scale] (not sure about that). But yes, at least reg*scale + offset and reg*scale + reg.

[PATCH][RFC] Remove quadratic loop with component_uses_parent_alias_set

2013-09-24 Thread Richard Biener
Eric, the current way component_uses_parent_alias_set is called from get_alias_set causes the reference tree chain to be walked O(n^2) in case there is any DECL_NONADDRESSABLE_P or TYPE_NONALIASED_COMPONENT reference in the tree chain. Also the comment above component_uses_parent_alias_set

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 1:40 PM, Bin.Cheng amker.ch...@gmail.com wrote: On Tue, Sep 24, 2013 at 6:12 PM, Richard Biener richard.guent...@gmail.com wrote: On Tue, Sep 24, 2013 at 8:20 AM, bin.cheng bin.ch...@arm.com wrote: -Original Message- Or even [reg*scale] (not sure about

Re: [Patch] match_results::format and regex_replace

2013-09-24 Thread Ed Smith-Rowland
On 09/23/2013 10:09 PM, Tim Shen wrote: On Sun, Sep 22, 2013 at 4:20 PM, Paolo Carlini paolo.carl...@oracle.com wrote: If testing goes well patch is Ok to commit. Tested under -m32 and -m64 and committed :) I'll learn how locale in glibc works. Thank you all! Thank *you*! regex has been

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-09-24 Thread Jan Hubicka
Hi Honza, I am finally getting back to working on this after a few weeks of working on some other priorities. I am also trying to return to this, so good timming ;) Martin has got smaller C++ programs (Inkscape) to not touch cold segment during the startup with FDO (w/o partitioning).

Re: [PATCH] Fix typo in check for null

2013-09-24 Thread Marek Polacek
On Mon, Sep 23, 2013 at 02:03:02PM +, Paulo Matos wrote: This is a patch for master, where in number_of_loops, we want to check if the loops (returned by loops_for_fn) is non-null but instead we are using fn, which is the function argument. I haven't opened a bug report, please let me

Re: [PATCH][ARM][testsuite] Add effective target check for arm conditional execution

2013-09-24 Thread Kyrill Tkachov
On 13/09/13 16:25, Kyrill Tkachov wrote: Hi all, gcc.target/arm/minmax_minus.c is really only valid when we have conditional execution available, that is non Thumb1-only targets. I've added an effective target check for that and used it in the test so that it does not get run and give a false

Re: patch to canonize small wide-ints.

2013-09-24 Thread Richard Biener
On Tue, 17 Sep 2013, Kenneth Zadeck wrote: Richi, This patch canonizes the bits above the precision for wide ints with types or modes that are not a perfect multiple of HOST_BITS_PER_WIDE_INT. I expect that most of the changes in rtl.h will go away. in particular, when we decide that

RE: [PATCH] Fix typo in check for null

2013-09-24 Thread Paulo Matos
-Original Message- From: Marek Polacek [mailto:pola...@redhat.com] Sent: 24 September 2013 13:57 To: Paulo Matos Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix typo in check for null On Mon, Sep 23, 2013 at 02:03:02PM +, Paulo Matos wrote: This is a patch for master,

RE: [PATCH] Fix typo in check for null

2013-09-24 Thread Paulo Matos
-Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: 24 September 2013 10:03 To: Paulo Matos Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix typo in check for null On Mon, Sep 23, 2013 at 4:03 PM, Paulo Matos pma...@broadcom.com wrote: This is

Re: patch to canonize small wide-ints.

2013-09-24 Thread Richard Biener
On Tue, 24 Sep 2013, Kenneth Zadeck wrote: On 09/24/2013 09:39 AM, Richard Biener wrote: On Tue, 17 Sep 2013, Kenneth Zadeck wrote: Richi, This patch canonizes the bits above the precision for wide ints with types or modes that are not a perfect multiple of

Re: [PATCH] Fix typo in check for null

2013-09-24 Thread Marek Polacek
On Tue, Sep 24, 2013 at 01:44:30PM +, Paulo Matos wrote: Thanks for the comments Marek, will fix it. 2013-09-24 Paulo Matos pma...@broadcom.com ^^ Two spaces between name and e-mail. Sorry for nitpicking like this. Thanks! Marek

Re: patch to canonize small wide-ints.

2013-09-24 Thread Kenneth Zadeck
On 09/24/2013 09:39 AM, Richard Biener wrote: On Tue, 17 Sep 2013, Kenneth Zadeck wrote: Richi, This patch canonizes the bits above the precision for wide ints with types or modes that are not a perfect multiple of HOST_BITS_PER_WIDE_INT. I expect that most of the changes in rtl.h will go

Re: patch to canonize small wide-ints.

2013-09-24 Thread Kenneth Zadeck
On 09/24/2013 09:51 AM, Richard Biener wrote: On Tue, 24 Sep 2013, Kenneth Zadeck wrote: On 09/24/2013 09:39 AM, Richard Biener wrote: On Tue, 17 Sep 2013, Kenneth Zadeck wrote: Richi, This patch canonizes the bits above the precision for wide ints with types or modes that are not a

RE: [PATCH] Fix typo in check for null

2013-09-24 Thread Paulo Matos
-Original Message- From: Marek Polacek [mailto:pola...@redhat.com] Sent: 24 September 2013 14:52 To: Paulo Matos Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix typo in check for null On Tue, Sep 24, 2013 at 01:44:30PM +, Paulo Matos wrote: Thanks for the comments

Re: [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-09-24 Thread Eric Botcazou
Index: gcc/expr.c === --- gcc/expr.c (revision 202778) +++ gcc/expr.c (working copy) @@ -9878,7 +9878,7 @@ modifier != EXPAND_STACK_PARM ? target : NULL_RTX),

Re: [patch, libgfortran, configure] Cross-compile support for libgfortran

2013-09-24 Thread Richard Earnshaw
On 23/09/13 18:43, Steve Ellcey wrote: On Mon, 2013-09-23 at 16:26 +0100, Marcus Shawcroft wrote: On 4 June 2013 20:49, Steve Ellcey sell...@mips.com wrote: This patch allows me to build libgfortran for a cross-compiling toolchain using newlib. Currently the checks done by AC_CHECK_FUNCS_ONCE

[PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Yvan Roux
Hi, This patch removes REG_DEAD and REG_UNUSED notes in update_inc_notes, as it is what the function is supposed to do (see the comments) and as keeping these notes produce some failures, at least on ARM. Thanks, Yvan 2013-09-24 Yvan Roux yvan.r...@linaro.org * lra.c

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Eric Botcazou
Indeed, I think it has to be the mode of loc, but I just wonder if it is not always the same, as in the doc it is written that mode m is the same as the mode that would be used for loc if it were a register. So can we assert that we have a REG here and use GET_MODE (XEXP (x, 0))? Or else

Re: [PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Eric Botcazou
This patch removes REG_DEAD and REG_UNUSED notes in update_inc_notes, as it is what the function is supposed to do (see the comments) and as keeping these notes produce some failures, at least on ARM. The description is too terse. In the RTL middle-end, you shouldn't have to manually deal

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Yvan Roux
So can we assert that we have a REG here and use GET_MODE (XEXP (x, 0))? Or else return false if we don't have a REG. I'm currently testing the patch with the modification below +static bool +lsb_bitfield_op_p (rtx x) +{ + if (GET_RTX_CLASS (GET_CODE (x)) == RTX_BITFIELD_OPS) +{ +

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Eric Botcazou
Sorry, I'm not sure I understand well, it means that you prefer the shift_and _rotate_code_p notation, right ? Let's do the following in addition to the lsb_bitfield_op_p thing: 1. Replace the LO_SUM test in set_address_base by a call to must_be_base_p, 2. Replace the MULT || ASHIFT test in

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-09-24 Thread Andrew MacLeod
On 09/16/2013 10:42 AM, Andrew MacLeod wrote: On 09/16/2013 04:55 AM, Richard Biener wrote: On Fri, Sep 13, 2013 at 9:15 PM, Andrew MacLeod amacl...@redhat.com wrote: OK, a slightly different take.. I realized that I should be adding tree-outof-ssa.h to handle the 3 exports from

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-24 Thread Christophe Lyon
On 23 September 2013 22:34, Eric Botcazou ebotca...@adacore.com wrote: Nice patch, but the formatting is totally wrong wrt spaces, please reformat using 2-space indentation and 8-space TABs, as already used in the files. Sorry for missing this problem when committing Kugan's patch. I have

Re: patch to canonize small wide-ints.

2013-09-24 Thread Richard Sandiford
Richard Biener rguent...@suse.de writes: On Tue, 24 Sep 2013, Kenneth Zadeck wrote: On 09/24/2013 09:39 AM, Richard Biener wrote: On Tue, 17 Sep 2013, Kenneth Zadeck wrote: Richi, This patch canonizes the bits above the precision for wide ints with types or modes that

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Yvan Roux
Thanks Eric, here is the new patch, validation is ongoing for ARM. Yvan 2013-09-24 Yvan Roux yvan.r...@linaro.org Vladimir Makarov vmaka...@redhat.com * rtlanal.c (lsb_bitfield_op_p): New predicate for bitfield operations from the least significant bit.

Re: [v3] More noexcept -- 6th

2013-09-24 Thread Paolo Carlini
Hi, On 9/24/13 11:13 AM, Marc Glisse wrote: Hello, bootstrap+testsuite ok. I think all container iterators are done, but not the containers themselves. Ok, thanks. Paolo.

[PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Marek Polacek
I admit I haven't spent much time on this, but it seems we should just check whether we can set the expr location before actually setting it... Regtested/bootstrapped on x86_64-linux, ok for trunk? 2013-09-24 Marek Polacek pola...@redhat.com PR c++/58516 cp/ * semantics.c

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Richard Sandiford
Eric Botcazou ebotca...@adacore.com writes: Sorry, I'm not sure I understand well, it means that you prefer the shift_and _rotate_code_p notation, right ? Let's do the following in addition to the lsb_bitfield_op_p thing: 1. Replace the LO_SUM test in set_address_base by a call to

Re: [PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Yvan Roux
The description is too terse. In the RTL middle-end, you shouldn't have to manually deal with the REG_DEAD and REG_UNUSED notes (unlike REG_EQUAL and REG_EQUIV notes), as the DF framework is supposed to do it for you. Sorry, for that. The description of the LRA function update_inc_notes

Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Paolo Carlini
Hi, On 9/24/13 11:35 AM, Marek Polacek wrote: I admit I haven't spent much time on this, but it seems we should just check whether we can set the expr location before actually setting it... Regtested/bootstrapped on x86_64-linux, ok for trunk? Two minor nits (assuming the general idea makes

Re: [PATCH i386 3/8] [AVX512] [1/n] Add AVX-512 patterns: VF iterator extended.

2013-09-24 Thread Richard Henderson
On 08/27/2013 11:37 AM, Kirill Yukhin wrote: Hello, This patch is still far too large. I think you should split it up based on every single mode iterator that you need to add or change. Problem is that some iterators are depend on each other, so patches are not going to be tiny. Here

Re: [PATCH][ARM][testsuite] Add effective target check for arm conditional execution

2013-09-24 Thread Mike Stump
On Sep 13, 2013, at 8:25 AM, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: gcc.target/arm/minmax_minus.c is really only valid when we have conditional execution available, that is non Thumb1-only targets. I've added an effective target check for that and used it in the test so that it does not

wide-int: Re: patch to canonize small wide-ints.

2013-09-24 Thread Kenneth Zadeck
I just committed the patch to do this as revision 202871. there are two changes from the earlier patch: 1) the addition of frag in loop-doloop.c. This fixes an rtl canonization bug, but it is unique to the branch. it did not cause a problem on x86 but did on ppc. 2) the code in rtl.h for

Re: RFA: Store the REG_BR_PROB probability directly as an int

2013-09-24 Thread Richard Sandiford
Andreas Schwab sch...@suse.de writes: Richard Sandiford rdsandif...@googlemail.com writes: REG_BR_PROB notes are stored as: (expr_list:REG_BR_PROB (const_int prob) chain) but a full const_int rtx seems a bit heavweight when all we want is a plain int. This patch uses:

Re: [PATCH]Fix computation of offset in ivopt

2013-09-24 Thread Oleg Endo
On Tue, 2013-09-24 at 12:31 +0200, Richard Biener wrote: On Tue, Sep 24, 2013 at 11:13 AM, bin.cheng bin.ch...@arm.com wrote: Hi, This patch fix two minor bugs when computing offset in IVOPT. 1) Considering below example: #define MAX 100 struct tag { int i; int j; } struct

[PATCH v2 1/4] Ignore access-control keywords when parsing fields.

2013-09-24 Thread David Malcolm
Classes containing access-control keywords such as public: confuse struct_field_seq, leading it to call consume_until_eos i.e. ignore text until after the next semicolon. This leads to the first field after an access-control keyword being ignored by gengtype. This can be seen in:

[PATCH v2 0/4] Support some cases of inheritance in gengtype

2013-09-24 Thread David Malcolm
Here's an updated version of the patch series. Changes since v1 of the patch series: * Patch 1/4: this one is new: I noticed that the public: specifier within class cgraph_node confused gengtype, leading it to erroneously omit the first field within the class. This patch fixes this

[PATCH v2 4/4] Add documentation about gengtype and inheritance

2013-09-24 Thread David Malcolm
gcc/ * doc/gty.texi (GTY Options): Add note about inheritance to description of desc and tag. (Inheritance and GTY): New. --- gcc/doc/gty.texi | 52 1 file changed, 52 insertions(+) diff --git a/gcc/doc/gty.texi

[PATCH v2 2/4] Parse base classes for GTY-marked types

2013-09-24 Thread David Malcolm
Extend gengtype (and gtype.state reading/writing) so that it is able to parse base classes in simple cases, and only attempt to do it for GTY-marked types. * gengtype-parse.c (require_without_advance): New. (type): For GTY-marked types that are not GTY((user)), parse any

[PATCH v2 3/4] Handle simple inheritance in gengtype.

2013-09-24 Thread David Malcolm
Treat GTY structs that have a desc as being the root of an inheritance hierarchy. Generate a switch on desc within the marking function with cases for each subclass, visiting all fields of the type (including inherited ones). Don't create marking functions for subclasses, instead using the base

Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Marek Polacek
On Tue, Sep 24, 2013 at 12:00:41PM -0500, Paolo Carlini wrote: Hi, On 9/24/13 11:35 AM, Marek Polacek wrote: I admit I haven't spent much time on this, but it seems we should just check whether we can set the expr location before actually setting it... Regtested/bootstrapped on

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-09-24 Thread Jan Hubicka
I looked at one that failed after 100 as well (20031204-1.c). In this case, it was due to expansion which was creating multiple branches/bbs from a logical OR and guessing incorrectly on how to assign the counts: if (octets == 4 (*cp == ':' || *cp == '\0')) { The (*cp == ':' || *cp

Re: [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-09-24 Thread Martin Jambor
Hi, On Tue, Sep 24, 2013 at 12:02:17PM +0200, Richard Biener wrote: On Tue, Sep 24, 2013 at 4:52 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, with the attached patch the read-side of the out of bounds accesses are fixed. There is a single new test case pr57748-3.c that is

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-09-24 Thread Teresa Johnson
On Tue, Sep 24, 2013 at 10:57 AM, Jan Hubicka hubi...@ucw.cz wrote: I looked at one that failed after 100 as well (20031204-1.c). In this case, it was due to expansion which was creating multiple branches/bbs from a logical OR and guessing incorrectly on how to assign the counts: if

[wwwdocs] svnwrite.html -- extend documentation of gcc.gnu.org accounts

2013-09-24 Thread Gerald Pfeifer
Caroline made me realize that we should improve our documentation around gcc.gnu.org accounts. This is a first step in that direction. (As a side effect, wrap the e-mail address in div/div to avoid undesired line breaks.) Applied. Gerald Index: svnwrite.html

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-09-24 Thread Teresa Johnson
Rong - can you answer the questions below on the comdat patch? On Tue, Sep 24, 2013 at 5:31 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi Honza, I am finally getting back to working on this after a few weeks of working on some other priorities. I am also trying to return to this, so good

Re: [PATCH]: Fix use of __builtin_eh_pointer in EH_ELSE

2013-09-24 Thread Richard Henderson
On 09/03/2013 07:08 AM, Tristan Gingold wrote: Hi, The field state-ehp_region wasn't updated before lowering constructs in the eh path of EH_ELSE. As a consequence, __builtin_eh_pointer is lowered to 0 (or possibly to a wrong region number) in this path. The only user of EH_ELSE looks

Re: [PATCH 0/3] Support some cases of inheritance in gengtype; use it for symtab

2013-09-24 Thread David Malcolm
On Mon, 2013-09-23 at 13:19 +0200, Richard Biener wrote: On Fri, Sep 20, 2013 at 4:05 PM, David Malcolm dmalc...@redhat.com wrote: There have been various discussions about how to handle inheritance within ggc and PCH: whether to extend gengtype to support C++ syntax such as templates, or

Re: [PATCH] Refactor type handling in get_alias_set, fix PR58513

2013-09-24 Thread H.J. Lu
On Tue, Sep 24, 2013 at 4:00 AM, Richard Biener rguent...@suse.de wrote: As noted in PR58513 the alias type comparison in operand_equal_p for MEM_REF and TARGET_MEM_REF is overly restrictive. The following adds a new alias_ptr_types_compatible_p helper for a less conservative comparison and

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-24 Thread Wei Mi
This is the updated patch2. Changed: 1. For cmp/test with rip-relative addressing mem operand, don't group insns. Bulldozer also doesn't support fusion for cmp/test with both displacement MEM and immediate operand, while m_CORE_ALL doesn't support fusion for cmp/test with MEM and immediate

Re: RFA: Store the REG_BR_PROB probability directly as an int

2013-09-24 Thread Andreas Schwab
Richard Sandiford rdsandif...@googlemail.com writes: Sorry for the breakage. I think we need to handle INT_LIST in the same way as INSN_LIST though, and eliminate in XEXP (x, 1). How about the attached? Testing in progress... Works for me as well. Andreas. -- Andreas Schwab,

[gomp4] Taskgroup and cancellation compiler fixes

2013-09-24 Thread Jakub Jelinek
Hi! This patch: 1) defers expansion of taskgroup into GOMP_taskgroup_start and GOMP_taskgroup_end until omplower/ompexp, mainly so that e.g. invalid nesting can be diagnosed (e.g. #pragma omp cancel * inside of #pragma omp taskgroup nested in some other construct) 2) diagnoses structured

[gomp4] Taskgroup library support

2013-09-24 Thread Jakub Jelinek
Hi! This implements taskgroups in the library and their cancellation. The implementation has been pretty straightforward, though I had to consolidate some operations from {gomp_barrier_handle_tasks, GOMP_taskwait} and the new GOMP_taskgroup_end to new inlines, because it became non-maintainable.

Re: [PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Steven Bosscher
On Tue, Sep 24, 2013 at 5:03 PM, Eric Botcazou wrote: This patch removes REG_DEAD and REG_UNUSED notes in update_inc_notes, as it is what the function is supposed to do (see the comments) and as keeping these notes produce some failures, at least on ARM. The description is too terse. In the

[PATCH, PR 58441] Fix location where libvtv puts its headers

2013-09-24 Thread Caroline Tice
The following patch updates where libvtv installs its header files (fixing PR 58441). This is a trivial change, and affects only libvtv, so I am going to go ahead and commit it. -- Caroline Tice cmt...@google.com 2013-09-24 Caroline Tice cmt...@google.com * Makefile.am: Change

Re: [PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Mike Stump
On Sep 24, 2013, at 12:23 PM, Steven Bosscher stevenb@gmail.com wrote: On Tue, Sep 24, 2013 at 5:03 PM, Eric Botcazou wrote: This patch removes REG_DEAD and REG_UNUSED notes DF framework is supposed to do it for you. Unfortunately LRA uses its own DF framework. Is that a bug, or a

Re: [PATCH] Bug fix: *var and MEM[(const int *)var] (var has int* type) are not treated as the same data ref.

2013-09-24 Thread Cong Hou
Nice fix! I noticed that this patch is already combined to the trunk. Thank you very much, Richard! Cong On Tue, Sep 24, 2013 at 1:49 AM, Richard Biener rguent...@suse.de wrote: On Tue, 24 Sep 2013, Richard Biener wrote: On Tue, 24 Sep 2013, Jakub Jelinek wrote: Hi! On Mon, Sep 23,

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #3

2013-09-24 Thread Michael Meissner
This patch adds the initial support for putting DI, DF, and SF values in the upper registers (traditional Altivec registers) using the -mupper-regs-df and -mupper-regs-sf patches. Those switches will not be enabled by default until the rest of the changes are made. This patch passes the

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-24 Thread H.J. Lu
On Tue, Sep 24, 2013 at 12:06 PM, Wei Mi w...@google.com wrote: This is the updated patch2. Changed: 1. For cmp/test with rip-relative addressing mem operand, don't group insns. Bulldozer also doesn't support fusion for cmp/test with both displacement MEM and immediate operand, while

Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Jason Merrill
OK. Jason

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-24 Thread Jan Hubicka
+ gcc_assert (ok); + base = parts.base; + index = parts.index; + disp = parts.disp; + + if (TARGET_64BIT !base !index) +{ + rtx symbol = disp; + + if (GET_CODE (disp) == CONST + GET_CODE (XEXP (disp, 0)) == PLUS + CONST_INT_P (XEXP

  1   2   >