RE: [PATCH GCC]Simplify address expression in IVOPT

2013-11-04 Thread bin.cheng
-Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Wednesday, October 30, 2013 10:46 PM To: Bin Cheng Cc: GCC Patches Subject: Re: [PATCH GCC]Simplify address expression in IVOPT On Tue, Oct 29, 2013 at 10:18 AM, bin.cheng bin.ch...@arm.com wrote:

Re: [wide-int] Update main comment

2013-11-04 Thread Richard Biener
On Wed, 30 Oct 2013, Richard Sandiford wrote: Kenneth Zadeck zad...@naturalbridge.com writes: On 10/30/2013 07:01 AM, Richard Sandiford wrote: Kenneth Zadeck zad...@naturalbridge.com writes: On 10/29/2013 06:37 PM, Richard Sandiford wrote: This patch tries to update the main wide_int

[wide-int] Fix UNSIGNED_FIX typo

2013-11-04 Thread Richard Sandiford
t had got switched to x during the conversion. This showed up in one of the alpha g++.dg tests. Applied as obvious. Richard Index: gcc/simplify-rtx.c === --- gcc/simplify-rtx.c 2013-11-03 13:01:39.083385620 + +++

[wide-int] Make integer_onep return false for signed 1-bit bitfields

2013-11-04 Thread Richard Sandiford
As discussed on gcc@, integer_onep is supposed to return false for a nonzero 1-bit value if the type is signed. Tested on x86_64-linux-gnu and powerpc64-linux-gnu. OK to install? Thanks, Richard Index: gcc/tree.c === ---

Re: [wide-int] Avoid some changes in output code

2013-11-04 Thread Richard Biener
On Mon, 4 Nov 2013, Richard Biener wrote: On Fri, 1 Nov 2013, Richard Sandiford wrote: I'm building one target for each supported CPU and comparing the wide-int assembly output of gcc.c-torture, gcc.dg and g++.dg with the corresponding output from the merge point. This patch removes all

Re: [wide-int] Avoid some changes in output code

2013-11-04 Thread Richard Sandiford
Richard Biener rguent...@suse.de writes: On Fri, 1 Nov 2013, Richard Sandiford wrote: I'm building one target for each supported CPU and comparing the wide-int assembly output of gcc.c-torture, gcc.dg and g++.dg with the corresponding output from the merge point. This patch removes all the

Re: [wide-int] Avoid some changes in output code

2013-11-04 Thread Richard Sandiford
Richard Biener rguent...@suse.de writes: On Mon, 4 Nov 2013, Richard Biener wrote: On Fri, 1 Nov 2013, Richard Sandiford wrote: I'm building one target for each supported CPU and comparing the wide-int assembly output of gcc.c-torture, gcc.dg and g++.dg with the corresponding output

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-04 Thread Jan Hubicka
Thanks! Can you attach the patch file for the proposed change? David On Fri, Nov 1, 2013 at 2:08 PM, Rong Xu x...@google.com wrote: libgcov.c is the main file to generate libgcov.a. This single source generates 21 object files and then archives to a library. These objects are of

Re: [PATCH 1/n] Add conditional compare support

2013-11-04 Thread Joey Ye
+ TARGET_ARM || TARGET_THUMB2 TARGET_32BIT +static const char *const ite = it\t%d4; +static const int cmp_idx[9] = {0, 0, 1, 0, 1}; s/9/5/ On Wed, Oct 30, 2013 at 5:32 PM, Zhenqiang Chen zhenqiang.c...@arm.com wrote: -Original Message- From: Richard Henderson

Re: [wide-int] Avoid some changes in output code

2013-11-04 Thread Richard Biener
On Mon, 4 Nov 2013, Richard Sandiford wrote: Richard Biener rguent...@suse.de writes: On Fri, 1 Nov 2013, Richard Sandiford wrote: I'm building one target for each supported CPU and comparing the wide-int assembly output of gcc.c-torture, gcc.dg and g++.dg with the corresponding output

RE: [PATCH 1/n] Add conditional compare support

2013-11-04 Thread Zhenqiang Chen
-Original Message- From: Richard Henderson [mailto:r...@redhat.com] Sent: Friday, November 01, 2013 12:27 AM To: Zhenqiang Chen Cc: Richard Earnshaw; 'Richard Biener'; GCC Patches Subject: Re: [PATCH 1/n] Add conditional compare support On 10/31/2013 02:06 AM, Zhenqiang Chen

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-11-04 Thread James Greenhalgh
On Fri, Nov 01, 2013 at 04:48:53PM +, Cong Hou wrote: diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi index 2a5a2e1..8f5d39a 100644 --- a/gcc/doc/md.texi +++ b/gcc/doc/md.texi @@ -4705,6 +4705,16 @@ wider mode, is computed and added to operand 3. Operand 3 is of a mode equal or wider

Re: [wide-int] Avoid some changes in output code

2013-11-04 Thread Richard Biener
On Mon, 4 Nov 2013, Richard Sandiford wrote: Richard Biener rguent...@suse.de writes: On Mon, 4 Nov 2013, Richard Biener wrote: On Fri, 1 Nov 2013, Richard Sandiford wrote: I'm building one target for each supported CPU and comparing the wide-int assembly output of gcc.c-torture,

Re: [PATCH] Fix up reassoc (PR tree-optimization/58946)

2013-11-04 Thread Richard Biener
On Fri, 1 Nov 2013, Jakub Jelinek wrote: Hi! My recent reassoc patch caused following regression (though, it only started failing on this testcase with Andrew's ifcombine changes). The issue is that update_ops relies on walking the same stmts as get_ops did, and uses has_single_uses

PATCH: middle-end/58981: movmem/setmem use mode wider than Pmode for size

2013-11-04 Thread H.J. Lu
emit_block_move_via_movmem and set_storage_via_setmem have for (mode = GET_CLASS_NARROWEST_MODE (MODE_INT); mode != VOIDmode; mode = GET_MODE_WIDER_MODE (mode)) { enum insn_code code = direct_optab_handler (movmem_optab, mode); if (code != CODE_FOR_nothing /*

Re: RFC: simd enabled functions (omp declare simd / elementals)

2013-11-04 Thread Richard Biener
On Fri, Nov 1, 2013 at 4:04 AM, Aldy Hernandez al...@redhat.com wrote: Hello gentlemen. I'm CCing all of you, because each of you can provide valuable feedback to various parts of the compiler which I touch. I have sprinkled love notes with your names throughout the post :). This is a patch

Re: [PATCH] Time profiler - phase 1

2013-11-04 Thread Jan Hubicka
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index fca665b..3b62bcc 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,31 @@ +2013-10-29 Martin Liska marxin.li...@gmail.com + Jan Hubicka j...@suse.cz + + * cgraph.c

Re: [PATCH, MPX, 2/X] Pointers Checker [8/25] Languages support

2013-11-04 Thread Richard Biener
On Thu, Oct 31, 2013 at 10:11 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch adds support Pointer Bounds Checker into c-family and LTO front-ends. The main purpose of changes in front-end is to register all statically initialized objects for checker. We also need to

Re: PR 58958: wrong aliasing info

2013-11-04 Thread Richard Biener
On Fri, Nov 1, 2013 at 11:39 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, the issue was described in the PR and the message linked from there. ao_ref_init_from_ptr_and_size calls get_ref_base_and_extent, which may detect an array_ref of variable index, but ao_ref_init_from_ptr_and_size

Re: RFC: simd enabled functions (omp declare simd / elementals)

2013-11-04 Thread Jakub Jelinek
Hi! On Mon, Nov 04, 2013 at 11:37:19AM +0100, Richard Biener wrote: Just a quick question, queueing the thread for later review (aww, queue back at 100 threads again - I can't get any work done anymore :(). What does #pragma omp declare simd guarantee about memory side-effects and memory

Re: Expect JUMP_TABLE_DATA in NEXT_INSN(label)

2013-11-04 Thread Richard Biener
On Sat, Nov 2, 2013 at 1:45 AM, Steven Bosscher stevenb@gmail.com wrote: Hello, As $SUBJECT. The assert for this has been in place for several months now without triggering any issues, so I'd like to make this next step before stage1 is over. OK for trunk? Ok. Can you verify this from

Re: PR 58958: wrong aliasing info

2013-11-04 Thread Marc Glisse
On Mon, 4 Nov 2013, Richard Biener wrote: On Fri, Nov 1, 2013 at 11:39 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, the issue was described in the PR and the message linked from there. ao_ref_init_from_ptr_and_size calls get_ref_base_and_extent, which may detect an array_ref of variable

Re: PATCH: middle-end/58981: movmem/setmem use mode wider than Pmode for size

2013-11-04 Thread Richard Sandiford
H.J. Lu hongjiu...@intel.com writes: emit_block_move_via_movmem and set_storage_via_setmem have for (mode = GET_CLASS_NARROWEST_MODE (MODE_INT); mode != VOIDmode; mode = GET_MODE_WIDER_MODE (mode)) { enum insn_code code = direct_optab_handler (movmem_optab, mode);

Re: PR 58958: wrong aliasing info

2013-11-04 Thread Marc Glisse
On Mon, 4 Nov 2013, Richard Biener wrote: On Mon, Nov 4, 2013 at 11:55 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, Nov 1, 2013 at 11:39 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, the issue was described in the PR and the message linked from there.

Re: [wide-int] Do not treat rtxes as sign-extended

2013-11-04 Thread Richard Biener
On Sat, Nov 2, 2013 at 3:25 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Kenneth Zadeck zad...@naturalbridge.com writes: On 11/02/2013 06:30 AM, Richard Sandiford wrote: Bah. After all that effort, it turns out that -- by design -- there is one special case where CONST_INTs are not

[C++ PATCH] Fix PR58979

2013-11-04 Thread Marek Polacek
Even RO_ARROW_STAR can end up in invalid_indirection_error in invalid code, so handle that instead of ICEing later on. Regtested/bootstrapped on x86_64-linux, ok for trunk and 4.8? 2013-11-04 Marek Polacek pola...@redhat.com PR c++/58979 c-family/ * c-common.c

Re: [wide-int] Simplify some force_fit_type calls

2013-11-04 Thread Richard Biener
On Sun, Nov 3, 2013 at 11:31 AM, Richard Sandiford rdsandif...@googlemail.com wrote: When going through force_fit_type calls to see whether they were extending correctly, I noticed some of the calls in VRP could be simplified. There's no change in behaviour, it's just shorter and more

Re: PATCH: middle-end/58981: movmem/setmem use mode wider than Pmode for size

2013-11-04 Thread H.J. Lu
Y On Mon, Nov 4, 2013 at 3:11 AM, Richard Sandiford rsand...@linux.vnet.ibm.com wrote: H.J. Lu hongjiu...@intel.com writes: emit_block_move_via_movmem and set_storage_via_setmem have for (mode = GET_CLASS_NARROWEST_MODE (MODE_INT); mode != VOIDmode; mode = GET_MODE_WIDER_MODE (mode))

Re: [PATCH GCC]Compute, cache and use cost of auto-increment rtx patterns in IVOPT

2013-11-04 Thread Richard Biener
On Mon, Nov 4, 2013 at 4:31 AM, bin.cheng bin.ch...@arm.com wrote: Hi, The IVOPT in GCC has a problem that it does not use cost of auto-increment address expression in accounting, while it retreats to cost of address expression if auto-increment addressing mode is unavailable. For example,

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-11-04 Thread Dodji Seketeli
Jakub Jelinek ja...@redhat.com writes: I think even as a fallback is the patch too expensive. I'd say best would be to write some getline API compatible function and just use it, using fread on say fixed size buffer. OK, thanks for the insight. I have just used the getline_fallback function

Re: Patch RFA: With -fnon-call-exceptions sync builtins may throw

2013-11-04 Thread Richard Biener
On Mon, Nov 4, 2013 at 7:01 AM, Ian Lance Taylor i...@google.com wrote: The middle-end currently marks all the sync builtins as nothrow. That is incorrect for most of them when using -fnon-call-exceptions. The -fnon-call-exceptions option means that instructions that trap may throw

Re: PR 58958: wrong aliasing info

2013-11-04 Thread Richard Biener
On Mon, Nov 4, 2013 at 12:18 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 4 Nov 2013, Richard Biener wrote: On Mon, Nov 4, 2013 at 11:55 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, Nov 1, 2013 at 11:39 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, the issue

RE: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-11-04 Thread Bernd Edlinger
Hi, I see another read_line at gcov.c, which seems to be a copy. Maybe this should be changed too? What do you think? Bernd. On Mon, 4 Nov 2013 12:46:10, Dodji Seketeli wrote: Jakub Jelinek ja...@redhat.com writes: I think even as a fallback is the patch too expensive. I'd say best

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-11-04 Thread Jakub Jelinek
On Mon, Nov 04, 2013 at 12:59:49PM +0100, Bernd Edlinger wrote: I see another read_line at gcov.c, which seems to be a copy. Copy of what? gcov.c read_line hardly can be allowed to fail because out of mem unlike this one for caret diagnostics. Though, surely, this one could be somewhat adjusted

RE: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-11-04 Thread Bernd Edlinger
On Mon, Nov 04, 2013 at 12:59:49PM +0100, Bernd Edlinger wrote: I see another read_line at gcov.c, which seems to be a copy. Copy of what? gcov.c read_line hardly can be allowed to fail because out of mem unlike this one for caret diagnostics. Though, surely, this one could be somewhat

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-11-04 Thread Richard Biener
On Wed, Oct 30, 2013 at 5:20 PM, Jeff Law l...@redhat.com wrote: On 10/30/13 04:34, Ilya Enkovich wrote: On 30 Oct 10:26, Richard Biener wrote: Ick - you enlarge all return statements? But you don't set the actual value? So why allocate it with 2 ops in the first place?? When return

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-11-04 Thread Richard Biener
On Wed, Oct 30, 2013 at 6:40 PM, Jeff Law l...@redhat.com wrote: On 10/30/13 04:48, Richard Biener wrote: foo (int * p, unsigned int size) { unnamed type __bound_tmp.0; long unsigned int D.2239; long unsigned int _2; sizetype _6; int * _7; bb 3: __bound_tmp.0_4 =

Re: PATCH to use -Wno-format during stage1

2013-11-04 Thread Richard Biener
On Wed, Oct 30, 2013 at 8:55 PM, Ian Lance Taylor i...@google.com wrote: On Wed, Oct 30, 2013 at 8:47 AM, Jason Merrill ja...@redhat.com wrote: I find -Wformat warnings about unknown % codes when building with an older GCC to be mildly annoying noise; this patch avoids them by passing

Re: [PATCH][RFA] Improvements to infer_nonnull_range

2013-11-04 Thread Richard Biener
On Thu, Oct 31, 2013 at 6:41 AM, Jeff Law l...@redhat.com wrote: On 10/28/13 23:02, Jeff Law wrote: Based on a suggestion from Marc, I want to use infer_nonnull_range in the erroneous path isolation optimization. In the process of doing that, I found a few deficiencies in

Re: [PATCH GCC]Compute, cache and use cost of auto-increment rtx patterns in IVOPT

2013-11-04 Thread Bin.Cheng
On Mon, Nov 4, 2013 at 7:38 PM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Nov 4, 2013 at 4:31 AM, bin.cheng bin.ch...@arm.com wrote: Hi, The IVOPT in GCC has a problem that it does not use cost of auto-increment address expression in accounting, while it retreats to cost of

Re: PATCH: middle-end/58981: movmem/setmem use mode wider than Pmode for size

2013-11-04 Thread H.J. Lu
On Mon, Nov 4, 2013 at 3:34 AM, H.J. Lu hjl.to...@gmail.com wrote: Y On Mon, Nov 4, 2013 at 3:11 AM, Richard Sandiford rsand...@linux.vnet.ibm.com wrote: H.J. Lu hongjiu...@intel.com writes: emit_block_move_via_movmem and set_storage_via_setmem have for (mode = GET_CLASS_NARROWEST_MODE

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-11-04 Thread Andrew MacLeod
On 11/01/2013 06:42 PM, David Malcolm wrote: ! gimple_statement_call *call; ! call = gimple_build_call_vec (build_fold_addr_expr_loc (0, alias), vargs); gimple_call_set_lhs (call, atree); that is looking much better :-) I'd love to make use of compile-time type-safety

[Patch, avr] Emit diagnostics if -f{pic,PIC,pie,PIE} or -shared is passed

2013-11-04 Thread Senthil Kumar Selvaraj
The AVR backend does not generate position independent code, yet it happily accepts -fpic, -fPIC, -fpie and -fPIE. The generated code doesn't change at all. Also, it accepts the -shared option to generate a shared library, without really doing anything with it. This causes one of the regression

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-04 Thread Richard Biener
On Thu, Oct 31, 2013 at 7:11 AM, Jeff Law l...@redhat.com wrote: I've incorporated the various suggestions from Marc and Richi, except for Richi's to integrate this into jump threading. I've also made the following changes since the last version: 1. Added more testcases. 2. Use

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-11-04 Thread Andrew MacLeod
On 11/01/2013 06:58 PM, David Malcolm wrote: On Fri, 2013-11-01 at 22:57 +0100, Jakub Jelinek wrote: On Fri, Nov 01, 2013 at 05:47:14PM -0400, Andrew MacLeod wrote: On 11/01/2013 05:41 PM, Jakub Jelinek wrote: On Fri, Nov 01, 2013 at 05:36:34PM -0400, Andrew MacLeod wrote: static inline

Re: Pre-Patch RFC: proposed changes to option-lookup

2013-11-04 Thread Richard Biener
On Wed, Oct 30, 2013 at 11:56 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 30 Oct 2013, David Malcolm wrote: My idea is to introduce a GCC_OPTION macro, and replace the above with: static bool gate_vrp (void) { return GCC_OPTION (flag_tree_vrp) != 0; } That's

[PATCH, rs6000] Fix vect_pack_trunc_v2df pattern for little endian

2013-11-04 Thread Bill Schmidt
Hi, This cleans up another case where a vector-pack operation needs to reverse its operand order for little endian. This fixes the last remaining vector test failure in the test suite when building for little endian. Next I'll be spending some time looking for additional little endian issues

Re: [PATCH, MPX, 2/X] Pointers Checker [7/25] Suppress BUILT_IN_CHKP_ARG_BND optimizations.

2013-11-04 Thread Richard Biener
On Thu, Oct 31, 2013 at 10:02 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, Here is a patch which hadles the problem with optimization of BUILT_IN_CHKP_ARG_BND calls. Pointer Bounds Checker expects that argument of this call is a default SSA_NAME of the PARM_DECL whose bounds we want

Re: [PATCH, MPX, 2/X] Pointers Checker [10/25] Calls copy and verification

2013-11-04 Thread Richard Biener
On Thu, Oct 31, 2013 at 10:24 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, Here is a patch to support of instrumented code in calls verifiers and calls copy with skipped args. Thanks, Ilya -- gcc/ 2013-10-29 Ilya Enkovich ilya.enkov...@intel.com * cgraph.c

[Patch, testsuite] Require scheduling support in gcc.dg/superblock.c

2013-11-04 Thread Senthil Kumar Selvaraj
Hi, gcc.dg/superblock.c uses the -fdump-rtl-sched2 option and then scans the resulting dump. This fails for the AVR target, as it doesn't have any instruction scheduling support. The attached patch makes this test require scheduling support in the target. If ok, could someone commit please? I

Re: Aliasing: look through pointer's def stmt

2013-11-04 Thread Richard Biener
On Thu, Oct 31, 2013 at 6:11 PM, Marc Glisse marc.gli...@inria.fr wrote: On Wed, 30 Oct 2013, Richard Biener wrote: --- gcc/tree-ssa-alias.c(revision 204188) +++ gcc/tree-ssa-alias.c(working copy) @@ -567,20 +567,29 @@ void ao_ref_init_from_ptr_and_size (ao_ref *ref, tree

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-11-04 Thread Andrew MacLeod
On 11/01/2013 05:57 PM, Jakub Jelinek wrote: On Fri, Nov 01, 2013 at 05:47:14PM -0400, Andrew MacLeod wrote: On 11/01/2013 05:41 PM, Jakub Jelinek wrote: On Fri, Nov 01, 2013 at 05:36:34PM -0400, Andrew MacLeod wrote: static inline void ! gimple_call_set_lhs (gimple gs, tree lhs) { -

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-11-04 Thread Jakub Jelinek
On Mon, Nov 04, 2013 at 08:54:40AM -0500, Andrew MacLeod wrote: What checking? There ought to be no checking at all in this example... gimple_build_call_vec returns a gimple_call, and gimple_call_set_lhs() doesn't have to check anything because it only accepts gimple_call's.. so there is no

Re: [PATCH, rs6000] Fix vect_pack_trunc_v2df pattern for little endian

2013-11-04 Thread David Edelsohn
On Mon, Nov 4, 2013 at 8:28 AM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: Hi, This cleans up another case where a vector-pack operation needs to reverse its operand order for little endian. This fixes the last remaining vector test failure in the test suite when building for little

Re: [PATCH, rs6000] Re-permute source register for postreload splits of VSX LE stores

2013-11-04 Thread David Edelsohn
On Sat, Nov 2, 2013 at 7:44 PM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: Hi, When I created the patch to split VSX loads and stores to add permutes so the register image was correctly little endian, I forgot to implement a known requirement. When a VSX store is split after reload, we

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-11-04 Thread Andrew MacLeod
On 11/04/2013 09:00 AM, Jakub Jelinek wrote: On Mon, Nov 04, 2013 at 08:54:40AM -0500, Andrew MacLeod wrote: What checking? There ought to be no checking at all in this example... gimple_build_call_vec returns a gimple_call, and gimple_call_set_lhs() doesn't have to check anything because it

Re: LRA vs reload on powerpc: 2 extra FAILs that are actually improvements?

2013-11-04 Thread David Edelsohn
Hi, Steven Thanks for investigating this. This presumably was the reason that Vlad changed the constraint modifier for that pattern in his patch for LRA. I don't think that using memory is an improvement, but Mike is the best person to comment. Thanks, David On Sat, Nov 2, 2013 at 6:48 PM,

Re: [wide-int] Avoid some changes in output code

2013-11-04 Thread Kenneth Zadeck
On 11/04/2013 04:12 AM, Richard Biener wrote: On Fri, 1 Nov 2013, Richard Sandiford wrote: I'm building one target for each supported CPU and comparing the wide-int assembly output of gcc.c-torture, gcc.dg and g++.dg with the corresponding output from the merge point. This patch removes all

Re: libsanitizer merge from upstream r191666

2013-11-04 Thread Konstantin Serebryany
+glider, our Mac expert. Hi Jack, This patch has not been tested on Mac and we generally do not claim that gcc-asan is supported on Mac. clang-asan *is* supported on Mac and our bots are green (this patch is a merge of the sources which are regularly tested on Mac, but the build procedure is

Re: Ping^3 Re: Add predefined macros for library use in defining __STDC_IEC_559*

2013-11-04 Thread Jakub Jelinek
On Mon, Nov 04, 2013 at 02:51:37PM +, Joseph S. Myers wrote: Ping^3. The addition of a new target hook in this patch http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01131.html is still pending review. Ok. Jakub

Re: [wide-int] Avoid some changes in output code

2013-11-04 Thread Richard Sandiford
Kenneth Zadeck zad...@naturalbridge.com writes: However, i would also say that it would be nice if were actually done right. There are (as far as i know) actually 3 ways handling shift amounts that have been used in the past: (1) mask the shift amount by (bitsize - 1). This is the most

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-11-04 Thread Dodji Seketeli
Bernd Edlinger bernd.edlin...@hotmail.de writes: I see another read_line at gcov.c, which seems to be a copy. Maybe this should be changed too? I have seen it as well. I'd rather have the patch be reviewed and everthing, and only then propose to share the implementation with the gcov

[omp4]

2013-11-04 Thread Aldy Hernandez
Hi. While looking over some of your testcases I noticed that array subscripts are not being properly adjusted: foo(int i) { array[i] = } The `i' should use the simd array magic instead of ICEing :). Is the attached patch OK for the branch? Aldy gcc/ChangeLog.gomp *

Re: [omp4] fix array subscripts in simd clones

2013-11-04 Thread Aldy Hernandez
On 11/04/13 08:19, Aldy Hernandez wrote: Hi. While looking over some of your testcases I noticed that array subscripts are not being properly adjusted: foo(int i) { array[i] = } The `i' should use the simd array magic instead of ICEing :). Is the attached patch OK for the branch?

Re: PATCH to use -Wno-format during stage1

2013-11-04 Thread Jason Merrill
On 11/04/2013 07:41 AM, Richard Biener wrote: Please make sure the warning is preserved when not bootstrapping, it's useful to have them in your dev-tree and not notice errors only during -Werror bootstrap ... I found it to be useless noise when not bootstrapping, since my system compiler

Re: [C++ PATCH] Fix PR58979

2013-11-04 Thread Jason Merrill
On 11/04/2013 05:50 AM, Marek Polacek wrote: case RO_ARROW: +case RO_ARROW_STAR: error_at (loc, invalid type argument of %-% (have %qT), type); I think the diagnostic for RO_ARROW_STAR should say -*, not just -. Jason

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-11-04 Thread Dodji Seketeli
Jakub Jelinek ja...@redhat.com writes: [...] Eventually, I think using int for sizes is just a ticking bomb, what if somebody uses 2GB long lines? Surely, on 32-bit hosts we are unlikely to handle it, but why couldn't 64-bit host handle it? Column info maybe bogus in there, sure, but at

Re: PATCH to use -Wno-format during stage1

2013-11-04 Thread Paolo Carlini
On 11/04/2013 04:34 PM, Jason Merrill wrote: On 11/04/2013 07:41 AM, Richard Biener wrote: Please make sure the warning is preserved when not bootstrapping, it's useful to have them in your dev-tree and not notice errors only during -Werror bootstrap ... I found it to be useless noise when

Re: [omp4]

2013-11-04 Thread Jakub Jelinek
On Mon, Nov 04, 2013 at 08:19:12AM -0700, Aldy Hernandez wrote: Hi. While looking over some of your testcases I noticed that array subscripts are not being properly adjusted: foo(int i) { array[i] = } The `i' should use the simd array magic instead of ICEing :). Is the

Re: PATCH to use -Wno-format during stage1

2013-11-04 Thread Jakub Jelinek
On Mon, Nov 04, 2013 at 10:34:55AM -0500, Jason Merrill wrote: On 11/04/2013 07:41 AM, Richard Biener wrote: Please make sure the warning is preserved when not bootstrapping, it's useful to have them in your dev-tree and not notice errors only during -Werror bootstrap ... I found it to be

Re: [PATCH, rs6000] (3/3) Fix mulv4si3 and mulv8hi3 patterns for little endian

2013-11-04 Thread Richard Sandiford
Bill Schmidt wschm...@linux.vnet.ibm.com writes: + /* We need this to be vmulouh for both big and little endian, + but for little endian we would swap this, so avoid that. */ + if (BYTES_BIG_ENDIAN) + emit_insn (gen_vec_widen_umult_odd_v8hi (low_product, one, two)); + else +

Re: [C++ PATCH] Fix PR58979

2013-11-04 Thread Marek Polacek
On Mon, Nov 04, 2013 at 10:36:35AM -0500, Jason Merrill wrote: On 11/04/2013 05:50 AM, Marek Polacek wrote: case RO_ARROW: +case RO_ARROW_STAR: error_at (loc, invalid type argument of %-% (have %qT), type); I think the diagnostic for

Re: [C++ PATCH] Fix PR58979

2013-11-04 Thread Jason Merrill
OK. Jason

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-04 Thread David Edelsohn
Balaji, I am seeing a large number of libcilkrts failures on AIX. These all are of the form: Executing on host: /tmp/20131103/gcc/xgcc -B/tmp/20131103/gcc/ /nasfarm/edelsohn /src/src/gcc/testsuite/c-c++-common/cilk-plus/CK/sync_wo_spawn.c -fno-diagnosti cs-show-caret -fdiagnostics-color=never

patch to fix pr58968

2013-11-04 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58968 It is actually the 3rd try to fix the problem. Removing no-ops move may result in mode-switching crashes on x86/x86-64 as it expects a specific code (by the way reload has the same problem on x86/x86-64). The

Re: [omp4]

2013-11-04 Thread Jakub Jelinek
On Mon, Nov 04, 2013 at 09:22:39AM -0700, Aldy Hernandez wrote: Ok, then let's leave this for later. I'm following what we've done in tree-sra.c to be consistent. Perhaps later we could even clean up ipa_sra_modify_function_body in tree-sra.c. But for now I think we can concentrate on the

Re: Aliasing: look through pointer's def stmt

2013-11-04 Thread Marc Glisse
On Mon, 4 Nov 2013, Richard Biener wrote: Well, host_integer_p (, 0) looks correct to me. But ... Ok, I'll put it back. Index: gcc/tree-ssa-alias.h === --- gcc/tree-ssa-alias.h(revision 204267) +++ gcc/tree-ssa-alias.h

[C++ Patch, Java related/RFC] PR 11006

2013-11-04 Thread Paolo Carlini
Hi, we have got this very old bug, where we ICE in build_java_class_ref because TYPE is an INTEGER_TYPE and we try to use TYPE_FIELDS on it. Shall we apply something like the below and resolve it for good? Alternately, we could maybe provide the same message we currently provide in

Re: libsanitizer merge from upstream r191666

2013-11-04 Thread Jack Howarth
On Mon, Nov 04, 2013 at 06:47:13AM -0800, Konstantin Serebryany wrote: +glider, our Mac expert. Hi Jack, This patch has not been tested on Mac and we generally do not claim that gcc-asan is supported on Mac. clang-asan *is* supported on Mac and our bots are green (this patch is a merge

Re: PR 58958: wrong aliasing info

2013-11-04 Thread Marc Glisse
On Mon, 4 Nov 2013, Richard Biener wrote: On Mon, Nov 4, 2013 at 12:18 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 4 Nov 2013, Richard Biener wrote: On Mon, Nov 4, 2013 at 11:55 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, Nov 1, 2013 at 11:39 PM, Marc Glisse

Re: [C++ Patch, Java related/RFC] PR 11006

2013-11-04 Thread Jason Merrill
Surely it should be valid to allocate a Java boolean type. Andrew, how should that work? Jason

Re: PATCH to use -Wno-format during stage1

2013-11-04 Thread Jason Merrill
On 11/04/2013 10:50 AM, Jakub Jelinek wrote: That's true, but it is easy to ignore those, while without -Wformat you won't notice until you bootstrap that you actually passed incorrect parameters to some *printf etc. family function. Sure, but that is much less common than the false positives,

Re: [Patch, avr] Emit diagnostics if -f{pic,PIC,pie,PIE} or -shared is passed

2013-11-04 Thread Joerg Wunsch
As Senthil Kumar Selvaraj wrote: If ok, could someone commit please? I don't have commit access. I don't have commit access either, but the changes look reasonable to me. -- Joerg Wunsch * Development engineer, Dresden, Germany Atmel Automotive GmbH, Theresienstrasse 2, D-74027 Heilbronn

Re: [PATCH, rs6000] (2/3) Fix widening multiply high/low operations for little endian

2013-11-04 Thread Bill Schmidt
Per Richard S's suggestion, I'm reworking parts 1 and 3 of the patch set, but this one will remain unchanged and is ready for review. Thanks, Bill On Sun, 2013-11-03 at 23:34 -0600, Bill Schmidt wrote: Hi, This patch fixes the widening multiply high/low operations to work correctly in the

Re: Patch RFA: With -fnon-call-exceptions sync builtins may throw

2013-11-04 Thread Richard Biener
Ian Lance Taylor i...@google.com wrote: On Mon, Nov 4, 2013 at 3:52 AM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Nov 4, 2013 at 7:01 AM, Ian Lance Taylor i...@google.com wrote: The middle-end currently marks all the sync builtins as nothrow. That is incorrect for most of them

Re: lto-plugin: mismatch between ld's architecture and GCC's configure --host

2013-11-04 Thread Cary Coutant
Ping. To sum it up, with these patches applied, there are no changes for a regular build (not using the new configure options). On the other hand, configuring GCC as described, it is possible use the 32-bit x86 linker for/with a x86_64 build, and get the very same GCC test results as when

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-11-04 Thread Jeff Law
On 11/01/13 15:41, Jakub Jelinek wrote: On Fri, Nov 01, 2013 at 05:36:34PM -0400, Andrew MacLeod wrote: static inline void ! gimple_call_set_lhs (gimple gs, tree lhs) { - GIMPLE_CHECK (gs, GIMPLE_CALL); gimple_set_op (gs, 0, lhs); to static inline void ! gimple_call_set_lhs

Re: [PATCH] Try to avoid vector mode punning in SET_DEST on i?86

2013-11-04 Thread James Greenhalgh
On Thu, Oct 31, 2013 at 04:49:47PM +, Jakub Jelinek wrote: 2013-10-31 Jakub Jelinek ja...@redhat.com * optabs.c (expand_vec_perm): Avoid vector mode punning SUBREGs in SET_DEST. * expmed.c (store_bit_field_1): Likewise. * config/i386/sse.md

Re: [Patch, ObjC, ObjC++, Darwin] Remove -fobjc-sjlj-exceptions

2013-11-04 Thread Joseph S. Myers
On Sun, 3 Nov 2013, Iain Sandoe wrote: gcc/c-family: * c-opts.c (c_common_post_options): Remove handling of flag_objc_sjlj_exceptions. * c.opt (fobjc-sjlj-exceptions): Issue a warning if this option is given. The c-family changes are OK. -- Joseph S. Myers

Re: [driver] Force options Wa, Wl, Wp, to take a mandatory argument

2013-11-04 Thread Joseph S. Myers
On Mon, 4 Nov 2013, Mingjie Xing wrote: Hello, This patch forces options Wa, Wl, Wp, to take a mandatory argument, which can fix the bug http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55651. Tested on i686-pc-linux-gnu. 2013-11-04 Mingjie Xing mingjie.x...@gmail.com *

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-11-04 Thread Cong Hou
On Mon, Nov 4, 2013 at 2:06 AM, James Greenhalgh james.greenha...@arm.com wrote: On Fri, Nov 01, 2013 at 04:48:53PM +, Cong Hou wrote: diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi index 2a5a2e1..8f5d39a 100644 --- a/gcc/doc/md.texi +++ b/gcc/doc/md.texi @@ -4705,6 +4705,16 @@ wider

Re: changing a collision resolution strategy of the symbol table of identifiers

2013-11-04 Thread Roman Gareev
2013/10/20 Ondřej Bílka nel...@seznam.cz: On Sun, Oct 20, 2013 at 06:55:40PM +0600, Roman Gareev wrote: Dear gcc contributors, Recently I came across the list of ideas for speeding up GCC (http://gcc.gnu.org/wiki/Speedup_areas). Among others, there was suggested to replace identifier hash

[PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-04 Thread Yufeng Zhang
Hi, This patch extends the slsr pass to optionally use an alternative base expression in finding basis for CAND_REFs. Currently the pass uses hash-based algorithm to match the base_expr in a candidate. Given a test case like the following, slsr will not be able to recognize the two

Re: [PATCH, MPX, 2/X] Pointers Checker [7/25] Suppress BUILT_IN_CHKP_ARG_BND optimizations.

2013-11-04 Thread Richard Biener
Richard Biener richard.guent...@gmail.com wrote: On Thu, Oct 31, 2013 at 10:02 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, Here is a patch which hadles the problem with optimization of BUILT_IN_CHKP_ARG_BND calls. Pointer Bounds Checker expects that argument of this call is a default

Re: [C++ Patch, Java related/RFC] PR 11006

2013-11-04 Thread Paolo Carlini
On 11/04/2013 06:21 PM, Jason Merrill wrote: Surely it should be valid to allocate a Java boolean type. Andrew, how should that work? Thanks. The problem we are facing (assuming we want to resolve this old isue) is that something seems seriously broken for the builtin Java types as declared

[PATCH] PR58985: testcase error.

2013-11-04 Thread Wei Mi
Hi, This is to fix testcase error reported in PR58985. The intention of the testcase was to ensure there was no REG_EQUIV notes generated for a reg which was used in a paradoxical subreg. When target was x86, there was subreg generated so I omitted to add the subreg in the regexp pattern.

Re: changing a collision resolution strategy of the symbol table of identifiers

2013-11-04 Thread Roman Gareev
2013/10/31 Florian Weimer fwei...@redhat.com: On 10/20/2013 02:55 PM, Roman Gareev wrote: During testing of the linux kernel (3.8.8) compilation time, the acquired results were the following: increasing by 0.17% for the version 4.8.0, increasing by 1.12% for the version 4.8.1, decreasing by

RFA: patch to fix PR58967

2013-11-04 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58967 The removed code is too old. To be honest, I even don't remember why I added this. LRA has been changed a lot since this change and now it works fine without it. There is no test for this case as it is too big.

Re: RFA: patch to fix PR58967

2013-11-04 Thread David Edelsohn
On Mon, Nov 4, 2013 at 2:23 PM, Vladimir Makarov vmaka...@redhat.com wrote: The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58967 The removed code is too old. To be honest, I even don't remember why I added this. LRA has been changed a lot since this change and now

Re: [PATCH, rs6000] (2/3) Fix widening multiply high/low operations for little endian

2013-11-04 Thread David Edelsohn
On Mon, Nov 4, 2013 at 12:34 AM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: Hi, This patch fixes the widening multiply high/low operations to work correctly in the presence of the first patch of this series, which reverses the meanings of multiply even/odd instructions. Here we reorder

  1   2   >