Reduce -flto -fprofile-generate memory use

2014-04-17 Thread Jan Hubicka
Hi, while compiling firefox I noticed that -fprofile-generage -flto goes to 8GB. It turns out that this is caused by ipa_reference no longer being disabled becaus in_lto_p became flag that is set later (it is not clear to me why it needs to be this way). I however do not see reason why not

Re: Reduce -flto -fprofile-generate memory use

2014-04-17 Thread Richard Biener
On Thu, 17 Apr 2014, Jan Hubicka wrote: Hi, while compiling firefox I noticed that -fprofile-generage -flto goes to 8GB. It turns out that this is caused by ipa_reference no longer being disabled becaus in_lto_p became flag that is set later (it is not clear to me why it needs to be this

Re: Fix lto/PR60854

2014-04-17 Thread Richard Biener
On Thu, Apr 17, 2014 at 4:30 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, the testcase shows problem where cpp implicit alias is always inline and symtab_remove_unreachable_nodes removes the body of aliased function before inlininghappens. The real problem is that cgraph_state is set too early

Re: [PATCH GCC]Fix pr60363 by adding backtraced value of phi arg along jump threading path

2014-04-17 Thread Richard Biener
On Thu, Apr 17, 2014 at 7:30 AM, Jeff Law l...@redhat.com wrote: On 03/18/14 04:13, bin.cheng wrote: Hi, After control flow graph change made by http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01492.html, case gcc.dg/tree-ssa/ssa-dom-thread-4.c is broken on logical_op_short_circuit targets

[PATCH] Fix PR60841

2014-04-17 Thread Richard Biener
This fixes running into the exponential value-graph - SLP tree expansion by artificially limiting the overall SLP tree size. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2014-04-16 Richard Biener rguent...@suse.de PR tree-optimization/60841

[PATCH] Fix PR60849

2014-04-17 Thread Richard Biener
This fixes PR60849 by properly rejecting non-boolean typed comparisons from valid_gimple_rhs_p so they go through the gimplification paths. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2014-04-16 Richard Biener rguent...@suse.de PR middle-end/60849

[PATCH] Fix PR60836

2014-04-17 Thread Richard Biener
This fixes PR60836 by emitting a non-proper PHI argument to the incoming edge. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2014-04-16 Richard Biener rguent...@suse.de PR tree-optimization/60836 * tree-vect-loop.c

[PATCH 2/6] merge register_dump_files_1 into register_dump_files

2014-04-17 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Hi, simplification allowed by previous patch. bootstrap + regtest passed on x86_64-unknown-linux-gnu, ok? Trev 2014-03-19 Trevor Saunders tsaund...@mozilla.com * pass_manager.h (pass_manager::register_dump_files_1): Remove declaration.

[PATCH 1/6] remove properties stuff from register_dump_files_1

2014-04-17 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Hi, just removing some dead code. bootstrapped + regtested against r209414 on x86_64-unknown-linux-gnu, ok? Trev 2014-03-19 Trevor Saunders tsaund...@mozilla.com * pass_manager.h (pass_manager::register_dump_files_1): Adjust. *

[PATCH 4/6] enable -Woverloaded-virtual when available

2014-04-17 Thread tsaunders
From: Trevor Saunders tbsau...@mozilla.com hi, its a useful warning, and helps catch bugs in the next two patches. bootstrap + regtest passed on x86_64-unknown-linux-gnu, ok? Trev 2014-03-19 Trevor Saunders tsaund...@mozilla.com * configure.ac: Check for -Woverloaded-virtual and

Re: [PATCH 2/6] merge register_dump_files_1 into register_dump_files

2014-04-17 Thread Richard Biener
On Thu, Apr 17, 2014 at 10:37 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, simplification allowed by previous patch. bootstrap + regtest passed on x86_64-unknown-linux-gnu, ok? Ok. Thanks, Richard. Trev 2014-03-19 Trevor Saunders

Re: [PATCH 1/6] remove properties stuff from register_dump_files_1

2014-04-17 Thread Richard Biener
On Thu, Apr 17, 2014 at 10:37 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, just removing some dead code. bootstrapped + regtested against r209414 on x86_64-unknown-linux-gnu, ok? Ok. Thanks, Richard. Trev 2014-03-19 Trevor Saunders

Re: [PATCH 4/6] enable -Woverloaded-virtual when available

2014-04-17 Thread Richard Biener
On Thu, Apr 17, 2014 at 10:37 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tbsau...@mozilla.com hi, its a useful warning, and helps catch bugs in the next two patches. bootstrap + regtest passed on x86_64-unknown-linux-gnu, ok? Ok. Thanks, Richard. Trev 2014-03-19 Trevor

Re: [RFC] Add aarch64 support for ada

2014-04-17 Thread Tristan Gingold
On 16 Apr 2014, at 17:36, Richard Henderson r...@redhat.com wrote: On 04/16/2014 12:39 AM, Eric Botcazou wrote: The primary bit of rfc here is the hunk that applies to ada/types.h with respect to Fat_Pointer. Given that the Ada type, as defined in s-stratt.ads, does not include alignment, I

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-04-17 Thread Jonathan Wakely
On 17 April 2014 01:56, Luke Allardyce wrote: Thanks, I was wrong about that. Then I think we should just bite the bullet and provide the new behaviour. If we do have an abi_tag on those types in the next release then we can preserve the old behaviour in the old ABI and use the C++11

Re: [PATCH] Enhancing the widen-mult pattern in vectorization.

2014-04-17 Thread Richard Biener
On Sat, Dec 7, 2013 at 12:45 AM, Cong Hou co...@google.com wrote: After further reviewing this patch, I found I don't have to change the code in tree-vect-stmts.c to allow further type conversion after widen-mult operation. Instead, I detect the following pattern in

Re: Remove obsolete Solaris 9 support

2014-04-17 Thread Rainer Orth
Uros Bizjak ubiz...@gmail.com writes: On Wed, Apr 16, 2014 at 1:16 PM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Now that 4.9 has branched, it's time to actually remove the obsolete Solaris 9 configuration. Most of this is just legwork and falls under my Solaris maintainership. A

Re: [PATCH GCC]Fix pr60363 by adding backtraced value of phi arg along jump threading path

2014-04-17 Thread Bin.Cheng
On Thu, Apr 17, 2014 at 1:30 PM, Jeff Law l...@redhat.com wrote: On 03/18/14 04:13, bin.cheng wrote: Hi, After control flow graph change made by http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01492.html, case gcc.dg/tree-ssa/ssa-dom-thread-4.c is broken on logical_op_short_circuit targets

Re: [PATCH, i386, PR57623] Introduce synonyms for BMI intrinsics

2014-04-17 Thread Jakub Jelinek
On Wed, Jul 03, 2013 at 08:14:25AM +0200, Uros Bizjak wrote: On Tue, Jul 2, 2013 at 10:32 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Bootstrap passing. Updated tests passing on BMI-featured HW. ChangeLog: 2013-07-02 Kirill Yukhin kirill.yuk...@intel.com *

Re: [PATCH][2/3] Fix PR54733 Optimize endian independent load/store

2014-04-17 Thread Richard Biener
On Thu, Apr 17, 2014 at 7:19 AM, Thomas Preud'homme thomas.preudho...@arm.com wrote: From: Richard Biener [mailto:richard.guent...@gmail.com] With handling only the outermost handled-component and then only a selected subset you'll catch many but not all cases. Why not simply use

Re: [PATCH] dwarf2out: Use normal constant values in bound_info if possible.

2014-04-17 Thread Mark Wielaard
On Tue, 2014-04-15 at 14:24 -0700, Cary Coutant wrote: + /* If HOST_WIDE_INT is big enough then represent the bound as + a constant value. Note that we need to make sure the type + is signed or unsigned. We cannot just add an unsigned + constant if the

Re: [PATCH] Fix PR60849

2014-04-17 Thread Marc Glisse
On Thu, 17 Apr 2014, Richard Biener wrote: This fixes PR60849 by properly rejecting non-boolean typed comparisons from valid_gimple_rhs_p so they go through the gimplification paths. Could you also accept vector comparisons please? -- Marc Glisse

Re: [PATCH, i386, PR57623] Introduce synonyms for BMI intrinsics

2014-04-17 Thread Kirill Yukhin
Thanks! Sorry, missed that! K On Thu, Apr 17, 2014 at 2:13 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Jul 03, 2013 at 08:14:25AM +0200, Uros Bizjak wrote: On Tue, Jul 2, 2013 at 10:32 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Bootstrap passing. Updated tests passing on

Re: [PATCH] Fix PR60849

2014-04-17 Thread Richard Biener
On Thu, 17 Apr 2014, Marc Glisse wrote: On Thu, 17 Apr 2014, Richard Biener wrote: This fixes PR60849 by properly rejecting non-boolean typed comparisons from valid_gimple_rhs_p so they go through the gimplification paths. Could you also accept vector comparisons please? Sure.

[PATCH] Try to coalesce for unary and binary ops

2014-04-17 Thread Richard Biener
The patch below increases the number of coalescs we attempt to also cover unary and binary operations. This improves initial code generation for code like int foo (int i, int j, int k, int l) { int res = i; res += j; res += k; res += l; return res; } from ;; res_3 = i_1(D) + j_2(D);

Re: [PATCH] Try to coalesce for unary and binary ops

2014-04-17 Thread Richard Biener
On Thu, 17 Apr 2014, Richard Biener wrote: The patch below increases the number of coalescs we attempt to also cover unary and binary operations. This improves initial code generation for code like int foo (int i, int j, int k, int l) { int res = i; res += j; res += k; res

RE: [PATCH] Add a new option -fmerge-bitfields (patch / doc inside)

2014-04-17 Thread Zoran Jovanovic
Hello, My apologies for inconvenience. Removed every appearance of -ftree-bitfield-merge from the patch and fixed an issue with unions. The rest of the patch is the same as before. Regards, Zoran Jovanovic

[RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-04-17 Thread Yury Gribov
-- From: Yury Gribov y.gri...@samsung.com Sent: Tuesday, March 25, 2014 11:57AM To: Jakub Jelinek ja...@redhat.com, Eric Botcazou ebotca...@adacore.com, gcc-patches@gcc.gnu.org, Hans-Peter Nilsson h...@bitrange.com, rdsandif...@googlemail.com

Re: Patch ping

2014-04-17 Thread Jakub Jelinek
On Wed, Apr 16, 2014 at 02:45:37PM -0400, DJ Delorie wrote: I'll approve both patches, if you agree to think about a way to solve this problem without module-specific configury changes for each such command line option. I understand the usefulness of having instrumentation, but the configure

Re: [PATCH] Make SRA tolerate most throwing statements

2014-04-17 Thread Martin Jambor
On Wed, Apr 16, 2014 at 11:22:28AM +0200, Richard Biener wrote: On Tue, 15 Apr 2014, Martin Jambor wrote: Hi, back in January in http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00848.html Eric pointed out a testcase where the problem was SRA not scalarizing an aggregate because it was

Re: [PATCH] Make SRA tolerate most throwing statements

2014-04-17 Thread Richard Biener
On Thu, Apr 17, 2014 at 2:21 PM, Martin Jambor mjam...@suse.cz wrote: On Wed, Apr 16, 2014 at 11:22:28AM +0200, Richard Biener wrote: On Tue, 15 Apr 2014, Martin Jambor wrote: Hi, back in January in http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00848.html Eric pointed out a testcase

Re: [PATCH 1/6] remove properties stuff from register_dump_files_1

2014-04-17 Thread Trevor Saunders
On Thu, Apr 17, 2014 at 10:53:07AM +0200, Richard Biener wrote: On Thu, Apr 17, 2014 at 10:37 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, just removing some dead code. bootstrapped + regtested against r209414 on x86_64-unknown-linux-gnu, ok?

Changes for if-convert to recognize simple conditional reduction.

2014-04-17 Thread Yuri Rumyantsev
Hi All, We implemented enhancement for if-convert phase to recognize the simplest conditional reduction and to transform it vectorizable form, e.g. statement if (A[i] != 0) num+= 1; will be recognized. A new test-case is also provided. Bootstrapping and regression testing did not show any

Re: [PATCH] Redesign jump threading profile updates

2014-04-17 Thread Teresa Johnson
On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law l...@redhat.com wrote: On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump threading were incorrect in many cases, particularly in the case where the threading path contains a joiner. Some

[PING] [PATCH] Fix for PR libstdc++/60758

2014-04-17 Thread Alexey Merzlyakov
Hi, This fixes infinite backtrace in __cxa_end_cleanup(). Regtest was finished with no regressions on arm-linux-gnueabi(sf). The patch posted at: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00496.html Thanks in advance. Best regards, Merzlyakov Alexey

[ PATCH] Extend mode-switching to support toggle (1/2)

2014-04-17 Thread Christian Bruel
Hello, He is a new version of the patch. It hookizes the mode-setting and mode-toggling macros. Split in 2 parts. Successfully bootstrapped/regtested on ix86 and SH4/SH4a. I was able to do a limited build on Epiphany, if someone could give it a try on it that would be great. comments ?

Re: [PATCH] Try to coalesce for unary and binary ops

2014-04-17 Thread Michael Matz
Hi, On Thu, 17 Apr 2014, Richard Biener wrote: The patch below increases the number of coalescs we attempt to also cover unary and binary operations. This is not usually a good idea if not mitigated by things like register pressure measurement and using target properties to determine if it's

[ PATCH] Extend mode-switching to support toggle (2/2)

2014-04-17 Thread Christian Bruel
and the toggle-support hookized many thanks, Christian 2014-04-02 Christian Bruel christian.br...@st.com * target.def (mode_switching): New hook vector. (toggle_init, toggle_destroy, toggle_set, toggle_test): New mode toggle hooks. * targhooks.h (default_toggle_test): Declare. *

[PATCH 0/3] libsanitizer libc conditionals

2014-04-17 Thread Bernhard Reutner-Fischer
Respun. First two patches are for gcc, the last one is for upstream LLVM. The gcc part was bootstrapped and regtested on x86_64-unknown-linux-gnu without regressions and bootstrapped on x86_64-unknown-linux-uclibc to verify that the configury works as expected and that the library links without

[PATCH 1/3] libsanitizer: Fix !statfs64 builds

2014-04-17 Thread Bernhard Reutner-Fischer
libsanitizer/ChangeLog 2014-04-02 Bernhard Reutner-Fischer al...@gcc.gnu.org * configure.ac: Check for sizeof(struct statfs64). * configure, config.h.in: Regenerate. * sanitizer_common/sanitizer_platform_interceptors.h (SANITIZER_INTERCEPT_STATFS64): Make

[PATCH 2/3] libsanitizer: add conditionals for libc

2014-04-17 Thread Bernhard Reutner-Fischer
Conditionalize usage of dlvsym(), nanosleep(), usleep(); Conditionalize layout of struct sigaction and type of it's member sa_flags. Conditionalize glob_t members gl_closedir, gl_readdir, gl_opendir, gl_flags, gl_lstat, gl_stat. Check for availability of glob.h for use with above members. Check

[PATCH 3/3] [LLVM] [sanitizer] add conditionals for libc

2014-04-17 Thread Bernhard Reutner-Fischer
Conditionalize usage of dlvsym(), nanosleep(), usleep(); Conditionalize layout of struct sigaction and type of it's member sa_flags. Conditionalize glob_t members gl_closedir, gl_readdir, gl_opendir, gl_flags, gl_lstat, gl_stat. Check for availability of glob.h for use with above members. Check

Re: [PATCH 3/3] [LLVM] [sanitizer] add conditionals for libc

2014-04-17 Thread Konstantin Serebryany
Hi, If you are trying to modify the libsanitizer files, please read here: https://code.google.com/p/address-sanitizer/wiki/HowToContribute --kcc On Thu, Apr 17, 2014 at 5:49 PM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: Conditionalize usage of dlvsym(), nanosleep(), usleep();

Re: [PATCH 3/3] [LLVM] [sanitizer] add conditionals for libc

2014-04-17 Thread Bernhard Reutner-Fischer
On 17 April 2014 16:07, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: Hi, If you are trying to modify the libsanitizer files, please read here: https://code.google.com/p/address-sanitizer/wiki/HowToContribute I read that, thanks. Patch 3/3 is for current compiler-rt git repo,

Re: [PATCH v7?] PR middle-end/60281

2014-04-17 Thread lin zuojian
Hi Bernd, I have my copyright mark signed and the process has completed. Now I am going to answer two more questions before my patch can be commited right? Did you copy any files or text written by someone else in these changes?” no [Which files have you changed so

Re: [RFC] Add aarch64 support for ada

2014-04-17 Thread Richard Henderson
On 04/17/2014 02:00 AM, Tristan Gingold wrote: On 16 Apr 2014, at 17:36, Richard Henderson r...@redhat.com wrote: On 04/16/2014 12:39 AM, Eric Botcazou wrote: The primary bit of rfc here is the hunk that applies to ada/types.h with respect to Fat_Pointer. Given that the Ada type, as

Re: [PATCH 3/3] [LLVM] [sanitizer] add conditionals for libc

2014-04-17 Thread Konstantin Serebryany
On Thu, Apr 17, 2014 at 6:27 PM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 17 April 2014 16:07, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: Hi, If you are trying to modify the libsanitizer files, please read here:

Re: fuse-caller-save - hook format

2014-04-17 Thread Vladimir Makarov
On 2014-04-16, 3:19 PM, Tom de Vries wrote: Vladimir, All patches for the fuse-caller-save optimization have been ok-ed. The only part not approved is the MIPS-specific part. The objection of Richard S. is not so much the patch itself, but more the idea of the hook

PATCH: PR target/60863: Incorrect codegen in ix86_expand_clear for -Os

2014-04-17 Thread H.J. Lu
Hi, I checked in this preapproved patch to generate xor reg, reg when optimizing for size. H.J. Index: ChangeLog === --- ChangeLog (revision 209487) +++ ChangeLog (working copy) @@ -1,3 +1,10 @@ +2014-04-17 H.J. Lu

Re: fuse-caller-save - hook format

2014-04-17 Thread Richard Sandiford
Vladimir Makarov vmaka...@redhat.com writes: On 2014-04-16, 3:19 PM, Tom de Vries wrote: Vladimir, All patches for the fuse-caller-save optimization have been ok-ed. The only part not approved is the MIPS-specific part. The objection of Richard S. is not so much the patch itself, but

Re: [RFC] Add aarch64 support for ada

2014-04-17 Thread Tristan Gingold
On 17 Apr 2014, at 16:50, Richard Henderson r...@redhat.com wrote: On 04/17/2014 02:00 AM, Tristan Gingold wrote: On 16 Apr 2014, at 17:36, Richard Henderson r...@redhat.com wrote: On 04/16/2014 12:39 AM, Eric Botcazou wrote: The primary bit of rfc here is the hunk that applies to

Re: [RFC] Add aarch64 support for ada

2014-04-17 Thread Eric Botcazou
Ah hah. /* Make sure we can put it into a register. */ if (STRICT_ALIGNMENT) TYPE_ALIGN (record_type) = MIN (BIGGEST_ALIGNMENT, 2 * POINTER_SIZE); AArch64 is not a STRICT_ALIGNMENT target, thus the mismatch. I see. Initially this alignment promotion had been universal, but

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-04-17 Thread Marek Polacek
On Wed, Apr 16, 2014 at 01:40:22PM -0400, Jason Merrill wrote: On 04/15/2014 03:56 PM, Marek Polacek wrote: The testsuite doesn't hit this code with C++, but does hit this code with C. The thing is, if we have e.g. enum { A = 128 }; void *fn1 (void) __attribute__((assume_aligned (A))); then

Re: Avoid unnecesary GGC runs during LTO

2014-04-17 Thread Jan Hubicka
+ + /* At this stage we know that majority of GGC memory is reachable. + Growing the limits prevents unnecesary invocation of GGC. */ + ggc_grow (); ggc_collect (); Isn't the collect here pointless? I see not in ENABLE_CHECKING, but shouldn't this be abstracted

RE: [PATCH] Add a new option -fmerge-bitfields (patch / doc inside)

2014-04-17 Thread Zoran Jovanovic
Hello, Unfortunately, optimization is limited only to bit-fields that have same bit-field representative (DECL_BIT_FIELD_REPRESENTATIVE), and fields from different classes do have different representatives. In given example optimization would merge accesses to x and y bit-fields from Base

[C++ Patch] PR 59120

2014-04-17 Thread Paolo Carlini
Hi, we can fix this crash during error recovery very easily, by grouping together the two conditions leading to skip early return, in complete analogy with the single-declaration case (note that we explicitly commit to tentative parse at the beginning of the function, thus we are good).

[PATCH] Fix uninitialised variable warning in tree-ssa-loop-ivcanon.c

2014-04-17 Thread Kyrill Tkachov
Hi all, While looking at the build logs I noticed a warning while building tree-ssa-loop-ivcanon.c about a potential use of an uninitialised variable. This patchlet fixes that warning by initialising it to 0. Tested arm-none-eabi. Ok for trunk? 2014-04-17 Kyrylo Tkachov

Re: [PATCH 3/3] [LLVM] [sanitizer] add conditionals for libc

2014-04-17 Thread Bernhard Reutner-Fischer
On 17 April 2014 16:51:23 Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: On Thu, Apr 17, 2014 at 6:27 PM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 17 April 2014 16:07, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: Hi, If you are trying to

Re: fuse-caller-save - hook format

2014-04-17 Thread Vladimir Makarov
On 2014-04-17, 11:29 AM, Richard Sandiford wrote: Vladimir Makarov vmaka...@redhat.com writes: On 2014-04-16, 3:19 PM, Tom de Vries wrote: Vladimir, All patches for the fuse-caller-save optimization have been ok-ed. The only part not approved is the MIPS-specific part. The objection of

[PATCH] Fix warning in libgfortran configure script

2014-04-17 Thread Kyrill Tkachov
Hi all, While configuring libgfortran I'm getting this message: libgfortran/configure: line 25938: test: =: unary operator expected The script doesn't fail and continues afterwards, but I don't think it's supposed to give that warning. This patch makes it go away and makes it more consistent

Re: [PATCH 3/3] [LLVM] [sanitizer] add conditionals for libc

2014-04-17 Thread Konstantin Serebryany
On Thu, Apr 17, 2014 at 8:45 PM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 17 April 2014 16:51:23 Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: On Thu, Apr 17, 2014 at 6:27 PM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 17 April 2014 16:07,

RE: [PATCH] Fix uninitialised variable warning in tree-ssa-loop-ivcanon.c

2014-04-17 Thread Daniel Marjamäki
Hello! I am not against it.. However I think there is no danger. I see no potential use of uninitialized variable. The use of n_unroll is guarded by n_unroll_found. Best regards, Daniel Marjamäki

PATCH: PR target/60868: [4.9/4.10 Regression] ICE: in int_mode_for_mode, at stor-layout.c:400 with -minline-all-stringops -minline-stringops-dynamically -march=core2

2014-04-17 Thread H.J. Lu
Hi, GET_MODE returns VOIDmode on CONST_INT. It happens with -O0. This patch uses counter_mode on count_exp to get mode. Tested on Linux/x86-64 without regressions. OK for trunk and 4.9 branch? Thanks. H.J. --- gcc/ 2014-04-17 H.J. Lu hongjiu...@intel.com PR target/60868

Re: Avoid unnecesary GGC runs during LTO

2014-04-17 Thread Richard Biener
On April 17, 2014 6:03:13 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: + + /* At this stage we know that majority of GGC memory is reachable. + Growing the limits prevents unnecesary invocation of GGC. */ + ggc_grow (); ggc_collect (); Isn't the collect here

Re: Avoid unnecesary GGC runs during LTO

2014-04-17 Thread Jan Hubicka
On April 17, 2014 6:03:13 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: + + /* At this stage we know that majority of GGC memory is reachable. + Growing the limits prevents unnecesary invocation of GGC. */ + ggc_grow (); ggc_collect (); Isn't the collect here

Re: [RFC] Add aarch64 support for ada

2014-04-17 Thread Richard Henderson
On 04/17/2014 08:35 AM, Tristan Gingold wrote: What about this compile-time check: package Fatptralign is type String_Acc is access String; type Integer_acc is access Integer; pragma Compile_Time_Error (String_Acc'Alignment = 1 * Integer_Acc'Alignment, Fat pointer are

Re: [PATCH] C++ thunk section names

2014-04-17 Thread Sriraman Tallam
Ping. On Wed, Feb 5, 2014 at 4:31 PM, Sriraman Tallam tmsri...@google.com wrote: Hi, I would like this patch reviewed and considered for commit when Stage 1 is active again. Patch Description: A C++ thunk's section name is set to be the same as the original function's section name for

Inliner heuristics TLC 1/n - let small function inlinng to ignore cold portion of program

2014-04-17 Thread Jan Hubicka
Hi, I think for 4.10 we should revisit inliner behaviour to be more LTO and LTO+FDO ready. This is first of small patches I made to sanitize behaviour of current bounds. The main problem LTO brings is that we get way too many inline candidates. In per-file model one gets only small percentage

Re: Avoid unnecesary GGC runs during LTO

2014-04-17 Thread Richard Biener
On April 17, 2014 7:18:05 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: On April 17, 2014 6:03:13 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: + + /* At this stage we know that majority of GGC memory is reachable. + Growing the limits prevents unnecesary invocation of GGC. */

Re: [gomp4] Add tables generation

2014-04-17 Thread Ilya Verbin
On 27 Mar 17:16, Jakub Jelinek wrote: On Thu, Mar 27, 2014 at 08:13:00PM +0400, Ilya Verbin wrote: On 27 Mar 15:02, Jakub Jelinek wrote: The tables need to be created before IPA, that way it really shouldn't matter in what order you emit them. E.g. the outlined target functions could

Re: Inliner heuristics TLC 1/n - let small function inlinng to ignore cold portion of program

2014-04-17 Thread David Malcolm
On Thu, 2014-04-17 at 19:52 +0200, Jan Hubicka wrote: [...] Index: doc/invoke.texi === --- doc/invoke.texi (revision 209461) +++ doc/invoke.texi (working copy) @@ -9409,7 +9409,8 @@ before applying @option{--param inline-u

Go patch commited: Mark various expressions as immutable

2014-04-17 Thread Ian Lance Taylor
This patch from Chris Manghane marks various expression types as immutable: numerics, constants, type info, address of, type conversion when appropriate. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 194e0f47c9e5 go/expressions.cc ---

Re: Inliner heuristics TLC 1/n - let small function inlinng to ignore cold portion of program

2014-04-17 Thread Xinliang David Li
This looks fine. LIPO has similar change too. Other directions worth looking into: 1) To model icache effect better, weighted callee size need to be used with profile. The weight for BB may look like: min(1, FREQ(BB)/FREQ(ENTRY)). 2) When function splitting is turned on, are any inline

RE: [PATCH v7?] PR middle-end/60281

2014-04-17 Thread Bernd Edlinger
Hi Lin, On Thu, 17 Apr 2014 22:29:14, Lin Zuojian wrote: Hi Bernd, I have my copyright mark signed and the process has completed. Now I am going to answer two more questions before my patch can be commited right? Did you copy any files or text written by someone else in these changes?”

Go patch committed: Only convert function type when necessary

2014-04-17 Thread Ian Lance Taylor
This patch to the Go frontend fixes it to not convert the function type in a call when calling an interface method. The function type of an interface method is not correct, since it does not include the receiver, but the type of the method field is correct, and as such should not be converted.

Re: [RFC][PATCH] RL78 - clean-up of missing operand mode warnings.

2014-04-17 Thread Richard Hulme
On 15/04/14 22:58, DJ Delorie wrote: I typically leave the mode off when the operand accepts a CONST_INT as I've had problems with patterns matching CONST_INTs otherwise, as CONST_INT rtx's do not have a mode (or have VOIDmode). (yes, I know gcc is supposed to accomodate that, but like I said,

Re: [patch] change specific int128 - generic intN

2014-04-17 Thread Marc Glisse
On Tue, 15 Apr 2014, DJ Delorie wrote: I wasn't sure what to do with that array, since it was static and couldn't have empty slots in them like the arrays in tree.h. Also, do we need to have *every* type in that list? What's the rule for whether a type gets installed there or not? The

Re: [RFC] Add aarch64 support for ada

2014-04-17 Thread Richard Henderson
On 04/17/2014 08:56 AM, Eric Botcazou wrote: I presume that the attached kludge is sufficient to make it work? * fe.h (Compiler_Abort): Replace Fat_Pointer by String. (Error_Msg_N): Likewise. (Error_Msg_NE): Likewise. (Get_External_Name_With_Suffix): Likewise.

Go patch committed: Use backend interface for constant expressions

2014-04-17 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface for global constants. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-04-17 Chris Manghane cm...@google.com * go-gcc.cc

Re: Patch ping

2014-04-17 Thread Uros Bizjak
On Wed, Apr 16, 2014 at 11:35 PM, Jeff Law l...@redhat.com wrote: I'd like to ping 2 patches: http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00140.html - Ensure GET_MODE_{SIZE,INNER,NUNITS} (const) is constant rather than memory load after optimization (I'd like to keep the current

[PATCH], PR target/60876 -- fix build issue with powerpc

2014-04-17 Thread Michael Meissner
I committed the following patch as obvious to fix the PowerPC build issue that came up with changes to machmode.h. These changes allow the compiler to build and bootstrap. Submitted as subversion id 209498. 2014-04-17 Michael Meissner meiss...@linux.vnet.ibm.com PR target/60876

Re: [RFC][PATCH] RL78 - clean-up of missing operand mode warnings.

2014-04-17 Thread DJ Delorie
It seems a little inconsistent, however, that *movqi_real and *xorqi3_real don't specify modes but *movhi_real and *andqi_real/*iorqi_real do (and they also accept CONST_INTs). Not that I'm advocating generating more warnings, but my inner OCD likes consistency :) Adding the mode might

libgo patch committed: Avoid unnecessary gccgo extension

2014-04-17 Thread Ian Lance Taylor
This patch from Peter Collingbourne avoids an unnecessary gccgo extension in libgo. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 801009f33610 libgo/go/syscall/libcall_posix.go --- a/libgo/go/syscall/libcall_posix.go Thu Apr 17 16:01:58 2014

libgo patch committed: Use delete rather than old map deletion syntax

2014-04-17 Thread Ian Lance Taylor
This patch from Peter Collingbourne changes libgo to use the builtin delete function rather than the old map deletion syntax. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 1e27a38c43ea libgo/go/syscall/syscall_unix.go ---

libgo patch committed: Avoid duplicate function declarations in syscall

2014-04-17 Thread Ian Lance Taylor
This patch from Peter Collingbourne avoids duplicate function declarations in the generated libcalls.go file when building the syscall package. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 5009262c3e56 libgo/go/syscall/mksyscall.awk ---

[PATCH, rs6000, 4.8, 4.9, trunk] Fix little endian behavior of vec_merge[hl] for V4SI/V4SF with VSX

2014-04-17 Thread Bill Schmidt
Hi, I missed a case in the vector API work for little endian. When VSX is enabled, the vec_mergeh and vec_mergel interfaces for 4x32 vectors are translated into xxmrghw and xxmrglw. The patterns for these were not adjusted for little endian. This patch fixes this and adds tests for V4SI and

[PATCH v8] PR middle-end/60281

2014-04-17 Thread lin zuojian
Hi, Here is the patch after the Jakub's review, and Jakub helps with the coding style. -- * asan.c (asan_emit_stack_protection): Force the base to align to appropriate bits if STRICT_ALIGNMENT. Set shadow_mem align to appropriate bits if STRICT_ALIGNMENT. * cfgexpand.c

Re: [PATCH v8] PR middle-end/60281

2014-04-17 Thread lin zuojian
Hi Bernd, a) On which target(s) did you boot-strap your patch? I just run it on x86, can't run it on ARM, because Android is not a posix system, nor a System V compatible system. And my code does not effect x86. b) Did you run the testsuite? Yes, but again my code does not effect

[patch, testsuite] Fix fragile case nsdmi-union5

2014-04-17 Thread Joey Ye
Resulting from discussion here: http://gcc.gnu.org/ml/gcc/2014-04/msg00125.html ChangeLog: * g++.dg/cpp0x/nsdmi-union5.C: Change to runtime test. Index: gcc/testsuite/g++.dg/cpp0x/nsdmi-union5.C === ---

[C PATCH] Warn if switch has boolean value (PR c/60439)

2014-04-17 Thread Marek Polacek
This patch implements a new warning that warns when controlling expression of a switch has boolean value. (Intentionally I don't warn if the controlling expression is (un)signed:1 bit-field.) I guess the question is if this should be enabled by default or deserves some new warning option. Since

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-04-17 Thread Marc Glisse
On Fri, 18 Apr 2014, Marek Polacek wrote: This patch implements a new warning that warns when controlling expression of a switch has boolean value. (Intentionally I don't warn if the controlling expression is (un)signed:1 bit-field.) I guess the question is if this should be enabled by default