Re: [patch] libstdc++/61390 don't redeclare template-parameters

2014-08-04 Thread Jonathan Wakely
On 10/06/14 19:09 +0100, Jonathan Wakely wrote: Yo dawg, I heard you like templates, so I renamed the template-parameters of your template template-parameters so they are not the same as the template-parameters of your templates. G++ fails to diagnose this (PR17267) but Clang gives an error and

[PATCH] gcc/testsuite: Disable pr44194-1.c for BE Power64/Linux

2014-08-04 Thread Maciej W. Rozycki
Hi, The pr44194-1.c test case scores a failure invariably for big-endian Power64/Linux targets: PASS: gcc.dg/pr44194-1.c (test for excess errors) FAIL: gcc.dg/pr44194-1.c scan-rtl-dump dse1 global deletions = (2|3) PASS: gcc.dg/pr44194-1.c scan-rtl-dump-not final insn[: ][^\n]*set

Re: [patch] Add const to constexpr member functions

2014-08-04 Thread Jonathan Wakely
On 15/04/14 19:29 +0100, Jonathan Wakely wrote: Add const to functions that would change meaning in C++14. Tested x86_64-linux, committed to trunk. Also committed to the 4.9 branch * include/bits/atomic_base.h (__atomic_base_PTp*::_M_type_size): Add const to constexpr member

Re: [patch cp]: Check for keep-inline-dllexport that we are operating on true inlines

2014-08-04 Thread Jason Merrill
OK. Jason

Re: {patch cp]: Disable hidden-inlines for pe-coff targets

2014-08-04 Thread Jason Merrill
On 08/04/2014 07:03 AM, Kai Tietz wrote: * decl2.c (determine_hidden_inline): Always fail for PE-COFF as there is no hidden visibility available. I'd think we should give a warning about -fvisibility-inlines-hidden on windows and turn off the flag rather than silently ignore it

Invalid gimple for nested functions

2014-08-04 Thread Bernd Schmidt
Some code I added for the ptx backend triggered tree-checking failures for gimple created in tree-nested: we can end up taking the address of an SSA_NAME, which seems invalid. The problem is that code in tree-nested wants to change the rhs of an existing assignment, but just using

Re: [C++ Patch/RFC] PR 43906

2014-08-04 Thread Jason Merrill
On 08/04/2014 12:24 PM, Paolo Carlini wrote: + || (TYPE_PTR_P (type1) VOID_TYPE_P (TREE_TYPE (type1)) Why check for VOID_TYPE_P? I'd think we would want to warn about comparing to other null pointer values as well. Jason

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-04 Thread Joseph S. Myers
On Mon, 4 Aug 2014, Alexander Ivchenko wrote: +2014-08-04 Alexander Ivchenko alexander.ivche...@intel.com + + * inclhack.def (stdio_va_list): Disable fix for *android*. Testing for *android* is less than ideal, because of the possibility of configuring a *-linux* toolchain to have

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-04 Thread Andrew Pinski
On Mon, Aug 4, 2014 at 8:29 AM, Alexander Ivchenko aivch...@gmail.com wrote: Hi, The following patch disables stdio_va_list fix: stdio.h is already good in Android and, since ndk gcc is indented to be used with different Android sysroots, it is actually harmful, because without this fix only

Re: [PATCH] gcc/testsuite: Disable pr44194-1.c for BE Power64/Linux

2014-08-04 Thread Joseph S. Myers
On Mon, 4 Aug 2014, Maciej W. Rozycki wrote: except from the newly-added 64-bit little-endian one (according to LINUX64_DEFAULT_ABI_ELFv2 defined in rs6000/sysv4le.h and then rs6000_return_in_memory) or where the `-mabi=elfv2' option has been used (that, regrettably, looks undetectable to

Re: Fwd: [RFC][gomp4] Offloading patches (2/3): Add tables generation

2014-08-04 Thread Bernd Schmidt
On 07/23/2014 04:37 PM, Ilya Verbin wrote: On 23 Jul 16:16, Bernd Schmidt wrote: Here's the latest version, which fixes some more issues and removes things that are now unnecessary. Configure scripts and toplevel autogenned stuff is left out and must be regenerated. Are you OK with me

Re: [C++ Patch/RFC] PR 43906

2014-08-04 Thread Paolo Carlini
Hi, On 08/04/2014 10:45 PM, Jason Merrill wrote: On 08/04/2014 12:24 PM, Paolo Carlini wrote: + || (TYPE_PTR_P (type1) VOID_TYPE_P (TREE_TYPE (type1)) Why check for VOID_TYPE_P? I'd think we would want to warn about comparing to other null pointer values as well. In fact I

[PING][Patch]Fix ICE for gcc.dg/noncompile/920507-1.c

2014-08-04 Thread Tony Wang
Ping, any comment and suggestion on this bug fix? -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Tony Wang Sent: Tuesday, July 29, 2014 10:31 AM To: gcc-patches@gcc.gnu.org; 'Richard Biener'; 'Jakub Jelinek' Subject:

Re: [C++ Patch/RFC] PR 43906

2014-08-04 Thread Jason Merrill
On 08/04/2014 07:01 PM, Paolo Carlini wrote: In fact I wondered about that a few minutes after sending my message... And this is what I figured out: normally we have hard errors from composite_pointer_type (eg, try scalar types, class types), even for null values. The only exception I have been

Go patch committed: Fix test of 64-bit index on 32-bit system

2014-08-04 Thread Ian Lance Taylor
This patch to the Go frontend changes it to not cast an index expression to int before checking whether the value is in bounds. This fixes PR 61866: on a 32-bit system, casting an int64 index to int drops the upper 32 bits of the value, and thus can cause an out-of-range index to appear to be in

Go patch committed: Fix enclosing vars for func type in func lit

2014-08-04 Thread Ian Lance Taylor
This patch to the Go frontend fixes a dumb bug in which the enclosing vars were incorrectly cleared when a function literal contains a reference to a function type. The test for this has been committed to the master repository: http://codereview.appspot.com/121200043 . This fixes PR 61308.

[GSoC] the separate option for all dimensions

2014-08-04 Thread Roman Gareev
I've attached the patch, which sets the separate option for all dimensions. Is it fine for trunk? -- Cheers, Roman Gareev. 2014-08-05 Roman Gareev gareevro...@gmail.com [gcc/] * graphite-isl-ast-to-gimple.c: (set_options): New function.

<    1   2