Re: [PATCH] IPA ICF: memory leak fix

2014-11-23 Thread Markus Trippelsdorf
On 2014.11.22 at 17:46 +0100, Markus Trippelsdorf wrote: On 2014.11.22 at 16:04 +0100, Martin Liška wrote: On 11/22/2014 10:09 AM, Markus Trippelsdorf wrote: On 2014.11.22 at 09:05 +0100, Martin Liška wrote: Following patch removes memory leak that was introduced by very first IPA

[RFC,PATCH,testsuite] Set gcc_force_conventional_output even without LTO linker plugin

2014-11-23 Thread Matthew Fortune
Hi, I have had to use this patch several times when performing cross testing but I'm not sure if it is the right fix. The MIPS target testsuite runs all tests regardless of the current compiler configuration and downgrades run tests to link tests and then to assembly tests depending on what

[Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread Tobias Burnus
This patch moves -Wtabs closer to the common diagnostics - and changed the odd reversed logic of flags = 0 meaning off. This brings nice common diagnostic features to fixed-form source code for the initial indentation [tab = 6 spaces] (which doesn't show a location), but not to free-form

Re: Fix vectorizer conditions on updating alignment

2014-11-23 Thread Eric Botcazou
It's quite recent and it will break Ada iirc. I don't think so, it will break the case for which it was added, possibly something to do with Altivec. But doing svn annotate is easy enough. -- Eric Botcazou

[Committed] Add some more testcases

2014-11-23 Thread Andrew Pinski
Hi, While looking at what patches I had in the internal tree here at Cavium, I noticed two more testcases which I did upstream already. One testcase for PR 53135 (reduced from dhcp-server) and another one for an ICE which showed up while improving PHI-OPT (reduced from gnupg-2.0.18). Committed

[C++ Patch, trivial?] PR 63905

2014-11-23 Thread Paolo Carlini
Hi, submitter noticed that when Honza in r201994 changed DECL_CONSTRUCTOR_P/DECL_DESTRUCTOR_P to use middle-end flags forgot to remove the unused front-end flags. Tested x86_64-linux. Thanks! Paolo. PS: FWIW, the issue still exists in 4_9-branch too. /// 2014-11-23 Paolo

Re: Localize symbols used only from comdat groups

2014-11-23 Thread H.J. Lu
On Sun, May 18, 2014 at 4:56 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch adds simple IPA pass that brings symbols used only from comdat groups into the groups. This prevents dead code in cases where the comdat group is replaced by a copy from different unit. The patch saves about

Re: [Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread FX
Build and regtested on x86-64-gnu-linux. OK for the trunk? OK. One question: I don’t understand why you need two separate Wtabs lines in lang.opt. FX

Re: [Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread Tobias Burnus
FX wrote: OK. One question: I don’t understand why you need two separate Wtabs lines in lang.opt. Thanks for the review! Because EnabledByLanguage(Fortran,Wall || Wpedantic) isn't supported – using two separate Wtabs is the work around. Cf.

Re: [Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread FX
Because EnabledByLanguage(Fortran,Wall || Wpedantic) isn't supported – using two separate Wtabs is the work around. Cf. https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02895.html You’re the best :) FX

[patch fortran/44054] handle %L using the common diagnostics machinery

2014-11-23 Thread Manuel López-Ibáñez
Exactly what the subject says. I'm not sure if this is appropriate for stage3, I'll leave that to the Fortran maintainers. Bootstrapped regression tested on x86_64-linux-gnu. Cheers, Manuel. gcc/fortran/ChangeLog: 2014-11-23 Manuel López-Ibáñez m...@gcc.gnu.org PR fortran/44054 *

[PATCH] pr63856 - test case

2014-11-23 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Hi, bug was already fixed, so just add the test case. tested this only passes with r217909 where it is fixed, ok? Trev diff --git a/gcc/testsuite/gcc.dg/pr63856.c b/gcc/testsuite/gcc.dg/pr63856.c new file mode 100644 index 000..8fb65c6 ---

Re: [Patch, Fortran] -Wtabs cleanup

2014-11-23 Thread Manuel López-Ibáñez
On 23 November 2014 at 10:27, Tobias Burnus bur...@net-b.de wrote: This patch moves -Wtabs closer to the common diagnostics - and changed the odd reversed logic of flags = 0 meaning off. You may wish to update the documentation to reflect this change in behavior (invoke.texi, lang.opt and

Re: [PATCH] pr63856 - test case

2014-11-23 Thread Jakub Jelinek
On Sun, Nov 23, 2014 at 01:32:27PM -0500, tsaund...@mozilla.com wrote: bug was already fixed, so just add the test case. tested this only passes with r217909 where it is fixed, ok? Trev diff --git a/gcc/testsuite/gcc.dg/pr63856.c b/gcc/testsuite/gcc.dg/pr63856.c new file mode 100644

[PATCH] pr61324 pr 63649 - fix crash in ipa_comdats

2014-11-23 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Hi, the interesting symbol in the test case for pr61324 is __GLOBAL__sub_I_s. It refers to nothing, and is called by nothing, however it is kept (I believe because of -fkeep-inline-functions). That means ipa_comdats never tries to put it in a comdat,

Re: [patch fortran/44054] handle %L using the common diagnostics machinery

2014-11-23 Thread Tobias Burnus
Manuel López-Ibáñez wrote: Exactly what the subject says. I'm not sure if this is appropriate for stage3, I'll leave that to the Fortran maintainers. Bootstrapped regression tested on x86_64-linux-gnu. Looks good to me - and is a rather simple patch. Thanks! Tobias gcc/fortran/ChangeLog:

[Patch, Fortran] Remove gfc_fatal_error_1

2014-11-23 Thread Tobias Burnus
This patch depends on Manuel's %L patch. It converts the remaining fatal error calls to the common diagnostic infrastructure and retires (removes) the old gfc_fatal_error_1. I will build and regtest it after Manuel's commit. OK, when it succeeds? Tobias 2014-11-23 Tobias Burnus

Re: [Patch, option handling] optc-gen.awk - support || in EnabledBy()

2014-11-23 Thread Tobias Burnus
Manuel López-Ibáñez wrote: For what is worth, the patch looks good to me, except that the form EnabledBy(@var{opt} || @var{opt2} needs documentation in doc/options.texi. Done. Perhaps it could be more condensed as (untested!): Seems to work - hence: Done. A version handling

[Fortran, Patch, committed] Fix coloring of : in diagnostic messages

2014-11-23 Thread Tobias Burnus
In C etc., the colon is colored the same way as the preceeding word (warning:), in Fortran, it wasn't. Fixed as obvious; committed as Rev. 217986. Tobias Index: gcc/fortran/ChangeLog === --- gcc/fortran/ChangeLog (Revision 217985)

Re: [PATCH] pr63856 - test case

2014-11-23 Thread Trevor Saunders
On Sun, Nov 23, 2014 at 07:58:30PM +0100, Jakub Jelinek wrote: On Sun, Nov 23, 2014 at 01:32:27PM -0500, tsaund...@mozilla.com wrote: bug was already fixed, so just add the test case. tested this only passes with r217909 where it is fixed, ok? Trev diff --git

Re: [PATCH] pr63856 - test case

2014-11-23 Thread Jakub Jelinek
On Sun, Nov 23, 2014 at 03:42:43PM -0500, Trevor Saunders wrote: Vector arguments or return values often result in -Wpsabi warnings, so you certainly want -Wno-psabi in dg-options. On the other side, -fPIC should be only used for { target pic }, so better put that into

Re: [Patch, Fortran] Remove gfc_fatal_error_1

2014-11-23 Thread FX
I will build and regtest it after Manuel's commit. OK, when it succeeds? OK indeed.

[SH][committed] Handle complex edges in sh_optimize_sett_clrt

2014-11-23 Thread Oleg Endo
Hi, As mentioned in the PR, a case has popped up which blew the sh_optimize_sett_clrt pass away. The quick fix was to bail out on handle complex edges. Tested with make all-gcc, running the sh.exp tests. Committed to trunk as r217987 and to 4.9 branch as r217989. Cheers, Oleg gcc/ChangeLog:

[Patch, Fortran, committed] invoke.texi - updated -Wtabs description

2014-11-23 Thread Tobias Burnus
Fix -Wtabs description, matching current implementation. Committed as Rev. 217990. Tobias diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index 12ec7e2..41169a8 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,5 +1,10 @@ 2014-11-23 Tobias Burnus bur...@net-b.de

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-23 Thread Sebastian Pop
Jeff Law wrote: PS: I have run some perf analysis with the patch: - on a bootstrap of GCC I see 3209 FSM jump threads - libpng and libjpeg contain FSM jump threads, the perf increase is in the 1% (measured on simulators and reduced data sets) - coremark gets jump threaded (as expected) -

PR 13631 Problems in messages

2014-11-23 Thread François Dumont
Hello As we are at doing some evolution in the ABI I would like to take the opportunity to merge branch libstdcxx_so_7-2. The first fix was about a messages facet issue. So here is the version for the trunk which is the one from the branch plus management of the charset part. This way

Re: [Patch, Fortran] Remove gfc_fatal_error_1

2014-11-23 Thread Manuel López-Ibáñez
On 23 November 2014 at 21:21, Tobias Burnus bur...@net-b.de wrote: This patch depends on Manuel's %L patch. It converts the remaining fatal error calls to the common diagnostic infrastructure and retires (removes) the old gfc_fatal_error_1. I will build and regtest it after Manuel's commit.

[patch, build] Restore bootstrap in building libcc1 on darwin

2014-11-23 Thread FX
tl;dr: One question to build maintainers, and one patch submitted to toplevel configure.ac --- I’m looked into the issue some more, and am comparing two builds of trunk (exact same source), one configured with system compiler (clang) in PATH, the other with GCC 4.9.2 in PATH. At

Re: PR 13631 Problems in messages

2014-11-23 Thread Jonathan Wakely
On 24/11/14 00:13 +0100, François Dumont wrote: Hello As we are at doing some evolution in the ABI I would like to take the opportunity to merge branch libstdcxx_so_7-2. The first fix was I don't think we want to merge everything, but it's certainly worth looking to see if there are some

[PATCH, committed] AIX gcc.dg testsuite patches

2014-11-23 Thread David Edelsohn
This fixes a few more testsuite failures on AIX. -fcompare-debug does not work correctly on AIX and some vector tests generate extra warnings about use of a non-standard ABI. Bootstrapped on powerpc-ibm-aix7.1.0.0 Thanks, David * gcc.dg/autopar/pr46799.c: XFAIL on AIX. *

Re: [C++ Patch, trivial?] PR 63905

2014-11-23 Thread Jason Merrill
OK. Jason

[PATCH, PR c++/58561] dbxout.c and TEMPLATE_TYPE_PARM

2014-11-23 Thread David Edelsohn
The patch for PR c++/58561 fixed DWARF, but did not fix Stabs debugging. The follow patch at least stops G++ from ICE'ing for a return type of auto. I'm not sure what type of debugging stabs should generate, if it can represent it. Thanks, David PR c++/58561 * dbxout.c: Include stringpool.h

Re: [PATCH, PR c++/58561] dbxout.c and TEMPLATE_TYPE_PARM

2014-11-23 Thread Jason Merrill
OK. Jason

RE: [PATCH, ifcvt] Fix PR63917

2014-11-23 Thread Zhenqiang Chen
-Original Message- From: Richard Henderson [mailto:r...@redhat.com] Sent: Friday, November 21, 2014 2:27 AM To: Zhenqiang Chen; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ifcvt] Fix PR63917 On 11/20/2014 10:48 AM, Zhenqiang Chen wrote: +/* Check X clobber CC reg or not. */

[PATCH 0/3] Finish removing param_is and if_marked

2014-11-23 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com HI, unfortunately this got finished up later than I hoped, but I don't see a reason to keep it private till next stage 1. The nvptx port snuck in a few more uses of if_marked, and I forgot about the silly use of ggc in lto.c, which are taken care of

[PATCH 2/3] move gimple_canonical_types htab out of gc memory

2014-11-23 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Hi, The memory allocated for the hash table is never rooted by anything, so keeping it in gc memory only works if it never needs to survive a gc. Trev lto/ * lto.c (read_cgraph_and_symbols): allocate gimple_canonical_types htab with

[PATCH 1/3] remove param_is from nvptx

2014-11-23 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Hi, $subject Trev gcc/ * config/nvptx/nvptx.c: Convert htabs to hash_table. --- gcc/config/nvptx/nvptx.c | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff --git

[PATCH 3/3] remove gengtype support for param_is use_param, if_marked and splay tree allocators

2014-11-23 Thread tsaunders
From: Trevor Saunders tsaund...@mozilla.com Hi, The one interesting part of this is what we do about plugins. As you can tell from the diff removing support for these gengtype features makes things much simpler, and I think the only way to do that is to remove the plugin hook for adding caches.

[PATCH, AARCH64] Fix ICE in CCMP (PR64015)

2014-11-23 Thread Zhenqiang Chen
Hi, Expand pass always uses sign-extend to represent constant value. For the case in the patch, a 8-bit unsigned value 252 is represented as -4, which pass the ccmn check. After mode conversion, -4 becomes 252, which leads to mismatch. The patch adds another operand check after mode conversion.

Re: [PATCH, AARCH64] Fix ICE in CCMP (PR64015)

2014-11-23 Thread Andrew Pinski
On Sun, Nov 23, 2014 at 9:11 PM, Zhenqiang Chen zhenqiang.c...@arm.com wrote: Hi, Expand pass always uses sign-extend to represent constant value. For the case in the patch, a 8-bit unsigned value 252 is represented as -4, which pass the ccmn check. After mode conversion, -4 becomes 252,

Re: [PATCH v3] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow

2014-11-23 Thread Jakub Jelinek
On Sun, Nov 23, 2014 at 09:13:27AM +0800, Chen Gang wrote: 2014-11-23 Chen Gang gang.chen.5...@gmail.com * ubsan.c (ubsan_type_descriptor): Use 'pretty_print' for 'pretty_name' to avoid memory overflow. Ok, with a small nit below. gcc/ubsan.c | 63