Re: [PATCH 04/08] PR jit/63854: Remove xstrdup from ipa/cgraph fprintf calls

2014-11-26 Thread Uros Bizjak
Hello! cgraph*.c and ipa-*.c use xstrdup on strings when dumping them via fprintf, leaking all of the duplicated buffers. Is/was there a reason for doing this? Yes, please see [1] and PR 53136 [2]. As said in [1]: There is a problem with multiple calls of cgraph_node_name in fprintf dumps.

Patch ping^2: [PATCH] -fsanitize=vptr instrumentation (take 2)

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 03:05:46PM +0100, Jakub Jelinek wrote: On Tue, Oct 28, 2014 at 01:44:50PM +0100, Jakub Jelinek wrote: On Mon, Oct 27, 2014 at 05:16:05PM +0100, Jakub Jelinek wrote: Here is an updated patch, ok if bootstrap/testing passes (so far just checked with make -j16 -k

RE: [PATCH][MIPS] Fix P5600 memory cost

2014-11-26 Thread Prachi Godbole
Committed with ChangeLog entry fixes. Prachi -Original Message- From: Matthew Fortune Sent: Wednesday, November 5, 2014 4:07 PM To: Prachi Godbole; gcc-patches@gcc.gnu.org Subject: RE: [PATCH][MIPS] Fix P5600 memory cost The patch below fixes the memory cost for P5600. ChangeLog:

[Committed] Add a new testcase

2014-11-26 Thread Andrew Pinski
Hi, While working on an aarch64 patch, I ran into wrong code produced by my patch. I am not ready to submit the patch yet but since I reduced the testcase and there was no testcase in the testsuite yet, I thought I commit the testcase. This testcase is reduced from

Re: [PATCH] Add a new option -fmerge-bitfields (patch / doc inside)

2014-11-26 Thread Andrew Pinski
On Wed, Oct 29, 2014 at 6:34 AM, Zoran Jovanovic zoran.jovano...@imgtec.com wrote: Hello, This is new patch version in which reported issue is fixed. Also, patch is rebased to the revision 216452 and some minor code clean-up is done. FYI. This causes gfc_add_interface_mapping in

Re: [PATCH] Enhance ASAN_CHECK optimization

2014-11-26 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 08:06:00PM +0300, Yury Gribov wrote: +/* Traits class for tree hash maps below. */ + +struct tree_map_traits : default_hashmap_traits +{ + static inline hashval_t hash (const_tree ref) +{ + return iterative_hash_expr (ref, 0); +} + + static inline

RE: [PATCH, AARCH64] Fix ICE in CCMP (PR64015)

2014-11-26 Thread Zhenqiang Chen
-Original Message- From: Richard Henderson [mailto:r...@redhat.com] Sent: Tuesday, November 25, 2014 5:25 PM To: Zhenqiang Chen Cc: Marcus Shawcroft; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, AARCH64] Fix ICE in CCMP (PR64015) On 11/25/2014 09:41 AM, Zhenqiang Chen wrote: I

Re: [PATCH v3] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-26 Thread Chen Gang
On 11/26/14 15:33, Jakub Jelinek wrote: On Wed, Nov 26, 2014 at 09:41:16AM +0800, Chen Gang wrote: On 11/26/14 8:31, Joseph Myers wrote: On Wed, 26 Nov 2014, Chen Gang wrote: + gcc_assert (wi::fits_to_tree_p (value, char_type_node) +|| wi::fits_to_tree_p (value,

[PATCH] Fix PR lto/64075

2014-11-26 Thread Ilya Enkovich
Hi, This patch fixes LTO streamers which were not adjusted when function_code field was extended up to 12 bits. OK for trunk after bootstrap and check? Thanks, Ilya -- gcc/ 2014-11-26 Ilya Enkovich ilya.enkov...@intel.com * tree-streamer-in.c (unpack_ts_function_decl_value_fields):

Re: [PATCH 01/08] PR jit/63854: Fix leak in tree-ssa-math-opts.c

2014-11-26 Thread Richard Biener
On Wed, Nov 26, 2014 at 2:39 AM, David Malcolm dmalc...@redhat.com wrote: Running testsuite/jit.dg/test-functions.c under valgrind showed this leak (amongst others): 400 bytes in 10 blocks are definitely lost in loss record 142 of 181 at 0x4A0645D: malloc (in

Re: [PATCH 03/08] PR jit/63854: Fix leak in real.c for i386:init_ext_80387_constants

2014-11-26 Thread Richard Biener
On Wed, Nov 26, 2014 at 2:39 AM, David Malcolm dmalc...@redhat.com wrote: Valgrind of testsuite/jit.dg/test-types.c showed this leak in real.c when converting the strings in init_ext_80387_constants to real. 160 bytes in 5 blocks are definitely lost in loss record 89 of 144 at 0x4A0645D:

Re: [PATCH] Fix PR lto/64075

2014-11-26 Thread Richard Biener
On Wed, Nov 26, 2014 at 10:35 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes LTO streamers which were not adjusted when function_code field was extended up to 12 bits. OK for trunk after bootstrap and check? Ok. Thanks, Richard. Thanks, Ilya -- gcc/ 2014-11-26

Re: [PATCH][AArch64] Implement vsqrt_f64 intrinsic

2014-11-26 Thread Christophe Lyon
Hi Kyrill, On 21 November 2014 at 16:52, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 17 November 2014 17:35, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: 2014-11-17 Kyrylo Tkachov kyrylo.tkac...@arm.com * config/aarch64/arm_neon.h (vsqrt_f64): New intrinsic. 2014-11-17

[PATCH] Fix overly restrictive condition in get_symbol_constant_value

2014-11-26 Thread Richard Biener
The following fixes an overly restrictive condition on the zeros we produce when folding a read from a zero-initialized global. Now it matches what we allow elsewhere and what is useful. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-26 Richard Biener

Re: [PATCH 2/2] PR debug/38757 continued. Handle C11, C++11 and C++14.

2014-11-26 Thread Mark Wielaard
On Fri, 2014-11-21 at 21:34 +0100, Mark Wielaard wrote: On Fri, Nov 21, 2014 at 09:28:45AM +0100, Jakub Jelinek wrote: I think best would be to tweak if (value 2 || value 4) error_at (loc, dwarf version %d is not supported, value); else opts-x_dwarf_version

Re: [PATCH 2/2] PR debug/38757 continued. Handle C11, C++11 and C++14.

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 11:19:42AM +0100, Mark Wielaard wrote: Ping. Rebased patch attached. I have submitted patches for elfutils, valgrind, gdb and binutils for this. But they are pending till this patch hits GCC first. Ok, thanks. Jakub

[PATCH] Fix PR63738

2014-11-26 Thread Richard Biener
I am testing the following (obvious) patch to avoid generating overlapping life-ranges for SSA names that occur in abnormal PHIs. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2014-11-26 Richard Biener rguent...@suse.de PR middle-end/63738 *

Re: [PATCH] Fix PR lto/64075

2014-11-26 Thread H.J. Lu
On Wed, Nov 26, 2014 at 1:35 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes LTO streamers which were not adjusted when function_code field was extended up to 12 bits. OK for trunk after bootstrap and check? Thanks, Ilya -- gcc/ 2014-11-26 Ilya Enkovich

[Ping]Re: [PR63762][4.9] Backport the patch which fixes GCC generates UNPREDICTABLE STR with Rn = Rt for arm

2014-11-26 Thread Renlin Li
On 20/11/14 16:17, Renlin Li wrote: Hi all, This is a backport for gcc-4_9-branch of the patch [PR63762]GCC generates UNPREDICTABLE STR with Rn = Rt for arm posted in: https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02253.html arm-none-eabi has been test on the model, no new issues.

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes GCC generates UNPREDICTABLE STR with Rn = Rt for arm

2014-11-26 Thread H.J. Lu
On Wed, Nov 26, 2014 at 4:07 AM, Renlin Li renlin...@arm.com wrote: On 20/11/14 16:17, Renlin Li wrote: Hi all, This is a backport for gcc-4_9-branch of the patch [PR63762]GCC generates UNPREDICTABLE STR with Rn = Rt for arm posted in:

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2014-11-26 Thread Andrew Stubbs
On 14/11/14 11:12, Andrew Stubbs wrote: On 07/11/14 10:35, Andrew Stubbs wrote: if armv6 never co-exist with NEON, personally I think your original patch is better because TARGET_NEON generally will be used when all options are processed. any way, this needs gate keeper's approval.

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-26 Thread Ilya Enkovich
On 25 Nov 15:03, Ilya Enkovich wrote: 2014-11-25 14:11 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich enkovich@gmail.com wrote: Ok, then it's get_for_asmname (). That said - the above loops look bogus to me. Honza - any better

[PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Ilya Enkovich
Hi, This patch makes optimization for bounds lifetime reduction to ignore debug stetments. This fixes stage2 and stage3 comparision for instrumented boostrap. OK for trunk? Thanks, Ilya -- 2014-11-26 Ilya Enkovich ilya.enkov...@intel.com PR bootstrap/63995 *

Re: [PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 03:41:46PM +0300, Ilya Enkovich wrote: Hi, This patch makes optimization for bounds lifetime reduction to ignore debug stetments. This fixes stage2 and stage3 comparision for instrumented boostrap. OK for trunk? Please add a small testcase (with -fcompare-debug

Re: [patch] Flatten streamer header files Pt. 1

2014-11-26 Thread Andrew MacLeod
On 11/20/2014 03:14 PM, Andrew MacLeod wrote: On 11/20/2014 03:05 PM, Michael Collison wrote: This is a part one of two part patch that flattens gimple-streamer.h, lto-streamer.h and tree-streamer.h. This work is part of the GCC Re-Architecture effort being led by Andrew MacLeod. In

[PING] Fix gcc_assert in expand_omp_for_static_chunk

2014-11-26 Thread Tom de Vries
On 12-11-14 11:00, Tom de Vries wrote: Jakub, this patch fixes a gcc_assert in expand_omp_for_static_chunk. The assert follows a loop with composite loop condition: ... vecedge_var_map *head = redirect_edge_var_map_vector (re); ene = single_succ_edge (entry_bb); psi =

Re: [PATCH][AArch64] Remove crypto extension from default for cortex-a53, cortex-a57

2014-11-26 Thread Gerald Pfeifer
On Tuesday 2014-11-25 16:08, Kyrill Tkachov wrote: The change is to the behaviour of -mcpu, not -march. -march is only mentioned as a way of getting the previous behaviour if the user so wishes. Ah, okay. How about this amendment? Where you have add the code+crypto/code extension to the

[testsuite, i386] XFAIL gcc.target/i386/mcount_pic.c etc. on Solaris

2014-11-26 Thread Rainer Orth
Two tests scanning for get_pc_thunk were FAILing on Solaris/x86: FAIL: gcc.target/i386/mcount_pic.c (test for excess errors) WARNING: gcc.target/i386/mcount_pic.c compilation failed to produce executable FAIL: gcc.target/i386/mcount_pic.c scan-assembler get_pc_thunk FAIL:

[v3] XFAIL 27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc on Solaris (PR libstdc++/64054)

2014-11-26 Thread Rainer Orth
The 27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc currently FAILs on Solaris FAIL: 27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc execution test As determined in the PR, this happens because Solaris only supports hexfloats in C99 mode, but gcc doesn't correctly link with

Re: [PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Ilya Enkovich
On 26 Nov 13:46, Jakub Jelinek wrote: On Wed, Nov 26, 2014 at 03:41:46PM +0300, Ilya Enkovich wrote: Hi, This patch makes optimization for bounds lifetime reduction to ignore debug stetments. This fixes stage2 and stage3 comparision for instrumented boostrap. OK for trunk? Please

Re: [PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 04:48:13PM +0300, Ilya Enkovich wrote: 2014-11-26 Ilya Enkovich ilya.enkov...@intel.com PR bootstrap/63995 * tree-chkp-opt.c (chkp_reduce_bounds_lifetime): Ignore debug statement when searching for a new position for bounds load/creation

[PATCH] Fix PR63704

2014-11-26 Thread Richard Biener
The following fixes the assert in mems_in_disjoint_alias_sets_p trigger. What the comment says can easily happen by using attribute((optimize(O3))) inside a -fno-strict-aliasing TU. Dependent on luck a global variable may get a alias-set non-zero MEM if expanded from the -O3 context and thus

Re: [PATCH] Fix sanitizer/63788

2014-11-26 Thread Marek Polacek
Ping. On Wed, Nov 19, 2014 at 08:09:21PM +0100, Marek Polacek wrote: As discussed in the PR, the problem here is that when running gfortran, the __builtin_object_size decl isn't available, because c-family's c_define_builtins wasn't called. One way how to fix this is to build the

Re: [PATCH] Fix sanitizer/63788

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 02:57:20PM +0100, Marek Polacek wrote: Ping. Ok, thanks. On Wed, Nov 19, 2014 at 08:09:21PM +0100, Marek Polacek wrote: As discussed in the PR, the problem here is that when running gfortran, the __builtin_object_size decl isn't available, because c-family's

Re: [PATCH 04/08] PR jit/63854: Remove xstrdup from ipa/cgraph fprintf calls

2014-11-26 Thread David Malcolm
On Wed, 2014-11-26 at 09:13 +0100, Uros Bizjak wrote: Hello! cgraph*.c and ipa-*.c use xstrdup on strings when dumping them via fprintf, leaking all of the duplicated buffers. Is/was there a reason for doing this? Yes, please see [1] and PR 53136 [2]. As said in [1]: There is a

Re: [patch] Fix handling of inlining and nested functions in dwarf2out.c

2014-11-26 Thread Jason Merrill
I ran a quick test to see if the output after this patch matches the examples in D.7, and it does. So the patch is OK. Jason

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-26 Thread Ilya Tocar
I think using cpuid for that is just fine. __builtin_cpu_supports is for ISA additions users might actually want to version code for, MPX stuff, as the instructions are nops without hw support, are not something one would multi-version a function for. If anything, AVX512F and

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-26 Thread Manuel López-Ibáñez
Sorry to be pedantic, but I think this is not exactly right: +if (cxx_dialect = cxx11) + { + if (pedantic) + pedwarn (input_location, OPT_Wpedantic, + ISO C++ forbids converting a string constant to %qT, + totype); + else + warning (OPT_Wwrite_strings, + ISO C++ forbids

[Build, Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

2014-11-26 Thread Tobias Burnus
This patch adds a configure check for isl_schedule_constraints_compute_schedule, which is new in ISL 0.13 - and uses it for conditional compilation. The graphite*c patch is based on the one of Jack Howarth, https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00906.html - without checking whether the

Ping with testcase: [PATCH][AArch64] Fix __builtin_aarch64_absdi, must not fold to ABS_EXPR

2014-11-26 Thread Alan Lawrence
So in case there's any confusion about the behaviour expected of *the vabs intrinsic*, here's a testcase (failing without patch, passing with it)... --Alan Alan Lawrence wrote: ...as the former is defined as returning MIN_VALUE for argument MIN_VALUE, whereas the latter is 'undefined', and

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-26 Thread Jason Merrill
On 11/26/2014 10:48 AM, Manuel López-Ibáñez wrote: If I understand correctly, the cxx11 standard requires to diagnose this. Thus, it should be always a pedwarn, independently of Wpedantic. I agree. This is what I checked in: commit 2aeccf739475ee181f4ca6422776b46bc9526352 Author: jason

Re: [Build, Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

2014-11-26 Thread Tobias Grosser
On 26.11.2014 16:55, Tobias Burnus wrote: This patch adds a configure check for isl_schedule_constraints_compute_schedule, which is new in ISL 0.13 - and uses it for conditional compilation. The graphite*c patch is based on the one of Jack Howarth,

Re: [PATCH] If using branch likelies in MIPS sync code fill the delay slot with a nop

2014-11-26 Thread Richard Sandiford
FWIW, I agree this is the right fix, but: Andrew Bennett andrew.benn...@imgtec.com writes: + /* When using branch likely (-mfix-r1), the delay slot instruction + will be annulled on false. The normal delay slot instructions + calculate the overall result of the atomic operation

Re: [PATCH 2/5] combine: handle I2 a parallel of two SETs

2014-11-26 Thread Segher Boessenkool
On Sat, Nov 15, 2014 at 06:59:23AM -0600, Segher Boessenkool wrote: On Fri, Nov 14, 2014 at 08:35:48PM +0100, Bernd Schmidt wrote: On 11/14/2014 08:19 PM, Segher Boessenkool wrote: + /* If I2 is a PARALLEL of two SETs of REGs (and perhaps some CLOBBERs), + make those two SETs separate

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-26 Thread Jan Hubicka
On 25 Nov 15:03, Ilya Enkovich wrote: 2014-11-25 14:11 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich enkovich@gmail.com wrote: Ok, then it's get_for_asmname (). That said - the above loops look bogus to me. Honza - any

[PING 3] Enhance array types debug info. for Ada

2014-11-26 Thread Pierre-Marie de Rodat
Hello, Ping for https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00694.html Thanks in advance! Regards, -- Pierre-Marie de Rodat

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-26 Thread Ilya Enkovich
2014-11-26 19:07 GMT+03:00 Jan Hubicka hubi...@ucw.cz: On 25 Nov 15:03, Ilya Enkovich wrote: 2014-11-25 14:11 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich enkovich@gmail.com wrote: Ok, then it's get_for_asmname (). That

Re: [PATCH] -fsanitize=vptr instrumentation (take 2)

2014-11-26 Thread Jason Merrill
On 10/28/2014 08:44 AM, Jakub Jelinek wrote: +cp_ubsan_check_member_access_r (tree *stmt_p, int *walk_subtrees, void *data) This function needs a longer comment about exactly what forms it's trying to instrument. + /* T t; t.foo (); doesn't need instrumentation, if the type is known. */

Re: [C++ Patch/RFC] PR 63757

2014-11-26 Thread Jason Merrill
On 11/24/2014 01:55 PM, Paolo Carlini wrote: in this rejects-valid, as part of build_user_type_conversion_1, standard_conversion is called by implicit_conversion with a *null* expr, thus the condition in standard_conversion /* [conv.ptr] A null pointer constant can be converted to a

Re: [Build, Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

2014-11-26 Thread Tobias Burnus
On Wed, Nov 26, 2014 at 04:55:40PM +0100, Tobias Burnus wrote: This patch adds a configure check for isl_schedule_constraints_compute_schedule, which is new in ISL 0.13 - and uses it for conditional compilation. Repeating the test on a massively multicore system, it fails at stage2 with an

Re: [Build, Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

2014-11-26 Thread Tobias Grosser
On 26.11.2014 17:27, Tobias Burnus wrote: On Wed, Nov 26, 2014 at 04:55:40PM +0100, Tobias Burnus wrote: This patch adds a configure check for isl_schedule_constraints_compute_schedule, which is new in ISL 0.13 - and uses it for conditional compilation. Repeating the test on a massively

Re: Ping with testcase: [PATCH][AArch64] Fix __builtin_aarch64_absdi, must not fold to ABS_EXPR

2014-11-26 Thread James Greenhalgh
On Wed, Nov 26, 2014 at 03:56:03PM +, Alan Lawrence wrote: So in case there's any confusion about the behaviour expected of *the vabs intrinsic*, here's a testcase (failing without patch, passing with it)... --Alan Alan Lawrence wrote: ...as the former is defined as returning

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-11-26 Thread Jason Merrill
Please give diagnostics explaining what's wrong with the shift rather than the generic is not a constant expression. + tree t = build_int_cst (unsigned_type_node, uprec - 1); + t = fold_build2 (MINUS_EXPR, unsigned_type_node, t, rhs); + tree ulhs = fold_convert

Re: [PATCH] Fix ubsan and C++14 constexpr ICEs (PR sanitizer/63956)

2014-11-26 Thread Jason Merrill
On 11/20/2014 02:04 PM, Marek Polacek wrote: + if (fun == NULL_TREE) +switch (CALL_EXPR_IFN (t)) + { + case IFN_UBSAN_NULL: + case IFN_UBSAN_BOUNDS: + return void_node; + default: + break; + } Other IFNs should make the call non-constant. -/* {

Re: Move dwarf2 frame tables to read-only section for AIX

2014-11-26 Thread Jason Merrill
On 09/22/2014 09:06 PM, Andrew Dixie wrote: - || ((fde_encoding 0x70) != DW_EH_PE_absptr -(fde_encoding 0x70) != DW_EH_PE_aligned -(per_encoding 0x70) != DW_EH_PE_absptr -(per_encoding 0x70) !=

Re: [PATCH 00/03] JIT refactoring

2014-11-26 Thread Jeff Law
On 11/25/14 18:45, David Malcolm wrote: Various cleanups of the jit code Successfully bootstrapped regrtested on x86_64-unknown-linux-gnu (Fedora 20). OK for trunk? (am not yet officially blessed as the JIT maintainer, so I require review for the non-obvious patches) You're now the official

RE: [Patch, ARM, ping1] Fix PR target/56846

2014-11-26 Thread Thomas Preud'homme
Ping? -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme Sent: Wednesday, November 19, 2014 6:00 PM To: Tony Wang; gcc-patches@gcc.gnu.org; d...@debian.org; aph- g...@littlepinkcloud.com; Richard Earnshaw;

Re: [Patch, ARM, ping1] Fix PR target/56846

2014-11-26 Thread Jonathan Wakely
On 26/11/14 17:23 -, Thomas Preud'homme wrote: Ping? I'm OK with backporting it if a release manager approves it. -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme Sent: Wednesday, November 19, 2014

[C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Marek Polacek
Both C11 and C++14 standards specify that integral promotions are performed on both operands of a shift-expression. This we do just fine. But then we convert the right operand to integer_type_node. Not only is this unnecessary, it can also be harfmul, because for e.g. void foo (unsigned int x)

Re: [PATCH 08/08] PR/64003 workaround (uninit memory in i386.md)

2014-11-26 Thread Jeff Law
On 11/25/14 18:39, David Malcolm wrote: I suspect this is papering over a real problem, but I've been applying this workaround locally to keep my valgrind output clean. gcc/ChangeLog: PR/64003 * final.c (shorten_branches): Allocate insn_lengths with XCNEWVEC rather than

Re: [PATCH] Enhance array types debug info. for Ada

2014-11-26 Thread Jakub Jelinek
On Wed, Oct 08, 2014 at 09:05:30PM +0200, Pierre-Marie de Rodat wrote: gcc/ * dwarf2out.h (struct array_descr_info): Remove the base_decl field. * dwarf2out.c (enum dw_scalar_form): New. (struct loc_descr_context): New. (add_scalar_info): New. (add_bound_info):

Re: [patch] Flatten streamer header files Pt. 1

2014-11-26 Thread Jeff Law
On 11/26/14 06:11, Andrew MacLeod wrote: So the question to the maintainers is whether its permissible to do a bit of flattening into the early parts of stage 3, or whether you'd rather it stay on a branch until next stage 1. Andrew PIng.. anyone want to chime in? :-) Apparently not :-) I'd

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 06:39:44PM +0100, Marek Polacek wrote: Both C11 and C++14 standards specify that integral promotions are performed on both operands of a shift-expression. This we do just fine. But then we convert the right operand to integer_type_node. Not only is this unnecessary,

Re: [patch c++]: Fix PR/53904

2014-11-26 Thread Kai Tietz
Ok. Adjusted patch attached. Nevertheless we should use here unsigned HWI instead of possible truncation to signed int. I admit that it is unlikely to have more then 2^31 elements, but well Ok for apply with adjusted ChangeLog? Regards, Kai Index: constexpr.c

Re: [Patch, Fortran] convert almost all {warning,error}_now to common diagnostic

2014-11-26 Thread Manuel López-Ibáñez
On 25 November 2014 at 23:42, Tobias Burnus bur...@net-b.de wrote: FX: (a) those majority which might need buffering (gfc_error, gfc_warning); Is there a plan for those in the longer term? Well, the long-term solution is of course to support them. That requires adding buffering+discarding

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes GCC generates UNPREDICTABLE STR with Rn = Rt for arm

2014-11-26 Thread Renlin Li
On 26/11/14 12:16, H.J. Lu wrote: On Wed, Nov 26, 2014 at 4:07 AM, Renlin Li renlin...@arm.com wrote: On 20/11/14 16:17, Renlin Li wrote: Hi all, This is a backport for gcc-4_9-branch of the patch [PR63762]GCC generates UNPREDICTABLE STR with Rn = Rt for arm posted in:

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes GCC generates UNPREDICTABLE STR with Rn = Rt for arm

2014-11-26 Thread H.J. Lu
On Wed, Nov 26, 2014 at 10:09 AM, Renlin Li renlin...@arm.com wrote: On 26/11/14 12:16, H.J. Lu wrote: On Wed, Nov 26, 2014 at 4:07 AM, Renlin Li renlin...@arm.com wrote: On 20/11/14 16:17, Renlin Li wrote: Hi all, This is a backport for gcc-4_9-branch of the patch [PR63762]GCC generates

Re: [PATCH 3/5] combine: add regno field to LOG_LINKS

2014-11-26 Thread Jeff Law
On 11/25/14 14:47, Segher Boessenkool wrote: On Tue, Nov 25, 2014 at 11:46:52AM -0700, Jeff Law wrote: On 11/14/14 12:19, Segher Boessenkool wrote: With this new field in place, we can have LOG_LINKS for insns that set more than one register and distribute them properly in distribute_links.

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Joseph Myers
On Wed, 26 Nov 2014, Marek Polacek wrote: Joseph, is that C FE part ok? The C changes are OK once Jakub's middle-end/expander issue is resolved (possibly by adding execution tests of shifts by in-range 64-bit and 128-bit integers, both constant and non-constant, and compilation tests of

Two small constexpr PATCHes

2014-11-26 Thread Jason Merrill
1) It occurred to me that now that there are side-effects in constant-expressions, we need to guard against multiple evaluation of SAVE_EXPR. 2) We don't want to complain about flowing off the end of a function because something in the function was non-constant. Tested x86_64-pc-linux-gnu,

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Marek Polacek
On Wed, Nov 26, 2014 at 06:50:29PM +0100, Jakub Jelinek wrote: On Wed, Nov 26, 2014 at 06:39:44PM +0100, Marek Polacek wrote: Both C11 and C++14 standards specify that integral promotions are performed on both operands of a shift-expression. This we do just fine. But then we convert the

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Jason Merrill
On 11/26/2014 01:18 PM, Joseph Myers wrote: On Wed, 26 Nov 2014, Marek Polacek wrote: Joseph, is that C FE part ok? The C changes are OK once Jakub's middle-end/expander issue is resolved (possibly by adding execution tests of shifts by in-range 64-bit and 128-bit integers, both constant and

Re: [PATCH] Enhance ASAN_CHECK optimization

2014-11-26 Thread ygribov
Formatting. The {} should be indented like static and return 2 columns to the right of that. Right. For base_addr computation, you don't really need g or ptr_checks, do you? So why not move the: auto_vecgimple *ptr_checks = ctx-asan_check_map.get_or_insert (ptr); gimple g =

Re: [PATCH] Enhance ASAN_CHECK optimization

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 11:21:06AM -0700, ygribov wrote: Formatting. The {} should be indented like static and return 2 columns to the right of that. Right. For base_addr computation, you don't really need g or ptr_checks, do you? So why not move the: auto_vecgimple

Re: [patch c++]: Fix PR/53904

2014-11-26 Thread Jason Merrill
OK, thanks. Jason

Re: [PATCH] Enhance ASAN_CHECK optimization

2014-11-26 Thread ygribov
Testing SANITIZE_ADDRESS bit in flag_sanitize_recover doesn't make sense, testing it in flag_sanitize of course does, but for recover you care whether the SANITIZE_{KERNEL,USER}_ADDRESS bit in flag_sanitize_recover is set depending on if SANITIZE_{KERNEL,USER}_ADDRESS is set in

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-26 Thread Uros Bizjak
Hello! I've added avx512f support to __builtin_cpu_supports. I'm not sure about bw+vl, i think for compound values like avx512bd+dq+vl, arch is better. Also for such cases prority is unclear, what should we choose bw+vl or e. g. avx512f+er? I've left MPX bits in cpuid.h, in case we will

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 07:20:04PM +0100, Marek Polacek wrote: On Wed, Nov 26, 2014 at 06:50:29PM +0100, Jakub Jelinek wrote: On Wed, Nov 26, 2014 at 06:39:44PM +0100, Marek Polacek wrote: Both C11 and C++14 standards specify that integral promotions are performed on both operands of a

Re: [PATCH] Enhance ASAN_CHECK optimization

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 11:42:57AM -0700, ygribov wrote: Testing SANITIZE_ADDRESS bit in flag_sanitize_recover doesn't make sense, testing it in flag_sanitize of course does, but for recover you care whether the SANITIZE_{KERNEL,USER}_ADDRESS bit in flag_sanitize_recover is set

[PATCH] Fix find_base_term in 32-bit -fpic code (PR lto/64025, take 2)

2014-11-26 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 09:20:13AM +0100, Jakub Jelinek wrote: Actually, thinking about it more, at least according to commutative_operand_precedence the canonical order is what we used to return (i.e. (something - _G_O_T_) + (symbol_ref) or (something - _G_O_T_) + (const (symbol_ref +-

[PATCH] Fix simd clone vectorization (PR tree-optimization/64024)

2014-11-26 Thread Jakub Jelinek
Hi! As discussed in the PR and on IRC, the problem here is that peeling for alignment can for some linear argument that during vect analysis passed simple_iv no longer pass it during vect transform phase. So, to fix this, this patch remembers the base and step values from simple_iv during vect

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Richard Biener
On November 26, 2014 7:49:55 PM CET, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 26, 2014 at 07:20:04PM +0100, Marek Polacek wrote: On Wed, Nov 26, 2014 at 06:50:29PM +0100, Jakub Jelinek wrote: On Wed, Nov 26, 2014 at 06:39:44PM +0100, Marek Polacek wrote: Both C11 and C++14 standards

[PATCH] Fix expansion with COMPOUND_LITERAL_EXPR (PR middle-end/64067)

2014-11-26 Thread Jakub Jelinek
Hi! The testcase shows that when expanding ARRAY_REF from a const static var with initializer that contains COMPOUND_LITERAL_EXPR, we can try to expand COMPOUND_LITERAL_EXPR even when modifier is not EXPAND_INITIALIZER (it is EXPAND_SUM in that testcase, but could be many others). While

Re: [C++ Patch/RFC] PR 63757

2014-11-26 Thread Paolo Carlini
Hi, On 11/26/2014 05:24 PM, Jason Merrill wrote: On 11/24/2014 01:55 PM, Paolo Carlini wrote: in this rejects-valid, as part of build_user_type_conversion_1, standard_conversion is called by implicit_conversion with a *null* expr, thus the condition in standard_conversion /* [conv.ptr]

Re: [Patch, Fortran] convert almost all {warning,error}_now to common diagnostic

2014-11-26 Thread Tobias Burnus
Hi Manuel, Manuel López-Ibáñez wrote: I think the changes to the common diagnostics part could be as simple as: Good – that's simpler than I had feared. However, I'm less familiar with the Fortran buffering mechanism. I am not sure you find someone who really is. At least I also have

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Jason Merrill
How about converting the rhs to unsigned int if it is already unsigned? Jason

Re: [C++ Patch/RFC] PR 63757

2014-11-26 Thread Jason Merrill
OK. Jason

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 02:25:54PM -0500, Jason Merrill wrote: How about converting the rhs to unsigned int if it is already unsigned? That is fine. I'm just worried about the casts to wider types. So perhaps just promote and cast to int if the promoted type is signed or unsigned if it is

[committed] Make 3 libgomp examples-4 tests cheaper

2014-11-26 Thread Jakub Jelinek
Hi! I've looked at which tests are still too expensive on heavily loaded many thread configurations (where other threads during normal testing run many other tests), and found these: The patch attempts to limit number of target or parallel regions to something smaller than hundreds or thousands.

Re: [Build, Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

2014-11-26 Thread Jeff Law
On 11/26/14 09:27, Tobias Burnus wrote: On Wed, Nov 26, 2014 at 04:55:40PM +0100, Tobias Burnus wrote: This patch adds a configure check for isl_schedule_constraints_compute_schedule, which is new in ISL 0.13 - and uses it for conditional compilation. Repeating the test on a massively

[PATCH] Allow -fsanitize=thread without -pie

2014-11-26 Thread Jakub Jelinek
On Fri, Nov 21, 2014 at 04:20:44PM +0400, Dmitry Vyukov wrote: Yes, I think it's the way to go. I've just committed the following revision to clang that removes -pie when compiling with tsan: http://llvm.org/viewvc/llvm-project?view=revisionrevision=222526 The tests in llvm tree pass with

Re: [PATCH] Allow -fsanitize=thread without -pie

2014-11-26 Thread Dmitry Vyukov
Looks good to me. Thanks! On Wed, Nov 26, 2014 at 10:43 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Nov 21, 2014 at 04:20:44PM +0400, Dmitry Vyukov wrote: Yes, I think it's the way to go. I've just committed the following revision to clang that removes -pie when compiling with tsan:

[PATCH v4] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-26 Thread Chen Gang
The original length 18 is not enough for HOST_WIDE_INT printing, need use 20 instead of. Also need additional bytes for printing related prefix and suffix, and give a related check. It passes testsuite under fedora 20 x86_64-unknown-linux-gnu. 2014-11-27 Chen Gang gang.chen.5...@gmail.com

Re: [PATCH v4] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-26 Thread Joseph Myers
On Thu, 27 Nov 2014, Chen Gang wrote: The original length 18 is not enough for HOST_WIDE_INT printing, need use 20 instead of. Also need additional bytes for printing related prefix and suffix, and give a related check. It passes testsuite under fedora 20 x86_64-unknown-linux-gnu.

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Richard Biener
On November 26, 2014 8:25:54 PM CET, Jason Merrill ja...@redhat.com wrote: How about converting the rhs to unsigned int if it is already unsigned? Does the standard say so? I think not. IMHO it's not the front ends business to do this. And I don't see how it helps either. Richard. Jason

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Richard Biener
On November 26, 2014 8:33:52 PM CET, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 26, 2014 at 02:25:54PM -0500, Jason Merrill wrote: How about converting the rhs to unsigned int if it is already unsigned? That is fine. I'm just worried about the casts to wider types. So perhaps just

RE: [patch, arm] align saved FP regs on stack

2014-11-26 Thread Evandro Menezes
Hi, Sandra. FWIW, I tried this patch on A15 Juno with Coremark and any difference, if any, between specifying this option and not was below 1%. Cheers, -- Evandro Menezes Austin, TX -Original Message- From: gcc-patches-ow...@gcc.gnu.org

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 10:20:39PM +0100, Richard Biener wrote: Well, if you want to aggressively prune unused bits then you could back-propagate the shift count value-range. And note that all the frontend shorten-optimizations should move to the middle-end. That said, instead of

Re: Merging configure bits with Binutils

2014-11-26 Thread Jan-Benedict Glaw
On Mon, 2014-11-24 12:43:40 -0700, Jeff Law l...@redhat.com wrote: [Merging top-level configury files from Binutils] It's pretty isolated stuff (in terms of what clauses are being changed in the configure bits), so I'm not too worried about breaking anything. We can reach out to Joel to ensure

[PATCH 2/4] Merge ./config/ChangeLog with missing entries from Binutils

2014-11-26 Thread Jan-Benedict Glaw
2014-11-26 Jan-Benedict Glaw jbg...@lug-owl.de * config/ChangeLog: Merge entries from Binutils --- config/ChangeLog | 15 +++ 1 file changed, 15 insertions(+) diff --git a/config/ChangeLog b/config/ChangeLog index ab3a773..2cbc885 100644 --- a/config/ChangeLog +++

  1   2   >