RE: [PATCH] [MIPS] Fix wrong instruction in the delay slot

Robert Suchanek > IMO, the fix is to recognize the empty basic block that has a code_label > followed by a barrier (ignoring notes and debug_insns), forbid going > beyond the barrier if the empty block is found in > skip_consecutive_labels () and

Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

On 2 September 2015 at 13:09, Jan Hubicka wrote: > It kind of sucks that one needs to mind this flag each time one creates edge, > but setting the value in create_edge is not quite correct as that one does not > have any information on where the call appears and if the exception

Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

On Mon, Sep 7, 2015 at 9:35 AM, Charles Baylis wrote: > On 2 September 2015 at 13:09, Jan Hubicka wrote: >> It kind of sucks that one needs to mind this flag each time one creates edge, >> but setting the value in create_edge is not quite correct as

Re: [PATCH][ARM][3/3] Expand mod by power of 2

On 24/07/15 11:55, Kyrill Tkachov wrote: > > commit d562629e36ba013b8f77956a74139330d191bc30 > Author: Kyrylo Tkachov > Date: Fri Jul 17 16:30:01 2015 +0100 > > [ARM][3/3] Expand mod by power of 2 > > diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c >

Re: [Patch, libstdc++] Add specific error message into exceptions

On 28/08/15 20:44 -0700, Tim Shen wrote: On Fri, Aug 28, 2015 at 11:23 AM, Tim Shen wrote: So is it good to have an owned raw pointer stored in runtime_error, pointing to a heap allocated char chunk, which will be deallocated in regex_error's dtor? I just put a string

Re: debug mode symbols cleanup

On 05/09/15 22:53 +0200, François Dumont wrote: I remember Paolo saying once that we were not guarantiing any abi compatibility for debug mode. I haven't found any section for unversioned symbols in gnu.ver so I simply uncomment the global export. There is no section, because all exported

Re: [PATCH][wwwdocs][AArch64] Add entry for target attributes and pragmas

Hi Gerald, On 07/09/15 12:31, Gerald Pfeifer wrote: On Wed, 2 Sep 2015, Kyrill Tkachov wrote: My thinking was that when we introduce some new command-line option we list it here and give a short description of it (new -mcpu values, for example). However, here we introduce about 10 new target

[PATCH] 2015-09-03 Benedikt Huber <benedikt.hu...@theobroma-systems.com> Philipp Tomsich <philipp.toms...@theobroma-systems.com>

* config/aarch64/aarch64-builtins.c: Builtins for rsqrt and rsqrtf. * config/aarch64/aarch64-opts.h: -mrecip has a default value depending on the core. * config/aarch64/aarch64-protos.h: Declare. * config/aarch64/aarch64-simd.md: Matching expressions

[PATCH v5][aarch64] Implemented reciprocal square root (rsqrt) estimation in -ffast-math

This fifth revision of the patch: * Moves a function declaration to a header. * Adds comments to functions. Ok for check in. Benedikt Huber (1): 2015-09-03 Benedikt Huber Philipp Tomsich

Re: [Patch, libstdc++] Add specific error message into exceptions

On 28/08/15 11:23 -0700, Tim Shen wrote: On Fri, Aug 28, 2015 at 8:59 AM, Jonathan Wakely wrote: There seems to be no need to construct a std::string here, just pass a const char* (see below). To be honest, I wasn't considering performance for a bit, since exceptions are

Re: [0/7] Type promotion pass and elimination of zext/sext

On 07/09/15 20:46, Wilco Dijkstra wrote: >> Kugan wrote: >> 2. vector-compare-1.c from c-c++-common/torture fails to assemble with >> -O3 -g Error: unaligned opcodes detected in executable segment. It works >> fine if I remove the -g. I am looking into it and needs to be fixed as well. > > This

Re: [patch] Rename shadowed variable in libstdc++ test.

On 07/09/15 12:33 +0100, Jonathan Wakely wrote: Thanks to Sebastian for pointing this out. Tested powerpc64le-linux, committed to trunk. With the patch this time ... commit 407976d0a374c2b291f4b75957936885f6314ae8 Author: Jonathan Wakely Date: Mon Sep 7 12:20:02 2015

Re: [wwwdocs] Re: C++ Concepts available in trunk?

On 7 September 2015 at 11:51, Gerald Pfeifer wrote: > Jonathan, > > On Thu, 13 Aug 2015, Jonathan Wakely wrote: >> Thanks, I've committed the attached change to the wwwdocs repo. > > looking at this I noticed a reference to "Subversion", when in > general we have tried to minimize references to

[patch] Rename shadowed variable in libstdc++ test.

Thanks to Sebastian for pointing this out. Tested powerpc64le-linux, committed to trunk.

Re: [gomp4.1] Various accelerator updates from OpenMP 4.1

On Fri, Sep 04, 2015 at 09:07:02PM +0300, Ilya Verbin wrote: > It seems that there is a bug some here: > > Here is the reproducer: > > #pragma omp declare target > int a[1]; > #pragma omp end declare target > > void foo () > { > #pragma omp target map(to: a[0:1]) > a; > } > > >

Re: [PATCH, PR 57195] Allow mode iterators inside angle brackets

Michael Collison writes: > This patch allow mode iterators inside angle brackets in machine > description files. I discovered the issue when attempting to use > iterators on match_operand's as follows: > > match_operand: 0 "s_register_operand" "=w") > > The function

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-02 15:35 GMT+03:00 Richard Biener : > > DECL_FIELD_BIT_OFFSET should be never NULL. Whoever created that > FIELD_DECL created an invalid one. > > Richard. > layout_class_type doesn't place fields with no type and thus we have nothing for DECL_FIELD_BIT_OFFSET.

Re: Openacc launch API

On 08/25/15 09:29, Nathan Sidwell wrote: Jakub, This patch changes the launch API for openacc parallels. The current scheme passes the launch dimensions as 3 separate parameters to the GOACC_parallel function. This is problematic for a couple of reasons: 1) these must be validated in the

RE: [0/7] Type promotion pass and elimination of zext/sext

> pins...@gmail.com wrote: > > On Sep 7, 2015, at 7:22 PM, Kugan wrote: > > > > > > > > On 07/09/15 20:46, Wilco Dijkstra wrote: > >>> Kugan wrote: > >>> 2. vector-compare-1.c from c-c++-common/torture fails to assemble with > >>> -O3 -g Error: unaligned opcodes

RE: [0/7] Type promotion pass and elimination of zext/sext

> Kugan wrote: > 2. vector-compare-1.c from c-c++-common/torture fails to assemble with > -O3 -g Error: unaligned opcodes detected in executable segment. It works > fine if I remove the -g. I am looking into it and needs to be fixed as well. This is a known assembler bug I found a while back,

Re: [PATCH] Fix PR64078

On Sun, Sep 06, 2015 at 07:21:13PM +0200, Bernd Edlinger wrote: > Hi, > > we observed sporadic failures of the following two test cases (see PR64078): > c-c++-common/ubsan/object-size-9.c and c-c++-common/ubsan/object-size-10.c > > For object-size-9.c this happens in a reproducible way when

Re: [patch] libstdc++/65704 portable timed_mutex and recursive_timed_mutex

One more patch for timed mutexes, to enable two more tests on darwin that are supported by the new implementations. Tested powerpc64le-linux, committed to trunk. commit 917a1e218c46a1bfcd9b2368a9e0f51c13f6a387 Author: Jonathan Wakely Date: Mon Sep 7 11:34:59 2015 +0100

Re: [wwwdocs] Re: C++ Concepts available in trunk?

Jonathan, On Thu, 13 Aug 2015, Jonathan Wakely wrote: > Thanks, I've committed the attached change to the wwwdocs repo. looking at this I noticed a reference to "Subversion", when in general we have tried to minimize references to specific version control systems. And I noticed we can be a

Re: [PATCH][wwwdocs][AArch64] Add entry for target attributes and pragmas

On Wed, 2 Sep 2015, Kyrill Tkachov wrote: > My thinking was that when we introduce some new command-line option we > list it here and give a short description of it (new -mcpu values, for > example). However, here we introduce about 10 new target attributes and > pragmas and listing them all

Re: [0/7] Type promotion pass and elimination of zext/sext

> On Sep 7, 2015, at 7:22 PM, Kugan wrote: > > > > On 07/09/15 20:46, Wilco Dijkstra wrote: >>> Kugan wrote: >>> 2. vector-compare-1.c from c-c++-common/torture fails to assemble with >>> -O3 -g Error: unaligned opcodes detected in executable segment. It

Re: [PATCH 2/5] completely_scalarize arrays as well as records.

In-Reply-To: <55e0697d.2010...@arm.com> On 28/08/15 16:08, Alan Lawrence wrote: > Alan Lawrence wrote: >> >> Right. I think VLA's are the problem with pr64312.C also. I'm testing a fix >> (that declares arrays with any of these properties as unscalarizable). > ... > In the meantime I've reverted

Re: [patch] Avoid #ifdef _GLIBCXX_DEBUG in regex_compiler.h

We could go further and remove the ABI difference in regex_compiler when using _GLIBCXX_DEBUG, as in the attached patch. The trick is that for the char specialization we have padding bytes between _M_is_non_matching (a bool) and _M_cache (a std::bitset), so we can reuse one of those padding

[PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

Hi, This is mostly Roland's patch with one extra case added by me plus I moved the new header to include/ as suggested in c#7 of the PR since there are other users for it in the compiler. == On Darwin platforms, when referenced from the main executable, it's permitted to access *_environ

[PATCH] PR target/67480: AVX512 bitwise logic insns pattern is incorrect

This patch adresses PR target/67480. As there are no bitwise logic instructions for BYTE/WORD in AVX512, we should split corresponding pattern into two different patterns, namely: (a) any bitwise logic, for SI/DI modes, masking is supported; (b) any bitwise logic, for QI/HI modes,

Re: [patch] Avoid #ifdef _GLIBCXX_DEBUG in regex_compiler.h

On 07/09/15 15:54 +0100, Jonathan Wakely wrote: @@ -457,10 +457,24 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION return 1ul << (sizeof(_CharT) * __CHAR_BIT__ * int(_UseCache::value)); } - struct _Dummy { }; - typedef typename std::conditional<_UseCache::value, -

[PATCH][RTL-ifcvt] PR rtl-optimization/67465: Do not ifcvt complex blocks if the else block is empty

Hi all, This patch fixes the PRs in the ChangeLog that have been reported against my if-conversion patch. The problem occurs when the 'then' block is complex but the else block is empty. In this case the calling code in noce_process_if_block takes the 'else' move (x := b) from the test block.

Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

On Sep 7, 2015, at 8:23 AM, Iain Sandoe wrote: > On Darwin platforms, when referenced from the main executable, it's permitted > to access *_environ directly. > OK for trunk and active branches? Darwin bits Ok.

Re: [5/7] Allow gimple debug stmt in widen mode

Hi, On Mon, 7 Sep 2015, Kugan wrote: > Allow GIMPLE_DEBUG with values in promoted register. Patch does much more. > gcc/ChangeLog: > > 2015-09-07 Kugan Vivekanandarajah > > * expr.c (expand_expr_real_1): Set proper SUNREG_PROMOTED_MODE for > SSA_NAME that

Re: [PATCH] [graphite] Remove limit_scops

On 09/05/2015 12:57 AM, Aditya Kumar wrote: This patch removes graphite-scop-detection.c:limit_scops function and fix related issues arising because of that. The functionality limit_scop was added as an intermediate step to discard the loops which graphite could not handle. Removing limit_scop

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

On Mon, Sep 07, 2015 at 05:46:12PM +0300, Ilya Verbin wrote: > On Sat, Sep 05, 2015 at 00:45:36 +0300, Ilya Verbin wrote: > > 2015-09-04 22:27 GMT+03:00 Mike Stump : > > > On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas > > > wrote: > > >*

Re: [4/7] Use correct promoted mode sign for result of GIMPLE_CALL

Hi, On Mon, 7 Sep 2015, Kugan wrote: > For the following testcase (compiling with -O1; -O2 works fine), we have > a stmt with stm_code SSA_NAME (_7 = _ 6) and for which _6 is defined by > a GIMPLE_CALL. In this case, we are using wrong SUNREG promoted mode > resulting in wrong code. And why is

RE: [PATCH] Fix PR64078

Hi, On Mon, 7 Sep 2015 12:07:00, Marek Polacek wrote: > > On Sun, Sep 06, 2015 at 07:21:13PM +0200, Bernd Edlinger wrote: >> Hi, >> >> we observed sporadic failures of the following two test cases (see PR64078): >> c-c++-common/ubsan/object-size-9.c and c-c++-common/ubsan/object-size-10.c >> >>

Re: [gomp4] expunge shared_size from launch API

On 31/08/15 19:39, Nathan Sidwell wrote: Index: gcc/omp-builtins.def === --- gcc/omp-builtins.def(revision 227269) +++ gcc/omp-builtins.def(working copy) @@ -45,11 +45,11 @@ DEF_GOACC_BUILTIN_FNSPEC (BUILT_IN_GOACC

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

On Sat, Sep 05, 2015 at 00:45:36 +0300, Ilya Verbin wrote: > 2015-09-04 22:27 GMT+03:00 Mike Stump : > > On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas > > wrote: > >* intelmic-mkoffload.c (prepare_target_image): Fix if the temp path >

[PATCH][AArch64] Improve code generation for float16 vector code

On 04/09/15 13:32, James Greenhalgh wrote: > In that case, these should be implemented as inline assembly blocks. As it > stands, the code generation for these intrinsics will be very poor with this > patch applied. > > I'm going to hold off OKing this until I see a follow-up to fix the code >

Re: [gomp4] expunge shared_size from launch API

On 09/07/15 09:46, Tom de Vries wrote: On 31/08/15 19:39, Nathan Sidwell wrote: Index: gcc/omp-builtins.def === --- gcc/omp-builtins.def(revision 227269) +++ gcc/omp-builtins.def(working copy) @@ -45,11 +45,11 @@

[patch] Avoid #ifdef _GLIBCXX_DEBUG in regex_compiler.h

This uses an NSDMI and the _GLIBCXX_DEBUG_ONLY macro to remove several ugly #ifdef _GLIBCXX_DEBUG conditionals in Tested powerpc64le-linux, committed to trunk. commit e53218fa5a7eedf76f409ab41f2e24776bb5195e Author: Jonathan Wakely Date: Mon Sep 7 15:12:03 2015 +0100

[patch] Relax Debug Mode assertions on operator-> for smart pointers.

The standard says that unique_ptr::operator->() and shared_ptr::operator->() have preconditions that the pointer is not null, but that's not strictly necessary and prevents using that function to get a raw pointer from a smart pointer in generic code. This changes the _GLIBCXX_DEBUG_ASSERT to

Re: [PATCH g++ driver] Push -static-libstdc++ back onto the command line to allow spec substitutions to use it.

On 14 Jul 2015, at 18:45, Iain Sandoe wrote: > > On 14 Jul 2015, at 18:24, Jason Merrill wrote: > >> On 06/18/2015 04:12 AM, Iain Sandoe wrote: >>> The patch below pushes -static-libstdc++ onto the output command line (for >>> targets without -Bstatic/dynamic) so that such specs have an

Re: [5/7] Allow gimple debug stmt in widen mode

Thanks for the review. On 07/09/15 23:20, Michael Matz wrote: > Hi, > > On Mon, 7 Sep 2015, Kugan wrote: > >> Allow GIMPLE_DEBUG with values in promoted register. > > Patch does much more. > Oops sorry. Copy and paste mistake. gcc/ChangeLog: 2015-09-07 Kugan Vivekanandarajah

Re: Remove redundant test for global_regs

- Original Message - From: "Jeff Law" Sent: Friday, September 04, 2015 11:22 PM Hello. Index: gcc/cse.c === --- gcc/cse.c (revision 226953) +++ gcc/cse.c (working copy) @@ -463,7 +463,7 @@ A reg

[Patch, fortran] PR66681 - Wrong result in assigning this_image() to a complex coarray

Dear All, This is something of a corner case, where gfc_conv_expr comes back with a SAVE_EXPR, in the case of complex, scalar, coarray lvalues. The first field of the SAVE_EXPR is a perfectly viable expression to assign to, so I have taken that. If anybody out there has a better solution, please

[RS6000] Fix PowerPC ICE due to secondary_reload ignoring reload replacements

In https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67378 analysis I show the reason for this PR is that insns emitted by secondary reload patterns are being generated without taking into account other reloads that may have occurred. We run into this problem when an insn has a pseudo that doesn't get

Re: [4/7] Use correct promoted mode sign for result of GIMPLE_CALL

On 07/09/15 23:10, Michael Matz wrote: > Hi, > > On Mon, 7 Sep 2015, Kugan wrote: > >> For the following testcase (compiling with -O1; -O2 works fine), we have >> a stmt with stm_code SSA_NAME (_7 = _ 6) and for which _6 is defined by >> a GIMPLE_CALL. In this case, we are using wrong SUNREG

Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.

On 07/09/15 21:31 +0200, Florian Weimer wrote: * Jonathan Wakely: This patch adds the "debug mode lite" we've been talking about, by changing __glibcxx_assert to be activated by _GLIBCXX_ASSERTIONS instead of _GLIBCXX_DEBUG (and making the latter imply the former). Interesting. Is this mode

Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.

On 07/09/15 20:53 +0100, Jonathan Wakely wrote: On 07/09/15 21:04 +0200, Daniel Krügler wrote: 2015-09-07 20:27 GMT+02:00 Jonathan Wakely : This patch adds the "debug mode lite" we've been talking about, by changing __glibcxx_assert to be activated by _GLIBCXX_ASSERTIONS

Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.

2015-09-07 22:10 GMT+02:00 Jonathan Wakely : > On 07/09/15 20:53 +0100, Jonathan Wakely wrote: >> On 07/09/15 21:04 +0200, Daniel Krügler wrote: >>> In the suggested doc changes: >>> >>> +When defined, _GLIBCXX_ASSERTIONS is defined >>> +automatically, so all

Re: [wwwdocs] Re: C++ Concepts available in trunk?

On Mon, 7 Sep 2015, Jonathan Wakely wrote: > Nice, I think they are good improvements. Cool. I committed this, only to notice another change. GCC stands for GNU Compiler Collection, to GCC compiler would expand to GNU Compiler Collection compiler, which feels a bit redundant. ;-) I'll wait a

[patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.

This patch adds the "debug mode lite" we've been talking about, by changing __glibcxx_assert to be activated by _GLIBCXX_ASSERTIONS instead of _GLIBCXX_DEBUG (and making the latter imply the former). _GLIBCXX_ASSERTIONS is already used in Parallel Mode for enabling optional assertions (although

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67465: Do not ifcvt complex blocks if the else block is empty

On Mon, Sep 7, 2015 at 9:29 AM, Kyrill Tkachov wrote: > Hi all, > > This patch fixes the PRs in the ChangeLog that have been reported against my > if-conversion patch. > The problem occurs when the 'then' block is complex but the else block is > empty. > In this case the

Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.

* Jonathan Wakely: > This patch adds the "debug mode lite" we've been talking about, by > changing __glibcxx_assert to be activated by _GLIBCXX_ASSERTIONS > instead of _GLIBCXX_DEBUG (and making the latter imply the former). Interesting. Is this mode ABI-compatible with the default mode? Should

[PATCH, Darwin] Some driver TLC (improve support for the '-arch' flag).

Hi, For some Darwin compilers, "-arch " can be used (a) in place of, but to indicate the same as, a multilib flag like "-m32" and (b) multiple times to indicate that the User wants a FAT object with multiple arch slices. It's helpful to support this, as far as possible, to minimise build

Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.

2015-09-07 20:27 GMT+02:00 Jonathan Wakely : > This patch adds the "debug mode lite" we've been talking about, by > changing __glibcxx_assert to be activated by _GLIBCXX_ASSERTIONS > instead of _GLIBCXX_DEBUG (and making the latter imply the former). > > _GLIBCXX_ASSERTIONS is

Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.

On 07/09/15 21:04 +0200, Daniel Krügler wrote: 2015-09-07 20:27 GMT+02:00 Jonathan Wakely : This patch adds the "debug mode lite" we've been talking about, by changing __glibcxx_assert to be activated by _GLIBCXX_ASSERTIONS instead of _GLIBCXX_DEBUG (and making the latter