Re: [PATCH] Fix PR68067

On 11/06/2015 05:26 AM, Richard Biener wrote: On Fri, 6 Nov 2015, Alan Lawrence wrote: On 06/11/15 10:39, Richard Biener wrote: ../spec2000/benchspec/CINT2000/254.gap/src/polynom.c:358:11: error: location references block not in block tree l1_279 = PHI <1(28), l1_299(33)> ^^^ this is the

Re: [PATCH] Make BB vectorizer work on sub-BBs

On 11/06/2015 04:09 AM, Richard Biener wrote: On Fri, 6 Nov 2015, Richard Biener wrote: The following patch makes the BB vectorizer not only handle BB heads (until the first stmt with a data reference it cannot handle) but arbitrary regions in a BB separated by such stmts. This improves the

Re: [vec-cmp, patch 1/6] Add optabs for vector comparison

On 11/05/2015 09:01 AM, Ilya Enkovich wrote: 2015-10-27 23:52 GMT+03:00 Jeff Law : Sigh. I searched for the enum type, not for CODE_FOR_nothing ;( My bad. If it's easy to get rid of, yes. I believe we've got 3 uses of CODE_FOR_nothing. AFAICT in none of those cases do we

Re: [OpenACC] declare directive

On 11/06/2015 10:08 AM, James Norris wrote: Thomas, I've added the issues that you pointed out. Attached is the updated patch and ChangeLog. Thanks for taking the time for your review! Errr, make that 'addressed the issues that you pointed out." Opps, Jim

Re: Move #undef DEF_BUILTIN* to builtins.def

On 11/06/2015 08:35 AM, Richard Sandiford wrote: I was confused at first why tree-core.h was undefining DEF_BUILTIN_CHKP before defining it, then undefining it again after including builtins.def. This is because builtins.def provides a default definition of DEF_BUILTIN_CHKP, but leaves it up to

Re: Move #undef DEF_INTERNAL_FN to internal-fn.def

On 11/06/2015 08:30 AM, Richard Sandiford wrote: In practice the definition of DEF_INTERNAL_FN is never reused after including internal-fn.def, so we might as well #undef it there. This becomes more obvious with a later patch that adds other DEF_INTERNAL_* directives, such as

Re: improved RTL-level if conversion using scratchpads [half-hammock edition]

On 11/06/2015 04:52 PM, Sebastian Pop wrote: opinion). If you want a half-finished redzone allocator, I can send you a patch. Yes please. Let's get it work. Here you go. This is incomplete and does not compile, but it shows the direction I have in mind and isn't too far off. I had a

Re: [PATCH 6/6] Make SRA replace constant-pool loads

On November 5, 2015 7:55:12 PM GMT+01:00, Alan Lawrence wrote: >On 3 November 2015 at 14:01, Richard Biener > wrote: >> >> Hum. I still wonder why we need all this complication ... > >Well, certainly I'd love to make it simpler, and if the

Re: Add -fno-math-errno to gcc.dg/lto/20110201-1_0.c

On November 6, 2015 3:34:22 PM GMT+01:00, Richard Sandiford wrote: >At the moment the ECF_* flags for a gimple call to a built-in >function are derived from the function decl, which in turn is >derived from the global command-line options. So if the compiler >is run

Re: Move constant bitop and bswap folds to fold-const-call.c

On November 6, 2015 4:12:56 PM GMT+01:00, Richard Sandiford wrote: >The only folds left in builtins.c were for constants, so we can remove >the builtins.c handling entirely. > >Tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-linux-gnueabi. >OK to install? OK.

[RFA] Do not use libiberty's getpagesize on Android

Hello, Building libiberty on Android currently fails with the error message shown below. This was discovered by trying to build GDBserver for Android, which stopped building after libiberty became a GDBserver dependency. Here is the error message: [...]/getpagesize.c:64:1: error: redefinition

Re: [PATCH] Fix PR ipa/68035

> Hello. > > Following patch triggers hash calculation of items (functions and variables) > in situations where LTO mode is not utilized. > > Patch survives regression tests and bootstraps on x86_64-linux-pc. > > Ready for trunk? > Thanks, > Martin > >From

Re: [PATCH] Merge from gomp-4_5-branch to trunk

Hi! On Fri, 6 Nov 2015 12:15:01 +0100, I wrote: > On Thu, 5 Nov 2015 10:41:41 -0500, Nathan Sidwell wrote: > > On 11/05/15 10:29, Jakub Jelinek wrote: > > > I've merged the current state of gomp-4_5-branch into trunk, after > > > bootstrapping/regtesting it on x86_64-linux and

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

On 04/11/15 13:13, Jakub Jelinek wrote: On Mon, Jul 06, 2015 at 05:38:35PM +0100, Alan Lawrence wrote: Trying to push these now (svn!), patch 2 is going first. I realize my second iteration of patch 1/2, dropped the testcases from the first version. Okay to include those as per

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

On Fri, Nov 06, 2015 at 04:48:02PM +, Alan Lawrence wrote: > Sorry Jakub, can you clarify please, how to reproduce this failure? I've > just bootstrapped gcc-5-branch with ada and run the Ada testsuite, which has > build me gcc/ada/rts/libgnat{.a,.so,-5.so}, and I see all tests passing. >

Re: [PATCH] Merge from gomp-4_5-branch to trunk

On 11/05/2015 09:08 PM, David Edelsohn wrote: Sorry for the incorrect blame. I thought the failure was due to GOMP changes, but it appears to be due to the placement new size changes. I am re-testing after Martin's fix. By the way, Martin, the ChangeLog entry is wrong I've fixed the

Re: [AArch64] Fix vqtb[lx][234] on big-endian

On Fri, Nov 06, 2015 at 02:49:38PM +0100, Christophe Lyon wrote: > Hi, > > As mentioned by James a few weeks ago, the vqtbl[lx][234] intrinsics > are failing on aarch64_be. > > The attached patch fixes them, and rewrites them using new builtins > instead of inline assembly. > > I wondered about

[PATCH][ARM] PR 49526: Add support for smmul,smmla,smmls instructions

Hi all, This patch introduces support for the smmul, smmla and smmls instructions that appear in armv6 architecture levels and higher. To quote the SMMUL description from the ARMARM: "Signed Most Significant Word Multiply multiplies two signed 32-bit values, extracts the most significant 32

Re: Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL for the consumer: (insn 20 15 21 2 (set (reg/i:SI 0 r0) (minus:SI (subreg:SI (reg:DI 117) 4) (mult:SI (reg:SI 123) (reg:SI

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

On 06/11/15 17:07, Nikolai Bozhenov wrote: On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL for the consumer: (insn 20 15 21 2 (set (reg/i:SI 0 r0) (minus:SI (subreg:SI (reg:DI 117) 4) (mult:SI

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

On Fri, 6 Nov 2015, Bernd Schmidt wrote: > On 10/30/2015 05:44 PM, Alexander Monakov wrote: > > + /* Ignore "omp target entrypoint" here: OpenMP target region functions > > are > > + called from gomp_nvptx_main. The corresponding kernel entry is > > emitted > > + from write_omp_entry.

Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost

On 06/11/15 11:37, Kyrill Tkachov wrote: Ping. https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03170.html My apologies, I meant to ping another patch. Please disregard that. Kyrill Thanks, Kyrill On 30/10/15 15:47, Kyrill Tkachov wrote: On 30/10/15 14:37, Ramana Radhakrishnan wrote: On

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

On 29/10/15 14:14, Kyrill Tkachov wrote: > > On 29/10/15 14:00, Marcus Shawcroft wrote: >> On 29 October 2015 at 13:50, Kyrill Tkachov wrote: >> > Ok for trunk? rtl.h exposes reg_or_subregno() already doesn't that do what we need here? >>> >>> reg_or_subregno

Re: Fix 61441

On Fri, 6 Nov 2015, Sujoy Saraswati wrote: > > Shouldn't real_convert do this rather than the caller needing to do it? > > Yes, it should be. I had started by doing this within real_convert but > then saw that there are quite a few callers where I should add the > check for flag_signaling_nans.

Unreviewed patch

The following patch has remained unrevied for a month: [build] Support init priority on Solaris https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00716.html It needs build and ia64 maintainers and someone familiar with the init priority support to review. Thanks. Rainer --

Re: [gomp4 06/14] omp-low: copy omp_data_o to shared memory on NVPTX

Sanity-checked by running the libgomp testsuite. I realize the #ifdef in internal-fn.c is not appropriate: it's there to make the patch smaller, I'll replace it with a target hook if otherwise this approach is ok. FWIW, no objections from me regarding the approach. Bernd

Re: [PATCH] x86 interrupt attribute

Hi, I updated and reposted the patch. Regtested/bootstraped on x86_64/Linux and i686/Linux. Ok for trunk? Implement x86 interrupt attribute The interrupt and exception handlers are called by x86 processors. X86 hardware pushes information onto stack and calls the handler. The requirements are

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

On Fri, Nov 06, 2015 at 03:05:05PM +0100, Bernd Schmidt wrote: > This patch creates a new "omp target entrypoint" annotation that appears not > to be used - it would be better to just not annotate a function if it's not > going to need entrypoint treatment. IMO a single type of attribute should be

Re: [PATCH] Make BB vectorizer work on sub-BBs

Hi Richard, On 06/11/15 11:09, Richard Biener wrote: On Fri, 6 Nov 2015, Richard Biener wrote: The following patch makes the BB vectorizer not only handle BB heads (until the first stmt with a data reference it cannot handle) but arbitrary regions in a BB separated by such stmts. This

Re: [PATCH] Make BB vectorizer work on sub-BBs

On Fri, 6 Nov 2015, Kyrill Tkachov wrote: > Hi Richard, > > On 06/11/15 11:09, Richard Biener wrote: > > On Fri, 6 Nov 2015, Richard Biener wrote: > > > > > The following patch makes the BB vectorizer not only handle BB heads > > > (until the first stmt with a data reference it cannot handle)

[PATCH] Fix object init in alloc-pool.h

The previous allocator never initialized objects thus switch to default initialization. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. Index: gcc/alloc-pool.h === --- gcc/alloc-pool.h(revision 229804)

Re: [PATCH 5/6]tree-sra.c: Fix completely_scalarize for negative array indices

On Thu, Nov 5, 2015 at 2:22 PM, Alan Lawrence wrote: > On 30/10/15 10:54, Eric Botcazou wrote: >> On 30/10/15 10:44, Richard Biener wrote: >>> >>> I think you want to use wide-ints here and >>> >>> wide_int idx = wi::from (minidx, TYPE_PRECISION (TYPE_DOMAIN >>> (...)),

Re: [PATCH] Fix transform_to_exit_first_loop_alt with -g

On Fri, 6 Nov 2015, Tom de Vries wrote: > Hi, > > This patch fixes a problem with -g compilation in > transform_to_exit_first_loop_alt. > > Consider test-case test.c: > ... > void > f (int *a, int n) > { > int i; > for (i = 0; i < n; ++i) > a[i] = 1; > } > ... > > If we add a

[PATCH, ARM, v2] PR target/68059 libgcc should not use __write for printing fatal error

libgcc/config/arm/linux-atomic-64bit.c uses __write to print an error message if the 64bit cmpxchg method is not available in the kernel. __write is not part of the public libc abi, so use write instead. (user code may define write in iso c conforming mode and then the error message may not be

Re: [PATCH] Fix memory leaks

On Fri, 6 Nov 2015, Richard Biener wrote: > > A few, spotted with valgrind. One is even mine ;) > > Bootstrap and regtest running on x86_64-unknown-linux-gnu. And this is what I committed (one extra leak in postreload-gcse). Richard. 2015-11-06 Richard Biener

Re: [openacc] tile, independent, default, private and firstprivate support in c/++

On 11/05/15 21:10, Cesar Philippidis wrote: I've applied this patch to trunk. It also includes the fortran and template changes. Note that there is a new regression in gfortran.dg/goacc/combined_loop.f90. Basically, the gimplifier is complaining about reduction variables appearing in multiple

[PATCH] gcc/config.gcc: fix typo for powerpc e6500 cpu_is_64bit

Otherwise, it will not be treated as a 64-bit CPU even if the target tuple specifies powerpc64. --- This is a trivial fix so I hope no copyright assignment is required. I submit this change in the public domain. This is my first time submitting anything to gcc, so if I should do someting

Patch for PR68106 was backported to gcc-5 branch

The following patch has been committed to gcc 5 branch as rev. 229868. The patch was bootstrapped and tested on x86/x86-64. Index: ChangeLog === --- ChangeLog (revision 229866) +++ ChangeLog (working copy) @@ -1,3 +1,12 @@

Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost

Ping. https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03170.html Thanks, Kyrill On 30/10/15 15:47, Kyrill Tkachov wrote: On 30/10/15 14:37, Ramana Radhakrishnan wrote: On 29/10/15 16:02, Kyrill Tkachov wrote: Hi all, An arm-none-eabi build with RTL checking and --with-cpu=cortex-a9 fails

[PATCH] Fix memory leaks

A few, spotted with valgrind. One is even mine ;) Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2015-11-06 Richard Biener * tree-ssa-sccvn.c (class sccvn_dom_walker): Add destructor. * lra.c (init_reg_info): Truncate copy_vec

Re: [PATCH, PR tree-optimization/68145] Fix vectype computation in vectorizable_operation

On Thu, Nov 5, 2015 at 5:16 PM, Ilya Enkovich wrote: > Hi, > > This patch fixes a way vectype is computed in vectorizable_operation. > Currently op0 is always used to compute vectype. If it is a loop invariant > then its type is used to get vectype which is impossible

Re: [ping] Fix PR debug/66728

On Fri, Nov 6, 2015 at 2:34 AM, Mike Stump wrote: > On Nov 5, 2015, at 4:32 AM, Richard Biener wrote: >> No idea on location lists but maybe this means we should just use the >> maximum supported integer mode for CONST_WIDE_INTs? > > Ah, yeah,

[gomp4, committed] Remove DEF_GOACC_BUILTIN_FNSPEC

[ was: Re: [gomp4, committed] Revert "Add IFN_GOACC_DATA_END_WITH_ARG" ] On 06/11/15 13:03, Tom de Vries wrote: Now that we've got -foffload-alias, we're no longer concerned about GOACC builtins being alias analysis optimization barriers, so the IFN_GOACC_DATA_END_WITH_ARG patch has become

Re: [PATCH] Simple optimization for MASK_STORE.

Richard, I tried it but 256-bit precision integer type is not yet supported. Yuri. 2015-11-06 15:56 GMT+03:00 Richard Biener : > On Mon, Nov 2, 2015 at 4:24 PM, Yuri Rumyantsev wrote: >> Hi Richard, >> >> I've come back to this optimization and

[AArch64] Fix vqtb[lx][234] on big-endian

Hi, As mentioned by James a few weeks ago, the vqtbl[lx][234] intrinsics are failing on aarch64_be. The attached patch fixes them, and rewrites them using new builtins instead of inline assembly. I wondered about the names of the new builtins, I hope I got them right: qtbl3, qtbl4, qtbx3, qtbx4

Re: [PATCH] Do not allow irreducible loops/regions in a scop

On Thu, Nov 5, 2015 at 10:12 PM, Aditya Kumar wrote: > Irreducible regions are not going to be optimized by ISL > so discard them early. > > gcc/ChangeLog: > > 2015-11-06 Aditya Kumar > > * graphite-scop-detection.c

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

Ping. https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03170.html Thanks, Kyrill On 29/10/15 14:14, Kyrill Tkachov wrote: On 29/10/15 14:00, Marcus Shawcroft wrote: On 29 October 2015 at 13:50, Kyrill Tkachov wrote: Ok for trunk? rtl.h exposes reg_or_subregno()

Re: [PING 2] [PATCH] c++/67942 - diagnose placement new buffer overflow

I see this failure on m68k: FAIL: g++.dg/warn/Wplacement-new-size.C -std=gnu++11 (test for excess errors) Excess errors: /daten/aranym/gcc/gcc-20151106/gcc/testsuite/g++.dg/warn/Wplacement-new-size.C:189:19: warning: placement new constructing an object of type 'int' and size '4' in a region

Re: [OpenACC] declare directive

Jakub, Ping. Do you need more information before you can review this patch? Thanks! Jim On 10/27/2015 03:18 PM, James Norris wrote: Hi! This patch adds the processing of OpenACC declare directive in C and C++. (Note: Support in Fortran is already in trunk.) Commentary on the

Re: [PATCH][combine][RFC] Don't transform sign and zero extends inside mults

On 06/11/15 00:56, Segher Boessenkool wrote: On Thu, Nov 05, 2015 at 12:01:26PM +, Kyrill Tkachov wrote: Thanks, that looks less intrusive. I did try it out on arm and aarch64. It does work on the aarch64 testcase. However, there's also a correctness regression, I'll try to explain

Re: [PING][PATCH][4.9]Backport "Fix register corruption bug in ree"

Hi Richard, I am trying to come up with a simple test case, but failed to do so. I have isolated the function where bug is triggered. However, in order to make it a useful test case, the silently corrupted register should be used somewhere, and should affect the correctness of the program. I

[PATCH] Do not allow irreducible loops/regions in a scop

Irreducible regions are not going to be optimized by ISL so discard them early. Passes bootstrap and regtest. gcc/ChangeLog: 2015-11-06 Aditya Kumar * graphite-scop-detection.c (scop_detection::merge_sese): Entry and exit edges should not be a part of

Revert "Add kernels-loop-nest-independent.f95"

Hi, this patch reverts aanother independent clause in oacc kernels region related test-case. Committed to gomp-4_0-branch. Thanks, - Tom Revert "Add kernels-loop-nest-independent.f95" 2015-07-15 Tom de Vries * gfortran.dg/goacc/kernels-loop-nest-independent.f95:

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

On 11/06/2015 10:21 AM, Bernd Schmidt wrote: The ifcvt scratchpad patch had some modifications to the function noce_mem_write_may_trap_or_fault_p in ifcvt, but as far as I can tell, that function itself makes no sense whatsoever. It returns true for MEM_READONLY_P which is sensible, but then it

Re: improved RTL-level if conversion using scratchpads [half-hammock edition]

On 11/06/2015 07:10 AM, Sebastian Pop wrote: On Fri, Nov 6, 2015 at 2:56 AM, Bernd Schmidt wrote: Formatting problem, here and in a few other places. I didn't fully read the patch this time around. I'm probably not reviewing further patches because I don't see this

[gomp4, committed] Revert "Use marked_independent in oacc kernels region"

Hi, this patch reverts the independent clause support in the oacc kernels region. The independent clause support is broken, in a subtle way. We currently set the marked_independent field in struct loop for loops with the independent clause in a kernels region. So that property holds for all

Re: regrename: don't overflow insn_rr_info

On 11/06/2015 04:08 AM, Bernd Schmidt wrote: This one is a fix for something that could currently only affect c6x, but I have code that exposes it on i386. When optionally gathering operand info in regrename, we can overflow the array in certain situations. This can occur when we have a

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

On 11/06/2015 07:39 PM, Jeff Law wrote: Given the name "..may_trap_or_fault_p" ISTM that its mode of operation should be to return true (the safe value) unless we can prove the write will not fault. The more cases we can prove true, the better AFAICT. The PLUS case looks totally wrong. Though

[gomp4, committed] Revert "Add c-c++-common/goacc/kernels-loop-nest-independent.c"

Hi, this patch revert a independent clause in oacc kernels region related test-case. Committed to gomp-4_0-branch. Thanks, - Tom Revert "Add c-c++-common/goacc/kernels-loop-nest-independent.c" 2015-10-2 Tom de Vries Revert: 2015-07-15 Tom de Vries

Re: OpenACC declare directive updates

On Fri, Nov 06, 2015 at 01:45:09PM -0600, James Norris wrote: > Okay, I'll fix this. > > After fixing, OK to commit? > > Thank you for taking the time for the review. Well, isn't this patch really dependent on the other one? Also, wonder about BLOCK stmt in Fortran, that can give you variables

Re: Allow matching of side effects in operand_equal_p

> On Mon, 2 Nov 2015, Jan Hubicka wrote: > > > Hi, > > this patch adds OEP_MATCH_SIDE_EFFECT to tell operand_equal_p that the two > > operands compared are from different code paths and thus they can be matched > > even if they have side effects. > > > > I.e. > > > > volatile int a; > > > >

Re: [patch] fix regrename pass to ensure renamings produce valid insns

On 11/06/2015 03:48 AM, Bernd Schmidt wrote: On 06/17/2015 07:11 PM, Sandra Loosemore wrote: Index: gcc/regrename.c === --- gcc/regrename.c(revision 224532) +++ gcc/regrename.c(working copy) @@ -942,19 +942,22 @@

Re: OpenACC declare directive updates

Jakub, On 11/06/2015 01:49 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 01:45:09PM -0600, James Norris wrote: Okay, I'll fix this. After fixing, OK to commit? Thank you for taking the time for the review. Well, isn't this patch really dependent on the other one? Yes. Should I combine

Re: [OpenACC] declare directive

On Fri, Nov 06, 2015 at 02:18:11PM -0600, James Norris wrote: > On 11/06/2015 01:22 PM, Jakub Jelinek wrote: > >On Fri, Nov 06, 2015 at 08:03:52PM +0100, Jakub Jelinek wrote: > >>What exactly do you want to achieve? Why do you record it > >>in gimplify_omp_ctx, but then only look at it in

Re: [PATCH] PR54224 Warn for unused internal procedures -- update testcase

On 11/05/2015 01:48 AM, Dominique d'Humières wrote: > Is there any objection to commit the following (see comments 21 and 22)? > > Dominique > OK, simple.

Re: OpenACC declare directive updates

Jakub, On 11/06/2015 01:31 PM, Jakub Jelinek wrote: On Wed, Nov 04, 2015 at 06:32:00AM -0600, James Norris wrote: +/* Node in the linked list used for storing !$oacc declare constructs. */ + +typedef struct gfc_oacc_declare +{ + struct gfc_oacc_declare *next; + bool module_var; +

Re: [PATCH 4b] diagnostic-show-locus.c changes: Insertions

On Thu, 2015-10-29 at 22:49 -0600, Jeff Law wrote: > On 10/28/2015 12:09 PM, David Malcolm wrote: > > gcc/ChangeLog: > > * diagnostic-show-locus.c (struct point_state): New struct. > > (class colorizer): New class. > > (class layout_point): New class. > > (class layout_range): New

Re: [OpenACC] declare directive

Jakub, On 11/06/2015 01:03 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 10:08:26AM -0600, James Norris wrote: 2015-10-27 James Norris Joseph Myers gcc/ * c-family/c-pragma.c (oacc_pragmas): Add entry for

Re: [PATCH] [ARM] neon-testgen.ml typo

On 4 November 2015 at 13:16, Ramana Radhakrishnan wrote: > On Fri, Oct 30, 2015 at 2:42 PM, Christophe Lyon > wrote: >> On 30 October 2015 at 15:33, Ramana Radhakrishnan >> wrote: >>> >>> >>> On 29/10/15

Re: [AArch64] Fix vqtb[lx][234] on big-endian

On 6 November 2015 at 18:03, James Greenhalgh wrote: > On Fri, Nov 06, 2015 at 02:49:38PM +0100, Christophe Lyon wrote: >> Hi, >> >> As mentioned by James a few weeks ago, the vqtbl[lx][234] intrinsics >> are failing on aarch64_be. >> >> The attached patch fixes them,

[gomp4, committed] Remove unused DEF_ATTR_FOR_STRING and DEF_ATTR_TREE_LIST

Hi, this patch removes some unused DEF_ATTR_FOR_STRING and DEF_ATTR_TREE_LIST. Committed to gomp-4_0-branch. Thanks, - Tom Remove unused DEF_ATTR_FOR_STRING and DEF_ATTR_TREE_LIST 2015-11-06 Tom de Vries * builtin-attrs.def (DOT_DOT_DOT_r_r_r,

[PATCH][AArch64] Add TARGET_IRA_CHANGE_PSEUDO_ALLOCNO_CLASS

This patch adds support for the TARGET_IRA_CHANGE_PSEUDO_ALLOCNO_CLASS hook. When the cost of GENERAL_REGS and FP_REGS is identical, the register allocator always uses ALL_REGS even when it has a much higher cost. The hook changes the class to either FP_REGS or GENERAL_REGS depending on the mode

Re: [OpenACC] declare directive

Jakub, On 11/06/2015 01:22 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 08:03:52PM +0100, Jakub Jelinek wrote: What exactly do you want to achieve? Why do you record it in gimplify_omp_ctx, but then only look at it in gimplify_body? The way you abuse gimplify_omp_ctx for that is just too

Re: [OpenACC] declare directive

On 11/06/2015 02:28 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 02:18:11PM -0600, James Norris wrote: On 11/06/2015 01:22 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 08:03:52PM +0100, Jakub Jelinek wrote: What exactly do you want to achieve? Why do you record it in

Re: [PATCH] Merge from gomp-4_5-branch to trunk

Hi! On Thu, 5 Nov 2015 10:41:41 -0500, Nathan Sidwell wrote: > On 11/05/15 10:29, Jakub Jelinek wrote: > > I've merged the current state of gomp-4_5-branch into trunk, after > > bootstrapping/regtesting it on x86_64-linux and i686-linux. > > > > There are > > +FAIL:

Re: [hsa 10/12] HSAIL BRIG description header file (hopefully not a licensing issue)

On 11/05/2015 11:05 PM, Martin Jambor wrote: Initially, I have created the file by copying out pieces of PDF documentation but the latest version of the file (describing final HSAIL 1.0) is actually taken from the HSAIL (dis)assembler developed by HSA foundation and released by "University of

[gomp4, committed] Revert "Add IFN_GOACC_DATA_END_WITH_ARG"

Hi, I've reverted the patch that added IFN_GOACC_DATA_END_WITH_ARG ( https://gcc.gnu.org/ml/gcc-patches/2015-05/msg02661.html ). The patch attempted to fix a test failure, while at the same time keeping the GOACC_data_start fnspec attributes to prevent it from becoming an alias analysis

Re: [PING 2] [PATCH] c++/67942 - diagnose placement new buffer overflow

Martin Sebor writes: >> If we use gcc_checking_assert it won't fire in release builds; let's go >> with that. > > Okay. Attached is an updated patch with that change. Unfortunately, this breaks i386-pc-solaris2.10 bootstrap: /vol/gcc/src/hg/trunk/local/gcc/cp/init.c: In

Re: [PATCH] PR/67682, break SLP groups up if only some elements match

On Thu, Nov 5, 2015 at 2:33 PM, Alan Lawrence wrote: > On 03/11/15 13:39, Richard Biener wrote: >> On Tue, Oct 27, 2015 at 6:38 PM, Alan Lawrence wrote: >>> >>> Say I...P are consecutive, the input would have gaps 0 1 1 1 1 1 1 1. If we >>> split the

Re: [PATCH] Simple optimization for MASK_STORE.

On Mon, Nov 2, 2015 at 4:24 PM, Yuri Rumyantsev wrote: > Hi Richard, > > I've come back to this optimization and try to implement your proposal > for comparison: >> Btw, you didn't try the simpler alternative of >> >> tree type = type_for_mode (int_mode_for_mode (TYPE_MODE

[PATCH][cp][committed] Fix bootstrap on arm due to print format warning

Hi all, With Martins' patch at https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00492.html I'm seeing an arm bootstrap error due to a warning in the print format addressed in this patchlet. bytes_avail is an unsigned HOST_WIDE_INT and so needs the %wu print format rather than %lu which may not be

Re: OpenACC declare directive updates

Jakub, Ping Do you need more information before you can review this patch? Thanks! Jim On 11/04/2015 06:32 AM, James Norris wrote: This patch updates the processing of OpenACC declare directive for Fortran in the following areas: 1) module support 2)

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

On 10/28/2015 01:07 PM, Kyrill Tkachov wrote: Hi all, This RTL checking error occurs on aarch64 in aarch_accumulator_forwarding when processing an msubsi insn with subregs: (insn 15 14 16 3 (set (reg/v:SI 78 [ i ]) (minus:SI (subreg:SI (reg/v:DI 76 [ aul ]) 0) (mult:SI

Re: improved RTL-level if conversion using scratchpads [half-hammock edition]

On Fri, Nov 6, 2015 at 2:56 AM, Bernd Schmidt wrote: > Formatting problem, here and in a few other places. I didn't fully read the > patch this time around. > > I'm probably not reviewing further patches because I don't see this > progressing to a state where it's acceptable.

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

On 11/06/2015 03:08 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 03:05:05PM +0100, Bernd Schmidt wrote: This patch creates a new "omp target entrypoint" annotation that appears not to be used - it would be better to just not annotate a function if it's not going to need entrypoint

Re: regrename: don't overflow insn_rr_info

On 06/11/15 11:31, Bernd Schmidt wrote: > On 11/06/2015 12:17 PM, Ramana Radhakrishnan wrote: >> On 06/11/15 11:08, Bernd Schmidt wrote: >>> This one is a fix for something that could currently only affect c6x, but I >>> have code that exposes it on i386. >>> >>> When optionally gathering

Re: Merge of HSA branch

Hi! On Fri, 6 Nov 2015 12:03:25 +0100, Bernd Schmidt wrote: > On 11/06/2015 11:30 AM, Richard Biener wrote: > > On Fri, 6 Nov 2015, Bernd Schmidt wrote: > >> > >> Realistically we're probably not going to reject this work, but I still > >> want > >> to ask whether the

Re: [hsa 10/12] HSAIL BRIG description header file (hopefully not a licensing issue)

On 11/06/2015 12:29 PM, Bernd Schmidt wrote: David Cc'ed so he can take the necessary steps. Initially, I have created the file by copying out pieces of PDF documentation but the latest version of the file (describing final HSAIL 1.0) is actually taken from the HSAIL (dis)assembler developed

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

> Hi! > > I faced the same issue but I had somewhat different RTL for the consumer: > > (insn 20 15 21 2 (set (reg/i:SI 0 r0) > (minus:SI (subreg:SI (reg:DI 117) 4) > (mult:SI (reg:SI 123) > (reg:SI 114 gasman.c:4 48 {*mulsi3subsi}) > >

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

On 06/11/15 17:09, Kyrill Tkachov wrote: On 06/11/15 17:07, Nikolai Bozhenov wrote: On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL for the consumer: (insn 20 15 21 2 (set (reg/i:SI 0 r0) (minus:SI (subreg:SI

Re: [PATCH][combine][RFC] Don't transform sign and zero extends inside mults

On 11/06/2015 07:19 AM, Kyrill Tkachov wrote: I think we should also add: && REG_P (XEXP (XEXP (x, 0), 0)) && REG_P (XEXP (XEXP (x, 1), 0)) I tend to agree. Yep, see new patch. The "from == to" condition is for when subst is called just to simplify some code (normally with

Re: Change behavior of -fsched-verbose option

On 10/22/2015 09:38 AM, Nikolai Bozhenov wrote: Hi! Currently -fsched-verbose option redirects debugging dumps to stderr if there is no dump_file for the current pass. It would be fine if there were the only scheduling pass. But for example for AArch64 there are 3 scheduling passes in the

Re: [RFA] Do not use libiberty's getpagesize on Android

> > libiberty/ChangeLog: > > > > * configure.ac: Set AC_CV_FUNC_GETPAGESIZE to "yes" on > > Android hosts. > > * configure: Regenerate. > > > > OK to apply? > > Ok. Thank you, DJ. committed in gcc's SVN, and pushed to binutils-gdb. -- Joel

Re: [PATCH][RFC] Remove warning for SET VOIDmode -> BLKmode.

On 11/03/2015 10:16 AM, Dominik Vogt wrote: (Debug code removed from patch.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany 0001-ChangeLog gcc/ChangeLog * genrecog.c (validate_pattern): Allow "set VOIDmode -> BLKmode" without warnings. First, for reference, I was

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

On 11/06/2015 12:30 PM, Bernd Schmidt wrote: On 11/06/2015 08:20 PM, Jeff Law wrote: So maybe what noce_mem_write_may_trap_or_fault_p is really trying to do is take objects where may_trap_or_fault_p returns false, but which in fact may fault if we write that memory? ie, working around lameness

Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c

On Nov 4, 2015, at 1:02 PM, Manuel López-Ibáñez wrote: > 24:missing

Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c

On Nov 4, 2015, at 1:02 PM, Manuel López-Ibáñez wrote: > On 4 November 2015 at 09:45, Mike Stump wrote: >> in the top of the tree. This is bad as the same line appears in a PASS: and >> an XFAIL:. Each test case should be unique. Should it be

Re: [PATCH 3/6] Share code from fold_array_ctor_reference with fold.

On 11/04/2015 07:35 AM, Alan Lawrence wrote: s/explicitely/explicitly/ And remove the '*' from the 2nd and 3rd lines of the comment. It looks like get_ctor_element_at_index has numerous formatting problems. In particular you didn't indent the braces across the board properly. Also check for

[PATCH] Implement OpenMP 4.5 region/construct nesting rules

Hi! I've committed following patch, after reading through all the OpenMP 4.5 region/construct nesting rules. Bootstrapped/regtested on x86_64-linux and i686-linux. 2015-11-06 Jakub Jelinek * gimplify.c (gimplify_omp_ordered): Fix up diagnostics wording.

Re: [PATCH][combine][RFC] Don't transform sign and zero extends inside mults

[ reordered a bit ] On Fri, Nov 06, 2015 at 02:14:12PM -0700, Jeff Law wrote: > On 11/06/2015 07:19 AM, Kyrill Tkachov wrote: > >>>I think we should also add: > >>> && REG_P (XEXP (XEXP (x, 0), 0)) > >>> && REG_P (XEXP (XEXP (x, 1), 0)) > I tend to agree. > >Indeed, this looks better

<    1   2   3   >