[PATCH] Fix PR c++/68948 (wrong code generation due to invalid constructor call)

2016-02-04 Thread Patrick Palka
The compiler correctly detects and diagnoses invalid constructor calls such as C::C () in a non-template context but it fails to do so while processing a class template. [ Section 3.4.3.1 of the standard is what makes these forms of constructor calls illegal -- see https://gcc.gnu.org/bugzilla/sho

[committed, PATCH] Compile pr69454-2.c with -msse2 -mno-accumulate-outgoing-args

2016-02-04 Thread H.J. Lu
pr69454-2.c needs -msse2 -mno-accumulate-outgoing-args to fail. Checked into trunk. H.J. Index: ChangeLog === --- ChangeLog (revision 233165) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2016-02-04 H.J. Lu + + * gcc.tar

Re: [PATCH, rs6000] Fix type attribute for a few insns

2016-02-04 Thread David Edelsohn
On Thu, Feb 4, 2016 at 9:33 PM, Pat Haugen wrote: > The following patch fixes a few insns that were specifying an incorrect > 'type' attribute. > > Bootstrap/regtest on powerpc64-linux with no new regressions. Ok for trunk? > > -Pat > > > 2016-02-04 Pat Haugen > > * config/rs6000/crypto

[PATCH, rs6000] Fix type attribute for a few insns

2016-02-04 Thread Pat Haugen
The following patch fixes a few insns that were specifying an incorrect 'type' attribute. Bootstrap/regtest on powerpc64-linux with no new regressions. Ok for trunk? -Pat 2016-02-04 Pat Haugen * config/rs6000/crypto.md (crypto_vpermxor_): Correct insn type. * config/rs60

[PATCH] add basic .gitattributes files to notice whitespace issues

2016-02-04 Thread tbsaunde+gcc
From: Trevor Saunders Hi, We can tell git to highlight whitespace errors in diffs, and if you enable the default pre-commit hook git won't allow you to make a commit with a whitespace error violating the rules you told it about. These files as are could be improved some, they don't enforce whi

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-04 Thread Jonathan Wakely
On 04/02/16 22:41 +, Jonathan Wakely wrote: On 04/02/16 17:31 -0500, John David Anglin wrote: On 2016-02-04 5:11 PM, Gerald Pfeifer wrote: In file included from .././../gcc-6-20160131/gcc/genautomata.c:116:0: /wrkdirs/usr/ports/lang/gcc6-devel/work/gcc-6-20160131/libstdc++-v3/include/c_comp

[patch] libstdc++/69626 Test for C99 stdlib.h functions with -std=c++98

2016-02-04 Thread Jonathan Wakely
When r230324 split the GLIBCXX_ENABLE_C99 configure checks to test everything twice, once with -std=gnu++98 and once with -std=gnu++11, we failed to check the stdlib.h functions with gnu++98. As a result _GLIBCXX98_USE_C99_STDLIB was never defined, and so various C99 functions disappeared from nam

Re: [PATCH] combine: distribute_notes again (PR69567, PR64682)

2016-02-04 Thread Segher Boessenkool
On Tue, Feb 02, 2016 at 11:32:08AM +, Segher Boessenkool wrote: > As it happens the patch I did over a year ago for PR64682 isn't quite > correct. This is PR69567. This fixes it. > > Tested on the separate testcases; also did bootstrap + testsuite on > powerpc64-linux and x86_64-linux. I'll

[PATCH] Fix up bootstrap on i686 --with-arch=corei7 --with-fpmath=sse (PR bootstrap/69677)

2016-02-04 Thread Jakub Jelinek
Hi! As mentioned in the PR, the convert_scalars_to_vector hunk is important, without that we e.g. miscompile simplify-rtx.c. The following patch restores that hunk and extends disabling of TARGET_STV also for the 64-bit, but not 128-bit, aligned preferred or incoming stack boundaries (also non-def

msp430: fix function type declarations

2016-02-04 Thread DJ Delorie
Minor bug, fixed, committed. * config/msp430/msp430.c (msp430_start_function): Add function type. 2016-02-04 Uros Bizjak Index: config/msp430/msp430.c === --- config/msp430/msp430.c (revision 233155) +++ config/msp

Re: [gofrontend-dev] Re: libgo patch committed: Update to Go 1.6rc1

2016-02-04 Thread Ian Lance Taylor
On Thu, Feb 4, 2016 at 6:12 AM, Lynn A. Boger wrote: > Should the libgo version number be updated? Thanks for the reminder. Done like so. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === --- gcc/go/gofrontend/MERGE

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-04 Thread Jonathan Wakely
On 04/02/16 23:11 +0100, Gerald Pfeifer wrote: It seems to break older versions of FreeBSD that have GCC 4.2 as their system compiler. (Those versions aren't actually all that old, they are stuck with GCC 4.2 as the last version under GPLv2.) The version of GCC doesn't matter, it's whether lib

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-04 Thread Jonathan Wakely
On 04/02/16 17:31 -0500, John David Anglin wrote: On 2016-02-04 5:11 PM, Gerald Pfeifer wrote: In file included from .././../gcc-6-20160131/gcc/genautomata.c:116:0: /wrkdirs/usr/ports/lang/gcc6-devel/work/gcc-6-20160131/libstdc++-v3/include/c_compatibility/math.h:65:12: error: 'constexpr bool st

Re: [PATCH] Fix c/69643, named address space wrong-code

2016-02-04 Thread Richard Henderson
On 02/05/2016 08:59 AM, Richard Biener wrote: This version fails to fall through to the next code block when (1) Both types are pointers, (2) Both types have the same address space, which will do the wrong thing when (3) The pointers have different modes. Recall that several ports allow

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-04 Thread John David Anglin
On 2016-02-04 5:11 PM, Gerald Pfeifer wrote: In file included from .././../gcc-6-20160131/gcc/genautomata.c:116:0: /wrkdirs/usr/ports/lang/gcc6-devel/work/gcc-6-20160131/libstdc++-v3/include/c_compatibility/math.h:65:12: error: 'constexpr bool std::isinf(double)' conflicts with a previous declara

[PATCH] PR preprocessor/69664: fix rich_location::override_column

2016-02-04 Thread David Malcolm
In gcc 5 and earlier, struct diagnostic_info had a field: unsigned int override_column; which could be set by the macro: diagnostic_override_column This was only used by the frontends' callbacks for handling errors from libcpp: c_cpp_error for the c-family, and cb_cpp_error for Fortran: if (

Re: [PATCH] [documentation] Fix documentation of --param

2016-02-04 Thread Sandra Loosemore
On 02/04/2016 07:42 AM, Jeremy Bennett wrote: The attached patch corrects some errors in documentation of the --param option to gcc. Mostly they are corrections to the names of options, but two parameters are documented which do not exist in trunk. gcc/ChangeLog: * doc/invoke.texi (Opt

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-04 Thread Gerald Pfeifer
On Thu, 28 Jan 2016, Jonathan Wakely wrote: > On 27/01/16 19:49 -0500, John David Anglin wrote: >> The attached patch fixes a stage1 build error compiling genautomata.c >> on hpux. We need to test for obsolete XOPEN declarations of isinf and >> isnan on hpux. Further, we need to check individua

Re: [Patch, MIPS] Fix PR target/68273, passing args in wrong regs

2016-02-04 Thread Richard Biener
On February 4, 2016 9:28:22 PM GMT+01:00, Richard Sandiford wrote: >Richard Biener writes: >> On Thu, Feb 4, 2016 at 12:09 PM, Eric Botcazou > wrote: So this doesn’t fix aarch64, c6x, epiphany, ia64, iq2000, rs6000, >rx, sparc, tilegx, tilepro or xtensa. :-( That’s one of the pro

[patch, Fortran] Fix PR 60526, variable name has already been declared as a type

2016-02-04 Thread Thomas Koenig
Hello world, For a type 'foo', we use a symtree 'Foo'. This led to accept-invalid when a variable name was already declared as a type. This rather self-explanatory patch fixes that. Regression-tested. OK for trunk and 5? (Do we still care about 4.9?) Regards Thomas 2016-02-03 Tho

Re: [PATCH] Fix c/69643, named address space wrong-code

2016-02-04 Thread Richard Biener
On February 4, 2016 10:04:47 PM GMT+01:00, Richard Henderson wrote: >On 02/04/2016 10:07 PM, Richard Biener wrote: >> On Wed, Feb 3, 2016 at 10:44 PM, Richard Henderson >wrote: >>> On 02/04/2016 07:30 AM, Richard Henderson wrote: On 02/04/2016 12:46 AM, Richard Biener wrote: >

Re: [PATCH] Remove unreachable code from get_ref_base_and_extent

2016-02-04 Thread Richard Biener
On February 4, 2016 8:50:58 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >As discussed on IRC and in the PR, get_ref_base_and_extent has >a big while (1) which can be only left with goto done;, so code >in between the end of that loop and the done: label is unreachable. >If the base is *MEM_REF, we

[patch] Update copyright years in libstdc++ manual

2016-02-04 Thread Jonathan Wakely
Some minor doc updates. Committed to trunk. commit e7a4324d0f8bb8bd622e1412b7daf8b8a2d91430 Author: Jonathan Wakely Date: Thu Feb 4 21:41:31 2016 + Update copyright years in libstdc++ manual and add link * doc/xml/manual/containers.xml: Add cross-reference to Dual ABI.

Re: [C PATCH] Fix up handling of enum with mode attribute (PR c/69669)

2016-02-04 Thread Joseph Myers
On Thu, 4 Feb 2016, Jakub Jelinek wrote: > Hi! > > If an enum has mode attribute, then finish_enum uses the precision > from its mode (and complains if the enumerators don't fit into that > precision), but will use TYPE_{MIN,MAX}_VALUE from int's precision instead. > > Fixed thusly, bootstrapped

Re: [PATCH] tweak -Wplacement-new to fix #69662

2016-02-04 Thread Martin Sebor
On 02/04/2016 02:10 PM, Jason Merrill wrote: On 02/04/2016 03:22 PM, Martin Sebor wrote: + /* Refers to the declared object that constains the subobject referenced + by OPER. When the object is initialized, makes it possible to determine + the actual size of a flexible array member use

Re: [PATCH] tweak -Wplacement-new to fix #69662

2016-02-04 Thread Jason Merrill
On 02/04/2016 03:22 PM, Martin Sebor wrote: + /* Refers to the declared object that constains the subobject referenced + by OPER. When the object is initialized, makes it possible to determine + the actual size of a flexible array member used as the buffer passed + as OPER to placem

Re: [PATCH] Fix c/69643, named address space wrong-code

2016-02-04 Thread Richard Henderson
On 02/04/2016 10:07 PM, Richard Biener wrote: On Wed, Feb 3, 2016 at 10:44 PM, Richard Henderson wrote: On 02/04/2016 07:30 AM, Richard Henderson wrote: On 02/04/2016 12:46 AM, Richard Biener wrote: As for a patch I'd repeatedly pondered on not stripping int <-> pointer conversions at all,

Re: [PATCH], PR 69667, Fix PowerPC long double failure with -mlra

2016-02-04 Thread David Edelsohn
On Thu, Feb 4, 2016 at 3:39 PM, Michael Meissner wrote: > This patch fixes a bug where LRA would abort when compiling a C++ program with > -mlra. I tracked this down to using the "ws" constraint for TFmode, TDmode, > and IFmode, but those types are limited to just the traditional floating point >

Re: [PATCH, i386] Partially revert ix86_cannot_change_mode_class changes

2016-02-04 Thread Richard Henderson
On 02/05/2016 07:07 AM, Uros Bizjak wrote: Adding forgotten CCs... On Thu, Feb 4, 2016 at 8:49 PM, Uros Bizjak wrote: Hello! After PR rtl-optimization/69577 fix went in, it looks that we can remove various kludges involving SSE and MMX register classes from ix86_cannot_change_mode_class. 201

[PATCH], PR 69667, Fix PowerPC long double failure with -mlra

2016-02-04 Thread Michael Meissner
This patch fixes a bug where LRA would abort when compiling a C++ program with -mlra. I tracked this down to using the "ws" constraint for TFmode, TDmode, and IFmode, but those types are limited to just the traditional floating point registers (ws on power8 targets all of the VSX registers). With

Re: [Patch, MIPS] Fix PR target/68273, passing args in wrong regs

2016-02-04 Thread Richard Sandiford
Richard Biener writes: > On Thu, Feb 4, 2016 at 12:09 PM, Eric Botcazou wrote: >>> So this doesn’t fix aarch64, c6x, epiphany, ia64, iq2000, rs6000, rx, sparc, >>> tilegx, tilepro or xtensa. >>> :-( That’s one of the problems by having each port copy and paste swaths of >>> :code from other port

Re: lra-remat issues (PR68730)

2016-02-04 Thread Vladimir Makarov
On 02/04/2016 12:17 PM, Bernd Schmidt wrote: In this PR, we have, at an intermediate stage during LRA (before create_cands): (insn 420 (set (reg:HI 276 [orig:132 g.2_118 ] [132]) (reg:HI 132 [ g.2_118 ])) 88 {*movhi_internal} (nil)) [] (insn 436 (set (reg/v:HI 290 [orig:87 g ]

[PATCH] tweak -Wplacement-new to fix #69662

2016-02-04 Thread Martin Sebor
The attached patch implements the changes to the warning we discussed in IRC yesterday. With the patch GCC is by default silent about the test case in bug 69662 and diagnoses it only with -Wplacement-new=2. Arrays of other sizes and statically allocated objects are diagnosed as before. Tested o

Re: patch to fix PR69461

2016-02-04 Thread Michael Meissner
On Wed, Feb 03, 2016 at 10:13:21PM -0500, Vladimir Makarov wrote: > Thanks, Mike. I found it when trying to fix numerous LRA failures > on power8. Reload pass when can not figure out what to do with > illegitimate address does nothing. LRA tried still to do something. > I've made LRA working as

Re: [PATCH, i386] Partially revert ix86_cannot_change_mode_class changes

2016-02-04 Thread Uros Bizjak
Adding forgotten CCs... On Thu, Feb 4, 2016 at 8:49 PM, Uros Bizjak wrote: > Hello! > > After PR rtl-optimization/69577 fix went in, it looks that we can > remove various kludges involving SSE and MMX register classes from > ix86_cannot_change_mode_class. > > 2016-02-04 Uros Bizjak > > PR

[C++ PATCH] Fix regression due to reshape_init being called multiple times (PR c++/69658)

2016-02-04 Thread Jakub Jelinek
Hi! As mentioned in the PR, it seems reshape_init isn't prepared to be called on the result of earlier reshape_init call, but since the recent Paolo's changes expand_default_init can call it the second time. The following patch attempts to narrow it down to the case where it has not been called y

[C PATCH] Fix up handling of enum with mode attribute (PR c/69669)

2016-02-04 Thread Jakub Jelinek
Hi! If an enum has mode attribute, then finish_enum uses the precision from its mode (and complains if the enumerators don't fit into that precision), but will use TYPE_{MIN,MAX}_VALUE from int's precision instead. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

[PATCH] Remove unreachable code from get_ref_base_and_extent

2016-02-04 Thread Jakub Jelinek
Hi! As discussed on IRC and in the PR, get_ref_base_and_extent has a big while (1) which can be only left with goto done;, so code in between the end of that loop and the done: label is unreachable. If the base is *MEM_REF, we already set maxsize to -1, and for decls it really shouldn't be needed,

[PATCH, i386] Partially revert ix86_cannot_change_mode_class changes

2016-02-04 Thread Uros Bizjak
Hello! After PR rtl-optimization/69577 fix went in, it looks that we can remove various kludges involving SSE and MMX register classes from ix86_cannot_change_mode_class. 2016-02-04 Uros Bizjak PR rtl-optimization/69577 Revert: 2015-10-29 Richard Henderson PR target/68124

Re: [PATCH, PR target/69454] Disable TARGET_STV when stack is not properly aligned

2016-02-04 Thread H.J. Lu
On Thu, Feb 4, 2016 at 12:02 AM, Uros Bizjak wrote: > On Wed, Feb 3, 2016 at 9:11 PM, Jakub Jelinek wrote: >> Hi! >> >> On Tue, Feb 02, 2016 at 05:09:34PM +0300, Ilya Enkovich wrote: >>> And it's too late to do it after STV pass and therefore we disable it >>> when stack is not properly aligned.

Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member

2016-02-04 Thread Mike Stump
On Feb 4, 2016, at 10:23 AM, Martin Sebor wrote: > Yes, I sure did! (But no, it wasn't obvious to me. I recently > upgraded this machine and did it differently than I normally do, > so things are, well, different than I expected. FWIW, it would > be nice to mention this as the first step at the

Re: [PATCH][ARM][0/4] Fixing PR target/65932

2016-02-04 Thread H.J. Lu
On Thu, Feb 4, 2016 at 1:34 AM, Kyrill Tkachov wrote: > > On 04/02/16 09:13, Ramana Radhakrishnan wrote: >> >> On Fri, Jan 22, 2016 at 9:52 AM, Kyrill Tkachov >> wrote: >>> >>> Hi all, >>> >>> PR target/65932 is a wrong-code bug affecting arm and has manifested >>> itself >>> when compiling the L

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Jason Merrill
On 02/04/2016 12:24 PM, Patrick Palka wrote: On Thu, Feb 4, 2016 at 11:57 AM, Jason Merrill wrote: On 02/04/2016 10:32 AM, Patrick Palka wrote: On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: On 02/03/2016 12:51 PM, Patrick Palka wrote: + && (integer_minus_onep (lhs) +

Re: [Patch, MIPS] Fix PR target/68273, passing args in wrong regs

2016-02-04 Thread Steve Ellcey
On Thu, 2016-02-04 at 12:09 +0100, Eric Botcazou wrote: > > So this doesn’t fix aarch64, c6x, epiphany, ia64, iq2000, rs6000, rx, sparc, > > tilegx, tilepro or xtensa. > > :-( That’s one of the problems by having each port copy and paste swaths of > > :code from other ports to express the same thi

Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member

2016-02-04 Thread Martin Sebor
On 02/04/2016 10:39 AM, Mike Stump wrote: On Feb 4, 2016, at 7:32 AM, Martin Sebor wrote: FWIW, I keep having trouble with the repository. $ svn switch --relocate svn://gcc.gnu.org/svn/gcc svn+ssh://mse...@gcc.gnu.org/svn/gcc svn: E170013: Unable to connect to a repository at URL 'svn+ssh:

Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member

2016-02-04 Thread Mike Stump
On Feb 4, 2016, at 7:32 AM, Martin Sebor wrote: > FWIW, I keep having trouble with the repository. > $ svn switch --relocate svn://gcc.gnu.org/svn/gcc > svn+ssh://mse...@gcc.gnu.org/svn/gcc > svn: E170013: Unable to connect to a repository at URL > 'svn+ssh://mse...@gcc.gnu.org/svn/gcc/trunk' >

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Patrick Palka
On Thu, Feb 4, 2016 at 12:24 PM, Patrick Palka wrote: > On Thu, Feb 4, 2016 at 11:57 AM, Jason Merrill wrote: >> On 02/04/2016 10:32 AM, Patrick Palka wrote: >>> >>> On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: On 02/03/2016 12:51 PM, Patrick Palka wrote: > > > +

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Patrick Palka
On Thu, Feb 4, 2016 at 11:57 AM, Jason Merrill wrote: > On 02/04/2016 10:32 AM, Patrick Palka wrote: >> >> On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: >>> >>> On 02/03/2016 12:51 PM, Patrick Palka wrote: + && (integer_minus_onep (lhs) + || integer_

lra-remat issues (PR68730)

2016-02-04 Thread Bernd Schmidt
In this PR, we have, at an intermediate stage during LRA (before create_cands): (insn 420 (set (reg:HI 276 [orig:132 g.2_118 ] [132]) (reg:HI 132 [ g.2_118 ])) 88 {*movhi_internal} (nil)) [] (insn 436 (set (reg/v:HI 290 [orig:87 g ] [87]) (reg/v:HI 87 [ g ])) (insn 14 (

Re: [PATCH][AArch64] Only update assembler .arch directive when necessary

2016-02-04 Thread Kyrill Tkachov
On 04/02/16 17:12, Andrew Pinski wrote: On Thu, Feb 4, 2016 at 5:50 AM, Kyrill Tkachov wrote: Hi all, As part of the target attributes and pragmas support for GCC 6 I changed the aarch64 port to emit a .arch assembly directive for each function that describes the architectural features used b

Re: [PATCH][AArch64] Only update assembler .arch directive when necessary

2016-02-04 Thread Andrew Pinski
On Thu, Feb 4, 2016 at 5:50 AM, Kyrill Tkachov wrote: > Hi all, > > As part of the target attributes and pragmas support for GCC 6 I changed the > aarch64 port > to emit a .arch assembly directive for each function that describes the > architectural features > used by that function. This is a cha

Re: [RFC] Variants of __typeof

2016-02-04 Thread Pedro Alves
On 02/04/2016 04:14 PM, Richard Henderson wrote: > On 02/04/2016 10:02 PM, Marek Polacek wrote: >>> Do we need matching __auto_type variants? >> >> I think at present __auto_type removes the qualifiers from atomic types only, >> but I'd hope we can just adjust __auto_type to always strip the qualif

Re: [PATCH PR69652, Regression]

2016-02-04 Thread Jakub Jelinek
On Thu, Feb 04, 2016 at 05:46:27PM +0300, Yuri Rumyantsev wrote: > Here is a patch that cures the issues with non-correct vuse for scalar > statements during code motion, i.e. if vuse of scalar statement is > vdef of masked store which has been sunk to new basic block, we must > fix it up. The pat

Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member

2016-02-04 Thread Martin Sebor
On 02/04/2016 09:38 AM, Jason Merrill wrote: On 02/04/2016 10:32 AM, Martin Sebor wrote: FWIW, I keep having trouble with the repository. Git doesn't work to check things in at all The instructions here aren't working for you? https://gcc.gnu.org/wiki/GitMirror#Commit_upstream_.28git-svn.29

[PATCH] S/390: Fix r6 vararg handling.

2016-02-04 Thread Andreas Krebbel
This patch fixes a problem introduced with the GPR into FPR slot save feature for leaf functions. r6 is argument register as well as call-saved. Currently we might decide that it will be a candidate for being saved into an FPR. If it turns out later that r6 also needs to be saved due to being re

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Jason Merrill
On 02/04/2016 10:32 AM, Patrick Palka wrote: On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: On 02/03/2016 12:51 PM, Patrick Palka wrote: + && (integer_minus_onep (lhs) + || integer_minus_onep (rhs))) Let's use null_member_pointer_value_p here. Done. Please ad

Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member

2016-02-04 Thread Jason Merrill
On 02/04/2016 10:32 AM, Martin Sebor wrote: FWIW, I keep having trouble with the repository. Git doesn't work to check things in at all The instructions here aren't working for you? https://gcc.gnu.org/wiki/GitMirror#Commit_upstream_.28git-svn.29 and I have only one svn repository that does

Re: [RFC] Variants of __typeof

2016-02-04 Thread Richard Henderson
On 02/04/2016 09:09 PM, Marek Polacek wrote: We've already been asked to add something like __typeof_noqual, e.g. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39985#c3 . In a similar PR, I wanted to modify __typeof to drop all qualifiers, but Joseph suggested instead to add a new typeof variant:

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-04 Thread Ulrich Weigand
Marcin Kościelnicki wrote: > Fair enough. Here's what I'm going to implement in gold: > > - any PLT relocation: call > - PC32DBL on a larl: non-call > - PC32DBL otherwise: call > - any other relocation: non-call > > Does that sound right? Hmm, I'm wondering about the PC32DBL choices. There a

Re: [RFC] Variants of __typeof

2016-02-04 Thread Richard Henderson
On 02/04/2016 10:02 PM, Marek Polacek wrote: Do we need matching __auto_type variants? I think at present __auto_type removes the qualifiers from atomic types only, but I'd hope we can just adjust __auto_type to always strip the qualifiers, not introduce __auto_type_noqual... Exactly what I w

Re: [PATCH] Fix jit crash on aarch64, mips

2016-02-04 Thread James Greenhalgh
On Thu, Feb 04, 2016 at 10:31:27AM -0500, David Malcolm wrote: > The jit testsuite was showing numerous segfaults and fatal > errors for trunk on aarch64; typically on the 2nd iteration of each > test, with errors like: > test-volatile.c.exe: fatal error: pass ‘rnreg’ not found but is referenced

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Patrick Palka
On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: > On 02/03/2016 12:51 PM, Patrick Palka wrote: >> >> + && (integer_minus_onep (lhs) >> + || integer_minus_onep (rhs))) > > > Let's use null_member_pointer_value_p here. Done. > > Please add pointers to member functions to t

Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member

2016-02-04 Thread Martin Sebor
On 02/04/2016 04:05 AM, Jakub Jelinek wrote: On Tue, Feb 02, 2016 at 06:21:04PM -0700, Martin Sebor wrote: gcc/cp/ChangeLog: 2016-02-02 Martin Sebor PR c++/69251 PR c++/69253 PR c++/69290 PR c++/69277 PR c++/69349 * class.c (walk_subobject_offs

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-04 Thread Marcin Kościelnicki
On 04/02/16 16:06, Ulrich Weigand wrote: Marcin Kościelnicki wrote: Ugh. I take that back. For -fPIC, the load-address sequence is: larl%r1,f@GOTENT lg %r2,0(%r1) br %r14 This is correct. And (sibling) call sequence is: larl%r1,f

[PATCH] Fix jit crash on aarch64, mips

2016-02-04 Thread David Malcolm
The jit testsuite was showing numerous segfaults and fatal errors for trunk on aarch64; typically on the 2nd iteration of each test, with errors like: test-volatile.c.exe: fatal error: pass ‘rnreg’ not found but is referenced by new pass ‘whole-program’ where the new pass' name varies, and can be

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-04 Thread Ulrich Weigand
Marcin Kościelnicki wrote: > Ugh. I take that back. For -fPIC, the load-address sequence is: > > larl%r1,f@GOTENT > lg %r2,0(%r1) > br %r14 This is correct. > And (sibling) call sequence is: > > larl%r1,f@GOTENT > lg %r1,0(%

Re: [Patch, testsuite] Require int32 target support in sso tests

2016-02-04 Thread Mike Stump
On Feb 4, 2016, at 5:46 AM, Senthil Kumar Selvaraj wrote: > When running the regression testsuite for the AVR target, I noticed a > bunch of sso tests failing > If this patch is ok, could someone commit please? The patch is Ok. I don’t recall a target supports for I/O. So, I/O is incredible

Un-parallelized OpenACC kernels constructs with nvptx offloading: "avoid offloading"

2016-02-04 Thread Thomas Schwinge
Hi! On Fri, 22 Jan 2016 14:31:35 +0100, Bernd Schmidt wrote: > On 01/22/2016 02:25 PM, Jakub Jelinek wrote: > > > What about #pragma oacc parallel? That would never do that? > > It shouldn't, no (IMO). Correct. Here is the patch re-worked for trunk. Instead of passing -foffload-force in th

[PATCH PR69652, Regression]

2016-02-04 Thread Yuri Rumyantsev
Hi All, Here is a patch that cures the issues with non-correct vuse for scalar statements during code motion, i.e. if vuse of scalar statement is vdef of masked store which has been sunk to new basic block, we must fix it up. The patch also fixed almost all remarks pointed out by Jacub. Bootstra

[PATCH] [documentation] Fix documentation of --param

2016-02-04 Thread Jeremy Bennett
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The attached patch corrects some errors in documentation of the --param option to gcc. Mostly they are corrections to the names of options, but two parameters are documented which do not exist in trunk. gcc/ChangeLog: * doc/invoke.texi (Optim

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Jason Merrill
On 02/03/2016 12:51 PM, Patrick Palka wrote: + && (integer_minus_onep (lhs) + || integer_minus_onep (rhs))) Let's use null_member_pointer_value_p here. Please add pointers to member functions to the testcase. Jason

Re: [PATCH] Partially fix PR c++/12277 (Warn on dynamic cast with known NULL results)

2016-02-04 Thread Jason Merrill
On 02/03/2016 10:07 PM, Patrick Palka wrote: It just occurred to me that issuing this warning during template instantiation may be undesirable if the dynamic_cast being built was originally dependent (for the same reasons it is undesirable to issue -Wuseless-cast warnings during instantiation, wh

Re: libgo patch committed: Update to Go 1.6rc1

2016-02-04 Thread Lynn A. Boger
Should the libgo version number be updated? On 02/03/2016 03:58 PM, Ian Lance Taylor wrote: I've committed a patch to the libgo library to update it to Go 1.6rc1, the first release candidate for the Go 1.6 release. As usual with major libgo updates, the change is too large to include here. I'v

Re: [PATCH] Fix -mcpu=power8 atomic expansion (PR target/69644)

2016-02-04 Thread Alan Modra
On Thu, Feb 04, 2016 at 02:42:38PM +0100, Jakub Jelinek wrote: > On Thu, Feb 04, 2016 at 08:40:22AM -0500, David Edelsohn wrote: > > On Thu, Feb 4, 2016 at 6:33 AM, Alan Modra wrote: > > > On Wed, Feb 03, 2016 at 05:34:17PM -0500, David Edelsohn wrote: > > >> On Wed, Feb 3, 2016 at 5:28 PM, Jakub

[PATCH][AArch64] Only update assembler .arch directive when necessary

2016-02-04 Thread Kyrill Tkachov
Hi all, As part of the target attributes and pragmas support for GCC 6 I changed the aarch64 port to emit a .arch assembly directive for each function that describes the architectural features used by that function. This is a change from GCC 5 behaviour where we output a single .arch directiv

Re: [PATCH][AArch64] PR target/69161: Don't use special predicate for CCmode comparisons in expressions that require matching modes

2016-02-04 Thread James Greenhalgh
On Fri, Jan 29, 2016 at 02:27:34PM +, Kyrill Tkachov wrote: > Hi all, > > In this PR we ICE during combine when trying to propagate a comparison into a > vec_duplicate, > that is we end up creating the rtx: > (vec_duplicate:V4SI (eq:CC_NZ (reg:CC_NZ 66 cc) > (const_int 0 [0]))) > > T

[Patch, testsuite] Require int32 target support in sso tests

2016-02-04 Thread Senthil Kumar Selvaraj
Hi, When running the regression testsuite for the AVR target, I noticed a bunch of sso tests failing - turns out they assume sizeof(int) == 4. This patch marks them UNSUPPORTED for targets that don't match that assumption, by requiring effective-target int32. A few tests still run and

Re: [PATCH] Fix -mcpu=power8 atomic expansion (PR target/69644)

2016-02-04 Thread Jakub Jelinek
On Thu, Feb 04, 2016 at 08:40:22AM -0500, David Edelsohn wrote: > On Thu, Feb 4, 2016 at 6:33 AM, Alan Modra wrote: > > On Wed, Feb 03, 2016 at 05:34:17PM -0500, David Edelsohn wrote: > >> On Wed, Feb 3, 2016 at 5:28 PM, Jakub Jelinek wrote: > >> > Hi! > >> > > >> > rs6000_expand_atomic_compare_a

Re: [PATCH] Fix -mcpu=power8 atomic expansion (PR target/69644)

2016-02-04 Thread David Edelsohn
On Thu, Feb 4, 2016 at 6:33 AM, Alan Modra wrote: > On Wed, Feb 03, 2016 at 05:34:17PM -0500, David Edelsohn wrote: >> On Wed, Feb 3, 2016 at 5:28 PM, Jakub Jelinek wrote: >> > Hi! >> > >> > rs6000_expand_atomic_compare_and_swap uses oldval directly in >> > a comparison instruction, but oldval mi

[PATCH, testsuite]: Move gcc.dg/sancov/asan.c to gcc.dg/asan/sancov-1.c

2016-02-04 Thread Uros Bizjak
On Thu, Feb 4, 2016 at 1:49 PM, Andreas Schwab wrote: >>> OTOH, does this testcase even gets a chance to run? >> >> It's not a runtime check. > > But it didn't link until today: > > Running /opt/gcc/gcc-20160203/gcc/testsuite/gcc.dg/sancov/sancov.exp ... > Executing on host: /opt/gcc/gcc-20160203

Re: [wwwdocs] Add some C++ bits to porting_to

2016-02-04 Thread Marek Polacek
On Thu, Feb 04, 2016 at 01:01:10PM +, Jonathan Wakely wrote: [...] > After you mentioned this on IRC I wrote the following. I think yours > is probably a bit simpler to read and so better, but is it worth > taking the "unless a base class or member variable has a destructor > that is noexcept(f

Re: [wwwdocs] Add some C++ bits to porting_to

2016-02-04 Thread Jonathan Wakely
On 04/02/16 13:37 +0100, Marek Polacek wrote: I spotted these two issues in real-world code when doing Fedora mass rebuild. It's C++ and so I don't really know what I'm talking about; Jon, could you please look at this? Thanks, Index: porting_to.html

Re: [Patch, MIPS] Fix PR target/68273, passing args in wrong regs

2016-02-04 Thread Richard Biener
On Thu, Feb 4, 2016 at 1:49 PM, Richard Biener wrote: > On Thu, Feb 4, 2016 at 12:09 PM, Eric Botcazou wrote: >>> So this doesn’t fix aarch64, c6x, epiphany, ia64, iq2000, rs6000, rx, sparc, >>> tilegx, tilepro or xtensa. >>> :-( That’s one of the problems by having each port copy and paste swat

Re: [PATCH 4/4] Un-XFAIL ssa-dom-cse-2.c for most platforms

2016-02-04 Thread Richard Biener
On Thu, Feb 4, 2016 at 12:53 PM, Alan Lawrence wrote: > On 04/02/16 09:53, Dominik Vogt wrote: >> >> On Wed, Feb 03, 2016 at 11:41:02AM +, Alan Lawrence wrote: >>> >>> On 26/01/16 12:23, Dominik Vogt wrote: On Mon, Dec 21, 2015 at 01:13:28PM +, Alan Lawrence wrote: > > ..

Re: [PATCH, testsuite]: Improve check_effective_target_fsanitize_thread

2016-02-04 Thread Andreas Schwab
Andreas Schwab writes: > Uros Bizjak writes: > >> OTOH, does this testcase even gets a chance to run? > > It's not a runtime check. But it didn't link until today: Running /opt/gcc/gcc-20160203/gcc/testsuite/gcc.dg/sancov/sancov.exp ... Executing on host: /opt/gcc/gcc-20160203/Build/gcc/xgcc

Re: [Patch, MIPS] Fix PR target/68273, passing args in wrong regs

2016-02-04 Thread Richard Biener
On Thu, Feb 4, 2016 at 12:09 PM, Eric Botcazou wrote: >> So this doesn’t fix aarch64, c6x, epiphany, ia64, iq2000, rs6000, rx, sparc, >> tilegx, tilepro or xtensa. >> :-( That’s one of the problems by having each port copy and paste swaths of >> :code from other ports to express the same thing in

Re: [PATCH, testsuite]: Improve check_effective_target_fsanitize_thread

2016-02-04 Thread Andreas Schwab
Uros Bizjak writes: > OTOH, does this testcase even gets a chance to run? It's not a runtime check. Running /opt/gcc/gcc-20160204/gcc/testsuite/gcc.dg/sancov/sancov.exp ... Executing on host: /opt/gcc/gcc-20160204/Build/gcc/xgcc -B/opt/gcc/gcc-20160204/Build/gcc/ fsanitize_addres

Re: [PATCH] s390: Add -fsplit-stack support

2016-02-04 Thread Marcin Kościelnicki
On 03/02/16 18:27, Ulrich Weigand wrote: Marcin Kościelnicki wrote: libgcc/ChangeLog: * config.host: Use t-stack and t-stack-s390 for s390*-*-linux. * config/s390/morestack.S: New file. * config/s390/t-stack-s390: New file. * generic-morestack.c (__splitstack_f

[wwwdocs] Add some C++ bits to porting_to

2016-02-04 Thread Marek Polacek
I spotted these two issues in real-world code when doing Fedora mass rebuild. It's C++ and so I don't really know what I'm talking about; Jon, could you please look at this? Thanks, Index: porting_to.html === RCS file: /cvs/gcc/wwwd

[PATCH] S/390: Do not require -march=z13 on s390 but only on s390x.

2016-02-04 Thread Dominik Vogt
A previous patch required -march=z13 in ssa-dom-cse-2.c for s390 and s390x, but actually only s390x really needs it. The attached patch removes the extra option on s390 (and fixes comment formatting). Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany gcc/testsuite/ChangeLog * gcc.dg/

Re: [PATCH, testsuite]: Improve check_effective_target_fsanitize_thread

2016-02-04 Thread Uros Bizjak
> +}] >>>>> } >>>>> >>>> >>>> This is just weird. What if fsanitize_address effective target is used >>>> outside of asan/ (i.e. without asan_init first) ? >>> >>> It won't work, you also need various lin

New German PO file for 'cpplib' (version 6.1-b20160131)

2016-02-04 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/cpplib/de.po (This file, 'cpplib-6.1-b20160131.

Re: [PATCH, testsuite]: Improve check_effective_target_fsanitize_thread

2016-02-04 Thread Uros Bizjak
tize_address effective target is used >>> outside of asan/ (i.e. without asan_init first) ? >> >> It won't work, you also need various link flags that are part of >> TEST_ALWAYS_FLAGS. > > That breaks gcc.dg/sancov/asan.c. > > Running /usr/local/gcc/gcc-20160204

Re: [PATCH 4/4] Un-XFAIL ssa-dom-cse-2.c for most platforms

2016-02-04 Thread Alan Lawrence
On 04/02/16 09:53, Dominik Vogt wrote: On Wed, Feb 03, 2016 at 11:41:02AM +, Alan Lawrence wrote: On 26/01/16 12:23, Dominik Vogt wrote: On Mon, Dec 21, 2015 at 01:13:28PM +, Alan Lawrence wrote: ...the test passes with --param sra-max-scalarization-size-Ospeed. Verified on aarch64 an

Re: [PATCH] Fix -mcpu=power8 atomic expansion (PR target/69644)

2016-02-04 Thread Alan Modra
On Wed, Feb 03, 2016 at 05:34:17PM -0500, David Edelsohn wrote: > On Wed, Feb 3, 2016 at 5:28 PM, Jakub Jelinek wrote: > > Hi! > > > > rs6000_expand_atomic_compare_and_swap uses oldval directly in > > a comparison instruction, but oldval might be a CONST_INT not suitable > > for the instruction (s

Re: [PATCH][ARM] Remove neon_reinterpret, use casts

2016-02-04 Thread Ramana Radhakrishnan
On 04/02/16 11:04, Ramana Radhakrishnan wrote: > On Mon, Jan 18, 2016 at 12:14 PM, Alan Lawrence wrote: >> This cleans up the neon_reinterpret code on ARM in a similar way to AArch64. >> Rather than a builtin backing onto an expander that emits a mov insn, we can >> just use a cast, because GCC de

Re: [PATCH, testsuite]: Improve check_effective_target_fsanitize_thread

2016-02-04 Thread Andreas Schwab
return 0; } >>> -} "-fsanitize=address"] >>> +}] >>> } >>> >> >> This is just weird. What if fsanitize_address effective target is used >> outside of asan/ (i.e. without asan_init first) ? > > It won't work, you als

Re: [Patch, MIPS] Fix PR target/68273, passing args in wrong regs

2016-02-04 Thread Eric Botcazou
> So this doesn’t fix aarch64, c6x, epiphany, ia64, iq2000, rs6000, rx, sparc, > tilegx, tilepro or xtensa. > :-( That’s one of the problems by having each port copy and paste swaths of > :code from other ports to express the same thing instead of ports sharing > :just one copy of code. My port i

Re: [PATCH] Fix c/69643, named address space wrong-code

2016-02-04 Thread Richard Biener
On Wed, Feb 3, 2016 at 10:44 PM, Richard Henderson wrote: > On 02/04/2016 07:30 AM, Richard Henderson wrote: >> >> On 02/04/2016 12:46 AM, Richard Biener wrote: >>> >>> As for a patch I'd repeatedly pondered on not stripping int <-> pointer >>> conversions at all, similar to what STRIP_SIGN_NOPS d

Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member

2016-02-04 Thread Jakub Jelinek
On Tue, Feb 02, 2016 at 06:21:04PM -0700, Martin Sebor wrote: > gcc/cp/ChangeLog: > 2016-02-02 Martin Sebor > > PR c++/69251 > PR c++/69253 > PR c++/69290 > PR c++/69277 > PR c++/69349 > * class.c (walk_subobject_offsets): Avoid testing the upper bound >

  1   2   >