Re: [gomp-nvptx 3/5] nvptx backend: set up stacks in entry code

2016-02-22 Thread Alexander Monakov
On Mon, 22 Feb 2016, Nathan Sidwell wrote: > On 02/22/16 15:25, Alexander Monakov wrote: > > > Template strings have an embedded nul character at the position where ORIG > > goes, so template_2 is set to point at the position following the embedded > > nul > > in template_1. Offset of the

Re: [PATCH] PR28901 Add two levels for -Wunused-const-variable.

2016-02-22 Thread Mark Wielaard
On Mon, 2016-02-22 at 19:20 -0800, H.J. Lu wrote: > It caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69911 Apologies. Apparently main_input_filename can be NULL. I am not entirely sure when that happens. Or how I failed to see that test failure. I think I didn't have java enabled,

Re: [Patch, testsuite] Require int32 target support in sso tests

2016-02-22 Thread Senthil Kumar Selvaraj
Mike Stump writes: > On Feb 22, 2016, at 12:41 AM, Senthil Kumar Selvaraj > wrote: >> Could someone commit it for me please? I don't have commit access. > > Could you test out: > > Index: sso.exp >

RE: [PING PATCH: RL78] Optimize libgcc routines using clrw and clrb

2016-02-22 Thread Kaushik Phatak
Hi Nick, Please let me know if you have had a chance to look at the following patch, https://gcc.gnu.org/ml/gcc-patches/2016-02/msg00415.html Best Regards, Kaushik -Original Message- From: Kaushik Phatak Sent: Friday, February 05, 2016 6:26 PM To: 'gcc-patches@gcc.gnu.org'

Re: [PATCH][RFC][Offloading] Fix PR68463

2016-02-22 Thread Tom de Vries
On 22/02/16 19:07, Ilya Verbin wrote: 2016-02-22 18:13 GMT+03:00 Thomas Schwinge: >On Sat, 20 Feb 2016 13:54:20 +0300, Ilya Verbin wrote: >>On Fri, Feb 19, 2016 at 15:53:08 +0100, Jakub Jelinek wrote: >> >On Wed, Feb 10, 2016 at 08:19:34PM +0300,

[PATCH] Make cstddef / cstdarg more robust (PR 69881)

2016-02-22 Thread Bernd Edlinger
Hi, as described in the PR 69881 it happens quite often that cstddef is called with __need_size_t because we still support gmp-4.3.2 which is installed by contrib/download_prerequisites. This causes a kind of undefined behavior. It is just by chance that this does not cause the gcc-6

Re: [PATCH] PR28901 Add two levels for -Wunused-const-variable.

2016-02-22 Thread H.J. Lu
On Mon, Feb 22, 2016 at 2:43 PM, Mark Wielaard wrote: > On Mon, Feb 22, 2016 at 11:57:56AM -0700, Jeff Law wrote: >> On 02/20/2016 06:42 PM, Mark Wielaard wrote: >> Note that given the discussion in the BZ, I'm going to consider this a >> regression and thus eligible for the

Re: [AArch64] Emit square root using the Newton series

2016-02-22 Thread Evandro Menezes
On 12/10/15 04:30, Kyrill Tkachov wrote: On 09/12/15 18:50, Evandro Menezes wrote: On 12/09/2015 11:16 AM, Kyrill Tkachov wrote: On 09/12/15 17:02, Kyrill Tkachov wrote: On 09/12/15 16:59, Evandro Menezes wrote: On 12/09/2015 10:52 AM, Kyrill Tkachov wrote: Hi Evandro, On 08/12/15

Re: PPC libgcc IEEE128 soft-fp exception/rounding fixes

2016-02-22 Thread David Edelsohn
libgcc * config/rs6000/sfp-machine.h: (_FP_DECL_EX): Declare _fpsr as a union of u64 and double. (FP_TRAPPING_EXCEPTIONS): Return a bitmask of trapping exceptions. (FP_INIT_ROUNDMODE): Read the fpscr instead of writing a mystery value. (FP_ROUNDMODE): Update the usage of _fpscr. Okay. Thanks,

Re: [PATCH] 69759 - document __builtin_alloca and __builtin_alloca_with_align

2016-02-22 Thread Joseph Myers
The documentation in this version is OK with __CHAR_BIT__ changed to CHAR_BIT (there's no need to refer to a macro that's meant only for use in implementing , when a corresponding standard macro exists). -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] PR28901 Add two levels for -Wunused-const-variable.

2016-02-22 Thread Mark Wielaard
On Mon, Feb 22, 2016 at 11:57:56AM -0700, Jeff Law wrote: > On 02/20/2016 06:42 PM, Mark Wielaard wrote: > Note that given the discussion in the BZ, I'm going to consider this a > regression and thus eligible for the trunk. Thanks. Unfortunately new warnings always seem to make some people

[Fortran,4.9/5/6 Regression]ICE for Fortran files when specifying a file instead of an include directory

2016-02-22 Thread Jerry DeLisle
The ice on this one is actually in libcpp but I don't want to mess around in that area. Not sure why we were only doing a warning here. I plan to commit the following to trunk with a ChangeLog entry under the simple and obvious rule. Let me no if any objections. Jerry diff --git

[patch, libgfortran] PR69456 Namelist value with trailing sign is ignored without error

2016-02-22 Thread Jerry DeLisle
Hi all, The problem here is we were treating a bad exponent as if it was a bad read. On bad reads we take a soft error path and go back to see if we are reading a new namelist name. It is done this way because short reads, for example, part of an array, are permitted. To get to the code where

Re: [PATCH] Fix endless recursion in decide_alg (PR target/69888)

2016-02-22 Thread Uros Bizjak
On Mon, Feb 22, 2016 at 10:27 PM, Uros Bizjak wrote: > On Mon, Feb 22, 2016 at 10:16 PM, Jakub Jelinek wrote: >> Hi! >> >> On the following testcase, we ICE due to infinite recursion in decide_alg >> - max is 0, and expected_size is the same (2048) in the

[PATCH] Another -Wnonnull-compare false positive fix (PR c++/69902)

2016-02-22 Thread Jakub Jelinek
Hi! Here is a fix for another -Wnonnull-compare false positive - the problem is that during folding the NE_EXPR of a nonnull_arg_p with NULL (on which the C++ FE set TREE_NO_WARNING, because it is an artificial comparison for dynamic_cast) is changed by fold-const.c into EQ_EXPR, and the

Re: [PATCH] Fix bootstrap on m68k (PR target/69885)

2016-02-22 Thread Jakub Jelinek
On Mon, Feb 22, 2016 at 09:15:29AM -0700, Jeff Law wrote: > Yea, as it's currently written, it's a bit vague. I think your suggesting > of saying that VOIDmode should not be used is what we need. I'll leave the > final word-smithing to you. Here is what I've committed. 2016-02-22 Jakub Jelinek

Re: [PATCH] Fix endless recursion in decide_alg (PR target/69888)

2016-02-22 Thread Uros Bizjak
On Mon, Feb 22, 2016 at 10:16 PM, Jakub Jelinek wrote: > Hi! > > On the following testcase, we ICE due to infinite recursion in decide_alg > - max is 0, and expected_size is the same (2048) in the second and following > recursive calls. > > Fixed by avoiding recursing with the

[PATCH] Fix regcprop noop move handling (PR rtl-optimization/69896)

2016-02-22 Thread Jakub Jelinek
Hi! The following testcase is miscompiled, because prepare_shrink_wrap attempts to copyprop_hardreg_forward_1 the first bb. We see DImode rbx being copied to DImode r11, and then we have (dead since postreload) an assignment of SImode r11d to SImode ebx, and later on some uses of DImode r11.

Re: [Patch, testsuite] Require int32 target support in sso tests

2016-02-22 Thread Mike Stump
On Feb 5, 2016, at 1:03 AM, Eric Botcazou wrote: > You probably need to tweak the regexps again to make it accept the ^M. So, it turned out to the the last line of the file and prune. I’ve fixed it by merely adding an extra line to the end, so that the regexps work as

[PATCH] Note that -Wunreachable-code used to be a warning option (PR c/69900)

2016-02-22 Thread Jakub Jelinek
Hi! While we ignore -Wunreachable-code option now, as we require that GCC diagnostic options are CL_WARNING only, we should remember that this is a former Warning option (similarly for -Werror=). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-02-22 Jakub Jelinek

[PATCH] Fix endless recursion in decide_alg (PR target/69888)

2016-02-22 Thread Jakub Jelinek
Hi! On the following testcase, we ICE due to infinite recursion in decide_alg - max is 0, and expected_size is the same (2048) in the second and following recursive calls. Fixed by avoiding recursing with the same arguments as before. Bootstrapped/regtested on x86_64-linux and i686-linux, ok

Re: [Patch, testsuite] Require int32 target support in sso tests

2016-02-22 Thread Mike Stump
On Feb 22, 2016, at 12:41 AM, Senthil Kumar Selvaraj wrote: > Could someone commit it for me please? I don't have commit access. Could you test out: Index: sso.exp === --- sso.exp (revision

Re: [gomp-nvptx 3/5] nvptx backend: set up stacks in entry code

2016-02-22 Thread Nathan Sidwell
On 02/22/16 15:25, Alexander Monakov wrote: Template strings have an embedded nul character at the position where ORIG goes, so template_2 is set to point at the position following the embedded nul in template_1. Offset of the embedded nul is the same in each template string, so it doesn't

Re: [gomp-nvptx 3/5] nvptx backend: set up stacks in entry code

2016-02-22 Thread Alexander Monakov
On Mon, 22 Feb 2016, Nathan Sidwell wrote: > On 02/15/16 13:44, Alexander Monakov wrote: > > This patch implements the NVPTX backend part of the transition to > > > + static const char template64[] = ENTRY_TEMPLATE ("64", "8", > > "mad.wide.u32"); > > + static const char template32[] =

Re: [PATCH] 69759 - document __builtin_alloca and __builtin_alloca_with_align

2016-02-22 Thread Martin Sebor
On 02/22/2016 10:53 AM, Andreas Schwab wrote: Martin Sebor writes: +@code{__BIGGEST_ALIGNMENT__} macro. @code{__builtin_alloca} returns Another uncapitalized sentence beginning. According to what I've read, whether or not a sentence should start with the name of a code

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Nathan Sidwell
On 02/22/16 14:35, Aaron Conole wrote: D'oh, you're probably right. In my excitement to contribute, I forgot this was shared. I think 'w' should be correct, since this isn't intended to be read at all, but I could be convinced otherwise. sorry, I misremembered the encoding of write append,

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Aaron Conole writes: > Nathan Sidwell writes: > >> On 02/22/16 13:11, Aaron Conole wrote: >>> Nathan Sidwell writes: >>> >>> Hi Nathan, thanks so much for looking at this! >>> On 02/22/16 12:03, Aaron Conole wrote: > The previous

Re: [PATCH] Fix installed plugin headers for aarch64, m68k and c6x (PR target/69894, PR target/69895)

2016-02-22 Thread Jeff Law
On 02/22/2016 12:26 PM, Jakub Jelinek wrote: Hi! Matthias filed to PRs about missing *.def files that are needed by plugins, and my grep found another case (c6x; well, I actually found even the aarch64 issue after seeing the m68k report, then found aarch64 has been already filed). The problem

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Nathan Sidwell writes: > On 02/22/16 13:11, Aaron Conole wrote: >> Nathan Sidwell writes: >> >> Hi Nathan, thanks so much for looking at this! >> >>> On 02/22/16 12:03, Aaron Conole wrote: The previous gcov behavior was to always output errors on the stderr

Re: [PATCH] Fix c_parser_for_statement for ObjC (PR objc/69844)

2016-02-22 Thread Jeff Law
On 02/18/2016 02:39 PM, Jakub Jelinek wrote: Hi! Here is an attempt to fix up the token reclassification after for statement, where we lexed the next token with the declaration from for in scope and need to undo that if it wasn't else. If token->id_kind is C_ID_CLASSNAME (ObjC only), then

[PATCH] Fix installed plugin headers for aarch64, m68k and c6x (PR target/69894, PR target/69895)

2016-02-22 Thread Jakub Jelinek
Hi! Matthias filed to PRs about missing *.def files that are needed by plugins, and my grep found another case (c6x; well, I actually found even the aarch64 issue after seeing the m68k report, then found aarch64 has been already filed). The problem is that the HeaderInclude header includes on

Re: [RFC] Add contrib/fix-ChangeLog.sh

2016-02-22 Thread Trevor Saunders
On Mon, Feb 22, 2016 at 11:05:49AM -0700, Jeff Law wrote: > On 02/20/2016 07:12 AM, Tom de Vries wrote: > >On 20/02/16 15:04, Tom de Vries wrote: > >>Hi, > >> > >>this patch adds a script contrib/fix-ChangeLog.sh. > >> > >>It fixes whitespace issues, and shows ChangeLog lines that look >

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Nathan Sidwell
On 02/22/16 13:11, Aaron Conole wrote: Nathan Sidwell writes: Hi Nathan, thanks so much for looking at this! On 02/22/16 12:03, Aaron Conole wrote: The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs

Re: [PATCH] PR28901 Add two levels for -Wunused-const-variable.

2016-02-22 Thread Jeff Law
On 02/22/2016 12:00 PM, Jakub Jelinek wrote: On Mon, Feb 22, 2016 at 11:57:56AM -0700, Jeff Law wrote: diff --git a/gcc/cgraphunit.c b/gcc/cgraphunit.c index 0a745f0..27a073a 100644 --- a/gcc/cgraphunit.c +++ b/gcc/cgraphunit.c @@ -971,7 +974,7 @@ check_global_declaration (symtab_node *snode)

Re: [PATCH] PR28901 Add two levels for -Wunused-const-variable.

2016-02-22 Thread Jakub Jelinek
On Mon, Feb 22, 2016 at 11:57:56AM -0700, Jeff Law wrote: > >diff --git a/gcc/cgraphunit.c b/gcc/cgraphunit.c > >index 0a745f0..27a073a 100644 > >--- a/gcc/cgraphunit.c > >+++ b/gcc/cgraphunit.c > >@@ -971,7 +974,7 @@ check_global_declaration (symtab_node *snode) > > (TREE_CODE (decl)

Re: [PATCH] PR28901 Add two levels for -Wunused-const-variable.

2016-02-22 Thread Jeff Law
On 02/20/2016 06:42 PM, Mark Wielaard wrote: There is some controversy about enabling -Wunused-const-variable for all unused static const variables because some feel there are too many errors exposed in header files. Create two levels for -Wunused-const-variable. One level to only check for

Re: [PATCH 2/2] PR preprocessor/69126: avoid comparing ad-hoc and non-ad-hoc locations

2016-02-22 Thread Jeff Law
On 02/20/2016 09:46 AM, David Malcolm wrote: Comment #18 of PR preprocessor/69126 reported a difficult-to-reproduce re-occurrence of that bug, where attempts to suppress -Wdeprecated-declarations via a _Pragma could fail. The root cause is a bug in linemap_compare_locations when comparing

Re: Fix PR44281 (bad RA with global regs)

2016-02-22 Thread Michael Matz
Hi, On Mon, 22 Feb 2016, Jeff Law wrote: > > never considers them as candidates. However, we do seem to have proper > > data flow information for them. IMO one of the points of global reg vars, and its long-standing documentation to that effect, is that we do not have proper data flow

Re: [PATCH 1/2] RFC: Add test coverage for _Pragma (PR preprocessor 69126, 69543, 69558)

2016-02-22 Thread Jeff Law
On 02/20/2016 09:46 AM, David Malcolm wrote: We had some regressions in the ability for _Pragma to disable a warning (PR preprocessor/69126, PR preprocessor/69543, PR preprocessor/69558). This patch attempts to add more test coverage for this, for the various combinations of: - various

Re: [JAVA PATCH] Enable more array bounds check elimination

2016-02-22 Thread Jeff Law
On 02/22/2016 11:10 AM, ro...@nextmovesoftware.com wrote: It has been a while since my last contribution. It has been. I ran into some of your eyesopen.com colleagues a couple years back at SC12 or SC13. It'd obviously be great to have you contributing regularly again. Note that we're

[JAVA PATCH] Builtin support for popcount* and bswap* functions

2016-02-22 Thread ro...@nextmovesoftware.com
The following patch provides builtin support for byte swapping and bit counting. On suitable hardware, these generate the x86 popcount instructions, as also generated by the SUN HotSpot JIT/JVM for these method calls. java.lang.Integer.bitCount -> __builtin_popcount java.lang.Long.bitCount ->

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Nathan Sidwell writes: Hi Nathan, thanks so much for looking at this! > On 02/22/16 12:03, Aaron Conole wrote: >> The previous gcov behavior was to always output errors on the stderr channel. >> This is fine for most uses, but some programs will require stderr to be >> silent

[JAVA PATCH] Enable more array bounds check elimination

2016-02-22 Thread ro...@nextmovesoftware.com
It has been a while since my last contribution. The following patch allows GCC's optimizers to more aggressively eliminate and optimize java array bounds checks. The results are quite impressive, for example producing a 26% performance improvement on the sieve.java benchmark given at

Re: [PATCH][RFC][Offloading] Fix PR68463

2016-02-22 Thread Ilya Verbin
2016-02-22 18:13 GMT+03:00 Thomas Schwinge : > On Sat, 20 Feb 2016 13:54:20 +0300, Ilya Verbin wrote: >> On Fri, Feb 19, 2016 at 15:53:08 +0100, Jakub Jelinek wrote: >> > On Wed, Feb 10, 2016 at 08:19:34PM +0300, Ilya Verbin wrote: >> > > This patch

Re: [RFC] Add contrib/fix-ChangeLog.sh

2016-02-22 Thread Jeff Law
On 02/20/2016 07:12 AM, Tom de Vries wrote: On 20/02/16 15:04, Tom de Vries wrote: Hi, this patch adds a script contrib/fix-ChangeLog.sh. It fixes whitespace issues, and shows ChangeLog lines that look suspicious. Using the script, I was able to find a stray changelog entry (removed in

Re: Fix PR44281 (bad RA with global regs)

2016-02-22 Thread Jeff Law
On 02/19/2016 03:03 PM, Bernd Schmidt wrote: In this PR, we generate unnecessarily bad code for code that declares a global register var. Since global regs get added to fixed_regs, IRA never considers them as candidates. However, we do seem to have proper data flow information for them. In the

Re: [PATCH] 69759 - document __builtin_alloca and __builtin_alloca_with_align

2016-02-22 Thread Andreas Schwab
Martin Sebor writes: > +@code{__BIGGEST_ALIGNMENT__} macro. @code{__builtin_alloca} returns Another uncapitalized sentence beginning. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for

Re: [PATCH] 69759 - document __builtin_alloca and __builtin_alloca_with_align

2016-02-22 Thread Jakub Jelinek
On Mon, Feb 22, 2016 at 10:41:32AM -0700, Martin Sebor wrote: > +@deftypefn {Built-in Function} void* __builtin_alloca (size_t size) Just a formatting nit for the documentation, most of extend.texi (and other texi docs), except for a few cases that have slipped through review, the documentation

Re: [PATCH] 69759 - document __builtin_alloca and __builtin_alloca_with_align

2016-02-22 Thread Martin Sebor
On 02/20/2016 01:32 AM, Andreas Schwab wrote: Martin Sebor writes: +in bits (not bytes). @var{size} must be positive and not exceed the stack +size limit. @var{align} must be a constant integer expression that Don't use a lowercase word at the start of a sentence. +The

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Nathan Sidwell
On 02/22/16 12:03, Aaron Conole wrote: The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be silent for certain tests. This change allows configuring the gcov output by an environment variable which

[PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be silent for certain tests. This change allows configuring the gcov output by an environment variable which will be used to open the appropriate file.

Re: [v3, 4.9] Handle C++11 overloads on Solaris 11, 12

2016-02-22 Thread Jakub Jelinek
On Mon, Feb 22, 2016 at 04:39:15PM +, Jonathan Wakely wrote: > On 22/02/16 16:38 +0100, Rainer Orth wrote: > >With the latest Solaris 11.3 SRU, the C++11 overloads have been > >backported to Solaris 11.3. While mainline and the gcc-5 branch already > >cope with this due to > > > >

Re: RFA: Prevent an ICE when redeclaring a static function as weak

2016-02-22 Thread Jeff Law
On 02/22/2016 02:49 AM, Nick Clifton wrote: Hi Jeff, Redefining a previously defined static function as both public and weak triggers an ICE in ipa-visibility.c: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49899 Does this fix a regression? How far back am I allowed to go ? :-)

Re: [v3, 4.9] Handle C++11 overloads on Solaris 11, 12

2016-02-22 Thread Jonathan Wakely
On 22/02/16 16:38 +0100, Rainer Orth wrote: With the latest Solaris 11.3 SRU, the C++11 overloads have been backported to Solaris 11.3. While mainline and the gcc-5 branch already cope with this due to https://gcc.gnu.org/ml/gcc-patches/2015-11/msg02075.html this broke Solaris 11

Re: [RFC] [P2] [PR tree-optimization/33562] Lowering more complex assignments.

2016-02-22 Thread Jeff Law
On 02/22/2016 07:32 AM, Richard Biener wrote: Presumably DOM is not looking at r = s.r and realizing it could look s.r piece-wise in the available expression table. If it did, it would effectively turn that fragment into: s = { {1, 2}, 3 }; s.r.x = 1; s.r.y = 2; struct R r

Re: openacc reference reductions

2016-02-22 Thread Nathan Sidwell
On 02/22/16 10:34, Cesar Philippidis wrote: Ping. This patch still needs a review. I'm not sure who has the approval ball. Jakub? nathan

Re: [openacc] vector state propagation

2016-02-22 Thread Nathan Sidwell
On 02/22/16 10:30, Cesar Philippidis wrote: This patch teaches the nvptx vector state propagator how to handle QImode and HImode variables. Basically, I'm converting the 8- and 16-bit values into 32-bits so that the shuffle broadcast can be used to propagate the register. I'm not sure if my

Re: [gomp-nvptx 3/5] nvptx backend: set up stacks in entry code

2016-02-22 Thread Nathan Sidwell
On 02/15/16 13:44, Alexander Monakov wrote: This patch implements the NVPTX backend part of the transition to + static const char template64[] = ENTRY_TEMPLATE ("64", "8", "mad.wide.u32"); + static const char template32[] = ENTRY_TEMPLATE ("32", "4", "mad.lo.u32 "); +#undef ENTRY_TEMPLATE

Re: [PATCH] Fix bootstrap on m68k (PR target/69885)

2016-02-22 Thread Jeff Law
On 02/22/2016 07:28 AM, Jakub Jelinek wrote: On Mon, Feb 22, 2016 at 07:09:41AM -0700, Jeff Law wrote: On 02/22/2016 06:08 AM, Jakub Jelinek wrote: Hi! Supposedly my recent invalid shift count expansion changes broke m68k bootstrap, we now really require that the shift expanders have some

Re: [PATCH] Add configure flag for operator new (std::nothrow)

2016-02-22 Thread Jonathan Wakely
On 19/02/16 18:56 -0300, Daniel Gutson wrote: On Mon, Nov 16, 2015 at 3:56 PM, Pedro Alves wrote: On 11/10/2015 01:10 PM, Jonathan Wakely wrote: On 06/11/15 09:59 +, Pedro Alves wrote: On 11/06/2015 01:56 AM, Jonathan Wakely wrote: On 5 November 2015 at 23:31, Daniel

[v3, 4.9] Handle C++11 overloads on Solaris 11, 12

2016-02-22 Thread Rainer Orth
With the latest Solaris 11.3 SRU, the C++11 overloads have been backported to Solaris 11.3. While mainline and the gcc-5 branch already cope with this due to https://gcc.gnu.org/ml/gcc-patches/2015-11/msg02075.html this broke Solaris 11 bootstrap on the 4.9 branch. Therefore I'd like

Re: [openacc] reference-typed data mappings

2016-02-22 Thread Cesar Philippidis
Ping. Cesar On 02/09/2016 09:05 AM, Cesar Philippidis wrote: > On 02/09/2016 07:00 AM, Cesar Philippidis wrote: >> On 02/01/2016 09:57 AM, Cesar Philippidis wrote: >> This patch fixes a couple of bugs preventing c++ reference-typed variables from working in openacc data clauses. These

Re: openacc reference reductions

2016-02-22 Thread Cesar Philippidis
Ping. This patch still needs a review. Cesar On 02/09/2016 08:17 AM, Cesar Philippidis wrote: > On 02/09/2016 07:33 AM, Nathan Sidwell wrote: >> While I've not looked at the rest of the patch, this bit stood out: >> >>> +static bool >>> +is_oacc_parallel_reduction (tree var, omp_context *ctx)

Re: Fix/work around PR57676, LRA terminates prematurely

2016-02-22 Thread Jeff Law
On 02/22/2016 07:34 AM, Richard Biener wrote: Hum, but then you get to "inifinite" compiles again when LRA is buggy or the user presents it with an impossible to handle asm. Neither should be happening in practice, even an impossible asm should cause LRA to halt in some way or another. In

[openacc] vector state propagation

2016-02-22 Thread Cesar Philippidis
This patch teaches the nvptx vector state propagator how to handle QImode and HImode variables. Basically, I'm converting the 8- and 16-bit values into 32-bits so that the shuffle broadcast can be used to propagate the register. I'm not sure if my solution is the best way to resolve this problem.

Re: [PATCH][RFC][Offloading] Fix PR68463

2016-02-22 Thread Thomas Schwinge
Hi! On Sat, 20 Feb 2016 13:54:20 +0300, Ilya Verbin wrote: > On Fri, Feb 19, 2016 at 15:53:08 +0100, Jakub Jelinek wrote: > > On Wed, Feb 10, 2016 at 08:19:34PM +0300, Ilya Verbin wrote: > > > This patch adds crtoffload{begin,end}.o to all -fopenmp programs, if they > > >

Re: [PATCH 1/2][AArch64] Implement AAPCS64 updates for alignment attribute

2016-02-22 Thread Alan Lawrence
On 22/01/16 17:16, Alan Lawrence wrote: On 21/01/16 17:23, Alan Lawrence wrote: On 18/01/16 17:10, Eric Botcazou wrote: Could you post the list of files that differ? How do they differ exactly? Hmmm. Well, I definitely had this failing to bootstrap once. I repeated that, to try to

Re: Fix PR44281 (bad RA with global regs)

2016-02-22 Thread Richard Biener
On Fri, Feb 19, 2016 at 11:03 PM, Bernd Schmidt wrote: > In this PR, we generate unnecessarily bad code for code that declares a > global register var. Since global regs get added to fixed_regs, IRA never > considers them as candidates. However, we do seem to have proper data

Re: [PATCH] Fix bootstrap on m68k (PR target/69885)

2016-02-22 Thread Andreas Schwab
Jakub Jelinek writes: > Would you like to somehow stress that operand 2's mode must be specified > in the instruction pattern or expander? As it says that the compiler will > convert it to that mode, I'd kind of say that VOIDmode should not be used > there. Perhaps a warning

Re: Fix/work around PR57676, LRA terminates prematurely

2016-02-22 Thread Richard Biener
On Fri, Feb 19, 2016 at 10:34 PM, Jeff Law wrote: > On 02/19/2016 02:32 PM, Bernd Schmidt wrote: >> >> The testcase in this PR causes gcc to abort with >> >> internal compiler error: Maximum number of LRA constraint passes is >> achieved (30) >> >> [in theory - I've not managed

Re: [RFC] [P2] [PR tree-optimization/33562] Lowering more complex assignments.

2016-02-22 Thread Richard Biener
On Fri, Feb 19, 2016 at 10:01 PM, Jeff Law wrote: > On 02/18/2016 02:56 AM, Richard Biener wrote: Just a short quick comment - the above means you only handle partial stores with no interveaning uses. You don't handle, say struct S { struct R { int

Re: [PATCH] Fix bootstrap on m68k (PR target/69885)

2016-02-22 Thread Jakub Jelinek
On Mon, Feb 22, 2016 at 07:09:41AM -0700, Jeff Law wrote: > On 02/22/2016 06:08 AM, Jakub Jelinek wrote: > >Hi! > > > >Supposedly my recent invalid shift count expansion changes broke > >m68k bootstrap, we now really require that the shift expanders > >have some non-VOIDmode, so that we can

[PATCH, HSA] Fix emission of clrsb{l,ll} builtins

2016-02-22 Thread Martin Liška
Hello. Following patch correctly handles builtins mentioned in the email subject in order to return correct value for 0 as the argument. The patch can boostrap on x86_64-linux-gnu and survives regression tests and is pre-approved by Martin Jambor. Moreover, I'm preparing a test-case that will

Re: [PATCH] Fix bootstrap on m68k (PR target/69885)

2016-02-22 Thread Jeff Law
On 02/22/2016 06:08 AM, Jakub Jelinek wrote: Hi! Supposedly my recent invalid shift count expansion changes broke m68k bootstrap, we now really require that the shift expanders have some non-VOIDmode, so that we can convert_mode it to that mode. But m68k didn't specify mode. For valid shift

Re: [ping] Enable -mstackrealign with SSE on 32-bit Windows

2016-02-22 Thread Richard Biener
On Fri, Feb 19, 2016 at 7:50 PM, Eric Botcazou wrote: >> Not sure - why doesn't mingw properly specify the default incoming >> stack boundary? >> If it does, why isn't there an issue elsewhere even on non-mingw if you use >> -mincoming-stack-boundary=2? > > Wouldn't that

Re: [PATCH GCC]Obvious change, dump min_profitable_estimate, rather than min_profitable_iters

2016-02-22 Thread Richard Biener
On Mon, Feb 22, 2016 at 12:10 PM, Bin Cheng wrote: > Hi, > This is an obvious change to vect_estimate_min_profitable_iters. Given the > context, it should dump min_profitable_estimate at patch site, rather than > min_profitable_iters. Or I must mis-understood something in

Re: [PATCH] Add testcase for PR61033

2016-02-22 Thread Richard Biener
On Sat, Feb 20, 2016 at 6:01 PM, Maxim Kuvyrkov wrote: > This patch adds a testcase for PR61033 [1]. > > The bug is about compiler going into infinite loop while solving data-flow in > vt_find_locations on arm-* targets. The issue in fixed in GCC 5 and later by >

[SH][committed] Fix PR 69806

2016-02-22 Thread Oleg Endo
Hi, The attached patch fixes PR 69806. Tested on sh-elf with make -k check RUNTESTFLAGS="--target_board=sh-sim\{-m2/-ml,-m2/-mb, -m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" Committed as r233601. Cheers, Oleg gcc/ChangeLog PR target/69806 PR target/54089 *

Re: better debug info for C++ cdtors, aliases, thunks and other trampolines

2016-02-22 Thread Richard Biener
On Sat, Feb 20, 2016 at 3:19 AM, Alexandre Oliva wrote: > Keith Seitz reported we were missing debug information for cdtors. > E.g., we emit a specification for the unified ctor and dtor, but then, > if we emit one of the in-charge and not-in-charge versions as an alias > to

[PATCH] Fix bootstrap on m68k (PR target/69885)

2016-02-22 Thread Jakub Jelinek
Hi! Supposedly my recent invalid shift count expansion changes broke m68k bootstrap, we now really require that the shift expanders have some non-VOIDmode, so that we can convert_mode it to that mode. But m68k didn't specify mode. For valid shift counts the patch makes no difference beyond

Re: [PATCH] Fix PR56888

2016-02-22 Thread Richard Biener
On Mon, 22 Feb 2016, Richard Biener wrote: > On Mon, 22 Feb 2016, Jakub Jelinek wrote: > > > On Mon, Feb 22, 2016 at 01:44:09PM +0100, Richard Biener wrote: > > > --- 1079,1086 > > > || !dominated_by_p (CDI_DOMINATORS, > > > loop->latch, gimple_bb

Re: [PATCH] Fix PR56888

2016-02-22 Thread Richard Biener
On Mon, 22 Feb 2016, Jakub Jelinek wrote: > On Mon, Feb 22, 2016 at 01:44:09PM +0100, Richard Biener wrote: > > --- 1079,1086 > > || !dominated_by_p (CDI_DOMINATORS, > > loop->latch, gimple_bb (stmt))) > > return; > > + if (cgraph_node::get

Re: [PATCH] Fix PR56888

2016-02-22 Thread Jakub Jelinek
On Mon, Feb 22, 2016 at 01:44:09PM +0100, Richard Biener wrote: > --- 1079,1086 > || !dominated_by_p (CDI_DOMINATORS, > loop->latch, gimple_bb (stmt))) > return; > + if (cgraph_node::get (cfun->decl)->aliases (BUILT_IN_MEMSET)) > + return;

[PATCH] Fix PR68963

2016-02-22 Thread Richard Biener
The following patch fixes invalid upper bounds recorded for conditonal array accesses - it doesn't depend on whether their IV wrap or not (and we were unsetting 'reliable' only anyway). In fact conditional accesses should be good enough for an estimate, just wrapping ones not. Until we

[PATCH] Fix PR69882

2016-02-22 Thread Richard Biener
The following fixes an oversight in SLP reduction permutation optimization which will happily delete permutations required for handling of gaps. Bootstrapped on x86_64-unknown-linux-gnu, testin in progress. Richard. 2016-02-22 Richard Biener PR

[PATCH] Fix PR56888

2016-02-22 Thread Richard Biener
The following fixes us to not transform loops into memcpy or memset or not transform malloc + memset into calloc if we implement that functionality itself (and thus we "alias" the symbol we'd call when emitting a call to the builtin). Bootstrap and regtest pending on x86_64-unknown-linux-gnu.

Re: [PATCH] Add -funknown-commons to work around PR/69368 (and others) in SPEC2006

2016-02-22 Thread Jakub Jelinek
On Mon, Feb 22, 2016 at 11:46:19AM +, Alan Lawrence wrote: > On 19/02/16 17:52, Jakub Jelinek wrote: > >On Fri, Feb 19, 2016 at 05:42:34PM +, Alan Lawrence wrote: > >>This relates to FORTRAN code where different modules give different sizes > >>to the > >>same array in a COMMON block

Re: [PING 2, PATCH] PR/68089: C++-11: Ingore "alignas(0)".

2016-02-22 Thread Dominik Vogt
On Mon, Jan 04, 2016 at 12:33:21PM +0100, Dominik Vogt wrote: > On Fri, Jan 01, 2016 at 05:53:08PM -0700, Martin Sebor wrote: > > On 12/31/2015 04:50 AM, Dominik Vogt wrote: > > >The attached patch fixes C++-11 handling of "alignas(0)" which > > >should be ignored but currently generates an error

Re: [PING 2, PATCH] S/390: Reduce accuracy of bessel_6.f90.

2016-02-22 Thread Dominik Vogt
On Mon, Jan 11, 2016 at 03:40:56PM +0100, Dominik Vogt wrote: > Another patch reducing the accuracy required in the bessel_6 test. > gcc/testsuite/ChangeLog > > * gfortran.dg/bessel_6.f90: Reduce accuracy for S/390. > >From 70a35dd6f6bf906d8e5907667ad0f04f981a61ac Mon Sep 17 00:00:00 2001

Re: [PING, PATCH] libitm: Introduce target macro TARGET_BEGIN_TRANSACTION_ATTRIBUTE.

2016-02-22 Thread Dominik Vogt
On Mon, Feb 01, 2016 at 02:18:48PM +0100, Dominik Vogt wrote: > The attached patch adds the a target specific attribute via the > new target macro TARGET_BEGIN_TRANSACTION_ATTRIBUTE to the > function begin_transaction(). S/390 uses this to set the > soft-float target attribute which is needed to

Re: [PATCH] Add -funknown-commons to work around PR/69368 (and others) in SPEC2006

2016-02-22 Thread Alan Lawrence
On 19/02/16 17:52, Jakub Jelinek wrote: On Fri, Feb 19, 2016 at 05:42:34PM +, Alan Lawrence wrote: This relates to FORTRAN code where different modules give different sizes to the same array in a COMMON block (contrary to the fortran language specification). SPEC have refused to patch the

[PATCH GCC]Obvious change, dump min_profitable_estimate, rather than min_profitable_iters

2016-02-22 Thread Bin Cheng
Hi, This is an obvious change to vect_estimate_min_profitable_iters. Given the context, it should dump min_profitable_estimate at patch site, rather than min_profitable_iters. Or I must mis-understood something in the code. Build successfully, no test needed. Is it OK? I am not sure obvious

Re: [PATCH][RFC][Offloading] Fix PR68463

2016-02-22 Thread Jakub Jelinek
On Sat, Feb 20, 2016 at 01:54:20PM +0300, Ilya Verbin wrote: > gcc/ > PR driver/68463 > * config/gnu-user.h (GNU_USER_TARGET_STARTFILE_SPEC): Add > crtoffloadbegin.o for -fopenacc/-fopenmp if it exists. > (GNU_USER_TARGET_ENDFILE_SPEC): Add crtoffloadend.o for >

Re: [PING^3][PATCH, 12/16] Handle acc loop directive

2016-02-22 Thread Jakub Jelinek
On Mon, Feb 22, 2016 at 11:54:46AM +0100, Tom de Vries wrote: > Following up on your suggestion to implement this during gimplification, I > wrote attached patch. > > I'll put it through some openacc testing and add testcases. Is this approach > acceptable for stage4? LGTM. > gcc/gimplify.c |

Re: [PING^3][PATCH, 12/16] Handle acc loop directive

2016-02-22 Thread Tom de Vries
On 12/02/16 12:10, Tom de Vries wrote: On 26/01/16 13:49, Jakub Jelinek wrote: On Tue, Jan 26, 2016 at 01:38:39PM +0100, Tom de Vries wrote: Ping^3. ( https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01089.html ) First of all, I wonder if it wouldn't be far easier to handle these during

Re: RFA: Prevent an ICE when redeclaring a static function as weak

2016-02-22 Thread Nick Clifton
Hi Jeff, >>Redefining a previously defined static function as both public and >>weak triggers an ICE in ipa-visibility.c: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49899 > Does this fix a regression? How far back am I allowed to go ? :-) The bug as reported in the PR existed

Re: [PATCH] Fix PR37448 (and dups?)

2016-02-22 Thread Richard Biener
On Fri, 19 Feb 2016, Jan Hubicka wrote: > > > > > > Are you sure? I thought we compute that up-front ... at least > > > we make sure we can_inline_edge_p all calls before even trying > > > to inline all calls - that looks somewhat redundant then if it > > > can happen that we give up anyway.

Re: [PATCH PR69052]Check if loop inv can be propagated into mem ref with additional addr expr canonicalization

2016-02-22 Thread Bin.Cheng
On Fri, Feb 19, 2016 at 10:24 PM, Jeff Law wrote: > On 02/16/2016 11:43 AM, Bin Cheng wrote: >> >> >> From: Jeff Law >> Sent: 11 February 2016 23:26 >> To: Bin.Cheng >> Cc: Bin Cheng; gcc-patches@gcc.gnu.org; nd >>

Re: [Patch, testsuite] Require int32 target support in sso tests

2016-02-22 Thread Senthil Kumar Selvaraj
Mike Stump okayed the patch (https://gcc.gnu.org/ml/gcc-patches/2016-02/msg00321.html). Could someone commit it for me please? I don't have commit access. Regards Senthil Senthil Kumar Selvaraj writes: > Hi, > > When running the regression testsuite for the AVR target, I noticed a > bunch