Re: [PATCH] PR47040 - Make error message for empty array constructor more helpful/correct

2016-04-06 Thread Dominique d'Humières
Could you please elaborate. Dominique > Le 7 avr. 2016 à 07:48, Steve Kargl a > écrit : > > On Wed, Apr 06, 2016 at 05:44:55PM +0200, Dominique d'Humières wrote: >> Is the following patch OK (regtested on x86_64-apple-darwin15)? Should it be >> back ported

Re: [PATCH] PR47040 - Make error message for empty array constructor more helpful/correct

2016-04-06 Thread Steve Kargl
On Wed, Apr 06, 2016 at 05:44:55PM +0200, Dominique d'Humières wrote: > Is the following patch OK (regtested on x86_64-apple-darwin15)? Should it be > back ported to the gcc-5 branch? No and No. -- Steve

Re: [PATCH] Avoid needless unsharing during constexpr evaluation (PR c++/70452)

2016-04-06 Thread Patrick Palka
On Wed, 6 Apr 2016, Patrick Palka wrote: > On Wed, Apr 6, 2016 at 1:17 PM, Richard Biener > wrote: > > On April 6, 2016 6:51:40 PM GMT+02:00, Patrick Palka > > wrote: > >>During constexpr evaluation we unconditionally call unshare_expr in a >

Re: openacc reference reductions

2016-04-06 Thread Cesar Philippidis
here? That's a good idea. I went ahead and combined this patch with the data map reduction fix for PR70289 that I posted on Monday, <https://gcc.gnu.org/ml/gcc-patches/2016-04/msg00202.html>, because I'm already scanning for parallel reduction data clauses in there. As you suggeste

Re: [PATCH, i386] Add some missing modes to mode attributes

2016-04-06 Thread Uros Bizjak
On Wed, Apr 6, 2016 at 5:55 PM, H.J. Lu wrote: > On Wed, Apr 6, 2016 at 8:11 AM, Uros Bizjak wrote: >> ... so there is no unresolved attributes in insn-output.c. >> >> 2016-04-06 Uros Bizjak >> >> * config/i386/sse.md

Re: [PATCH: RL78] Optimize libgcc routines using clrw and clrb

2016-04-06 Thread DJ Delorie
Kaushik Phatak writes: > 2016-04-06 Kaushik Phatak > > * config/rl78/bit-count.S: Use clrw/clrb where possible. > * config/rl78/cmpsi2.S: Likewise. > * config/rl78/divmodhi.S Likewise. > * config/rl78/divmodsi.S

Re: [PATCH] Avoid needless unsharing during constexpr evaluation (PR c++/70452)

2016-04-06 Thread Patrick Palka
On Wed, Apr 6, 2016 at 1:17 PM, Richard Biener wrote: > On April 6, 2016 6:51:40 PM GMT+02:00, Patrick Palka > wrote: >>During constexpr evaluation we unconditionally call unshare_expr in a >>bunch of places to ensure that CONSTRUCTORs (and

Re: [PATCH] Avoid needless unsharing during constexpr evaluation (PR c++/70452)

2016-04-06 Thread Richard Biener
On April 6, 2016 6:51:40 PM GMT+02:00, Patrick Palka wrote: >During constexpr evaluation we unconditionally call unshare_expr in a >bunch of places to ensure that CONSTRUCTORs (and their >CONSTRUCTOR_ELTS) >don't get shared. But as far as I can tell, we don't have any

patch for PR70398

2016-04-06 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70398 The patch was successfully tested and bootstrapped on x86_64 and aarch64. Committed as rev. 234792 Index: ChangeLog === --- ChangeLog (revision

[PATCH] Avoid needless unsharing during constexpr evaluation (PR c++/70452)

2016-04-06 Thread Patrick Palka
During constexpr evaluation we unconditionally call unshare_expr in a bunch of places to ensure that CONSTRUCTORs (and their CONSTRUCTOR_ELTS) don't get shared. But as far as I can tell, we don't have any reason to call unshare_expr on non-CONSTRUCTORs, and a CONSTRUCTOR will never be an operand

C++ PATCH for implicit abi_tag on template member function

2016-04-06 Thread Jason Merrill
We were incorrectly omitting the ABI tag on the instantiation of this member function because we were setting the tags on the instantiation and looking for them on the temploid. Tested x86_64-pc-linux-gnu, applying to trunk. commit 32a5b18940f37dd97c2735f24a8353d1db457d86 Author: Jason Merrill

Re: [PATCH, i386] Add some missing modes to mode attributes

2016-04-06 Thread H.J. Lu
On Wed, Apr 6, 2016 at 8:11 AM, Uros Bizjak wrote: > ... so there is no unresolved attributes in insn-output.c. > > 2016-04-06 Uros Bizjak > > * config/i386/sse.md (shuffletype): Add V32HI and V4TI modes. > (ssescalarsize): Add V8SF, V4SF, V4DF and

[PATCH] PR47040 - Make error message for empty array constructor more helpful/correct

2016-04-06 Thread Dominique d'Humières
Is the following patch OK (regtested on x86_64-apple-darwin15)? Should it be back ported to the gcc-5 branch? TIA Dominique Index: gcc/fortran/ChangeLog === --- gcc/fortran/ChangeLog (revision 234788) +++

Re: [Patch] Avoid deadlock in guality tests.

2016-04-06 Thread Yvan Roux
On 6 April 2016 at 17:24, Pedro Alves wrote: > On 04/06/2016 04:13 PM, Yvan Roux wrote: >> On 6 April 2016 at 17:09, Pedro Alves wrote: >>> On 04/06/2016 03:53 PM, Yvan Roux wrote: Dejagnu cleanup mechanism needs to be enhanced, but I think that it

[testsuite] Skip gcc.c-torture/execute/20101011-1.c on Visium

2016-04-06 Thread Eric Botcazou
I don't understand how this one slipped through the cracks last year, but the test needs to be disabled on Visium as on a bunch of other architectures. Tested on visium-elf, applied on the mainline and 5 branch. 2016-04-06 Eric Botcazou *

Re: [Patch] Avoid deadlock in guality tests.

2016-04-06 Thread Pedro Alves
On 04/06/2016 04:13 PM, Yvan Roux wrote: > On 6 April 2016 at 17:09, Pedro Alves wrote: >> On 04/06/2016 03:53 PM, Yvan Roux wrote: >>> Dejagnu cleanup mechanism needs to be enhanced, but I think that it >>> would also be better if guality tests don't get stuck and/or can be

Re: [Patch] Avoid deadlock in guality tests.

2016-04-06 Thread Yvan Roux
On 6 April 2016 at 17:09, Pedro Alves wrote: > On 04/06/2016 03:53 PM, Yvan Roux wrote: >> Dejagnu cleanup mechanism needs to be enhanced, but I think that it >> would also be better if guality tests don't get stuck and/or can be >> killed easily. This patch changes GDB

[PATCH, i386] Add some missing modes to mode attributes

2016-04-06 Thread Uros Bizjak
... so there is no unresolved attributes in insn-output.c. 2016-04-06 Uros Bizjak * config/i386/sse.md (shuffletype): Add V32HI and V4TI modes. (ssescalarsize): Add V8SF, V4SF, V4DF and V2DF modes. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.

Re: [patch] Remove superfluous /dev/null on grep line

2016-04-06 Thread Eric Botcazou
> OK, I have no objection to the original patch then. Thanks, applied. FWIW I verified that the library still builds after the change with an empty port_specific_symbol_files variable. -- Eric Botcazou

Re: [C++ PATCH] PR 70501, ICE in verify ctor sanity

2016-04-06 Thread Nathan Sidwell
On 04/06/16 07:49, Jason Merrill wrote: On 04/05/2016 05:21 PM, Nathan Sidwell wrote: On 04/05/16 12:40, Jason Merrill wrote: It's not clear to me that we really need a TARGET_EXPR for vector values. Since one element of a vector can't refer to another, we don't need the ctx->ctor handling.

Re: [Patch] Avoid deadlock in guality tests.

2016-04-06 Thread Jakub Jelinek
On Wed, Apr 06, 2016 at 04:53:47PM +0200, Yvan Roux wrote: > 2016-04-06 Yvan Roux > Pedro Alves > > * gcc.dg/guality/guality.h (main): Avoid GDB being blocked on signals. Ok. > diff --git a/gcc/testsuite/gcc.dg/guality/guality.h

[Patch] Avoid deadlock in guality tests.

2016-04-06 Thread Yvan Roux
Hi, we are confronted to a deadlock situation when doing native validation on armv8l target. When gcc/testsuite/gcc.dg/guality/example.c is executed it spawns gdb, and makes it attach to his parent, but during the test execution, gdb receives a SIGSEGV, which is handled as a stop signal. Then

Re: [C++ PATCH] PR 70501, ICE in verify ctor sanity

2016-04-06 Thread Jason Merrill
On 04/05/2016 05:21 PM, Nathan Sidwell wrote: On 04/05/16 12:40, Jason Merrill wrote: It's not clear to me that we really need a TARGET_EXPR for vector values. Since one element of a vector can't refer to another, we don't need the ctx->ctor handling. Perhaps we should handle vectors like we

Re: [PATCH, cpp] Fix pr61817 and 69391

2016-04-06 Thread Jakub Jelinek
On Tue, Apr 05, 2016 at 09:22:37AM -0700, Richard Henderson wrote: > These two related PRs are all about remembering where a macro is expanded. > Worse, we've got two competing goals -- the real location of the expansion, > for __LINE__, and the virtual location of the expansion, for diagnostics.

Re: [PATCH 2/2] Fix C++ side of PR c/70436 (missing -Wparentheses warnings)

2016-04-06 Thread Jason Merrill
OK. Jason

Re: openacc reference reductions

2016-04-06 Thread Jakub Jelinek
On Tue, Apr 05, 2016 at 06:53:47PM -0700, Cesar Philippidis wrote: > --- a/gcc/omp-low.c > +++ b/gcc/omp-low.c > @@ -309,6 +309,25 @@ is_oacc_kernels (omp_context *ctx) > == GF_OMP_TARGET_KIND_OACC_KERNELS)); > } > > +/* Return true if CTX corresponds to an oacc parallel region and

Re: Add some C++17 items to gcc-6/changes.html

2016-04-06 Thread Jason Merrill
On 04/04/2016 06:22 AM, Jonathan Wakely wrote: I plan to commit this to wwwdocs CVS. Have I missed anything that should be listed? I'd mention that TM requires the -fgnu-tm flag. Jason

[committed] OpenMP declare simd ABI changes on x86_64/i686

2016-04-06 Thread Jakub Jelinek
Hi! As we already have some declare simd ABI changes in GCC 6 (mangling of the various linear clause kinds), and as glibc uses the AVX512F stuff in, I've decided to commit following ABI changes right now rather than waiting for GCC 7. The changes are: 1) for AVX2, functions with {{un,}signed

Re: [PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Alan Modra
On Wed, Apr 06, 2016 at 12:27:36PM +0200, Andreas Schwab wrote: > Alan Modra writes: > > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr70117.c > > b/gcc/testsuite/gcc.target/powerpc/pr70117.c > > new file mode 100644 > > index 000..99e6f19 > > --- /dev/null > > +++

Re: [PATCH, testsuite/ARM] Skip pr70496.c for cortex-m devices

2016-04-06 Thread Ramana Radhakrishnan
On Wed, Apr 6, 2016 at 12:03 PM, Thomas Preudhomme wrote: > Hi, > > Testcase in gcc.target/arm/pr70496.c uses an .arm directive so assumes the > target has an ARM execution state. This patch adds a dg-skip-if directive to > skip that test on Cortex-M targets since

Compile libcilkrts with -funwind-tables (PR target/60290)

2016-04-06 Thread Rainer Orth
I've finally gotten around to analyzing this testsuite failure on 32-bit Solaris/x86: FAIL: g++.dg/cilk-plus/CK/catch_exc.cc -O1 -fcilkplus execution test FAIL: g++.dg/cilk-plus/CK/catch_exc.cc -O3 -fcilkplus execution test FAIL: g++.dg/cilk-plus/CK/catch_exc.cc -g -O2 -fcilkplus execution

Re: [PATCH, testsuite/ARM] Skip pr70496.c for cortex-m devices

2016-04-06 Thread Kyrill Tkachov
Hi Thomas, On 06/04/16 12:03, Thomas Preudhomme wrote: Hi, Testcase in gcc.target/arm/pr70496.c uses an .arm directive so assumes the target has an ARM execution state. This patch adds a dg-skip-if directive to skip that test on Cortex-M targets since they don't have such an execution state.

[PATCH, testsuite/ARM] Skip pr70496.c for cortex-m devices

2016-04-06 Thread Thomas Preudhomme
Hi, Testcase in gcc.target/arm/pr70496.c uses an .arm directive so assumes the target has an ARM execution state. This patch adds a dg-skip-if directive to skip that test on Cortex-M targets since they don't have such an execution state. ChangeLog entry is as follows: ***

Unreviewed patch

2016-04-06 Thread Rainer Orth
The following patch has remainded unreviewed for a week: [testsuite, sparcv9] Fix gcc.dg/ifcvt-4.c on 64-bit SPARC (PR rtl-optimization/68749) https://gcc.gnu.org/ml/gcc-patches/2016-03/msg01631.html Although it's testsuite-only, I'm quite reluctant to make potential semantic

Re: PATCH] Fix PR 31531: A microoptimization of isnegative of signed integer

2016-04-06 Thread Richard Biener
On Tue, Feb 16, 2016 at 5:50 AM, Hurugalawadi, Naveen wrote: > Hi, > >>> I'm also failing to see why you can't enhance the existing > > Please find attached the patch that enhances the existing pattern. > Please review the patch and let me know if any

Re: [PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Andreas Schwab
Alan Modra writes: > diff --git a/gcc/testsuite/gcc.target/powerpc/pr70117.c > b/gcc/testsuite/gcc.target/powerpc/pr70117.c > new file mode 100644 > index 000..99e6f19 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/pr70117.c > @@ -0,0 +1,22 @@ > +/* { dg-do run {

[Patch AArch64 3/3] Fix up for pr70133

2016-04-06 Thread James Greenhalgh
Hi, Having updated the way we parse and output extension strings, now we just need to wire up the native detection to use these new features. In doing some cleanup and rename I ended up fixing 8-spaces to tabs in about half the file. I've done the rest while I'm here to save us from some a

[Patch AArch64 2/3] Rework the code to print extension strings (pr70133)

2016-04-06 Thread James Greenhalgh
Hi, This patch aims to ensure that when we say: -march=armv8-a+nosimd We communicate that to the assembler in a way it understands. On trunk, we'll put out a directive that says .march armv8-a+fp Which has two issues; it is not enough to disable the simd extensions, and it adds a +fp

[Patch AArch64 0/3] Fix PR70133

2016-04-06 Thread James Greenhalgh
Hi, This patch set fixes PR70133, which is a bug in the way we handle extension strings after using -march or -mcpu=native. In investigating this, I found other bugs in the way we communicate architceture intention between the compiler and the assembler. This patch set cleans this up somewhat.

[Patch AArch64 1/3] Enable CRC by default for armv8.1-a

2016-04-06 Thread James Greenhalgh
Hi, This change reflects binutils support for CRC, where it is always enabled for armv8.1-a. OK? Thanks, James --- 2016-04-06 James Greenhalgh * config/aarch64/aarch64.h (AARCH64_FL_FOR_ARCH8_1): Also add AARCH64_FL_CRC. diff --git

Re: [PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Alan Modra
On Wed, Apr 06, 2016 at 10:46:48AM +0200, Richard Biener wrote: > On Wed, Apr 6, 2016 at 10:31 AM, Alan Modra wrote: > > On Tue, Apr 05, 2016 at 11:29:30AM +0200, Richard Biener wrote: > >> In general the patch looks like a good approach to me but can we > >> hide that > >> > >>

Re: [patch] Remove superfluous /dev/null on grep line

2016-04-06 Thread Jakub Jelinek
On Wed, Apr 06, 2016 at 10:12:18AM +0100, Jonathan Wakely wrote: > >As it is a make variable, can't make be used to test this? > >So perhaps > > chmod +w $@.tmp > >ifneq ($(port_specific_symbol_files),) > > if grep '^# Appended to version file.' \ > >

Re: [patch] Remove superfluous /dev/null on grep line

2016-04-06 Thread Jonathan Wakely
On 06/04/16 11:01 +0200, Jakub Jelinek wrote: On Wed, Apr 06, 2016 at 09:50:48AM +0100, Jonathan Wakely wrote: On 06/04/16 09:39 +0200, Eric Botcazou wrote: >we recently ran into build failures on Windows systems using a somewhat old >grep, coming from a syntax error in the

Re: [RFC] introduce --param max-lto-partition for having an upper bound on partition size

2016-04-06 Thread Richard Biener
On Wed, 6 Apr 2016, Prathamesh Kulkarni wrote: > On 6 April 2016 at 13:44, Richard Biener wrote: > > On Wed, 6 Apr 2016, Prathamesh Kulkarni wrote: > > > >> On 5 April 2016 at 18:28, Richard Biener wrote: > >> > On Tue, 5 Apr 2016, Prathamesh Kulkarni

Re: [patch] Remove superfluous /dev/null on grep line

2016-04-06 Thread Jakub Jelinek
On Wed, Apr 06, 2016 at 09:50:48AM +0100, Jonathan Wakely wrote: > On 06/04/16 09:39 +0200, Eric Botcazou wrote: > >we recently ran into build failures on Windows systems using a somewhat old > >grep, coming from a syntax error in the libstdc++-symbols.ver version file: > > > ># Symbol versioning

Re: [RFC] introduce --param max-lto-partition for having an upper bound on partition size

2016-04-06 Thread Prathamesh Kulkarni
On 6 April 2016 at 13:44, Richard Biener wrote: > On Wed, 6 Apr 2016, Prathamesh Kulkarni wrote: > >> On 5 April 2016 at 18:28, Richard Biener wrote: >> > On Tue, 5 Apr 2016, Prathamesh Kulkarni wrote: >> > >> >> On 5 April 2016 at 16:58, Richard Biener

Re: [patch] Remove superfluous /dev/null on grep line

2016-04-06 Thread Jonathan Wakely
On 06/04/16 09:39 +0200, Eric Botcazou wrote: Hi, we recently ran into build failures on Windows systems using a somewhat old grep, coming from a syntax error in the libstdc++-symbols.ver version file: # Symbol versioning for shared libraries. if ENABLE_SYMVERS libstdc++-symbols.ver:

Re: [PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Richard Biener
On Wed, Apr 6, 2016 at 10:31 AM, Alan Modra wrote: > On Tue, Apr 05, 2016 at 11:29:30AM +0200, Richard Biener wrote: >> In general the patch looks like a good approach to me but can we >> hide that >> >> > + const struct real_format *fmt = FLOAT_MODE_FORMAT (mode); >> > + bool

[wwwdocs] Simplify gcc-4.8/cxx0x_status.html (and convert to global CSS)

2016-04-06 Thread Gerald Pfeifer
This is similar to what Jason reported last week for the main cxxstatus.html page. Things already improved by virtue of the global styles I introduced, this now completes things, simplifying the page (removing all those align="center"s and s) and using the global CSS sheet, so any changes

[PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Alan Modra
On Tue, Apr 05, 2016 at 11:29:30AM +0200, Richard Biener wrote: > In general the patch looks like a good approach to me but can we > hide that > > > + const struct real_format *fmt = FLOAT_MODE_FORMAT (mode); > > + bool is_ibm_extended = fmt->pnan < fmt->p; > > in a function somewhere in

Re: [RFC] introduce --param max-lto-partition for having an upper bound on partition size

2016-04-06 Thread Richard Biener
On Wed, 6 Apr 2016, Prathamesh Kulkarni wrote: > On 5 April 2016 at 18:28, Richard Biener wrote: > > On Tue, 5 Apr 2016, Prathamesh Kulkarni wrote: > > > >> On 5 April 2016 at 16:58, Richard Biener wrote: > >> > On Tue, 5 Apr 2016, Prathamesh Kulkarni

Re: [RFC] introduce --param max-lto-partition for having an upper bound on partition size

2016-04-06 Thread Prathamesh Kulkarni
On 5 April 2016 at 18:28, Richard Biener wrote: > On Tue, 5 Apr 2016, Prathamesh Kulkarni wrote: > >> On 5 April 2016 at 16:58, Richard Biener wrote: >> > On Tue, 5 Apr 2016, Prathamesh Kulkarni wrote: >> > >> >> On 4 April 2016 at 19:44, Jan Hubicka

[patch] Remove superfluous /dev/null on grep line

2016-04-06 Thread Eric Botcazou
Hi, we recently ran into build failures on Windows systems using a somewhat old grep, coming from a syntax error in the libstdc++-symbols.ver version file: # Symbol versioning for shared libraries. if ENABLE_SYMVERS libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \