Re: [C PATCH] Warn for optimize attribute on decl after definition (PR c/70255)

2016-05-09 Thread Martin Sebor
On 05/09/2016 08:45 AM, Marek Polacek wrote: In this PR, Richi pointed out that we don't warn for the case when a declaration with attribute optimize follows the definition which is lacking that attribute. This patch adds such a warning. Though the question is whether this shouldn't apply to

[PATCH, rs6000] Fix PR70963: Wrong code for V2DF/V2DI vec_cts with zero scale factor

2016-05-09 Thread Bill Schmidt
Hi, PR70963 reports a problem with vec_cts when used to convert vector double to vector long long. This is due to a register with an undefined value that is generated only when the scale factor is zero. This patch adds logic to provide the correct value when the scale factor is zero. The

[PATCH] PR driver/69265: add hint for options with misspelled arguments

2016-05-09 Thread David Malcolm
opts-common.c's cmdline_handle_error handles invalid arguments for options with CL_ERR_ENUM_ARG by building a strings listing the valid arguments. By also building a vec of valid arguments, we can use find_closest_string and provide a hint if we see a close misspelling. Successfully bootstrapped

PING^4 [PATCH, GCC 5] PR 70613, -fabi-version docs don't match implementation

2016-05-09 Thread Jim Wilson
On Mon, May 2, 2016 at 12:13 PM, Jim Wilson wrote: > Here is a patch to correct the -fabi-version docs on the GCC 5 branch. > https://gcc.gnu.org/ml/gcc-patches/2016-04/msg00480.html Maybe I didn't put enough info in the email the first 3 times? You can see the default

Re: [C PATCH] Warn for optimize attribute on decl after definition (PR c/70255)

2016-05-09 Thread Joseph Myers
On Mon, 9 May 2016, Marek Polacek wrote: > In this PR, Richi pointed out that we don't warn for the case when a > declaration with attribute optimize follows the definition which is lacking > that attribute. This patch adds such a warning. Though the question is > whether this shouldn't apply

Re: [PATCH] Fix PR c++/70822 (bogus error with parenthesized SCOPE_REF)

2016-05-09 Thread Patrick Palka
On Fri, Apr 29, 2016 at 11:55 AM, Patrick Palka wrote: > The problem here is that some code paths are not prepared to handle a > non-dependent PAREN_EXPR, which my fix for PR c++/70106 introduced. In > particular lvalue_kind() returns clk_none for a PAREN_EXPR which makes >

Re: [PATCH] Make basic asm implicitly clobber memory

2016-05-09 Thread Bernd Edlinger
On 05/09/16 15:46, Bernd Schmidt wrote: > On 05/09/2016 03:37 PM, Bernd Edlinger wrote: >> On 05/09/16 09:56, Richard Biener wrote: >>> >>> At least it sounds to me that its semantics can be fully expressed >>> with generic asms? (Maybe apart from the only-if-ASM_STRING-is-empty >>> part) >>> >>

[gomp4] backport fix for PR70626

2016-05-09 Thread Cesar Philippidis
This patch backports the change in the way that 'acc parallel loop' reductions are handled in trunk. Before, the reduction clause only used to be associated with the split acc loop. Now the reduction clause is associated with both the loop and the parallel region. That's beneficial because the

[gomp4] backport the *finish_omp_clauses changes

2016-05-09 Thread Cesar Philippidis
This patch backports the *finish_omp_clauses changes I made to the c and c++ front ends in trunk revision 235780. Like the cilk patch, there were enough changes in gomp-4_0-branch which prevented this patch from applying cleanly on that branch. I've applied this patch to gomp-4_0-branch. Cesar

[gomp4] backport fix for PR69363

2016-05-09 Thread Cesar Philippidis
I've applied this patch to gomp-4_0-branch which backports some cilk changes in the c and c++ front ends to gomp-4_0-branch. These changes were necessary for my recent finish_omp_clauses patch, which I'll be committing next. Cesar 2016-05-09 Cesar Philippidis Backport

Re: [PATCH] Remove constraints from further i386 define_expand patterns

2016-05-09 Thread Uros Bizjak
On Mon, May 9, 2016 at 6:49 PM, Jakub Jelinek wrote: > Hi! > > I believe this cleans up all remaining define_expands (have looked > at tmp-mddump.md with sed picking up only define_expand patterns in there > and have been looking for any constraints and none were left). > >

Re: [RS6000] complex long double ABI_V4 fix

2016-05-09 Thread Michael Meissner
On Fri, May 06, 2016 at 03:54:43PM +0930, Alan Modra wrote: > Revision 235792 regressed compat/scalar-by-value-6 for powerpc-linux > -m32 due to accidentally changing the ABI. By another historical > accident, complex long double is stupidly passed in gprs for -m32. Sorry about the breakage.

Re: [PATCH,rs6000] Add built-in support for new Power9 darn (deliver a random number) instruction

2016-05-09 Thread Peter Bergner
On Mon, 2016-05-09 at 12:35 -0500, Bill Schmidt wrote: > On Mon, 2016-05-09 at 08:58 -0500, Segher Boessenkool wrote: > > On Thu, May 05, 2016 at 10:26:01AM -0600, Kelvin Nilsen wrote: > > Do we really want to #define short words like "darn"? If this is already > > set in stone, so be it. > >

Re: [PATCH], Add PowerPC ISA 3.0 min/max support

2016-05-09 Thread Michael Meissner
On Mon, May 09, 2016 at 09:31:43AM -0500, Segher Boessenkool wrote: > On Thu, May 05, 2016 at 03:18:39PM -0400, Michael Meissner wrote: > > At the present time, the code does not support comparisons involving >= and > > <= > > unless the -ffast-math option is used. I hope eventually to support >

Re: [PATCH], Add PowerPC ISA 3.0 vector d-form addressing

2016-05-09 Thread Michael Meissner
On Mon, May 09, 2016 at 08:11:54AM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Thu, May 05, 2016 at 02:05:19PM -0400, Michael Meissner wrote: > > > > With this patch, I enable -mlra if the user did not specify either > > > > -mlra or > > > > -mno-lra on the command line, and -mcpu=power9

Re: [PATCH] Load external function address via GOT slot

2016-05-09 Thread H.J. Lu
On Fri, Apr 22, 2016 at 6:03 AM, Uros Bizjak wrote: > On Fri, Apr 22, 2016 at 2:54 PM, H.J. Lu wrote: >> For -fno-plt, we load the external function address via the GOT slot >> so that linker won't create an PLT entry for extern function address. >> >>

Re: [PATCH,rs6000] Add built-in support for new Power9 darn (deliver a random number) instruction

2016-05-09 Thread Bill Schmidt
On Mon, 2016-05-09 at 08:58 -0500, Segher Boessenkool wrote: > Hi Kelvin, > > On Thu, May 05, 2016 at 10:26:01AM -0600, Kelvin Nilsen wrote: > > (UNSPEC_DARN_32): New usnpec constant. > > Typo. > > > ("darn_32"): New instruction. > > We don't normally use quotes for insn names. > > >

Re: [ARM] mno-pic-data-is-text-relative & msingle-pic-base

2016-05-09 Thread Nathan Sidwell
Joey, This patch will do what you intend it to do. However, I am not sure in part related to VxWorks. The logic behind this patch is that -mno-pic-data-is-text-relative should enable -msingle-pic-base because otherwise it will be useless. The logic itself is orthogonal to OS. So I am not

RE: [ARM] mno-pic-data-is-text-relative & msingle-pic-base

2016-05-09 Thread Joey Ye
Nathan, This patch will do what you intend it to do. However, I am not sure in part related to VxWorks. The logic behind this patch is that -mno-pic-data-is-text-relative should enable -msingle-pic-base because otherwise it will be useless. The logic itself is orthogonal to OS. So I am not

[PATCH] Improve sse2_loadld

2016-05-09 Thread Jakub Jelinek
Hi! I hope this pattern actually shouldn't be used for AVX512*, because vpinsr should match instead, but just in case it doesn't, all the insns involved are in AVX512F. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-05-09 Jakub Jelinek *

[PATCH] Improve XMM16-XMM31 handling in vpinsr*

2016-05-09 Thread Jakub Jelinek
Hi! vpinsr{b,w} are AVX512BW, vpinsr{d,q} are AVX512DQ. This patch makes us use v constraint instead of x in those cases. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-05-09 Jakub Jelinek * config/i386/sse.md (pinsr_evex_isa): New mode

[PATCH] vec_extract XMM16-XMM17 improvements

2016-05-09 Thread Jakub Jelinek
Hi! vpextr{b,w} are in AVX512BW, so is vpsrldq, and vpextr{d,q} are in AVX512DQ. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-05-09 Jakub Jelinek * config/i386/i386.md (isa): Add x64_avx512dq, enable if TARGET_64BIT &&

[PATCH] Remove constraints from further i386 define_expand patterns

2016-05-09 Thread Jakub Jelinek
Hi! I believe this cleans up all remaining define_expands (have looked at tmp-mddump.md with sed picking up only define_expand patterns in there and have been looking for any constraints and none were left). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-05-09 Jakub

[PATCH] vinsertps XMM16-XMM31 fixes

2016-05-09 Thread Jakub Jelinek
Hi! The testcases show that we emit AVX512BW instructions even when AVX512BW is disabled. Additionally, two of the 4 patterns were using weirdo constraint for the output (x instead of v, while they used v for input). Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for

[PATCH] vinsertps XMM16-XMM31 fixes

2016-05-09 Thread Jakub Jelinek
Hi! vinsertps is already in AVX512F, so we can use use v constraints freely. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-05-09 Jakub Jelinek * config/i386/sse.md (*vec_setv4sf_sse4_1, sse4_1_insertps): Use v constraint instead

[PATCH] Don't emit AVX512DQ insns for -mavx512vl -mno-avx512dq (PR target/70927, take 2)

2016-05-09 Thread Jakub Jelinek
On Tue, May 03, 2016 at 08:23:28PM +0200, Jakub Jelinek wrote: > While working on a patch I'm going to post momentarily, I've noticed that > we sometimes emit AVX512DQ specific instructions even when avx512dq is not > enabled (in particular, EVEX andnps and andnpd are AVX512DQ plus if > they have

PING [PATCH] integer overflow checking builtins in constant expressions

2016-05-09 Thread Martin Sebor
Pinging the following patch: https://gcc.gnu.org/ml/gcc-patches/2016-05/msg00013.html On 05/01/2016 10:39 AM, Martin Sebor wrote: c/68120 - can't easily deal with integer overflow at compile time, is an enhancement request to make the integer overflow intrinsics usable in constant expressions

Re: [PATCH, rs6000] Add support for int versions of vec_addec

2016-05-09 Thread Segher Boessenkool
Hi Bill, On Fri, May 06, 2016 at 09:29:11AM -0500, Bill Seurer wrote: > 2016-05-06 Bill Seurer > > * config/rs6000/rs6000-builtin.def (vec_addec): Change vec_addec to a > special case builtin. > * config/rs6000/rs6000-c.c

Re: [PATCH] add reassociation width target function for power8

2016-05-09 Thread Segher Boessenkool
Hi Aaron, On Wed, May 04, 2016 at 11:20:12AM -0500, Aaron Sawdey wrote: > This patch enables TARGET_SCHED_REASSOCIATION_WIDTH for power8 and up. > The widths returned are derived from testing with SPEC 2006 and some > simple tests on power8. > > Bootstrapped and regtested on

[PATCH, i386]: Fix btrq peephole2

2016-05-09 Thread Uros Bizjak
Hello! As shown by attached testcase, btrq peephole2 generates wrong immediate value for AND mask. Attached patch fixes this problem and also improves btr{s,r,c}q peephole2 patterns a bit. 2016-05-09 Uros Bizjak * config/i386/i386.md (absneg splitters with general

[Patch, Fortran] Update documentation of UNION to be endian agnostic

2016-05-09 Thread Fritz Reese
In light of https://gcc.gnu.org/ml/fortran/2016-05/msg00018.html I should also update the documentation... --- Fritz Reese 0001-Update-documentation-of-UNION-to-be-endian-agnostic.patch Description: Binary data

Re: [PATCH 3/3] shrink-wrap: Remove complicated simple_return manipulations

2016-05-09 Thread Segher Boessenkool
Hi Christophe, On Mon, May 09, 2016 at 03:54:26PM +0200, Christophe Lyon wrote: > After this patch, I've noticed that > gcc.target/arm/pr43920-2.c > now fails at: > /* { dg-final { scan-assembler-times "pop" 2 } } */ > > Before the patch, the generated code was: > [...] > pop {r3,

[C PATCH] Warn for optimize attribute on decl after definition (PR c/70255)

2016-05-09 Thread Marek Polacek
In this PR, Richi pointed out that we don't warn for the case when a declaration with attribute optimize follows the definition which is lacking that attribute. This patch adds such a warning. Though the question is whether this shouldn't apply to more attributes than just "optimize". And, as

[Patch, Fortran] Fix for test case dec_union_4.f90

2016-05-09 Thread Fritz Reese
I was silly to assume little-endian integer representations for this test case - of course it fails on big-endian machines. Fixed to use endian-agnostic character strings. ref https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56226 https://gcc.gnu.org/ml/gcc-testresults/2016-05/msg00779.html ---

Re: [RS6000] complex long double ABI_V4 fix

2016-05-09 Thread Segher Boessenkool
On Fri, May 06, 2016 at 03:54:43PM +0930, Alan Modra wrote: > Revision 235792 regressed compat/scalar-by-value-6 for powerpc-linux > -m32 due to accidentally changing the ABI. By another historical > accident, complex long double is stupidly passed in gprs for -m32. > > Bootstrapped and

Re: [PATCH], Add PowerPC ISA 3.0 min/max support

2016-05-09 Thread Segher Boessenkool
On Thu, May 05, 2016 at 03:18:39PM -0400, Michael Meissner wrote: > At the present time, the code does not support comparisons involving >= and <= > unless the -ffast-math option is used. I hope eventually to support generating > these instructions without having -ffast-math used. > > The

[PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-05-09 Thread Chung-Lin Tang
Hi, this patch resolves an ICE for Fortran when using the OpenACC host_data directive. Actually, rather than say resolve, it's more like adjusting the front-end to same middle-end restrictions as C/C++, namely that we only support pointers or arrays for host_data right now. This patch contains a

Re: [RX] Add support for atomic operations

2016-05-09 Thread Nick Clifton
Hi Oleg, > gcc/ChangeLog: > * config/rx/rx-protos.h (is_interrupt_func, is_fast_interrupt_func): > Forward declare. > (rx_atomic_sequence): New class. > * config/rx/rx.c (rx_print_operand): Use symbolic names for PSW bits. > (is_interrupt_func,

Re: [PATCH] Fix memory leak in tree-inliner

2016-05-09 Thread Martin Liška
On 05/09/2016 12:57 PM, Richard Biener wrote: > does that resolve the issue? If so, this is ok for trunk and branches. It does. I'll commit the patch to trunk after it finishes regression tests. Related patches for branches will be prepared after that. Martin >From

[ARM] mno-pic-data-is-text-relative & msingle-pic-base

2016-05-09 Thread Nathan Sidwell
This patch comes from an off-list conversation between Joey & me. The context is with RTOSs not all singing & dancing dynamic objects and OSes. currently, the documentation for -mno-pic-data-is-text-relative (-mno-PDITR) says 'Assume that each data segments are relative to text segment at

Re: [PATCH,rs6000] Add built-in support for new Power9 darn (deliver a random number) instruction

2016-05-09 Thread Segher Boessenkool
Hi Kelvin, On Thu, May 05, 2016 at 10:26:01AM -0600, Kelvin Nilsen wrote: > (UNSPEC_DARN_32): New usnpec constant. Typo. > ("darn_32"): New instruction. We don't normally use quotes for insn names. > (rs6000_builtin_mask_calculate): Add in the RS6000_BTM_MODULO and >

Re: [PATCH 3/3] shrink-wrap: Remove complicated simple_return manipulations

2016-05-09 Thread Christophe Lyon
On 3 May 2016 at 08:59, Segher Boessenkool wrote: > Now that cfgcleanup knows how to optimize with return statements, the > epilogue insertion code doesn't have to deal with it itself anymore. > > > 2016-05-03 Segher Boessenkool > >

Re: [PATCH] Make basic asm implicitly clobber memory

2016-05-09 Thread Bernd Schmidt
On 05/09/2016 03:37 PM, Bernd Edlinger wrote: On 05/09/16 09:56, Richard Biener wrote: At least it sounds to me that its semantics can be fully expressed with generic asms? (Maybe apart from the only-if-ASM_STRING-is-empty part) That was also my first idea too. In simple cases an asm

Re: [PATCH] Fix PR70497, missed "subreg" CSE on GIMPLE

2016-05-09 Thread Richard Biener
On Mon, 9 May 2016, Marc Glisse wrote: > On Mon, 9 May 2016, Richard Biener wrote: > > > The following patch implements CSEing of "subreg" reads from memory > > like (from the testcase in the PR) > > > > union U { int i[16]; char c; }; > > > > char foo(int i) > > { > > union U u; > > u.i[0]

Re: [PATCH v2] add support for placing variables in shared memory

2016-05-09 Thread Nathan Sidwell
On 05/06/16 13:11, Alexander Monakov wrote: Allow using __attribute__((shared)) to place static variables in '.shared' memory space. Changes in v2: - reword diagnostic message in nvptx_handle_shared_attribute to follow other backends ("... attribute not allowed with auto storage class"); -

Re: [PATCH] Make basic asm implicitly clobber memory

2016-05-09 Thread Bernd Edlinger
On 05/09/16 09:56, Richard Biener wrote: > On Thu, 5 May 2016, Bernd Edlinger wrote: > >> Hi! >> >> this patch is inspired by recent discussion about basic asm: >> >> Currently a basic asm is an instruction scheduling barrier, >> but not a memory barrier, and most surprising, basic asm >> does

Re: [PATCH] Take known zero bits into account when checking extraction.

2016-05-09 Thread Marc Glisse
On Mon, 9 May 2016, Dominik Vogt wrote: This turns out to be quite difficult. A small test function effectively just returns the argument: unsigned long bar (unsigned long in) { if ((in & 1) == 0) in = (in & ~(unsigned long)1); return in; } However, Gcc does not notice that

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-09 Thread Christophe Lyon
On 9 May 2016 at 15:29, Jeff Law wrote: > On 05/09/2016 01:37 AM, Christophe Lyon wrote: > >> >> Hi, >> After this merge, I'm seeing lots of timeouts on arm (using QEMU). >> Is this "expected"? (as in: should I increase my timeout value) > > I wouldn't say it's expected; this is

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-09 Thread Jeff Law
On 05/09/2016 01:37 AM, Christophe Lyon wrote: Hi, After this merge, I'm seeing lots of timeouts on arm (using QEMU). Is this "expected"? (as in: should I increase my timeout value) I wouldn't say it's expected; this is the first time Cilk+ has been supported on ARM. It could be a bug in the

Re: [RS6000] Stop regrename twiddling with split-stack prologue

2016-05-09 Thread Segher Boessenkool
On Wed, May 04, 2016 at 10:41:07PM +0930, Alan Modra wrote: > Bootstrap and regression tested powerpc64le-linux. Fixes 771 Go > testsuite regressions. OK to apply everywhere? > > The alternative of adding all parameter regs used by cfun to the > __morestack CALL_INSN_FUNCTION_USAGE and uses for

Re: [PATCH] Fix PR70497, missed "subreg" CSE on GIMPLE

2016-05-09 Thread Marc Glisse
On Mon, 9 May 2016, Richard Biener wrote: The following patch implements CSEing of "subreg" reads from memory like (from the testcase in the PR) union U { int i[16]; char c; }; char foo(int i) { union U u; u.i[0] = i; return u.c; } CSEing u.c as (char)i and thus removing u during GIMPLE

Re: [PATCH], Add PowerPC ISA 3.0 vector d-form addressing

2016-05-09 Thread Segher Boessenkool
Hi Mike, On Thu, May 05, 2016 at 02:05:19PM -0400, Michael Meissner wrote: > > > With this patch, I enable -mlra if the user did not specify either -mlra > > > or > > > -mno-lra on the command line, and -mcpu=power9 or -mpower9-dform-vector > > > were > > > used. I also enabled -mvsx-timode if

[PATCH] Fix PR70497, missed "subreg" CSE on GIMPLE

2016-05-09 Thread Richard Biener
The following patch implements CSEing of "subreg" reads from memory like (from the testcase in the PR) union U { int i[16]; char c; }; char foo(int i) { union U u; u.i[0] = i; return u.c; } CSEing u.c as (char)i and thus removing u during GIMPLE optimizations. The patch always goes via

PING^2: [PATCH] PR target/70454: Build x86 libgomp with -march=i486 or better

2016-05-09 Thread H.J. Lu
On Mon, May 2, 2016 at 6:46 AM, H.J. Lu wrote: > On Mon, Apr 25, 2016 at 1:36 PM, H.J. Lu wrote: >> If x86 libgomp isn't compiled with -march=i486 or better, append >> -march=i486 XCFLAGS for x86 libgomp build. >> >> Tested on i686 with and without

Re: [RS6000] Fragile testcase breaks with -frename-registers

2016-05-09 Thread Segher Boessenkool
On Wed, May 04, 2016 at 12:05:45AM +0930, Alan Modra wrote: > See comments added below. Bootstrapped and regression tested > powerpc64le-linux. OK to apply? > > PR testsuite/70826 > * gcc.target/powerpc/savres.c: Compile with -fno-rename-registers. Okay for trunk. Thanks! Segher

RE: [PATCH 2/4] [MIPS] Add pipeline description for MSA

2016-05-09 Thread Robert Suchanek
Hi Matthew, > > gcc/ChangeLog: > > > > * config/mips/i6400.md (i6400_fpu_intadd, i6400_fpu_logic) > > (i6400_fpu_div, i6400_fpu_cmp, i6400_fpu_float, i6400_fpu_store) > > (i6400_fpu_long_pipe, i6400_fpu_logic_l, i6400_fpu_float_l) > > (i6400_fpu_mult): New cpu units. > >

RE: [PATCH 1/4] [MIPS] Add support for MIPS SIMD Architecture (MSA)

2016-05-09 Thread Robert Suchanek
Hi Matthew, > One small tweak, ChangeLog should wrap at 74 columns. Done. > Please consider the > full list of authors for this patch as it has had many major contributors > now. I believe this includes at least the following for the implementation > but fewer for the testsuite updates: > >

RE: [MIPS r5900] libgcc floating point fixes

2016-05-09 Thread Matthew Fortune
Hi Woon Yung, Woon yung Liu writes: > Thank you for your feedback. > > New changes in this updated version: > > gcc/config/mips/mips.c:added a check against the use of both -mips16 and > -march=r5900. > libgcc/configure.ac:added a check for the support of -mips16 by the >

Re: [RFC][PR70841] Reassoc fails to handle FP division

2016-05-09 Thread Richard Biener
On Thu, May 5, 2016 at 5:33 AM, kugan wrote: > Hi, > > I tried to handle reassoc fails to handle FP division. I think the best way > to do this is to do like what is done for MINUS_EXPR. I.e, convert the > RDIV_EXPR to MULT_EXPR by (1/x) early and later in

Re: [patch] libstdc++/71004 fix recursive_directory_iterator default constructor

2016-05-09 Thread Jonathan Wakely
On 09/05/16 11:09 +0100, Jonathan Wakely wrote: This fixes some uninitialized members in the filesystem::recursive_directory_iterator default constructor. Tested x86_64-linux, committed to trunk. Backports to follow soon. Oops, I think I need more caffeine. The new function I added to the

Re: [PATCH : RL78] Disable interrupts during hardware multiplication routines

2016-05-09 Thread Nick Clifton
Hi Kaushik, > gcc/ChangeLog > 2016-05-04 Kaushik Phatak > > * config/rl78/rl78.c (rl78_expand_prologue): Save the MDUC related > registers in all interrupt handlers if necessary. > (rl78_option_override): Add warning. >

Re: [RFC][PATCH][PR63586] Convert x+x+x+x into 4*x

2016-05-09 Thread Richard Biener
On Thu, May 5, 2016 at 3:57 AM, kugan wrote: > Hi Richard, > >> >> maybe instert_stmt_after will help here, I don't think you got the >> insertion >> logic correct, thus insert_stmt_after (mul_stmt, def_stmt) which I think >> misses GIMPLE_NOP handling. At

Re: Error out on -fvtable-verify without --enable-vtable-verify

2016-05-09 Thread Bernd Schmidt
On 05/09/2016 01:28 PM, Rainer Orth wrote: Ok now? Yes, thanks. Bernd

Re: Error out on -fvtable-verify without --enable-vtable-verify

2016-05-09 Thread Rainer Orth
Hi Bernd, > On 05/08/2016 12:44 PM, Rainer Orth wrote: >> With the recent change not to install libvtv without >> --enable-vtable-verify, I noticed that gcc/g++ would still accept >> -fvtable-verify without errors, only to emit obscure link-time errors >> about missing vtv_*.o (which hadn't been

Re: [PATCH][ARM] Use proper output modifier for DImode register in store exclusive patterns

2016-05-09 Thread Kyrill Tkachov
Hi all, This seems to have fallen through the cracks. Ping. https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00558.html Thanks, Kyrill On 09/03/16 12:56, Kyrill Tkachov wrote: Hi all, I notice that the output code for our store exclusive patterns accesses unallocated memory. It wants to output

Re: [PATCH GCC]Proving no-trappness for array ref in tree if-conv using loop niter information.

2016-05-09 Thread Bin.Cheng
On Mon, May 9, 2016 at 11:54 AM, Richard Biener wrote: > On Fri, May 6, 2016 at 11:42 AM, Bin.Cheng wrote: >> On Fri, May 6, 2016 at 10:40 AM, Bin.Cheng wrote: >>> On Tue, May 3, 2016 at 11:08 AM, Richard Biener >>>

Re: [RFC][PATCH][PR40921] Convert x + (-y * z * z) into x - y * z * z

2016-05-09 Thread Richard Biener
On Thu, May 5, 2016 at 2:41 AM, kugan wrote: > Hi Richard, > >> >> + int last = ops.length () - 1; >> + bool negate_result = false; >> >> Do >> >>oe = ops.last (); >> > > Done. > >> >> + if (rhs_code == MULT_EXPR >> +

Re: [PING*2][PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-05-09 Thread Richard Biener
On Wed, May 4, 2016 at 4:23 PM, Pierre-Marie de Rodat wrote: > Ping for the patch submitted at > . It applies just > fine on the current trunk and still bootstrapps and regtests successfuly on > x86_64-linux. > > Thank

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-09 Thread Bernd Schmidt
On 05/09/2016 12:42 PM, Jakub Jelinek wrote: On Mon, May 09, 2016 at 12:38:14PM +0200, Bernd Schmidt wrote: On 05/09/2016 12:23 PM, Bernd Schmidt wrote: On 05/06/2016 01:38 AM, Dhole wrote: I've wrote a test case which fails (when it shouldn't) and I don't see why. I think it's setting the

Re: [v3 PATCH] Avoid endless run-time recursion for copying single-element tuples where the element type is by-value constructible from any type

2016-05-09 Thread Jonathan Wakely
On 09/05/16 13:41 +0300, Ville Voutilainen wrote: On 9 May 2016 at 12:31, Jonathan Wakely wrote: On 08/05/16 14:43 +0300, Ville Voutilainen wrote: Tested on Linux-PPC64. OK for trunk, and we should backport to gcc-6-branch (and gcc-5-branch?) soon. gcc-5-branch

Re: [PATCH] Fix memory leak in tree-inliner

2016-05-09 Thread Richard Biener
On Fri, May 6, 2016 at 2:35 PM, Martin Liška wrote: > On 05/06/2016 12:56 PM, Richard Biener wrote: >> Hmmm. But this means debug stmt remapping calls >> remap_dependence_clique which may end up bumping >> cfun->last_clique and thus may change code generation. >> >> So what debug

Re: [PATCH GCC]Proving no-trappness for array ref in tree if-conv using loop niter information.

2016-05-09 Thread Richard Biener
On Fri, May 6, 2016 at 11:42 AM, Bin.Cheng wrote: > On Fri, May 6, 2016 at 10:40 AM, Bin.Cheng wrote: >> On Tue, May 3, 2016 at 11:08 AM, Richard Biener >> wrote: >>> On Tue, May 3, 2016 at 12:01 PM, Bin.Cheng

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-09 Thread Jakub Jelinek
On Mon, May 09, 2016 at 12:38:14PM +0200, Bernd Schmidt wrote: > On 05/09/2016 12:23 PM, Bernd Schmidt wrote: > >On 05/06/2016 01:38 AM, Dhole wrote: > >>I've wrote a test case which fails (when it shouldn't) and I don't see > >>why. > > > >I think it's setting the env var when executing the test,

Re: [v3 PATCH] Avoid endless run-time recursion for copying single-element tuples where the element type is by-value constructible from any type

2016-05-09 Thread Ville Voutilainen
On 9 May 2016 at 12:31, Jonathan Wakely wrote: > On 08/05/16 14:43 +0300, Ville Voutilainen wrote: >> >> Tested on Linux-PPC64. > > > OK for trunk, and we should backport to gcc-6-branch (and > gcc-5-branch?) soon. gcc-5-branch doesn't have the "Improving pair and tuple"

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-09 Thread Bernd Schmidt
On 05/09/2016 12:23 PM, Bernd Schmidt wrote: On 05/06/2016 01:38 AM, Dhole wrote: I've wrote a test case which fails (when it shouldn't) and I don't see why. I think it's setting the env var when executing the test, not when executing the compiler. Here's something that seems to work (with

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-09 Thread Bernd Schmidt
On 05/06/2016 01:38 AM, Dhole wrote: On 16-04-29 09:17:44, Jakub Jelinek wrote: Bernd: I'll see if I can prepare a testcase; first I need to get familiar with the testing framework and learn how to set environment variables in tests. Any tips on that will be really welcome! grep for

[patch] libstdc++/71004 fix recursive_directory_iterator default constructor

2016-05-09 Thread Jonathan Wakely
This fixes some uninitialized members in the filesystem::recursive_directory_iterator default constructor. Tested x86_64-linux, committed to trunk. Backports to follow soon. commit 2b1c32ec504886625dae53274b14f86e2082a636 Author: Jonathan Wakely Date: Mon May 9 11:01:59

Re: [PATCH] Take known zero bits into account when checking extraction.

2016-05-09 Thread Dominik Vogt
On Wed, Apr 27, 2016 at 10:24:21PM -0600, Jeff Law wrote: > On 04/27/2016 02:20 AM, Dominik Vogt wrote: > >The attached patch is a result of discussing an S/390 issue with > >"and with complement" in some cases. > > > > https://gcc.gnu.org/ml/gcc/2016-03/msg00163.html > >

Re: Simple bitop reassoc in match.pd (was: Canonicalize X u< X to UNORDERED_EXPR)

2016-05-09 Thread Richard Biener
On Fri, May 6, 2016 at 1:50 PM, Marc Glisse wrote: > On Tue, 3 May 2016, Richard Biener wrote: > >> On Tue, May 3, 2016 at 3:26 PM, Marc Glisse wrote: >>> >>> On Tue, 3 May 2016, Richard Biener wrote: >>> On Tue, May 3, 2016 at 8:36 AM, Marc

Re: [patch] Fix PR tree-optimization/70884

2016-05-09 Thread Richard Biener
On Sat, May 7, 2016 at 11:22 PM, Eric Botcazou wrote: > Hi, > > this is a tentative fix for the regression introduced in SRA by the machinery > which deals with the constant pool. initialize_constant_pool_replacements is > supposed to issues new loads from the pool for

Re: [PATCH 3/3] Enhance dumps of IVOPTS

2016-05-09 Thread Richard Biener
On Fri, May 6, 2016 at 11:19 AM, Martin Liška wrote: > Hi. > > Honza asked me to explain the change more verbosely. > The patch simplify enhances verbose dump of IVOPTS so that > # of iterations is printed. Apart from that it also prints > invariant expression that are used during

Re: [PATCH 0/4] RFC: RTL frontend

2016-05-09 Thread Richard Biener
On Wed, May 4, 2016 at 10:49 PM, David Malcolm wrote: > This patch kit introduces an RTL frontend, for the purpose > of unit testing: primarly for unit testing of RTL passes, and > possibly for unit testing of .md files. > > It's very much a work-in-progress; I'm posting it

Re: Fix regrename compare-debug issue

2016-05-09 Thread Bernd Schmidt
On 05/05/2016 09:02 AM, Eric Botcazou wrote: When scanning addresses inside a debug insn, we shouldn't use normal base/index classes. This shows as a compare-debug issue on Alpha, where INDEX_REG_CLASS is NO_REGS, and this prevented a chain from being renamed with debugging turned on. Uros

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-09 Thread Matthias Klose
On 07.05.2016 16:35, Matthias Klose wrote: On 02.05.2016 17:51, Jeff Law wrote: On 04/29/2016 05:36 AM, Ilya Verbin wrote: Hi! This patch brings the latest libcilkrts from upstream. Regtested on i686-linux and x86_64-linux. Abidiff: Functions changes summary: 0 Removed, 1 Changed (16

[PATCH] Fix PR70985

2016-05-09 Thread Richard Biener
I am testing the following followup to my BIT_FIELD_REF simplification changes which resolve issues when applying to memory BIT_FIELD_REFs. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2016-05-09 Richard Biener PR tree-optimization/70985

Re: [v3 PATCH] Avoid endless run-time recursion for copying single-element tuples where the element type is by-value constructible from any type

2016-05-09 Thread Jonathan Wakely
On 08/05/16 14:43 +0300, Ville Voutilainen wrote: Tested on Linux-PPC64. OK for trunk, and we should backport to gcc-6-branch (and gcc-5-branch?) soon. Thanks.

Re: [v3 PATCH] Avoid endless run-time recursion for copying single-element tuples where the element type is by-value constructible from any type

2016-05-09 Thread Jonathan Wakely
On 08/05/16 15:55 +0300, Ville Voutilainen wrote: For what it's worth, I have the tiniest preference against using decay here; whenever I see decay, I wonder whether array/function decay is significant. While it doesn't make a difference here, I still prefer just doing

Re: [RFA] Remove useless test in bitmap_find_bit.

2016-05-09 Thread Bernd Schmidt
On 05/06/2016 11:18 PM, Jeff Law wrote: OK for the trunk? Counts as obvious, doesn't it? Bernd

Re: Error out on -fvtable-verify without --enable-vtable-verify

2016-05-09 Thread Bernd Schmidt
On 05/08/2016 12:44 PM, Rainer Orth wrote: With the recent change not to install libvtv without --enable-vtable-verify, I noticed that gcc/g++ would still accept -fvtable-verify without errors, only to emit obscure link-time errors about missing vtv_*.o (which hadn't been installed in that

Re: [PATCH][ARM] Add mode to probe_stack set operands

2016-05-09 Thread Richard Earnshaw (lists)
On 03/05/16 12:27, Kyrill Tkachov wrote: > Hi all, > > When building the arm backend genrecog complains that the probe_stack > set expression > doesn't specify any modes. This patch adds the SI mode annotation and > fixes the warning > > Bootstrapped and tested on arm-none-linux-gnueabihf. > >

Re: Fix handling of negative bitpos in expand_debug_expr

2016-05-09 Thread Bernd Schmidt
On 05/05/2016 04:20 PM, Richard Sandiford wrote: expand_debug_expr handled negative bit positions using: else if (bitpos < 0) { HOST_WIDE_INT units = (-bitpos + BITS_PER_UNIT - 1) / BITS_PER_UNIT; op0 =

Re: [PATCH] Make basic asm implicitly clobber memory

2016-05-09 Thread Richard Biener
On Thu, 5 May 2016, Bernd Edlinger wrote: > Hi! > > this patch is inspired by recent discussion about basic asm: > > Currently a basic asm is an instruction scheduling barrier, > but not a memory barrier, and most surprising, basic asm > does _not_ implicitly clobber CC on targets where >

Re: [PATCH] Fix PR70937

2016-05-09 Thread Richard Biener
On Fri, 6 May 2016, Richard Biener wrote: > On Fri, 6 May 2016, Richard Biener wrote: > > > > > The following patch fixes another case of missing DECL_EXPR in the FE. > > > > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. > > > > Ok for trunk? > > Dominique noticed a FAIL

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-09 Thread Christophe Lyon
On 2 May 2016 at 17:51, Jeff Law wrote: > On 04/29/2016 05:36 AM, Ilya Verbin wrote: >> >> Hi! >> >> This patch brings the latest libcilkrts from upstream. >> Regtested on i686-linux and x86_64-linux. >> >> Abidiff: >> Functions changes summary: 0 Removed, 1 Changed (16 filtered