RE: [PATCH,testsuite] MIPS: Downgrade from R6 to R5 to prevent redundant testing of branch-cost-1.c.

Moore, Catherine writes: > > gcc/testsuite/ChangeLog: > > > > 2016-11-15 Toma Tabacu > > > > * gcc.target/mips/branch-cost-1.c (dg-options): Use > > (HAS_MOVN) instead > > of isa>=4, in order to downgrade to R5. > > > > diff --git

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

On Fri, Nov 18, 2016 at 09:29:13AM +, Kyrill Tkachov wrote: > >So your COMPONENTS_FOR_BB returns both components in a pair whenever one > >of those is needed? That should work afaics. > > I mean I still want to have one component per register and since > emit_{prologue,epilogue}_components

Re: [PATCH v3] bb-reorder: Improve compgotos pass (PR71785)

On Fri, Nov 18, 2016 at 09:09:40AM +0100, Richard Biener wrote: > > This patch rewrites the algorithm to deal with this. It also makes it > > simpler: it does not need the "candidates" array anymore, it does not > > need RTL layout mode, it does not need cleanup_cfg, and it does not > > need to

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

On 18/11/16 12:10 +0100, Rainer Orth wrote: The change is OK in principle, but I'd prefer more meaningful names for the macros ... Fine with me: I know close to nothing of C++, so please bear with me ;-) No problem, that's what the rest of us are here to help with :-) I don't mind whether

RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard library support check the sysroot supports the required test options.

Toma Tabacu writes: > The version below has a more detailed comment about marking tests as > unsupported. > Matthew, does it look good to you ? > > Also, should we document our expectations for the rest of do_what's > format (elements 0 and 2) ? I don’t think it is

Re: [PATCH, Darwin] Fix PR57438 by avoiding empty function bodies and trailing labels.

Hi Segher, Thanks for the review, > On 6 Nov 2016, at 22:09, Segher Boessenkool > wrote: > > On Sun, Nov 06, 2016 at 12:13:16PM -0800, Iain Sandoe wrote: >> 2016-11-06 Iain Sandoe >> >> PR target/57438 >> * config/i386/i386.c

Re: [PATCH] OpenACC routines -- test cases

On Fri, Nov 11, 2016 at 03:44:29PM -0800, Cesar Philippidis wrote: > This patch contains new and adjusted, runtime and compiler test cases > for the new OpenACC routine functionality. > > Is this ok for trunk? Ok (though of course, if the diagnostic wording is adjusted, then the test will need

Re: [PATCH] OpenACC routines -- fortran front end

On Fri, Nov 11, 2016 at 03:44:07PM -0800, Cesar Philippidis wrote: > --- a/gcc/fortran/gfortran.h > +++ b/gcc/fortran/gfortran.h > @@ -314,6 +314,15 @@ enum save_state > { SAVE_NONE = 0, SAVE_EXPLICIT, SAVE_IMPLICIT > }; > > +/* Flags to keep track of ACC routine states. */ > +enum

Re: [PATCH] OpenACC routines -- c front end

On Fri, Nov 11, 2016 at 03:43:23PM -0800, Cesar Philippidis wrote: > @@ -11801,12 +11807,11 @@ c_parser_oacc_shape_clause (c_parser *parser, > omp_clause_code kind, > } > > location_t expr_loc = c_parser_peek_token (parser)->location; > - c_expr cexpr =

Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

On 16 November 2016 at 23:12, Andrew Burgess wrote: > * Mike Stump [2016-11-16 12:59:53 -0800]: > >> On Nov 16, 2016, at 12:09 PM, Andrew Burgess >> wrote: >> > My only remaining concern is the new tests, I've

Re: [PATCH] OpenACC routines -- middle end

On Fri, Nov 11, 2016 at 03:43:02PM -0800, Cesar Philippidis wrote: > + error_at (OMP_CLAUSE_LOCATION (c), > + "%qs specifies a conflicting level of parallelism", > + omp_clause_code_name[OMP_CLAUSE_CODE (c)]); > + inform (OMP_CLAUSE_LOCATION

Re: [PATCH 1/2] PR77822

On Fri, Nov 18, 2016 at 03:31:40AM -0600, Segher Boessenkool wrote: > Hi Dominik, > > On Thu, Nov 17, 2016 at 04:53:47PM +0100, Dominik Vogt wrote: > > +/* A convenience macro to determine whether a SIZE lies inclusively > > + within [1, RANGE], POS lies inclusively within between > > + [0,

RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard library support check the sysroot supports the required test options.

> From: Moore, Catherine [mailto:catherine_mo...@mentor.com] > Sent: 17 November 2016 21:53 > To: Matthew Fortune; Toma Tabacu; Andrew Bennett; 'gcc- > patc...@gcc.gnu.org' > Cc: Moore, Catherine > Subject: RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard > library support check

Re: [PATCH, ARM] Enable ldrd/strd peephole rules unconditionally

On 17 November 2016 at 10:23, Kyrill Tkachov wrote: > > On 09/11/16 12:58, Bernd Edlinger wrote: >> >> Hi! >> >> >> This patch enables the ldrd/strd peephole rules unconditionally. >> >> It is meant to fix cases, where the patch to reduce the sha512 >> stack usage

Re: [Patch 4/5] OpenACC tile clause support, Fortran front-end parts

On Sat, Nov 12, 2016 at 08:51:00AM -0800, Cesar Philippidis wrote: > On 11/11/2016 02:34 AM, Jakub Jelinek wrote: > > On Thu, Nov 10, 2016 at 06:46:46PM +0800, Chung-Lin Tang wrote: > > And here's the patch. The patch doesn't look like OpenACC tile clause fortran support, but bind/nohost clause

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

On Thu, Nov 17, 2016 at 05:34:34PM +0800, Chung-Lin Tang wrote: > Updated C/C++ front-end patches, adjusted as reviewed. Jason is right, finish_omp_clauses will verify the tile operands when !processing_template_decl are non-negative host INTEGER_CSTs, so can't you just tsubst it like

Re: [Patch 2/5] OpenACC tile clause support, omp-low parts

Hi! On Thu, Nov 17, 2016 at 05:31:40PM +0800, Chung-Lin Tang wrote: > +#ifndef ACCEL_COMPILER > + span = integer_one_node; > +#else > + if (!e_mask) > +/* Not paritioning. */ > +span = integer_one_node; ... This goes against the recent trend of avoiding #if/#ifdef guarded blocks of

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

> On 17 Nov 2016, at 21:19, Jeff Law wrote: > > On 11/08/2016 05:49 PM, Iain Sandoe wrote: >> >>> On 8 Nov 2016, at 13:39, Mike Stump wrote: >>> >>> On Nov 8, 2016, at 1:05 PM, Iain Sandoe >>> wrote: Simple for the

Re: [PATCH v3] bb-reorder: Improve compgotos pass (PR71785)

On Fri, Nov 18, 2016 at 03:07:27AM -0600, Segher Boessenkool wrote: > rtl_merge_blocks does not check rtl_can_merge_blocks_p (and you get a > quite spectacular ICE when you get it wrong: everything between the two > blocks is deleted :-) ). I'll make a separate patch that checks it > (layout mode

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

Hi Jonathan, > On 03/11/16 15:11 +0100, Rainer Orth wrote: >>Fortunately, this is all easily fixed by wrapping the affected templates >>in a new macro. That's what this patch does. The new libstdc++ >>acinclude.m4 test may well need wording changes in comments etc. and can >>perhaps be

Re: [Patch 1/5] OpenACC tile clause support, OMP_CLAUSE_TILE adjustments

On Thu, Nov 17, 2016 at 05:27:14PM +0800, Chung-Lin Tang wrote: > I've updated the patch as you suggested. > Here's the v2 of the first patch, mainly gimplify.c adjusted. > > About the ChangeLog issues, I'll make sure the final committed diffs will > solve them. Ok. Jakub

Re: Add a load_extend_op wrapper

> Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? > > Thanks, > Richard > > > gcc/ > * rtlanal.c (load_extend_op): Move to... > * rtl.h: ...here and make inline. OK, thanks. -- Eric Botcazou

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

Hi Bruce, Mike, > On Fri, Nov 11, 2016 at 3:18 AM, Mike Stump wrote: >> >> No objections from me. >> > Or me. Thanks! as discussed at length in the PR, the fixincludes route alone isn't enough to get libsanitizer to build on Darwin 15: we stay with undefined references

Re: [PATCH 3/4] OpenMP lowering changes from the hsa branch

On Sun, Nov 13, 2016 at 10:42:01PM +0100, Martin Jambor wrote: > + size_t collapse = gimple_omp_for_collapse (for_stmt); > + struct omp_for_data_loop *loops > += (struct omp_for_data_loop *) > +alloca (gimple_omp_for_collapse (for_stmt) > + * sizeof (struct omp_for_data_loop));

Re: [PATCH 2/4] HSA specific built-ins

On Sun, Nov 13, 2016 at 08:39:35PM +0100, Martin Jambor wrote: > Hello, > > this patch adds a small file hsa-builtins.def which defines a few > builtins that I then use in OpenMP lowering and expansion. > > After we split gridification stuff in omp-low.c to a separate file, we > should be able

[PATCH][wwwdocs] Document new arm/aarch64 CPU support in a more compact way

Hi all, This patch brings the new CPU support announcements in line with the format used in the GCC 6 notes. That is, rather than have a separate "The is now supported via the..." entry for each new core just list them and give a use example with the -mcpu,-mtune options. Ok to commit?

Re: [PATCH 1/4] Remove build dependence on HSA run-time

On Sun, Nov 13, 2016 at 08:02:41PM +0100, Martin Jambor wrote: > @@ -143,6 +240,12 @@ init_enviroment_variables (void) > suppress_host_fallback = true; >else > suppress_host_fallback = false; > + > + hsa_runtime_lib = getenv ("HSA_RUNTIME_LIB"); > + if (hsa_runtime_lib == NULL) > +

[PATCH GCC]Move simplification from fold-cond.c to match.pd and extend it

Hi, This is a rework of https://gcc.gnu.org/ml/gcc-patches/2016-10/msg02005.html. According to review comment, I extended the original patch and made it covering last kind simplification of fold_cond_expr_with_comparison (Well, this patch handles <, <=, > and >=. == will be handled by a

Re: [PATCH] [AArch64] Fix PR78382

Hi Kyrill, Thanks for the comment. Bootstrapped successfully on AArch64 (thunder) system. And also regression tested on AArch64(thunder) with no regressions. Thanks, Naveen

Re: Add a load_extend_op wrapper

Eric Botcazou writes: >> 2016-11-15 Richard Sandiford >> Alan Hayward >> David Sherwood >> >> * rtl.h (load_extend_op): Declare. >> * rtlanal.c (load_extend_op): New

Re: [PATCH 1/2] PR77822

Hi Dominik, On Thu, Nov 17, 2016 at 04:53:47PM +0100, Dominik Vogt wrote: > +/* A convenience macro to determine whether a SIZE lies inclusively > + within [1, RANGE], POS lies inclusively within between > + [0, RANGE - 1] and the sum lies inclusively within [1, RANGE]. */ > +#define

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

On 17/11/16 17:45, Segher Boessenkool wrote: On Thu, Nov 17, 2016 at 04:50:46PM +, Kyrill Tkachov wrote: Is loading/storing a pair as cheap as loading/storing a single register? In that case you could shrink-wrap per pair of registers instead. I suppose it can vary by microarchitecture.

Re: [PATCH, GCC/ARM] Make arm_feature_set agree with type of FL_* macros

On 17/11/16 20:41, Thomas Preudhomme wrote: On 17/11/16 09:10, Kyrill Tkachov wrote: On 16/11/16 18:09, Thomas Preudhomme wrote: Hi, I've rebased the patch to make arm_feature_set agree with type of FL_* macros on top of trunk rather than on top of the optional -mthumb patch. That

Re: [PATCH] [AArch64] Fix PR78382

Hi Naveen, On 18/11/16 05:30, Hurugalawadi, Naveen wrote: Hi, Please find attached the patch that fixes PR78382. The "SYMBOL_SMALL_TLSGD" was not handled for ILP32. Hence it generates error when compiled for ILP32. The attached patch adds the support and handles it properly as expected for

Re: [PATCH v3] bb-reorder: Improve compgotos pass (PR71785)

On Fri, Nov 18, 2016 at 09:09:40AM +0100, Richard Biener wrote: > > + /* Make a copy of BB, merge it into PRED. */ > > + basic_block copy = duplicate_block (bb, e, NULL); > > + emit_barrier_after_bb (copy); > > + reorder_insns_nobb (BB_HEAD (copy), BB_END (copy), BB_END

Re: [PATCH v3] bb-reorder: Improve compgotos pass (PR71785)

On Thu, 17 Nov 2016, Segher Boessenkool wrote: > For code like the testcase in PR71785 GCC factors all the indirect branches > to a single dispatcher that then everything jumps to. This is because > having many indirect branches with each many jump targets does not scale > in large parts of the

Re: ubsan PATCH to fix compile-time hog with operator overloading (PR sanitizer/78208)

On Thu, Nov 17, 2016 at 05:39:57PM -0800, Marek Polacek wrote: > > Yes, there will be 119 SAVE_EXPRs, and when you -fdump-tree-original it, > > it will be just insanely huge, but each SAVE_EXPR appears exactly twice > > in its containing SAVE_EXPR and the second time cp_genericize_r sees > > the

<    1   2