Re: [patch part, libgcc] Add AVX-specific matmul

2016-11-29 Thread Uros Bizjak
> the patch at https://gcc.gnu.org/ml/fortran/2016-11/msg00246.html > (the one going to gcc-patches was rejected due to size of > regernerated files) contains one libgcc change, which exposes > the __cpu_model interface fox i386 to libgfortran. > > The Fortran bits are OKd, but I need an approval

Re: [PATCH v2] Fix PR78588 - rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type

2016-11-29 Thread Markus Trippelsdorf
On 2016.11.29 at 15:25 -0600, Segher Boessenkool wrote: > On Tue, Nov 29, 2016 at 05:00:05PM +0100, Markus Trippelsdorf wrote: > > Building gcc with -fsanitize=undefined shows: > > rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large > > for 64-bit type 'long unsigned int' >

Re: [Patch, Fortran] PR 78573: [7 Regression] [OOP] ICE in resolve_component, at fortran/resolve.c:13405

2016-11-29 Thread Janus Weil
2016-11-29 23:21 GMT+01:00 Steve Kargl : > On Tue, Nov 29, 2016 at 10:58:35PM +0100, Janus Weil wrote: >> >> here is a rather straightforward patch for an ice-on-invalid >> regression. Regtests cleanly on x86_64-linux-gnu. Ok for trunk? >> > > Yes. Thanks,

[patch part, libgcc] Add AVX-specific matmul

2016-11-29 Thread Thomas Koenig
Hello world, the patch at https://gcc.gnu.org/ml/fortran/2016-11/msg00246.html (the one going to gcc-patches was rejected due to size of regernerated files) contains one libgcc change, which exposes the __cpu_model interface fox i386 to libgfortran. The Fortran bits are OKd, but I need an

Re: [PATCH] Another debug info stv fix (PR rtl-optimization/78547)

2016-11-29 Thread Uros Bizjak
On Tue, Nov 29, 2016 at 8:44 PM, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs because DECL_RTL/DECL_INCOMING_RTL are adjusted > by the stv pass through the PUT_MODE modifications, which means that for > var-tracking.c they contain a bogus mode. > > Fixed by

Re: PING! [PATCH, Fortran, accaf, v1] Add caf-API-calls to asynchronously handle allocatable components in derived type coarrays.

2016-11-29 Thread Paul Richard Thomas
Dear Andre, This all looks OK to me. The only comment that I have that you might deal with before committing is that some of the Boolean expressions, eg: + int caf_dereg_mode + = ((caf_mode & GFC_STRUCTURE_CAF_MODE_IN_COARRAY) != 0 + || c->attr.codimension) + ?

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

2016-11-29 Thread Pitchumani Sivanupandi
On Tuesday 29 November 2016 10:06 PM, Denis Chertykov wrote: 2016-11-28 10:17 GMT+03:00 Pitchumani Sivanupandi : On Saturday 26 November 2016 12:11 AM, Denis Chertykov wrote: I'm sorry for delay. I have a problem with the patch: (Stripping trailing CRs

[PATCH] Fix prs 78602 & 78560 on PowerPC (vec_extract/vec_sec)

2016-11-29 Thread Michael Meissner
These two patches to fix PRs 78602 and 78560 fix aspects of the vector set and extract code I've been working on in the last couple of months. The two symptoms were essentially the same thing, one on vector set and the other on vector extract. The core issue was both set and extract did not

Re: [PATCH][AArch64] PR target/71112: Properly create lowpart of pic_offset_table_rtx with -fpie

2016-11-29 Thread Andrew Pinski
On Tue, Nov 29, 2016 at 1:09 AM, Kyrill Tkachov wrote: > Hi all, > > This ICE only occurs on big-endian ILP32 -fpie code. The expansion code > generates the invalid load: > (insn 6 5 7 (set (reg/f:SI 76) > (unspec:SI [ > (mem/u/c:SI (lo_sum:SI

Re: Go patch committed: Merge to gccgo branch

2016-11-29 Thread Ian Lance Taylor
Now I've merged GCC trunk revision 242992 to the gccgo branch. Ian

RE: [PATCH] PR fortran/77505 -- Treat negative character length as LEN=0

2016-11-29 Thread Punnoose, Elizebeth
Please excuse the messy formatting in my initial mail. Resending with proper formatting. This patch checks for negative character length in the array constructor, and treats it as LEN=0. A warning message is also printed if bounds checking is enabled. Bootstrapped and regression tested the

[PATCH] PR fortran/77505 -- Treat negative character length as LEN=0

2016-11-29 Thread Punnoose, Elizebeth
This patch checks for negative character length in the array constructor, and treats it as LEN=0. A warning message is also printed if bounds checking is enabled. Bootstrapped and regression tested the patch on x86_64-linux-gnu and aarch64-linux-gnu. Index: ChangeLog

Fix arc builds

2016-11-29 Thread Jeff Law
There's a couple unused variables in arc_handle_option. This patch removes them. Verified the arc port builds again. Installed on the trunk. Jeff commit 0177a97d002107d99f82be0861ac0052285ccc0a Author: law Date: Wed Nov 30 04:37:10 2016 +

Re: [RFA] Fix false positive out of bounds array index warning in LRA

2016-11-29 Thread Jeff Law
On 11/02/2016 01:20 PM, Bernd Schmidt wrote: On 10/29/2016 06:21 PM, Jeff Law wrote: On a small number of ports, we only have 2 defined register classes. NO_REGS and ALL_REGS. Examples would include nvptx and vax. So let's look at check_and_process_move from lra-constraints.c: sclass =

Re: [RFC PATCH] avoid printing type suffix with %E (PR c/78165)

2016-11-29 Thread Jeff Law
On 11/19/2016 02:04 PM, Martin Sebor wrote: On 10/26/2016 02:46 PM, Joseph Myers wrote: On Wed, 26 Oct 2016, Martin Sebor wrote: The attached patch implements one such approach by having the pretty printer recognize the space format flag to suppress the type suffix, so "%E" still prints the

Re: [PATCH] avoid calling alloca(0)

2016-11-29 Thread Jeff Law
On 11/26/2016 05:52 PM, Martin Sebor wrote: On 11/25/2016 12:51 PM, Jeff Law wrote: On 11/23/2016 06:15 PM, Martin Sebor wrote: gcc_assert works only in some instances (e.g., in c-ada-spec.c:191) but not in others because some actually do make the alloca(0) call at runtime: at a minimum,

Re: [PATCH] enable -Wformat-length for dynamically allocated buffers (pr 78245)

2016-11-29 Thread Martin Sebor
That said, I defer to you on how to proceed here. I'm prepared to do the work(*) but I do worry about jeopardizing the chances of this patch and the others making it into 7.0. So would it make sense to just init/fini the b_o_s framework in your pass and for builtin expansion? I think that

Re: [PATCH] Support nested functions (PR sanitize/78541).

2016-11-29 Thread Jeff Law
On 11/29/2016 03:44 AM, Martin Liška wrote: Currently we an assert that prevents proper use-after-scope sanitization in nested functions. With the attached patch, we are able to do so. I'm adding 2 test-cases, first one is the ICE reported in PR and the second one tests proper report of

Re: [PING] [PATCH] Fix PR31096

2016-11-29 Thread Hurugalawadi, Naveen
Hi Jeff, >> I believe Richi asked for a small change after which you can consider >> the patch approved: Yeah. Thanks for all the comments and reviews. Patch committed after the modification as:- https://gcc.gnu.org/ml/gcc-cvs/2016-11/msg01019.html Thanks, Naveen

libgo patch committed: Some fixes for c-archive/c-shared mode

2016-11-29 Thread Ian Lance Taylor
This patch to libgo fixes a couple of problems that arise when building Go code into an archive or shared library that is linked into a C program. In archive mode, initsig is called before the memory allocator has been initialized. The code was doing a memory allocation because of the call to

Re: [PATCH] Fix format_integer (PR tree-optimization/78586)

2016-11-29 Thread Jeff Law
On 11/29/2016 12:48 PM, Jakub Jelinek wrote: Hi! As mentioned in the PR, the LSHIFT_EXPR computation of values that will need longest or shortest string is both incorrect (it shifts integer_one_node left, so for precisions above precision of integer it returns 0 (not to mention that it is

Re: [Patch 4/5] OpenACC tile clause support, Fortran front-end parts

2016-11-29 Thread Cesar Philippidis
On 11/18/2016 03:24 AM, Jakub Jelinek wrote: > On Sat, Nov 12, 2016 at 08:51:00AM -0800, Cesar Philippidis wrote: >> On 11/11/2016 02:34 AM, Jakub Jelinek wrote: >>> On Thu, Nov 10, 2016 at 06:46:46PM +0800, Chung-Lin Tang wrote: >> >> And here's the patch. > > The patch doesn't look like OpenACC

Re: Remove stray '@' from install.texi (was Re: [PATCH] Delete GCJ)

2016-11-29 Thread David Malcolm
On Tue, 2016-11-29 at 18:20 -0700, Sandra Loosemore wrote: > On 11/29/2016 06:10 PM, David Malcolm wrote: > > [snip] > > > > r242985 seems to have broken the build, for me at least (with > > texinfo > > 5.1): > > > > ../../src/gcc/doc/install.texi:2199: use braces to give a command > > as an

Re: Remove stray '@' from install.texi (was Re: [PATCH] Delete GCJ)

2016-11-29 Thread Sandra Loosemore
On 11/29/2016 06:10 PM, David Malcolm wrote: [snip] r242985 seems to have broken the build, for me at least (with texinfo 5.1): ../../src/gcc/doc/install.texi:2199: use braces to give a command as an argument to @= make[2]: *** [doc/gccinstall.info] Error 1 The attached patch fixes it. OK

[committed] substring locations and # line directives (PR preprocessor/78569)

2016-11-29 Thread David Malcolm
The ICE in PR preprocessor/78569 appears to be due to an attempt to generate substring locations in a .i file where the underlying .c file has changed since the .i file was generated. This can't work, so it seems safest for the on-demand substring locations to be unavailable for such files,

Remove stray '@' from install.texi (was Re: [PATCH] Delete GCJ)

2016-11-29 Thread David Malcolm
On Tue, 2016-11-29 at 14:23 -0700, Jeff Law wrote: > On 11/21/2016 04:23 PM, Matthias Klose wrote: > > On 21.11.2016 18:16, Rainer Orth wrote: > > > Hi Matthias, > > > > > > > ahh, didn't see that :-/ Now fixed, is this clearer now? > > > > > > > > The options

Re: [PATCH] Fix format_integer (PR tree-optimization/78586)

2016-11-29 Thread Martin Sebor
On 11/29/2016 12:48 PM, Jakub Jelinek wrote: Hi! As mentioned in the PR, the LSHIFT_EXPR computation of values that will need longest or shortest string is both incorrect (it shifts integer_one_node left, so for precisions above precision of integer it returns 0 (not to mention that it is

Re: PING! [PATCH, Fortran, accaf, v1] Add caf-API-calls to asynchronously handle allocatable components in derived type coarrays.

2016-11-29 Thread Andre Vehreschild
Hi Jerry, Tests with multiple images go into the opencoarrays testsuite. Still to push though. The tests I have so far all pass. - Andre Am 30. November 2016 00:06:22 MEZ, schrieb Jerry DeLisle : >On 11/28/2016 10:33 AM, Andre Vehreschild wrote: >> PING! >> >> I know

Re: PING! [PATCH, Fortran, accaf, v1] Add caf-API-calls to asynchronously handle allocatable components in derived type coarrays.

2016-11-29 Thread Jerry DeLisle
On 11/28/2016 10:33 AM, Andre Vehreschild wrote: PING! I know it's a lengthy patch, but comments would be nice anyway. - Andre On Tue, 22 Nov 2016 20:46:50 +0100 Andre Vehreschild wrote: Hi all, attached patch addresses the need of extending the API of the caf-libs to enable

Re: Add a mem_alias_size helper class

2016-11-29 Thread Jeff Law
On 11/29/2016 03:51 PM, Richard Sandiford wrote: Jeff Law writes: On 11/15/2016 09:04 AM, Richard Sandiford wrote: alias.c encodes memory sizes as follows: size > 0: the exact size is known size == 0: the size isn't known size < 0: the exact size of the reference itself is

Re: Add a mem_alias_size helper class

2016-11-29 Thread Richard Sandiford
Jeff Law writes: > On 11/15/2016 09:04 AM, Richard Sandiford wrote: >> alias.c encodes memory sizes as follows: >> >> size > 0: the exact size is known >> size == 0: the size isn't known >> size < 0: the exact size of the reference itself is known, >> but the address has been

Re: [PATCH] xtensa: Fix PR target/78603

2016-11-29 Thread Max Filippov
On Tue, Nov 29, 2016 at 2:16 PM, augustine.sterl...@gmail.com wrote: > On Tue, Nov 29, 2016 at 2:08 PM, Max Filippov wrote: >> 2016-11-29 Max Filippov >> gcc/ >> * config/xtensa/xtensa.c (hwloop_optimize): Don't

Re: [PATCH] Fix x86_64 fix_debug_reg_uses (PR rtl-optimization/78575)

2016-11-29 Thread Jakub Jelinek
On Tue, Nov 29, 2016 at 03:20:08PM -0700, Jeff Law wrote: > On 11/29/2016 12:41 PM, Jakub Jelinek wrote: > >The x86_64 stv pass uses PUT_MODE to change REGs and MEMs in place to affect > >all setters and users, but that is undesirable in debug insns which are > >intentionally ignored during the

Re: [Patch, Fortran] PR 78573: [7 Regression] [OOP] ICE in resolve_component, at fortran/resolve.c:13405

2016-11-29 Thread Steve Kargl
On Tue, Nov 29, 2016 at 10:58:35PM +0100, Janus Weil wrote: > > here is a rather straightforward patch for an ice-on-invalid > regression. Regtests cleanly on x86_64-linux-gnu. Ok for trunk? > Yes. -- Steve

Re: [PATCH] Fix x86_64 fix_debug_reg_uses (PR rtl-optimization/78575)

2016-11-29 Thread Jeff Law
On 11/29/2016 12:41 PM, Jakub Jelinek wrote: Hi! The x86_64 stv pass uses PUT_MODE to change REGs and MEMs in place to affect all setters and users, but that is undesirable in debug insns which are intentionally ignored during the analysis and we should keep using correct modes (TImode) instead

Re: [PATCH] xtensa: Fix PR target/78603

2016-11-29 Thread augustine.sterl...@gmail.com
On Tue, Nov 29, 2016 at 2:08 PM, Max Filippov wrote: > 2016-11-29 Max Filippov > gcc/ > * config/xtensa/xtensa.c (hwloop_optimize): Don't emit zero > overhead loop start between a call and its CALL_ARG_LOCATION > note. Approved.

Re: Add a mem_alias_size helper class

2016-11-29 Thread Jeff Law
On 11/15/2016 09:04 AM, Richard Sandiford wrote: alias.c encodes memory sizes as follows: size > 0: the exact size is known size == 0: the size isn't known size < 0: the exact size of the reference itself is known, but the address has been aligned via AND. In this case "-size" includes the

[PATCH] xtensa: Fix PR target/78603

2016-11-29 Thread Max Filippov
2016-11-29 Max Filippov gcc/ * config/xtensa/xtensa.c (hwloop_optimize): Don't emit zero overhead loop start between a call and its CALL_ARG_LOCATION note. --- gcc/config/xtensa/xtensa.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH] correct handling of non-constant width and precision (pr 78521)

2016-11-29 Thread Martin Sebor
On 11/29/2016 01:04 AM, Christophe Lyon wrote: On 29 November 2016 at 03:59, Martin Sebor wrote: On 11/28/2016 06:35 PM, David Edelsohn wrote: Martin, I am seeing a number of new failures with the testcases on AIX. FAIL: gcc.dg/tree-ssa/builtin-sprintf-warn-1.c (test for

[Patch, Fortran] PR 78573: [7 Regression] [OOP] ICE in resolve_component, at fortran/resolve.c:13405

2016-11-29 Thread Janus Weil
Hi all, here is a rather straightforward patch for an ice-on-invalid regression. Regtests cleanly on x86_64-linux-gnu. Ok for trunk? Cheers, Janus 2016-11-29 Janus Weil PR fortran/78573 * decl.c (build_struct): On error, return directly and do not build

Re: [PATCH] libiberty: avoid reading past end of buffer in strndup/xstrndup (PR c/78498)

2016-11-29 Thread Ian Lance Taylor
On Tue, Nov 29, 2016 at 2:08 PM, David Malcolm wrote: > > gcc/ChangeLog: > PR c/78498 > * selftest.c (selftest::assert_strndup_eq): New function. > (selftest::test_strndup): New function. > (selftest::test_libiberty): New function. >

Re: [PATCH], PR 78594, Fix storing QImode/HImode on ISA 3.0/power9

2016-11-29 Thread Segher Boessenkool
On Tue, Nov 29, 2016 at 02:14:17PM -0500, Michael Meissner wrote: > I was developing the next round of ISA 3.0 code changes to use the vector > extract byte, half word, and word instructions (VEXTU{B,H,W}{R,L}X) that > deposit the value into a general purpose register instead of a vector >

Re: [PR middle-end/78566] Fix uninit regressions caused by previous -Wmaybe-uninit change

2016-11-29 Thread Christophe Lyon
On 29 November 2016 at 17:49, Christophe Lyon wrote: > On 29 November 2016 at 17:33, Aldy Hernandez wrote: >> This fixes the gcc.dg/uninit-pred-6* failures I seem to have caused on some >> non x86 platforms. Sorry for the delay. >> >> The problem is

Re: [PATCH] add common CPP_SPECS for bfin

2016-11-29 Thread Jeff Law
On 11/28/2016 10:51 PM, Waldemar Brodkorb wrote: Hi, add common defines _REENTRANT and _POSIX_SOURCE for bfin. Patch is used in Buildroot for a while to fix issues compiling some software. See here, why this should be always enabled:

Re: [PATCH, ARM] Further improve stack usage on sha512 (PR 77308)

2016-11-29 Thread Bernd Edlinger
On 11/29/16 16:06, Wilco Dijkstra wrote: > Bernd Edlinger wrote: > > - "TARGET_32BIT && reload_completed > + "TARGET_32BIT && ((!TARGET_NEON && !TARGET_IWMMXT) || reload_completed) > && ! (TARGET_NEON && IS_VFP_REGNUM (REGNO (operands[0])))" > > This is equivalent to "&& (!TARGET_IWMMXT ||

[PATCH] libiberty: avoid reading past end of buffer in strndup/xstrndup (PR c/78498)

2016-11-29 Thread David Malcolm
libiberty's implementations of strndup and xstrndup call strlen on the input string, and hence can read past the end of the input buffer if it isn't zero-terminated (such as is the case in PR c/78498, where the input string is from the input.c line cache). This patch converts them to use strnlen

Re: [PATCH] Introduce -fdump-ipa-clones dump output

2016-11-29 Thread Jeff Law
On 11/11/2016 07:30 AM, Martin Liška wrote: Hello. Motivation for the patch is to dump IPA clones that were created by all inter-procedural optimizations. Usage of such input is to track set of functions where a code from another function can eventually occur. Usage of the dump file can be seen

Re: Import libcilkrts Build 4467 (PR target/68945)

2016-11-29 Thread Jeff Law
On 11/17/2016 06:06 AM, Rainer Orth wrote: I happened to notice that my libcilkrts SPARC port has been applied upstream. So to reach closure on this issue for the GCC 7 release, I'd like to import upstream into mainline which seems to be covered by the free-for-all clause in

Re: [PATCH v2] Fix PR78588 - rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type

2016-11-29 Thread Segher Boessenkool
On Tue, Nov 29, 2016 at 05:00:05PM +0100, Markus Trippelsdorf wrote: > Building gcc with -fsanitize=undefined shows: > rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for > 64-bit type 'long unsigned int' > > This happens because if_then_else_cond() in combine.c calls >

Re: [PATCH] Delete GCJ

2016-11-29 Thread Jeff Law
On 11/21/2016 04:23 PM, Matthias Klose wrote: On 21.11.2016 18:16, Rainer Orth wrote: Hi Matthias, ahh, didn't see that :-/ Now fixed, is this clearer now? The options @option{--with-target-bdw-gc-include} and @option{--with-target-bdw-gc-lib} must always specified together for

Re: [PATCH] combine: Tweak change_zero_ext

2016-11-29 Thread Christophe Lyon
On 29 November 2016 at 20:38, Uros Bizjak wrote: >> 2016-11-26 Segher Boessenkool >> >> * combine.c (change_zero_ext): Also handle extends from a subreg >> to a mode bigger than that of the operand of the subreg. > > This patch introduced: > >

Re: [PATCH 7/9] Add RTL-error-handling to host

2016-11-29 Thread Bernd Schmidt
On 11/29/2016 07:53 PM, David Malcolm wrote: Would you prefer that I went with approach (B), or is approach (A) acceptable? Well, I was hoping there'd be an approach (C) where the read-rtl code uses whatever diagnostics framework that is available. Maybe it'll turn out that's too hard.

Go patch committed: Merge to gccgo branch

2016-11-29 Thread Ian Lance Taylor
I merged GCC trunk revision 242967 to the gccgo branch. Ian

[PATCH] Fix x86_64 fix_debug_reg_uses (PR rtl-optimization/78575)

2016-11-29 Thread Jakub Jelinek
Hi! The x86_64 stv pass uses PUT_MODE to change REGs and MEMs in place to affect all setters and users, but that is undesirable in debug insns which are intentionally ignored during the analysis and we should keep using correct modes (TImode) instead of the new one (V1TImode). The current

Re: [v3 PATCH] Implement LWG 2534, Constrain rvalue stream operators.

2016-11-29 Thread Jonathan Wakely
On 27/11/16 20:50 +0200, Ville Voutilainen wrote: Implement LWG 2534, Constrain rvalue stream operators. * include/std/istream (__is_convertible_to_basic_istream): New. (__is_extractable): Likewise. (operator>>(basic_istream<_CharT, _Traits>&&, _Tp&&)): Turn the stream parameter

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-29 Thread Segher Boessenkool
Hi James, Kyrill, On Tue, Nov 29, 2016 at 10:57:33AM +, James Greenhalgh wrote: > > +static sbitmap > > +aarch64_components_for_bb (basic_block bb) > > +{ > > + bitmap in = DF_LIVE_IN (bb); > > + bitmap gen = _LIVE_BB_INFO (bb)->gen; > > + bitmap kill = _LIVE_BB_INFO (bb)->kill; > > + > >

Re: [libstdc++, testsuite] Add dg-require-thread-fence

2016-11-29 Thread Jonathan Wakely
On 16/11/16 22:18 +0100, Christophe Lyon wrote: On 15 November 2016 at 12:50, Jonathan Wakely wrote: On 14/11/16 14:32 +0100, Christophe Lyon wrote: On 20 October 2016 at 19:40, Jonathan Wakely wrote: On 20/10/16 10:33 -0700, Mike Stump wrote: On

Re: Pretty printers for versioned namespace

2016-11-29 Thread Jonathan Wakely
On 28/11/16 22:19 +0100, François Dumont wrote: Hi Here is a patch to fix pretty printers when versioned namespace is activated. You will see that I have hesitated in making the fix independant of the version being used. In source files you will find (__7::)? patterns while in

Re: [PATCH] correct handling of non-constant width and precision (pr 78521)

2016-11-29 Thread Martin Sebor
On 11/29/2016 09:56 AM, Martin Sebor wrote: On 11/28/2016 05:42 PM, Joseph Myers wrote: On Sun, 27 Nov 2016, Martin Sebor wrote: Finally, the patch also tightens up the constraint on the upper bound of bounded functions like snprintf to be INT_MAX. The functions cannot produce output in

Re: [PATCH] Remove uninitialized reads of is_leaf

2016-11-29 Thread Wilco Dijkstra
Jeff Law wrote: > On 11/29/2016 11:39 AM, Wilco Dijkstra wrote: > > I forgot to ask, would it be reasonable to add an assert to check we're not > > in > > a sequence in leaf_function_p? I guess this will trigger on several targets > > (leaf_function_p is used in several backends) but it's a real

[PATCH] Fix format_integer (PR tree-optimization/78586)

2016-11-29 Thread Jakub Jelinek
Hi! As mentioned in the PR, the LSHIFT_EXPR computation of values that will need longest or shortest string is both incorrect (it shifts integer_one_node left, so for precisions above precision of integer it returns 0 (not to mention that it is invalid GENERIC, because the types of first operand

[PATCH] Another debug info stv fix (PR rtl-optimization/78547)

2016-11-29 Thread Jakub Jelinek
Hi! The following testcase ICEs because DECL_RTL/DECL_INCOMING_RTL are adjusted by the stv pass through the PUT_MODE modifications, which means that for var-tracking.c they contain a bogus mode. Fixed by wrapping those into TImode subreg or adjusting the MEMs to have the correct mode.

Re: [PATCH] combine: Tweak change_zero_ext

2016-11-29 Thread Uros Bizjak
> 2016-11-26 Segher Boessenkool > > * combine.c (change_zero_ext): Also handle extends from a subreg > to a mode bigger than that of the operand of the subreg. This patch introduced: FAIL: gcc.target/i386/pr44578.c (internal compiler error) on i686 (or x86_64

[PATCH, i386]: Move mask ops from i386.md to sse.md ...

2016-11-29 Thread Uros Bizjak
... and fix gcc.target/i386/avx512f-kmovw-1.c scan-asm failure. 2016-11-29 Uros Bizjak * config/i386/sse.md (UNSPEC_MASKOP): Move from i386.md. (mshift): Ditto. (SWI1248_AVX512BWDQ): Ditto. (SWI1248_AVX512BW): Ditto. (k): Ditto. (kandn): Ditto.

[PATCH], PR 78594, Fix storing QImode/HImode on ISA 3.0/power9

2016-11-29 Thread Michael Meissner
I was developing the next round of ISA 3.0 code changes to use the vector extract byte, half word, and word instructions (VEXTU{B,H,W}{R,L}X) that deposit the value into a general purpose register instead of a vector register, and I was running the changes through the simulator. I discovered that

Re: [PATCH 7/9] Add RTL-error-handling to host

2016-11-29 Thread David Malcolm
On Tue, 2016-11-29 at 18:23 +0100, Bernd Schmidt wrote: > On 11/29/2016 06:20 PM, David Malcolm wrote: > > > > if that distinction makes sense. Clearly we already have a > > diagnostics > > subsystem on the host; what this patch is adding is the separate, > > rtl-s > > pecific diagnostic

Re: [PATCH] Remove uninitialized reads of is_leaf

2016-11-29 Thread Jeff Law
On 11/29/2016 11:39 AM, Wilco Dijkstra wrote: Jeff Law wrote: On 11/29/2016 04:10 AM, Wilco Dijkstra wrote: GCC caches the whether a function is a leaf in crtl->is_leaf. Using this in the backend is best as leaf_function_p may not work correctly (eg. while emitting prolog or epilog code). I

Re: [PATCH] Remove uninitialized reads of is_leaf

2016-11-29 Thread Wilco Dijkstra
Jeff Law wrote: > On 11/29/2016 04:10 AM, Wilco Dijkstra wrote: > > GCC caches the whether a function is a leaf in crtl->is_leaf. Using this > > in the backend is best as leaf_function_p may not work correctly (eg. while > > emitting prolog or epilog code).  I forgot to ask, would it be

Re: [PING] [PATCH] Fix PR31096

2016-11-29 Thread Jeff Law
On 11/22/2016 10:25 PM, Hurugalawadi, Naveen wrote: Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01049.html I believe Richi asked for a small change after which you

Re: [PATCH] Remove uninitialized reads of is_leaf

2016-11-29 Thread Jeff Law
On 11/29/2016 04:10 AM, Wilco Dijkstra wrote: GCC caches the whether a function is a leaf in crtl->is_leaf. Using this in the backend is best as leaf_function_p may not work correctly (eg. while emitting prolog or epilog code). There are many reads of crtl->is_leaf before it is initialized.

Re: [Ping][PATCH 0/6][ARM] Implement support for ACLE Coprocessor Intrinsics

2016-11-29 Thread Andre Vieira (lists)
On 29/11/16 10:37, Kyrill Tkachov wrote: > > On 29/11/16 10:35, Andre Vieira (lists) wrote: >> On 21/11/16 08:42, Christophe Lyon wrote: >>> Hi, >>> >>> >>> On 17 November 2016 at 11:45, Kyrill Tkachov >>> wrote: On 17/11/16 10:31, Andre Vieira (lists) wrote:

[PATCH] Fix PR68838

2016-11-29 Thread David Edelsohn
Separate from ulimit, 32 bit AIX processes have the concept of memory segments. By default, AIX devotes one 256MB segment to the data section of an executable. Some libstdc++ testcases allocate more than that amount of memory. Instead of individually fixing tests, this patch always adds the AIX

Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

2016-11-29 Thread Jeff Law
On 11/29/2016 07:02 AM, Andrew Burgess wrote: * Jeff Law [2016-11-28 15:08:46 -0700]: On 11/24/2016 02:40 PM, Andrew Burgess wrote: * Christophe Lyon [2016-11-21 13:47:09 +0100]: On 20 November 2016 at 18:27, Mike Stump

Re: [PATCH] remove %p handling from gimple-ssa-sprintf (pr78512)

2016-11-29 Thread Jeff Law
On 11/28/2016 07:57 PM, Martin Sebor wrote: PR 78512 - r242674 miscompiles Linux kernel observes that the Linux kernel fails to boot as a result of enabling the -fprintf-return-value optimization in GCC. This is likely because the kernel has its own sprintf with a large set of extensions to the

Re: Calling 'abort' on bounds violations in libmpx

2016-11-29 Thread Ilya Enkovich
2016-11-29 17:43 GMT+03:00 Alexander Ivchenko : > Hi, > > Attached patch is addressing PR67520. Would that approach work for the > problem? Should I also change the version of the library? Hi! Overall patch is OK. But you need to change version because you change default

Re: [PATCH 7/9] Add RTL-error-handling to host

2016-11-29 Thread Bernd Schmidt
On 11/29/2016 06:20 PM, David Malcolm wrote: if that distinction makes sense. Clearly we already have a diagnostics subsystem on the host; what this patch is adding is the separate, rtl-s pecific diagnostic subsystem to cc1 on the host. So that still seems odd to me. Why not use the normal

Re: [PATCH 7/9] Add RTL-error-handling to host

2016-11-29 Thread David Malcolm
On Mon, 2016-11-28 at 14:47 +0100, Bernd Schmidt wrote: > Been looking at this off and on, and I'm still not sure I entirely > get > it - sorry. > > On 11/11/2016 10:15 PM, David Malcolm wrote: > > > > Implementing an RTL frontend by using the RTL reader from read > > > > -rtl.c > > > > means

Re: [RFC] Assert DECL_ABSTRACT_ORIGIN is different from the decl itself

2016-11-29 Thread Jeff Law
On 11/29/2016 03:13 AM, Richard Biener wrote: On Mon, Nov 28, 2016 at 6:28 PM, Martin Jambor wrote: Hi Jeff, On Mon, Nov 28, 2016 at 08:46:05AM -0700, Jeff Law wrote: On 11/28/2016 07:27 AM, Martin Jambor wrote: Hi, one of a number of symptoms of an otherwise unrelated HSA

Re: [PATCH] correct handling of non-constant width and precision (pr 78521)

2016-11-29 Thread Martin Sebor
On 11/28/2016 05:42 PM, Joseph Myers wrote: On Sun, 27 Nov 2016, Martin Sebor wrote: Finally, the patch also tightens up the constraint on the upper bound of bounded functions like snprintf to be INT_MAX. The functions cannot produce output in excess of INT_MAX + 1 bytes and some

Re: [PATCH] Fix PR78306

2016-11-29 Thread Jeff Law
On 11/29/2016 12:47 AM, Richard Biener wrote: Balaji added this check explicitly. There should be tests in the testsuite (spawnee_inline, spawner_inline) which exercise that code. Yes he did, but no, nothing in the testsuite. I believe the tests are:

Re: [PR middle-end/78566] Fix uninit regressions caused by previous -Wmaybe-uninit change

2016-11-29 Thread Christophe Lyon
On 29 November 2016 at 17:33, Aldy Hernandez wrote: > This fixes the gcc.dg/uninit-pred-6* failures I seem to have caused on some > non x86 platforms. Sorry for the delay. > > The problem is that my fix for PR61409 had the logic backwards. I was > proving that all the uses of a

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

2016-11-29 Thread Denis Chertykov
2016-11-28 10:17 GMT+03:00 Pitchumani Sivanupandi : > On Saturday 26 November 2016 12:11 AM, Denis Chertykov wrote: >> >> I'm sorry for delay. >> >> I have a problem with the patch: >> (Stripping trailing CRs from patch; use --binary to disable.) >> patching

[PR middle-end/78566] Fix uninit regressions caused by previous -Wmaybe-uninit change

2016-11-29 Thread Aldy Hernandez
This fixes the gcc.dg/uninit-pred-6* failures I seem to have caused on some non x86 platforms. Sorry for the delay. The problem is that my fix for PR61409 had the logic backwards. I was proving that all the uses of a PHI are invalidated by any one undefined PHI path, whereas what we want is

Re: [PATCH, vec-tails] Support loop epilogue vectorization

2016-11-29 Thread Christophe Lyon
On 18 November 2016 at 16:54, Christophe Lyon wrote: > On 18 November 2016 at 16:46, Yuri Rumyantsev wrote: >> It is very strange that this test failed on arm, since it requires >> target avx2 to check vectorizer dumps: >> >> /* { dg-final {

Re: [PATCH] improve folding of expressions that move a single bit around

2016-11-29 Thread Jeff Law
On 11/29/2016 03:16 AM, Richard Biener wrote: On Mon, Nov 28, 2016 at 7:41 PM, Jeff Law wrote: On 11/28/2016 06:10 AM, Paolo Bonzini wrote: On 27/11/2016 00:28, Marc Glisse wrote: On Sat, 26 Nov 2016, Paolo Bonzini wrote: --- match.pd(revision 242742) +++ match.pd

Re: [RFA] Handle target with no length attributes sanely in bb-reorder.c

2016-11-29 Thread Jeff Law
On 11/29/2016 03:23 AM, Richard Biener wrote: On Mon, Nov 28, 2016 at 10:23 PM, Jeff Law wrote: I was digging into issues around the patches for 78120 when I stumbled upon undesirable bb copying in bb-reorder.c on the m68k. The core issue is that the m68k does not define a

Re: [PATCH v2] Fix PR78588 - rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type

2016-11-29 Thread Markus Trippelsdorf
Here is v2 of the fix. Building gcc with -fsanitize=undefined shows: rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type 'long unsigned int' This happens because if_then_else_cond() in combine.c calls num_sign_bit_copies() in rtlanal.c with mode==BLKmode.

Re: [PATCH 4/4] S/390: Disable peeling for alignment.

2016-11-29 Thread Andreas Krebbel
And again with the costs for unaligned loads/stores actually changed: gcc/ChangeLog: 2016-11-29 Andreas Krebbel * gcc/config/s390/s390.c (s390_builtin_vectorization_cost): New function. (TARGET_VECTORIZE_BUILTIN_VECTORIZATION_COST): Define

[libiberty] demangler formatting

2016-11-29 Thread Nathan Sidwell
In working on pr78252 I noticed a source formatting nit. Fixed thusly and committed. nathan -- Nathan Sidwell 2016-11-29 Nathan Sidwell * cp-demangle.c (d_print_comp_inner): Fix parameter indentation. Index: cp-demangle.c

Re: [PATCH] Fix PR78588 - rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type

2016-11-29 Thread Markus Trippelsdorf
ID */ > > 236 0, /* BLK */ > > markus@x4 libsupc++ % cat cp-demangle.i > d_demangle_callback_mangled() { > if (strncmp(d_demangle_callback_mangled, "", 1)) > d_type(); > } > > markus@x4 libsupc++ % UBSAN_OPTIONS=print_stacktrace=1:

Re: [PATCH 4/4] S/390: Disable peeling for alignment.

2016-11-29 Thread Andreas Krebbel
On Tue, Nov 29, 2016 at 11:38:15AM +0100, Richard Biener wrote: > So - please instead of setting this param provide > TARGET_VECTORIZE_BUILTIN_VECTORIZATION_COST. Right, that's way better. gcc/ChangeLog: 2016-11-29 Andreas Krebbel * gcc/config/s390/s390.c

Re: [PATCH] Fix PR78588 - rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type

2016-11-29 Thread Markus Trippelsdorf
ot;", 1)) d_type(); } markus@x4 libsupc++ % UBSAN_OPTIONS=print_stacktrace=1:halt_on_error=1 /var/tmp/gcc_build_dir_/./gcc/cc1 -w -fpreprocessed cp-demangle.i -quiet -dumpbase cp-demangle.i -mtune=generic -march=x86-64 -auxbase cp-demangle -O2 -version -o /dev/null GNU C11 (GCC) version 7

Calling 'abort' on bounds violations in libmpx

2016-11-29 Thread Alexander Ivchenko
Hi, Attached patch is addressing PR67520. Would that approach work for the problem? Should I also change the version of the library? 2016-11-29 Alexander Ivchenko * mpxrt/mpxrt-utils.c (set_mpx_rt_stop_handler): New function. (print_help): Add help for

RE: [PATCH] [ARC] Fix compact casesi option.

2016-11-29 Thread Claudiu Zissulescu
> Approved. > Committed, thank you for ur review, Claudiu

Re: [PATCH] Fix PR78588 - rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type

2016-11-29 Thread Markus Trippelsdorf
On 2016.11.29 at 15:14 +0100, Jakub Jelinek wrote: > On Tue, Nov 29, 2016 at 03:08:15PM +0100, Markus Trippelsdorf wrote: > > Building gcc with -fsanitize=undefined shows: > > rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too > > large for 64-bit type 'long unsigned int' > > > >

Re: [Patch, Fortran, OOP] PR 58175: Incorrect warning message on scalar finalizer

2016-11-29 Thread Janus Weil
Committed as r242960. 2016-11-28 14:36 GMT+01:00 Janus Weil : > Hi all, > > the attached patch was posted on bugzilla by Tobias three years ago, > but left unattended since then. It is simple, works well (fixing a > bogus warning) and regtests cleanly on x86_64-linux-gnu. > >

Re: [PATCH] Fix PR78588 - rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type

2016-11-29 Thread Jakub Jelinek
On Tue, Nov 29, 2016 at 03:08:15PM +0100, Markus Trippelsdorf wrote: > Building gcc with -fsanitize=undefined shows: > rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too > large for 64-bit type 'long unsigned int' > > 5210 return nonzero & (HOST_WIDE_INT_1U << (bitwidth - 1))

[PATCH] Fix PR78588 - rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type

2016-11-29 Thread Markus Trippelsdorf
Building gcc with -fsanitize=undefined shows: rtlanal.c:5210:38: runtime error: shift exponent 4294967295 is too large for 64-bit type 'long unsigned int' 5210 return nonzero & (HOST_WIDE_INT_1U << (bitwidth - 1)) 5211 ? 1 : bitwidth - floor_log2 (nonzero) - 1; Here (bitwidth - 1)

Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

2016-11-29 Thread Andrew Burgess
* Jeff Law [2016-11-28 15:08:46 -0700]: > On 11/24/2016 02:40 PM, Andrew Burgess wrote: > > * Christophe Lyon [2016-11-21 13:47:09 +0100]: > > > > > On 20 November 2016 at 18:27, Mike Stump wrote: > > > > On Nov 19, 2016, at

[PATCH] Avoid compile-time overhead of GIMPLE FE in CFG construction

2016-11-29 Thread Richard Biener
$subject Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2016-11-29 Richard Biener * tree-cfg.c (lower_phi_internal_fn): Do not look for further PHIs after a regular stmt. (stmt_starts_bb_p): PHIs not preceeded by a PHI or a

  1   2   >