[gomp4] Make front ends emit warnings when OpenACC routines directives lack parallelism

2017-05-01 Thread Cesar Philippidis
The language regarding OpenACC routines have changed in OpenACC 2.5 such that the end user must explicitly specify one of gang, worker, vector or seq partitioning. I guess some other compiler need those directives to generate specialized versions of those functions accordingly. However, GCC

[gomp4] Make OpenACC orphan gang reductions errors

2017-05-01 Thread Cesar Philippidis
This patch promotes all OpenACC gang reductions on orphan loops as errors. Accord to the spec, orphan loops are those which are not lexically nested inside an OpenACC parallel or kernels regions. I.e., acc loops inside acc routines. At first I thought this could be a warning because the gang

Re: [PATCH] stack adjustment is unsigned

2017-05-01 Thread Jeff Law
On 05/01/2017 04:23 PM, Nathan Sidwell wrote: I happened to notice that stack adjustment code was confusingly testing for an unsigned value being > 0. In this case unadjusted_alignment is of type unsigned HOST_WIDE_INT, so the 'else' portion of the has no effect. This patch simplifies the

Re: [PATCH v2] Destroy arguments for _Cilk_spawn calling in the child (PR 80038)

2017-05-01 Thread Jeff Law
On 04/28/2017 09:20 PM, Xi Ruoyao wrote: On 2017-04-28 08:42 -0600, Jeff Law wrote: On 04/28/2017 08:31 AM, Xi Ruoyao wrote: Should I prepare (re-diff) a patch for current trunk? If you want for the trunk, yes. Rediff for current GCC trunk. -- Xi Ruoyao School of

[PATCH] stack adjustment is unsigned

2017-05-01 Thread Nathan Sidwell
I happened to notice that stack adjustment code was confusingly testing for an unsigned value being > 0. In this case unadjusted_alignment is of type unsigned HOST_WIDE_INT, so the 'else' portion of the has no effect. This patch simplifies the adjustment to be less confusing (IMHO). booted

Basketball Enthusiasts List

2017-05-01 Thread Lilly Walker
Hi, Would you are interested in acquiring an email list of "Basketball Enthusiasts"? from USA. Our Databases:- Students List, Tennis Enthusiasts List, Soccer Enthusiasts List, Softball Enthusiasts List, Hockey Enthusiasts List, Golfers List, Sports Enthusiasts List, Health and Fitness

Re: PR79715: Special case strcpy/strncpy for dse

2017-05-01 Thread Jeff Law
On 05/01/2017 12:17 PM, Richard Biener wrote: On April 28, 2017 8:14:56 PM GMT+02:00, Jeff Law wrote: On 04/24/2017 03:05 AM, Prathamesh Kulkarni wrote: On 1 March 2017 at 13:24, Richard Biener wrote: On Tue, 28 Feb 2017, Jeff Law wrote: On 02/28/2017

Re: [PATCH] RISC-V: Don't built 64-bit multilibs on 32-bit targets

2017-05-01 Thread Palmer Dabbelt
On Mon, 01 May 2017 03:54:49 PDT (-0700), jos...@codesourcery.com wrote: > On Mon, 1 May 2017, Palmer Dabbelt wrote: > >> > Specifically, in such cases the GCC configure option is >> > --enable-target=all to enable 64-bit multilibs for a default-32-bit >> > target, and the binutils/GDB configure

[committed] Eliminate fixit_hint class hierarchy

2017-05-01 Thread David Malcolm
The original implementation of fix-it hints (r230674) had an abstract base class "fixit_hint" and three subclasses, representing each of insertions, replacements, and deletions. Having multiple classes for fix-it hints was a nuisance, as it required per-class logic everywhere that the hints were

Re: [PATCH] Make __FUNCTION__ a mergeable string and do not generate symbol entry.

2017-05-01 Thread Jason Merrill
On Wed, Apr 26, 2017 at 6:58 AM, Martin Liška wrote: > On 04/25/2017 01:58 PM, Jakub Jelinek wrote: >> On Tue, Apr 25, 2017 at 01:48:05PM +0200, Martin Liška wrote: >>> Hello. >>> >>> This is patch that was originally installed by Jason and later reverted due >>> to PR70422. >>>

Re: [committed] fix ILP32 testsuite failures for after PR 80503

2017-05-01 Thread Andreas Schwab
On Mai 01 2017, Martin Sebor wrote: > + /* The range here happens to be a property of the compiler, not > + one of the target. */ > + T ("%9223372036854775808i", 0);/* { dg-warning "width out of range" > } */ > + /* { dg-warning "result to exceed .INT_MAX." "" {

[committed] fix ILP32 testsuite failures for after PR 80503

2017-05-01 Thread Martin Sebor
I committed r247444 as an obvious fix for the ILP32 failures in gcc.dg/tree-ssa/builtin-sprintf-warn-18.c. The committed change is below for reference. Martin diff --git a/gcc/gimple-ssa-sprintf.c b/gcc/gimple-ssa-sprintf.c index c3c717d..a3153c1 100644 --- a/gcc/gimple-ssa-sprintf.c +++

Re: [PATCH 5/7] [D] libiberty: Fixes for demangling qualified symbol names

2017-05-01 Thread Iain Buclaw
On 15 April 2017 at 17:25, Iain Buclaw wrote: > This patch removes `dlang_parse_symbol', and replaces it with > `dlang_parse_qualified' and `dlang_parse_mangle'. All callers have > been updated to reflect as to whether we expect either a `MangleName' > or `QualifiedName'

Re: [PATCH] C++: fix-it hints suggesting accessors for private fields

2017-05-01 Thread Jason Merrill
On Thu, Apr 27, 2017 at 7:23 AM, Nathan Sidwell wrote: > On 04/26/2017 12:34 PM, David Malcolm wrote: > >> Thanks - yes; that gives information on the const vs non-const of the >> "this" parameter, but doesn't say whether the argument was const vs non >> -const. > > >> However,

Re: PR79715: Special case strcpy/strncpy for dse

2017-05-01 Thread Richard Biener
On April 28, 2017 8:14:56 PM GMT+02:00, Jeff Law wrote: >On 04/24/2017 03:05 AM, Prathamesh Kulkarni wrote: >> On 1 March 2017 at 13:24, Richard Biener wrote: >>> On Tue, 28 Feb 2017, Jeff Law wrote: >>> On 02/28/2017 05:59 AM, Prathamesh Kulkarni wrote:

[PATCH 5/5][GIMPLE FE] PR testsuite/80580: Handle invalid SSA names

2017-05-01 Thread Mikhail Maltsev
When parsing SSA names, we should check that parent names are scalars. In fact, this patch just uses the condition of a 'gcc_assert' in 'make_ssa_name_fn'. -- Regards, Mikhail Maltsev gcc/testsuite/ChangeLog: 2017-05-01 Mikhail Maltsev *

[PATCH 4/5][GIMPLE FE] PR testsuite/80580. Handle invalid __MEM

2017-05-01 Thread Mikhail Maltsev
This patch deals with invalid __MEM construct. Before we start building an expression for __MEM, we must check that parsing succeeded and that the __MEM operand is a pointer. -- Regards, Mikhail Maltsev gcc/c/ChangeLog: 2017-05-01 Mikhail Maltsev *

[PATCH 3/5][GIMPLE FE] PR testsuite/80580. Handle invalid unary "*" operand type

2017-05-01 Thread Mikhail Maltsev
This is essentially the same problem as in patch 2, but with unary '*'. We should verify that its argument is a pointer. -- Regards, Mikhail Maltsev gcc/c/ChangeLog: 2017-05-01 Mikhail Maltsev * gimple-parser.c (c_parser_gimple_unary_expression): Check

Re: [PATCH] adding missing LTO to some warning options (PR 78606)

2017-05-01 Thread Martin Sebor
On 04/30/2017 02:02 PM, Tom de Vries wrote: On 01/10/2017 11:16 PM, Martin Sebor wrote: + __builtin_sprintf (d, "%32s", "x"); /* { dg-warning "directive writing 32 bytes into a region of size 12" "-Wformat-length" { xfail *-*-* } } */ This xpasses for me on an older system: ... XPASS:

[PATCH 2/5][GIMPLE FE] PR testsuite/80580: handle invalid types of "->" operands

2017-05-01 Thread Mikhail Maltsev
This bug happens when the LHS of operator '->' is either missing, i.e.: (->a) = 0; or it is not a pointer: int b; b_2->c = 0; LHS should be validated. -- Regards, Mikhail Maltsev gcc/testsuite/ChangeLog: 2017-05-01 Mikhail Maltsev *

[PATCH 1/5][GIMPLE FE] PR testsuite/80580. Handle missing labels in goto statements

2017-05-01 Thread Mikhail Maltsev
The first problem happens because we don't check for missing labels when parsing 'goto' statements. I.e.: __GIMPLE() void fn1() { if (1) goto } The fix is pretty obvious: just add a check. My question is: which functions should I use to produce diagnostics? The surrounding code uses

[PATCH 0/5][GIMPLE FE] PR testsuite/80580. Fix some ICEs on invalid code

2017-05-01 Thread Mikhail Maltsev
Hi, all. As I have already mentioned in the bug report (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80580), I performed some fuzz testing of the GIMPLE front end. I used a technique proposed by John Regehr in his blog post http://blog.regehr.org/archives/1284 for testing C++ compilers. In

[wwwdocs] GCC 7 changes: OpenACC

2017-05-01 Thread Thomas Schwinge
Hi! Committed: Index: htdocs/gcc-7/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v retrieving revision 1.79 retrieving revision 1.80 diff -u -p -r1.79 -r1.80 --- htdocs/gcc-7/changes.html 21 Apr 2017

Re: [patch, fortran] Check bounds for matrix-vector multiplication

2017-05-01 Thread Steve Kargl
On Mon, May 01, 2017 at 07:21:03PM +0200, Thomas Koenig wrote: > Hi Steve, > > > Why the duplicate code? Seems like an OR is needed. > > You are quite right. > > Here's an updated patch: > > Index: frontend-passes.c > === > ---

Re: [patch, fortran] Check bounds for matrix-vector multiplication

2017-05-01 Thread Thomas Koenig
Hi Steve, Why the duplicate code? Seems like an OR is needed. You are quite right. Here's an updated patch: Index: frontend-passes.c === --- frontend-passes.c (Revision 247003) +++ frontend-passes.c (Arbeitskopie) @@

Re: [PATCH] RISC-V: Add -mstrict-align option

2017-05-01 Thread Palmer Dabbelt
On Mon, 01 May 2017 10:08:08 PDT (-0700), san...@codesourcery.com wrote: > On 05/01/2017 09:40 AM, Palmer Dabbelt wrote: >> [snip] >> >> diff --git a/gcc/config/riscv/riscv.opt b/gcc/config/riscv/riscv.opt >> index 0466bb2..0422e07 100644 >> --- a/gcc/config/riscv/riscv.opt >> +++

[PATCH/AARCH64] Improve aarch64 conditional compare usage

2017-05-01 Thread Steve Ellcey
This is a resubmittal of an earlier patch (https://gcc.gnu.org/ml/gcc-patches/2017-02/msg00203.html) to improve the use of ccmp (conditional compare) on aarch64.  I made a couple of tweaks after the first submittal and retested now that we are back in stage 1. Most of the changes are

Re: [PATCH] RISC-V: Add -mstrict-align option

2017-05-01 Thread Sandra Loosemore
On 05/01/2017 09:40 AM, Palmer Dabbelt wrote: [snip] diff --git a/gcc/config/riscv/riscv.opt b/gcc/config/riscv/riscv.opt index 0466bb2..0422e07 100644 --- a/gcc/config/riscv/riscv.opt +++ b/gcc/config/riscv/riscv.opt @@ -84,6 +84,10 @@ mcmodel= Target Report RejectNegative Joined

Re: PR79715: Special case strcpy/strncpy for dse

2017-05-01 Thread Martin Sebor
On 04/24/2017 03:05 AM, Prathamesh Kulkarni wrote: On 1 March 2017 at 13:24, Richard Biener wrote: On Tue, 28 Feb 2017, Jeff Law wrote: On 02/28/2017 05:59 AM, Prathamesh Kulkarni wrote: On 28 February 2017 at 15:40, Jakub Jelinek wrote: On Tue, Feb

Re: [patch, fortran] Check bounds for matrix-vector multiplication

2017-05-01 Thread Steve Kargl
On Mon, May 01, 2017 at 06:19:28PM +0200, Thomas Koenig wrote: > + if (m_case == A2B2) > + { > + a2 = get_array_inq_function (GFC_ISYM_SIZE, matrix_a, 2); > + b1 = get_array_inq_function (GFC_ISYM_SIZE, matrix_b, 1); > + test = runtime_error_ne (b1, a2,

Re: [PATCH, i386]: Fix PR 68491, __get_cpuid with 0 level breaks on early 486

2017-05-01 Thread Christos Zoulas
On May 1, 5:42pm, ubiz...@gmail.com (Uros Bizjak) wrote: -- Subject: [PATCH, i386]: Fix PR 68491, __get_cpuid with 0 level breaks on e | Hello! | | > I've been asked to send the patch against trunk here. | | I have fixed the PR in a slightly different way. Thank you! christos

[patch, fortran] Check bounds for matrix-vector multiplication

2017-05-01 Thread Thomas Koenig
Hello world, the attached patch also performs a check for matrix-vector multiplication. I found it by poking around the source while looking to do some improvements, which should be coming up shortly once this is out of the way. Regression-tested. OK for trunk? Regards Thomas

Re: [C++ Patch] Remove is_auto_or_concept, etc (Was: Re: [C++, concepts] Two slightly obscure pt.c functions?)

2017-05-01 Thread Jason Merrill
OK. On Thu, Apr 27, 2017 at 2:02 PM, Paolo Carlini wrote: > Hi again, > > On 26/04/2017 12:32, Paolo Carlini wrote: >> >> Hi, >> >> in 2013 (2013-09-16) Adam added two slightly obscure functions and I can't >> find much around in terms of rationale, etc: >> >> /*

Re: [PATCH] Implement a warning for bogus sizeof(pointer) / sizeof(pointer[0])

2017-05-01 Thread Jason Merrill
On Fri, Apr 28, 2017 at 1:05 PM, Bernd Edlinger wrote: > On 04/28/17 17:29, Martin Sebor wrote: >> On 04/28/2017 08:12 AM, Bernd Edlinger wrote: >>> >>> Do you want me to change the %qT format strings to %T ? >> >> Yes, with the surrounding %< and %> the nested

Re: [PATCH] warn on mem calls modifying objects of non-trivial types (PR 80560)

2017-05-01 Thread Jason Merrill
Pedro's suggestions all sound good to me. Jason

[PATCH, i386]: Fix PR 68491, __get_cpuid with 0 level breaks on early 486

2017-05-01 Thread Uros Bizjak
Hello! > I've been asked to send the patch against trunk here. I have fixed the PR in a slightly different way. 2017-05-01 Uros Bizjak PR target/68491 * config/i386/cpuid.h (__get_cpuid): Always return 0 when __get_cpuid_max returns 0. (__get_cpuid_count):

[PATCH] RISC-V: Add -mstrict-align option

2017-05-01 Thread Palmer Dabbelt
From: Andrew Waterman The RISC-V user ISA permits misaligned accesses, but they may trap and be emulated. That emulation software needs to be compiled assuming strict alignment. Even when strict alignment is not required, set SLOW_UNALIGNED_ACCESS based upon -mtune to avoid

[testsuite, committed, PR65941] Add and use effective target rdrand

2017-05-01 Thread Tom de Vries
Hi, atm I get these failures for x86_64 -m32: ... FAIL: g++.dg/other/pr59492.C -std=gnu++11 (test for excess errors) FAIL: g++.dg/other/pr59492.C -std=gnu++14 (test for excess errors) FAIL: g++.dg/other/pr59492.C -std=gnu++98 (test for excess errors) ... More specifically: ...

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-01 Thread Uros Bizjak
On Thu, Apr 27, 2017 at 10:04 AM, Daniel Santos wrote: > All of patches are concerned with 64-bit Microsoft ABI functions that call > System V ABI function which clobbers RSI, RDI and XMM6-15 and are aimed at > improving performance and .text size of Wine 64. I had

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-01 Thread Uros Bizjak
On Thu, Apr 27, 2017 at 10:09 AM, Daniel Santos wrote: > Adds the predicates save_multiple and restore_multiple to predicates.md, > which are used by following patterns in sse.md: > > * save_multiple - insn that calls a save stub > * restore_multiple - call_insn that

Re: [PATCH] RISC-V: Don't built 64-bit multilibs on 32-bit targets

2017-05-01 Thread Joseph Myers
On Mon, 1 May 2017, Palmer Dabbelt wrote: > > Specifically, in such cases the GCC configure option is > > --enable-target=all to enable 64-bit multilibs for a default-32-bit > > target, and the binutils/GDB configure option is --enable-64-bit-bfd. But > > you can also make a binutils/GDB target

[patch] Inline size functions in more cases

2017-05-01 Thread Eric Botcazou
Because variable-sized types are first-class citizens in Ada, the compiler factors out size (and offset) computations into size functions in order to make these types less heavyweight to manipulate. The counterpart is that it needs to inline back these size functions into regular expressions

Re: [PATCH][x86] Add missing intrinsics for ADD[SD,SS] and SUB[SD,SS]

2017-05-01 Thread Uros Bizjak
On Thu, Apr 27, 2017 at 10:22 AM, Peryt, Sebastian wrote: > Hi, > > This patch adds missing intrinsics for ADDSD, ADDSS, SUBSD and SUBSS > instructions. > > gcc/ > * config/i386/avx512fintrin.h (_mm_mask_add_round_sd, > _mm_maskz_add_round_sd,

Re: [PATCH] Check for sp push/pop insns in reg_set_p (PR target/79430)

2017-05-01 Thread Uros Bizjak
On Thu, Apr 27, 2017 at 6:13 PM, Jeff Law wrote: > On 04/27/2017 01:32 AM, Jakub Jelinek wrote: >> >> Hi! >> >> As mentioned in the PR and can be seen on the testcase (too large for >> testsuite, with lots of delta reduction I got 48KB *.f90 file still using >> a dozen of

Re: [PATCH] simplify-rtx: Fix compare of comparisons (PR60818)

2017-05-01 Thread Segher Boessenkool
Hi! Is this okay for backport to 5 and 6? Segher On Fri, Mar 31, 2017 at 09:40:34PM +, Segher Boessenkool wrote: > The function simplify_binary_operation_1 has code that does > /* Convert (compare (gt (flags) 0) (lt (flags) 0)) to (flags). */ > but this transformation is only valid if

Re: [PATCH] x86: vpermil2p{s,d} have no commutative operands

2017-05-01 Thread Uros Bizjak
On Fri, Apr 28, 2017 at 4:51 PM, Jan Beulich wrote: > While either of the last two operands can be in memory, they can't be > swapped. > > gcc/ > 2017-04-28 Jan Beulich > > * config/i386/sse.md (xop_vpermil23): Use alternatives. Please write a

{PATCH] New C++ warning -Wcatch-value

2017-05-01 Thread Volker Reichelt
Hi, catching exceptions by value is a bad thing, as it may cause slicing, i.e. a) a superfluous copy b) which is only partial. See also https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#e15-catch-exceptions-from-a-hierarchy-by-reference To warn the user about catch