Re: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-09-29 Thread James Greenhalgh
On Fri, Sep 15, 2017 at 09:15:17AM +0100, Michael Collison wrote: > Patch updated with comments to simplify pattern .from Richard Sandiford. Okay > for trunk? OK. Thanks, James > > 2017-09-14 Michael Collison > > * config/aarch64/aarch64.md

Re: [PING][PATCH][Aarch64] Improve int<->FP conversions

2017-09-29 Thread James Greenhalgh
On Fri, Sep 29, 2017 at 10:42:14PM +0100, Michael Collison wrote: > Ping. Original patch posted here: > > https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00808.html I don't see a patch attached there to review, nor can I see an earlier mail threaded to it with the patch attached. Can you help?

Re: [PATCH,rs6000] Correct dejagnu directives in several newly added tests

2017-09-29 Thread Segher Boessenkool
Hi Kelvin, > * gcc.target/powerpc/swaps-p8-30.c: Exchange the order of dg-do > and dg-require-effective-target directives to correct testing > behavior. > * gcc.target/powerpc/swaps-p8-32.c: Likewise. > * gcc.target/powerpc/swaps-p8-41.c: Likewise. > *

Re: [PATCH, rs6000] Follow-on fix for PR target/80210: ICE in extract_insn

2017-09-29 Thread Segher Boessenkool
Hi Peter, On Thu, Sep 28, 2017 at 09:26:00PM -0500, Peter Bergner wrote: > This patch fixes two new issues exposed (but not caused) by the original > test case added for PR80210 as well as a modified version of that test case. [ .. snip ... ] This all seems correct (but it is so complex that

[PING][PATCH][Aarch64] Improve int<->FP conversions

2017-09-29 Thread Michael Collison
Ping. Original patch posted here: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00808.html

[PING][PATCH] [Aarch64] Optimize subtract in shift counts

2017-09-29 Thread Michael Collison
Ping. Updated patch posted here: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00964.htm l

[PING^2][PATCH][compare-elim] Merge zero-comparisons with normal ops

2017-09-29 Thread Michael Collison
Ping ^ 2. Updated patch posted here: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00390.html

Re: isl scheduler and spatial locality (Re: [PATCH][GRAPHITE] More TLC)

2017-09-29 Thread Oleksandr Zinenko
On 29/09/17 21:58, Sebastian Pop wrote: On Fri, Sep 29, 2017 at 2:37 PM, Sven Verdoolaege wrote: [Sorry for the resend; I used the wrong email address to CC Alex] On Wed, Sep 27, 2017 at 02:18:51PM +0200, Richard Biener wrote: Ah, so I now see why we do not

[PATCH] Improve x86-64 32-bit div/mod followed by zero-extension to 64-bit (PR target/82361)

2017-09-29 Thread Jakub Jelinek
Hi! The following patch adds patterns and splitters for {,u}divmodsi4 followed by zero-extension, similarly to other 32-bit operand instructions divl and idivl zero extends both results to 64-bit, so there is no need to extend it again. The REE pass ignores instructions that have more than one

[PATCH] Fix REG_EQUAL note in x86 -m8bit-idiv code

2017-09-29 Thread Jakub Jelinek
Hi! While working on the following patch, I've discovered that the REG_EQUAL notes for DImode signed/unsigned division/modulo are wrong, there is e.g. (div:SI (reg:DI ...) (reg:DI ...)). Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2017-09-29 Jakub Jelinek

[C++ PATCH] With -Wuseless-cast on direct enum init (PR c++/82299)

2017-09-29 Thread Jakub Jelinek
Hi! The casts added for the C++17 direct enum initialization IMNSHO shouldn't trigger -Wuseless-cast warnings. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2017-09-29 Jakub Jelinek PR c++/82299 * decl.c (reshape_init):

Re: [PATCH] Fix up handle_noipa_attribute

2017-09-29 Thread Joseph Myers
On Fri, 29 Sep 2017, Jakub Jelinek wrote: > Hi! > > I've noticed a bogus attribute (stack_protector) on a function with noipa > attribute. > > The reason seems to be misapplied patch of mine, the 4 lines below were > actually from handle_stack_protect_attribute, but instead of moving those >

[PATCH] Fix up handle_noipa_attribute

2017-09-29 Thread Jakub Jelinek
Hi! I've noticed a bogus attribute (stack_protector) on a function with noipa attribute. The reason seems to be misapplied patch of mine, the 4 lines below were actually from handle_stack_protect_attribute, but instead of moving those there, I'd like to remove them because they make no sense to

Re: [PATCH], Add PowerPC ISA 3.0 IEEE 128-bit floating point round to odd built-in functions

2017-09-29 Thread Joseph Myers
On Fri, 29 Sep 2017, Joseph Myers wrote: > On Fri, 29 Sep 2017, Segher Boessenkool wrote: > > > How do other ports deal with this? Insns with a specific rounding mode? > > Have a separate unspec for every operation? Not very nice either :-( > > Well, ideally you'd have a machine-independent

Re: [PATCH], Add PowerPC ISA 3.0 IEEE 128-bit floating point round to odd built-in functions

2017-09-29 Thread Joseph Myers
On Fri, 29 Sep 2017, Segher Boessenkool wrote: > How do other ports deal with this? Insns with a specific rounding mode? > Have a separate unspec for every operation? Not very nice either :-( Well, ideally you'd have a machine-independent representation of constant rounding modes that could

Re: Patch I have Formatted in Git

2017-09-29 Thread nick
On 2017-09-29 04:25 PM, Joseph Myers wrote: > On Fri, 29 Sep 2017, nick wrote: > >> - error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", reason); >> + error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", N_(reason)); > > This can't be right. N_ only makes sense around a

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-09-29 Thread Steve Ellcey
On Thu, 2017-09-28 at 12:31 +0100, Szabolcs Nagy wrote: >  > i think this should be improved, see below. Those were all good suggestions, here is a new patch that incorporates the changes.  I fixed the IFUNC_OPTIONS argument, renamed ARCH_AARCH64_LINUX_LSE, got rid of the auxv references, and

Re: Patch I have Formatted in Git

2017-09-29 Thread Joseph Myers
On Fri, 29 Sep 2017, nick wrote: > - error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", reason); > + error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", N_(reason)); This can't be right. N_ only makes sense around a string literal (e.g. in a constant initializer); it marks

Re: [PATCH] Improve -Ofast vectorization of std::sin etc. (PR libstdc++/81706)

2017-09-29 Thread Joseph Myers
On Fri, 29 Sep 2017, Jakub Jelinek wrote: > Here is a patch which does that. Also bootstrapped/regtested on > x86_64-linux and i686-linux, ok for trunk? > * c-decl.c (merge_decls): Copy "omp declare simd" attributes from > newdecl to corresponding __builtin_ if any. The C front-end

Re: isl scheduler and spatial locality (Re: [PATCH][GRAPHITE] More TLC)

2017-09-29 Thread Sebastian Pop
On Fri, Sep 29, 2017 at 2:37 PM, Sven Verdoolaege wrote: > [Sorry for the resend; I used the wrong email address to CC Alex] > > On Wed, Sep 27, 2017 at 02:18:51PM +0200, Richard Biener wrote: >> Ah, so I now see why we do not perform interchange on trivial cases like

Re: Patch that fix PR80188

2017-09-29 Thread Bernd Edlinger
On 09/29/17 20:22, nick wrote: > > > On 2017-09-29 01:48 PM, Bernd Edlinger wrote: >> > Greetings, >> > >> > I don't have write access so can someone commit this bug fix as it >> > fixes, >> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80188. >> > >> > Author: Nicholas Krause

Re: [reviewed] qsort comparator consistency checking

2017-09-29 Thread Steve Ellcey
On Fri, 2017-09-29 at 21:43 +0200, Christophe Lyon wrote: > On 29 September 2017 at 21:39, Steve Ellcey > wrote: > > > > On Fri, 2017-09-29 at 21:14 +0300, Alexander Monakov wrote: > > > > > > On Fri, 29 Sep 2017, Andrew Pinski wrote: > > > > > > > > > > > > > > > > > >

Re: [reviewed] qsort comparator consistency checking

2017-09-29 Thread Christophe Lyon
On 29 September 2017 at 21:39, Steve Ellcey wrote: > On Fri, 2017-09-29 at 21:14 +0300, Alexander Monakov wrote: >> On Fri, 29 Sep 2017, Andrew Pinski wrote: >> > >> > > >> > > This patch (r253295) breaks the gcc build for aarch64-linux-gnu: >> > I was just about to report the

Re: [reviewed] qsort comparator consistency checking

2017-09-29 Thread Steve Ellcey
On Fri, 2017-09-29 at 21:14 +0300, Alexander Monakov wrote: > On Fri, 29 Sep 2017, Andrew Pinski wrote: > > > > > > > > This patch (r253295) breaks the gcc build for aarch64-linux-gnu: > > I was just about to report the same thing. > I think autoprefetch ranking heuristic is still wrong if >

isl scheduler and spatial locality (Re: [PATCH][GRAPHITE] More TLC)

2017-09-29 Thread Sven Verdoolaege
[Sorry for the resend; I used the wrong email address to CC Alex] On Wed, Sep 27, 2017 at 02:18:51PM +0200, Richard Biener wrote: > Ah, so I now see why we do not perform interchange on trivial cases like > > double A[1024][1024], B[1024][1024]; > > void foo(void) > { > for (int i = 0; i <

isl scheduler and spatial locality (Re: [PATCH][GRAPHITE] More TLC)

2017-09-29 Thread Sven Verdoolaege
On Wed, Sep 27, 2017 at 02:18:51PM +0200, Richard Biener wrote: > Ah, so I now see why we do not perform interchange on trivial cases like > > double A[1024][1024], B[1024][1024]; > > void foo(void) > { > for (int i = 0; i < 1024; ++i) > for (int j = 0; j < 1024; ++j) > A[j][i] =

Re: [RFC] propagate malloc attribute in ipa-pure-const pass

2017-09-29 Thread Jan Hubicka
> > I wonder what happens here when, say, ipa-icf redirect the call to eqivaelnt > > function and removes the callee? Perhaps we realy want to have set of call > > sites rahter than nodes stored from analysis to execution. Call sites have > > unique stmts and uids, so it will be possible to map

Re: [C++ Patch] PR 68754 ("Explicitly defaulted constexpr assignment operator fails to compile")

2017-09-29 Thread Nathan Sidwell
On 09/29/2017 10:04 AM, Paolo Carlini wrote: Hi, the main issue, a C++14 rejects-valid, is already fixed in trunk, and a while ago I added a testcase for that. However, Andrew noticed that in C++11 mode we emit redundant and also a bit puzzling diagnostic (ending with one of those annoying

Re: [patch, libfortran] Fix thead sanitizer issue with libgfortran

2017-09-29 Thread Thomas Koenig
Am 29.09.2017 um 10:03 schrieb Janne Blomqvist: 1) I'm confused why fbuf_destroy is modified. The fbuf structure is part of gfc_unit, and should be accessed with the same locking rules as the rest of the gfc_unit components. When closing the unit, I think the same should apply here, no? It

[c-family] Implement support for overloading in -fdump-ada-spec

2017-09-29 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on the mainline. 2017-09-29 Eric Botcazou * c-ada-spec.c (to_ada_name): Add index parameter. (pp_ada_tree_identifier): Likewise. (dump_ada_macros): Adjust call to to_ada_name. (struct

Re: Patch that fix PR80188

2017-09-29 Thread nick
On 2017-09-29 01:48 PM, Bernd Edlinger wrote: > > Greetings, > > > > I don't have write access so can someone commit this bug fix as it > > fixes, > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80188. > > > > Author: Nicholas Krause > > Date: Fri Sep 29 11:39:46

[c-family] Tidy up implementation of -fdump-ada-spec

2017-09-29 Thread Eric Botcazou
This renames a few functions for the sake of consistency as well as merges some of them. No functional changes. Tested on x86_64-suse-linux, applied on the mainline. 2017-09-29 Eric Botcazou * c-ada-spec.c (max_ada_macros): Move around.

Re: [reviewed] qsort comparator consistency checking

2017-09-29 Thread Alexander Monakov
On Fri, 29 Sep 2017, Andrew Pinski wrote: > > This patch (r253295) breaks the gcc build for aarch64-linux-gnu: > > I was just about to report the same thing. I think autoprefetch ranking heuristic is still wrong if multi_mem_insn_p may be true; please try this patch. * haifa-sched.c

[committed][PATCH] Fix minor typos and whitespace errors

2017-09-29 Thread Jeff Law
As pointed out by Bernhard. Installing on the trunk as obvious. Jeff diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 63db7ac..1a8f965 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -13967,7 +13967,7 @@ ix86_adjust_stack_and_probe_stack_clash (const

Re: [reviewed] qsort comparator consistency checking

2017-09-29 Thread Andrew Pinski
On Fri, Sep 29, 2017 at 10:46 AM, Christophe Lyon wrote: > Hi, > > > On 29 September 2017 at 15:29, Alexander Monakov wrote: >> Hello, >> >> I'm going to install the following patch on trunk in the next few hours. >> This revision doesn't offer

Re: Patch that fix PR80188

2017-09-29 Thread Bernd Edlinger
> Greetings, > > I don't have write access so can someone commit this bug fix as it > fixes, > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80188. > > Author: Nicholas Krause > Date: Fri Sep 29 11:39:46 2017 -0400 > >This patch fixes,

Re: [reviewed] qsort comparator consistency checking

2017-09-29 Thread Christophe Lyon
Hi, On 29 September 2017 at 15:29, Alexander Monakov wrote: > Hello, > > I'm going to install the following patch on trunk in the next few hours. > This revision doesn't offer per-callsite opt-out anymore as suggested by > Richi on the Cauldron (made possible by fixing all

patch to fix PR81481

2017-09-29 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81481 The patch was bootstrapped and tested on x86-64. Committed as rev. 253300. Index: ira-costs.c === --- ira-costs.c (revision 253253) +++ ira-costs.c

Patch that fix PR80188

2017-09-29 Thread nick
Greetings, I don't have write access so can someone commit this bug fix as it fixes, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80188. Author: Nicholas Krause Date: Fri Sep 29 11:39:46 2017 -0400 This patch fixes, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80188

patch to fix PR82338

2017-09-29 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82338 The patch was bootstrapped and tested on x86-64. Committed as rev. 253259. Index: ChangeLog === --- ChangeLog (revision 253298) +++ ChangeLog

Re: [PATCH], Add PowerPC ISA 3.0 IEEE 128-bit floating point round to odd built-in functions

2017-09-29 Thread Segher Boessenkool
Hi Mike, On Thu, Sep 28, 2017 at 06:34:23PM -0400, Michael Meissner wrote: > This patch addss built-in functions on PowerPC ISA 3.0 (power9) that allow the > user to access the round to odd IEEE 128-bit floating point instructions. > --- gcc/config/rs6000/rs6000.md (revision 253267) > +++

[C++ Patch] PR 68754 ("Explicitly defaulted constexpr assignment operator fails to compile")

2017-09-29 Thread Paolo Carlini
Hi, the main issue, a C++14 rejects-valid, is already fixed in trunk, and a while ago I added a testcase for that. However, Andrew noticed that in C++11 mode we emit redundant and also a bit puzzling diagnostic (ending with one of those annoying "... because:" and nothing after which

[PATCH,rs6000] Correct dejagnu directives in several newly added tests

2017-09-29 Thread Kelvin Nilsen
This patch corrects an error in several newly added test programs that was causing these programs to be SUPPORTED on platforms where they were not supposed to be SUPPORTED, which was causing unexpected FAILS. The patch has been preapproved by seg...@gcc.gnu.org. gcc/testsuite/ChangeLog:

Re: [PATCH,AIX] Initial support for DWARF debug sections in XCOFF.

2017-09-29 Thread Ian Lance Taylor via gcc-patches
On Tue, Aug 1, 2017 at 8:41 AM, REIX, Tony wrote: > > Description: > * This patch provides an initial support for DWARF debug sections in XCOFF. > > Tests: > * AIX: Build: SUCCESS >- build made by means of gmake. > > ChangeLog: > * xcoff.c: Initial support for DWARF

Patch I have Formatted in Git

2017-09-29 Thread nick
Greetings All, I have this patch formatted in git, I was unable to figure out how the whole svn works. I am new to svn. Here is the patch below so any comments on this patch or how to format it properly would be great: >From a86173b1cab13a8fe5615c53005adcfafb97415f Mon Sep 17 00:00:00 2001 From:

RE: 0001-Part-1.-Add-generic-part-for-Intel-CET-enabling

2017-09-29 Thread Tsimbalist, Igor V
Updated patch, version #3. Igor > -Original Message- > From: Tsimbalist, Igor V > Sent: Friday, September 29, 2017 4:32 PM > To: Jeff Law ; gcc-patches@gcc.gnu.org > Cc: richard.guent...@gmail.com; Tsimbalist, Igor V > > Subject: RE:

Re: correct attribute ifunc C++ type safety (PR 82301)

2017-09-29 Thread Martin Sebor
On 09/28/2017 05:23 AM, Pedro Alves wrote: On 09/25/2017 02:03 AM, Martin Sebor wrote: +a @option{-Wincompatible-pointer-types} warning for mismatches. To suppress +a warning for the necessary cast from a pointer to the implementation member +function to the type of the corresponding

RE: 0002-Part-2.-Document-finstrument-control-flow-and-notrack attribute

2017-09-29 Thread Tsimbalist, Igor V
> -Original Message- > From: Sandra Loosemore [mailto:san...@codesourcery.com] > Sent: Friday, September 29, 2017 6:57 AM > To: Tsimbalist, Igor V ; 'gcc- > patc...@gcc.gnu.org' > Cc: Jeff Law > Subject: Re:

[Ada] Avoid single colon in comment markup

2017-09-29 Thread Pierre-Marie de Rodat
This change allows our style-checker to implement a heuristic to detect either only typed one ':' or mistyped one of the characters, causing the entire markup block to disappear as it is then unexpectedly being treated as a comment instead. Tested on x86_64-pc-linux-gnu, committed on trunk

[Ada] Misleading warning when no read access for source file

2017-09-29 Thread Pierre-Marie de Rodat
This patch corrects an issue whereby source files that did not have read permissions were incorrectly referred to as "not found'. Now, these different cases are explicitly identified and warned about properly. -- Source -- -- toto.c void toto(void) { } -- hello.adb

Re: [PING][patch] PR81794: have "would be stringified in traditional C" warning in libcpp/macro.c be controlled by -Wtraditional

2017-09-29 Thread David Malcolm
On Fri, 2017-09-29 at 11:15 -0400, David Malcolm wrote: > On Sun, 2017-09-17 at 20:00 -0400, Eric Gallager wrote: > > Attached is a version of > > https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00481.html that > > contains > > a combination of both the fix and the testcase update, as requested > >

Re: [PING][patch] PR81794: have "would be stringified in traditional C" warning in libcpp/macro.c be controlled by -Wtraditional

2017-09-29 Thread David Malcolm
On Sun, 2017-09-17 at 20:00 -0400, Eric Gallager wrote: > Attached is a version of > https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00481.html that > contains > a combination of both the fix and the testcase update, as requested > in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81794#c2 > > I

[RFA][PATCH] Stack clash protection 07/08 -- V4 (aarch64 bits)

2017-09-29 Thread Jeff Law
Wilco has done most of the design/implementation review work to-date and should have state on most of this code. -- Here's the current aarch64 patch for stack clash protection. It's the only bits for stack clash protection that haven't been committed to the trunk. Looking through my archives

Re: [PATCH][GRAPHITE] More TLC

2017-09-29 Thread Sebastian Pop
On Fri, Sep 29, 2017 at 6:17 AM, Richard Biener wrote: > I fixed the "hack patch" somewhat but realized it's not really possible > ATM to get back at this form because the array descriptor contains only > information to generate the linearized form. So while I get now correct

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Alex Potapenko
On Fri, Sep 29, 2017 at 5:15 PM, Ian Lance Taylor wrote: > > Thanks. Committed to mainline. > Great, thanks! -- Best regards, Alex Potapenko

Re: [libgo] Support 32-bit SPARC relocs

2017-09-29 Thread Ian Lance Taylor
On Tue, Sep 12, 2017 at 6:01 AM, Rainer Orth wrote: > A couple of gotools tests were FAILing on 32-bit Solaris/SPARC like > this: > > FAIL: TestCgoHandlesWlORIGIN > go_test.go:267: running testgo [build origin] > go_test.go:286: standard error: >

Re: [PATCH][GRAPHITE] Abstract away codegen_error setting

2017-09-29 Thread Sebastian Pop
On Fri, Sep 29, 2017 at 3:52 AM, Richard Biener wrote: > > This moves it to a function to make it easy to enable ICEin on them > in one place. > > Bootstrapped / tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2017-09-29 Richard Biener > >

RE: 0001-Part-1.-Add-generic-part-for-Intel-CET-enabling

2017-09-29 Thread Tsimbalist, Igor V
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Friday, September 29, 2017 12:44 AM > To: Tsimbalist, Igor V ; gcc- > patc...@gcc.gnu.org > Cc: richard.guent...@gmail.com > Subject: Re: 0001-Part-1.-Add-generic-part-for-Intel-CET-enabling

Re: [PATCH][GRAPHITE] Avoid CHRECs with evolution in loops not in the nest

2017-09-29 Thread Sebastian Pop
On Fri, Sep 29, 2017 at 6:18 AM, Richard Biener wrote: > The idea is that we'd transform the above to > basically wrap each SCOP inside a loop that doesn't iterate. > > Does this look reasonable? Yes, I think your solution looks good. > 2017-09-29 Richard Biener

Re: [C++ PATCH] C++2A P0683R1 - default member initializers for bit-fields (take 2)

2017-09-29 Thread Nathan Sidwell
On 09/29/2017 05:26 AM, Jakub Jelinek wrote: Hi! On Wed, Sep 27, 2017 at 07:55:20AM -0700, Nathan Sidwell wrote: 1) fix the parsing bug you found and move to (ab)using DECL_BIT_FIELD_REPRESENTATIVE 2) the new c++2a feature And here is the 2) patch, on top of the previous 3

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Ian Lance Taylor
On Fri, Sep 29, 2017 at 7:08 AM, Alex Potapenko wrote: > On Fri, Sep 29, 2017 at 4:44 PM, Ian Lance Taylor wrote: >> >> Thanks. Yes, the problem is that -fdump-go-spec is faithfully >> reporting a dangling type definition, which is fine in C but not in >>

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Alex Potapenko
On Fri, Sep 29, 2017 at 4:44 PM, Ian Lance Taylor wrote: > > Thanks. Yes, the problem is that -fdump-go-spec is faithfully > reporting a dangling type definition, which is fine in C but not in > Go. Since we don't care about any of the locale stuff anyhow, I'm > inclined to a

Re: [PATCH] Fix fortran/81509

2017-09-29 Thread Steve Kargl
On Fri, Sep 29, 2017 at 11:15:47AM +0200, Janus Weil wrote: > Hi Steve, > > > As aside effect, the patch removes a questionable GNU Fortran > > extension that allowed arguments to IAND, IOR, and IEOR to have > > different kind type parameters. The behavior of this extension > > was not

[Ada] Build in place for nonlimited types

2017-09-29 Thread Pierre-Marie de Rodat
First cut at build-in-place for nonlimited types. This is a work in progress; the build-in-place support is currently disabled. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-29 Bob Duff * exp_ch6.adb (Expand_Call_Helper): Handle case of build-in-place

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Ian Lance Taylor
On Fri, Sep 29, 2017 at 6:28 AM, Alex Potapenko wrote: > (Sorry for the rerepost: the list doesn't accept any attachments) > > Hi Ian, > > On Fri, Sep 29, 2017 at 3:56 PM, Ian Lance Taylor wrote: >> >> On Fri, Sep 29, 2017 at 1:38 AM, Alex Potapenko

[reviewed] qsort comparator consistency checking

2017-09-29 Thread Alexander Monakov
Hello, I'm going to install the following patch on trunk in the next few hours. This revision doesn't offer per-callsite opt-out anymore as suggested by Richi on the Cauldron (made possible by fixing all known issues on trunk). Thus this patch has a few minor differences compared to the previous

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Alex Potapenko
(Sorry for the rerepost: the list doesn't accept any attachments) Hi Ian, On Fri, Sep 29, 2017 at 3:56 PM, Ian Lance Taylor wrote: > On Fri, Sep 29, 2017 at 1:38 AM, Alex Potapenko > wrote: > > > > Building GCC 7.2.0 libgo against uClibc-ng 1.0.26

Re: [RFA gfortran] PR 25071: dummy argument larger than actual argument

2017-09-29 Thread Dominique d'Humières
Committed as revisions r253286 and r253287. Dominique > Le 29 sept. 2017 à 15:07, Dominique d'Humières a écrit : > > Thanks for the quick review. The change logs are > > 2017-09-29 Dominique d'Humieres > > PR fortran/25071 > *

[Ada] Crash on illegal use of iterated component association

2017-09-29 Thread Pierre-Marie de Rodat
An iterated component association is an Ada2020 extension that simplifies the construction of array aggregates. This patch properly rejects the use of this construct as a named association in an aggregate for a record type. compiling gcc -c -gnat2020 klurigt-m2.adb must yield:

[Ada] Copy of Unchecked_Union derived discriminated types

2017-09-29 Thread Pierre-Marie de Rodat
The compiler crashes processing an assignment to a discriminated record type that has pragma Unchecked_Union and Convention C and is a derivation of a non-tagged record type with discriminants. After this patch the following test compiles silently. procedure Conversion is type small_array is

[Ada] Compiler hangs on evaluation of use-clause within package context

2017-09-29 Thread Pierre-Marie de Rodat
Due to the installation order of packages within a context clause it is possible to create circularities within the Prev_Use_Clause clain. This patch corrects this issue by identifying this case through the use of an extra check. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-29

[Ada] Pragma Unchecked_Union on derived discriminated type

2017-09-29 Thread Pierre-Marie de Rodat
The compiler reports an spurious error processing a derived type of a non-tagged record type that has discriminants, pragma Unchecked_Union and pragma Convention C. After this patch the following test compiles silently. procedure Conversion is type small_array is array (0 .. 2) of Integer;

[patch committed FT32] Add watchdog vector and FT930 support

2017-09-29 Thread James Bowman
The attached patch adds a watchdog reset vector and FT930 support to the base interrupt code. [libgcc] 2017-09-28 James Bowman * config/ft32/crti-hw.S: Add watchdog vector, FT930 IRQ support. Index: libgcc/config/ft32/crti-hw.S

Re: [RFA gfortran] PR 25071: dummy argument larger than actual argument

2017-09-29 Thread Dominique d'Humières
Thanks for the quick review. The change logs are 2017-09-29 Dominique d'Humieres PR fortran/25071 * interface.c (compare_actual_formal): Change warnings to errors when "Actual argument contains too few elements for dummy argument", unless

[Ada] Spurious error in nested generic containing expression function

2017-09-29 Thread Pierre-Marie de Rodat
This patch removes spurious visibility errors from the instantiation of a generic package nested within another generic, when the inner package contains an expression function that is the completion of a visible function of that package, and the expression includes an object of a tagged type local

Re: [PATCH][GRAPHITE] Avoid CHRECs with evolution in loops not in the nest

2017-09-29 Thread Richard Biener
On Fri, 29 Sep 2017, Richard Biener wrote: > > For gcc.dg/graphite/scop-4.c when we analyze data-refs of the fist > two inner loops (with the scalar BB in between) > > for (i = 1; i < 100; i++) /// loop 1 > { > -- scop start > for (j = 1; j < 80; j++) /// loop 2 > a[j][i] =

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Ian Lance Taylor
On Fri, Sep 29, 2017 at 1:38 AM, Alex Potapenko wrote: > > Building GCC 7.2.0 libgo against uClibc-ng 1.0.26 results in the following > error: > >> runtime_sysinfo.go:418:17: error: use of undefined type >> ‘___uclibc_locale_struct’ > > > This happens because -fdump-go-spec

Re: [PATCH] Improve -Ofast vectorization of std::sin etc. (PR libstdc++/81706)

2017-09-29 Thread Jakub Jelinek
On Tue, Sep 12, 2017 at 09:49:20AM +0200, Jakub Jelinek wrote: > On Sat, Sep 09, 2017 at 03:42:35PM +0200, Jason Merrill wrote: > > On Fri, Sep 1, 2017 at 1:12 PM, Jakub Jelinek wrote: > > > + tree s = lookup_attribute ("omp declare simd", > > > +

[C++ PATCH] C++2A P0683R1 - default member initializers for bit-fields (take 2)

2017-09-29 Thread Jakub Jelinek
Hi! On Wed, Sep 27, 2017 at 07:55:20AM -0700, Nathan Sidwell wrote: > 1) fix the parsing bug you found and move to (ab)using > DECL_BIT_FIELD_REPRESENTATIVE > > 2) the new c++2a feature And here is the 2) patch, on top of the previous 3 ones. Bootstrapped/regtested on x86_64-linux

Re: [PATCH] Fix PR82337 (SLSR and abnormal PHIs)

2017-09-29 Thread Richard Biener
On Wed, Sep 27, 2017 at 9:15 PM, Bill Schmidt wrote: > Hi, > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82337 reports a problem > with SLSR performing an invalid optimization across an abnormal PHI. > This is easy to avoid by ensuring that SSA names used in an

[PATCH][GRAPHITE] Avoid CHRECs with evolution in loops not in the nest

2017-09-29 Thread Richard Biener
For gcc.dg/graphite/scop-4.c when we analyze data-refs of the fist two inner loops (with the scalar BB in between) for (i = 1; i < 100; i++) /// loop 1 { -- scop start for (j = 1; j < 80; j++) /// loop 2 a[j][i] = a[j+1][2*i-1*j] + 12; b[i] = b[i-1] + 10; for

Re: [PATCH][GRAPHITE] More TLC

2017-09-29 Thread Richard Biener
On Thu, 28 Sep 2017, Sebastian Pop wrote: > On Wed, Sep 27, 2017 at 9:33 AM, Richard Biener wrote: > > Looks like even when hacking the Fortran FE to produce nested > > ARRAY_REFs we run into the same issue for > > > > (gdb) p debug_data_reference (dr) > > #(Data Ref: > > #

Re: [PATCH] Fix fortran/81509

2017-09-29 Thread Janus Weil
Hi Steve, > As aside effect, the patch removes a questionable GNU Fortran > extension that allowed arguments to IAND, IOR, and IEOR to have > different kind type parameters. The behavior of this extension > was not documented. I don't really like that part. We were using the nice and convenient

Patch ping

2017-09-29 Thread Jakub Jelinek
Hi! I'd like to ping the following patch: http://gcc.gnu.org/ml/gcc-patches/2017-09/msg01540.html libgcc __mulvDI3 fix - missed detection of overflow for 0x * 0x __builtin_mul_overflow{,_p} fix for the same Thanks Jakub

Re: [PATCH][GRAPHITE] Allow --param graphite-max-arrays-per-scop=0

2017-09-29 Thread Richard Biener
On Thu, 28 Sep 2017, Sebastian Pop wrote: > On Wed, Sep 27, 2017 at 6:51 AM, Richard Biener wrote: > > > > The following is to allow making --param graphite-max-arrays-per-scop > > unbounded. That's a little tricky because the bound is used when > > computing "alias-sets" for

[PATCH][GRAPHITE] Abstract away codegen_error setting

2017-09-29 Thread Richard Biener
This moves it to a function to make it easy to enable ICEin on them in one place. Bootstrapped / tested on x86_64-unknown-linux-gnu, applied. Richard. 2017-09-29 Richard Biener * graphite-isl-ast-to-gimple.c

[LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Alex Potapenko
Hi! Building GCC 7.2.0 libgo against uClibc-ng 1.0.26 results in the following error: > runtime_sysinfo.go:418:17: error: use of undefined type > ‘___uclibc_locale_struct’ This happens because -fdump-go-spec probably generates types only from typedef declarations, ignoring structs, like

Re: [RFA gfortran] PR 25071: dummy argument larger than actual argument

2017-09-29 Thread Janne Blomqvist
On Thu, Sep 28, 2017 at 3:57 PM, Dominique d'Humières wrote: > Hi all, > > In the PR there was some consensus to turn the warnings into errors. > > This is what the patch does: the warnings are kept with -std=legacy, errors > are emitted otherwise. > I am sure it may exist a

Re: [patch, libfortran] Fix thead sanitizer issue with libgfortran

2017-09-29 Thread Janne Blomqvist
On Fri, Sep 29, 2017 at 9:03 AM, Thomas Koenig wrote: > I wrote: > >> This gets rid of the thread sanitizer issue; the thread sanitizer >> output is clean. However, I would appreciate feedback about whether >> this approach (and my code) is correct. >> >>

Re: [patch, libfortran] Fix thead sanitizer issue with libgfortran

2017-09-29 Thread Thomas Koenig
I wrote: This gets rid of the thread sanitizer issue; the thread sanitizer output is clean.  However, I would appreciate feedback about whether this approach (and my code) is correct. Regression-tested. Here is an update: The previous version of the patch had a regression, which is removed