Re: [PATCH] Add -fsanitize=pointer-{compare,subtract}.

On 10/06/2017 03:33 PM, Jakub Jelinek wrote: > On Fri, Oct 06, 2017 at 02:46:05PM +0200, Martin Liška wrote: >> + if (sanitize_comparison_p) >> +{ >> + if (is_gimple_assign (s) >> + && gimple_assign_rhs_class (s) == GIMPLE_BINARY_RHS >> + &&

Re: Fix profile update in switch conversion

On 10/10/2017 07:39 PM, Jan Hubicka wrote: >> Hi Honza, >> >> The change here cause the following failures: >> >>> FAIL: gcc.dg/tree-prof/switch-case-1.c scan-rtl-dump-times expand ";; basic >>> block[^\\n]*count 2000" 1 >>> FAIL: gcc.dg/tree-prof/switch-case-2.c scan-rtl-dump-times expand ";;

Re: Fwd: [PATCH] scheduler bug fix for AArch64 insn fusing SCHED_GROUP usage

On Sun, 2017-09-10 at 19:45 +0200, Jim Wilson wrote: > -- Forwarded message -- > From: Jim Wilson > Date: Tue, Sep 5, 2017 at 8:04 PM > Subject: Re: [PATCH] scheduler bug fix for AArch64 insn fusing > SCHED_GROUP usage > To: "gcc-patches@gcc.gnu.org"

Re: [PATCH] Add a warning for invalid function casts

On 10/10/2017 03:48 PM, Joseph Myers wrote: On Tue, 10 Oct 2017, Martin Sebor wrote: Calling a function that takes arguments via a void (*)(void) is undefined not just on paper but also in practice, so the resulting pointer from such a cast is unusable except to convert to a compatible

[PATCH] i386: Check red zone size in push peephole2

Check red zone size, instead of if red zone is available, in push peephole2s. Tested on i686 and x86-64. OK for master? H.J. --- gcc/ PR target/82499 * config/i386/i386.h (x86_red_zone_size): New. * config/i386/i386.md (push peephole2s): Replace

Re: [PATCH][mingw] Enable colorized diagnostics

On 2017/10/11 5:04, Manuel López-Ibáñez wrote: Ops! You're obviously right. What was I thinking? I still believe that pretty-printer.c is not the right place for all this color-handling code (diagnostic-color.c or libiberty/ may be better places). No and yes. The colors emerge only when those

Re: [RFC] overflow safe scaling of 64bit values

> Any ideas for better version? If not I will go ahead with this variant and > increase profile probability base. Why not use GCC wide int? - David

[PATCH] rs6000: insn_cost

This adds an implementation of the insn_cost hook to rs6000. This implementations is very minimal (so far). It is mostly based on how many machine instructions are generated by an RTL insn, and it also looks at the instruction type. Floating point insns are costed as if all machine instructions

Re: [PATCH] Add a warning for invalid function casts

On Tue, 10 Oct 2017, Martin Sebor wrote: > Calling a function that takes arguments via a void (*)(void) > is undefined not just on paper but also in practice, so the > resulting pointer from such a cast is unusable except to convert > to a compatible pointer. That's the point of a generic

Re: [PATCH][mingw] Enable colorized diagnostics

On 10 Oct 2017 2:34 am, "Liu Hao" wrote: Since on *nix it is not when `colorize_start()` is called that the terminal color is changed (it is when those ANSI escape codes are delivered to the other peer which will translate them), and the string passed to `fputs()` is free to

Re: [gomp4] OpenACC async re-work

On 10/10/2017 11:08 AM, Thomas Schwinge wrote: > Reported by Cesar for a test case similar to the one below, where we > observe: > > acc_prof-cuda-1.exe: [...]/libgomp/oacc-profiling.c:592: > goacc_profiling_dispatch_p: Assertion `thr->prof_info == NULL' failed. > > This is because of: >

[C++ PATCH] Kill unneeded hash specialization

Now I've converted the identifier_>decl hash_maps to self-hashing hash_tables, there's no need for the lang_identifier specialization of default_hash_traits. So killing it. nathan -- Nathan Sidwell 2017-10-10 Nathan Sidwell * cp-tree.h (default_hash_traits ): Delete

[RFC] overflow safe scaling of 64bit values

Hi, in order to drop frequencies from basic blocks and counts from edges I need to make probabilities more precise (so we do not get all those roundoff errors from 1-base fixpoint arithmetics). Increasing base is easy now, but it means that in temporaries one can get overflows easily. I need

[PATCH] Add various testcases

Hi! While going through still open [5 Regression] bugs manually, I've gathered various testcases from PRs that were fixed by other changes and thus IMHO the tests are worth being added. I have some further PRs to go through tomorrow, so I might add some further ones. Regtested on x86_64-linux

[C++ PATCH] Hash mangling alias

This patch changes the mangling alias hash_map to a hash_table, hashing by DECL_ASSEMBLER_NAME. Thus halving its size. It continues to use DECL_ASSEMBLER_NAME, not the new DECL_ASSEMBLER_NAME_RAW I posted earlier today. When (if) that gets the ok, I'll adjust this fragment too. Applying

Re: GCC 7 libbacktrace patch committed: Ignore compressed debug sections

On Tue, Oct 10, 2017 at 12:47 PM, Paolo Carlini wrote: > > On 10/10/2017 18:55, Ian Lance Taylor wrote: >> >> Index: elf.c >> === >> --- elf.c (revision 253593) >> +++ elf.c (working copy) >> @@

Re: [C++ PATCH] hash-table for extern-c fns.

On Tue, Oct 10, 2017 at 3:11 PM, Nathan Sidwell wrote: > On 10/09/2017 06:15 PM, Nathan Sidwell wrote: >> >> On 10/09/2017 11:57 AM, Jason Merrill wrote: > > >>> Hmm, why do we only check extern "C" conflicts for functions? >> >> >> I suspect a bug. I noticed it as existing

Re: GCC 7 libbacktrace patch committed: Ignore compressed debug sections

Hi, On 10/10/2017 18:55, Ian Lance Taylor wrote: Index: elf.c === --- elf.c (revision 253593) +++ elf.c (working copy) @@ -103,6 +103,7 @@ #undef SHT_SYMTAB #undef SHT_STRTAB #undef SHT_DYNSYM +#undef

Re: [C++ PATCH] hash-table for extern-c fns.

On 10/09/2017 06:15 PM, Nathan Sidwell wrote: On 10/09/2017 11:57 AM, Jason Merrill wrote: Hmm, why do we only check extern "C" conflicts for functions? I suspect a bug.  I noticed it as existing behaviour and was puzzled the first time around rearranging this code, but didn't want to get

Re: [PATCH, ARM] correctly encode the CC reg data flow

On 10/09/17 15:02, Richard Earnshaw (lists) wrote: > On 06/09/17 14:17, Bernd Edlinger wrote: >> Index: gcc/doc/rtl.texi >> === >> --- gcc/doc/rtl.texi (revision 251752) >> +++ gcc/doc/rtl.texi (working copy) >> @@ -2252,6 +2252,13 @@

Re: [patch, Fortran] Fix PR 82372

Hi Steve, the attached patch displays an error for characters which are outside the normal Fortran character set, and includes a hex If this ^ corresponds to this statement, +char valid_chars[] = +

[PATCH] preprocessor stringizing raw strings

This patch fixes PR 82506, where we fail to properly stringize a raw string literal, which can contain a raw LF character. When we're not just preprocessing, there isn't a problem. The string literal gets correctly escaped into the assembly file. This is just a problem with preprocessing.

Re: [patch][arm][FreeBSD] gcc-6/5: add support for armv7*-*-freebsd*

On 08.10.17 23:12, Andreas Tobler wrote: Hi all, and here is the patch for gcc-6/5 branch to add support for armv7*-*-freebsd* The difference towards trunk is the missing of target_cpu_cname which is solved differently. I'm aware of the gcc-5 branch status and I will not apply before gcc-5.5

Re: [patch][arm][FreeBSD] gcc-7 branch: add support for armv7*-*-freebsd*

On 08.10.17 22:58, Andreas Tobler wrote: Hi all, here is the patch witch adds support for armv7*-*-freebsd* on the gcc-7 branch. The difference towards trunk is the target_cpu_cname. I'll commit this one if no objections pop up. Committed in 253603 Andreas 2017-10-08 Andreas Tobler

Re: [patch][arm][FreeBSD] add support for armv7*-*-freebsd*

On 08.10.17 22:51, Andreas Tobler wrote: Hi all, I'm going to commit this patch if no objections pop up. We (FreeBSD folks) have added a new target tripplet for armv7*-*-freebsd* To be able to build GCC we need the below changes. Results will be posted to the usual place, once they

Re: [PATCH] Fix PR80295[aarch64] [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

On Oct 9, 2017, at 12:05 PM, Qing Zhao wrote: > Thanks a lot for Wilco’s help on this bug. Yes, Aarch64 does NOT do anything wrong. The implementation of __builtin_update_setjmp_buf is not correct. It takes a pointer as an operand

Re: [gomp4] OpenACC async re-work

Hi! Reported by Cesar for a test case similar to the one below, where we observe: acc_prof-cuda-1.exe: [...]/libgomp/oacc-profiling.c:592: goacc_profiling_dispatch_p: Assertion `thr->prof_info == NULL' failed. This is because of: On Tue, 25 Jul 2017 20:51:05 +0800, Chung-Lin Tang

Re: [patch, Fortran] Fix PR 82372

On Tue, Oct 10, 2017 at 07:42:25PM +0200, Thomas Koenig wrote: > Hello world, > > the attached patch displays an error for characters which are > outside the normal Fortran character set, and includes a hex If this ^ > code when it is not printable. > >

Re: C++ PATCH for c++/56973 (DR 696), lambda capture of const variables

On Thu, Sep 28, 2017 at 3:38 PM, Jason Merrill wrote: > The G++ lambda implementation previously implemented an early > tentative resolution of DR 696, whereby mentions of an outer constant > variable would immediately decay to the constant value of that > variable. But the

Cleanup x86-tune.def

Hi, while looking into Zen tuning I noticed that some of the tunables in x86-tune.def was added into section with obsolette flags, which does not make much sense. * x86-tune.def (X86_TUNE_AVOID_FALSE_DEP_FOR_BMI, X86_TUNE_ADJUST_UNROLL, X86_TUNE_ONE_IF_CONV_INSN): Move to right

[patch, Fortran] Fix PR 82372

Hello world, the attached patch displays an error for characters which are outside the normal Fortran character set, and includes a hex code when it is not printable. gfortran 4.9 did display unprintable characters in the file, so it might be argued that this bug is a regression.

Re: Fix profile update in switch conversion

> Hi Honza, > > The change here cause the following failures: > > >FAIL: gcc.dg/tree-prof/switch-case-1.c scan-rtl-dump-times expand ";; basic > >block[^\\n]*count 2000" 1 > >FAIL: gcc.dg/tree-prof/switch-case-2.c scan-rtl-dump-times expand ";; basic > >block[^\\n]*count 2000" 1 > > > I

Re: [PATCH] Add a warning for invalid function casts

On 10/10/2017 10:30 AM, Joseph Myers wrote: On Tue, 10 Oct 2017, Martin Sebor wrote: I know of pre-existing code-bases where a type-cast to type: void (*) (void); .. is already used as a generic function pointer: libffi and libgo, I would not want to break these. Why not fix them instead?

Re: [PATCH, rs6000] (v2) fix-up int128 fold vector multiply tests

On Tue, Oct 10, 2017 at 10:52:37AM -0500, Will Schmidt wrote: > [PATCH, rs6000] fix-up int128 fold vector multiply tests > > Fix up a few issues with the tests. > - add -O2 to int128-p8 test, and firm up the -mcpu and > -mpower*-vector options > - update the

GCC 7 libbacktrace patch committed: Ignore compressed debug sections

This patch to the GCC 7 libbacktrace ignores compressed debug sections. If we don't, the DWARF reader reports an error. Since the GCC 7 libbacktrace does not support uncompressing the debug sections, ignoring them is the best approach (on trunk, we uncompress). This is for PR 80914.

Re: [PATCH] Add a warning for invalid function casts

On Tue, 10 Oct 2017, Martin Sebor wrote: > > I know of pre-existing code-bases where a type-cast to type: > > void (*) (void); > > > > .. is already used as a generic function pointer: libffi and > > libgo, I would not want to break these. > > Why not fix them instead? They're a part of GCC so

Re: [PATCH, rs6000] (v2) fix-up int128 fold vector multiply tests

On Mon, 2017-10-09 at 17:22 -0500, Segher Boessenkool wrote: > Hi Will, > > On Mon, Oct 09, 2017 at 04:27:54PM -0500, Will Schmidt wrote: > > Fix up a few issues with the tests. > > - add -O2 to int128-p8 test, and firm up the -mcpu options > > - update the set of expected

Re: Fix profile update in switch conversion

Hi Honza, The change here cause the following failures: FAIL: gcc.dg/tree-prof/switch-case-1.c scan-rtl-dump-times expand ";; basic block[^\\n]*count 2000" 1 FAIL: gcc.dg/tree-prof/switch-case-2.c scan-rtl-dump-times expand ";; basic block[^\\n]*count 2000" 1 I checked that, after the

Re: [PATCH] Add a warning for invalid function casts

On 10/09/2017 04:30 PM, Bernd Edlinger wrote: On 10/09/17 20:34, Martin Sebor wrote: On 10/09/2017 11:50 AM, Bernd Edlinger wrote: On 10/09/17 18:44, Martin Sebor wrote: On 10/07/2017 10:48 AM, Bernd Edlinger wrote: Hi! I think I have now something useful, it has a few more heuristics

GCC 5 branch is now closed

After the GCC 5.5 release the GCC 5 branch is now closed. Please refrain from committing to it from now on. Thanks Jakub

[C++ PATCH] set_global_binding tweak

It turns out that we no longer have to worry about the stat hack when pushing internal decls into the global namespace. I think it was last week's change to record_builtin_type, which did have the habit of pushing duplicates before that. Applying to trunk. nathan -- Nathan Sidwell

Re: [PATCH,AIX] Fix issue with PRI*64 on AIX.

On Tue, Oct 10, 2017 at 10:31 AM, REIX, Tony wrote: > Hi David, > > Since the file ./gcc/go/go-system.h in GCC source code starts by: > > // go-system.h -- Go frontend inclusion of gcc header files -*- C++ -*- > // Copyright (C) 2009-2017 Free Software Foundation, Inc. > >

RE:[PATCH,AIX] Fix issue with PRI*64 on AIX.

Hi David, Since the file ./gcc/go/go-system.h in GCC source code starts by: // go-system.h -- Go frontend inclusion of gcc header files -*- C++ -*- // Copyright (C) 2009-2017 Free Software Foundation, Inc. // This file is part of GCC. ... I think it is SFS and not Google. Moreover, this

Re: X+Y < X iff Y<0 moved to match.pd

On Mon, 9 Oct 2017, Richard Biener wrote: On Sun, Oct 8, 2017 at 1:22 PM, Marc Glisse wrote: Hello, this moves (and extends a bit) one more transformation from fold-const.c to match.pd. The single_use restriction is necessary for consistency with the existing X+CST1 CMP

Re: [PATCH] libstdc++: istreambuf_iterator proxy (was: keep attached streambuf)

On 06/10/17 18:01 +0200, François Dumont wrote: On 03/10/2017 22:39, Petr Ovtchenkov wrote: On Thu, 28 Sep 2017 13:38:06 +0100 Jonathan Wakely wrote: On 28/09/17 15:06 +0300, Petr Ovtchenkov wrote: On Thu, 28 Sep 2017 11:34:25 +0100 Jonathan Wakely

Re: [PATCH] Enable ifunc attribute by default for ARM GNU/Linux

On Tue, 10 Oct 2017, Adhemerval Zanella wrote: > On 09/10/2017 19:20, Joseph Myers wrote: > > On Mon, 9 Oct 2017, Adhemerval Zanella wrote: > > > >> *-*-linux*) > >>case ${target} in > >> - aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-*) > >> + aarch64*-* |

Re: [PATCH,AIX] Fix issue with PRI*64 on AIX.

On Tue, Oct 10, 2017 at 5:09 AM, REIX, Tony wrote: > Description: > * This patch enables to build on AIX. > > Tests: > * AIX: Build: SUCCESS >- build made by means of gmake within GCC 8 trunk. > > ChangeLog: > * go-system.h : Enable to build on AIX. > (fix issue with

[PATCH] More SCEV TLC

This cuts the recursion in analyze_scalar_evolution_1 somewhat more making the flow easier to understand. In particular no_evolution_in_loop_p is replaced with a positive test on chrec_contains_symbols_defined_in_loop guarding further analysis after skipping overall effects of loops. I've also

Re: r253554 - in /trunk/gcc: ada/ChangeLog ada/exp_...

Hello Andreas, On 10/10/2017 04:44 AM, Andreas Schwab wrote: On Okt 09 2017, pmdero...@gcc.gnu.org wrote: 2017-10-09 Ed Schonberg * gnat.dg/class_wide4.adb, gnat.dg/class_wide4_pkg.ads, gnat.dg/class_wide4_pkg2.ads: New testcase. FAIL:

Re: [PATCH] Enable ifunc attribute by default for ARM GNU/Linux

On 09/10/2017 19:20, Joseph Myers wrote: > On Mon, 9 Oct 2017, Adhemerval Zanella wrote: > >> *-*-linux*) >> case ${target} in >> -aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-*) >> +aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-* >>

[PATCH] DECL_ASSEMBLER_NAME and friends

I have a patch cleaning up a bit of the C++ FE, which will involve hashing via DECL_ASSEMBLER_NAME. however, all the items in that hash are known to have it set, so its mapping to a function call is undesirable. This patch adds DECL_ASSEMBLER_NAME_RAW, which gets at the field directly. I

Re: [PATCH] Fix ICEs with ss{e,e2,se3} builtins with -mno-mmx (PR target/82483, take 2)

On Tue, Oct 10, 2017 at 1:11 PM, Jakub Jelinek wrote: > On Mon, Oct 09, 2017 at 09:47:49PM +0200, Jakub Jelinek wrote: >> > Hm, I remember there was similar patch for PR79565 [1], which seems >> > related. Does your patch also fix all builtins that HJ's patch touch? >> >> Ah, I

Re: [PATCH GCC][3/7]Don't skip renaming PHIs in loop nest with only one inner loop

On Mon, Oct 9, 2017 at 2:33 PM, Richard Biener wrote: > On Thu, Oct 5, 2017 at 3:16 PM, Bin Cheng wrote: >> Hi, >> Function rename_variables_in_bb skips renaming PHI nodes in loop nest if the >> outer loop has only one inner loop. This breaks loop

Re: Restore functional DONT_USE_BUILTIN_SETJMP support

> After verification, you are right: the problem is older but requires the > compiler to be configured with --enable-checking=yes. Thanks for confirming. The problem is present on x86-64/Linux too, I'll have a quick look later today. -- Eric Botcazou

[PATCH] PR libstdc++/82417 do not include C99 in strict modes

As an extension the C++ version of includes the C version, but that defines macros with non-reserved names that should not be defined in ISO C++. Only include the C header for non-strict modes, or for pre-C++11 (because C++98 doesn't mention at all). PR libstdc++/59087 PR

[PATCH] Update comment referring to status of LWG issue 111

A small tweak to correct an old comment. * include/bits/streambuf_iterator.h (istreambuf_iterator::equal): Update comment about NAD issue. Committed to trunk. commit 952424a1d1947d77348754d90fee8f4b65248bd7 Author: Jonathan Wakely Date: Tue Oct 10

[PATCH] Fix ICEs with ss{e,e2,se3} builtins with -mno-mmx (PR target/82483, take 2)

On Mon, Oct 09, 2017 at 09:47:49PM +0200, Jakub Jelinek wrote: > > Hm, I remember there was similar patch for PR79565 [1], which seems > > related. Does your patch also fix all builtins that HJ's patch touch? > > Ah, I wasn't aware of that patch. Will look in detail tomorrow. > > > [1]

Re: [PATCH][GCC] Simplification of 1U << (31 - x)

Thanks, I have made the changes to the patch. Also can someone please apply it for me. I do not have commit access. 2017-10-10 Sudakshina Das PR middle-end/80131 * match.pd: Simplify 1 << (C - x) where C = precision (x) - 1. 2017-10-10 Sudakshina Das

Re: Restore functional DONT_USE_BUILTIN_SETJMP support

> Le 10 oct. 2017 à 11:53, Eric Botcazou a écrit : > >> This cause >> >> % /opt/gcc/gcc8w/bin/g++ -std=c++11 -O2 -fnon-call-exceptions >> /opt/gcc/work/gcc/testsuite/g++.dg/pr62079.C -c -m32 >> /opt/gcc/work/gcc/testsuite/g++.dg/pr62079.C: In function 'int main()': >>

[PATCH] Simplify SCEV entry

This simplifies SCEV analyze_scalar_evolution_1 by removing what appeared to be dead code for the case of res != chrec_not_analyzed_yet. Adding a gcc_unrechable () turned up a rather serious bug though as in the loop pipeline we get a messed up SCEV cache if CFG cleanup renumbers blocks given

Re: Restore functional DONT_USE_BUILTIN_SETJMP support

> This cause > > % /opt/gcc/gcc8w/bin/g++ -std=c++11 -O2 -fnon-call-exceptions > /opt/gcc/work/gcc/testsuite/g++.dg/pr62079.C -c -m32 > /opt/gcc/work/gcc/testsuite/g++.dg/pr62079.C: In function 'int main()': > /opt/gcc/work/gcc/testsuite/g++.dg/pr62079.C:78:1: error: non-cold basic > block 5

[PATCH,AIX] Fix issue with PRI*64 on AIX.

Description: * This patch enables to build on AIX. Tests: * AIX: Build: SUCCESS - build made by means of gmake within GCC 8 trunk. ChangeLog: * go-system.h : Enable to build on AIX. (fix issue with PRIx64 and PRIu64) Cordialement, Tony Reix Bull - ATOS IBM Coop Architect & Technical

Re: r253554 - in /trunk/gcc: ada/ChangeLog ada/exp_...

On Okt 09 2017, pmdero...@gcc.gnu.org wrote: > 2017-10-09 Ed Schonberg > > * gnat.dg/class_wide4.adb, gnat.dg/class_wide4_pkg.ads, > gnat.dg/class_wide4_pkg2.ads: New testcase. FAIL: gnat.dg/class_wide4.adb (test for excess errors) Excess errors:

Re: Restore functional DONT_USE_BUILTIN_SETJMP support

> The attached patch replaces it with an ad-hoc definition of setjmp, … This cause % /opt/gcc/gcc8w/bin/g++ -std=c++11 -O2 -fnon-call-exceptions /opt/gcc/work/gcc/testsuite/g++.dg/pr62079.C -c -m32 /opt/gcc/work/gcc/testsuite/g++.dg/pr62079.C: In function 'int main()':

[committed] Fix return type on stack clash protection hook

Pointed out in IRC. The intent as well as the docs and prototype had the return type as a bool, but the default implementation used HOST_WIDE_INT. Opps. This fixes the default implementation to match the intent, docs & prototype. Bootstrapped and regression tested. Installing on the trunk as