Re: [PATCH] Fix store merging (PR tree-optimization/84503)

2018-02-21 Thread Richard Biener
On February 21, 2018 11:28:36 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The long comment above the new check_no_overlap function below should >hopefully explain the problem. coalesce_immediate_stores is splitting >the >stores from the same base into groups that we are going

Re: [PATCH] Fix TYPE_EMPTY_P handling - x86_64 ABI issue (PR target/84502)

2018-02-21 Thread Richard Biener
On February 21, 2018 11:37:20 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The following testcase shows that we set TYPE_EMPTY_P just one of the >possibly many variants of an aggregate type. >On the testcase, in one case (in the callee) we check TYPE_EMPTY_P on X >which is >the

Re: [PATCH] Fix pdftex miscompilation due to get_range_strlen (PR tree-optimization/84478)

2018-02-21 Thread Richard Biener
On February 21, 2018 4:25:14 AM GMT+01:00, Jeff Law wrote: >On 02/20/2018 04:59 PM, Martin Sebor wrote: >>> It would help if you explained why you think it is a good idea >>> ignoring the other phi arguments if you have one (or more) where you >can >>> determine length. >> >>

Re: [PATCH v2] RISC-V: Support for FreeBSD

2018-02-21 Thread Kito Cheng
Hi Jim: > I saw the email. I checked the FSF copyright list and see that it > hasn't been recorded yet. The FSF copyright clerk sometimes takes a > few weeks to respond. Hopefully this will be competed on the FSF side > soon. I don't family with copyright matters, so we can't commit this

Re: [Patch] Document __builtin_extend_pointer

2018-02-21 Thread Jeff Law
On 02/20/2018 10:33 AM, Steve Ellcey wrote: > While working on PR 83335 I proposed a change to a test case that > used __builtin_extend_pointer and Richared Earnshaw pointed out > that this builtin is not documented.  Since I could not find any > other (reasonable) way to generate an extended

Re: [PATCH] avoid bogus -Wstringop-truncation when inlining (PR 84480)

2018-02-21 Thread Jeff Law
On 02/21/2018 02:19 PM, Martin Sebor wrote: > The attached patch eliminates -Wstringop-truncation false > positives reported in bug 84480 - bogus -Wstringop-truncation > despite assignment with an inlined string literal.  It does > that by delegating early strncpy checks during folding to > the 

[PATCH 1/2] rs6000: Use brace blocks in define_insn

2018-02-21 Thread Segher Boessenkool
This patch changes the remaining cases in our machine description files to use brace blocks instead of double-quoted strings as the output control string. This increases readability by making the blocks look more like normal C code, mostly because backslash quoting is no longer needed. It also

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Damian Rouson
Hi Janne, To be more specific, the new OpenCoarrays test failures after applying the patch are the following ones:  image_fail_test_1 (Timeout)  image_fail_and_sync_test_2 (Timeout)  image_fail_and_sync_test_3 (Timeout)  image_fail_and_get_test_1 (Timeout) There

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-21 Thread Martin Sebor
On 02/13/2018 11:33 AM, Jason Merrill wrote: On Tue, Feb 13, 2018 at 1:00 PM, Martin Sebor wrote: On 02/13/2018 07:47 AM, Jason Merrill wrote: On Mon, Feb 12, 2018 at 6:39 PM, Martin Sebor wrote: I really don't think it's helpful to try to force

[PATCH] Fix TYPE_EMPTY_P handling - x86_64 ABI issue (PR target/84502)

2018-02-21 Thread Jakub Jelinek
Hi! The following testcase shows that we set TYPE_EMPTY_P just one of the possibly many variants of an aggregate type. On the testcase, in one case (in the callee) we check TYPE_EMPTY_P on X which is the type variant for the using type, and in another case we check it on the A type instead, which

Re: PR84229 part 1: Avoid cloning of functions that calls va_arg_pack

2018-02-21 Thread Jakub Jelinek
On Wed, Feb 21, 2018 at 08:09:28PM +0100, Jan Hubicka wrote: > --- ipa-cp.c (revision 257844) > +++ ipa-cp.c (working copy) > @@ -630,6 +630,24 @@ determine_versionability (struct cgraph_ >reason = "calls comdat-local function"; > } > > + /* Functions calling BUILT_IN_VA_ARG_PACK

[PATCH rs6000], Move Power 8 tests, fix ICE for vec_unsigned2, vec_signed2

2018-02-21 Thread Carl Love
GCC maintainers: Per discussions with Segher, we felt it would be best to move the vec_float2 test to a Power 8 test as it is only defined for Power 8 and beyond. In doing this, I found that compiling builtins-3-runnable.c with -mcpu=power7 then generated an ICE for vec_signed2 and vec_unsigned2.

Re: C++ PATCH to fix ICE with invalid cast (PR c++/84493)

2018-02-21 Thread Jason Merrill
OK. On Wed, Feb 21, 2018 at 5:36 AM, Marek Polacek wrote: > Here we can prevent a crash on invalid by using require_open where '{' is > expected. require_open uses cp_parser_require whereas consume_open has > an assert: > gcc_assert (tok->type == traits_t::open_token_type);

[PATCH] avoid bogus -Wstringop-truncation when inlining (PR 84480)

2018-02-21 Thread Martin Sebor
The attached patch eliminates -Wstringop-truncation false positives reported in bug 84480 - bogus -Wstringop-truncation despite assignment with an inlined string literal. It does that by delegating early strncpy checks during folding to the same machinery in tree-ssa-strlen that looks for a NUL

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Izaak Beekman
Reach out to Damian or me if you encounter any frustration. You should be all set with a recent version of CMake and MPICH or OpenMPI installed. It should look something like: git clone https://github.com/sourceryinstitute/OpenCoarrays cd OpenCoarrays mkdir build cd build export

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Janne Blomqvist
On Wed, Feb 21, 2018 at 10:18 PM, Damian Rouson wrote: > > > > > On February 21, 2018 at 11:35:47 AM, Janne Blomqvist > (blomqvist.ja...@gmail.com(mailto:blomqvist.ja...@gmail.com)) wrote: > >> PING >> >> Is anybody planning to work on this on the opencoarrays side?

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Janne Blomqvist
PING Is anybody planning to work on this on the opencoarrays side? Or do you prefer that this is just committed and you can sort it out on your own schedule? On Sat, Feb 10, 2018 at 11:20 PM, Janne Blomqvist wrote: > On Sat, Feb 10, 2018 at 9:34 PM, Damian Rouson >

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Damian Rouson
  On February 21, 2018 at 11:35:47 AM, Janne Blomqvist (blomqvist.ja...@gmail.com(mailto:blomqvist.ja...@gmail.com)) wrote: > PING > > Is anybody planning to work on this on the opencoarrays side? Or do > you prefer that this is just committed and you can sort it out on your > own

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

2018-02-21 Thread Jakub Jelinek
On Wed, Feb 21, 2018 at 08:33:21AM +0100, Martin Liška wrote: > >From 8f1783a9017ec06c578fd644e46168ec5763d5ca Mon Sep 17 00:00:00 2001 > From: marxin > Date: Tue, 20 Feb 2018 14:21:05 +0100 > Subject: [PATCH 3/3] Add "native" as a valid option value for -march= on i386 > (PR

Re: PR84229 part 1: Avoid cloning of functions that calls va_arg_pack

2018-02-21 Thread Jan Hubicka
> On Wed, Feb 21, 2018 at 08:09:28PM +0100, Jan Hubicka wrote: > > --- ipa-cp.c(revision 257844) > > +++ ipa-cp.c(working copy) > > @@ -630,6 +630,24 @@ determine_versionability (struct cgraph_ > >reason = "calls comdat-local function"; > > } > > > > + /* Functions

PR84229 part 1: Avoid cloning of functions that calls va_arg_pack

2018-02-21 Thread Jan Hubicka
Hi, this fixes first part of the issue in PR84229. The actual testcase dies because ipa-cp decides to cone function calling va_arg_pack which is later not inlined. Such functions works only when they are inlined and thus it makes no sense to inline them. I disabled cloning only for external

[PATCH, rs6000] tighten target statements for a p8 and p9 specific tests

2018-02-21 Thread Will Schmidt
Hi, Update the dg-requires statements for these tests to specify the target. These tests may otherwise fail on a system missing p9 assembler support. (Seen in a p6 environment). OK for trunk? Thanks, -Will [testsuite] 2018-02-21 Will Schmidt *

[PATCH, rs6000] Update altivec-7 testcase(s).

2018-02-21 Thread Will Schmidt
Hi, This patch moves the vsx related content from the altivec-7-be test into a new vsx-7-be test. This fixes up some test failures as seen on older power systems. OK for trunk? Thanks, Will [testsuite] 2018-02-21 Will Schmidt *

[PATCH, rs6000] fold-vec-mult* testcase updates for power9

2018-02-21 Thread Will Schmidt
Hi, An update for the fold-vec-mult-int128-p9.c test to include more of the instructions generated for a vec_mul() with a power9 target. [testsuite] 2018-02-21 Will Schmidt * fold-vec-mult-int128-p9.c: Add maddld insn to expected output. diff

Re: [PATCH] Fix pdftex miscompilation due to get_range_strlen (PR tree-optimization/84478)

2018-02-21 Thread Martin Sebor
On 02/20/2018 08:25 PM, Jeff Law wrote: On 02/20/2018 04:59 PM, Martin Sebor wrote: It would help if you explained why you think it is a good idea ignoring the other phi arguments if you have one (or more) where you can determine length. It's a heuristic that was meant just for the

Re: [PATCH] Fix pdftex miscompilation due to get_range_strlen (PR tree-optimization/84478, take 2 and 3)

2018-02-21 Thread Jakub Jelinek
On Tue, Feb 20, 2018 at 08:56:11PM -0700, Jeff Law wrote: > On 02/20/2018 02:34 PM, Jakub Jelinek wrote: > > On Tue, Feb 20, 2018 at 01:13:13PM -0700, Martin Sebor wrote: > >> A safer and even more conservative alternative that should be > >> equivalent to your approach while avoiding the sprintf

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

2018-02-21 Thread Jakub Jelinek
On Wed, Feb 21, 2018 at 03:19:22PM +0100, Martin Liška wrote: > On 02/21/2018 03:08 PM, Jakub Jelinek wrote: > > This just adds "native" as possible value for -march, but shouldn't it be > > also for -mtune, i.e. around line 4268? > > Thanks for note. There's updated version. > > Is it ok now? >

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

2018-02-21 Thread Martin Liška
On 02/21/2018 03:08 PM, Jakub Jelinek wrote: > This just adds "native" as possible value for -march, but shouldn't it be > also for -mtune, i.e. around line 4268? Thanks for note. There's updated version. Is it ok now? Thanks, Martin >From 980016be748b8f6a917f497d256c62a054bdece8 Mon Sep 17

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

2018-02-21 Thread Martin Liška
On 02/21/2018 10:23 AM, Kyrill Tkachov wrote: > Have you tested this with a native and a cross-compiler like the aarch64  > version? Yes, you tested that ;) I'm going to install the patch. Martin

Re: [PATCH PR82096][gcc-7, gcc-6] Backport: Fix ICE in int_mode_for_mode, at stor-layout.c:403 with arm-linux-gnueabi

2018-02-21 Thread Sudakshina Das
On 16/02/18 15:40, Sudakshina Das wrote: On 22/01/18 15:23, Richard Biener wrote: On Mon, Jan 22, 2018 at 4:10 PM, Sudakshina Das wrote: Hi This is a patch to backport r256526 and r256941 (Fix case fix) of trunk to fix emit_store_flag_force () function to fix the ICE. The

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

2018-02-21 Thread Kyrill Tkachov
On 21/02/18 09:53, Martin Liška wrote: On 02/21/2018 10:23 AM, Kyrill Tkachov wrote: Have you tested this with a native and a cross-compiler like the aarch64 version? No, I don't have a machine. Can you please do that? Sure, I've bootstrapped and tested it on arm-none-linux-gnueabihf and

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-21 Thread Uros Bizjak
On Wed, Feb 21, 2018 at 11:11 AM, Alexandre Oliva wrote: > On Feb 15, 2018, Szabolcs Nagy wrote: > >> i see assembler slow downs with these location view patches >> i opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84408 > > > [LVU] reset view at

PING: [PATCH] Use dlsym to check if libdl is needed for plugin

2018-02-21 Thread H.J. Lu
On Wed, Oct 18, 2017 at 5:25 PM, H.J. Lu wrote: > config/plugins.m4 has > > if test "$plugins" = "yes"; then > AC_SEARCH_LIBS([dlopen], [dl]) > fi > > Plugin uses dlsym, but libasan.so only intercepts dlopen, not dlsym: > > [hjl@gnu-tools-1 binutils-text]$ nm -D

C++ PATCH to fix ICE with invalid cast (PR c++/84493)

2018-02-21 Thread Marek Polacek
Here we can prevent a crash on invalid by using require_open where '{' is expected. require_open uses cp_parser_require whereas consume_open has an assert: gcc_assert (tok->type == traits_t::open_token_type); which triggers here. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2018-02-21

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-21 Thread Alexandre Oliva
On Jan 24, 2018, Jakub Jelinek wrote: >> --- a/gcc/tree-ssa-live.c >> +++ b/gcc/tree-ssa-live.c >> @@ -520,6 +520,11 @@ remove_unused_scope_block_p (tree scope, bool >> in_ctor_dtor_block) >> else if (!BLOCK_SUPERCONTEXT (scope) >> || TREE_CODE (BLOCK_SUPERCONTEXT (scope)) ==

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-21 Thread Alexandre Oliva
On Feb 15, 2018, Szabolcs Nagy wrote: > i see assembler slow downs with these location view patches > i opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84408 [LVU] reset view at function entry, omit views at line zero Location views might be associated with

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

2018-02-21 Thread Martin Liška
On 02/21/2018 10:23 AM, Kyrill Tkachov wrote: > Have you tested this with a native and a cross-compiler like the aarch64  > version? No, I don't have a machine. Can you please do that? Thanks, Martin

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

2018-02-21 Thread Kyrill Tkachov
Hi Martin, On 21/02/18 07:34, Martin Liška wrote: Hi. This is equivalent patch for ARM target. Thanks for fixing this! Ready for trunk? Have you tested this with a native and a cross-compiler like the aarch64 version? Thanks, Martin From 656a883bc5239439ba80743f15a8df704501ee71 Mon

Re: [PATCH] Fix pdftex miscompilation due to get_range_strlen (PR tree-optimization/84478)

2018-02-21 Thread Jakub Jelinek
On Tue, Feb 20, 2018 at 08:31:06PM -0700, Jeff Law wrote: > On 02/20/2018 05:14 PM, Jakub Jelinek wrote: > > On Tue, Feb 20, 2018 at 04:59:12PM -0700, Martin Sebor wrote: > >>> It would help if you explained why you think it is a good idea > >>> ignoring the other phi arguments if you have one (or