Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

While reviewing other related bugs I noticed 83502. This patch doesn't fix the first test case in the bug (attribute noinline vs always_inline). Somehow those are still copied from the primary to the specialization and can cause conflicts. Hmm, that's odd. Why is that? Because

Re: [PATCH PR other/77609] Let the assembler choose ELF section types for miscellaneous named sections

On Sat, Feb 24, 2018 at 1:54 AM, Roland McGrath via gcc-patches wrote: > Anybody want to look at this? > > It rebases identically on today's trunk. I'd like to commit it to > trunk and gcc-7-branch and gcc-6-branch ideally. You are recreating the conditions used in

C++ PATCH for c++/84560, ICE capturing multi-dimensional VLA

The code was already there to give an error for this case, we just weren't hitting it because array_of_runtime_bound_p was incorrectly returning true. Tested x86_64-pc-linux-gnu, applying to trunk. commit 1106dfa9e9df6e4dddb75c50db57cff953017fc7 Author: Jason Merrill Date:

C++ PATCH for c++/84441, ICE with base initialized from ?:

A while back I added unsafe_copy_elision_p to catch cases where we don't want to initialize a base subobject directly from a call because it might clobber data packed into the tail padding of the base. Later I extended that function to look into COMPOUND_EXPR. This patch further adjusts it to

C++ PATCH for c++/84520, ICE with generic lambda in NSDMI

lambda_expr_this_capture assumes that we can find the fake 'this' inserted while parsing an NSDMI, but it isn't there if we are instantiating, rather than parsing, a generic lambda. Tested x86_64-pc-linux-gnu, applying to trunk/7/6. commit 9c64c953f0595e88cd911d488a415c8568934864 Author: Jason

Re: [PATCH] Correct debug for -mcall-ms2sysv-xlogues stubs (PR target/83917, take 2)

On 02/26/2018 02:20 AM, Jakub Jelinek wrote: > On Sun, Feb 25, 2018 at 05:56:28PM -0600, Daniel Santos wrote: >>> --- libgcc/config/i386/i386-asm.h.jj2018-01-03 10:42:56.317763517 >>> +0100 >>> +++ libgcc/config/i386/i386-asm.h 2018-02-22 15:33:43.812922298 +0100 >>> @@ -27,8 +27,47

Re: [PING] [PATCH] consider successor blocks when avoiding -Wstringop-truncation (PR 84468)

On 02/26/2018 12:13 PM, Jeff Law wrote: On 02/24/2018 05:11 PM, Martin Sebor wrote: Attached is an updated patch with a fix for a bad assumption exposed by building the linux kernel. On 02/19/2018 07:50 PM, Martin Sebor wrote: PR 84468 points out a false positive in -Wstringop-truncation in

Re: [PATCH] [Microblaze]: PIC Data Text Relative

On 02/25/2018 11:44 PM, Andrew Guirguis wrote: Dears, Kindly find attached the patch bundle for Microblaze '-mpic-data-text-relative' feature. Description of the feature in the following link: https://github.com/andrewsadek/microblaze-pic-data-text-rel/blob/pic_data_text_rel/README.md

[PATCH] PR c/46921 Lost side effect when struct initializer expression uses comma operator

This patch fixes improper handling of comma operator expression in a struct field initializer as described in: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46921 Currently, function output_init_element () does not evaluate the left hand expression in a comma operator that's used for a struct

[PATCH/testsuite] avoid test failures with -fpic

Compiling a number of tests with -fpic results in failures because the tests make use of non-inline, extern helper functions defined within, and these helpers must be assumed to have been superimposed elsewhere. For example: https://gcc.gnu.org/ml/gcc-testresults/2018-02/msg01762.html I took a

Re: [v3 PATCH] Implement the missing bits of LWG 2769

On 26 February 2018 at 22:52, Jonathan Wakely wrote: > But those are just stylistic issues, the technical side of the patch > is fine. I had to look up why we had two overloads for any_cast(any&&) > and that seems to be a leftover from experimental::any, so thanks for >

Re: [PATCH][AArch64] PR84114: Avoid reassociating FMA

On Thu, Feb 22, 2018 at 11:38:03AM +, Wilco Dijkstra wrote: > As discussed in the PR, the reassociation phase runs before FMAs are formed > and so can significantly reduce FMA opportunities. Although reassociation > could be switched off, it helps in many cases, so a better alternative is to

C++ PATCH for c++/84559, ICE with constexpr VLA

Clang rejects this testcase saying that the VLA is a non-literal type, but I think we don't want that; we want to allow VLAs in a constexpr function, where the length can be constant during constexpr evaluation. In this case, however, we are dealing with a constexpr variable rather than a

Re: [C++ PATCH] Fix ICE in cxx_eval_vec_init_1 (PR c++/84558)

OK. On Mon, Feb 26, 2018 at 2:57 PM, Jakub Jelinek wrote: > Hi! > > The PR70001 optimization in cxx_eval_vec_init_1 uses > initializer_constant_valid_p (eltinit, TREE_TYPE (eltinit)) > which doesn't work if eltinit is NULL. This can happen if > *non_constant_p is true, but

Re: [PATCH] expand description of poly_int conversions

Martin Sebor writes: > On 02/26/2018 12:45 PM, Richard Sandiford wrote: >> Martin Sebor writes: >>> Richard, >>> >>> If you agree, I'd like to update the conversion section of >>> the poly_int manual to make the conversion to make it clearer >>> that the

Re: [PATCH] libstdc++-v3: Check for TLS support on mingw

Apologies if you get this mail multiple times, I'm having some trouble sending mail to @gcc.gnu.org lists. On 19/02/18 09:59 +0100, Hugo Beauzée-Luyssen wrote: > libstdc++-v3: Check for TLS support on mingw > > 2018-02-16 Hugo Beauzée-Luyssen > >* crossconfig.m4: Check

Re: [v3 PATCH] Implement the missing bits of LWG 2769

On 25/02/18 23:22 +0200, Ville Voutilainen wrote: Tested partially on Linux-x64, will test with the full suite on Linux-PPC64. Ok for trunk and the gcc-7 branch? This is theoretically a breaking change for the branch, but the committee has decided that they don't want the support for

[PATCH] i386: Don't generate alias for function return thunk

Function return thunks shouldn't be aliased to indirect branch thunks since indirect branch thunks are placed in COMDAT section and a COMDAT section with indirect branch may not have function return thunk. This patch generates function return thunks directly. Tested on i686 and x86-64. OK for

[PATCH] Fix ICE with -mforce-indirect-call (PR target/84564)

Hi! While this isn't a regression, it is ICE in newly added feature and so should be fixed too. The problem is that with -mforce-indirect-call even direct calls are emitted as indirect, and if we have in 32-bit mode a direct call to a regparm(3) function or a direct call to a function we've

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

On Mon, Feb 26, 2018 at 10:32:27AM -0700, Martin Sebor wrote: > That attached revision updates the pass to directly convert > the poly64_int into offset_int using the API suggested by > Richard (thanks again). As discussed below, I've made no > other changes. > > Jakub, if you still have

Re: [PATCH] expand description of poly_int conversions

On 02/26/2018 12:45 PM, Richard Sandiford wrote: Martin Sebor writes: Richard, If you agree, I'd like to update the conversion section of the poly_int manual to make the conversion to make it clearer that the to_constant() function can be used even with class types like

[PATCH] PR fortran/51434 -- ICE in gfc_simplify_transfer

All, The attached patch fixes an ICE that occurs in gfc_simplify_tranfer. The code that causes the problem is if (!gfc_is_constant_expr (source) || (gfc_init_expr_flag && !gfc_is_constant_expr (mold)) || !gfc_is_constant_expr (size)) return NULL; in particular

[committed] Fix C++ OpenMP parsing ICE (PR c++/84557)

Hi! In C++, the OpenMP variable lists are lists of id-expressions, which include template-ids; for those cp_parser_lookup_name_simple ICEs though, so this patch just calls that for identifiers similarly to other cp_parser_lookup_name_simple callers. Bootstrapped/regtested on x86_64-linux and

Re: [PATCH][committed][PR tree-optimization/82123] 01/06 Do nothing in EVRP analyzer is not optimizing

On 02/26/2018 05:27 AM, Richard Biener wrote: > On Tue, Feb 20, 2018 at 7:49 PM, Jeff Law wrote: >> This is part #1 of the patches to fix 81592/82123. The changes aren't >> particularly large or invasive, but I already had them broken down >> internally into distinct chunks, so

Re: [PATCH] expand description of poly_int conversions

Martin Sebor writes: > Richard, > > If you agree, I'd like to update the conversion section of > the poly_int manual to make the conversion to make it clearer > that the to_constant() function can be used even with class > types like offset_int besides scalars. > > Also, when

Re: [PATCH] Correct debug for -mcall-ms2sysv-xlogues stubs (PR target/83917, take 2)

On 02/22/2018 07:56 AM, Jakub Jelinek wrote: > Hi! > > On Sat, Jan 20, 2018 at 06:01:16PM -0600, Daniel Santos wrote: >> Thanks.  I like the idea of commonizing the macros for consistency. > > Didn't see a progress on this P3 for a while, so I've written this > version of the patch; no tests

Re: [PING] [PATCH] consider successor blocks when avoiding -Wstringop-truncation (PR 84468)

On 02/24/2018 05:11 PM, Martin Sebor wrote: > Attached is an updated patch with a fix for a bad assumption > exposed by building the linux kernel. > > On 02/19/2018 07:50 PM, Martin Sebor wrote: >> PR 84468 points out a false positive in -Wstringop-truncation >> in code like this: >> >>   struct

C++ PATCH for c++/84551, ICE with concepts and DEBUG_BEGIN_STMT

DEBUG_BEGIN_STMT was confusing the concepts machinery, and it isn't useful in concepts, which are never expanded. Tested x86_64-pc-linux-gnu, applying to trunk. commit 8a2a7e8672b17af0231c82b6f3d4429efddec0d6 Author: Jason Merrill Date: Mon Feb 26 13:48:34 2018 -0500

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

On 02/26/2018 10:39 AM, Jakub Jelinek wrote: On Mon, Feb 26, 2018 at 10:32:27AM -0700, Martin Sebor wrote: That attached revision updates the pass to directly convert the poly64_int into offset_int using the API suggested by Richard (thanks again). As discussed below, I've made no other

[PATCH] expand description of poly_int conversions

Richard, If you agree, I'd like to update the conversion section of the poly_int manual to make the conversion to make it clearer that the to_constant() function can be used even with class types like offset_int besides scalars. Also, when testing this I also tried converting poly64_int into

Re: [PATCH] i386: Update -mfunction-return= for return with pop

On Mon, Feb 26, 2018 at 7:44 AM, Jan Hubicka wrote: >> On Mon, Feb 26, 2018 at 7:06 AM, Jan Hubicka wrote: >> >> On Mon, Feb 26, 2018 at 2:58 AM, Jan Hubicka wrote: >> >> >> On Mon, Feb 26, 2018 at 2:05 AM, Martin Liška wrote: >>

Re: [C++ Patch] PR 84540 ("[6/7/8 Regression] ICE with alignas in variadic template")

OK. On Mon, Feb 26, 2018 at 11:56 AM, Paolo Carlini wrote: > Hi, > > this regression is an ICE on valid, and seems rather easy to analyze: both > apply_late_template_attributes and tsubst_attributes don't appear to cope > correctly with tsubst_attribute returning

Re: C++ PATCH to fix ICE with constexpr operator"" (PR c++/84325)

On Mon, Feb 26, 2018 at 12:42 PM, Marek Polacek wrote: > The original testcase was invalid but I added seconds's constructor and made > time_to_wait inline and now the testcase is accepted by clang++. > > But we ICE in replace_placeholders_r because we were checking

Re: [PATCH] Fix bootstrap with GCC 3.4 (and likely anything < 4.4 except 4.2.[0-3]) (PR bootstrap/84405)

Hi! On Sat, Feb 17, 2018 at 10:08:48AM +0100, Jakub Jelinek wrote: > Note, this doesn't work, as G++ <= 4.2 rejects: > template > struct S > { > char __attribute__ ((__aligned__ (__alignof__ (value_type buf[sizeof > (value_type)]; > }; > > S s; > > with: > error: requested alignment is

Re: [PATCH, rs6000] GCC 7 backport for vec_insert4b, vec_extract4b support

On Mon, Feb 26, 2018 at 08:26:43AM -0800, Carl Love wrote: > > 2018-02-26 Carl Love > > *gcc.target/powerpc/builtins-7-p9-runnable.c: New runnable test file > for the ABI definitions for vec_extract4b and vec_insert4b. (Space after the asterisk). This is just

C++ PATCH to fix ICE with constexpr operator"" (PR c++/84325)

The original testcase was invalid but I added seconds's constructor and made time_to_wait inline and now the testcase is accepted by clang++. But we ICE in replace_placeholders_r because we were checking TREE_CONSTANT on a type. With this patch we accept the code without crashing. (We require

Re: [PATCH] Fix formatting of -ftime-report.

On 02/22/2018 05:13 AM, Martin Liška wrote: > Hi. > > It fixes column formatting of time report. Please take a look at attached > samples. Hope it can go in even though we are in stage4? > > Thanks, > Martin > > gcc/ChangeLog: > > 2018-02-22 Martin Liska > > *

Re: [PATCH, rs6000] Update altivec-7 testcase(s).

On Fri, Feb 23, 2018 at 10:35:43AM -0600, Will Schmidt wrote: > On Thu, 2018-02-22 at 12:06 -0600, Segher Boessenkool wrote: > > On Wed, Feb 21, 2018 at 11:33:14AM -0600, Will Schmidt wrote: > > > This patch moves the vsx related content from the altivec-7-be test into > > > a new vsx-7-be test.

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

That attached revision updates the pass to directly convert the poly64_int into offset_int using the API suggested by Richard (thanks again). As discussed below, I've made no other changes. Jakub, if you still have concerns that the false positive suppression logic isn't sufficiently effective

Re: [PATCH, rs6000] Tests for builtin vec_neg updated

Hi Carl, On Thu, Feb 22, 2018 at 07:41:10AM -0800, Carl Love wrote: > * gcc.target/powerpc/builtins-3.c: Move vec_neg builtin tests to > Power 8 test file. > * gcc.target/powerpc/builtins-3-p8.c: Add vec_neg builtin tests. > *

C++ PATCH for c++/84447, ICE with deleted inherited ctor and default arg

Normally, when we call an inherited constructor we determine which base constructor it actually calls, and then use that information for instantiating the default arguments later. But if the base constructor is deleted, that process breaks down: the simulated call fails, so we don't update the

[C++ Patch] PR 84540 ("[6/7/8 Regression] ICE with alignas in variadic template")

Hi, this regression is an ICE on valid, and seems rather easy to analyze: both apply_late_template_attributes and tsubst_attributes don't appear to cope correctly with tsubst_attribute returning NULL_TREE. That, in turn, seems normal for an empty pack - as in the testcases - given the

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

> On Mon, Feb 26, 2018 at 7:47 AM, Jan Hubicka wrote: > > Hi, > > my main concern about the patch is that we now have > > -mindirect-branch=thunk-extern > > which is intended to work well and is used by kernel, but we also have > > other modes > > that are documented and as such

Fix PR rtl-optimization/83496

(relax_delay_slots): Likewise. (update_reg_unused_notes): Rename REDUNDANT_INSN to OTHER_INSN. 2018-02-26 Eric Botcazou <ebotca...@adacore.com> * gcc.c-torture/execute/20180226-1.c: New test. -- Eric Botcazou/* PR rtl-optimization/83496 */ /* Reported by Hauke Mehrtens <

[PATCH, rs6000] GCC 7 backport for vec_insert4b, vec_extract4b support

GCC maintainers: The following patch is a back port for the GCC 7 branch of mainline commit 257747. The mainline commit added support for builtins vec_insert4b and vec_extract4b. This is the first of two patches. This patch adds the ABI specified builtin instances. A second patch to be posted

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

On Mon, Feb 26, 2018 at 7:47 AM, Jan Hubicka wrote: > Hi, > my main concern about the patch is that we now have > -mindirect-branch=thunk-extern > which is intended to work well and is used by kernel, but we also have other > modes > that are documented and as such they should

Re: [PATCH][committed] Fix ICE in maybe_record_trace_start

On 02/23/2018 04:59 PM, Jeff Law wrote: On 02/22/2018 03:59 AM, Tom de Vries wrote: On 02/12/2018 07:32 PM, Jeff Law wrote: diff --git a/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c b/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c new file mode 100644 index 000..0ca0b9f034b

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

Hi, my main concern about the patch is that we now have -mindirect-branch=thunk-extern which is intended to work well and is used by kernel, but we also have other modes that are documented and as such they should work but they may lead to invalid unwind info (or did I miss anything imporant

Re: [PATCH] i386: Update -mfunction-return= for return with pop

> On Mon, Feb 26, 2018 at 7:06 AM, Jan Hubicka wrote: > >> On Mon, Feb 26, 2018 at 2:58 AM, Jan Hubicka wrote: > >> >> On Mon, Feb 26, 2018 at 2:05 AM, Martin Liška wrote: > >> >> > On 02/25/2018 02:37 AM, H.J. Lu wrote: > >> >> >> PR

Fix PR debug/84545

This fixes the slew of -fcompare-debug regressions present in the testsuite for targets with delay slots and caused by REG_CALL_ARG_LOCATION notes still present in the .final dumps. Tested on SPARC64/Linux and x86-64/Linux, applied on the mainline as obvious. 2018-02-26 Eric Botcazou

Re: [PATCH] i386: Update -mfunction-return= for return with pop

On Mon, Feb 26, 2018 at 7:06 AM, Jan Hubicka wrote: >> On Mon, Feb 26, 2018 at 2:58 AM, Jan Hubicka wrote: >> >> On Mon, Feb 26, 2018 at 2:05 AM, Martin Liška wrote: >> >> > On 02/25/2018 02:37 AM, H.J. Lu wrote: >> >> >> PR target/r84530 >>

Re: [PATCH] i386: Update -mfunction-return= for return with pop

> On Mon, Feb 26, 2018 at 2:58 AM, Jan Hubicka wrote: > >> On Mon, Feb 26, 2018 at 2:05 AM, Martin Liška wrote: > >> > On 02/25/2018 02:37 AM, H.J. Lu wrote: > >> >> PR target/r84530 > >> > > >> > Just a nit I've noticed: > >> > > >> > s/r84530/84530 > >> >

Re: Make fix for PR 83965 handle SLP reduction chains

On Mon, Feb 26, 2018 at 3:37 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Tue, Feb 20, 2018 at 5:53 PM, Richard Sandiford >> wrote: >>> This patch prevents pattern-matching of fold-left SLP

Re: Make fix for PR 83965 handle SLP reduction chains

Richard Biener writes: > On Tue, Feb 20, 2018 at 5:53 PM, Richard Sandiford > wrote: >> This patch prevents pattern-matching of fold-left SLP reduction chains, >> which the previous patch for 83965 didn't handle properly. It only >>

RE: [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs

Tom de Vries writes: > On 02/26/2018 12:00 PM, Matthew Fortune wrote: > > Tom de Vries writes: > >> On 01/08/2018 05:32 PM, Tom de Vries wrote: > >>> On 12/18/2017 05:57 PM, Vladimir Makarov wrote: > > > On 12/15/2017 06:25 AM, Tom

Re: [C++ Patch] PR 84533 ("[7/8 Regression] ICE with duplicate enum value")

OK. On Mon, Feb 26, 2018 at 5:19 AM, Paolo Carlini wrote: > Hi, > > this ICE on invalid happens only in c++17 mode, when > redeclaration_error_message performs an additional check which only makes > sense for data members. Thus the fix is easy: avoid checking >

Re: [C++ Patch] Define build_capture_proxy as static

OK. On Mon, Feb 26, 2018 at 5:22 AM, Paolo Carlini wrote: > Hi, > > today noticed this straightforward nit trivial enough for this stage? > > Thanks, Paolo. > > / >

Re: C++ PATCH to fix ICE with suggestions (PR c++/84537)

OK. On Mon, Feb 26, 2018 at 4:44 AM, Marek Polacek wrote: > Here error_mark_node leaks all the way to edit_distance_traits::get_string > which crashed, so let's not try to give a suggestion for an error node in > the first place. > > Bootstrapped/regtested on x86_64-linux, ok

Re: [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs

On 02/26/2018 12:00 PM, Matthew Fortune wrote: Tom de Vries writes: On 01/08/2018 05:32 PM, Tom de Vries wrote: On 12/18/2017 05:57 PM, Vladimir Makarov wrote: On 12/15/2017 06:25 AM, Tom de Vries wrote: Proposed Solution: The patch addresses the problem, by: -

Re: [PATCH] Fix bootstrap with GCC 3.4 (and likely anything < 4.4 except 4.2.[0-3]) (PR bootstrap/84405)

On Mon, Feb 26, 2018 at 01:15:45PM +0100, Richard Biener wrote: > > I'd like to ping this patch, or if it isn't acceptable, at least the vec.h > > part of it which isn't really more complex than what we have right now. > > So BROKEN_VALUE_INITIALIZATION doesn't really mean it's "broken" but >

Re: Fix slow value range hash

On Mon, Feb 26, 2018 at 12:04:53PM +0100, Jan Hubicka wrote: > Hi, > this is patch Jakub posted to IRC while discussing slow ipa-cp jump function > streaming. The problem is that hash hashes types as iterative types but later > compares them as pointers. Iterative hash is trying to make

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

On Wed, Feb 21, 2018 at 11:32 AM, Alexandre Oliva wrote: > On Jan 24, 2018, Jakub Jelinek wrote: > >>> --- a/gcc/tree-ssa-live.c >>> +++ b/gcc/tree-ssa-live.c >>> @@ -520,6 +520,11 @@ remove_unused_scope_block_p (tree scope, bool >>> in_ctor_dtor_block) >>>

Re: [PATCH] Fix bootstrap with GCC 3.4 (and likely anything < 4.4 except 4.2.[0-3]) (PR bootstrap/84405)

On Mon, 26 Feb 2018, Jakub Jelinek wrote: > On Mon, Feb 26, 2018 at 01:15:45PM +0100, Richard Biener wrote: > > > I'd like to ping this patch, or if it isn't acceptable, at least the vec.h > > > part of it which isn't really more complex than what we have right now. > > > > So

Re: [PATCH][committed][PR tree-optimization/82123] 01/06 Do nothing in EVRP analyzer is not optimizing

On Tue, Feb 20, 2018 at 7:49 PM, Jeff Law wrote: > This is part #1 of the patches to fix 81592/82123. The changes aren't > particularly large or invasive, but I already had them broken down > internally into distinct chunks, so I'm going to send them out that way. > > This patch

Re: Make fix for PR 83965 handle SLP reduction chains

On Tue, Feb 20, 2018 at 5:53 PM, Richard Sandiford wrote: > This patch prevents pattern-matching of fold-left SLP reduction chains, > which the previous patch for 83965 didn't handle properly. It only > stops the last statement in the group from being matched, but

Re: [PATCH] Fix bootstrap with GCC 3.4 (and likely anything < 4.4 except 4.2.[0-3]) (PR bootstrap/84405)

On Mon, 26 Feb 2018, Jakub Jelinek wrote: > Hi! > > On Sat, Feb 17, 2018 at 10:08:48AM +0100, Jakub Jelinek wrote: > > Note, this doesn't work, as G++ <= 4.2 rejects: > > template > > struct S > > { > > char __attribute__ ((__aligned__ (__alignof__ (value_type buf[sizeof > >

Re: Patch ping (Re: [PATCH PR82965/PR83991]Fix invalid profile count in vectorization peeling)

Ping^2 Thanks, bin On Mon, Feb 19, 2018 at 5:14 PM, Jakub Jelinek wrote: > Hi! > > Honza, do you think you could have a look at this P1 fix? > > Thanks. > > On Wed, Jan 31, 2018 at 10:03:51AM +, Bin Cheng wrote: >> Hi, >> This patch fixes invalid profile count information

[committed] Add testcase for already fixed PR c++/84556

Hi! This ICE got fixed already in r257820, but more testsuite coverage doesn't hurt. 2018-02-26 Jakub Jelinek PR c++/84556 * g++.dg/gomp/pr84556.C: New test. * g++.dg/vect/pr84556.cc: New test. --- gcc/testsuite/g++.dg/gomp/pr84556.C.jj

Re: [PATCH] i386: Update -mfunction-return= for return with pop

On Mon, Feb 26, 2018 at 2:58 AM, Jan Hubicka wrote: >> On Mon, Feb 26, 2018 at 2:05 AM, Martin Liška wrote: >> > On 02/25/2018 02:37 AM, H.J. Lu wrote: >> >> PR target/r84530 >> > >> > Just a nit I've noticed: >> > >> > s/r84530/84530 >> >> Fixed. >> >> --

Re: Fix slow value range hash

On Mon, Feb 26, 2018 at 12:12:21PM +0100, Jan Hubicka wrote: > > On Mon, Feb 26, 2018 at 12:04:53PM +0100, Jan Hubicka wrote: > > > Hi, > > > this is patch Jakub posted to IRC while discussing slow ipa-cp jump > > > function > > > streaming. The problem is that hash hashes types as iterative

Re: Fix slow value range hash

> On Mon, Feb 26, 2018 at 12:04:53PM +0100, Jan Hubicka wrote: > > Hi, > > this is patch Jakub posted to IRC while discussing slow ipa-cp jump function > > streaming. The problem is that hash hashes types as iterative types but > > later > > compares them as pointers. Iterative hash is trying to

Re: [PATCH] PR gcc/68256 Defining TARGET_USE_CONSTANT_BLOCKS_P causes go bootstrap failure on aarch64.

On Fri, Feb 16, 2018 at 6:18 PM, wrote: > From: Vladimir Mezentsev > > Ramana Radhakrishnan made a workaround in gcc/config/aarch64/aarch64.c to > resolve > bootstrap comparison failure (2015-11-10, commit >

Fix slow value range hash

Hi, this is patch Jakub posted to IRC while discussing slow ipa-cp jump function streaming. The problem is that hash hashes types as iterative types but later compares them as pointers. Iterative hash is trying to make semantically equivalent types really equivalent. Alternatively we may try to

RE: [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs

Tom de Vries writes: > On 01/08/2018 05:32 PM, Tom de Vries wrote: > > On 12/18/2017 05:57 PM, Vladimir Makarov wrote: > >> > >> > >> On 12/15/2017 06:25 AM, Tom de Vries wrote: > >>> > >>> Proposed Solution: > >>> > >>> The patch addresses the problem, by: > >>> - marking

Re: [Patch fortran] PR32957 - C/Fortran interoperability and -fdefault-integer-8

Thanks for the quick review, committed as r257985. I have spotted a few similar issues in my recent testing and I have problem with gfortran.dg/bind_c_usage_10.f03 when using -fdefault-integer-8: /opt/gcc/_clean/gcc/testsuite/gfortran.dg/bind_c_usage_10.f03:66:31: integer(c_int) function

Re: [Patch] Fix lto-wrapper link flags

On Mon, Feb 19, 2018 at 11:11 AM, Christophe Lyon wrote: > Hi, > > I think there's a typo in gcc/Makefile.in, where lto-wrapper is linked > using $(ALL_COMPILERFLAGS) while it should be $(ALL_LINKERFLAGS). > > I noticed this while playing with linker flags, and not

Re: [PATCH] i386: Update -mfunction-return= for return with pop

> On Mon, Feb 26, 2018 at 2:05 AM, Martin Liška wrote: > > On 02/25/2018 02:37 AM, H.J. Lu wrote: > >> PR target/r84530 > > > > Just a nit I've noticed: > > > > s/r84530/84530 > > Fixed. > > -- > H.J. > From f08b8721ed038cefcee5a0bb1329b90a2d322269 Mon Sep 17 00:00:00

Re: [PATCH] Correct debug for -mcall-ms2sysv-xlogues stubs (PR target/83917, take 2)

On Sun, Feb 25, 2018 at 05:56:28PM -0600, Daniel Santos wrote: > > --- libgcc/config/i386/i386-asm.h.jj2018-01-03 10:42:56.317763517 > > +0100 > > +++ libgcc/config/i386/i386-asm.h 2018-02-22 15:33:43.812922298 +0100 > > @@ -27,8 +27,47 @@ see the files COPYING3 and COPYING.RUNTI > >

Re: [PATCH] Fix up compound literal handling in C FE (PR sanitizer/84307)

On Mon, Feb 26, 2018 at 11:00:48AM +0100, Martin Liška wrote: > On 02/14/2018 11:03 PM, Joseph Myers wrote: > > On Wed, 14 Feb 2018, Jakub Jelinek wrote: > > > >> 2018-02-13 Jakub Jelinek > >> > >>PR sanitizer/84340 > >>* c-decl.c (build_compound_literal): Call

[C++ Patch] Define build_capture_proxy as static

Hi, today noticed this straightforward nit trivial enough for this stage? Thanks, Paolo. / 2018-02-26 Paolo Carlini * lambda.c (build_capture_proxy): Define static. * cp-tree.h (build_capture_proxy): Remove. Index: cp-tree.h

[C++ Patch] PR 84533 ("[7/8 Regression] ICE with duplicate enum value")

Hi, this ICE on invalid happens only in c++17 mode, when redeclaration_error_message performs an additional check which only makes sense for data members. Thus the fix is easy: avoid checking DECL_DECLARED_CONSTEXPR_P on CONST_DECLs. Tested x86_64-linux. Thanks, Paolo.

Re: [PATCH] i386: Update -mfunction-return= for return with pop

On Mon, Feb 26, 2018 at 2:05 AM, Martin Liška wrote: > On 02/25/2018 02:37 AM, H.J. Lu wrote: >> PR target/r84530 > > Just a nit I've noticed: > > s/r84530/84530 Fixed. -- H.J. From f08b8721ed038cefcee5a0bb1329b90a2d322269 Mon Sep 17 00:00:00 2001 From: "H.J. Lu"

Re: Mising Patch #2 from the RISC-V v3 Submission

On Feb 15 2018, Palmer Dabbelt wrote: > On Mon, 12 Feb 2018 15:18:39 PST (-0800), Jim Wilson wrote: >> On 02/12/2018 03:23 AM, Andreas Schwab wrote: >>> On Feb 06 2017, Palmer Dabbelt wrote: >>> +/* Because RISC-V only has word-sized atomics, it

Re: [PATCH] Fix up compound literal handling in C FE (PR sanitizer/84307)

On 02/26/2018 11:04 AM, Jakub Jelinek wrote: > On Mon, Feb 26, 2018 at 11:00:48AM +0100, Martin Liška wrote: >> On 02/14/2018 11:03 PM, Joseph Myers wrote: >>> On Wed, 14 Feb 2018, Jakub Jelinek wrote: >>> 2018-02-13 Jakub Jelinek PR sanitizer/84340 *

Re: [PATCH] i386: Update -mfunction-return= for return with pop

On 02/25/2018 02:37 AM, H.J. Lu wrote: > PR target/r84530 Just a nit I've noticed: s/r84530/84530 Martin

Re: [PATCH] Fix up compound literal handling in C FE (PR sanitizer/84307)

On 02/14/2018 11:03 PM, Joseph Myers wrote: > On Wed, 14 Feb 2018, Jakub Jelinek wrote: > >> 2018-02-13 Jakub Jelinek >> >> PR sanitizer/84340 >> * c-decl.c (build_compound_literal): Call pushdecl (decl) even when >> it is not TREE_STATIC. >> * c-typeck.c

C++ PATCH to fix ICE with suggestions (PR c++/84537)

Here error_mark_node leaks all the way to edit_distance_traits::get_string which crashed, so let's not try to give a suggestion for an error node in the first place. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2018-02-26 Marek Polacek PR c++/84537

Re: [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs

On 01/08/2018 05:32 PM, Tom de Vries wrote: On 12/18/2017 05:57 PM, Vladimir Makarov wrote: On 12/15/2017 06:25 AM, Tom de Vries wrote: Proposed Solution: The patch addresses the problem, by: - marking the hard regs that have been used in lra_spill in   hard_regs_spilled_into - using

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Change logs below. There is a problem in attaching the bundle. I get permanent error from sourceware.org GCC ChangeLog: Microblaze Target: PIC data text relative * gcc/config/microblaze/microblaze.opt: add new option -mpic-data-text-rel. * gcc/config/microblaze/microblaze-protos.h