[committed] Remove trailing whitespace from diagnostics (PR c/84910)

2018-03-16 Thread Jakub Jelinek
Hi! All of warning, error_at and inform functions emit a newline after the message, so trailing whitespace is undesirable there. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2018-03-16 Jakub Jelinek PR c/84910

[PATCH] PR fortran/65453 -- procedure statement vs subprogram name clash

2018-03-16 Thread Steve Kargl
The attached patch fixes an ICE by detecting a name clash between a procedure statement and a contained subprogram. Regression tested on x86_64-*-freebsd. 2018-03-16 Steven G. Kargl PR fortran/65453 * decl.c (get_proc_name): Catch clash between a procedure

Re: [PATCH] avoid warning for memcpy to self (PR 83456)

2018-03-16 Thread H.J. Lu
On Wed, Mar 7, 2018 at 3:01 PM, Martin Sebor wrote: > I have become convinced that issuing -Wrestrict in gimple-fold > for calls to memcpy() where the source pointer is the same as > the destination causes more trouble than it's worth, especially > when inlining is involved, as

Re: [PATCH, rs6000] Finish implementation of __builtin_atlivec_lvx_v1ti

2018-03-16 Thread Segher Boessenkool
On Wed, Mar 14, 2018 at 04:27:31PM -0500, Kelvin Nilsen wrote: > During code review, it was discovered that the implementation of > __builtin_altivec_lvx_v1ti is not complete. The constant > ALTIVEC_BUILTINLVX_V1TI is introduced and is bound to the function > __builtin_altivec_lvx_v1ti. However,

Re: [PATCH v2, rs6000] Remove unused (and incorrect) code for internal store and load operations

2018-03-16 Thread Segher Boessenkool
Hi Kelvin, Okay for trunk. Thanks! Segher On Wed, Mar 14, 2018 at 02:22:44PM -0500, Kelvin Nilsen wrote: > 2018-03-14 Kelvin Nilsen > > * config/rs6000/rs6000-builtin.def: Remove various BU_ALTIVEC_X > macro expansions for definition of ST_INTERNAL_ and >

Re: [RFC Patch], PowerPC memory support pre-gcc9, patch #1

2018-03-16 Thread Michael Meissner
In patch #4, I mentioned that the spec 2006 benchmark 'tonto' generated different with the patches applied. I tracked it down, and it was due to the call I inserted in rs6000_debug_reg_print to update the conditional register usage seemed to set the Altivec registers VS0..VS19 to call_used

Re: [PATCH ] PR 844422 Fix FCTID, FCTIW with -mcpu=power7

2018-03-16 Thread Segher Boessenkool
Hi Carl, On Wed, Mar 14, 2018 at 08:27:08AM -0700, Carl Love wrote: > The following patch fixes an ICE when compiling the test case > > gcc -mcpu=power7 builtin-fctid-fctiw-runnable.c > > The GCC compiler now gives a message  > > "error: builtin function ‘__builtin_fctiw’ requires the

New German PO file for 'gcc' (version 8.1-b20180128)

2018-03-16 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/gcc/de.po (This file, 'gcc-8.1-b20180128.de.po',

[PR c++/84789] do not resolve typename into template-independent

2018-03-16 Thread Alexandre Oliva
resolve_typename_type may peek into template types that might still be specialized. In some cases, e.g. g++.dg/template/friend48.C or g++.dg/template/decl2.C, that is exactly the right thing to do. In others, like the newly-added testcase g++.dg/template/pr84789.C, it isn't, and if the

[PATCH 2/3] Add htdocs/ansi2html.css

2018-03-16 Thread David Malcolm
Generated by: ansi2html.sh --css-only --bg=dark --palette=xterm --- htdocs/ansi2html.css | 287 +++ 1 file changed, 287 insertions(+) create mode 100644 htdocs/ansi2html.css diff --git a/htdocs/ansi2html.css b/htdocs/ansi2html.css new file mode

[PATCH 1/3] bin: add ansi2html.sh

2018-03-16 Thread David Malcolm
--- bin/ansi2html.sh | 520 +++ 1 file changed, 520 insertions(+) create mode 100755 bin/ansi2html.sh diff --git a/bin/ansi2html.sh b/bin/ansi2html.sh new file mode 100755 index 000..ae83a78 --- /dev/null +++ b/bin/ansi2html.sh @@ -0,0

[PATCH 0/3] wwwdocs: Updates for gcc 8 changes

2018-03-16 Thread David Malcolm
This patch kit is for the website; I generated it against a local git mirror of the CVS repo. It adds lots of examples of colorized output from GCC, which I generated using ansi2html.sh, an LGPLv2 script for turning ANSI color codes into HTML spans. It also emits a .css file for mapping the span

[PATCH 3/3] Document my gcc 8 changes for the website

2018-03-16 Thread David Malcolm
This patch documents various improvements in GCC 8 for our website. There are lots of examples of colorized output from GCC (generated using ansi2html); the patch uses the ansi2html.css from the previous patch for styling them. Caveat: I don't have the toolchain working for building the site, so

Re: [PATCH] Fix postreload constant merging (PR target/84899)

2018-03-16 Thread Jeff Law
On 03/16/2018 02:17 PM, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs on powerpc-linux, because we merge > SImode constants 0x7fff and 1 into 0x8000, which is not valid SImode > CONST_INT - -0x8000 is. Fixed by calling trunc_int_for_mode, and to > avoid UB in the

Re: [PATCH] Fix PR84873

2018-03-16 Thread Jakub Jelinek
On Fri, Mar 16, 2018 at 12:53:29PM +0100, Richard Biener wrote: > > An alternative slightly more expensive patch is the following which > > I'm now testing on x86_64-unknown-linux-gnu, the above testcase > > is fixed with it (verified with a cross). > > Bootstrapped and tested on

[PATCH] Fix x86 -march/-mtune after recent icelake-* split (PR target/84902)

2018-03-16 Thread Jakub Jelinek
Hi! We now have more than 32 enumerators in enum processor_type (well, we had 33 already before the icelake-* split, but the last one isn't really used), and while all the m_* macros were changed tom 1U< PR target/84902 * config/i386/i386.c (initial_ix86_tune_features,

[PATCH] Fix postreload constant merging (PR target/84899)

2018-03-16 Thread Jakub Jelinek
Hi! The following testcase ICEs on powerpc-linux, because we merge SImode constants 0x7fff and 1 into 0x8000, which is not valid SImode CONST_INT - -0x8000 is. Fixed by calling trunc_int_for_mode, and to avoid UB in the compiler do the addition in unsigned type.

[committed] Fix "to to" -> "to" in diagnostics and comments (PR c/84909)

2018-03-16 Thread Jakub Jelinek
Hi! Duplicated word in diagnostics and the same issues in 3 comments. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2018-03-16 Jakub Jelinek PR c/84909 * c-warn.c (conversion_warning): Replace "to to" with "to" in

[Committed] PR fortran/69395 -- Correct error condition

2018-03-16 Thread Steve Kargl
The following patch fixes essentially and off-by-one in the error condition. Committed as obvious. 2018-03-16 Steven G. Kargl PR fortran/69395 * decl.c (merge_array_spec): Correct the error condition. 2018-03-16 Steven G. Kargl

libgo patch committed: add missing entry to noinst_DATA

2018-03-16 Thread Ian Lance Taylor
This libgo patch adds runtime/pprof/internal/profile.gox to noinst_DATA. That package is only used by tests, so it needs to be in noinst_DATA to ensure that it is built when tests are run. It also adds noinst_DATA to CHECK_DEPS; it's not needed in practice since `make` will build noinst_DATA,

Re: C++ PATCH for c++/84720, ICE with rvalue ref template parameter

2018-03-16 Thread Jason Merrill
On Tue, Mar 13, 2018 at 2:54 PM, Jason Merrill wrote: > It's unclear to me that it is ever possible to instantiate a template > taking an rvalue ref parameter, but I guess we might as well handle it > properly. ...except that such parameters are actually ill-formed, so we

patch to fix PR84876

2018-03-16 Thread Vladimir Makarov
The following patch fixes   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84876 and another problem with LRA cycling which occurred on the same test. The patch was successfully bootstrapped and tested on i686 and x86_64. Committed as rev. 258602. Index: ChangeLog

C++ PATCH for c++/80227, SFINAE and negative array size

2018-03-16 Thread Jason Merrill
In this testcase, because sizeof (T) - 5 has unsigned type, it ends up being an extremely large number rather than a negative one. valid_constant_size_p seems to be a useful predicate for recognizing problematic cases; tree_int_cst_sign_bit should also work, but seems more subtle. While I was

C++ PATCH for c++/84906, silent wrong code with ambiguous conversion

2018-03-16 Thread Jason Merrill
The problem here was that when we initially looked for the conversion we were in direct-initialization context, but then when we tried to do the lookup again to get an error it was done in copy-initialization context, so it was no longer ambiguous. Fixed by remembering which we're in. Tested

Re: Enable string_view assertions

2018-03-16 Thread Jonathan Wakely
On 15 March 2018 at 00:18, Jonathan Wakely wrote: > On 14 March 2018 at 23:27, Jonathan Wakely wrote: >> Here's one way to generalize this idea. We could potentially replace >> most of the lightweight __glibcxx_assert checks with this, to get >> zero-overhead static checking at compile-time

New Ukrainian PO file for 'gcc' (version 8.1-b20180128)

2018-03-16 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Ukrainian team of translators. The file is available at: http://translationproject.org/latest/gcc/uk.po (This file,

Re: [RFC Patch], PowerPC memory support pre-gcc9, patch #4

2018-03-16 Thread Michael Meissner
Here is patch #4 that moves the MOVDF/MOVDD insns into calling C code. I added documentation to the various MOVD{F,D} patterns similar to the documentation I've done on the other patterns to make it simpler to track which two constraints match which instruction and which instruction type is used.

New German PO file for 'gcc' (version 8.1-b20180128)

2018-03-16 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/gcc/de.po (This file, 'gcc-8.1-b20180128.de.po',

Re: [committed] Fix ICE for missing header fix-it hints with overlarge #line directives (PR c/84852)

2018-03-16 Thread David Malcolm
On Fri, 2018-03-16 at 10:18 +, Bin.Cheng wrote: > On Thu, Mar 15, 2018 at 1:32 AM, Paul Hua > wrote: > > Hi: > > > > The fixits-pr84852-1.c fails on mips64el target. > > Hi, > It fails on aarch64/arm bare-metal cross toolchains with different > message like: > ERROR:

[PATCH][OBVIOUS] Fix UBSAN in regrename.c (PR rtl-optimization/84635).

2018-03-16 Thread Martin Liška
Hi. It's quite obvious mistake, where we access an array variable before we check index boundary. I'll install it after bootstrap & regression tests. Martin gcc/ChangeLog: 2018-03-16 Martin Liska PR rtl-optimization/84635 * regrename.c (build_def_use): Use

Re: [PATCH] Fix PR84512

2018-03-16 Thread Tom de Vries
On 03/16/2018 12:55 PM, Richard Biener wrote: On Fri, 16 Mar 2018, Tom de Vries wrote: On 02/27/2018 01:42 PM, Richard Biener wrote: Index: gcc/testsuite/gcc.dg/tree-ssa/pr84512.c === --- gcc/testsuite/gcc.dg/tree-ssa/pr84512.c

Re: [PATCH] Properly redirect alias for MVC (PR ipa/84722).

2018-03-16 Thread Martin Liška
On 03/13/2018 09:21 AM, Martin Liška wrote: > Hi. > > When having a weak alias that points to a multi-versioning function, one > needs to redirect the alias properly. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > Ready for trunk? > Thanks, > Martin > >

Re: [PATCH] Redirect reference in the symbol table (PR ipa/84833).

2018-03-16 Thread Martin Liška
On 03/13/2018 02:35 PM, Martin Liška wrote: > Hi. > > This fixed issue where we have an ifunc function called from another ifunc > function. > One needs to properly make a reference redirection. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > MVC tests on x86_64

Re: [PATCH] Handle -fno-guess-branch-probability properly in predict.c (PR ipa/84825).

2018-03-16 Thread Martin Liška
On 03/13/2018 01:13 PM, Martin Liška wrote: > Hi. > > This is a fix for situation where we use -fno-guess-branch-probability and > fnsplit happens. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > Ready for trunk? > Thanks, > Martin > > gcc/ChangeLog: > >

C++ PATCH for c++/83937, wrong C++17 overload resolution with constructor and {}

2018-03-16 Thread Jason Merrill
With T({}), the {} specifically initializes the first constructor parameter, rather than T directly. This is different from T{}, so we need to check CONSTRUCTOR_IS_DIRECT_INIT. Tested x86_64-pc-linux-gnu, applying to trunk. commit 96fb2fc01280452682585dcc68038f54f416d034 Author: Jason Merrill

Re: [PATCH 1/3] [builtins] Generic support for __builtin_load_no_speculate()

2018-03-16 Thread Björn Weber
I ran a number of tests against this patch on non-ARM platforms and noticed something weird. The default_speculation_safe_load seems to have a logic twist. When cmpptr is greater or equal to the upper_bound the call is considered in-range. In: gcc/targhooks.c [..]

[PATCH] Fix PR84859

2018-03-16 Thread Richard Biener
This fixes a bogus warning by performing MIN_EXPR detection on memory which avoids bogus threading and isolating of a path with a bogus memcpy. I've gone back in time and at some point we had no MAX_STORES_TO_SINK param but handled just the last_and_only_stmt case of sinking two stores. The

Re: [PATCH][GCC][ARM] Fix can_change_mode_class for big-endian

2018-03-16 Thread Christophe Lyon
On 15 March 2018 at 11:19, Kyrill Tkachov wrote: > Hi Tamar, > > > On 05/03/18 16:51, Tamar Christina wrote: >> >> Hi All, >> >> Taking the subreg of a vector mode on big-endian may result in an infinite >> recursion and eventually a segfault once we run out of stack

Re: [og7] vector_length extension part 5: libgomp and tests

2018-03-16 Thread Thomas Schwinge
Hi! On Fri, 2 Mar 2018 12:47:23 -0800, Cesar Philippidis wrote: > The attached patch is the last one in the vector length extension > series. It consists of some tweaks to the libgomp nvptx plugin to > accommodate larger vectors along with two test cases. > > I only

Re: RFA (make_dispatcher_decl): PATCH for c++/83911, ICE with multiversioned constructor

2018-03-16 Thread Jason Merrill
On Thu, Mar 15, 2018 at 4:50 AM, Richard Biener wrote: > On Wed, Mar 14, 2018 at 8:57 PM, Jason Merrill wrote: >> Ping >> >> On Fri, Mar 2, 2018 at 1:23 PM, Jason Merrill wrote: >>> As I mentioned in the PR, the problem here is

Re: [C++ PATCH] Fix ICE in reshape_init_class (PR c++/84874)

2018-03-16 Thread Jakub Jelinek
On Fri, Mar 16, 2018 at 12:29:58AM +0100, Jakub Jelinek wrote: > As the testcase shows, even when we've already reshaped the initializer, if > it uses designated initializers and skips using those over others, we can > have field != d->cur->index. The following patch handles that case. Just to

[testsuite] Require label_values in builtin-unreachable-6.c

2018-03-16 Thread Tom de Vries
[ was: Re: [PATCH][committed][PR tree-optimization/82123] 02/06 Perform EVRP analysis in sprintf warning pass ] On 02/20/2018 07:52 PM, Jeff Law wrote: This twiddles one test -- adding the calls into the analyzer from the sprintf pass causes us to record a range for an object that didn't have

Re: [PATCH] Fix PR84512

2018-03-16 Thread Richard Biener
On Fri, 16 Mar 2018, Tom de Vries wrote: > On 02/27/2018 01:42 PM, Richard Biener wrote: > > Index: gcc/testsuite/gcc.dg/tree-ssa/pr84512.c > > === > > --- gcc/testsuite/gcc.dg/tree-ssa/pr84512.c (nonexistent) > > +++

Re: [PATCH] Fix PR84873

2018-03-16 Thread Richard Biener
On Fri, 16 Mar 2018, Richard Biener wrote: > On Thu, 15 Mar 2018, Bin.Cheng wrote: > > > On Thu, Mar 15, 2018 at 1:07 PM, Jakub Jelinek wrote: > > > On Thu, Mar 15, 2018 at 01:56:16PM +0100, Richard Biener wrote: > > >> The following fixes the C familiy gimplification langhook

Re: [PATCH AArch64]Fix test failure for pr84682-2.c

2018-03-16 Thread Kyrill Tkachov
Hi Bin, On 16/03/18 11:42, Bin Cheng wrote: Hi, This simple patch fixes test case failure for pr84682-2.c by returning false on wrong mode rtx in aarch64_classify_address, rather than assert. Bootstrap and test on aarch64. Is it OK? Thanks, bin 2018-03-16 Bin Cheng

Re: [PATCH] Fix PR84512

2018-03-16 Thread Tom de Vries
On 02/27/2018 01:42 PM, Richard Biener wrote: Index: gcc/testsuite/gcc.dg/tree-ssa/pr84512.c === --- gcc/testsuite/gcc.dg/tree-ssa/pr84512.c (nonexistent) +++ gcc/testsuite/gcc.dg/tree-ssa/pr84512.c (working copy) @@ -0,0

[PATCH AArch64]Fix test failure for pr84682-2.c

2018-03-16 Thread Bin Cheng
Hi, This simple patch fixes test case failure for pr84682-2.c by returning false on wrong mode rtx in aarch64_classify_address, rather than assert. Bootstrap and test on aarch64. Is it OK? Thanks, bin 2018-03-16 Bin Cheng * config/aarch64/aarch64.c

Re: [committed] Fix ICE for missing header fix-it hints with overlarge #line directives (PR c/84852)

2018-03-16 Thread Bin.Cheng
On Thu, Mar 15, 2018 at 1:32 AM, Paul Hua wrote: > Hi: > > The fixits-pr84852-1.c fails on mips64el target. Hi, It fails on aarch64/arm bare-metal cross toolchains with different message like: ERROR: gcc.dg/fixits-pr84852-1.c: bad option "-812156810": must be -exact, -glob,

Re: [PATCH][committed][Fortran] Add a few new tests for -fdec-static and -fdec-structure

2018-03-16 Thread Jakub Jelinek
On Thu, Mar 15, 2018 at 11:09:13PM -0600, Jeff Law wrote: > Tested on x86_64-linux-gnu. Installing on the trunk. ENOPATCH. Jakub

Re: [PATCH][committed][Fortran] Add a few new tests for -fdec-static and -fdec-structure

2018-03-16 Thread Jakub Jelinek
On Fri, Mar 16, 2018 at 09:01:30AM +0100, Jakub Jelinek wrote: > On Thu, Mar 15, 2018 at 11:09:13PM -0600, Jeff Law wrote: > > Tested on x86_64-linux-gnu. Installing on the trunk. > > ENOPATCH. Here it is from svn: 03-16-2018 Mark Doffman Jim

[C++ PATCH] Fix ICE in reshape_init_class (PR c++/84874)

2018-03-16 Thread Jakub Jelinek
Hi! As the testcase shows, even when we've already reshaped the initializer, if it uses designated initializers and skips using those over others, we can have field != d->cur->index. The following patch handles that case. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

Re: libgo patch committed: Force LANG=C when looking for compiler version

2018-03-16 Thread Andreas Schwab
On Mär 15 2018, Ian Lance Taylor wrote: > On Thu, Mar 15, 2018 at 11:24 AM, Andreas Schwab > wrote: >> On Mär 15 2018, Ian Lance Taylor wrote: >> >>> On Thu, Mar 15, 2018 at 10:10 AM, Andreas Schwab >>> wrote:

Re: [PATCH] Fix reassoc with -frounding-math or IBM long double (PR tree-optimization/84841)

2018-03-16 Thread Richard Biener
On Thu, 15 Mar 2018, Jakub Jelinek wrote: > Hi! > > If any argument of * is negated, reassoc adds an artificial -1.0 multiplier. > The code then relies on folding at least all those artificial multipliers > through const_binop. That function can fail if the result is inexact for >

Re: [PATCH] Fix PR84873

2018-03-16 Thread Richard Biener
On Thu, 15 Mar 2018, Bin.Cheng wrote: > On Thu, Mar 15, 2018 at 1:07 PM, Jakub Jelinek wrote: > > On Thu, Mar 15, 2018 at 01:56:16PM +0100, Richard Biener wrote: > >> The following fixes the C familiy gimplification langhook to not > >> introduce tree sharing which isn't valid

Re: [PATCH] PR gcc/68256 Defining TARGET_USE_CONSTANT_BLOCKS_P causes go bootstrap failure on aarch64.

2018-03-16 Thread vladimir . mezentsev
On 03/15/2018 07:07 AM, Bin.Cheng wrote: > On Fri, Feb 16, 2018 at 5:18 PM, wrote: >> From: Vladimir Mezentsev >> >> Ramana Radhakrishnan made a workaround in gcc/config/aarch64/aarch64.c to >> resolve >> bootstrap comparison