[ARM] Fix PR85434: spill of stack protector's guard address

On Arm (Aarch32 and Aarch64) the stack protector's guard is accessed by loading its address first before loading its value from it as part of the stack_protect_set or stack_protect_check insn pattern. This creates the risk of spilling between the two. It is particularly likely on Aarch32 when

Re: [C++ PATCH] Fix value initialized decltype(nullptr) in constexpr (PR c++/85553)

Hi again, I'm now pretty sure that we have a latent issue in ocp_convert. The bug fixed by Jakub shows that we used to not have issues with integer_zero_node. That's easy to explain: at the beginning of ocp_convert there is code which handles first some special / simple cases when

Re: [wwwdocs] Add no_sanitize attribute

On 04/18/2018 06:22 AM, Martin Liška wrote: > I would like to mention the attribute in GCC 8 changes. OK. jeff

[openacc, testsuite, PR85527, committed] Fix undefined behaviour in atomic_capture-1.f90

Hi, Consider this test-case, minimized from atomic_capture-1.f90: ... program main real fgot, fexp, ftmp integer, parameter :: N = 32 fgot = 1234.0 fexp = 1266.0 !$acc parallel loop copy (fgot, ftmp) do i = 1, N !$acc atomic capture ftmp = fgot fgot = fgot +

Re: [PATCHv2][PR 81376] Remove unnecessary float casts in comparisons

On 02/19/2018 12:47 PM, Richard Sandiford wrote: > Yuri Gribov writes: >> Hi all, >> >> This is a second iteration of patch which gets rid of float casts in >> comparisons when all values of casted integral type are exactly >> representable by the float type >>

Re: ATTRIBUTE_NONSTRING

On Fri, 27 Apr 2018, Alan Modra wrote: > This patch adds ATTRIBUTE_NONSTRING, which will be used to curb > -Wstringop-truncation warnings in binutils. OK to apply? > > * ansidecl.h (ATTRIBUTE_NONSTRING): Define. > > diff --git a/include/ansidecl.h b/include/ansidecl.h > index

RFA (clobbers, gimplification): PATCH for c++/61982, dead stores to destroyed objects

61982 notes that an explicit destructor call or delete expression ends the lifetime of an object, but we weren't clobbering affected objects if their destructors are trivial. This patch fixes that. The first commit just adds a helper function, build_clobber. The second commit changes explicit

Re: [PATCH 5/5] [ARC] Clear the instruction cache using syscalls.

* Claudiu Zissulescu [2018-04-06 11:00:14 +0200]: > Clear the instruction cache from `beg' to `end'. This makes an inline > system call to SYS_cacheflush. > > gcc/ > 2017-03-28 Claudiu Zissulescu > > * config/arc/linux.h

Re: [PATCH 4/5] [ARC] Cleanup sdata handling.

* Claudiu Zissulescu [2018-04-06 11:00:13 +0200]: > From: Claudiu Zissulescu > > Clean up how we handle small data load/store operations. This patch clears > -flto-fat-lto-object LTO related errors. > > gcc/ > 2018-01-18 Claudiu

Re: [PATCH 3/5] [ARC] Update movhi and movdi patterns.

* Claudiu Zissulescu [2018-04-06 11:00:12 +0200]: > From: Claudiu Zissulescu > > Allow signed 6-bit short immediates into st[d] instructions. > > 2017-10-19 Claudiu Zissulescu > > * config/arc/arc.c

Re: [wwwdocs]Mention -ftree-loop-distribution

On 04/03/2018 09:51 AM, Bin Cheng wrote: > Hi, > > Option -ftree-loop-distribution is improved and enabled by default at -O3 for > GCC8. > This patch describes the change, is it OK? Yes. This is fine. jeff

Re: [C++ PATCH] Fix value initialized decltype(nullptr) in constexpr (PR c++/85553)

On 27/04/2018 22:25, Paolo Carlini wrote: Hi, On 27/04/2018 22:13, Jason Merrill wrote: Ok Maybe for 8.2.0 or whatever, would it make sense to special case convert itself? See what we do in, say, decay_conversion, we aren't afraid to immediately return nullptr_node... ... or more generally

Re: [C++ PATCH] Fix value initialized decltype(nullptr) in constexpr (PR c++/85553)

Hi, On 27/04/2018 22:13, Jason Merrill wrote: Ok Maybe for 8.2.0 or whatever, would it make sense to special case convert itself? See what we do in, say, decay_conversion, we aren't afraid to immediately return nullptr_node... Paolo.

[committed] input.h: convert some macros to inline functions

Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Committed to trunk as r259727. gcc/ChangeLog: * input.h (in_system_header_at): Convert from macro to inline function. (from_macro_expansion_at): Likewise. (from_macro_definition_at): Likewise. ---

Re: [C++ PATCH] Fix value initialized decltype(nullptr) in constexpr (PR c++/85553)

Ok On Fri, Apr 27, 2018, 2:07 PM Jakub Jelinek wrote: > Hi! > > init = fold (convert (type, nullptr_node)); unfortunately creates > a NOP_EXPR around INTEGER_CST and constexpr.c doesn't consider that a valid > constant; fold (convert (type, integer_zero_node)) we used

Re: [C++ PATCH] Fix value initialized decltype(nullptr) in constexpr (PR c++/85553)

On Fri, Apr 27, 2018 at 08:07:36PM +0200, Jakub Jelinek wrote: > init = fold (convert (type, nullptr_node)); unfortunately creates > a NOP_EXPR around INTEGER_CST and constexpr.c doesn't consider that a valid > constant; fold (convert (type, integer_zero_node)) we used previously > on the other

Re: Remove tilegx port

On 04/27/2018 11:42 AM, Richard Biener wrote: > On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law wrote: >> On 04/27/2018 09:36 AM, Joseph Myers wrote: >>> Since tile support has been removed from the Linux kernel for 4.17, >>> this patch removes the (unmaintained) port to tilegx

Re: [PATCH][arm][FreeBSD] PR libgcc/84292

On 26.04.18 09:49, Richard Biener wrote: On Wed, Apr 25, 2018 at 10:41 PM, Andreas Tobler wrote: Hi all, I'm going to commit this patch to all active branches as soon as the branch status permits. Built and tested on native armv5 FreeBSD12. If you think it is safe

Re: libgo patch committed, RFA for GCC 8 release branch: Solaris assembler support

On Fri, Apr 27, 2018 at 11:04 AM, Jakub Jelinek wrote: > On Fri, Apr 27, 2018 at 11:00:41AM -0700, Ian Lance Taylor wrote: >> This libgo patch fixes the go tool to use Solaris assembler syntax for >> the buildid file. The Solaris assembler uses a different syntax for >> section

[C++ PATCH] Fix value initialized decltype(nullptr) in constexpr (PR c++/85553)

Hi! init = fold (convert (type, nullptr_node)); unfortunately creates a NOP_EXPR around INTEGER_CST and constexpr.c doesn't consider that a valid constant; fold (convert (type, integer_zero_node)) we used previously on the other side emitted warnings. The following patch just builds the

Re: libgo patch committed, RFA for GCC 8 release branch: Solaris assembler support

On Fri, Apr 27, 2018 at 11:00:41AM -0700, Ian Lance Taylor wrote: > This libgo patch fixes the go tool to use Solaris assembler syntax for > the buildid file. The Solaris assembler uses a different syntax for > section directives. This is https://golang.org/cl/109140 ported over > to gccgo.

libgo patch committed, RFA for GCC 8 release branch: Solaris assembler support

This libgo patch fixes the go tool to use Solaris assembler syntax for the buildid file. The Solaris assembler uses a different syntax for section directives. This is https://golang.org/cl/109140 ported over to gccgo. This fixes PR 85429. Bootstrapped and ran Go tests on x86_64-pc-linux-gnu

Re: [PR 85549] Add mising check to aggregate IPA-CP propagation

On April 27, 2018 5:36:27 PM GMT+02:00, Martin Jambor wrote: >Hi, > >On Fri, Apr 27 2018, Martin Jambor wrote: >> Hi, >> >> this is a fix for another fallout from the fix for 84149 > >sorry, I have mistakenly hit the send key. Anyway, this is a fix for >another fallout from the

Re: Remove tilegx port

On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law wrote: >On 04/27/2018 09:36 AM, Joseph Myers wrote: >> Since tile support has been removed from the Linux kernel for 4.17, >> this patch removes the (unmaintained) port to tilegx from glibc (the >> tilepro support having been

Re: Remove tilegx port

On 04/27/2018 09:36 AM, Joseph Myers wrote: > Since tile support has been removed from the Linux kernel for 4.17, > this patch removes the (unmaintained) port to tilegx from glibc (the > tilepro support having been previously removed). This reflects the > general principle that a glibc port needs

Re: C++ PATCH for c++/85545, ICE with noexcept static_cast

On Fri, Apr 27, 2018 at 11:00 AM, Jason Merrill wrote: > With Nathan's patch for 85437, constexpr evaluation now breaks open a > PTRMEM_CST that has a non-qualification conversion. Then actually > performing the conversion means messing with the contents of the > CONSTRUCTOR.

Re: [C++ Patch] PR 84691 ("[6/7/8/9 Regression] internal compiler error: in poplevel_class...")

OK. On Fri, Apr 27, 2018 at 5:33 AM, Paolo Carlini wrote: > Hi, > > this small error-recovery issue remained in my todo list of 8 regressions: > just clear the friendp flag in this case too - like we do a few lines above > for virtual declarations - and avoid problems

Re: [PATCH] v2: Don't offer suggestions for compiler-generated variables (PR c++/85515)

On Thu, Apr 26, 2018 at 8:09 PM, David Malcolm wrote: > On Thu, 2018-04-26 at 15:53 -0400, Jason Merrill wrote: >> On Thu, Apr 26, 2018 at 3:45 AM, Richard Biener >> wrote: >> > On Wed, Apr 25, 2018 at 7:10 PM, Nathan Sidwell >> >

Re: [PR 85549] Add mising check to aggregate IPA-CP propagation

Hi, On Fri, Apr 27 2018, Martin Jambor wrote: > Hi, > > this is a fix for another fallout from the fix for 84149 sorry, I have mistakenly hit the send key. Anyway, this is a fix for another fallout from the fix for 84149, in which I have relaxed conditions to propagate values along self

[PR 85549] Add mising check to aggregate IPA-CP propagation

Hi, this is a fix for another fallout from the fix for 84149 2018-04-27 Martin Jambor PR ipa/85549 * ipa-cp.c (find_aggregate_values_for_callers_subset): Make sure the jump function allows for passing through aggregate values. testsuite/

C++ PATCH for c++/85545, ICE with noexcept static_cast

With Nathan's patch for 85437, constexpr evaluation now breaks open a PTRMEM_CST that has a non-qualification conversion. Then actually performing the conversion means messing with the contents of the CONSTRUCTOR. Tested x86_64-pc-linux-gnu, applying to trunk. commit

Re: [PATCH] Fix aarch64 ILP32 ICE with vaarg gimplified code

On 27/04/18 15:25, James Greenhalgh wrote: On Fri, Apr 27, 2018 at 10:02:11AM +0100, Richard Biener wrote: > On Fri, 27 Apr 2018, Kyrill Tkachov wrote: > > > > > On 26/04/18 15:04, Christophe Lyon wrote: > > > On 26 April 2018 at 15:41, Richard Biener wrote: > > > > On Thu,

Re: [PATCH] Fix aarch64 ILP32 ICE with vaarg gimplified code

On Fri, Apr 27, 2018 at 10:02:11AM +0100, Richard Biener wrote: > On Fri, 27 Apr 2018, Kyrill Tkachov wrote: > > > > > On 26/04/18 15:04, Christophe Lyon wrote: > > > On 26 April 2018 at 15:41, Richard Biener wrote: > > > > On Thu, 26 Apr 2018, Christophe Lyon wrote: > > > >

[C++ PATCH] cleanup 2

When working on the recent ptrmem static_cast bug, I noticed convert_ptrmem could do with a bit of modernization. Thusly moved its local var decls to their assignments. nathan -- Nathan Sidwell 2018-04-27 Nathan Sidwell * typeck.c (convert_ptrmem): Move local var decls to

Re: [patch] allow '-' for stdout dump

On 04/26/2018 01:31 PM, Sandra Loosemore wrote: Hmmm, I'm not crazy about putting this material in the middle of a discussion about how the compiler comes up with its default dump file names.  How about splitting the existing paragraph into 3: Yeah, that documentation is rather a mess. I

Re: [patch][i386] Goldmont -march/-mtune options

On Fri, Apr 27, 2018 at 10:04 AM, Makhotina, Olga wrote: > Hi, > > This patch implements Goldmont -march/-mtune. > > 2018-04-27 Olga Makhotina > > gcc/ > > * config.gcc: Support "goldmont". > * config/i386/driver-i386.c

Re: [libstdc++; pr66689; pr68397] Backport special function fixes to 7.

On 26/04/18 23:17 -0400, Ed Smith-Rowland wrote: I'm thinking of going back on my choice not to fix special function bugs on 7. These build and test clean on gcc-7. OK? OK for gcc-7-branch, thanks.

[C++ PATCH] some cleanups

A few cleanups from the modules branch. * The TEMPLATE_INFO comments still described TREE_LIST contents. * we didn't check we were looking at a TEMPLATE_INFO in one case * we declared some (now?) non-existent dump functions * we made a name-lookup internal dumping function extern * we made a

[PATCH] More stmt verification pruning

I'll merge verify_expr into verify_gimple_stmt and as a first step the following marks all dead code as gcc_unreachable. The 2nd step will remove duplicate checking and adjust verify_gimple_stmt where it lacks compared to verify_expr. Note that this gives us slightly more checking since

[PATCH] Remove MPX support

Hi. I'm sending patch that removes MPX. It preserves all options -fcheck-pointer-bounds, -fchkp-* and -mmpx target option. These options are now NOP. On the contrary following options were removed: --static-libmpx -static-libmpxwrappers. Is it fine to remove them? Patch can bootstrap on

[PATCH] Shave some bit of work off verify_gimple_in_cfg

This makes us not record all stmts in the visited_stmts hash-set but only those that are possibly valid EH stmts. Should save us some cycles here. Bootstrap running on x86_64-unknown-linux-gnu. Richard. 2018-04-27 Richard Biener * tree-cfg.c (verify_gimple_phi):

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Thanks Michael. Please find below updated Change Log. 2018-04-27 Andrew Sadek Microblaze Target: PIC data text relative * gcc/config/microblaze/microblaze.opt: add new option -mpic-is-data-text-relative. * gcc/config/microblaze/microblaze-protos.h

[C++ Patch] PR 84691 ("[6/7/8/9 Regression] internal compiler error: in poplevel_class...")

Hi, this small error-recovery issue remained in my todo list of 8 regressions: just clear the friendp flag in this case too - like we do a few lines above for virtual declarations - and avoid problems later. Tested x86_64-linux. Thanks, Paolo. /cp 2018-04-27 Paolo

Re: [patch] allow '-' for stdout dump

On Thu, Apr 26, 2018 at 7:12 PM, Nathan Sidwell wrote: > Here's the patch to allow '-' as a synonym for 'stdout'. It's easier to > type, and a convention used elsewhere. > > Also document the existing stdout/stderr selection along with the new > behaviour? > > ok for trunk? OK

Re: [PATCH] Do not set nothrow flag on recursive function with stack checking

On Thu, Apr 26, 2018 at 4:29 PM, Eric Botcazou wrote: > Hi, > > when stack checking is enabled in Ada, it is supposed to be able to handle the > case of a recursive function that does essentially nothing. But in this case > the IPA machinery will compute that the function

[PATCH 2/2, i386]: Emit inter-unit moves using preferred_for_speed infrastructure

Second part of the patch. 2018-04-27 Uros Bizjak * config/i386/i386.md (*movti_internal): Substitute Ye constraint with Yd constraint. Set "preferred_for_speed" attribute from TARGET_INTER_UNIT_MOVES_{FROM,TO}_VEC for alternatives with Yd constraint.

Re: [PATCH] Fix aarch64 ILP32 ICE with vaarg gimplified code

On Fri, 27 Apr 2018, Kyrill Tkachov wrote: > > On 26/04/18 15:04, Christophe Lyon wrote: > > On 26 April 2018 at 15:41, Richard Biener wrote: > > > On Thu, 26 Apr 2018, Christophe Lyon wrote: > > > > > >> On 26 April 2018 at 14:09, Richard Biener wrote: >

Re: [PATCH] Fix aarch64 ILP32 ICE with vaarg gimplified code

On 26/04/18 15:04, Christophe Lyon wrote: On 26 April 2018 at 15:41, Richard Biener wrote: > On Thu, 26 Apr 2018, Christophe Lyon wrote: > >> On 26 April 2018 at 14:09, Richard Biener wrote: >> > >> > Seen by Christophe Lyon, verified with a cross that

Re: [PATCH][arm] PR target/82518: Return false in ARRAY_MODE_SUPPORTED_P for BYTES_BIG_ENDIAN

On 25/04/18 18:31, Maxim Kuvyrkov wrote: On Mar 20, 2018, at 8:11 PM, Kyrill Tkachov wrote: Hi all, This PR shows that we get the load/store_lanes logic wrong for arm big-endian. It is tricky to get right. Aarch64 does it by adding the appropriate lane-swapping

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

On Fri, 27 Apr 2018, David Edelsohn wrote: > Hi, Richi > > This patches causes a boostrap failure on AIX. Everything miscompares. > The code itself is the same, but the DWARF debug information contains many > differences. Does AIX use bootstrap-debug by default? I don't see how the patch can

Re: [PATCH][AArch64] PR target/85512: Tighten SIMD right shift immediate constraints

On Fri, Apr 27, 2018 at 09:29:28AM +0100, Kyrill Tkachov wrote: > > On 26/04/18 14:47, Richard Sandiford wrote: > > Kyrill Tkachov writes: > >> On 24/04/18 17:41, Jakub Jelinek wrote: > >>> On Tue, Apr 24, 2018 at 05:22:15PM +0100, Kyrill Tkachov wrote: > I've

Re: [PATCH][AArch64] PR target/85512: Tighten SIMD right shift immediate constraints

On 26/04/18 14:47, Richard Sandiford wrote: Kyrill Tkachov writes: On 24/04/18 17:41, Jakub Jelinek wrote: On Tue, Apr 24, 2018 at 05:22:15PM +0100, Kyrill Tkachov wrote: I've cleaned up the testcase a bit to leave only the function that generates the invalid

Re: [PATCH] Prevent excessive loop-header copying with multiple exits

On Thu, 26 Apr 2018, Richard Biener wrote: > > The following makes loop-header copying stop after the first exit test > it copied. The reports rightfully complain about too much peeling. > If some cases pop up which show we should peel up to a specific test > we need to improve this heuristic

Re: PR85532, crtend.o built without --enable-initfini-array has bad .eh_frame

On Fri, Apr 27, 2018 at 09:31:37AM +0200, Jakub Jelinek wrote: > On Fri, Apr 27, 2018 at 02:27:40AM -0500, Segher Boessenkool wrote: > > Hi Alan, > > > > On Fri, Apr 27, 2018 at 10:49:14AM +0930, Alan Modra wrote: > > > This patch is aimed at removing bogus .eh_frame info emitted after the > > >

[patch][i386] Goldmont -march/-mtune options

Hi, This patch implements Goldmont -march/-mtune. 2018-04-27 Olga Makhotina gcc/ * config.gcc: Support "goldmont". * config/i386/driver-i386.c (host_detect_local_cpu): Detect "goldmont". * config/i386/i386-c.c (ix86_target_macros_internal):

Re: PR85532, crtend.o built without --enable-initfini-array has bad .eh_frame

On Fri, Apr 27, 2018 at 02:27:40AM -0500, Segher Boessenkool wrote: > Hi Alan, > > On Fri, Apr 27, 2018 at 10:49:14AM +0930, Alan Modra wrote: > > This patch is aimed at removing bogus .eh_frame info emitted after the > > zero terminator in crtend.o, which will cause a ld warning and slow > >

Re: PR85532, crtend.o built without --enable-initfini-array has bad .eh_frame

Hi Alan, On Fri, Apr 27, 2018 at 10:49:14AM +0930, Alan Modra wrote: > This patch is aimed at removing bogus .eh_frame info emitted after the > zero terminator in crtend.o, which will cause a ld warning and slow > exception handling. The right fix for the PR is probably to change >

gcc 8 trunk broken O3 on x86_64

All  Just a heads the trunk has been broken since about Weds most files fail compare during bootstrap at O3 but pass at O2 My last succesful boostrap at O3 was Tuesday I no idea which commit caused it Graham

Re: [PATCH] Fix reassoc var_bound optimization (PR tree-optimization/85529)

On Thu, 26 Apr 2018, Jakub Jelinek wrote: > Hi! > > As explained in the comment below, when doing the inter-bb range test > optimization and are trying to optimize the > a >= 0 && a < b > where b is known to be >= 0 into > (unsigned) a < (unsigned) b, we need to be careful if the a >= 0

[NDS32, committed] Fix bug in bit-instruction checking functions.

Hi, all, In the implementation of nds32_can_use_bclr_p(), nds32_can_use_bset_p(), and nds32_can_use_btgl_p(), we better use HOST_WIDE_INT type and GET_MODE_MASK() so that the mask would be good for the bit-operation checking. Committed as Rev.259647: https://gcc.gnu.org/r259647 gcc/ *

[NDS32, committed] Split movdi/df if reigster number is illegal.

Hi, all, We have to split move_di/df pattern when hard register is odd so that the wrong assembly code can be avoided. Committed as Rev.259646: https://gcc.gnu.org/r259646 gcc/ * config/nds32/nds32-doubleword.md: New define_split pattern for illegal register number. Best

[NDS32, committed] Fix incorrect settings in sfp-machine.h and t-nds32-newlib for hard fp.

Hi, all, For nds32 NDS32_ABI_2FP_PLUS abi design, some settings and compilation options are required to be adjusted so that we can build correct libgcc.a library. Committed as Rev.259645: https://gcc.gnu.org/r259645 libgcc/ * config/nds32/sfp-machine.h: Fix settings for

[NDS32, committed] Fix print operand for cctl register.

Hi, all, There was an error in nds32_print_operand() to output cctl register. It would be better to set value earlier. The following commit is to fix such issue. Committed as Rev.259643: https://gcc.gnu.org/r259643 gcc/ * config/nds32/nds32.c (nds32_print_operand): Set op_value

[NDS32, committed] Add missing newline character into ASM_APP_ON macro.

Hi, all, For nds32 inline assembly code output, a newline character was missing. The following commit is to fix the issue. Committed as Rev.259642: https://gcc.gnu.org/r259642 gcc/ * config/nds32/nds32.h (ASM_APP_ON): Add missing newline character. Best regards, jasonwucj