std::vector fix & enhancements

2018-10-29 Thread François Dumont
Following Marc Glisse change to ignore _M_start offset I wanted to go a little step further and just remove it in _GLIBCXX_INLINE_VERSION mode. I also fix a regression we already fixed on mainstream std::vector regarding noexcept qualification of move constructor with allocator. And I impleme

[PATCH] Fix bug 86293

2018-10-29 Thread Nicholas Krause
This fixes the bug on the gcc bugzilla with id, 86293. Basically a variable is undefined in certain build configuration scentarios and must be enabled with the attribute marco and the flag, unused for it to avoid this build error. Build and regtested on x86_64_gnu, ok for trunk? Signed-off-by: Ni

[committed] Fix ICE in get_substring_ranges_for_loc on __FILE__ (PR c++/87721)

2018-10-29 Thread David Malcolm
PR c++/87721 reports a crash in get_substring_ranges_for_loc introduced by r265271, my fix for PR 87562. The new issue occurs when attempting to get a location with a string literal inside a macro in which the first token is __FILE__ (formed via concatenation). Attempting to get the spelling loca

[PATCH] detect missing nuls in address of const char (PR 87756)

2018-10-29 Thread Martin Sebor
The missing nul detection fails when the argument of the %s or similar sprintf directive is the address of a non-nul character constant such as in: const char c = 'a'; int f (void) { return snprintf (0, 0, "%s", &c); } This is because the string_constant function only succeeds for ar

[PATCHv2] Add sinh(atanh(x)) and cosh(atanh(x)) optimizations

2018-10-29 Thread Giuliano Augusto Faulin Belinassi
Improves the numerical precision, as suggested on the previous iteration. Before, the code used 1 - x*x, which can be problematic when x is near 1. Wilco Dijkstra suggested to replace it with 2*(1-fabs(x)) - (1-fabs(x))*(1-fabs(x)) when fabs(x) > 0.5 to greatly improve precision, however after som

Re: Fix build of the D frontend on the Hurd and KFreeBSD

2018-10-29 Thread Iain Buclaw
On Mon, 29 Oct 2018 at 12:51, Matthias Klose wrote: > > Fix build of the D frontend on the Hurd and KFreeBSD. Where should these > changes go, when they are not yet applied upstream? > > Ok to commit? > > Matthias > Thanks, I can send a patch to the github repository upstream. I'll do a sync o

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v4]

2018-10-29 Thread Marek Polacek
On Wed, Oct 24, 2018 at 02:55:14PM -0400, Jason Merrill wrote: > On 10/12/18 12:32 PM, Marek Polacek wrote: > > + EXPLICIT_SPECIFIER is used in case the explicit-specifier, if any, has > > + value-dependent expression. */ > > static void > > cp_parser_decl_specifier_seq (cp_parser* parser, >

Re: [PATCH] xstormy: Set tm_d_file in config.gcc

2018-10-29 Thread Jeff Law
On 10/29/18 4:10 PM, Iain Buclaw wrote: > The default value of tm_d_file is "${cpu_type}/${cpu_type}.h", however > this header doesn't exist for the xstormy back-end, so need to > explicitly override it to stormy16/stormy16.h > > Also including elfos.h, otherwise there's a warning about a > redefi

[PATCH] xstormy: Set tm_d_file in config.gcc

2018-10-29 Thread Iain Buclaw
The default value of tm_d_file is "${cpu_type}/${cpu_type}.h", however this header doesn't exist for the xstormy back-end, so need to explicitly override it to stormy16/stormy16.h Also including elfos.h, otherwise there's a warning about a redefinition of PREFERRED_DEBUGGING_TYPE when building wit

[PATCH] avoid -Wnonnull for printf format in dead code (PR 87041)

2018-10-29 Thread Martin Sebor
PR 87041 - -Wformat "reading through null pointer" on unreachable code is a complaint about -Wformat false positives due to null arguments to %s directives in unreachable printf calls. The warning is issued by the front end, too early to know whether or not the call is ever made. The -Wformat-ov

Re: C++ PATCH to Implement P0846R0, ADL and function templates

2018-10-29 Thread Jason Merrill
On 10/28/18 3:56 PM, Marek Polacek wrote: This patch implements P0846R0: ADL and Function Templates that are not Visible whereby a name for which a normal lookup produces either no result or finds one or more functions and tha

Re: [ARM/FDPIC v3 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2018-10-29 Thread Segher Boessenkool
On Mon, Oct 29, 2018 at 02:45:20PM +0100, Christophe Lyon wrote: > Here is an updated doc proposal (that would go in patch #1, without > changing this one): > @item -mfdpic > @opindex mfdpic > Select the FDPIC ABI, which uses function descriptors to represent > pointers to functions. When the comp

Re: [patch, doc, fortran] Document FINDLOC

2018-10-29 Thread Thomas König
Am 29.10.18 um 12:31 schrieb Bernhard Reutner-Fischer: Hi! On Sun, 28 Oct 2018 15:13:49 +0100 Thomas König wrote: One question and some nits below. === --- intrinsic.texi (Revision 265569) +++ intrinsic.texi (Arbeitsko

Re: [PATCH] i386: Use scalar operand in SF/DF/SI/DI vec_dup patterns

2018-10-29 Thread Uros Bizjak
On Sat, Oct 27, 2018 at 8:03 AM H.J. Lu wrote: > > Use scalar operand in SF/DF/SI/DI vec_dup patterns which enables combiner > to generate > > (set (reg:V8SF 84) > (vec_duplicate:V8SF (mem/c:SF (symbol_ref:DI ("y") > > const_vector_duplicate_operand is added for constant vector broadcast.

Re: [PATCH] BB vectorization with intermediate aliasing stores

2018-10-29 Thread H.J. Lu
On Wed, Oct 24, 2018 at 3:03 AM Richard Biener wrote: > > > The following fixes data ref analysis giving up forming group accesses > when it encounters duplicates. This most happens during BB vectorization > when inside a single BB two store groups are separated by a stmt that > prevents DSE (or

[PATCH, rs6000, committed] Remove inaccurate comment in ssse3-check.h

2018-10-29 Thread Paul Clarke
In gcc.target/powerpc/ssse3-check.h, "DEBUG" doesn't actually "replace abort with printf on error", it just enables debugging output. Remove the comment. Suggested-by: Bill Schmidt (Committing as trivial.) [gcc/testsuite] 2018-10-29 Paul A. Clarke * gcc.target/powerpc/ssse3-check.

Re: [PATCH] Change vectorizer SLP tree to be a graph

2018-10-29 Thread H.J. Lu
On Wed, Oct 24, 2018 at 7:19 AM Richard Biener wrote: > > > This does the last step (I've already changed costing, analysis and > code generation to process nodes as if it were) in making the SLP > tree a graph. This means adjusting SLP analysis to lookup already > identified SLP nodes for a set

[PATCH, doc] Fix CONST_WIDE_INT_ELT

2018-10-29 Thread Paul Koning
The description of CONST_WIDE_INT_ELT gave the macro's name as CONST_WIDE_INT_NUNITS instead. Committed as obvious. paul ChangeLog: 2018-10-29 Paul Koning * doc/rtl.texi (CONST_WIDE_INT_ELT): Give correct macro name. Index: doc/rtl.texi

[PATCH, testsuite, c-compat] Handle another c/l option not recognised by older GCC or clang.

2018-10-29 Thread Iain Sandoe
Hi When using ALT_CC/CXX_UNDER_TEST in the compat/struct-layout-1 tests, the c/l options provided to the “alt” compiler need to avoid latest and greatest GCC capability. The patch tests to see if the ‘alt’ compiler can handle -fno-diagnostics-show-line-numbers. OK for trunk? thanks Iain gcc/

Re: [PATCH][rs6000] use index form addresses more often for ldbrx/stdbrx

2018-10-29 Thread Segher Boessenkool
Hi again, On Mon, Oct 29, 2018 at 09:39:59AM -0500, Aaron Sawdey wrote: > * config/rs6000/rs6000.md (bswapdi2): Force address into register > if not in one already. This isn't very correct, could you rephrase? > +void > +rs6000_force_indexed_or_indirect_mem (rtx x) > +{ > + rtx addr

[PATCH, rs6000] Consistently use '__vector' instead of 'vector'

2018-10-29 Thread Paul Clarke
Revision r265535 committed changes that used 'vector' instead of the preferred '__vector'. There is a reason that '__vector' is preferred, because it ensures no conflicts with C++ namespace. Indeed, gcc/config/rs6000/xmmintrin.h undefines it, leading to errors: gcc/include/xmmintrin.h:999:20:

Re: [C++ Patch] Improve create_array_type_for_decl locations

2018-10-29 Thread Jason Merrill
On 10/29/18 6:12 AM, Paolo Carlini wrote: Hi, while working on something else I noticed that by adding a location_t parameter we can improve the locations of those error messages. Tested x86_64-linux. OK. Jason

Re: C++ PATCH for c++/87594, constexpr rejects-valid with range-based for

2018-10-29 Thread Jason Merrill
On 10/29/18 2:07 PM, Marek Polacek wrote: On Wed, Oct 24, 2018 at 05:16:33PM -0400, Jason Merrill wrote: On 10/11/18 8:56 PM, Marek Polacek wrote: Here potential_constant_expression_1 rejects the testcase because the body of the for loop calls a non-constexpr function. But the range is empty s

Re: [nvptx] vector length patch series

2018-10-29 Thread Cesar Philippidis
On 10/5/18 23:22, Tom de Vries wrote: > On 9/18/18 10:04 PM, Cesar Philippidis wrote: >> 591973d3c3a [nvptx] use user-defined vectors when possible > > If I drop this patch, I get the same test results. Can you find a > testcase for which this patch has an effect? I just revisited the vector leng

Go patch committed: Pass a single flags argument to Backend::function

2018-10-29 Thread Ian Lance Taylor
This patch changes the Go frontend to pass a single flags argument to Backend::function, rather than a sequence of boolean variables. This requires a change to the interface between the Go frontend and the rest of GCC. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainli

Re: [PATCH] S/390: Allow LARL of literal pool entries

2018-10-29 Thread Ulrich Weigand
Ilya Leoshkevich wrote: > r265490 allowed the compiler to choose in a more flexible way whether to > use load or load-address-relative-long (LARL) instruction. When it > chose LARL for literal pool references, the latter ones were rewritten > by pass_s390_early_mach to use UNSPEC_LTREF, which ass

Re: [PATCH] Folding and check_function_arguments

2018-10-29 Thread Alexander Monakov
On Mon, 29 Oct 2018, Jason Merrill wrote: > On Mon, Oct 29, 2018 at 7:07 AM Alexander Monakov wrote: > > On Thu, 25 Oct 2018, Jason Merrill wrote: > > > > > > > > > > Maybe we should remove that in favor of fold_for_warn in > > > > > check_function_arguments. > > > > David, I think your patch als

Go patch committed: Add location_file method to Linemap

2018-10-29 Thread Ian Lance Taylor
This patch to the Go frontend adds a location_file method to Linemap, adding support for getting the file name from a Location value. This will be used by later work. This requires a patch to the interface between the Go frontend and the rest of GCC. Bootstrapped and ran Go testsuite on x86_64-p

Re: C++ PATCH for c++/87594, constexpr rejects-valid with range-based for

2018-10-29 Thread Marek Polacek
On Wed, Oct 24, 2018 at 05:16:33PM -0400, Jason Merrill wrote: > On 10/11/18 8:56 PM, Marek Polacek wrote: > > Here potential_constant_expression_1 rejects the testcase because the body > > of > > the for loop calls a non-constexpr function. But the range is empty so the > > function would never

Re: [Patch, fortran] PR40196 - [F03] [F08] Type parameter inquiry (str%len, a%kind) and Complex parts (z%re, z%im)

2018-10-29 Thread Paul Richard Thomas
Hi Thomas, Thanks for finding the assignment a%len = 2 that escapes the check for lvalues. I am back home tomorrow night and will investigate why this one evades the trap. I think that an error test is needed in expr.c(gfc_check_assign). Cheers Paul On Sun, 28 Oct 2018 at 13:38, Thomas Koenig

Re: [PATCH] Folding and check_function_arguments

2018-10-29 Thread Jason Merrill
On Mon, Oct 29, 2018 at 7:07 AM Alexander Monakov wrote: > On Thu, 25 Oct 2018, Jason Merrill wrote: > > > > > > > > Maybe we should remove that in favor of fold_for_warn in > > > > check_function_arguments. > > David, I think your patch also fixes PR 86567. > > David, Jason, could you comment on

Re: [PATCH] libgcc: properly destroy mutexes on VxWorks

2018-10-29 Thread Olivier Hainque
> On 29 Oct 2018, at 16:16, Olivier Hainque wrote: > > Hi Rasmus, >> libgcc/ >> >> * config/gthr-vxworks.h (__gthread_mutex_destroy): Call semDelete. > > Looks good at first sight. Let me give it a try > on an ongoing port. Ok, thanks!

Re: [PATCH v4] Avoid unnecessarily numbering cloned symbols.

2018-10-29 Thread Michael Ploujnikov
On 2018-10-29 6:49 a.m., Martin Liška wrote: > On 10/29/18 9:40 AM, Martin Liška wrote: >> On 10/27/18 6:15 PM, Michael Ploujnikov wrote: >>> Hi, >>> >>> On 2018-10-26 10:25 a.m., Jan Hubicka wrote: > From aea94273e7a477a03d1ee10a5d9043d6d13b8e8d Mon Sep 17 00:00:00 2001 > From: Michael Pl

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-29 Thread Richard Henderson
On 10/29/18 4:34 PM, Segher Boessenkool wrote: > Is there some better documentation available? This is what google found > for me. I would have like better docs (more compact, etc.) Links to > such would be great to have in readings.html :-) https://openrisc.io/architecture and especially the

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-29 Thread Segher Boessenkool
On Mon, Oct 29, 2018 at 10:34:25PM +0900, Stafford Horne wrote: > On Sun, Oct 28, 2018 at 11:16:13PM +, Richard Henderson wrote: > > On 10/28/18 2:57 AM, Segher Boessenkool wrote: > > > Is this correct? Should this be unsigned (u16 and K)? > > > > No, l.xori is signed. > > Right, sorry, I di

Re: [

2018-10-29 Thread graham stott via gcc-patches
Looks like it fixed an GO Libs failure as well I was having Original message From: Jeff Law Date: 29/10/2018 15:56 (GMT+00:00) To: Segher Boessenkool , Andrew Pinski Cc: GCC Patches Subject: Re: [ On 10/29/18 1:49 AM, Segher Boessenkool wrote: > On Mon, Oct 29, 2018 a

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-29 Thread Jakub Jelinek
On Mon, Oct 29, 2018 at 10:38:11AM -0500, Bill Seurer wrote: > > I'm still wondering what didn't work with 41 bits? AFAICS, due to > > highshadow=highmem-offset and lowshadow=low+offset, and the existence of a > > non-empty shadow-gap, offset must be minimum(vbits)-3 (vbits being one of > > the ab

Re: [PATCH] combine: Fix various shortcomings in make_more_copies (PR87701, PR87780)

2018-10-29 Thread Jeff Law
On 10/29/18 1:49 AM, Segher Boessenkool wrote: > On Mon, Oct 29, 2018 at 12:31:28AM -0700, Andrew Pinski wrote: >>> PR rtl-optimization/87701 >>> PR rtl-optimization/87780 >>> * combine.c (make_more_copies): Rewrite. >> >> I think a better changelog would be :): >> * combine

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-29 Thread Bill Seurer
On 10/29/18 10:26, Michael Matz wrote: Hi, On Mon, 29 Oct 2018, Bill Seurer wrote: Just for the record: am I right that any system using 44 bit of VMA will fail because anything + (1 << 44) will be out of process address space? Yes. And I noticed that documentation in sanitizer_linux.cc is

Re: [PATCH] Fix PR87785

2018-10-29 Thread Richard Biener
tstrap & regtest running on x86_64-unknown-linux-gnu. > > > > Richard. > > > > 2018-10-29 Richard Biener > > > > * tree-vect-slp.c (vect_gather_slp_loads): Only gather > > internal defs. > > > > * gcc.d

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-29 Thread Michael Matz
Hi, On Mon, 29 Oct 2018, Bill Seurer wrote: > >> Just for the record: am I right that any system using 44 bit of VMA will > >> fail because > >> anything + (1 << 44) will be out of process address space? > > > > Yes. > > > >> And I noticed that documentation in sanitizer_linux.cc is misleading:

Re: [PATCH] Fix PR87785

2018-10-29 Thread Martin Liška
x86_64-unknown-linux-gnu. > > Richard. > > 2018-10-29 Richard Biener > > * tree-vect-slp.c (vect_gather_slp_loads): Only gather > internal defs. > > * gcc.dg/torture/20181029-1.c: New testcase. > > Index: gcc/tree-vect-slp.c > =

Re: [PATCH] libgcc: properly destroy mutexes on VxWorks

2018-10-29 Thread Olivier Hainque
Hi Rasmus, > On 29 Oct 2018, at 14:32, Rasmus Villemoes wrote: > > Just as one needs run-time initialization of mutexes, one needs to > destroy them properly to allow the OS to release resources associated > with the semaphore. > > ==changelog== > > libgcc/ > > * config/gthr-vxworks.h (

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-29 Thread Martin Liška
On 10/29/18 2:53 PM, Alexander Monakov wrote: > On Mon, 29 Oct 2018, Martin Liška wrote: >> My question is whether we want to have in GCC 9 time frame or should I wait >> with that? >> Does it worth implementing? > > This is cool, thanks! A few questions/comments on the patch. Hi. Thanks for su

Re: [PATCH] Fix PR87785

2018-10-29 Thread Richard Biener
eveals a thinko... Bootstrap & regtest running on x86_64-unknown-linux-gnu. Richard. 2018-10-29 Richard Biener * tree-vect-slp.c (vect_gather_slp_loads): Only gather internal defs. * gcc.dg/torture/20181029-1.c: New testcase. Index:

Re: [PATCH][rs6000] use index form addresses more often for ldbrx/stdbrx

2018-10-29 Thread Aaron Sawdey
On 10/27/18 12:52 PM, Segher Boessenkool wrote: > Hi Aaron, > > On Sat, Oct 27, 2018 at 11:20:01AM -0500, Aaron Sawdey wrote: >> --- gcc/config/rs6000/rs6000.md (revision 265393) >> +++ gcc/config/rs6000/rs6000.md (working copy) >> @@ -2512,9 +2512,27 @@ >>if (TARGET_POWERPC64 && TAR

ping x2 [PATCH 3/3] [MSP430] Search for MCU data file using environment variable and in a toolchain subdirectory

2018-10-29 Thread Jozef Lawrynowicz
This patch adds functionality to search for devices.csv in both the path specified by the environment variable "MSP430_GCC_INCLUDE_DIR", and the directory "msp430-elf/include/devices" from the toolchain root. These locations are searched if devices.csv is not found on an include path. If devices.c

Extract VXWORKS_NET_LIBS_RTP from VXWORKS_LIBS_RTP

2018-10-29 Thread Olivier Hainque
Hello, This patch extracts the network part of the VXWORKS_LIBS_RTP LIB_SPEC component, so it can be redefined by OS specific configuration files. I used this in the course of the aarch64 port development and verified that I could still build a functional powerpc-vxworks port after the patch. Ol

ping x2 [PATCH 2/3] [MSP430] Search for MCU data file on include paths

2018-10-29 Thread Jozef Lawrynowicz
This patch adds functionality to search the include paths specified with -I for "devices.csv". If the file is found, and a device name has been passed to the -mmcu option, then devices.csv is parsed, and the MCU data for the given device is extracted. >From e85964a398a35a69513da07e4fcdaeed215ae79

Introduce VXWORKS_PERSONALITY

2018-10-29 Thread Olivier Hainque
Hello, This patch simply makes explicit the notion of VxWorks "personality" on which a given port relies, which controls conditional parts exposed by the system headers, depending on the kind of system compiler used to build the VxWorks kernel on which we expect programs will run. This defaults t

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-29 Thread Szabolcs Nagy
On 27/10/18 05:37, Stafford Horne wrote: > +++ b/gcc/config/or1k/linux.h > @@ -0,0 +1,44 @@ > +/* Linux Definitions for OpenRISC. > + Copyright (C) 2018 Free Software Foundation, Inc. > + Contributed by Stafford Horne. > + > + This file is part of GCC. > + > + GCC is free software; you can

ping x2 [PATCH 1/3] [MSP430] Consolidate hard-coded MCU data

2018-10-29 Thread Jozef Lawrynowicz
This patch keeps the hard-coded data as the only way of reading MCU data, but consolidates it in a single file. Extensions to the spec handling in msp430.h mean that the hard-coded data is no longer needed in 't-msp430' for multilib selection, or in the assembler. This is achieved by the driver wh

Re: [RFC][PR87528][PR86677] Disable builtin popcount detection when back-end does not define it

2018-10-29 Thread Richard Biener
On Mon, Oct 29, 2018 at 2:06 AM Kugan Vivekanandarajah wrote: > > Hi Richard and Jeff, > > Thanks for your comments. > > On Fri, 26 Oct 2018 at 19:40, Richard Biener > wrote: > > > > On Fri, Oct 26, 2018 at 4:55 AM Jeff Law wrote: > > > > > > On 10/25/18 4:33 PM, Kugan Vivekanandarajah wrote: >

ping x2 [PATCH 0/3] [MSP430] Add methods to extract MCU data from file

2018-10-29 Thread Jozef Lawrynowicz
The same as previous pings except I removed the patch which updates the hard-coded device data - I'll commit that later as "obvious". Ok for trunk? The following series of patches extends MCU device data handling for the msp430 target, allowing an external file to be read which describes the C

Re: [PR87469] ICE in record_estimate, at tree-ssa-loop-niter.c

2018-10-29 Thread Richard Biener
On Sun, Oct 28, 2018 at 1:11 AM Kugan Vivekanandarajah wrote: > > Hi, > > In the testcase provided in the bug report, max value for niter > estimation is off by one when it is INTEGER_CST. As a results it > asserts at the place where it is checked for equality. > Attached patch fixes this. Bootstr

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-29 Thread Bill Seurer
On 10/29/18 06:24, Jakub Jelinek wrote: On Mon, Oct 29, 2018 at 12:13:04PM +0100, Martin Liška wrote: Just for the record: am I right that any system using 44 bit of VMA will fail because anything + (1 << 44) will be out of process address space? Yes. And I noticed that documentation in san

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-29 Thread Alexander Monakov
On Mon, 29 Oct 2018, Martin Liška wrote: > My question is whether we want to have in GCC 9 time frame or should I wait > with that? > Does it worth implementing? This is cool, thanks! A few questions/comments on the patch. I think there are places that use libiberty C-style hashtab (htab_t), wou

[PATCH] Fix PR87790

2018-10-29 Thread Richard Biener
When fixing compile-time issues with the SLP graph processing I failed to recognize that vect_detect_hybrid_slp_stmts needs to union info over graph edges and thus a simple visited flag doesn't do the trick. The following instead makes sure we propagate to children only after we have visited all

Re: [ARM/FDPIC v3 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2018-10-29 Thread Christophe Lyon
On Fri, 26 Oct 2018 at 17:07, Christophe Lyon wrote: > > On Tue, 23 Oct 2018 at 17:14, Segher Boessenkool > wrote: > > > > On Tue, Oct 23, 2018 at 02:58:21PM +0100, Richard Earnshaw (lists) wrote: > > > On 15/10/2018 11:10, Christophe Lyon wrote: > > > > Do you mean to also make -mfdpic non-exist

Re: [PATCH v3 1/3] or1k: libgcc: initial support for openrisc

2018-10-29 Thread Stafford Horne
On Sun, Oct 28, 2018 at 01:25:54AM +, Richard Henderson wrote: > On 10/27/18 5:37 AM, Stafford Horne wrote: > > +/* Here _init and _fini are empty because .init_array/.fini_array are used > > + exclusively. However, the functions are still needed as required when > > + linking. */ > > +

Re: [PATCH] Make __PRETTY_FUNCTION__-like functions mergeable string csts (PR c++/64266).

2018-10-29 Thread Jason Merrill
On Fri, Oct 26, 2018 at 3:14 AM Martin Liška wrote: > On 10/24/18 7:24 PM, Jason Merrill wrote: > > On Tue, Oct 23, 2018 at 4:59 AM Martin Liška wrote: > >> However, I still see some minor ICEs, it's probably related to > >> decay_conversion in cp_fname_init: > >> > >> 1) ./xg++ -B. > >> /home/

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-29 Thread Stafford Horne
On Sun, Oct 28, 2018 at 11:16:13PM +, Richard Henderson wrote: > On 10/28/18 2:57 AM, Segher Boessenkool wrote: > >> +(define_insn "xorsi3" > >> + [(set (match_operand:SI 0 "register_operand" "=r,r") > >> +(xor:SI > >> + (match_operand:SI 1 "register_operand" "%r,r") > >> + (matc

[PATCH] libgcc: properly destroy mutexes on VxWorks

2018-10-29 Thread Rasmus Villemoes
Just as one needs run-time initialization of mutexes, one needs to destroy them properly to allow the OS to release resources associated with the semaphore. ==changelog== libgcc/ * config/gthr-vxworks.h (__gthread_mutex_destroy): Call semDelete. --- libgcc/config/gthr-vxworks.h | 3 ++-

[PATCH] Fix PR87785

2018-10-29 Thread Richard Biener
The following fixes gone missing load nodes with the SLP tree build now eventually caching them but not having them in the SLP tree. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2018-10-29 Richard Biener PR tree-optimization/87785 * tree-v

Re: [GCC][PATCH][Aarch64] Replace umov with cheaper fmov in popcount expansion

2018-10-29 Thread Richard Henderson
On 10/29/18 10:31 AM, Sam Tebbs wrote: > On 10/23/2018 02:50 PM, Richard Earnshaw (lists) wrote: > >> On 22/10/2018 10:02, Sam Tebbs wrote: >>> diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md >>> index >>> d7473418a8eb62b2757017cd1675493f86e41ef4..77e6f75cc15f06733df7b4

Re: [PATCH] GCOV: introduce --json-format.

2018-10-29 Thread Martin Liška
On 10/10/18 1:46 PM, Martin Liška wrote: > Hi. > > I'm sending updated version of the patch. I made a research and it looks that > actually any significant consumer of GCOV does not use intermediate format: > > https://github.com/gcovr/gcovr/issues/282 > https://github.com/linux-test-project/lcov

Fix build of the D frontend on the Hurd and KFreeBSD

2018-10-29 Thread Matthias Klose
Fix build of the D frontend on the Hurd and KFreeBSD. Where should these changes go, when they are not yet applied upstream? Ok to commit? Matthias # DP: Fix build of the D frontend on the Hurd and KFreeBSD. Index: b/src/gcc/d/dfrontend/object.h

Re: [patch, doc, fortran] Document FINDLOC

2018-10-29 Thread Bernhard Reutner-Fischer
Hi! On Sun, 28 Oct 2018 15:13:49 +0100 Thomas König wrote: One question and some nits below. > === > --- intrinsic.texi(Revision 265569) > +++ intrinsic.texi(Arbeitskopie) > @@ -6021,8 +6022,68 @@ END PROGRAM > @ref{FGET}

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-29 Thread Jakub Jelinek
On Mon, Oct 29, 2018 at 12:13:04PM +0100, Martin Liška wrote: > Just for the record: am I right that any system using 44 bit of VMA will fail > because > anything + (1 << 44) will be out of process address space? Yes. > And I noticed that documentation in sanitizer_linux.cc is misleading: > > .

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-29 Thread Martin Liška
On 10/26/18 4:52 PM, Jakub Jelinek wrote: > On Fri, Oct 26, 2018 at 09:48:54AM -0500, Bill Seurer wrote: >> On 10/26/18 03:57, Jakub Jelinek wrote: >>> On Thu, Oct 25, 2018 at 12:49:42PM +0200, Jakub Jelinek wrote: On Thu, Oct 25, 2018 at 12:15:46PM +0200, marxin wrote: > I've just finishe

Re: [PATCH] Folding and check_function_arguments

2018-10-29 Thread Alexander Monakov
On Thu, 25 Oct 2018, Jason Merrill wrote: > > > > > > Maybe we should remove that in favor of fold_for_warn in > > > check_function_arguments. David, I think your patch also fixes PR 86567. David, Jason, could you comment on doing something similar (using fold_for_warn instead of maybe_constant_

[PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-29 Thread Martin Liška
Hi. As slightly discussed here: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01674.html I fixed a situation where an equal operator of a hash table returns true, while corresponding hash value of a pair of elements is different. That's inconsistent and can probably cause issues in different ar

Re: [PATCH v4] Avoid unnecessarily numbering cloned symbols.

2018-10-29 Thread Martin Liška
On 10/29/18 9:40 AM, Martin Liška wrote: > On 10/27/18 6:15 PM, Michael Ploujnikov wrote: >> Hi, >> >> On 2018-10-26 10:25 a.m., Jan Hubicka wrote: From aea94273e7a477a03d1ee10a5d9043d6d13b8e8d Mon Sep 17 00:00:00 2001 From: Michael Ploujnikov Date: Thu, 25 Oct 2018 13:16:36 -0400 >

Re: [GCC][PATCH][Aarch64] Replace umov with cheaper fmov in popcount expansion

2018-10-29 Thread Sam Tebbs
On 10/23/2018 02:50 PM, Richard Earnshaw (lists) wrote: > On 22/10/2018 10:02, Sam Tebbs wrote: >> diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md >> index >> d7473418a8eb62b2757017cd1675493f86e41ef4..77e6f75cc15f06733df7b47906ee00580bea8d29 >> 100644 >> --- a/gcc/conf

[PATCH. Committed] Fix PR85669.

2018-10-29 Thread Iain Sandoe
Hi, With Segher’s approval on the PR thread I’ve committed the following to trunk and 8 branch. A slightly different patch is needed for 7 branch (under test). thanks Iain gcc/ 2018-10-28 Iain Sandoe PR target/85669 * config/rs6000/darwin.h (STACK_BOUNDARY): New. (RS

[C++ Patch] Improve create_array_type_for_decl locations

2018-10-29 Thread Paolo Carlini
Hi, while working on something else I noticed that by adding a location_t parameter we can improve the locations of those error messages. Tested x86_64-linux. Thanks, Paolo. / /cp 2018-10-29 Paolo Carlini * decl.c (create_array_type_for_decl): Add location_t

[PATCH] S/390: Allow LARL of literal pool entries

2018-10-29 Thread Ilya Leoshkevich
Bootstrapped and regtested on s390x-redhat-linux. r265490 allowed the compiler to choose in a more flexible way whether to use load or load-address-relative-long (LARL) instruction. When it chose LARL for literal pool references, the latter ones were rewritten by pass_s390_early_mach to use UNSPE

Re: Turn complete to incomplete types in free_lang_data

2018-10-29 Thread Jan Hubicka
Hi, this is cleaner version of the patch. During weekend I did some tests with firefox, libreoffice and gcc builds and it seems to work well. For firefox it reaches almost linear scalability of the ltrans files (they are 1.9GB, after increasing number of partitions to 128 they grow to 2GB that loo

Undef CLEAR_INSN_CACHE before #define in vxworks.h

2018-10-29 Thread Olivier Hainque
Hello, This fixes a build failure observed during aarch64 port development effort, corresponds to the intent on this target (we still want to use the vxworks specific definition), and I checked that I could still build a function powerpc-vxworks toolchain after the patch. Olivier 2018-10-29 Oli

Re: [PATCH v4] Avoid unnecessarily numbering cloned symbols.

2018-10-29 Thread Martin Liška
On 10/27/18 6:15 PM, Michael Ploujnikov wrote: > Hi, > > On 2018-10-26 10:25 a.m., Jan Hubicka wrote: >>> From aea94273e7a477a03d1ee10a5d9043d6d13b8e8d Mon Sep 17 00:00:00 2001 >>> From: Michael Ploujnikov >>> Date: Thu, 25 Oct 2018 13:16:36 -0400 >>> Subject: [PATCH] Avoid unnecessarily numberin

Re: [ARM/FDPIC v3 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2018-10-29 Thread Christophe Lyon
On Fri, 26 Oct 2018 at 17:42, Richard Earnshaw (lists) wrote: > > On 26/10/2018 16:25, Christophe Lyon wrote: > > On Tue, 23 Oct 2018 at 16:07, Richard Earnshaw (lists) > > wrote: > >> > >> On 19/10/2018 14:40, Christophe Lyon wrote: > >>> On 12/10/2018 12:45, Richard Earnshaw (lists) wrote: > >>

Re: [PATCH] combine: Fix various shortcomings in make_more_copies (PR87701, PR87780)

2018-10-29 Thread Segher Boessenkool
On Mon, Oct 29, 2018 at 12:31:28AM -0700, Andrew Pinski wrote: > > PR rtl-optimization/87701 > > PR rtl-optimization/87780 > > * combine.c (make_more_copies): Rewrite. > > I think a better changelog would be :): > * combine.c (make_more_copies): Rewrite to be simplier. But

Re: [PATCH] combine: Fix various shortcomings in make_more_copies (PR87701, PR87780)

2018-10-29 Thread Andrew Pinski
On Mon, Oct 29, 2018 at 12:29 AM Segher Boessenkool wrote: > > This rewrites most of make_more_copies, in the process fixing a few PRs > and some other bugs, and working around a few target problems. Certain > notes turn out to actually change the meaning of the RTL, so we cannot > drop them; and

[PATCH] combine: Fix various shortcomings in make_more_copies (PR87701, PR87780)

2018-10-29 Thread Segher Boessenkool
This rewrites most of make_more_copies, in the process fixing a few PRs and some other bugs, and working around a few target problems. Certain notes turn out to actually change the meaning of the RTL, so we cannot drop them; and i386 takes subregs of hard regs. Committing. Segher 2018-10-29