Re: [PATCH v3 1/6, Committed] [MIPS] Split Loongson (MMI) from loongson3a

2018-11-07 Thread Paul Hua
On Wed, Nov 7, 2018 at 5:12 PM Paul Hua wrote: > > Hi, Matthew: > > I committed the patch. Thanks for your review. > After committed this patch some test failure under with-arch=mips64r2(i only test under -with-arch=loongson3a). 664 FAIL: gcc.target/mips/insn-casesi.c -O0 (test for excess

Re: [PATCH] Fix PR87906

2018-11-07 Thread Richard Biener
On November 7, 2018 7:47:43 PM GMT+01:00, Rainer Orth wrote: >Hi Richard, > >> This adds a workaround for LTO decl merging prevailing a >> non-ultimate origin decl, breaking invariants of the middle-end. >> In the future (GCC 10) I hope to have DIE references here so >> this will not be an issue

Re: [patches] Re: [PATCH] Update soft-fp from glibc.

2018-11-07 Thread Kito Cheng
Hi Joseph: I don't have commit right, could you help me to commit that, thanks :) On Thu, Nov 8, 2018 at 1:14 AM Joseph Myers wrote: > > This patch is OK. > > -- > Joseph S. Myers > jos...@codesourcery.com

[doc, committed] clarify -fno-common behavior

2018-11-07 Thread Sandra Loosemore
I've checked in this patch to fix a minor but long-standing bug in the description of -fno-common, PR 42726. -Sandra 2018-11-07 Sandra Loosemore PR middle-end/42726 gcc/ * doc/invoke.texi (Code Gen Options): Clarify -fno-common behavior. Index: gcc/doc/invoke.texi

[doc, committed] remove leading dash from @opindex entries

2018-11-07 Thread Sandra Loosemore
I noticed this buglet when working on the PR80828 fix: The introductory paragraph to the Option Index appendix says: "GCC’s command line options are indexed here without any initial ‘-’ or ‘--’." Indeed, that was mostly true, but there were ~20 index entries that incorrectly included the

Re: [RFC][PATCH LRA] WIP patch to fix one part of PR87507

2018-11-07 Thread Peter Bergner
On 11/7/18 11:36 AM, Jeff Law wrote: > OK with this change. Before I commit, how about I add the following test cases to test both valid and invalid asm constraints? I think I have the reg numbers for the other architectures defined correctly. Peter gcc/testsuite/ PR

Re: [PATCH] Add sinh(tanh(x)) and cosh(tanh(x)) rules

2018-11-07 Thread Segher Boessenkool
On Wed, Nov 07, 2018 at 10:34:30PM +, Wilco Dijkstra wrote: > Hi Jeff, > > > So if we're going from 0->2 ULPs in some cases, do we want to guard it > > with one of the various options, if so, which?  Giuliano's follow-up > > will still have the potential for 2ULPs. > > The ULP difference is

[doc, committed] document -e and --entry

2018-11-07 Thread Sandra Loosemore
Trying to knock off some easy documentation bugs from bugzilla... I've checked in this patch to fix PR driver/80828, about missing documentation for these options that are passed through to the linker. -Sandra 2018-11-07 Sandra Loosemore PR driver/80828 gcc/ * doc/invoke.texi (Option

Re: [PATCH 4/6] [RS6000] Remove constraints on call rounded_stack_size_rtx arg

2018-11-07 Thread Segher Boessenkool
On Wed, Nov 07, 2018 at 04:09:06PM +1030, Alan Modra wrote: > This call arg is unused on rs6000. This is fine. Okay for trunk. Thank you! Segher > * config/rs6000/darwin.md (call_indirect_nonlocal_darwin64, > call_nonlocal_darwin64, call_value_indirect_nonlocal_darwin64, >

Re: [PATCH 3/6] [RS6000] Replace TLSmode with P, and correct tls call mems

2018-11-07 Thread Segher Boessenkool
On Wed, Nov 07, 2018 at 04:08:26PM +1030, Alan Modra wrote: > There is really no need to define a TLSmode mode iterator that is > identical (since !TARGET_64BIT == TARGET_32BIT) to the much used P > mode iterator. Nice :-) > It's nonsense to think we might ever want to support > 32-bit TLS on

[PATCH] minor FDO profile related fixes

2018-11-07 Thread Indu Bhagat
I have been looking at -fdump-ipa-profile dump with an intention to sanitize bits of information so that one may use it to judge the "quality of a profile" in FDO. The overall question I want to address is - are there ways to know which functions were not run in the training run, i.e. have ZERO

Re: [PATCH 1/6] [RS6000] rs6000_output_call for external call insn assembly output

2018-11-07 Thread Segher Boessenkool
On Wed, Nov 07, 2018 at 04:07:15PM +1030, Alan Modra wrote: > +extern const char *rs6000_output_call (rtx *, unsigned int, bool, const char > *); Maybe have a separate rs6000_output_call and rs6000_output_sibcall? Bare boolean function parameters aren't great. (They can of course both call

Re: [PATCH] combine: Do not combine moves from hard registers

2018-11-07 Thread Segher Boessenkool
Hi! On Mon, Nov 05, 2018 at 06:16:16PM +, Renlin Li wrote: > Sorry, this is not correct. Instructions scheduled between x and x+1 > directly use hard register r1. > It is not IRA/LRA assigning r1 to the operands. > > > To reproduce this particular case, you could use: > cc1 -O3 -marm

Re: [PATCH] Verify that last argument of __builtin_expect_with_probability is a real cst (PR c/87811).

2018-11-07 Thread Jeff Law
On 11/7/18 2:36 AM, Martin Liška wrote: > On 11/5/18 7:00 PM, Martin Sebor wrote: >> On 11/01/2018 07:45 AM, Martin Liška wrote: >>> On 11/1/18 1:15 PM, Jakub Jelinek wrote: On Thu, Nov 01, 2018 at 01:09:16PM +0100, Martin Liška wrote: > -range 0.0 to 1.0, inclusive. > +range 0.0 to

Re: [PR87793] reject non-toplevel unspecs in debug loc exprs on x86

2018-11-07 Thread Jeff Law
On 11/7/18 12:42 AM, Alexandre Oliva wrote: > Before revision 254025, we'd reject UNSPECs in debug loc exprs. > TARGET_CONST_NOT_OK_FOR_DEBUG_P still rejects that by default, on all > ports that override it, except for x86, that accepts @gotoff unspecs. > We can indeed accept them in top-level

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 03:23:55PM -0700, Jeff Law wrote: > > @@ -882,8 +883,12 @@ hash_table > >if (insert == INSERT && m_size * 3 <= m_n_elements * 4) > > expand (); > > > > - m_searches++; > > +#if ENABLE_EXTRA_CHECKING > > +if (insert == INSERT) > > + verify (comparable,

[PR/87936] --disable-checking bootstrap break

2018-11-07 Thread Nathan Sidwell
I'm committing this to unbreak a --disable-checking bootstrap build failure. As documented in the PR we think there's an out of bound array access. nathan -- Nathan Sidwell 2018-11-07 Nathan Sidwell PR 87926 * Makefile.in (bitmap.o-warn): Add -Wno-error to unbreak --disable-checking

Re: PING [PATCH] use MAX_OFILE_ALIGNMENT to validate attribute aligned (PR 87795)

2018-11-07 Thread Jeff Law
On 11/6/18 5:06 PM, Martin Sebor wrote: > Ping: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg02081.html I thought I'd already ACK's this one... OK. Jeff

Re: Small typo in iconv.m4

2018-11-07 Thread Jeff Law
On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote: > Hi All, > I was investigating a character set related problem with windows hosted > GDB and I tracked it down to a typo in iconv.m4. This typo caused > libiconv detection to fail and related support was not built into gdb. > > The problem is with the

Re: [PATCH] Add sinh(tanh(x)) and cosh(tanh(x)) rules

2018-11-07 Thread Wilco Dijkstra
Hi Jeff, > So if we're going from 0->2 ULPs in some cases, do we want to guard it > with one of the various options, if so, which?  Giuliano's follow-up > will still have the potential for 2ULPs. The ULP difference is not important since the individual math functions already have ULP of 3 or

Re: [PATCH AutoFDO/4]Fix profile count computation/propagation.

2018-11-07 Thread Jeff Law
On 10/31/18 12:34 AM, bin.cheng wrote: > Hi, > This patch fixes AutoFDO breakage on trunk. The main reason for breakage is > AutoFDO > relies on standalone edge count computing and propagating profile > count/probability info > on CFG, but in new infra, edge count is actually computed from

[committed] Fix type of "num" argument to memcpy in gcc.c-torture/compile/pr65595.c

2018-11-07 Thread Jozef Lawrynowicz
The test uses "unsigned long" as the "num" argument to memcpy, but it should be size_t, and these types are not equivalent on all targets. Committed to trunk. >From 3ebbb8102bd9b984c6f1a1eaf0bca45fe4fd23e1 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Tue, 6 Nov 2018 12:49:00 +

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 05:05:13PM -0500, Fritz Reese wrote: --- a/gcc/fortran/options.c +++ b/gcc/fortran/options.c @@ -32,6 +32,20 @@ along with GCC; see the file COPYING3. If not see gfc_option_t gfc_option; +#define _expand(m) m I think it would be better to avoid names like _expand,

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-11-07 Thread Jeff Law
On 10/30/18 6:28 AM, Martin Liška wrote: > On 10/30/18 11:03 AM, Jakub Jelinek wrote: >> On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: >>> +hashtab_chk_error () >>> +{ >>> + fprintf (stderr, "hash table checking failed: " >>> + "equal operator returns true for a pair " >>> +

Re: [PATCH] Add sinh(tanh(x)) and cosh(tanh(x)) rules

2018-11-07 Thread Jeff Law
On 10/23/18 3:17 AM, Richard Biener wrote: > On Mon, Oct 22, 2018 at 10:09 PM Jeff Law wrote: >> >> On 10/20/18 9:47 AM, Giuliano Augusto Faulin Belinassi wrote: >>> So I did some further investigation comparing the ULP error. >>> >>> With the formula that Wilco Dijkstra provided, there are cases

Re: [PATCH] handle attribute positional arguments consistently (PR 87541, 87542)

2018-11-07 Thread Jeff Law
On 10/24/18 8:02 PM, Martin Sebor wrote: >> No camel case.  Make the enum type lower case and its values upper case. > > Done. > > As an aside, I almost thought that after nearly fours years > I've adjusted to most reviewers' preferences but I'm clearly > not quite there yet.  As usual, this is

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-07 Thread Fritz Reese
On 11/7/18, Jakub Jelinek wrote: > On Wed, Nov 07, 2018 at 03:07:04PM +, Mark Eggleston wrote: > >> PR fortran/87919 >> * options.c (gfc_handle_option): Removed case OPT_fdec_structure >> as it breaks the handling of -fno-dec-structure. > > No entries for the tests, i.e. >

Re: [PATCH] detect attribute mismatches in alias declarations (PR 81824)

2018-11-07 Thread Jeff Law
On 10/23/18 7:50 PM, Martin Sebor wrote: > On 10/23/2018 03:53 PM, Joseph Myers wrote: >> On Mon, 22 Oct 2018, Martin Sebor wrote: >> >>> between aliases and ifunc resolvers.  With -Wattribute-alias=1 >>> that reduced the number of unique instances of the warnings for >>> a Glibc build to just 27. 

Re: [PATCH] Fix PR87691: transparent_union attribute does not work with MODE_PARTIAL_INT

2018-11-07 Thread Marek Polacek
On Tue, Oct 23, 2018 at 08:49:26PM +0100, Jozef Lawrynowicz wrote: > msp430-elf uses the partial int type __int20 for pointers in the large memory > model. __int20 has PSImode, with bitsize of 20. > > A few DejaGNU tests fail when built with -mlarge for msp430-elf, when > transparent unions are

[PATCH] [aarch64] Correct the maximum shift amount for shifted operands.

2018-11-07 Thread christoph . muellner
From: Christoph Muellner The aarch64 ISA specification allows a left shift amount to be applied after extension in the range of 0 to 4 (encoded in the imm3 field). This is true for at least the following instructions: * ADD (extend register) * ADDS (extended register) * SUB (extended

Re: [PATCH] Fix PR87691: transparent_union attribute does not work with MODE_PARTIAL_INT

2018-11-07 Thread Jeff Law
On 10/23/18 1:49 PM, Jozef Lawrynowicz wrote: > msp430-elf uses the partial int type __int20 for pointers in the large memory > > model. __int20 has PSImode, with bitsize of 20. > > A few DejaGNU tests fail when built with -mlarge for msp430-elf, when > transparent unions are used containing 

Re: [PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

2018-11-07 Thread Jeff Law
On 10/20/18 6:01 PM, Martin Sebor wrote: > > The warning only triggers when the bound is less than or equal > to the length of the constant source string (i.e, when strncpy > truncates).  So IIUC, your suggestion would defer folding only > such strncpy calls and let gimple_fold_builtin_strncpy

Re: [PATCH] Add option to control warnings added through attribure "warning"

2018-11-07 Thread Jeff Law
On 10/15/18 9:21 AM, Nikolai Merinov wrote: > Hi Martin, > > On 10/15/18 6:20 PM, Martin Sebor wrote: >> On 10/15/2018 01:55 AM, Nikolai Merinov wrote: >>> Hi Martin, >>> >>> On 10/12/18 9:58 PM, Martin Sebor wrote: On 10/12/2018 04:14 AM, Nikolai Merinov wrote: > Hello, > > In

[gomp5] Merge from trunk

2018-11-07 Thread Jakub Jelinek
Hi! I've merged trunk into gomp-5_0-branch. atomic-5.C testcase needed some adjustments for recent C++ FE changes and the taskloop-reduction-1.c testcase wasn't correct for 32-bit targets. Tested on x86_64-linux and on i686-linux (the latter libgomp only), committed to gomp-5_0-branch.

Re: Free TYPE_VALUES of enums

2018-11-07 Thread Bernhard Reutner-Fischer
On Wed, 7 Nov 2018 14:09:24 +0100 Richard Biener wrote: > On Wed, Nov 7, 2018 at 1:34 PM Jan Hubicka wrote: > > Bootstrapped/regtested x86_64-linux, will commit it after > > lto-bootstrapping uneless there are complains. > > +/* Save some WPA->ltrans streaming by freeing enum values. */ >

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 08:13:29PM +0100, Thomas Schwinge wrote: > Isn't that sufficient for the ABI compatibility that we promise, which is > (unless I'm confused now?) that old (existing) executables continue to > run correctly when dynamically linking against a new libgomp. Or do we > also

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

2018-11-07 Thread Thomas Schwinge
Hi Chung-Lin! On Thu, 30 Aug 2018 21:27:22 +0800, Chung-Lin Tang wrote: > Hi, this patch properly handles OpenACC 'wait' clauses without arguments, > making it an equivalent of "wait all". Thanks! > (current trunk basically discards and ignores such argument-less wait > clauses) Bugs should

Re: [PATCH] Implement std::pmr::unsynchronized_pool_resource

2018-11-07 Thread Jonathan Wakely
On 07/11/18 19:55 +0100, Rainer Orth wrote: Hi Jonathan, Implement std::pmr::unsynchronized_pool_resource * config/abi/pre/gnu.ver: Add new symbols. * include/std/memory_resource (std::pmr::__pool_resource): New class. (std::pmr::unsynchronized_pool_resource):

Re: [PATCH] Implement std::pmr::unsynchronized_pool_resource

2018-11-07 Thread Rainer Orth
Hi Jonathan, > Implement std::pmr::unsynchronized_pool_resource > * config/abi/pre/gnu.ver: Add new symbols. > * include/std/memory_resource (std::pmr::__pool_resource): New class. > (std::pmr::unsynchronized_pool_resource): New class. > * src/c++17/Makefile.am: Add

Re: [PATCH] Fix PR87906

2018-11-07 Thread Rainer Orth
Hi Richard, > This adds a workaround for LTO decl merging prevailing a > non-ultimate origin decl, breaking invariants of the middle-end. > In the future (GCC 10) I hope to have DIE references here so > this will not be an issue there anymore. > > Bootstrapped and tested on

Re: [PATCH], Remove power9 fusion support

2018-11-07 Thread Michael Meissner
On Mon, Nov 05, 2018 at 04:09:23PM -0600, Segher Boessenkool wrote: > Hi Mike, > > On Fri, Nov 02, 2018 at 02:37:34PM -0400, Michael Meissner wrote: > > This patch removes all of the so-called power9 fusion support for the GCC > > compiler. It leaves -mpower9-fusion as a deprecated switch in

[PATCH, arm] Backport -- Fix ICE during thunk generation with -mlong-calls

2018-11-07 Thread Mihail Ionescu
Hi All, This is a backport from trunk for GCC 8 and 7. SVN revision: r264595. Regression tested on arm-none-eabi. gcc/ChangeLog 2018-11-02 Mihail Ionescu Backport from mainiline 2018-09-26 Eric Botcazou * config/arm/arm.c (arm_reorg): Skip Thumb reorg pass

Re: [PATCH, ARM] Clean up arm backend using the @ construct for MD patterns

2018-11-07 Thread Mihail Ionescu
On 10/09/2018 09:52 AM, Ramana Radhakrishnan wrote: On 09/10/2018 09:27, Mihail Ionescu wrote: Hi all, This patch removes some of the machine mode checks from the arm backend when emitting instructions by using the '@' construct (Parameterized Names[2]). It is based on the previous AArch64

Re: [RFC][PATCH LRA] WIP patch to fix one part of PR87507

2018-11-07 Thread Peter Bergner
On 11/7/18 11:36 AM, Jeff Law wrote: > I was referring to a more fundamental check in the IL checkers. Yes, I understood that. I was just replying to Segher's specific issue with this code. I do plan on looking at adding IL verifier checks for subregs of subregs like you requested. > Segher

Re: [RFC][PATCH LRA] WIP patch to fix one part of PR87507

2018-11-07 Thread Jeff Law
On 11/7/18 9:29 AM, Peter Bergner wrote: > On 11/6/18 6:14 PM, Segher Boessenkool wrote: >> Or more general, that what is inside the subreg is a reg, because the >> code does rely on that. > > I think you mean to beef up the following from: > > + if (HARD_REGISTER_P

Re: [PATCH] Update soft-fp from glibc.

2018-11-07 Thread Joseph Myers
This patch is OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH v2] MIPS: Default to --with-llsc for the R5900 Linux target as well

2018-11-07 Thread Fredrik Noring
Hello global GCC reviewers, Would it be possible to apply the reviewed patch below? Thank you, Fredrik On Fri, Oct 19, 2018 at 08:33:33PM +0200, Fredrik Noring wrote: > The Linux kernel requires and emulates LL and SC for the R5900 too. The > special --without-llsc default for the R5900 is

Re: [RFC][PATCH LRA] WIP patch to fix one part of PR87507

2018-11-07 Thread Peter Bergner
On 11/6/18 6:14 PM, Segher Boessenkool wrote: > Or more general, that what is inside the subreg is a reg, because the > code does rely on that. I think you mean to beef up the following from: + if (HARD_REGISTER_P (nop_reg) + &&

[PATCH] MIPS: Add `-mfix-r5900' option for the R5900 short loop erratum

2018-11-07 Thread Fredrik Noring
The short loop bug under certain conditions causes loops to execute only once or twice, due to a hardware bug in the R5900 chip. `-march=r5900' already enables the R5900 short loop workaround. However, the R5900 ISA and most other MIPS ISAs are mutually exclusive since R5900-specific instructions

[PR C++/87904] lookup ICE

2018-11-07 Thread Nathan Sidwell
My recent relaxing of overload ordering broken an invariant that unhiding a hidden decl was assuming. Fixed thusly. nathan -- Nathan Sidwell 2018-11-07 Nathan Sidwell PR c++/87904 * cp-tree.h (struct tree_overload): Fix comment. * tree.c (ovl_iterator::reveal_node): Propagate

[PATCH 2/4] dump_printf: add "%C" for dumping cgraph_node *

2018-11-07 Thread David Malcolm
This patch implements support for %C in dump_printf for dumping cgraph_node *. (I would have preferred to have a code for printing symtab_node * and both subclasses, but there doesn't seem to be a good way for -Wformat to handle inheritance, so, failing that, I went with this approach).

[PATCH 3/4] support %f in pp_format

2018-11-07 Thread David Malcolm
Numerous formatted messages from the inliner use %f, mostly as %f, but occasionally with length modifiers. This patch implements the simplest case of "%f" for pp_format (with no modifier support) to make it easier to port these messages from fprintf to dump_printf_loc. The selftest has an

[PATCH 4/4] ipa-inline.c/tree-inline.c: port from fprintf to dump API (PR ipa/86395)

2018-11-07 Thread David Malcolm
This patch ports various fprintf calls in the inlining code to using the dump API, using the %C format code for printing cgraph_node *. I focused on the dump messages that seemed most significant to end-users; I didn't port all of the calls. Doing so makes this information appear in -fopt-info

[PATCH 1/4] cgraph: add selftest::symbol_table_test

2018-11-07 Thread David Malcolm
This patch adds a selftest fixture for overriding the "symtab" global, so that selftests involving symtab nodes can be isolated from each other: each selftest can have its own symbol_table instance. In particular, this ensures that nodes can have a predictable "order" and thus predictable dump

[PATCH 0/4] Fix -fopt-info-inline (PR ipa/86395)

2018-11-07 Thread David Malcolm
Currently -fopt-info-inline does nothing, as all of the dumping relating to inlining uses fprintf rather than dumpfile.h's dump_* interface. This patch kit adds a %C format code to dumpfile.c for printing cgraph_node *, and uses it to port many of the IPA dump messages to the dump API. I focused

[PATCH, testsuite]: Use int128 effective target for gcc.dg/pr87874.c

2018-11-07 Thread Uros Bizjak
2018-11-07 Uros Bizjak * gcc.dg/pr87874.c: Compile only for int128 effective target. Tested on x86_64-linux-gnu {,-m32} and committed to mainline SVN. Uros. diff --git a/gcc/testsuite/gcc.dg/pr87874.c b/gcc/testsuite/gcc.dg/pr87874.c index 3ab5dcf68ffb..1480a5e54937 100644 ---

Simplify types of arrays

2018-11-07 Thread Jan Hubicka
Hi, this patch simplfies types of arrays so we don't propagate duplicates when record/union contains array of pointers. With this we still miss simplification of pointers to arrays of structures (where we need to rebuild array same way as we rebuild pointers) and enumerate types. That should make

Re: [PATCH, GCC, AARCH64, 6/6] Enable BTI: Add configure option for BTI and PAC-RET

2018-11-07 Thread James Greenhalgh
On Fri, Nov 02, 2018 at 01:38:46PM -0500, Sudakshina Das wrote: > Hi > > This patch is part of a series that enables ARMv8.5-A in GCC and > adds Branch Target Identification Mechanism. > (https://developer.arm.com/products/architecture/cpu-architecture/a-profile/exploration-tools) > > This patch

Re: [PATCH, GCC, AARCH64, 4/6] Enable BTI: Add new to -mbranch-protection.

2018-11-07 Thread James Greenhalgh
On Fri, Nov 02, 2018 at 01:38:25PM -0500, Sudakshina Das wrote: > Hi > > This patch is part of a series that enables ARMv8.5-A in GCC and > adds Branch Target Identification Mechanism. > (https://developer.arm.com/products/architecture/cpu-architecture/a-profile/exploration-tools) > > NOTE: This

Re: Small typo in iconv.m4

2018-11-07 Thread Simon Marchi
On 2018-11-06 11:37, Hafiz Abid Qadeer wrote: Hi All, I was investigating a character set related problem with windows hosted GDB and I tracked it down to a typo in iconv.m4. This typo caused libiconv detection to fail and related support was not built into gdb. The problem is with the

[PATCH] Fix part of PR87913

2018-11-07 Thread Richard Biener
The following fixes MIN/MAX recognition for comparisons that we turned into equality compares (for tests like unsigned < 1). It turns out we don't do a very good job in expanding them, nevertheless this GIMPLE level fix is good and we get slight improvements in code generation. Bootstrap and

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 03:07:04PM +, Mark Eggleston wrote: > PR fortran/87919 > * options.c (gfc_handle_option): Removed case OPT_fdec_structure > as it breaks the handling of -fno-dec-structure. No entries for the tests, i.e. *

Re: [PATCH, GCC, AARCH64, 2/6] Add new arch command line feaures from ARMv8.5-A

2018-11-07 Thread James Greenhalgh
On Fri, Nov 02, 2018 at 01:37:41PM -0500, Sudakshina Das wrote: > Hi > > This patch is part of a series that enables ARMv8.5-A in GCC and > adds Branch Target Identification Mechanism. > (https://developer.arm.com/products/architecture/cpu-architecture/a-profile/exploration-tools) > > This patch

Re: [PATCH, GCC, AARCH64, 1/6] Enable ARMv8.5-A in gcc

2018-11-07 Thread James Greenhalgh
On Fri, Nov 02, 2018 at 01:37:33PM -0500, Sudakshina Das wrote: > Hi > > This patch is part of a series that enables ARMv8.5-A in GCC and > adds Branch Target Identification Mechanism. > (https://developer.arm.com/products/architecture/cpu-architecture/a-profile/exploration-tools) > > This patch

Re: Clear more useless flags

2018-11-07 Thread Richard Biener
On Wed, 7 Nov 2018, Jan Hubicka wrote: > > > + /* TREE_PUBLIC is used to tell if type is anonymous. */ > > > + DECL_EXTERNAL (decl) = 0; > > > + TYPE_DECL_SUPPRESS_DEBUG (decl) = 0; > > > > DECL_EXTERNAL and TYPE_DECL_SUPPRESS_DEBUG map to the same decl_flag_1 ... > > so I'd say

Re: Clear more useless flags

2018-11-07 Thread Jan Hubicka
> > + /* TREE_PUBLIC is used to tell if type is anonymous. */ > > + DECL_EXTERNAL (decl) = 0; > > + TYPE_DECL_SUPPRESS_DEBUG (decl) = 0; > > DECL_EXTERNAL and TYPE_DECL_SUPPRESS_DEBUG map to the same decl_flag_1 ... > so I'd say you should use TYPE_DECL_SUPPRESS_DEBUG only here.

PR fortran/87919 patch for -fno-dec-structure

2018-11-07 Thread Mark Eggleston
Please find attached the patch and a ChangeLog entry. This is my first patch, apologies for any mistakes in the submission process. This patch is the simple removal of an OPT_dec_structure case from a switch statement, it was noticeable as there was no corresponding code for the other dec

[PATCH] Fix PR87914

2018-11-07 Thread Richard Biener
This PR shows one example (IIRC I've seen others recently) where we fail to handle outer loop vectorization because we do a poor job identifying "safe" nested cycles. This improves the situation. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. I've also built SPEC 2006

Re: Clear more useless flags

2018-11-07 Thread Richard Biener
On Wed, 7 Nov 2018, Jan Hubicka wrote: > Hi, > this patch enables bit more merging by clearing more flags that are > unnecesary and differ in practice across different copies of same ODR > types. > > lto-bootstrapped/regtested x86_64-linux, OK? > * tree.c (fld_incomplete_type_of): Clear

Re: GCC options for kernel live-patching (Was: Add a new option to control inlining only on static functions)

2018-11-07 Thread Martin Liška
On 11/7/18 3:27 PM, Jan Hubicka wrote: >> On 11/5/18 10:51 AM, Jan Hubicka wrote: @honza: PING On 10/3/18 12:53 PM, Martin Liška wrote: > On 10/3/18 11:04 AM, Jan Hubicka wrote: >>> >>> That was promised to be done by Honza Hubička. He's very skilled in IPA >>>

Re: GCC options for kernel live-patching (Was: Add a new option to control inlining only on static functions)

2018-11-07 Thread Jan Hubicka
> On 11/5/18 10:51 AM, Jan Hubicka wrote: > >> @honza: PING > >> > >> On 10/3/18 12:53 PM, Martin Liška wrote: > >>> On 10/3/18 11:04 AM, Jan Hubicka wrote: > > > > That was promised to be done by Honza Hubička. He's very skilled in IPA > > optimizations and he's aware > > of

Re: GCC options for kernel live-patching (Was: Add a new option to control inlining only on static functions)

2018-11-07 Thread Martin Liška
On 11/5/18 10:51 AM, Jan Hubicka wrote: >> @honza: PING >> >> On 10/3/18 12:53 PM, Martin Liška wrote: >>> On 10/3/18 11:04 AM, Jan Hubicka wrote: > > That was promised to be done by Honza Hubička. He's very skilled in IPA > optimizations and he's aware > of optimizations that

Clear more useless flags

2018-11-07 Thread Jan Hubicka
Hi, this patch enables bit more merging by clearing more flags that are unnecesary and differ in practice across different copies of same ODR types. lto-bootstrapped/regtested x86_64-linux, OK? * tree.c (fld_incomplete_type_of): Clear TREE_ADDRESSABLE flag.

Re: [PATCH] doc: Use @: where needed

2018-11-07 Thread Jeff Law
On 11/6/18 5:56 PM, Segher Boessenkool wrote: > When an abbreviation ends with a dot followed by whitespace, Texinfo > thinks the dot ends a sentence, and applies spacing rules etc. based > on that. To prevent this, there is the @: macro. > > This patch puts @: after every vs., e.g., and i.e.

Re: Update libquadmath fmaq from glibc, fix nanq issues

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 01:40:11PM +, Joseph Myers wrote: > On Wed, 7 Nov 2018, Jakub Jelinek wrote: > > > Don't know about the dropping of HAVE_FENV_H/USE_FENV_H stuff, don't we > > support libquadmath on targets that don't have fenv.h? > > In other sources, like e.g. expq.c, the USE_FENV_H

Re: Update libquadmath fmaq from glibc, fix nanq issues

2018-11-07 Thread Joseph Myers
On Wed, 7 Nov 2018, Jakub Jelinek wrote: > Don't know about the dropping of HAVE_FENV_H/USE_FENV_H stuff, don't we > support libquadmath on targets that don't have fenv.h? > In other sources, like e.g. expq.c, the USE_FENV_H guards are still kept. All those conditionals are now meant to be

Re: Free TYPE_VALUES of enums

2018-11-07 Thread Richard Biener
On Wed, Nov 7, 2018 at 1:34 PM Jan Hubicka wrote: > > Hi, > this patch make free_lang_data_in_type to free TYPE_VALUE of enum > unless it is an main variant of ODR type (in that case we use them to > produce ODR warnings). C++ represents enum values as CONST_DECLs that > are expensive to stream

Re: [RFC][PR87528][PR86677] Disable builtin popcount detection when back-end does not define it

2018-11-07 Thread Richard Biener
On Fri, Nov 2, 2018 at 10:02 AM Kugan Vivekanandarajah wrote: > > Hi Richard, > Thanks for the review. > On Tue, 30 Oct 2018 at 01:25, Richard Biener > wrote: > > > > On Mon, Oct 29, 2018 at 2:06 AM Kugan Vivekanandarajah > > wrote: > > > > > > Hi Richard and Jeff, > > > > > > Thanks for your

Re: introduce --enable-mingw-full32 to default to --large-address-aware

2018-11-07 Thread JonY
On 11/07/2018 08:34 AM, Alexandre Oliva wrote: > On Nov 1, 2018, JonY wrote: > >> Looks like it causes an error on 64bit: >> /usr/libexec/gcc/x86_64-w64-mingw32/ld: unrecognized option >> '--large-address-aware' > > What does? The patch I suggested? The current trunk? > > What was the

Free TYPE_VALUES of enums

2018-11-07 Thread Jan Hubicka
Hi, this patch make free_lang_data_in_type to free TYPE_VALUE of enum unless it is an main variant of ODR type (in that case we use them to produce ODR warnings). C++ represents enum values as CONST_DECLs that are expensive to stream and unused, so I also updated free_lang_data to replace them by

Re: [PATCH] Reduce number of sreal operator* calls

2018-11-07 Thread Jan Hubicka
> > This reduces the number of $subject calls by computing big_speedup_p > lazily. This caller accounts for roughly a quarter of all operator* > calls for PR38474 and operator* is top of the profile of the whole > compilation. > > Next offenders (callers) are compute_inlined_call_time and >

[PATCH] Reduce number of sreal operator* calls

2018-11-07 Thread Richard Biener
This reduces the number of $subject calls by computing big_speedup_p lazily. This caller accounts for roughly a quarter of all operator* calls for PR38474 and operator* is top of the profile of the whole compilation. Next offenders (callers) are compute_inlined_call_time and edge_badness.

Re: introduce --enable-mingw-full32 to default to --large-address-aware

2018-11-07 Thread Alexandre Oliva
On Nov 1, 2018, JonY <10wa...@gmail.com> wrote: > Looks like it causes an error on 64bit: > /usr/libexec/gcc/x86_64-w64-mingw32/ld: unrecognized option > '--large-address-aware' What does? The patch I suggested? The current trunk? What was the command in this case? How was the toolchain

Re: [PATCH v4 3/6,Committed] [MIPS] Add Loongson EXTensions R2 (EXT2) instructions support

2018-11-07 Thread Paul Hua
sorry, i commits a wrong version patch. Fix the typo and bad logical by commits attached patch. On Wed, Nov 7, 2018 at 5:14 PM Paul Hua wrote: > > On Tue, Oct 16, 2018 at 10:50 AM Paul Hua wrote: > > > > From 16a357d8f844e4bdc45bf385e98b8dc6c0723720 Mon Sep 17 00:00:00 2001 From: Chenghua Xu

Re: [PATCH][AArch64] Add -mcpu/-mtune support for Arm Ares

2018-11-07 Thread Richard Earnshaw (lists)
On 07/11/2018 09:47, Kyrill Tkachov wrote: > Hi all, > > This adds support for the Arm Ares CPU for AArch64. > It implements the Armv8.2-A architecture with the optional features > of statistical profiling, dot product and FP16 on by default. > > Note: Ares is a codename to enable early adopters

Re: Simplify function types

2018-11-07 Thread Richard Biener
On Tue, 6 Nov 2018, Jan Hubicka wrote: > Hi, > this patch simplifies function types. For GCC it cuts number of type > duplicates to half (to about 500 duplicates). I need to analyze the > remaining ones, but i think they are mostly caused by mixing up > complete/incomplete enums and arrays of

[PATCH][arm] Add support for Arm Ares

2018-11-07 Thread Kyrill Tkachov
Hi all, This adds support for the Arm Ares CPU for in the arm port. It implements the Armv8.2-A architecture with the optional features of statistical profiling, dot product and FP16 on by default. Note: Ares is a codename to enable early adopters and in time we will add the final product name

[PATCH][AArch64] Add -mcpu/-mtune support for Arm Ares

2018-11-07 Thread Kyrill Tkachov
Hi all, This adds support for the Arm Ares CPU for AArch64. It implements the Armv8.2-A architecture with the optional features of statistical profiling, dot product and FP16 on by default. Note: Ares is a codename to enable early adopters and in time we will add the final product name once

Re: [PATCH v4 0/3] OpenRISC port

2018-11-07 Thread Richard Henderson
On 11/6/18 9:21 PM, Stafford Horne wrote: > As you can see this is v4 of the OpenRISC port patch series, I just want to > mention that there are a few things pointed out during the v3 review that I > have > not fixed, and do not plan before pushing upstream. These are either because > I >

Re: [PATCH] Verify that last argument of __builtin_expect_with_probability is a real cst (PR c/87811).

2018-11-07 Thread Martin Liška
On 11/5/18 7:00 PM, Martin Sebor wrote: > On 11/01/2018 07:45 AM, Martin Liška wrote: >> On 11/1/18 1:15 PM, Jakub Jelinek wrote: >>> On Thu, Nov 01, 2018 at 01:09:16PM +0100, Martin Liška wrote: -range 0.0 to 1.0, inclusive. +range 0.0 to 1.0, inclusive.  The @var{probability} argument

Re: [PATCH][RFC] Fix UBSAN in postreload-gcse.c (PR rtl-optimization/87868).

2018-11-07 Thread Martin Liška
On 11/6/18 7:55 PM, Jeff Law wrote: > On 11/6/18 7:05 AM, Martin Liška wrote: >> Hi. >> >> The patch is adding a check overflow in eliminate_partially_redundant_load. >> Question is whether the usage of conditional compilation of >> __builtin_mul_overflow >> is fine? >> >> Thanks, >> Martin >>

Re: [PATCH 2/4] Fix GNU coding style.

2018-11-07 Thread Martin Liška
On 11/7/18 10:17 AM, Jakub Jelinek wrote: > On Wed, Nov 07, 2018 at 10:12:17AM +0100, Martin Liška wrote: >>/* Register memory allocation descriptor for container PTR. ORIGIN >> identifies >> type of container and GGC identifes if the allocation is handled in GGC >> memory. Each

[PATCH v4 6/6,Committed] [MIPS] Add Loongson 2K1000 processor support

2018-11-07 Thread Paul Hua
On Tue, Oct 16, 2018 at 10:50 AM Paul Hua wrote: > > From 7ab0637b28b22bdb00e021692ceb8372855c8a87 Mon Sep 17 00:00:00 2001 From: Chenghua Xu Date: Wed, 7 Nov 2018 09:38:09 +0800 Subject: [PATCH 6/6] Add support for Loongson 2K1000 processor. gcc/ * config/mips/gs264e.md: New. *

[PATCH v4 4/6, Committed] [MIPS] Add Loongson 3A1000 processor support

2018-11-07 Thread Paul Hua
On Tue, Oct 16, 2018 at 10:50 AM Paul Hua wrote: > > From ef10d77f03e693299611e6b4eee2ae6375a5841d Mon Sep 17 00:00:00 2001 From: Chenghua Xu Date: Tue, 6 Nov 2018 21:12:46 +0800 Subject: [PATCH 4/6] Add support for Loongson 3A1000 processor. gcc/ * config/mips/loongson3a.md: Rename to ... *

Re: [PATCH 2/4] Fix GNU coding style.

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 10:12:17AM +0100, Martin Liška wrote: >/* Register memory allocation descriptor for container PTR. ORIGIN > identifies > type of container and GGC identifes if the allocation is handled in GGC > memory. Each location is identified by file NAME, LINE in

[PATCH v4 5/6,Committed] [MIPS] Add Loongson 3A2000/3A3000 processor support

2018-11-07 Thread Paul Hua
On Tue, Oct 16, 2018 at 10:50 AM Paul Hua wrote: > > From 51c914e8c2b2e4c7cc93718e563a8f55f0161ff9 Mon Sep 17 00:00:00 2001 From: Chenghua Xu Date: Wed, 7 Nov 2018 09:27:05 +0800 Subject: [PATCH 5/6] Add support for Loongson 3A2000/3A3000 processor. gcc/ * config/mips/gs464e.md: New. *

[PATCH v4 3/6,Committed] [MIPS] Add Loongson EXTensions R2 (EXT2) instructions support

2018-11-07 Thread Paul Hua
On Tue, Oct 16, 2018 at 10:50 AM Paul Hua wrote: > > From 73a4aac5034307cf7369bb70fa407709502fffbf Mon Sep 17 00:00:00 2001 From: Chenghua Xu Date: Fri, 31 Aug 2018 11:55:48 +0800 Subject: [PATCH 3/6] Add support for Loongson EXT2 instructions. gcc/ * config/mips/mips-protos.h

Re: [PATCH 2/4] Fix GNU coding style.

2018-11-07 Thread Martin Liška
The version I've just installed. M. >From ff99a2f57f3372c66aa25ed0c8e36697b49fee56 Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 7 Nov 2018 10:05:41 +0100 Subject: [PATCH] Fix GNU coding style (V2). gcc/ChangeLog: 2018-11-07 Martin Liska * mem-stats.h: Fix GNU coding style. ---

[PATCH v4 2/6, Committed] [MIPS] Split Loongson EXTensions (EXT) instructions from loongson3a

2018-11-07 Thread Paul Hua
On Tue, Oct 16, 2018 at 10:50 AM Paul Hua wrote: > > From b1dfcb228934e3cde90f408056192ed7faff4417 Mon Sep 17 00:00:00 2001 From: Chenghua Xu Date: Tue, 6 Nov 2018 17:04:36 +0800 Subject: [PATCH 2/6] Add support for Loongson EXT instructions. gcc/ * config/mips/mips.h

[PATCH v3 1/6, Committed] [MIPS] Split Loongson (MMI) from loongson3a

2018-11-07 Thread Paul Hua
Hi, Matthew: I committed the patch. Thanks for your review. On Tue, Oct 16, 2018 at 10:50 AM Paul Hua wrote: > > From f0e4191439f1dd212b766ea80852aad1919e4887 Mon Sep 17 00:00:00 2001 From: Chenghua Xu Date: Mon, 5 Nov 2018 16:34:50 +0800 Subject: [PATCH 1/6] Add support for loongson mmi

  1   2   >