[Committed] S/390: Support vector load/store alignment hints

2018-11-20 Thread Andreas Krebbel
The IBM z14 POP adds an optional alignment operand to the vl, vst, vlm, and vstm instruction (vector loads and stores). Vectors residing on 8 or 16 byte boundaries might get loaded or stored faster on some models given the instruction uses the proper hint operand. A wrong hint will hurt

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2018-11-20 Thread Thomas Koenig
Hi Jakub, I'd like to ping this patch, ok for trunk? OK. Thanks for the patch! Before 9.0 is released, we should also document the flag (and the extension it supports) in the manual, and note it in changes.html and on the Wiki. Would you also do that? Regards Thomas

Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

2018-11-20 Thread Uros Bizjak
On Wed, Nov 21, 2018 at 12:50 AM Jeff Law wrote: > > + /* x86 targets use mode-switching infrastructure to > > + conditionally insert vzeroupper instruction at the exit > > + from the function and there is no need to switch the > > + mode before

Re: Stream TREE_TYPE of TYPE_DECLs again

2018-11-20 Thread Jan Hubicka
> PR lto/87957 > * tree.c (fld_decl_context): Break out from ... > (free_lang_data_in_decl): ... here; free TREE_PUBLIC, TREE_PRIVATE > DECL_ARTIFICIAL of TYPE_DECL; do not free TREE_TYPE of TYPE_DECL. > (fld_incomplete_type_of): Build copy of TYP_DECL. > *

Re: [PATCH 06/10] GCN back-end config

2018-11-20 Thread Jeff Law
On 11/16/18 9:28 AM, Andrew Stubbs wrote: > This patch contains the configuration adjustments needed to enable the GCN > back-end. > > The new configure check for dlopen is required to allow building the new > gcn-run tool. This tool uses libdl to load the HSA runtime libraries, which > are

Fix regression introduced by 88069

2018-11-20 Thread Jeff Law
Richi's recent change to fix 88069 is causing various targets to fail tree-ssa/20030711-2.c. That test is verifying a variety of optimizations occur during the first DOM pass. Prior to Richi's change FRE1 would do some significant cleanups of the IL and as a result DOM was fully able to optimize

libgo patch committed: Always define _AT_FDCWD and IPv6MTUInfo

2018-11-20 Thread Ian Lance Taylor
This libgo patch alwayss define _AT_FDCWD and IPv6MTUInfo in the syscall package. They aren't defined by old versions of glibc, but are required by the code in syscall_linux.go. This should fix GCC PR 88060. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian

Re: [maintainer-scipts] Add a bugzilla script

2018-11-20 Thread David Malcolm
On Tue, 2018-11-20 at 11:08 +0100, Martin Liška wrote: > Hi. > > It's the script that I used to identify potentially resolvable bugs. > That's done > by parsing of comments and seeking for trunk/branch commits. Sample > output looks > as follows: > >

compute discriminator info for overrides

2018-11-20 Thread Alexandre Oliva
In some cases of overriding or resetting locations, we might retain discriminator info from earlier locations, when we should take discriminator information from the overriding location or reset it. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog * final.c

Re: [PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-20 Thread Ian Lance Taylor
On Wed, Nov 14, 2018 at 6:45 AM, Tom de Vries wrote: > On 14-11-18 14:25, Jakub Jelinek wrote: >> On Wed, Nov 14, 2018 at 02:08:05PM +0100, Tom de Vries wrote: +btest_dwz_CFLAGS = $(AM_CFLAGS) -g -O0 >>> >>> Hmm, I already discovered that specifying the -O0 doesn't work, since >>> it's

Re: [PATCH 10/10] Port testsuite to GCN

2018-11-20 Thread Jeff Law
On 11/16/18 9:29 AM, Andrew Stubbs wrote: > This collection of miscellaneous patches configures the testsuite to run on > AMD > GCN in a standalone (i.e. not offloading) configuration. It assumes you have > your Dejagnu set up to run binaries via the gcn-run tool. > > 2018-11-16 Andrew Stubbs

Re: [PATCH 03/10] GCN libgcc.

2018-11-20 Thread Jeff Law
On 11/16/18 9:27 AM, Andrew Stubbs wrote: > This patch contains the GCN port of libgcc. > > Since the previous posting, I've removed gomp_print.c and reduction.c, > as well as addressing some other feedback. > > 2018-11-16 Andrew Stubbs > Kwok Cheung Yeung > Julian Brown

Re: [PATCH 01/10] Fix IRA ICE.

2018-11-20 Thread Jeff Law
On 11/16/18 9:27 AM, Andrew Stubbs wrote: > > This patch is unchanged from that which was posted before. Discussion > fizzled out there and I was too busy with other patches to restart it > then. This issue needs to be resolved before libgfortran can be > compiled for GCN. > > The IRA pass

Re: [maintainer-scipts] Add a bugzilla script

2018-11-20 Thread Martin Sebor
On 11/20/2018 03:08 AM, Martin Liška wrote: Hi. It's the script that I used to identify potentially resolvable bugs. That's done by parsing of comments and seeking for trunk/branch commits. Sample output looks as follows: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88084 branches: trunk

Re: [PATCH] avoid error_mark_node in -Wsizeof-pointer-memaccess (PR 88065)

2018-11-20 Thread Jeff Law
On 11/19/18 5:36 PM, Martin Sebor wrote: > On 11/19/2018 04:10 PM, Jeff Law wrote: >> On 11/17/18 3:45 PM, Martin Sebor wrote: >>> -Wsizeof-pointer-memaccess fails with an ICE when one of >>> the arguments is ill-formed (error_mark_node).  To avoid >>> the error the attached patch has the function

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-20 Thread Martin Sebor
+void test_2 (void) +{ + takes_int_ptr(ivar); /* { dg-warning "" "" { target c } } */ + /* { dg-error "" "" { target c++ } .-1 } */ + /* { dg-message "possible fix: take the address with '&'" "" { target *-*-* } .-2 } */ + + /* Expect an '&' fix-it hint. */ + /* { dg-begin-multiline-output

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-20 Thread Jeff Law
On 11/19/18 2:23 PM, David Malcolm wrote: [ Snip ] > > The above code is in c-family, but same_type_p is specific to C++, > so the change is not quite trivial. > > Here's a v3 of the patch which moves same_type_p from cp/cp-tree.h > to c-family/c-common.h, converting it from a macro to an

Re: [PATCH, ARM, ping3] PR85434: Prevent spilling of stack protector guard's address on ARM

2018-11-20 Thread Jeff Law
On 11/16/18 7:56 AM, Thomas Preudhomme wrote: > Ping? I thought I acked the target independent stuff a while back. What's still waiting on review here? jeff

Re: [PATCH 5/6] ifcvt: Only created temporaries as needed.

2018-11-20 Thread Jeff Law
On 11/15/18 4:38 AM, Robin Dapp wrote: >> This looks pretty reasonable. ISTM it ought to be able to go forward if >> it's tested independently. > > The test suite already passes, any other tests you have in mind? To be > honest I suppose noce_convert_multiple_sets will currently never >

Re: [PATCH v2, target]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

2018-11-20 Thread Jeff Law
On 11/20/18 12:40 PM, Uros Bizjak wrote: > Hello! > > Attached patch is a different approach to the problem of split return > copies in create_pre_exit. It turns out that for vzeroupper insertion > pass, we actually don't need to insert a mode switch before the return > copy, it is enough to

Re: Fix PR37916 (unnecessary spilling)

2018-11-20 Thread Jeff Law
On 11/20/18 6:42 AM, Michael Matz wrote: > Hi, > > this bug report is about cris generating worse code since tree-ssa. The > effect is also visible on x86-64. The symptom is that the work horse of > adler32.c (from zlib) needs spills in the inner loop, while gcc 3 did not, > and those spills

Re: [maintainer-scipts] Add a bugzilla script

2018-11-20 Thread Jeff Law
On 11/20/18 3:08 AM, Martin Liška wrote: > Hi. > > It's the script that I used to identify potentially resolvable bugs. That's > done > by parsing of comments and seeking for trunk/branch commits. Sample output > looks > as follows: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88084

Stream TREE_TYPE of TYPE_DECLs again

2018-11-20 Thread Jan Hubicka
Hi, this patch recovers location infomration in the ODR warnings. Because location info is not attached to types but corresponding TYPE_DECLs, we need to prevent TYPE_DECLs to be merged when corresponding types are not merged. To achieve this I no longer clear TREE_TYPE of TYPE_DECLs which puts

Re: [PATCH][libbacktrace] Factor out read_string

2018-11-20 Thread Jeff Law
On 11/15/18 9:02 AM, Tom de Vries wrote: > Hi, > > This patch factors out new function read_string in dwarf.c. > > Bootstrapped and reg-tested on x86_64. > > OK for trunk (or, for stage1)? > > Thanks, > - Tom > > [libbacktrace] Factor out read_string > > 2018-11-15 Tom de Vries > >

Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

2018-11-20 Thread Jeff Law
On 11/20/18 3:24 AM, Uros Bizjak wrote: > On Tue, Nov 20, 2018 at 8:59 AM Eric Botcazou wrote: >> >>> The blockage was introduced as a fix for PR14381 [1] in r79265 [2]. >>> Later, the blockage was moved after return label as a fix for PR25176 >>> [3] in r107871 [4]. >>> >>> After that, r122626

Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

2018-11-20 Thread Jeff Law
On 11/19/18 12:58 PM, Uros Bizjak wrote: > Hello! > > The assert in create_pre_exit at mode-switching.c expects return copy > pair with nothing in between. However, the compiler starts mode > switching pass with the following sequence: > > (insn 19 18 16 2 (set (reg:V2SF 21 xmm0) >

Re: [PATCH][driver] Ensure --help=params lines end with period

2018-11-20 Thread Jeff Law
On 11/20/18 4:51 AM, Tom de Vries wrote: > Hi, > > this patch ensures that gcc --help=params lines end with a period by: > - fixing the help message of param HOT_BB_COUNT_FRACTION, and > - adding a test-case. > > Build and tested on x86_64. > > OK for trunk? > > Thanks, > - Tom > > [driver]

Re: [PATCH] Do not mix -fsanitize=thread and -mabi=ms (PR sanitizer/88017).

2018-11-20 Thread Jeff Law
On 11/20/18 5:22 AM, Martin Liška wrote: > Hi. > > It's very similar to what I did few days ago for -fsanitize=address and > -mabi=ms. > > Patch survives tests on x86_64-linux-gnu and bootstraps. > > Ready for trunk? > Thanks, > Martin > > gcc/ChangeLog: > > 2018-11-20 Martin Liska > >

Re: [PATCH, libstdc++] Implement P0415 More constexpr for std::complex.

2018-11-20 Thread Ed Smith-Rowland
On 11/19/18 6:13 AM, Jonathan Wakely wrote: On 16/11/18 19:39 -0500, Ed Smith-Rowland wrote: @@ -322,67 +323,43 @@   //@{   ///  Return new complex value @a x plus @a y.   template -    inline complex<_Tp> +    inline _GLIBCXX20_CONSTEXPR complex<_Tp>     operator+(const complex<_Tp>& __x,

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-20 Thread Joseph Myers
On Tue, 20 Nov 2018, David Malcolm wrote: > Should I do: You should do whatever is appropriate for the warning in question. But if what's appropriate for the warning in question includes types that are compatible but not the same, the comments need to avoid saying it's about the types being

Re: [C++ PATCH] Fix ICE in constexpr OBJ_TYPE_REF handling (PR c++/88110)

2018-11-20 Thread Jason Merrill
OK. On Tue, Nov 20, 2018 at 3:51 PM Jakub Jelinek wrote: > > Hi! > > The comment in OBJ_TYPE_REF handling code correctly says that we are > looking for x.D.2103.D.2094, but it is important that x is not an > INDIRECT_REF or something similar as in the following testcase - we can't > really

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-20 Thread David Malcolm
On Tue, 2018-11-20 at 02:46 +, Joseph Myers wrote: > On Mon, 19 Nov 2018, David Malcolm wrote: > > > +/* C implementation of same_type_p. > > + Returns true iff TYPE1 and TYPE2 are the same type, in the > > usual > > + sense of `same'. */ > > + > > +bool > > +same_type_p (tree type1,

Re: C++ PATCH to implement P1094R2, Nested inline namespaces

2018-11-20 Thread Jason Merrill
On 11/19/18 5:12 PM, Marek Polacek wrote: On Mon, Nov 19, 2018 at 10:33:17PM +0100, Jakub Jelinek wrote: On Mon, Nov 19, 2018 at 04:21:19PM -0500, Marek Polacek wrote: 2018-11-19 Marek Polacek Implement P1094R2, Nested inline namespaces. * g++.dg/cpp2a/nested-inline-ns1.C:

[PATCH 5/6] [og8] Backport parts of upstream declare-allocate patch

2018-11-20 Thread Julian Brown
This patch adjusts mappings used for some special cases in Fortran (e.g. allocatable scalars) on og8 to match code that is already upstream, or that has been submitted but not yet reviewed. Parts taken from https://gcc.gnu.org/ml/gcc-patches/2018-09/msg01205.html and parts reverted from

[PATCH 6/6] [og8] OpenACC refcounting refresh

2018-11-20 Thread Julian Brown
This patch represents a mild overhaul of reference counting for OpenACC in libgomp. It's been partly automatically checked (using code not yet quite finished nor submitted upstream), but it's already more precise than the pre-patch implementation (as demonstrated by adjustments to

[PATCH 3/6] [og8] OpenACC 2.6 manual deep copy support (attach/detach)

2018-11-20 Thread Julian Brown
Previously posted upstream: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00826.html gcc/c/ * c-parser.c (c_parser_omp_variable_list): Allow deref (->) in variable lists. (c_parser_oacc_all_clauses): Re-alphabetize cases. * c-typeck.c

[PATCH 0/6] [og8] OpenACC attach/detach

2018-11-20 Thread Julian Brown
This patch series is a backport of the OpenACC attach/detach support to the openacc-gcc-8-branch branch. It was previously posted upstream here: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00823.html This version of the series has been adjusted to account for features on the branch that are

[PATCH 4/6] [og8] Interaction of dynamic/multidimensional arrays with attach/detach.

2018-11-20 Thread Julian Brown
OpenACC multidimensional (or "dynamic") arrays do not seem to fit very neatly into the attach/detach mechanism described for OpenACC 2.6, that is if the user tries to use a multidimensional array as a field in a struct. This patch disallows that combination, for now at least. Multidimensional

[PATCH 1/6] [og8] Host-to-device transfer coalescing & magic offset value self-documentation

2018-11-20 Thread Julian Brown
Previously posted upstream: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00825.html libgomp/ * libgomp.h (OFFSET_INLINED, OFFSET_POINTER, OFFSET_STRUCT): Define. * target.c (FIELD_TGT_EMPTY): Define. (gomp_coalesce_chunk): New. (gomp_coalesce_buf): Use

[PATCH 2/6] [og8] Factor out duplicate code in gimplify_scan_omp_clauses

2018-11-20 Thread Julian Brown
Previously posted upstream: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00824.html gcc/ * gimplify.c (insert_struct_component_mapping) (check_base_and_compare_lt): New. (gimplify_scan_omp_clauses): Outline duplicated code into calls to above two

Re: [PATCH] handle unusual targets in -Wbuiltin-declaration-mismatch (PR 88098)

2018-11-20 Thread Martin Sebor
By calling builtin_decl_explicit rather than builtin_decl_implicit the updated patch in the attachment avoids test failures due to missing warnings on targets with support for long double but whose libc doesn't support C99 functions like fabsl (such as apparently aarch64-linux). Martin On

Re: [RFC C++ PATCH] Improve locations of id-expressions and operator "" (PR c++/87386)

2018-11-20 Thread David Malcolm
On Tue, 2018-11-20 at 21:57 +0100, Jakub Jelinek wrote: > Hi! > > This PR is complaining about range covering the first token from > an id-expression: > pr87386.C:4:15: error: static assertion failed: foo > 4 | static_assert(foo::test::value, "foo"); > | ^~~ > The following patch

Re: [PATCH] handle unusual targets in -Wbuiltin-declaration-mismatch (PR 88098)

2018-11-20 Thread Martin Sebor
On 11/20/2018 08:56 AM, Christophe Lyon wrote: On Mon, 19 Nov 2018 at 22:38, Martin Sebor wrote: The gcc.dg/Wbuiltin-declaration-mismatch-4.c test added with the recent -Wbuiltin-declaration-mismatch enhancement to detect calls with incompatible arguments to built-ins declared without a

[RFC C++ PATCH] Improve locations of id-expressions and operator "" (PR c++/87386)

2018-11-20 Thread Jakub Jelinek
Hi! This PR is complaining about range covering the first token from an id-expression: pr87386.C:4:15: error: static assertion failed: foo 4 | static_assert(foo::test::value, "foo"); | ^~~ The following patch adjust that to: pr87386.C:4:31: error: static assertion failed: foo

[C++ PATCH] Fix ICE in constexpr OBJ_TYPE_REF handling (PR c++/88110)

2018-11-20 Thread Jakub Jelinek
Hi! The comment in OBJ_TYPE_REF handling code correctly says that we are looking for x.D.2103.D.2094, but it is important that x is not an INDIRECT_REF or something similar as in the following testcase - we can't really devirtualize in that case because we really don't know what it points to.

[committed] Fix omp simd clone creation for multiple return stmts (PR tree-optimization/87895)

2018-11-20 Thread Jakub Jelinek
Hi! In certain cases like the testcases below there are multiple return stmts in the function for which we create simd clones and the simd clone adjusting code wasn't handling that case properly, some bbs could end up with non-fallthru edges to the increment bb even without a gimple_goto at the

[PATCH] Fix up method-nonnull-1.mm testcase on Solaris (PR testsuite/88090)

2018-11-20 Thread Jakub Jelinek
Hi! The following testcase fails on Solaris, because it doesn't print there 'size_t', but 'std::size_t', as the type is defined by system headers and it is not under gcc control how exactly is size_t defined. The following patch fixes that by using a different typedef which we have total control

Re: [PATCH] clarify comments for implicit_p flag for built-ins

2018-11-20 Thread Martin Sebor
On 11/20/2018 11:02 AM, Martin Sebor wrote: Would the updated comments in the attached patch more accurately describe the purpose of the IMPLICIT_P flag and the builtin_decl_explicit() and builtin_decl_implicit() functions? I ended up here while trying to understand the differences between the

Re: [C++ PATCH] Fix ICE in adjust_temp_type (PR c++/87506)

2018-11-20 Thread Jakub Jelinek
On Sun, Nov 18, 2018 at 08:33:39PM -0500, Jason Merrill wrote: > On Fri, Nov 16, 2018 at 4:26 PM Jakub Jelinek wrote: > > I admit this is just a shot in the dark, but I don't see why > > one couldn't adjust a type of EMPTY_CLASS_EXPR to EMPTY_CLASS_EXPR > > with a different variant of the same

Re: Fix PR rtl-optimization/85925

2018-11-20 Thread Segher Boessenkool
Hi Eric, On Tue, Nov 20, 2018 at 10:05:21AM +0100, Eric Botcazou wrote: > +/* Return true if X is an operation that always operates on the full > + registers for WORD_REGISTER_OPERATIONS architectures. */ > + > +inline bool > +word_register_operation_p (const_rtx x) > +{ > + switch (GET_CODE

[PATCH v2, target]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438

2018-11-20 Thread Uros Bizjak
Hello! Attached patch is a different approach to the problem of split return copies in create_pre_exit. It turns out that for vzeroupper insertion pass, we actually don't need to insert a mode switch before the return copy, it is enough to split edge to exit block - so we can emit vzeroupper at

[PATCH] Fix missing dump_impl_location_t values, using a new dump_metadata_t

2018-11-20 Thread David Malcolm
The dump_* API attempts to capture emission location metadata for the various dump messages, but looking in -fsave-optimization-record shows that many dump messages are lacking useful impl_location values, instead having this location within dumpfile.c: "impl_location": {

Re: [PATCH] RISC-V: Pass -mno-relax through to assembler if supported

2018-11-20 Thread Jim Wilson
On 11/18/18 7:28 AM, James Clarke wrote: GCC will emit ".option (no)relax" in its outputted assembly, but when using it as an assembler driver, such as for preprocessed assembly, it's merely preprocessing and therefore will not generate this directive. Therefore we should pass -mno-relax on to

Re: [PATCH v2 1/3] Allow memory operands for PTWRITE

2018-11-20 Thread Andi Kleen
On Tue, Nov 20, 2018 at 11:53:15AM +0100, Richard Biener wrote: > On Fri, Nov 16, 2018 at 8:07 AM Uros Bizjak wrote: > > > > On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > > > > > From: Andi Kleen > > > > > > The earlier PTWRITE builtin definition was unnecessarily restrictive, > > >

Re: [PATCH v2 2/3] Add a pass to automatically add ptwrite instrumentation

2018-11-20 Thread Andi Kleen
On Tue, Nov 20, 2018 at 01:04:19PM +0100, Richard Biener wrote: > Since your builtin clobbers memory Hmm, maybe we could get rid of that, but then how to avoid the optimizer moving it around over function calls etc.? The instrumentation should still be useful when the program crashes, so we don't

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-20 Thread Joseph Myers
On Tue, 20 Nov 2018, Jakub Jelinek wrote: > hardcoding /usr/include looks just very wrong here. That should always be > dependent on the configured prefix or better be relative from the driver, > gcc should be relocatable. Or at least come from configure. It should e.g. > honor the sysroot

[PATCH] clarify comments for implicit_p flag for built-ins

2018-11-20 Thread Martin Sebor
Would the updated comments in the attached patch more accurately describe the purpose of the IMPLICIT_P flag and the builtin_decl_explicit() and builtin_decl_implicit() functions? I ended up here while trying to understand the differences between the functions on different targets and decide

[PATCH v3] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-11-20 Thread Christoph Muellner
Tested with "make check" and no regressions found. This patch depends on the struct xgene1_prefetch_tune, which has been acknowledged already: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00985.html *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner *

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-20 Thread Pat Haugen
On 11/20/18 10:53 AM, Kyrill Tkachov wrote: > On 20/11/18 16:48, Pat Haugen wrote: >> On 11/19/18 2:30 PM, Pat Haugen wrote: This is a follow-up from https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html This version introduces an "artificial" property of the dependencies

PING: V2 [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-20 Thread H.J. Lu
On Mon, Nov 5, 2018 at 2:02 PM H.J. Lu wrote: > > Hi Richard, Jakub, > > Can you take a look at this patch? The last review from Kirill was in > June. > > Thanks. > > > H.J. > -- > There are many duplicated AVX2/AVX512 vec_dup patterns like: > > (define_insn "avx2_vec_dup" > [(set

Re: [PATCH 3/6] [RS6000] Replace TLSmode with P, and correct tls call mems

2018-11-20 Thread Segher Boessenkool
On Tue, Nov 13, 2018 at 11:20:08PM +1030, Alan Modra wrote: > There is really no need to define a TLSmode mode iterator that is > identical (since !TARGET_64BIT == TARGET_32BIT) to the much used P > mode iterator. It's nonsense to think we might ever want to support > 32-bit TLS on 64-bit or vice

PING^3: [PATCH] apply_subst_iterator: Handle define_split/define_insn_and_split

2018-11-20 Thread H.J. Lu
On Tue, Nov 13, 2018 at 6:08 AM H.J. Lu wrote: > > On Sun, Nov 4, 2018 at 7:24 AM H.J. Lu wrote: > > > > On Fri, Oct 26, 2018 at 12:44 AM H.J. Lu wrote: > > > > > > On 10/25/18, Uros Bizjak wrote: > > > > On Fri, Oct 26, 2018 at 8:48 AM H.J. Lu wrote: > > > >> > > > >> On 10/25/18, Uros

Re: Simplify enumerate and array types

2018-11-20 Thread Jan Hubicka
> > Somehow do this first, otherwise 'incomplete' above is useless > work? Well, there are two types but one is main variant of the other. I have restructured the code and avoided the duplicate lookup & code duplication. The attached patch boostraps and I plan to commit it after bit of further

Patch ping (was Re: [PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839))

2018-11-20 Thread Jakub Jelinek
Hi! On Tue, Nov 13, 2018 at 10:28:16AM +0100, Jakub Jelinek wrote: > 2018-11-13 Jakub Jelinek > > PR target/87839 > * config/aarch64/atomics.md (@aarch64_compare_and_swap): Use > rIJ constraint for aarch64_plus_operand rather than rn. > > *

Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2018-11-20 Thread Jakub Jelinek
Hi! I'd like to ping this patch, ok for trunk? > 2018-11-12 Jakub Jelinek > Mark Eggleston > > * lang.opt (fdec-include): New option. > * options.c (set_dec_flags): Set also flag_dec_include. > * scanner.c (include_line): Change return type from bool to int. >

Re: [PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-11-20 Thread Christoph Müllner
> On 20.11.2018, at 17:43, Kyrill Tkachov wrote: > > On 20/11/18 16:20, Christoph Müllner wrote: >>> On 20.11.2018, at 17:14, Kyrill Tkachov wrote: >>> >>> Hi Christoph, >>> >>> On 20/11/18 15:22, Christoph Muellner wrote: Tested with "make check" and no regressions found.

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-20 Thread Kyrill Tkachov
On 20/11/18 16:48, Pat Haugen wrote: On 11/19/18 2:30 PM, Pat Haugen wrote: This is a follow-up from https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html This version introduces an "artificial" property of the dependencies produced in sched-deps.c that is recorded when they are created

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-20 Thread Pat Haugen
On 11/19/18 2:30 PM, Pat Haugen wrote: >> This is a follow-up from >> https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html >> This version introduces an "artificial" property of the dependencies >> produced in >> sched-deps.c that is recorded when they are created due to >>

Re: [PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-11-20 Thread Kyrill Tkachov
On 20/11/18 16:20, Christoph Müllner wrote: On 20.11.2018, at 17:14, Kyrill Tkachov wrote: Hi Christoph, On 20/11/18 15:22, Christoph Muellner wrote: Tested with "make check" and no regressions found. *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner *

Re: [PATCH 2/6] [RS6000] rs6000_indirect_call_template

2018-11-20 Thread Segher Boessenkool
Hi Alan, On Tue, Nov 13, 2018 at 11:19:03PM +1030, Alan Modra wrote: > Like the last patch for external calls, now handle most assembly code > for indirect calls in one place. The patch also merges some insns, > correcting some !rs6000_speculate_indirect_jumps cases branching to > LR, which

[Committed] S/390: Fix flogr RTX.

2018-11-20 Thread Andreas Krebbel
The flogr instruction uses a 64 bit register pair target operand. In the RTX we model this as a write to a TImode register. Unfortunately the RTX's being assigned to the two parts of the target operand were swapped. This is no problem if in the end the flogr instruction will be emitted since

Re: [PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-11-20 Thread Christoph Müllner
> On 20.11.2018, at 17:14, Kyrill Tkachov wrote: > > Hi Christoph, > > On 20/11/18 15:22, Christoph Muellner wrote: >> Tested with "make check" and no regressions found. >> >> *** gcc/ChangeLog *** >> >> 2018-xx-xx Christoph Muellner >> >> * config/aarch64/aarch64-cores.def: Define

Re: [PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-11-20 Thread Kyrill Tkachov
Hi Christoph, On 20/11/18 15:22, Christoph Muellner wrote: Tested with "make check" and no regressions found. *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner * config/aarch64/aarch64-cores.def: Define emag. * config/aarch64/aarch64-tune.md: Regenerated with emag.

Re: [PATCH 1/6] [RS6000] rs6000_call_template for external call insn assembly output

2018-11-20 Thread Segher Boessenkool
On Tue, Nov 13, 2018 at 11:17:55PM +1030, Alan Modra wrote: > Version 2. > > This is a first step in tidying rs6000 call patterns, in preparation > to support inline plt calls. Okay for trunk. Thanks for the patch, and for the rework! Segher > * config/rs6000/rs6000-protos.h

Improve ODR warnings

2018-11-20 Thread Jan Hubicka
Hi, this patch fixes another problem with ODR warnings (and I hope I am one patch away from closing that PR). As shown in the first testcase Martin attached, we output very confusing warning about wrong alignment of subtype instead of noticing that type contains field of type that already

Re: [PATCH] handle unusual targets in -Wbuiltin-declaration-mismatch (PR 88098)

2018-11-20 Thread Christophe Lyon
On Mon, 19 Nov 2018 at 22:38, Martin Sebor wrote: > > The gcc.dg/Wbuiltin-declaration-mismatch-4.c test added with > the recent -Wbuiltin-declaration-mismatch enhancement to detect > calls with incompatible arguments to built-ins declared without > a prototype fails on a few targets due to

[PR 87926] bitmap -Wno-error=array-bounds

2018-11-20 Thread Nathan Sidwell
Applying a more focussed fix, as suggested by Richard. nathan -- Nathan Sidwell 2018-11-20 Nathan Sidwell PR 87926 * Makefile.in (bitmap.o-warn): Use -Wno-error=array-bounds. Index: Makefile.in === --- Makefile.in (revision

Re: [PATCH] make function_args_iterator a proper iterator

2018-11-20 Thread Martin Sebor
On 11/20/2018 02:21 AM, Richard Biener wrote: On Mon, Nov 19, 2018 at 4:36 PM Martin Sebor wrote: On 11/19/2018 03:32 AM, Richard Biener wrote: On Sat, Nov 17, 2018 at 12:05 AM Martin Sebor wrote: To encourage and simplify the adoption of iterator classes in GCC the attached patch turns

[PATCH v2] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-11-20 Thread Christoph Muellner
Tested with "make check" and no regressions found. *** gcc/ChangeLog *** 2018-xx-xx Christoph Muellner * config/aarch64/aarch64-cores.def: Define emag. * config/aarch64/aarch64-tune.md: Regenerated with emag. * config/aarch64/aarch64.c (emag_tunings): New struct.

Re: [PATCH] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-11-20 Thread Christoph Müllner
Hi Kyrill, thank's for your comments. > On 20.11.2018, at 11:08, Kyrill Tkachov wrote: > > Hi Christoph, > > Thank you for the patch. > Can you please confirm how this has been tested? Tested with "make check" and no regressions found. Will put that info into the mail next time. > > On

Re: Fix PR37916 (compile time regression)

2018-11-20 Thread Richard Biener
On Tue, Nov 20, 2018 at 3:19 PM Michael Matz wrote: > > Hi, > > On Tue, 20 Nov 2018, Richard Biener wrote: > > > > Anyway, regstrapped on x86-64-linux, no regressions. Okay for trunk? > > > > Ick. Given you do that only for one stmt kind and it looks kind of ugly > > wouldn't it be better to

Re: [RFC][PATCH]Merge VEC_COND_EXPR into MASK_STORE after loop vectorization

2018-11-20 Thread Renlin Li
Hi Richard, On 11/14/2018 02:59 PM, Richard Biener wrote: On Fri, Nov 9, 2018 at 4:49 PM Renlin Li wrote: Hi Richard, On 11/09/2018 11:48 AM, Richard Biener wrote: On Thu, Nov 8, 2018 at 5:55 PM Renlin Li wrote: Hi Richard, I don't see the masked load here on x86_64 btw. (I don't see

Re: C++ PATCH to implement P1094R2, Nested inline namespaces

2018-11-20 Thread Marek Polacek
On Tue, Nov 20, 2018 at 10:36:32AM +0100, Jakub Jelinek wrote: > On Tue, Nov 20, 2018 at 10:25:01AM +0100, Richard Biener wrote: > > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > > > Just another small comment - given the usual high number of > > C++ regressions delaying the release

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-20 Thread Jakub Jelinek
On Tue, Nov 20, 2018 at 03:14:02PM +0100, Martin Liška wrote: > Following patch is a follow up of the discussion we had on IRC about > locations where a Fortran pre-include should be searched. > > With the patch applied I see now: > $ strace -f -s512 ./xgcc -B. ~/Programming/testcases/usage.F90

Re: Fix PR37916 (compile time regression)

2018-11-20 Thread Michael Matz
Hi, On Tue, 20 Nov 2018, Richard Biener wrote: > > Anyway, regstrapped on x86-64-linux, no regressions. Okay for trunk? > > Ick. Given you do that only for one stmt kind and it looks kind of ugly > wouldn't it be better to splat out gimple_set_location (g, > input_location) to all 108

[PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-20 Thread Martin Liška
Hi. Following patch is a follow up of the discussion we had on IRC about locations where a Fortran pre-include should be searched. With the patch applied I see now: $ strace -f -s512 ./xgcc -B. ~/Programming/testcases/usage.F90 -c 2>&1 | grep math-vector

Re: Fix PR37916 (unnecessary spilling)

2018-11-20 Thread Alexander Monakov
On Tue, 20 Nov 2018, Michael Matz wrote: > > I'm wondering about testcase: should I add an x86-64 specific that tests > for no stack accesses, or would that be too constraining in the future? > > Regstrapped on x86-64-linux, no regressions. Okay for trunk? By the way, this patch helps x86-64

Re: Fix PR37916 (compile time regression)

2018-11-20 Thread Richard Biener
On Tue, Nov 20, 2018 at 2:23 PM Michael Matz wrote: > > Hi, > > the testcase gcc.dg/20020425-1.c was once a compile time hog. With > current trunk it only needs 7 seconds (on my machine, with -O0 cc1) but > there's still something to improve as virtually all of that time is > wasted in

Fix PR37916 (unnecessary spilling)

2018-11-20 Thread Michael Matz
Hi, this bug report is about cris generating worse code since tree-ssa. The effect is also visible on x86-64. The symptom is that the work horse of adler32.c (from zlib) needs spills in the inner loop, while gcc 3 did not, and those spills go away with -fno-tree-reassoc. The underlying

Fix PR37916 (compile time regression)

2018-11-20 Thread Michael Matz
Hi, the testcase gcc.dg/20020425-1.c was once a compile time hog. With current trunk it only needs 7 seconds (on my machine, with -O0 cc1) but there's still something to improve as virtually all of that time is wasted in repeatedly scanning the same (long) sequence of gimple statements to

Re: [PATCH] Remove unreachable nodes before IPA profile pass (PR ipa/87706).

2018-11-20 Thread Jan Hubicka
> Hi. > > In order to fix the warnings mentioned in the PR, we need > to run remove_unreachable_nodes after early tree passes. That's > however possible only within a IPA pass. Thus I'm calling that > before the profile PASS. > > Patch survives regression tests on ppc64le-linux-gnu and majority

[PATCH] Do not mix -fsanitize=thread and -mabi=ms (PR sanitizer/88017).

2018-11-20 Thread Martin Liška
Hi. It's very similar to what I did few days ago for -fsanitize=address and -mabi=ms. Patch survives tests on x86_64-linux-gnu and bootstraps. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2018-11-20 Martin Liska PR sanitizer/88017 * config/i386/i386.c

[PATCH] Fix PR88105

2018-11-20 Thread Richard Biener
Boostrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. >From 27b32c8684c9703b92f5c035ebb6f06b9e2a20af Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Tue, 20 Nov 2018 10:33:16 +0100 Subject: [PATCH] fix-pr88105 2018-11-20 Richard Biener PR

Re: [PATCH]Come up with -flive-patching master option.

2018-11-20 Thread Martin Liška
On 11/19/18 4:52 PM, Qing Zhao wrote: > >> On Nov 19, 2018, at 2:11 AM, Martin Liška > > wrote: >> >> On 11/16/18 5:04 PM, Qing Zhao wrote: >>> On Nov 16, 2018, at 9:26 AM, Martin Liška >>> > wrote: On 11/16/18

Re: [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests.

2018-11-20 Thread Martin Liška
On 11/16/18 6:01 PM, Renlin Li wrote: > Hi Martin, > > Seems the change is not checked in yet? Sorry, I've just installed the patch. Martin > > Thanks, > Renlin > > On 10/22/2018 01:22 PM, Martin Liška wrote: >> On 10/22/18 12:09 PM, Jakub Jelinek wrote: >>> On Mon, Oct 22, 2018 at

Re: [PATCH v2 2/3] Add a pass to automatically add ptwrite instrumentation

2018-11-20 Thread Richard Biener
On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote: > > From: Andi Kleen > > Add a new pass to automatically instrument changes to variables > with the new PTWRITE instruction on x86. PTWRITE writes a 4 or 8 byte > field into an Processor Trace log, which allows low over head > logging of

[PATCH][driver] Ensure --help=params lines end with period

2018-11-20 Thread Tom de Vries
Hi, this patch ensures that gcc --help=params lines end with a period by: - fixing the help message of param HOT_BB_COUNT_FRACTION, and - adding a test-case. Build and tested on x86_64. OK for trunk? Thanks, - Tom [driver] Ensure --help=params lines end with period 2018-11-20 Tom de Vries

Re: [PATCH 06/10] GCN back-end config

2018-11-20 Thread Andrew Stubbs
On 16/11/2018 17:44, Joseph Myers wrote: On Fri, 16 Nov 2018, Andrew Stubbs wrote: * config.sub: Recognize amdgcn*-*-amdhsa. config.sub should be copied from upstream config.git (along with config.guess at the same time), once the support has been added there; it shouldn't be patched

Re: GCC 8 backports

2018-11-20 Thread Martin Liška
On 10/3/18 11:23 AM, Martin Liška wrote: > On 9/25/18 8:48 AM, Martin Liška wrote: >> Hi. >> >> One more tested patch. >> >> Martin >> > > One more tested patch. > > Martin > Hi. One another tested patch that I'm going to install. Martin >From 94cd1e55e5baec63b7a80c59fdd8b5c52595c9e9 Mon Sep

Re: [PATCH AutoFDO/2]Treat ZERO as common profile probability/count

2018-11-20 Thread bin.cheng
Sender:Jan Hubicka Sent at:2018 Nov 5 (Mon) 22:21 To:Richard Biener Cc:bin.cheng ; GCC Patches Subject:Re: [PATCH AutoFDO/2]Treat ZERO as common profile probability/count > > > On Wed, Oct 31, 2018 at 7:30 AM bin.cheng > > wrote: > > > > > > Hi, > > > In new profile probability/count

  1   2   >