[doc, committed] Document -Wmissing-noreturn

2018-11-25 Thread Sandra Loosemore
I've checked in this patch to fix PR 57166. -Sandra 2018-11-25 Sandra Loosemore PR c/57166 gcc/ * doc/invoke.texi (Option Summary): Add -Wmissing-noreturn. (Warning Options): Likewise. Index: gcc/doc/invoke.texi === ---

[doc,committed] clarify docs for function attribute "const"

2018-11-25 Thread Sandra Loosemore
I've checked in the attached patch for PR79738. -Sandra 2018-11-25 Sandra Loosemore PR web/79738 gcc/ * doc/extend.texi (Common Function Attributes): Clarify that functions with "const" attribute can read const global variables. Index: gcc/doc/extend.texi

Re: [PATCH 1/4] introduce struct strlen_data_t into gimple-fold

2018-11-25 Thread Martin Sebor
On 10/10/18 1:39 PM, Jeff Law wrote: On 10/2/18 10:37 AM, Martin Sebor wrote: [1/4] - Introduce struct strlen_data_t into gimple-fold This patch introduces a new data structure to reduce the number of arguments and overloads of the get_range_strlen API.  One of the goals of this change is to 

Re: [PATCH] target/58397: add host_hooks for NetBSD to make precompiled headers work

2018-11-25 Thread Krister Walfridsson
On Sun, 25 Nov 2018, Maya Rashish wrote: gcc/config.host | 4 ++ gcc/config/host-netbsd.c | 85 gcc/config/x-netbsd | 4 ++ 3 files changed, 93 insertions(+) create mode 100644 gcc/config/host-netbsd.c create mode 100644 gcc/config/x-netbsd

[doc, committed] use preferred placement of type attributes in examples

2018-11-25 Thread Sandra Loosemore
I've checked in this patch for PR 54265, after getting clarification that there really is a reason why it's preferred to place type attributes after the struct/union/enum keyword instead of after the closing brace. -Sandra 2018-11-25 Sandra Loosemore PR other/54265 gcc/ *

Re: [PATCH] add simple attribute introspection

2018-11-25 Thread Martin Sebor
On 11/25/18 7:11 AM, Rainer Orth wrote: Hi Martin, I'm seeing the same on sparc-sun-solaris2.11, plus +FAIL: c-c++-common/builtin-has-attribute-3.c -std=gnu++14 (test for excess errors) +FAIL: c-c++-common/builtin-has-attribute-3.c -std=gnu++17 (test for excess errors) +FAIL:

[PATCH] target/58397: add host_hooks for NetBSD to make precompiled headers work

2018-11-25 Thread Maya Rashish
--- gcc/config.host | 4 ++ gcc/config/host-netbsd.c | 85 gcc/config/x-netbsd | 4 ++ 3 files changed, 93 insertions(+) create mode 100644 gcc/config/host-netbsd.c create mode 100644 gcc/config/x-netbsd diff --git a/gcc/config.host

[PATCH v3 1/2] Add a pass to automatically add ptwrite instrumentation

2018-11-25 Thread Andi Kleen
From: Andi Kleen [v3: addressing review comments and fixing more bugs. Instrumentation is now based on generic walkers and SSA, which minimizes redundancies and avoids corner cases. Now able to trace floats/doubles too. Some fixes for issues from running the full test suite with -fvartrace=all,

[PATCH v3 2/2] Add tests for the vartrace pass

2018-11-25 Thread Andi Kleen
From: Andi Kleen [v3: Added more tests. Use more targeted match for trace.] So far they are mostly i386 target specific. Later they could be moved up to architecture specific if some other architecture adds vartracing. This would need abstracing the scanning for the trace function.

[PATCH, pdp11] Fix 64 bit divide

2018-11-25 Thread Paul Koning
This fixes a number of testsuite failures in pdp11. Committed. paul ChangeLog: 2018-11-25 Paul Koning * config/pdp11/pdp11.h (TARGET_HAS_NO_HW_DIVIDE): Define. Index: config/pdp11/pdp11.h === ---

Re: [RS6000] Delete OBJECT_PEF and TARGET_MACOS

2018-11-25 Thread Segher Boessenkool
On Sun, Nov 25, 2018 at 10:53:30PM +1030, Alan Modra wrote: > Nothing references these macros. Bootstrapped etc. powerpc64le-linux. > > * config/rs6000/rs6000.h (OBJECT_PEF, TARGET_MACOS): Delete. Thanks! Okay for trunk. Segher

Re: [testsuite] Disable gdc execution tests without libphobos

2018-11-25 Thread Iain Buclaw
On Sun, 25 Nov 2018 at 16:08, Rainer Orth wrote: > > On targets with gdc enabled (most with --enable-languages=all or with an > explicit --enable-languges=d), but libphobos not built (many), all gdc.* > execution tests FAIL because already libgphobos.spec is missing. > > This is easy to avoid,

[testsuite] Disable gdc execution tests without libphobos

2018-11-25 Thread Rainer Orth
On targets with gdc enabled (most with --enable-languages=all or with an explicit --enable-languges=d), but libphobos not built (many), all gdc.* execution tests FAIL because already libgphobos.spec is missing. This is easy to avoid, however, as the following patch does. It adds D support to

PING^2: V4 [PATCH] C/C++: Add -Waddress-of-packed-member

2018-11-25 Thread H.J. Lu
On Sun, Nov 4, 2018 at 7:16 AM H.J. Lu wrote: > > On Tue, Sep 25, 2018 at 8:46 AM H.J. Lu wrote: > > > > On Fri, Aug 31, 2018 at 2:04 PM, Jason Merrill wrote: > > > On 07/23/2018 05:24 PM, H.J. Lu wrote: > > >> > > >> On Mon, Jun 18, 2018 at 12:26 PM, Joseph Myers > > >> wrote: > > >>> > > >>>

Re: [PATCH] add simple attribute introspection

2018-11-25 Thread Rainer Orth
Hi Martin, >> I'm seeing the same on sparc-sun-solaris2.11, plus >> >> +FAIL: c-c++-common/builtin-has-attribute-3.c -std=gnu++14 (test for >> excess errors) >> +FAIL: c-c++-common/builtin-has-attribute-3.c -std=gnu++17 (test for >> excess errors) >> +FAIL: c-c++-common/builtin-has-attribute-3.c

[RS6000] Delete OBJECT_PEF and TARGET_MACOS

2018-11-25 Thread Alan Modra
Nothing references these macros. Bootstrapped etc. powerpc64le-linux. * config/rs6000/rs6000.h (OBJECT_PEF, TARGET_MACOS): Delete. diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h index c7934c601ed..f9d5173ebd6 100644 --- a/gcc/config/rs6000/rs6000.h +++

[RS6000] PR11848 rs6000_emit_move long double split

2018-11-25 Thread Alan Modra
This split is disabled for power7 and up, so we don't often see its bad effects. However, on a powerpc-linux compiler (which defaults to PPC750 judging from rs6000/sysv4.h) we see long double ld1 (void) { return 1.0L; } compiled with -msoft-float -O2 -S resulting in ld1:

[RS6000] PowerPC64 soft-float

2018-11-25 Thread Alan Modra
This patch aims to prevent long sequences loading soft-float constants. For 32-bit, it makes sense to load values inline to a gpr with lis, addi, but not so much for 64-bit where a 5 insn sequence might be needed for each gpr. For TFmode in particular, a 10 insn sequence is reduced to 2 loads

[RS6000] num_insns_constant ICE

2018-11-25 Thread Alan Modra
This patch came about from investigating an ICE that appeared when I was retesting an old half-baked patch of mine to rs6000_rtx_costs. If a const_double is fed to rs6000_is_valid_and_mask and from there to rs6000_is_valid_mask where INTVAL is used, gcc will ICE. The num_insns_constant ICE was

[RS6000] movdi_internal64 insn lengths

2018-11-25 Thread Alan Modra
Fixes alternatives wi<-Oj (xxlxor), wi<-wM (xxlorc) and wv<-wS. Bootstrapped etc. powerpc64le-linux. * config/rs6000/rs6000.md (movdi_internal64): Correct lengths. diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md index c4d697f856b..11097717268 100644 ---

[RS6000] CONST_DOUBLE tidy

2018-11-25 Thread Alan Modra
Once upon a time CONST_DOUBLE was used to hold large integer constants that didn't fit into a CONST_INT. Now that CONST_INT is always at least 64 bits, and the rs6000 backend uses CONST_WIDE_INT for larger integers, there is no need for old code dealing with integers in CONST_DOUBLE. The rs6000

[RS6000] "G" and "H" constraints

2018-11-25 Thread Alan Modra
The patch fixes two cases where the "G" and "H" constraints were used incorrectly. Their purpose is calculating insn lengths. Thus it never makes sense to put "GH" together or with "F" in an insn alternative. movdi_internal32 used "GHF" in an alternative so I replaced that with "F", and added

[RS6000] Bogus easy_fp_constant call

2018-11-25 Thread Alan Modra
easy_fp_constant accepts const_double, easy_vector_constant accepts const_vector. Calling one from the other therefore will always return false. I believe the zero_constant call in easy_vector_constant will cover the 0.0 case of easy_fp_constant for KFmode and TFmode. Bootstrapped and

Re: [PATCH, d] Fix IdentityExp comparison for complex floats

2018-11-25 Thread Iain Buclaw
On Sat, 24 Nov 2018 at 11:43, Johannes Pfau wrote: > > Currently all identity comparisons for complex types (c1 is c2) return > true. This is caused by the rrent implementation being only correct for > real types, so this adds new code for the complex type cases. > > Fixes

*ping* – PR C++/88114 - PATCH for destructor not generated for "virtual ~destructor() = default"

2018-11-25 Thread Tobias Burnus
On 21 November 2018, Tobias Burnus wrote: Hello all, if a class contains any 'virtual ... = 0', it's an abstract class and for an abstract class, the destructor not added to the vtable. For a normal virtual ~class() { } that's not a problem as the class::~class() destructor will be