C++ PATCH for c++/88548, this accepted in static member functions

2018-12-22 Thread Marek Polacek
I noticed that we weren't diagnosing using 'this' in noexcept-specifiers of static member functions, and Jakub pointed out that this is also true for trailing-return-type. cp_parser has local_variables_forbidden_p to detect using local vars and 'this' in certain contexts, so let's use that.

Re: [PATCH, OpenACC] Enable GOMP_MAP_FIRSTPRIVATE_INT for OpenACC

2018-12-22 Thread Julian Brown
On Tue, 18 Dec 2018 13:47:34 +0100 Jakub Jelinek wrote: > On Thu, Dec 13, 2018 at 03:44:25PM +, Julian Brown wrote: > > +static tree > > +convert_to_firstprivate_int (tree var, gimple_seq *gs) > > +{ > > + tree type = TREE_TYPE (var), new_type = NULL_TREE; > > + tree tmp = NULL_TREE; > > +

Fix devirtualization with LTO

2018-12-22 Thread Jan Hubicka
Hi, while fixing Firefox issues I also noticed that type simplification completely disabled type based devirtualization on LTO path. Problem is that method pointers now point to simplified type and obj_type_ref_class is not ready for that. I also moved testcases where it makes sense to lto so

Re: [PATCH] PR fortran/85798 -- Check for allocatable components in data statement

2018-12-22 Thread Steve Kargl
On Thu, Dec 20, 2018 at 05:00:19PM -0800, Steve Kargl wrote: > On Sun, Dec 16, 2018 at 11:04:44AM -0800, Steve Kargl wrote: > > The attached patch has been tested on i586-*-freebsd and x86_64-*-freebsd. > > If a data-statement-object is a component of a derived type, it checks if > > that

Re: [PATCH, C++] Fix PR c++/88261

2018-12-22 Thread Bernd Edlinger
On 12/21/18 2:03 AM, Martin Sebor wrote: > On 12/20/18 2:07 PM, Bernd Edlinger wrote: >> On 12/20/18 6:50 PM, Martin Sebor wrote: >>> On 12/20/18 10:46 AM, Martin Sebor wrote: On 12/17/18 7:58 AM, Jason Merrill wrote: > On 12/15/18 3:36 AM, Bernd Edlinger wrote: >> this patch

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2018-12-22 Thread Iain Sandoe
Hi Julian, > On 21 Dec 2018, at 16:47, Julian Brown wrote: > > On Fri, 21 Dec 2018 14:31:19 +0100 > Jakub Jelinek wrote: > >> On Fri, Dec 21, 2018 at 01:23:03PM +, Julian Brown wrote: >>> 2018-xx-yy Nathan Sidwell > >>> * testsuite/libgomp.oacc-c++/pr71959-a.C: New. >>> *

Re: [patch, fortran] Fix PR 85544

2018-12-22 Thread Paul Richard Thomas
Hi Thomas, That's OK for 7- through 9-branches. Thanks for the fix. Paul On Sun, 16 Dec 2018 at 22:01, Thomas Koenig wrote: > > Hello world, > > the PR pointed out an old regression because the front-end optimization > pass was substituting 2**n with ishift(1,n), where n was an array. > >

Re: [PATCH] PR fortran/88169 -- remove error condition/message

2018-12-22 Thread Thomas Koenig
Hi Steve, The attached patch addresses an issue submitted by Neil Carlson. He and I have an exchange in the PR's audit trail hashing out the validity of his code example. I also asked on the J3 mailing about the his code. It seems that language of the Fortran standard may have been

*ping* [patch, fortran] Fix PR 85544

2018-12-22 Thread Thomas Koenig
Ping? the PR pointed out an old regression because the front-end optimization pass was substituting 2**n with ishift(1,n), where n was an array. Simply removing the optimization for that case would have been easy, but also introduced a performance regression. So, for this, I moved the