Re: Backports to 8.x branch

2019-02-13 Thread Jakub Jelinek
On Sat, Feb 09, 2019 at 09:52:52AM +0100, Jakub Jelinek wrote: > And two further ones now, bootstrapped/regtested on powerpc64{,le}-linux > and committed. 4 further ones, bootstrapped/regtested on x86_64-linux and i686-linux. Jakub 2019-02-14 Jakub Jelinek Backported from

Re: [PATCH] Swap ubsan and early uninit warning passes (PR middle-end/89284)

2019-02-13 Thread Richard Biener
On February 14, 2019 12:10:54 AM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The ubsan pass makes early uninit warning harder (and often doesn't >warn), >because e.g. for enum/bool loads we add instrumentation and the reads >from >the fields isn't easily visible to the uninit pass, we have > _7 =

[PATCH] i386: Properly encode xmm16-xmm31/ymm16-ymm31 for vector move

2019-02-13 Thread H.J. Lu
On Mon, Feb 11, 2019 at 05:24:24PM +0100, Jakub Jelinek wrote: > On Mon, Feb 11, 2019 at 04:56:45PM +0100, Uros Bizjak wrote: > > > Let's first define what MODE_XI means in standard_sse_constant_opcode > > > as well as in all these mov patterns for with and without AVX512VL. > > > Without > > >

V2 [PATCH] driver: Also prune joined switches with negation

2019-02-13 Thread H.J. Lu
On Thu, Feb 14, 2019 at 12:15:53AM +0100, Jakub Jelinek wrote: > On Wed, Feb 13, 2019 at 03:08:01PM -0800, H.J. Lu wrote: > > > How does this test verify that both -fno-builtin-* options are in effect? > > > That is, how does it fail if you remove either or both of those options? > > > > > > >

Go patch committed: Compile thunks with -Os

2019-02-13 Thread Ian Lance Taylor
Nikhil Benesch noticed that changes in the GCC backend were making the use of defer functions that call recover less efficient. A defer thunk is a generated function that looks like this (this is the entire function body): if !runtime.setdeferretaddr() { deferredFunction() } L:

Re: [PR fortran/88248, patch] - [F18] Bogus warning about obsolescent feature: Labeled DO statement

2019-02-13 Thread Jerry DeLisle
On 2/13/19 2:38 PM, Harald Anlauf wrote: The attached patch moves the check for labeled DO statements to the place where a label is referenced instead of where a label was defined, which lead to false positives. Regtested on x86_64-pc-linux-gnu. OK for trunk? Thanks Harald, All OK with

Re: [-fcompare-debug] var tracking options are not optimization options

2019-02-13 Thread Ian Lance Taylor
> 2019-02-13 Ian Lance Taylor > > * optc-save-gen.awk: Set var_opt_hash for initial optimizations > and set current index for other optimizations. > > 2019-02-13 Ian Lance Taylor > > * gcc.dg/func-attr-1.c: New test. I went ahead and committed this patch. Ian

[Patch, aarch64] Issue warning/error for mixing functions with/without aarch64_vector_pcs attribute

2019-02-13 Thread Steve Ellcey
Szabolcs pointed out that my SIMD ABI patches that implement the aarch64_vector_pcs attribute do not generate a warning or error when being mixed with functions that do not have the attribute because the 'affects_type_identity' field was false in the attribute table. This patch fixes that. I

[PATCH] document __builtin_is_constant_evaluated

2019-02-13 Thread Martin Sebor
The attached patch adds the __builtin_is_constant_evaluated newly introduced in GCC 9 to the Other Builtins section in the manual. I followed the example of __builtin_setjmp and __builtin_longjmp by encouraging the use of std::is_constant_evaluated over making use of the built-in directly.

Re: PING^1: [PATCH] driver: Also prune joined switches with negation

2019-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2019 at 03:08:01PM -0800, H.J. Lu wrote: > > How does this test verify that both -fno-builtin-* options are in effect? > > That is, how does it fail if you remove either or both of those options? > > > > Without -fno-builtin-free -fno-builtin-malloc As you haven't discovered any

[PATCH] Swap ubsan and early uninit warning passes (PR middle-end/89284)

2019-02-13 Thread Jakub Jelinek
Hi! The ubsan pass makes early uninit warning harder (and often doesn't warn), because e.g. for enum/bool loads we add instrumentation and the reads from the fields isn't easily visible to the uninit pass, we have _7 = _8 = MEM[(_Bool *)_7]; instead etc. As the early uninit warning pass

Re: PING^1: [PATCH] driver: Also prune joined switches with negation

2019-02-13 Thread H.J. Lu
On Wed, Feb 13, 2019 at 2:54 PM Joseph Myers wrote: > > On Wed, 13 Feb 2019, H.J. Lu wrote: > > > Like this? > > This patch is missing any updates to options.texi to discuss the > interation of Negative and RejectNegative with Joined. I will add something. > > diff --git

[PATCH] PR rtl-optimization/88308 Update LABEL_NUSES in move_insn_for_shrink_wrap

2019-02-13 Thread Aaron Sawdey
I've tracked pr/88308 down to move_insn_for_shrink_wrap(). This function moves an insn from one BB to another by copying it and deleting the old one. Unfortunately this does the LABEL_NUSES count on labels referenced because deleting the old instruction decrements the count and nothing in this

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-13 Thread H.J. Lu
On Wed, Feb 13, 2019 at 2:51 PM Uros Bizjak wrote: > > On Wed, Feb 13, 2019 at 9:21 PM H.J. Lu wrote: > > > > On Tue, Feb 12, 2019 at 4:07 AM Uros Bizjak wrote: > > > > > > On Mon, Feb 11, 2019 at 11:55 PM H.J. Lu wrote: > > > > > > > > Allow MMX intrinsic emulation with SSE/SSE2/SSSE3. Don't

[C++ PATCH] Fix cxx_eval_store_expression (PR c++/89336)

2019-02-13 Thread Jakub Jelinek
Hi! As the following testcases shows, cxx_eval_store_expression mishandles the case when constexpr evaluation of the rhs (init) modifies part of the ctor that the store stores into. Except for unions (see below) I believe it is fine the way the outer refs are handled, because we advance into

Re: PING^1: [PATCH] driver: Also prune joined switches with negation

2019-02-13 Thread Joseph Myers
On Wed, 13 Feb 2019, H.J. Lu wrote: > Like this? This patch is missing any updates to options.texi to discuss the interation of Negative and RejectNegative with Joined. > diff --git a/gcc/testsuite/gcc.dg/pr69471-1.c > b/gcc/testsuite/gcc.dg/pr69471-1.c > new file mode 100644 > index

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-13 Thread Uros Bizjak
On Wed, Feb 13, 2019 at 9:21 PM H.J. Lu wrote: > > On Tue, Feb 12, 2019 at 4:07 AM Uros Bizjak wrote: > > > > On Mon, Feb 11, 2019 at 11:55 PM H.J. Lu wrote: > > > > > > Allow MMX intrinsic emulation with SSE/SSE2/SSSE3. Don't enable MMX ISA > > > by default with TARGET_MMX_WITH_SSE. > > > > >

Re: [PR fortran/88248, patch] - [F18] Bogus warning about obsolescent feature: Labeled DO statement

2019-02-13 Thread Harald Anlauf
Sorry, forgot to attach the patch to the revised testcase f2018_obs.f90. Here it is. Regards, Harald Adjusted ChangeLog: 2019-02-13 Harald Anlauf PR fortran/88248 * gfortran.dg/pr88248.f90: New test. * gfortran.dg/f2018_obs.f90: Updated test. On 02/13/19 23:38,

[PR fortran/88248, patch] - [F18] Bogus warning about obsolescent feature: Labeled DO statement

2019-02-13 Thread Harald Anlauf
The attached patch moves the check for labeled DO statements to the place where a label is referenced instead of where a label was defined, which lead to false positives. Regtested on x86_64-pc-linux-gnu. OK for trunk? Thanks, Harald 2019-02-13 Harald Anlauf PR fortran/88248

[PATCH] PR libstdc++/89345 Only define std::destroying_delete for C++2a

2019-02-13 Thread Jonathan Wakely
Clang defines the __cpp_impl_destroying_delete macro unconditionally, so that the feature is supported whenever the library type is defined. This is incompatible with the current definition in libstdc++ because we use constexpr and inline variables, which will give an error for older -std modes.

[PATCH, i386]: Fix vec_set and vec_concat patterns

2019-02-13 Thread Uros Bizjak
Hello! Attached patch fixes operand predicates of several vec_set patterns and uses correct constraints and attributes for various alternatives. 2019-02-13 Uroš Bizjak * config/i386/sse.md (vec_set_0): Use nonimmediate_operand as operand 2 predicate. (vec_set_0): Ditto.

Re: [PATCH,GDC] Add netbsd support to GDC

2019-02-13 Thread Iain Buclaw
On Mon, 11 Feb 2019 at 09:28, wrote: > > On Wed, Jan 23, 2019 at 09:35:03AM +, co...@sdf.org wrote: > > > Is this necessary? I'd prefer to not set this field if it can be > > > avoided. The same goes for the others, I intend to remove them at > > > soonest convenience once the problematic

[PATCH] document __has_attribute and __has_include

2019-02-13 Thread Martin Sebor
The attached patch adds documentation for the __has_attribute (and __has_cpp_attribute) and __has_include operators added in r215752. I was a little unsure where to add this, whether the preprocessor manual or the GCC manual, or both. It seems that it belongs in the preprocessor manual but

Re: PING^1: [PATCH] driver: Also prune joined switches with negation

2019-02-13 Thread H.J. Lu
On Wed, Feb 13, 2019 at 12:02 AM Jakub Jelinek wrote: > > On Wed, Feb 13, 2019 at 08:43:45AM +0100, Jakub Jelinek wrote: > > > It seems right in the march= case to handle that combination as > > > -march=foobar - but it's less clear if that must always be the case for > > > Joined options with

Re: C++ PATCH for c++/89297 - ICE with OVERLOAD in template

2019-02-13 Thread Jason Merrill
On Wed, Feb 13, 2019 at 4:03 PM Marek Polacek wrote: > On Wed, Feb 13, 2019 at 11:59:05AM -0500, Marek Polacek wrote: > > On Wed, Feb 13, 2019 at 11:44:42AM -0500, Jason Merrill wrote: > > > On 2/13/19 12:13 AM, Marek Polacek wrote: > > > > Here we ICE because we're in a template and the

Re: RFA: PATCH to gimple-fold.c for c++/80916, bogus "static but not defined" warning

2019-02-13 Thread Jason Merrill
Ping^2 On Mon, Feb 4, 2019 at 4:09 PM Jason Merrill wrote: > > Ping > > On Fri, Jan 25, 2019 at 10:06 AM Jason Merrill wrote: > > > > Here we warn because i::dispatch has internal linkage (because l > > does) and is never instantiated (because the vtable is never emitted). > > The regression

Re: C++ PATCH for c++/89297 - ICE with OVERLOAD in template

2019-02-13 Thread Marek Polacek
On Wed, Feb 13, 2019 at 11:59:05AM -0500, Marek Polacek wrote: > On Wed, Feb 13, 2019 at 11:44:42AM -0500, Jason Merrill wrote: > > On 2/13/19 12:13 AM, Marek Polacek wrote: > > > Here we ICE because we're in a template and the constructor contains an > > > OVERLOAD, so calling check_narrowing ->

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-13 Thread H.J. Lu
On Tue, Feb 12, 2019 at 4:07 AM Uros Bizjak wrote: > > On Mon, Feb 11, 2019 at 11:55 PM H.J. Lu wrote: > > > > Allow MMX intrinsic emulation with SSE/SSE2/SSSE3. Don't enable MMX ISA > > by default with TARGET_MMX_WITH_SSE. > > > > For pr82483-1.c and pr82483-2.c, "-mssse3 -mno-mmx" compiles in

Re: Provide __start_minfo/__stop_minfo for linkers that don't (PR d/87864)

2019-02-13 Thread Iain Buclaw
On Tue, 29 Jan 2019 at 13:24, Rainer Orth wrote: > > Solaris ld only gained support for section bracketing in Solaris 11.4. > Fortunately, in gdc it is only used for the minfo section, so it's easy > to provide a workaround by adding two additional startup files > drt{begin,end}.o which define

Re: [PATCH] Avoid assuming valid_constant_size_p argument is a constant expression (PR 89294)

2019-02-13 Thread Martin Sebor
On 2/12/19 4:43 PM, Rainer Orth wrote: Hi Martin, The attached patch removes the assumption introduced earlier today in my fix for bug 87996 that the valid_constant_size_p argument is a constant expression. I couldn't come up with a C/C++ test case where this isn't true but apparently it can

Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2)

2019-02-13 Thread David Malcolm
On Wed, 2019-02-13 at 20:08 +0100, Iain Buclaw wrote: > On Wed, 13 Feb 2019 at 14:37, Jakub Jelinek wrote: > > > > On Wed, Feb 13, 2019 at 10:22:14AM +, Andrew Stubbs wrote: > > > On 13/02/2019 09:09, Jakub Jelinek wrote: > > > > To make it work together with doing llvm_binutils only once, >

Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2)

2019-02-13 Thread Iain Buclaw
On Wed, 13 Feb 2019 at 14:37, Jakub Jelinek wrote: > > On Wed, Feb 13, 2019 at 10:22:14AM +, Andrew Stubbs wrote: > > On 13/02/2019 09:09, Jakub Jelinek wrote: > > > To make it work together with doing llvm_binutils only once, the global > > > now > > > has multiple values > > > 0 - disallow

Re: [PATCH 36/40] i386: Allow MMX vector expanders with TARGET_MMX_WITH_SSE

2019-02-13 Thread H.J. Lu
On Tue, Feb 12, 2019 at 12:29 PM Uros Bizjak wrote: > > On 2/12/19, H.J. Lu wrote: > > >> This way, it is clear that we enable alternative 0 only for native > >> mmx. It looks to me that we need to add similar treatment to a couple > >> of other patterns in sse.md, where we allow "y" constraint,

Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074)

2019-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2019 at 10:51:07AM -0800, Steve Kargl wrote: > To get Richard's emin/emax patch into the tree so adequate > testing can be done prior to the 9.1 release, I'll suggest > that we XFAIL norm2_3.f90 while we work out the details for > norm2. > > Yesteraday, I looked at Jakub's patch,

Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074)

2019-02-13 Thread Steve Kargl
On Wed, Feb 13, 2019 at 07:30:53PM +0100, Jakub Jelinek wrote: > On Wed, Feb 13, 2019 at 07:17:53PM +0100, Thomas Koenig wrote: > > > Bootstrapped/regtested on x86_64-linux and i686-linux (together with > > > Richard's patch), ok for trunk? > > > > A couple of points: > > > > with this patch, we

Re: [C++PATCH] [PR86379] do not use TREE_TYPE for USING_DECL_SCOPE

2019-02-13 Thread Jason Merrill
On 2/13/19 12:36 PM, Alexandre Oliva wrote: On Feb 8, 2019, Jason Merrill wrote: On 2/8/19 4:07 AM, Alexandre Oliva wrote: On Feb 7, 2019, Jason Merrill wrote: In protected_accessible_p and shared_member_p, if we're left with a USING_DECL after strip_using_decl, we can't give a

Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074)

2019-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2019 at 07:17:53PM +0100, Thomas Koenig wrote: > > Bootstrapped/regtested on x86_64-linux and i686-linux (together with > > Richard's patch), ok for trunk? > > A couple of points: > > with this patch, we will have an algorithm that will evaluate NORM2 > in a different way than

Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074)

2019-02-13 Thread Thomas Koenig
Hi Jakub, Bootstrapped/regtested on x86_64-linux and i686-linux (together with Richard's patch), ok for trunk? A couple of points: with this patch, we will have an algorithm that will evaluate NORM2 in a different way than before, possibly leading to regressions in some cases where we

Re: [wwwdocs, doc] List -Wabsolute-value in gcc-9/changes.html

2019-02-13 Thread Martin Jambor
Hi Gerald and Martin, On Mon, Jan 28 2019, Gerald Pfeifer wrote: > Hi Martin, > > On Sat, 26 Jan 2019, Martin Jambor wrote: >>> What is a "wrong absolute value function"? That might be good to >>> show by means of an example? (Also in invoke.texi, which I checked >>> before writing this.) >>

Re: [C++PATCH] [PR86379] do not use TREE_TYPE for USING_DECL_SCOPE

2019-02-13 Thread Alexandre Oliva
On Feb 8, 2019, Jason Merrill wrote: > On 2/8/19 4:07 AM, Alexandre Oliva wrote: >> On Feb 7, 2019, Jason Merrill wrote: >> >>> In protected_accessible_p and shared_member_p, if we're left with a >>> USING_DECL after strip_using_decl, we can't give a meaningful answer, >>> and should

Re: [Patch 1/4][Aarch64] v2: Implement Aarch64 SIMD ABI

2019-02-13 Thread Steve Ellcey
On Wed, 2019-02-13 at 16:54 +, Szabolcs Nagy wrote: > > +/* Table of machine attributes. */ > > +static const struct attribute_spec aarch64_attribute_table[] = > > +{ > > + /* { name, min_len, max_len, decl_req, type_req, fn_type_req, > > + affects_type_identity, handler, exclude } */

Re: C++ PATCH for c++/89297 - ICE with OVERLOAD in template

2019-02-13 Thread Marek Polacek
On Wed, Feb 13, 2019 at 11:44:42AM -0500, Jason Merrill wrote: > On 2/13/19 12:13 AM, Marek Polacek wrote: > > Here we ICE because we're in a template and the constructor contains an > > OVERLOAD, so calling check_narrowing -> maybe_constant_value crashes. > > > > check_narrowing deliberately

Re: [Patch 1/4][Aarch64] v2: Implement Aarch64 SIMD ABI

2019-02-13 Thread Szabolcs Nagy
On 08/11/2018 17:52, Steve Ellcey wrote: > This is a resubmission of patch 1 to support the Aarch64 SIMD ABI [1] in > GCC, it does not have any functional changes from the last submit. > > The significant difference between the standard ARM ABI and the SIMD ABI > is that in the normal ABI a

Re: [PATCH, GCC] PR target/86487: fix the way 'uses_hard_regs_p' handles paradoxical subregs

2019-02-13 Thread Vladimir Makarov
On 2019-02-13 5:54 a.m., Andre Vieira (lists) wrote: PING. Since Jeff is away can another maintainer have a look at this please? I see the following patch diff --git a/gcc/lra-constraints.c b/gcc/lra-constraints.c index

Re: C++ PATCH for c++/89297 - ICE with OVERLOAD in template

2019-02-13 Thread Jason Merrill
On 2/13/19 12:13 AM, Marek Polacek wrote: Here we ICE because we're in a template and the constructor contains an OVERLOAD, so calling check_narrowing -> maybe_constant_value crashes. check_narrowing deliberately calls maybe_constant_value and not fold_non_dependent_expr so as to avoid

Re: [PATCH][GCC][Arm] Add HF modes to ANY iterators

2019-02-13 Thread Kyrill Tkachov
Hi Tamar, On 2/13/19 4:31 PM, Tamar Christina wrote: The 02/13/2019 10:57, Kyrill Tkachov wrote: Hi Tamar On 2/13/19 10:33 AM, Tamar Christina wrote: Hi All, The iterators ANY64 and ANY128 are used in various general split patterns and are supposed to contain any 64 bit and 128 bit modes

C++ PATCH to add test for c++/77304

2019-02-13 Thread Marek Polacek
Tested x86_64-linux, checking in as obvious. 2019-02-13 Marek Polacek PR c++/77304 * g++.dg/cpp2a/nontype-class13.C: New test. diff --git gcc/testsuite/g++.dg/cpp2a/nontype-class13.C gcc/testsuite/g++.dg/cpp2a/nontype-class13.C new file mode 100644 index

Re: [PATCH][GCC][Arm] Add HF modes to ANY iterators

2019-02-13 Thread Tamar Christina
The 02/13/2019 10:57, Kyrill Tkachov wrote: > Hi Tamar > > On 2/13/19 10:33 AM, Tamar Christina wrote: > > Hi All, > > > > The iterators ANY64 and ANY128 are used in various general split > > patterns and > > are supposed to contain any 64 bit and 128 bit modes respectively. > > > > For some

PING Re: [PATCH] Fix excess warnings from -Wtype-limits with location wrappers (PR c++/88680)

2019-02-13 Thread David Malcolm
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-02/msg00363.html On Wed, 2019-02-06 at 21:23 -0500, David Malcolm wrote: > PR c++/88680 reports excess warnings from -Wtype-limits after the C++ > FE's use of location wrappers was extended in r267272 for cases such > as: > > const unsigned n =

Re: [-fcompare-debug] var tracking options are not optimization options

2019-02-13 Thread Ian Lance Taylor
On Wed, Jan 4, 2017 at 8:08 PM Alexandre Oliva wrote: > > On Jan 4, 2017, Alexandre Oliva wrote: > > > So I guess we need some alternate PerFunction option flag that makes > > it per-function, but not part of the ICF hash? > > Like this... > > If we include them in the ICF hash, they may cause

Re: [PATCH] Bump LTO_minor_version on GCC-8 branch (PR lto/89260).

2019-02-13 Thread Jan Hubicka
> On February 13, 2019 7:20:37 AM GMT+01:00, "Martin Liška" > wrote: > >As seen in the PR, bump would be needed due to r268698. > > > >Ready for GCC-8 branch? > > OK. It's unfortunate we need to break streaming though. Yep, it was me breaking it for fix of PR88561 which is correctness issue.

Re: PING^2 Re: [PATCH v2] C++ concepts: fix ICE with requires on dtors (PR c++/89036)

2019-02-13 Thread Nathan Sidwell
On 2/13/19 9:36 AM, David Malcolm wrote: Ping yes, sorry didn't realize you were waiting on me. On Fri, 2019-02-08 at 12:03 -0500, David Malcolm wrote: Ping On Fri, 2019-01-25 at 15:02 -0500, David Malcolm wrote: On Fri, 2019-01-25 at 08:59 -0800, Nathan Sidwell wrote: On 1/25/19 8:48

PING^2 Re: [PATCH v2] C++ concepts: fix ICE with requires on dtors (PR c++/89036)

2019-02-13 Thread David Malcolm
Ping On Fri, 2019-02-08 at 12:03 -0500, David Malcolm wrote: > Ping > > On Fri, 2019-01-25 at 15:02 -0500, David Malcolm wrote: > > On Fri, 2019-01-25 at 08:59 -0800, Nathan Sidwell wrote: > > > On 1/25/19 8:48 AM, David Malcolm wrote: > > > > PR c++/89036 reports an ICE due to this assertion

[PATCH] Fix PR86554 on branch

2019-02-13 Thread Richard Biener
This backports the fix to the GCC 8 branch where we have a different way of determining availability. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-02-13 Richard Biener Backport from mainline 2019-01-08 Richard Biener PR

[PATCH][DOC] Document new features for GCC 9.

2019-02-13 Thread Martin Liška
Hi. I'm sending patch where I document changes I made during GCC 9 development. I would appreciate both language and factical comments about the patch. Martin --- htdocs/gcc-9/changes.html | 65 --- 1 file changed, 61 insertions(+), 4 deletions(-) diff

Re: [PATCH] Clean up another MPX-related stuff.

2019-02-13 Thread Richard Biener
On February 13, 2019 6:53:17 AM GMT+01:00, "Martin Liška" wrote: >Hi. > >As Honza noticed, there's still some leftover from MPX removal. >May I remove another bunch of fields now, or should I wait >for next stage1? You can do it now. Richard. >Patch can bootstrap on x86_64-linux-gnu and

Re: [PATCH][ARM] Fix Thumb-1 ldm (PR89190)

2019-02-13 Thread Kyrill Tkachov
Hi Wilco, On 2/13/19 12:42 PM, Wilco Dijkstra wrote: ping From: Wilco Dijkstra Sent: 04 February 2019 14:59 To: GCC Patches Cc: nd; Kyrylo Tkachov Subject: [PATCH][ARM] Fix Thumb-1 ldm (PR89190) This patch fixes an ICE in the Thumb-1 LDM peepholer. Thumb-1 LDMs always update the base

[PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2)

2019-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2019 at 10:22:14AM +, Andrew Stubbs wrote: > On 13/02/2019 09:09, Jakub Jelinek wrote: > > To make it work together with doing llvm_binutils only once, the global now > > has multiple values > > 0 - disallow blank lines > > 1 - allow them for a single test only, reset after

[committed] Fix set_uids_in_ptset (PR middle-end/89303)

2019-02-13 Thread Jakub Jelinek
Hi! The following testcase is miscompiled on x86_64-linux (-m32 and -m64) at -O1, as a pointer has two vars in points-to set, the first one is escaped heap var and the second one is escaped non-heap var, and in the end the last var that sets vars_contains_escaped won and overwrote

Re: [PATCH][ARM] Fix Thumb-1 ldm (PR89190)

2019-02-13 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 04 February 2019 14:59 To: GCC Patches Cc: nd; Kyrylo Tkachov Subject: [PATCH][ARM] Fix Thumb-1 ldm (PR89190)   This patch fixes an ICE in the Thumb-1 LDM peepholer.  Thumb-1 LDMs always update the base register except if the base is loaded. The current

Re: [PATCH] Fix -fdec simplification (PR fortran/88649).

2019-02-13 Thread Jerry DeLisle
On 2/12/19 10:22 PM, Martin Liška wrote: PING^1. On 2/4/19 1:46 PM, Martin Liška wrote: On 2/4/19 10:56 AM, Martin Liška wrote: Hi. Starting from r266926 'switch (e->value.op.op)' is reached when one using -fdec. That's wrong as -fdec causes to create a e->value.function. I hope the proper

Re: [PATCH][ARM] Fix PR89222

2019-02-13 Thread Wilco Dijkstra
Hi Ramana, >> ARMv5te bootstrap OK, regression tests pass. OK for commit? > > Interesting bug. armv5te-linux bootstrap ? Can you share your --target > and --with-arch flags ? --target/host/build=arm-linux-gnueabi --with-arch=armv5te --with-mode=arm >> +  if (GET_CODE (base) == SYMBOL_REF) > >

Re: [PATCH][GCC][AArch64] Allow any offset for SVE addressing modes before reload

2019-02-13 Thread Richard Sandiford
Tamar Christina writes: > Hi Richard, > > The 02/11/2019 18:22, Richard Sandiford wrote: >> pollute the target-independent namespace). Then we can use something like: >> >> expand_operand ops[3]; >> create_output_operand ([0], dest, mode); >> create_input_operand ([1], pred, GET_MODE

Re: Fortran vector math header

2019-02-13 Thread Martin Liška
May I please ping this so that we can reach mainline soon? Thanks, Martin On 2/5/19 1:48 PM, Martin Liška wrote: > On 2/5/19 2:31 AM, Joseph Myers wrote: >> My main comment here is that if you go with the approach of a single >> header shared by multilibs, you should also update the driver code

Re: [PATCH][GCC][Arm] Add HF modes to ANY iterators

2019-02-13 Thread Kyrill Tkachov
Hi Tamar On 2/13/19 10:33 AM, Tamar Christina wrote: Hi All, The iterators ANY64 and ANY128 are used in various general split patterns and are supposed to contain any 64 bit and 128 bit modes respectively. For some reason these patterns had HI but not HF.  This adds HF so that general 64

Re: [PATCH, GCC] PR target/86487: fix the way 'uses_hard_regs_p' handles paradoxical subregs

2019-02-13 Thread Andre Vieira (lists)
PING. Since Jeff is away can another maintainer have a look at this please? Cheers, Andre On 01/02/2019 14:31, Andre Vieira (lists) wrote: On 11/01/2019 22:54, Jeff Law wrote: On 1/8/19 8:21 AM, Andre Vieira (lists) wrote: On 07/01/2019 22:50, Jeff Law wrote: On 1/7/19 7:42 AM, Andre

[PATCH][GCC][Arm] Add HF modes to ANY iterators

2019-02-13 Thread Tamar Christina
Hi All, The iterators ANY64 and ANY128 are used in various general split patterns and are supposed to contain any 64 bit and 128 bit modes respectively. For some reason these patterns had HI but not HF. This adds HF so that general 64 and 128 bit splits are generated for these modes as well.

Re: [PATCH][GCC][AArch64] Allow any offset for SVE addressing modes before reload

2019-02-13 Thread Tamar Christina
Hi Richard, The 02/11/2019 18:22, Richard Sandiford wrote: > pollute the target-independent namespace). Then we can use something like: > > expand_operand ops[3]; > create_output_operand ([0], dest, mode); > create_input_operand ([1], pred, GET_MODE (pred)); > create_input_operand

Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920)

2019-02-13 Thread Andrew Stubbs
On 13/02/2019 09:09, Jakub Jelinek wrote: To make it work together with doing llvm_binutils only once, the global now has multiple values 0 - disallow blank lines 1 - allow them for a single test only, reset after testing it in gcc-dg-prune 2 - allow it for all tests (llvm_binutils) FWIW, this

Re: [PATCH] Bump LTO_minor_version on GCC-8 branch (PR lto/89260).

2019-02-13 Thread Richard Biener
On February 13, 2019 7:20:37 AM GMT+01:00, "Martin Liška" wrote: >As seen in the PR, bump would be needed due to r268698. > >Ready for GCC-8 branch? OK. It's unfortunate we need to break streaming though. Richard. >Thanks, >Martin > >gcc/ChangeLog: > >2019-02-13 Martin Liska > > PR

Re: [PATCH] Fix UB in prepare_cmp_insn (PR middle-end/89281)

2019-02-13 Thread Eric Botcazou
> The code will do: > size = convert_to_mode (cmp_mode, size, 1); > i.e. convert size from whatever mode it had before to cmp_mode and the > test is whether it can do so without changing the behavior. If size is > non-constant, then that can be obviously (without using range info etc.)

Re: [PATCH][ARM] Fix PR89222

2019-02-13 Thread Olivier Hainque
> On 11 Feb 2019, at 22:32, Ramana Radhakrishnan > wrote: > Can Olivier or someone who cares about vxworks also give this a quick > sanity run for the alternate code path once we resolve some of the > review questions here ? Don't we also need to worry about > -mslow-flash-data where we get

[PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920)

2019-02-13 Thread Jakub Jelinek
Hi! The following patch fixes various testsuite issues related to allow_blank_lines. One issue is that even when llvm_binutils effective target is now cached so it is checked just once (per runtest invocation), if the first test invoked emits some diagnostics, that diagnostics in the log file

Re: Define __sparcv8 in 64-bit-default Solaris/SPARC gcc with -m32

2019-02-13 Thread Eric Botcazou
> Eric, could you have another look if I'm missing something? Note that this OPTION_DEFAULT_SPECS code is duplicated in linux64.h. There is this comment: In the SPARC_BI_ARCH compiler we cannot pass %{!mcpu=*:-mcpu=%(VALUE)} here, otherwise say -mcpu=v7 would be passed even when -m64.

Re: [PATCH] Fix TLS ICE with -mcmodel=large (PR target/89290)

2019-02-13 Thread Uros Bizjak
On Wed, Feb 13, 2019 at 12:01 AM Jakub Jelinek wrote: > > Hi! > > The following patch fixes ICE, when we try to split a double-word TLS load > or store. The problem is that x86_64_immediate_operand disallows CONST_INT > offsets with -mcmodel=large. I guess it is intentional for SYMBOL_REFs, >

Re: [PATCH 36/40] i386: Allow MMX vector expanders with TARGET_MMX_WITH_SSE

2019-02-13 Thread Uros Bizjak
On Tue, Feb 12, 2019 at 9:44 PM H.J. Lu wrote: > > On Tue, Feb 12, 2019 at 12:24 PM Uros Bizjak wrote: > > > > On 2/12/19, H.J. Lu wrote: > > > On Tue, Feb 12, 2019 at 11:44 AM Uros Bizjak wrote: > > >> > > >> On Tue, Feb 12, 2019 at 8:35 PM H.J. Lu wrote: > > >> > > > >> > On Tue, Feb 12,

Re: PING^1: [PATCH] driver: Also prune joined switches with negation

2019-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2019 at 08:43:45AM +0100, Jakub Jelinek wrote: > > It seems right in the march= case to handle that combination as > > -march=foobar - but it's less clear if that must always be the case for > > Joined options with negative versions (at least, the semantics would need > >