Re: [patch, fortran] Fix PR 89496, error with alternate return

2019-02-25 Thread Thomas Koenig
Hi Dominique, AFAICT there is no patch attached. I guess that would have helped :-) Here it is. 2019-02-25 Thomas Koenig PR fortran/89496 * trans-types.c (get_formal_from_actual_arglist): If the actual arglist has no expression, the corresponding formal

[doc, committed] fix PR c/80409

2019-02-25 Thread Sandra Loosemore
I've checked in this patch to document the GNU extension to va_arg for pointer types, which is really a POSIX extension per discussion in the issue. -Sandra 2019-02-25 Sandra Loosemore PR c/80409 gcc/ * doc/extend.texi (Variadic Pointer Args): New section. Index: gcc/doc/extend.texi

Re: [patch, fortran] Fix PR 87689, wrong decls / ABI violation on POWER

2019-02-25 Thread Steve Kargl
On Mon, Feb 25, 2019 at 05:54:44PM -0800, Bob Deen via fortran wrote: > On 2/19/19 2:44 PM, Thomas Koenig wrote: > > Bob, > > > >> Some of us still use varargs interfaces (in my case, Fortran calling C > >> stdarg subroutines). > > > > The problem for us is that that sometimes using varargs made

Re: [patch, fortran] Fix PR 87689, wrong decls / ABI violation on POWER

2019-02-25 Thread Bob Deen via gcc-patches
On 2/19/19 2:44 PM, Thomas Koenig wrote: Bob, Some of us still use varargs interfaces (in my case, Fortran calling C stdarg subroutines). The problem for us is that that sometimes using varargs made standard- conforming Fortran code like, in file a.f subroutine foo(a) print

[PATCH] PR c/43673 - Incorrect warning in dfp printf.

2019-02-25 Thread luoxhu
From: Xiong Hu Luo dfp printf/scanf of Ha/HA, Da/DA and DDa/DDA is not set properly, cause incorrect warning happens: "use of 'D' length modifier with 'a' type character". Regression-tested on powerpc64le-linux, OK for trunk and gcc-8? gcc/c-family/ChangeLog: 2019-02-25 Xiong Hu Luo

libgo patch committed: Update to 1.12rc1

2019-02-25 Thread Ian Lance Taylor
I've committed this patch to update libgo to the 1.12rc1 release of the master library. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian patch.txt.bz2 Description: application/bzip

Re: [PATCH] Fix up strnlen handling in tree-ssa-strlen.c (PR tree-optimization/89500)

2019-02-25 Thread Martin Sebor
On 2/25/19 4:12 PM, Jakub Jelinek wrote: Hi! The following testcase ICEs, because rhs (previously known string length) is SSA_NAME (return value from the earlier strlen), but bound is 0 and so MIN_EXPR yields also size_zero_node. The noncst_bound initialization checks if new_rhs is INTEGER_CST

Re: [PATCH] Fix UB in c-format.c (maybe_read_dollar_number) (PR c/89495)

2019-02-25 Thread Joseph Myers
On Mon, 25 Feb 2019, Jakub Jelinek wrote: > Hi! > > The testcases Martin has added recently that contain precision or width > that doesn't fit into int cause UB in the following routine, as 10 * argnum > or that + (*fcp - '0') can result in signed integer overflow. > > The following patch just

[PATCH] Fix up strnlen handling in tree-ssa-strlen.c (PR tree-optimization/89500)

2019-02-25 Thread Jakub Jelinek
Hi! The following testcase ICEs, because rhs (previously known string length) is SSA_NAME (return value from the earlier strlen), but bound is 0 and so MIN_EXPR yields also size_zero_node. The noncst_bound initialization checks if new_rhs is INTEGER_CST and if it is, assumes rhs must be too and

[PATCH] Use RANGE_EXPR in Fortran array initializers some more (PR fortran/43210)

2019-02-25 Thread Jakub Jelinek
Hi! When initializing whole array with a const, we can save quite some compile time memory (and time in some cases) by using RANGE_EXPRs, instead of duplicating the same initializer thousands of times in the CONSTRUCTOR. In some cases the gimplifier even can optimize those better.

[committed] Add testcases for PR c/77754

2019-02-25 Thread Jakub Jelinek
Hi! All the following testcases were fixed by r266271 aka PR87229 fix already. I've regtested them on x86_64-linux and i686-linux and committed to trunk as obvious. 2019-02-25 Jakub Jelinek PR c/77754 * gcc.c-torture/compile/pr77754-1.c: New test. *

Re: [PATCH] Fix up remove_partial_avx_dependency (PR target/89474)

2019-02-25 Thread H.J. Lu
On Mon, Feb 25, 2019 at 2:53 PM Jakub Jelinek wrote: > > Hi! > > The following patch fixes two issues in the new rpad pass. > One is that the insertion at the start of a basic block didn't work properly > if the basic block didn't contain any non-NOTE/non-DEBUG_INSN instructions. >

[PATCH] Fix UB in c-format.c (maybe_read_dollar_number) (PR c/89495)

2019-02-25 Thread Jakub Jelinek
Hi! The testcases Martin has added recently that contain precision or width that doesn't fit into int cause UB in the following routine, as 10 * argnum or that + (*fcp - '0') can result in signed integer overflow. The following patch just does the computation in UHWI, which we know is wider than

[PATCH] Fix up remove_partial_avx_dependency (PR target/89474)

2019-02-25 Thread Jakub Jelinek
Hi! The following patch fixes two issues in the new rpad pass. One is that the insertion at the start of a basic block didn't work properly if the basic block didn't contain any non-NOTE/non-DEBUG_INSN instructions. next_nonnote_nondebug_insn hapilly turns through into another basic block and the

[C++ PATCH] Fix up constexpr changing of active union member (PR c++/89481)

2019-02-25 Thread Jakub Jelinek
Hi! cxx_eval_store_expression has code to propagate no_zero_init from outer ctors to inner ctors, if the outer ctor is known to be zero initialized, the inner one should be as well. As the following patch shows, when changing active union member there needs to be an exception, even if the whole

[patch, fortran] Fix PR 89496, error with alternate return

2019-02-25 Thread Thomas König
Hello world, the attached patch fixes a regression introduced by my recent patch for PR 87689, where the alternate return arguments were not handled correctly. Some experimentation resulted in a test case which actually segfaulted on a normal compiler, instead of just being visible on an

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Steve Kargl
On Mon, Feb 25, 2019 at 01:58:27PM -0800, Steve Kargl wrote: > On Mon, Feb 25, 2019 at 10:03:29PM +0100, Thomas König wrote: > > Hi Steve, > > > > >> I think this was introduced quite some time ago, not sure if it > > >> was ever documented anywhere. I guess we should do so. > > >> > > >

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Steve Kargl
On Mon, Feb 25, 2019 at 10:03:29PM +0100, Thomas König wrote: > Hi Steve, > > >> I think this was introduced quite some time ago, not sure if it > >> was ever documented anywhere. I guess we should do so. > >> > > Probably want to document this in the testcase. > > I just checked and found 77

[PR fortran/89492, patch] - [9 Regression] Endless compilation of an invalid TRANSFER after r269177

2019-02-25 Thread Harald Anlauf
Rev. 269177 uncovered a latent issue in TRANSFER when the MOLD argument had storage size 0, resulting in an infinite loop. The attached patch rejects illegal cases and handles the case where storage size of both SOURCE and MOLD are 0. It also verifies proper simplification for some cases, some

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Thomas König
Hi Steve, I think this was introduced quite some time ago, not sure if it was ever documented anywhere. I guess we should do so. Probably want to document this in the testcase. I just checked and found 77 occurences in the test suite (most of them mine, to be sure). So, maybe an entry in

Re: [backtrace] Avoid segfault

2019-02-25 Thread Tom de Vries
On 25-02-19 15:12, Gerald Pfeifer wrote: > Specifically I am now seeing > > gmake[4]: *** No rule to make target 'b3test_dwz_buildid', > needed by 'b3test_dwz_buildid.log'. > > in my build/test logs. (Note, this is GNU make 4.2.1, so might reproduce > on your SUSE systems as well?) Hi

Re: [PATCH v2][rs6000] PR89338, PR89339: Fix compat vector intrinsics for BE and 32-bit

2019-02-25 Thread Segher Boessenkool
Hi Paul, On Tue, Feb 19, 2019 at 03:03:58PM -0600, Paul Clarke wrote: > Test FAILS: sse2-cvtpd2dq-1, sse2-cvtpd2ps, sse2-cvttpd2dq on powerpc64 > (big-endian). > > _mm_cvtpd_epi32, _mm_cvtpd_ps, _mm_cvttpd_epi32: Type conversion from > vector doubleword type to vector word type leaves the

Re: [EXT] Re: [Patch, Aarch64] Implement TARGET_GET_MULTILIB_ABI_NAME for aarch64 (for use in Fortran vector header file)

2019-02-25 Thread Steve Ellcey
On Wed, 2019-02-20 at 10:04 +, Richard Sandiford wrote: > > (E.g. __attribute__((vector_size)) never creates an ABI-level SVE vector, > even with -msve-vector-bits=N, but it can create an ABI-level Advanced > SIMD vector.) > > I think we should leave the SVE stuff out for now though. ISTM

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Steve Kargl
On Mon, Feb 25, 2019 at 07:15:32PM +0100, Thomas Koenig wrote: > Hi Dominique, > > > I see a double space in > > > > ! { dg-do run } > > > > Is this intended? > > Yes, it is. This is for tests which should not be run with all > the options cycling, but only once. > > I think this was

Re: [PATCH v2][rs6000] PR89338, PR89339: Fix compat vector intrinsics for BE and 32-bit

2019-02-25 Thread Paul Clarke
ping. On 02/19/2019 03:03 PM, Paul Clarke wrote: > Test FAILS: sse2-cvtpd2dq-1, sse2-cvtpd2ps, sse2-cvttpd2dq on powerpc64 > (big-endian). > > _mm_cvtpd_epi32, _mm_cvtpd_ps, _mm_cvttpd_epi32: Type conversion from > vector doubleword type to vector word type leaves the results in even > lanes in

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Thomas Koenig
Hi Dominique, I see a double space in ! { dg-do run } Is this intended? Yes, it is. This is for tests which should not be run with all the options cycling, but only once. I think this was introduced quite some time ago, not sure if it was ever documented anywhere. I guess we should do

Re: [PATCH][GCC][AArch64] Fix command line options canonicalization version #2. (PR target/88530)

2019-02-25 Thread Tamar Christina
The 02/21/2019 22:34, James Greenhalgh wrote: > On Wed, Feb 20, 2019 at 08:00:38AM -0600, Tamar Christina wrote: > > Hi All, > > > > Commandline options on AArch64 don't get canonicalized into the smallest > > possible set before output to the assembler. This means that overlapping > > feature >

[PATCH, OpenACC, libgomp, v6, stage1] Async-rework update

2019-02-25 Thread Chung-Lin Tang
Hi Thomas, I have incorporated all your patches you've included in the last mail (with some modifications, though pretty minor I think). The default_async, GOMP_PLUGIN_IF_VERSION, and testsuite changes have all been removed. We can work on them later as we clarify more things. Thanks,

Re: Move -Wmaybe-uninitialized to -Wextra

2019-02-25 Thread Michael Matz
Hi, On Wed, 20 Feb 2019, Jeff Law wrote: > No, I'm saying the distinction between maybe and always uninitialized is > a false distinction. Code duplication can easily take something that > triggers a "maybe" warning and turn it into a "always" warning. The > distinction between them is just

Re: [PATCH doc] correct/improve -Wmissing-attributes and -Wattribute-alias

2019-02-25 Thread Martin Sebor
On 2/15/19 6:57 PM, Sandra Loosemore wrote: On 2/6/19 9:16 AM, Martin Sebor wrote: The manual documents the -Wno-missing-attributes form of the option as if it was enabled by default, even though it's enabled by -Wall (I can't get this -Wno- convention straight in my head).  I also got private

Re: [PATCH][libbacktrace] Add btest_lto

2019-02-25 Thread Tom de Vries
On 25-02-19 11:48, Thomas Schwinge wrote: > Hi Tom! > > On Fri, 8 Feb 2019 10:42:24 +0100, Tom de Vries wrote: >> Add libbacktrace test-case using -flto. > > I'm seeing this one fail is some configurations, but only in the > 'build-gcc/libbacktrace/btest_lto.log' variant: > Hi Thomas,

[committed fortran] New test for PR89282 - Garbage arithmetics results in fortran with -O3 and overloaded operators

2019-02-25 Thread Dominique d'Humières
New test committed as r269190. Dominique

[C++ Patch] PR 89488 ("[9 Regression] ICE in merge_exception_specifiers, at cp/typeck2.c:2395")

2019-02-25 Thread Paolo Carlini
Hi, this error recovery regression has to do with the recent changes committed by Jason for c++/88368. What happens is that maybe_instantiate_noexcept fails the hard way, thus, toward the end of the function, doesn't update TREE_TYPE (fn) and just returns false. process_subob_fn doesn't

[committed] df-scan: fix use of mw_order in df_mw_compare (PR 86096)

2019-02-25 Thread Alexander Monakov
Hi, df_mw_compare tries to order df_mw_hardreg structures lexicographically, but the last comparison step wrongly tests one field (mw_reg) while subtracting another (mw_order). This makes the comparison non-transitive. Fix this by simply returning difference of mw_order. Patch pre-approved by

[committed] Add the primary testcase from PR c++/89285

2019-02-25 Thread Jakub Jelinek
Hi! This testcase ICEs on the 8.x branch and ICEd as well with my earlier approach to get the testcase rejected on the trunk again when foo is constexpr, but actually with the latest approach that was committed (where constexpr evaluation is done on pre-cp_fold_function trees and cp_fold can

Re: [backtrace] Avoid segfault

2019-02-25 Thread Gerald Pfeifer
Hi Tom, I'm afraid this triggers on my (FreeBSD-based) testers: 2019-01-29 Tom de Vries * install-debuginfo-for-buildid.sh.in: New script. * Makefile.am (check_PROGRAMS): Add b2test and b3test. (TESTS): Add b2test_buildid and b3test_dwz_buildid. *

Re: [patch, fortran] Fix PR 89174, segfault on allocate with MOLD

2019-02-25 Thread Dominique d'Humières
Hi Thomas, I see a double space in ! { dg-do run } Is this intended? If yes, it should probably be documented, otherwise it should be fixed. TIA Dominique

[PATCH committed Fortran] PR89274 - Inconsistent list directed output of INTEGER(16)

2019-02-25 Thread Dominique d'Humières
Committed as revision r269187. Dominique

Re: [PATCH][libbacktrace] Add btest_lto

2019-02-25 Thread Thomas Schwinge
Hi Tom! On Fri, 8 Feb 2019 10:42:24 +0100, Tom de Vries wrote: > Add libbacktrace test-case using -flto. I'm seeing this one fail is some configurations, but only in the 'build-gcc/libbacktrace/btest_lto.log' variant: test5: unexpected syminfo name got global.2537 expected global PASS:

Re: [PATCH] Fix arm *subsi3_carryin_{compare_,}const patterns (PR target/89434)

2019-02-25 Thread Kyrill Tkachov
On 2/24/19 2:26 PM, Jakub Jelinek wrote: Hi! As the testcase shows, *subsi3_carryin_{const,compare_const} patterns don't express in RTL what they are actually doing, which may (on the testcase) does cause miscompilation if we manage to propagate constants into it or for other reason

[PATCH][wwwdocs][AArch64/arm] Mention Neoverse N1 and Neoverse E1 support for GCC 9

2019-02-25 Thread Kyrill Tkachov
Hi all, Here's a wwwdocs patch mentioning the recently-added support for the Arm Neoverse N1 and Neoverse E1 processors. Checked the output on Firefox. Ok to commit (from an aarch64 perspective)? Thanks, Kyrill Index: htdocs/gcc-9/changes.html

Re: [PATCH] Improve arm and aarch64 casesi (PR target/70341)

2019-02-25 Thread Kyrill Tkachov
Hi Jakub, On 2/25/19 10:19 AM, Jakub Jelinek wrote: On Mon, Feb 25, 2019 at 10:05:46AM +, Kyrill Tkachov wrote: Hi Jakub, On 2/23/19 12:20 AM, Jakub Jelinek wrote: Hi! The testcase in the PR doesn't hoist any memory loads from the large switch before the switch on aarch64 and arm

Re: [PATCH] Improve arm and aarch64 casesi (PR target/70341)

2019-02-25 Thread Jakub Jelinek
On Mon, Feb 25, 2019 at 10:05:46AM +, Kyrill Tkachov wrote: > Hi Jakub, > > On 2/23/19 12:20 AM, Jakub Jelinek wrote: > > Hi! > > > > The testcase in the PR doesn't hoist any memory loads from the large > > switch > > before the switch on aarch64 and arm (unlike e.g. x86), because the > >

Re: [PATCH] Improve arm and aarch64 casesi (PR target/70341)

2019-02-25 Thread Kyrill Tkachov
Hi Jakub, On 2/23/19 12:20 AM, Jakub Jelinek wrote: Hi! The testcase in the PR doesn't hoist any memory loads from the large switch before the switch on aarch64 and arm (unlike e.g. x86), because the arm/aarch64 casesi patterns don't properly annotate the memory load from the jump table. 

Re: [PATCH] Fix var-tracking ICE on ARM due to backend bug (PR target/89438)

2019-02-25 Thread Kyrill Tkachov
On 2/25/19 9:35 AM, Jakub Jelinek wrote: On Mon, Feb 25, 2019 at 09:25:19AM +, Kyrill Tkachov wrote: --- gcc/config/arm/vfp.md.jj    2019-02-18 20:48:32.642732323 +0100 +++ gcc/config/arm/vfp.md   2019-02-22 00:37:36.730795663 +0100 @@ -871,14 +871,15 @@ (define_insn_and_split

Re: [PATCH] Fix var-tracking ICE on ARM due to backend bug (PR target/89438)

2019-02-25 Thread Jakub Jelinek
On Mon, Feb 25, 2019 at 09:25:19AM +, Kyrill Tkachov wrote: > > --- gcc/config/arm/vfp.md.jj    2019-02-18 20:48:32.642732323 +0100 > > +++ gcc/config/arm/vfp.md   2019-02-22 00:37:36.730795663 +0100 > > @@ -871,14 +871,15 @@ (define_insn_and_split "*negdf2_vfp" > >    if (REGNO

Re: [PATCH] Fix var-tracking ICE on ARM due to backend bug (PR target/89438)

2019-02-25 Thread Kyrill Tkachov
Hi Jakub, On 2/22/19 10:19 PM, Jakub Jelinek wrote: Hi! The following testcase ICEs on arm, because the backend creates non-canonical SImode constants (0x8000).  CONST_INTs always need to be sign-extended from their corresponding mode to HOST_WIDE_INT. Fixed thusly, bootstrapped/regtested

[patch] Fix wrong code for boolean negation in condition at -O

2019-02-25 Thread Eric Botcazou
Hi, this is a regression present on the mainline and 8 branch, introduced by the new code in edge_info::derive_equivalences dealing with BIT_AND_EXPR for SSA names with boolean range: /* If either operand has a boolean range, then we know its value must be one,