[PATCH GCC] PR90021 ICE fix

2019-04-09 Thread bin.cheng
Hi, This patch fixes ICE reported by PR90021. The issue has been there since loop interchange and recently exposed by patch for PR89725. As PR comment suggests, we have equal access function {{1, +, 1}_6, +, 1}_4 and _6 is of loop_nest's outer loop. This patch introduces new parameter

Re: [PATCH] Fix up target_to_host fn in gimple-ssa-sprintf.c (PR c++/90010)

2019-04-09 Thread Richard Biener
On April 9, 2019 11:47:28 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >As the following testcase shows, target_to_host handled >targstr with strlen shorter than hostsz - 4 right (though with wasteful >clearing of the rest of the buffer when only one '\0' termination is >enough) >and similarly also

Re: [Patch, fortran] PRs 89843 and 90022 - C Fortran Interop fixes.

2019-04-09 Thread Steve Kargl
On Tue, Apr 09, 2019 at 11:18:11AM +0100, Paul Richard Thomas wrote: > > This patch is safe for trunk, even at this late stage, because its > effects are barricaded behind the tests for CFI descriptors. I believe > that it appropriately rewards the bug reporters to have this feature > work as

Re: [PATCH] D support for RISC-V

2019-04-09 Thread Jim Wilson
On Tue, Apr 9, 2019 at 10:36 AM Iain Buclaw wrote: > Any objection if I upstream the non-asm bits? Doesn't all of it, except maybe the configure.tgt patch need to go upstream first? And do you need some paperwork or button click from David for D language patches for the copyright assignment?

Re: [PATCH, rs6000] PR87532: Bad results from vec_extract (unsigned char, foo) dependent upon function inline

2019-04-09 Thread Segher Boessenkool
Hi Kelvin, On Tue, Apr 09, 2019 at 08:15:31AM -0500, Kelvin Nilsen wrote: > This new patch addresses the code generation problems that were uncovered by > these failing tests. Additionally, this new patch corrects some of the > expected instruction counts for certain previously existing

Re: [Patch, fortran] PRs 89843 and 90022 - C Fortran Interop fixes.

2019-04-09 Thread Paul Richard Thomas
Many thanks, sir! I will look into it. Paul On Tue, 9 Apr 2019 at 17:43, Dominique d'Humières wrote: > > Hi Paul, > > With your patch the test gfortran.dg/ISO_Fortran_binding_9.f90 fails in the > 32 bit mode, due to the errors > >

[PATCH] Replace direct PSTL uses of assert() with a macro

2019-04-09 Thread Thomas Rodgers
This also replaces calls to __TBB_ASSERT so that there are two macro definitions provided by c++config - __PSTL_ASSERT(_Condition) __PSTL_ASSERT_MSG(_Condition, _Message) * include/bits/c++config: Add definition for __PSTL_ASSERT. Add

Re: [PATCH] Add PSTL internal namespace qualifications

2019-04-09 Thread Thomas Rodgers
Committed to trunk. Thomas Rodgers writes: > This patch adds additional internal namespace qualifications to the pstl > implementation. > > From 35dba02035ebb5fd44ac0f06e25a81dfef05898f Mon Sep 17 00:00:00 2001 > From: Thomas Rodgers > Date: Thu, 28 Mar 2019 17:23:49 -0700 > Subject: [PATCH]

[PATCH] Fix up target_to_host fn in gimple-ssa-sprintf.c (PR c++/90010)

2019-04-09 Thread Jakub Jelinek
Hi! As the following testcase shows, target_to_host handled targstr with strlen shorter than hostsz - 4 right (though with wasteful clearing of the rest of the buffer when only one '\0' termination is enough) and similarly also strlen hostsz and more right (making last 4 characters in the buffer

[C/C++ PATCH] Fix promoted switch condition out of range diagnostics (PR c/89888, take 2)

2019-04-09 Thread Jakub Jelinek
On Tue, Apr 09, 2019 at 09:06:33AM +0200, Jakub Jelinek wrote: > Alternatively, I believe we could remove from the patch the in-place > replacement of CASE_LABEL_EXPRs with LABEL_EXPRs if we want to remove, > just splay_tree_remove those, because by my reading of >

Re: [wwwdocs] gcc-9/changes.html - Mention new OpenRISC backend

2019-04-09 Thread Stafford Horne
Committed. On Tue, Apr 02, 2019 at 01:03:35PM +0900, Stafford Horne wrote: > Hello, > > I was reading through some things and found this was missing. > > As before, I don't seem to have CVS access, if its OK and someone can commit > it > would be helpful. It turns out I do have CVS access,

Re: [RFC, doc] Note variable shadowing at max macro using statement expression

2019-04-09 Thread Sandra Loosemore
On 4/8/19 5:38 AM, Tom de Vries wrote: Hi, When suggesting to rewrite the unsafe (with respect to multiple evaluation of arguments) macro definition: ... #define max(a,b) ((a) > (b) ? (a) : (b)) ... into the safe macro definition: ... #define maxint(a,b) \ ({int _a = (a), _b = (b);

[PATCH] PR libstdc++/89851 Add testcase for std::variant equality

2019-04-09 Thread Jonathan Wakely
Add a test for the regression introduced with r269422 and fixed with r270056. PR libstdc++/89851 * testsuite/20_util/variant/89851.cc: New test. Tested x86_64-linux, committed to trunk. commit 429d850417840c18a5a1e90ee085f474395a7117 Author: Jonathan Wakely Date: Tue Apr 9

Re: [libphobos] Work around Solaris ld bug linking __tls_get_addr on 64-bit x86

2019-04-09 Thread Rainer Orth
Rainer Orth writes: > Here's the patch I mentioned in > > https://gcc.gnu.org/ml/gcc-patches/2019-01/msg01661.html > > to work around an amd64 Solaris ld bug. I'm just posting it for > reference now: until it's clear if a fix will make it into Solaris 11.5 > or not, there's no point in

[Ada] Fix wrong translation of C++ virtual destructor

2019-04-09 Thread Eric Botcazou
This is a regression present on all active branches: -fdump-ada-spec no longer generates a declaration for the (implicit) deleting destructor in a class, which is problematic if it's virtual because it has a slot in the vtable. Tested on x86_64-suse-linux, applied on all active branches.

Re: [libphobos] Work around lack of dlpi_tls_modid before Solaris 11.5

2019-04-09 Thread Rainer Orth
Rainer Orth writes: > Before Solaris 11.5, struct dl_phdr_info lacked the dlpi_tls_modid > member. While the support might be backported to Solaris 11.4, it > certainly won't to previous Solaris releases. To work around this, I've > used the following patch. Again, it's pretty

[PATCH 3/3] Add comments and style fixes to

2019-04-09 Thread Jonathan Wakely
* include/std/variant: Adjust whitespace. Add comments. (_Multi_array): Leave primary template undefined. (_Multi_array<_Tp>): Define partial specialization for base case of recursion. (__gen_vtable_impl, __gen_vtable): Remove redundant && from type

Re: [PATCH 2/3] Fix std::visit to support arbitrary callables

2019-04-09 Thread Jonathan Wakely
The __visitor_result_type helper didn't use std::invoke and so didn't compile when the visitor was a pointer-to-member rather than a function object. Use std::invoke_result instead. * include/std/variant (__variant_idx_cookie): Add member type. (__visitor_result_type): Remove.

[PATCH 1/3] PR libstdc++/90008 remove unused capture from variant rel ops

2019-04-09 Thread Jonathan Wakely
PR libstdc++/90008 * include/std/variant (_VARIANT_RELATION_FUNCTION_TEMPLATE): Remove unused capture. * testsuite/20_util/variant/90008.cc: New test. Teted powerpc64le-linux, committed to trunk. commit 89a4191807ed2409f0e6f510ea8349392c43d9da Author: Jonathan

[PATCH, testsuite]: Fix FAIL: gcc.target/i386/ifcvt-onecmpl-abs-1.c scan-assembler cltd

2019-04-09 Thread Uros Bizjak
Look for a message of a successful ifcvt in the relevant RTL dump instead of scanning asm dump. 2019-04-09 Uroš Bizjak * gcc.target/i386/ifcvt-onecmpl-abs-1.c (dg-options): Use -O2 -fdump-rtl-ce1. (dg-final): Scan ce1 RTL dump instead of asm dump. Tested on x86_64-linux-gnu

Re: [PATCH] [ARC] PR 88409: miscompilation due to missing cc clobber in longlong.h macros

2019-04-09 Thread Claudiu Zissulescu
Done. On Wed, Apr 3, 2019 at 8:28 PM Vineet Gupta wrote: > > On 4/3/19 2:53 AM, Claudiu Zissulescu wrote: > > Pushed, thank you for your contribution, > > Claudiu > > Thx, can this be backported to gcc-8-stable please which is what glibc folks > use > for testing ! > > -Vineet > > > > > On Tue,

Re: [PATCH] D support for RISC-V

2019-04-09 Thread Iain Buclaw
On Tue, 9 Apr 2019 at 11:53, David Abdurachmanov wrote: > > This patch has been in Fedora/RISCV for the last couple of months. > I have tested simple applications (e.g. word count example), which > worked without a problem. > > I believe Iain Buclaw did run GCC testsuite using Fedora/RISCV >

Merge from trunk to gccgo branch

2019-04-09 Thread Ian Lance Taylor
I merged trunk revision 270220 to the gccgo branch. Ian

Re: [Patch, fortran] PRs 89843 and 90022 - C Fortran Interop fixes.

2019-04-09 Thread Dominique d'Humières
Hi Paul, With your patch the test gfortran.dg/ISO_Fortran_binding_9.f90 fails in the 32 bit mode, due to the errors /opt/gcc/work/gcc/testsuite/gfortran.dg/ISO_Fortran_binding_9.f90:24:6: Error: Type mismatch in argument 'expected' at (1); passed INTEGER(4) to INTEGER(8)

Re: [PATCH] netbsd EABI support

2019-04-09 Thread Richard Earnshaw (lists)
On 09/04/2019 16:04, Jeff Law wrote: > On 4/8/19 9:17 AM, co...@sdf.org wrote: >> Pinging again in the hope of getting the patch in, I'd like to have >> less outstanding patches :) (I have quite a few and new releases >> can become painful!) >> >> gcc/ChangeLog >> >> config.gcc (arm*-*-netbsdelf*)

Negative arguments in OpenMP 'num_threads' clause etc. (was: [Patch 4/5] OpenACC tile clause support, Fortran front-end parts)

2019-04-09 Thread Thomas Schwinge
Hi Jakub! On Tue, 29 Nov 2016 17:47:08 -0800, Cesar Philippidis wrote: > One notable difference between the trunk and gomp4 implementation of the > tile clause is that gomp4 errors on negative value tile arguments, > whereas trunk issues warnings. I'm picking up these changes, which have been

[PATCH] S/390: Fix PR89952 incorrect CFI

2019-04-09 Thread Andreas Krebbel
This patch fixes a cases where inconsistent CFI is generated. After restoring the hard frame pointer (r11) from an FPR we have to set the CFA register. In order to be able to set it back to the stack pointer (r15) we have to make sure that r15 has been restored already. gcc/ChangeLog:

Re: RFA: Fix uninitialized memory use in sched_macro_fuse_insns

2019-04-09 Thread Jeff Law
On 4/5/19 8:47 AM, Richard Sandiford wrote: > Joern Rennecke writes: >> On Fri, 5 Apr 2019 at 11:07, Richard Sandiford >> wrote: >> >> 2019-04-04 Joern Rennecke * sched-deps.c (sched_macro_fuse_insns): Check return value of targetm.fixed_condition_code_regs.

Re: [PATCH] claim ifunc support on several NetBSD architectures

2019-04-09 Thread Jeff Law
On 4/7/19 7:31 AM, co...@sdf.org wrote: > architecture list from netbsd src/tests/libexec/ld.elf_so/t_ifunc.c > (quick reference: > https://github.com/NetBSD/src/blob/trunk/tests/libexec/ld.elf_so/t_ifunc.c#L38 > ) > tested on netbsd/amd64. > > ifuncs worked anyway, but I can't use

Re: [PATCH] netbsd EABI support

2019-04-09 Thread Jeff Law
On 4/8/19 9:17 AM, co...@sdf.org wrote: > Pinging again in the hope of getting the patch in, I'd like to have > less outstanding patches :) (I have quite a few and new releases > can become painful!) > > gcc/ChangeLog > > config.gcc (arm*-*-netbsdelf*) Add support for EABI configuration >

[PATCH] Fix PR90020

2019-04-09 Thread Richard Biener
This fixes issues in GIMPLE and RTL code-hoisting which ignore const/pure calls when determining whether it is safe to hoist a possibly trapping memory reference across it. The GIMPLE side of the fix handles this similar to regular operations where we avoid hoisting possibly trapping ones over

[PATCH] Remove unused DR_GROUP_SAME_DR_STMT

2019-04-09 Thread Richard Biener
While looking at PR90018 I figured DR_GROUP_SAME_DR_STMT is never set since GCC 4.9. The following removes it to confuse the occasional reader of the vectorizer code less. Bootstrap / regtest in progress on x86_64-unknown-linux-gnu. Richard. 2019-04-09 Richard Biener *

Re: [PATCH] Remove some further trailing whitespaces from diagnostic messages (PR translation/90011)

2019-04-09 Thread Jakub Jelinek
On Tue, Apr 09, 2019 at 10:05:00AM -0400, David Malcolm wrote: > > Thinking aloud, maybe c-format.c could check for some of > > these? (provided they're at a suitable callsite). > > > > We're already statically checking for valid format codes/types for > > strings at callsites of decls with

Re: [PATCH] Remove some further trailing whitespaces from diagnostic messages (PR translation/90011)

2019-04-09 Thread David Malcolm
On Tue, 2019-04-09 at 10:01 -0400, David Malcolm wrote: > On Tue, 2019-04-09 at 09:21 +0200, Jakub Jelinek wrote: > > Hi! > > > > Several further spots with trailing whitespace, only > > bootstrapped/regtested > > on x86_64-linux and i686-linux (so the ipa-devirt.c change is > > covered), > > the

Re: [PATCH] Remove some further trailing whitespaces from diagnostic messages (PR translation/90011)

2019-04-09 Thread David Malcolm
On Tue, 2019-04-09 at 09:21 +0200, Jakub Jelinek wrote: > Hi! > > Several further spots with trailing whitespace, only > bootstrapped/regtested > on x86_64-linux and i686-linux (so the ipa-devirt.c change is > covered), > the rest is just by eyeballing gcc.pot. > > Ok for trunk? > > I wonder

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-09 Thread Jan Hubicka
> Hi. > > There's updated version that supports profile quality for both counts > and probabilities. I'm wondering whether ENTRY and EXIT BBs needs to > have set probability. Apparently, I haven't seen any verifier that > would complain. Well, you do not need to define it but then several cases

Re: [C++ PATCH] Remove trailing space from diagnostics for narrowing conv (PR translation/90011)

2019-04-09 Thread Marek Polacek
On Tue, Apr 09, 2019 at 09:09:55AM +0200, Jakub Jelinek wrote: > Hi! > > In r263523 check_narrowing changed in this spot: > pedwarn (loc, OPT_Wnarrowing, > -"narrowing conversion of %qE from %qH to %qI " > -"inside { }", init, ftype, type); > +

[PATCH, rs6000] PR87532: Bad results from vec_extract (unsigned char, foo) dependent upon function inline

2019-04-09 Thread Kelvin Nilsen
A patch to address this problem report was committed on 3/15/2019. Some of the new regressions tests submitted with that initial patch failed on P8 big-endian and on P9 little-endian. This new patch addresses the code generation problems that were uncovered by these failing tests.

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-09 Thread Martin Liška
On 4/8/19 3:35 PM, Martin Liška wrote: > On 4/8/19 11:11 AM, Richard Biener wrote: >> On Fri, Apr 5, 2019 at 2:32 PM Martin Liška wrote: >>> >>> Hi. >>> >>> The patch adds support for profile for GIMPLE FE. That can be useful >>> in the future. >>> >>> Patch can bootstrap on x86_64-linux-gnu and

Re: [PATCH] D support for RISC-V

2019-04-09 Thread David Abdurachmanov
On Tue, Apr 9, 2019 at 12:22 PM Andreas Schwab wrote: > > On Apr 09 2019, David Abdurachmanov wrote: > > > diff --git > > a/libphobos/src/std/experimental/allocator/building_blocks/region.d > > b/libphobos/src/std/experimental/allocator/building_blocks/region.d > > index

Re: [PATCH] D support for RISC-V

2019-04-09 Thread Andreas Schwab
On Apr 09 2019, David Abdurachmanov wrote: > diff --git > a/libphobos/src/std/experimental/allocator/building_blocks/region.d > b/libphobos/src/std/experimental/allocator/building_blocks/region.d > index dfcecce72bd..cafe059a61f 100644 > ---

Re: [PATCH] Remove some further trailing whitespaces from diagnostic messages (PR translation/90011)

2019-04-09 Thread Richard Biener
On Tue, 9 Apr 2019, Jakub Jelinek wrote: > Hi! > > Several further spots with trailing whitespace, only bootstrapped/regtested > on x86_64-linux and i686-linux (so the ipa-devirt.c change is covered), > the rest is just by eyeballing gcc.pot. > > Ok for trunk? OK. Richard. > I wonder where

Re: [PATCH] Fix s{,n}printf folding ICEs with slightly bogus prototypes (PR tree-optimization/89998)

2019-04-09 Thread Richard Biener
On Tue, 9 Apr 2019, Jakub Jelinek wrote: > Hi! > > If there are major differences in argument or return types of builtin > prototypes, we already don't mark them as builtins, but if there are smaller > differences like signedness changes of integral types with the same > precision, we still

[Patch, fortran] PRs 89843 and 90022 - C Fortran Interop fixes.

2019-04-09 Thread Paul Richard Thomas
The most part of this patch is concerned with implementing calls from C of of fortran bind c procedures with assumed shape or assumed rank dummies to completely fix PR89843. The conversion of the descriptors from CFI to gfc occur on entry to and reversed on exit from the procedure. This patch is

[PATCH] D support for RISC-V

2019-04-09 Thread David Abdurachmanov
This patch has been in Fedora/RISCV for the last couple of months. I have tested simple applications (e.g. word count example), which worked without a problem. I believe Iain Buclaw did run GCC testsuite using Fedora/RISCV build and QEMU. The patch has not changed since that. Signed-off-by:

[Patch AArch64] Add __ARM_FEATURE_ATOMICS

2019-04-09 Thread Ramana Radhakrishnan
This keeps coming up repeatedly and the ACLE has finally added __ARM_FEATURE_ATOMICS for the LSE feature in GCC. This is now part of the latest ACLE release (https://developer.arm.com/docs/101028/latest/5-feature-test-macros) I know it's late for GCC-9 but this is a simple macro which need

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-04-09 Thread Andreas Schwab
On Apr 08 2019, Marek Polacek wrote: > Thanks, committed. Andreas -- I hope the failure is fixed now. Yes, all tests of aggr-base[89].C are passing. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for

[PATCH] Remove some further trailing whitespaces from diagnostic messages (PR translation/90011)

2019-04-09 Thread Jakub Jelinek
Hi! Several further spots with trailing whitespace, only bootstrapped/regtested on x86_64-linux and i686-linux (so the ipa-devirt.c change is covered), the rest is just by eyeballing gcc.pot. Ok for trunk? I wonder where and how we could check for this kind of errors, unfortunately the strings

[C++ PATCH] Remove trailing space from diagnostics for narrowing conv (PR translation/90011)

2019-04-09 Thread Jakub Jelinek
Hi! In r263523 check_narrowing changed in this spot: pedwarn (loc, OPT_Wnarrowing, - "narrowing conversion of %qE from %qH to %qI " - "inside { }", init, ftype, type); + "narrowing conversion of %qE from %qH to %qI ", +

[C/C++ PATCH] Fix promoted switch condition out of range diagnostics (PR c/89888)

2019-04-09 Thread Jakub Jelinek
Hi! As mentioned in the PR, check_case_bounds warns about case labels on switches with promoted condition where the values lie fully (or partially when using ...) outside of the range of the original, non-promoted, type and adjusts (or doesn't create at all) the CASE_LABEL_EXPRs too early, so

[PATCH] Fix s{,n}printf folding ICEs with slightly bogus prototypes (PR tree-optimization/89998)

2019-04-09 Thread Jakub Jelinek
Hi! If there are major differences in argument or return types of builtin prototypes, we already don't mark them as builtins, but if there are smaller differences like signedness changes of integral types with the same precision, we still accept them (with warning). The following patch makes

Re: [PATCH] Fix PR90006

2019-04-09 Thread Richard Biener
On April 8, 2019 10:59:49 PM GMT+02:00, Richard Sandiford wrote: >Richard Biener writes: >> The following fixes SLP vectorization to properly consider >> calls like lrint demoting on ilp32 targets. >> >> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. >> >> Richard. >> >>

[committed] Fix typo in riscv diagnostics (PR target/90015)

2019-04-09 Thread Jakub Jelinek
Hi! The following patch fixes a typo in diagnostics as well as removes trailing dot. Tested by Jim and also preapproved by him in the PR, committed to trunk. 2019-04-09 Jakub Jelinek PR target/90015 * config/riscv/riscv.c (riscv_get_interrupt_type): Fix comment typo.