Add GCC support to ENQCMD.

2019-05-23 Thread Hongtao Liu
Hi Uros and all: This patch is about to enable support for ENQCMD(Enqueue Command) which will be in Willow Cove. There are two instructions for ENQCMD: ENQCMD and ENQCMDS. More details please refer to

[PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-23 Thread Alex Henrie
--- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86407#c6 --- gcc/c-family/c.opt | 4 gcc/c/c-decl.c | 4 +++- gcc/config/i386/i386-options.c | 12 ++-- gcc/testsuite/c-c++-common/pr86407-1.c | 23 +++

Re: [PATCH] rs6000: Call flow implementation for PC-relative addressing

2019-05-23 Thread Bill Schmidt
Hm, I got ahead of myself on this one.  I haven't done the regstrap yet, so please hold off reviewing for now. Sorry for the noise.  I shouldn't post when I'm tired... Thanks, Bill On 5/23/19 9:11 PM, Bill Schmidt wrote: > Hi, > > This patch contains the changes to implement call flow for

[PATCH] rs6000: Call flow implementation for PC-relative addressing

2019-05-23 Thread Bill Schmidt
Hi, This patch contains the changes to implement call flow for PC-relative addressing. It's an amalgam of several internal patches that Alan and I worked on, and as a result it's hard to tease apart individual pieces much further. So I apologize that this patch is a little larger than the

Re: [PATCH] Move VEC_PERM_EXPR folding to match.pd

2019-05-23 Thread Bernhard Reutner-Fischer
On 20 May 2019 12:31:46 CEST, Richard Biener wrote: > >So the following is what I have applied. Typo in the guard? s/GCC_VEC_PERN_INDICES_H/GCC_VEC_PERM_INDICES_H/ ? I.e. not pern but perm, with an 'M' thanks, >Bootstrapped / tested on x86_64-unknown-linux-gnu. > >Richard. > >2019-05-20

Re: Fix alias oracle stats

2019-05-23 Thread Bernhard Reutner-Fischer
Hi honza, On 20 May 2019 11:38:14 CEST, Richard Biener wrote: >On Mon, 20 May 2019, Jan Hubicka wrote: > >> Hi, >> at the moment the alias stats outputs mostly 0 for res_may_alias_p >> (which is supposed to be main entry point to the alias oracle). >> I think this is because of code refactoring

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-23 Thread Joseph Myers
On Tue, 21 May 2019, Segher Boessenkool wrote: > > I think having author names and email addresses is a basic requirement of > > any reasonable repository conversion > > Yes, and they should be the same as they were in the original repository. That's what the "changelogs" feature in

Re: *Ping* Re: [PATCH] PR c/43673 - Incorrect warning in dfp printf.

2019-05-23 Thread Joseph Myers
On Tue, 21 May 2019, Jeff Law wrote: > On 5/20/19 6:56 PM, luoxhu wrote: > > Ping for GCC-10. > I thought this was a NAK in its current form. > > See Ryan's c#1 in the BZ. I don't see that as relevant to this bug report. That comment is about the question of how GCC can know whether libc's

[PATCH] Fix testsuite bugs

2019-05-23 Thread Jonathan Wakely
One of the static assertions in 20_util/function_objects/invoke/1.cc was wrong, but didn't fail because by default it was compiled with -std=gnu++14 which didn't use that static assertion. Split out the C++17 parts to a new file that always runs with -std=gnu++17, so those checks are always done.

[PATCH] LWG 2996 add rvalue overloads for shared_ptr aliasing and casting

2019-05-23 Thread Jonathan Wakely
* doc/xml/manual/intro.xml: Document LWG DR 2996 change. * doc/html/*: Regenerate. * include/bits/shared_ptr.h (shared_ptr(shared_ptr&&, T*)): Add rvalue aliasing constructor. (static_pointer_cast, const_pointer, dynamic_pointer_cast)

[PATCH] LWG 2921 remove packaged_task constructors taking allocators

2019-05-23 Thread Jonathan Wakely
* doc/xml/manual/evolution.xml: Document LWG DR 2921 change. * doc/xml/manual/intro.xml: Likewise. * include/std/future (__create_task_state): Add default arguments to make providing an allocator optional. (packaged_task::packaged_task(F&&)): Call

[PATCH] Allow fusion of stack_protect_test_ with adjacent conditional jump (PR target/90568)

2019-05-23 Thread Jakub Jelinek
Hi! On Thu, May 23, 2019 at 12:40:51AM +0200, Jakub Jelinek wrote: > Incrementally, we should consider handling e.g. *subsi_2{,_zext} and similar > patterns and also this stack_protect_test_[sd]i in ix86_macro_fusion_pair_p, > not sure if unconditionally, or only when tuning for skylake+ /

[PATCH} rs6000: Enable PC-relative by default and test

2019-05-23 Thread Bill Schmidt
Hi, This is a short patch that enables PC-relative support by default, and provides a test case to ensure that the correct .localentry name,1 directive is produced iff PC-relative support is enabled. Bootstrapped and tested on powerpc64le-unknown-linux-gnu. Okay for trunk? Thanks, Bill

[PATCH] Add LABEL_REF_P to rtl.h

2019-05-23 Thread Bill Schmidt
Hi, This patch just adds a convenience macro to be used in subsequent patches. Bootstrapped successfully on powerpc64le-unknown-linux-gnu. Okay for trunk? Thanks, Bill 2019-05-23 Michael Meissner * rtl.h (LABEL_REF_P): New #define. Index: gcc/rtl.h

Re: Fixed: "required ftruncate or chsize support not present" in gfortran testsuite

2019-05-23 Thread Janne Blomqvist
On Thu, May 23, 2019 at 5:21 AM Hans-Peter Nilsson wrote: > > There was a regression for gfortran.dg/fmt_en.f90 for cris-elf > that on inspection was due to it having acquired a truncation > call through the runtime. I updated that and the new tests that > had "Fortran runtime error: required

Re: [PATCH,RFC 0/3] Support for CTF in GCC

2019-05-23 Thread Indu Bhagat
On 05/22/2019 02:04 AM, Richard Biener wrote: The CTF debug information is kept in a CTF container distinct from the frontend structures. HashMaps are used to avoid generation of duplicate CTF and to book-keep the generated CTF. OK. So I wonder how difficult it is to emit CTF by walking

[PATCH, i386]: Fix PR90552, attribute((optimize(3))) not overriding -Os

2019-05-23 Thread Uros Bizjak
Hello! As explained in the PR, ix86_cost switches to ix86_size_cost when -Os is used. This defeats the intention of speed variable to ix86_rtx_costs, which is set according to the optimization level at the point of insn insertion. 2019-05-23 Uroš Bizjak PR target/90552 *

[C++ Patch] A few more grokdeclarator locations fixes

2019-05-23 Thread Paolo Carlini
Hi, one more, rather straightforward, simply use the location stored in the declarator. Tested x86_64-linux. Thanks, Paolo. /cp 2019-05-23 Paolo Carlini * decl.c (grokdeclarator): Use declarator->id_loc in five error error_at calls. /testsuite

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-23 Thread Steve Kargl
On Thu, May 23, 2019 at 05:26:53PM +0200, Christophe Lyon wrote: > On Thu, 23 May 2019 at 15:54, Mark Eggleston > wrote: > > > > > > The logs contain: > > > /gcc/testsuite/gfortran.dg/fmt_f_default_field_width_1.f90:15:11: > > > Error: Kind 16 not supported for type REAL at (1) > > > > > >

Re: [PATCH] netbsd EABI support

2019-05-23 Thread coypu
On Thu, May 23, 2019 at 05:11:30PM +0100, Richard Earnshaw (lists) wrote: > On 23/05/2019 17:01, Richard Earnshaw (lists) wrote: > > On 23/05/2019 15:11, Richard Earnshaw (lists) wrote: > >> On 23/05/2019 15:03, Richard Earnshaw (lists) wrote: > >>> On 20/05/2019 20:24, Jeff Law wrote: > On

Re: [PATCH v2] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-23 Thread Segher Boessenkool
On Thu, May 23, 2019 at 10:21:44AM -0500, Bill Schmidt wrote: > Functions using PC-relative addressing do not use a TOC, so there is no need > for > a global entry point for TOC setup. Ensure we never generate a global entry > point, and use a .localentry directive that sets the upper st_other

Re: [PATCH] netbsd EABI support

2019-05-23 Thread Richard Earnshaw (lists)
On 23/05/2019 17:01, Richard Earnshaw (lists) wrote: > On 23/05/2019 15:11, Richard Earnshaw (lists) wrote: >> On 23/05/2019 15:03, Richard Earnshaw (lists) wrote: >>> On 20/05/2019 20:24, Jeff Law wrote: On 4/9/19 10:36 AM, Richard Earnshaw (lists) wrote: > On 09/04/2019 16:04, Jeff Law

Re: [PATCH] netbsd EABI support

2019-05-23 Thread Ramana Radhakrishnan
On Thu, May 23, 2019 at 3:12 PM Richard Earnshaw (lists) wrote: > > On 23/05/2019 15:03, Richard Earnshaw (lists) wrote: > > On 20/05/2019 20:24, Jeff Law wrote: > >> On 4/9/19 10:36 AM, Richard Earnshaw (lists) wrote: > >>> On 09/04/2019 16:04, Jeff Law wrote: > On 4/8/19 9:17 AM,

[PATCH] Add missing feature test macro to C++17 status table

2019-05-23 Thread Jonathan Wakely
* doc/xml/manual/status_cxx2017.xml: Add feature test macro for P0040R3. * doc/html/*: Regenerate. Committed to trunk. commit f58762124c374887a5785a6f4a812af64fe5b2f1 Author: Jonathan Wakely Date: Thu May 23 17:00:37 2019 +0100 Add missing feature test macro to

Re: [PATCH] netbsd EABI support

2019-05-23 Thread Richard Earnshaw (lists)
On 23/05/2019 15:11, Richard Earnshaw (lists) wrote: > On 23/05/2019 15:03, Richard Earnshaw (lists) wrote: >> On 20/05/2019 20:24, Jeff Law wrote: >>> On 4/9/19 10:36 AM, Richard Earnshaw (lists) wrote: On 09/04/2019 16:04, Jeff Law wrote: > On 4/8/19 9:17 AM, co...@sdf.org wrote: >>

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread H.J. Lu
On Thu, May 23, 2019 at 8:25 AM Iain Sandoe wrote: > > > > On 23 May 2019, at 16:17, H.J. Lu wrote: > > > > On Thu, May 23, 2019 at 6:09 AM Uros Bizjak wrote: > >> > >> On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: > >> > These changes are OK as long as they don't regress HJ's

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-23 Thread Christophe Lyon
On Thu, 23 May 2019 at 15:54, Mark Eggleston wrote: > > On 23/05/2019 11:38, Christophe Lyon wrote: > > On Wed, 22 May 2019 at 13:57, Janne Blomqvist > > wrote: > >> On Wed, May 22, 2019 at 10:58 AM Mark Eggleston > >> wrote: > >>> On 13/05/2019 10:45, Mark Eggleston wrote: >

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Iain Sandoe
> On 23 May 2019, at 16:17, H.J. Lu wrote: > > On Thu, May 23, 2019 at 6:09 AM Uros Bizjak wrote: >> >> On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: >> These changes are OK as long as they don't regress HJ's x86_64 and i686 autotesters. >>> >>> Applied as r271544, will

[PATCH v2] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-23 Thread Bill Schmidt
Hi, Functions using PC-relative addressing do not use a TOC, so there is no need for a global entry point for TOC setup. Ensure we never generate a global entry point, and use a .localentry directive that sets the upper st_other bits to 1. Also change a function name for clarity, and move a var

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread H.J. Lu
On Thu, May 23, 2019 at 6:09 AM Uros Bizjak wrote: > > On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: > > > > These changes are OK as long as they don't regress HJ's x86_64 and > > > i686 autotesters. > > > > Applied as r271544, will look out for such fails. > > > > > Double points if they

Re: [PATCH] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-23 Thread Segher Boessenkool
On Thu, May 23, 2019 at 08:56:23AM -0500, Bill Schmidt wrote: > On 5/23/19 6:06 AM, Segher Boessenkool wrote: > > On Wed, May 22, 2019 at 06:39:55PM -0500, Bill Schmidt wrote: > >> @@ -26191,6 +26191,10 @@ rs6000_global_entry_point_needed_p (void) > >>if (TARGET_SINGLE_PIC_BASE) > >>

Re: [RFC PATCH] Coalesce host to device transfers in libgomp

2019-05-23 Thread Jakub Jelinek
On Thu, May 23, 2019 at 04:40:14PM +0200, Thomas Schwinge wrote: > Hi! > > On Tue, 24 Oct 2017 11:55:27 +0200, Jakub Jelinek wrote: > > The following patch implements coalescing of transfers (only those that are > > copied into the freshly allocated device buffer) into one or multiple larger > >

Re: [PATCH] A jump threading opportunity for condition branch

2019-05-23 Thread Jiufu Guo
Richard Biener writes: > On Thu, 23 May 2019, Jiufu Guo wrote: > >> Hi, >> >> Richard Biener writes: >> >> > On Tue, 21 May 2019, Jiufu Guo wrote: >> > >> >> Hi, >> >> >> >> This patch implements a new opportunity of jump threading for PR77820. >> >> In this optimization, conditional jumps

Re: [RFC PATCH] Coalesce host to device transfers in libgomp

2019-05-23 Thread Thomas Schwinge
Hi! On Tue, 24 Oct 2017 11:55:27 +0200, Jakub Jelinek wrote: > The following patch implements coalescing of transfers (only those that are > copied into the freshly allocated device buffer) into one or multiple larger > transfers. The patch doesn't coalesce > 32KB transfers or transfers where >

[PATCH] Make any_cast compare typeinfo as well as function pointers

2019-05-23 Thread Jonathan Wakely
It's possible for the function pointer comparison to fail even though the type is correct, because the function could be defined multiple times with different addresses when shared libraries are in use. Retain the function pointer check for the common case where the check succeeds, but compare

Re: [PATCH] netbsd EABI support

2019-05-23 Thread Richard Earnshaw (lists)
On 23/05/2019 15:03, Richard Earnshaw (lists) wrote: > On 20/05/2019 20:24, Jeff Law wrote: >> On 4/9/19 10:36 AM, Richard Earnshaw (lists) wrote: >>> On 09/04/2019 16:04, Jeff Law wrote: On 4/8/19 9:17 AM, co...@sdf.org wrote: > Pinging again in the hope of getting the patch in, I'd like

Re: [PATCH] netbsd EABI support

2019-05-23 Thread Richard Earnshaw (lists)
On 20/05/2019 20:24, Jeff Law wrote: > On 4/9/19 10:36 AM, Richard Earnshaw (lists) wrote: >> On 09/04/2019 16:04, Jeff Law wrote: >>> On 4/8/19 9:17 AM, co...@sdf.org wrote: Pinging again in the hope of getting the patch in, I'd like to have less outstanding patches :) (I have quite a

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-23 Thread Steve Kargl
On Thu, May 23, 2019 at 12:38:12PM +0200, Christophe Lyon wrote: > On Wed, 22 May 2019 at 13:57, Janne Blomqvist > wrote: > > > > > > * gfortran.dg/fmt_f_default_field_width_1.f90: New test. > > > > * gfortran.dg/fmt_f_default_field_width_2.f90: New test. > > > > *

Re: [PATCH] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-23 Thread Bill Schmidt
On 5/23/19 6:06 AM, Segher Boessenkool wrote: > Hi! > > On Wed, May 22, 2019 at 06:39:55PM -0500, Bill Schmidt wrote: >> @@ -26191,6 +26191,10 @@ rs6000_global_entry_point_needed_p (void) >>if (TARGET_SINGLE_PIC_BASE) >> return false; >> >> + /* PC-relative functions never generate a

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-23 Thread Mark Eggleston
On 23/05/2019 11:38, Christophe Lyon wrote: On Wed, 22 May 2019 at 13:57, Janne Blomqvist wrote: On Wed, May 22, 2019 at 10:58 AM Mark Eggleston wrote: On 13/05/2019 10:45, Mark Eggleston wrote: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89100 see comment 4 Please can someone commit the

Re: [PATCH] tree-ssa-uninit: suppress more spurious warnings

2019-05-23 Thread Vladislav Ivanishin
Iain Sandoe writes: >> On 22 May 2019, at 16:19, Jeff Law wrote: >> >> On 5/22/19 8:44 AM, Vladislav Ivanishin wrote: >>> Christophe, Rainer, >>> >>> Rainer Orth writes: >>> Hi Christophe, > On Fri, 17 May 2019 at 10:12, Vladislav Ivanishin wrote: >> > As you have

[PATCH] PR libstdc++/90220 fix experimental::any_cast for non-object types

2019-05-23 Thread Jonathan Wakely
This corresponds to the fixes done for std::any_cast, but has to be done without if-constexpr. The dummy specialization of _Manager_internal<_Op> is used to avoid instantiating the real _Manager_internal::_S_manage function just to compare its address. PR libstdc++/90220 *

Re: [PATCH] rs6000: Add basic infrastructure for PC-relative addressing

2019-05-23 Thread Bill Schmidt
On 5/23/19 4:27 AM, Segher Boessenkool wrote: > Hi! > > On Wed, May 22, 2019 at 03:29:17PM -0500, Bill Schmidt wrote: >> + /* -mpcrel requires the prefixed load/store support on FUTURE systems. */ >> + if (!TARGET_FUTURE && TARGET_PCREL) >> +{ >> + if ((rs6000_isa_flags_explicit &

Re: [PATCH v2] rs6000: Infrastructure for future arch

2019-05-23 Thread Segher Boessenkool
On Thu, May 23, 2019 at 04:27:34AM -0500, Bill Schmidt wrote: > This patch introduces the infrastructure to support -mcpu=future, used for > features > in a future architecture, as yet unnamed. Reworked to incorporate comments > from > Segher and Alan. Thanks for the reviews! > > Bootstrapped

Re: Fix simulator timeout for testsuite/26_numerics/random/poisson_distribution/operators/values.cc

2019-05-23 Thread Jonathan Wakely
On 23/05/19 15:14 +0200, Hans-Peter Nilsson wrote: This test regressed for cris-elf (testing in a simulator) with the fixing of libstdc++/83237, as the part suggested to be wrapped in #ifndef was *added* to the existing test and causes a timeout. Tsk tsk. Please don't pile-on existing tests,

Re: [PATCH] Remove resolved TODO comment

2019-05-23 Thread Jason Merrill
On Thu, May 23, 2019 at 4:45 AM Jonathan Wakely wrote: > > * init.c (std_placement_new_fn_p): Remove outdated TODO comment that > was resolved by r254694. > > Committing to trunk as obvious. > > Should I bother doing the same thing on the branches where this was > resolved? I

Fix simulator timeout for testsuite/26_numerics/random/poisson_distribution/operators/values.cc

2019-05-23 Thread Hans-Peter Nilsson
This test regressed for cris-elf (testing in a simulator) with the fixing of libstdc++/83237, as the part suggested to be wrapped in #ifndef was *added* to the existing test and causes a timeout. Tsk tsk. Please don't pile-on existing tests, instead add a *separate* test-file. >From what I

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Uros Bizjak
On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: > > These changes are OK as long as they don't regress HJ's x86_64 and > > i686 autotesters. > > Applied as r271544, will look out for such fails. > > > Double points if they also fix -fpic failures. ;) > > make check-gcc-c

Re: [ARM/FDPIC v5 00/21] FDPIC ABI for ARM

2019-05-23 Thread Christophe Lyon
Ping? Any feedback other than what I got on patch 03/21 ? Thanks, Christophe On 15/05/2019 14:39, Christophe Lyon wrote: Hello, This patch series implements the GCC contribution of the FDPIC ABI for ARM targets. This ABI enables to run Linux on ARM MMU-less cores and supports shared

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-05-23 Thread Christophe Lyon
On 22/05/2019 10:45, Christophe Lyon wrote: On Wed, 22 May 2019 at 10:39, Szabolcs Nagy wrote: On 21/05/2019 16:28, Christophe Lyon wrote: --- a/gcc/config/arm/linux-eabi.h +++ b/gcc/config/arm/linux-eabi.h @@ -89,7 +89,7 @@ #define MUSL_DYNAMIC_LINKER_E "%{mbig-endian:eb}" #endif

Re: Strenghten aliasing_component_refs_p

2019-05-23 Thread Jan Hubicka
> > Whoops, didn't notice that. > > Indeed - Honza please fix. > Thanks to Martin's reduction, hunting down the soplex issue was easy. There was two thinkos I managed to introduce while converting the patch to three way compare. First we only need to call same_types_for_tbaa if the sizes

Re: [PATCH] A jump threading opportunity for condition branch

2019-05-23 Thread Richard Biener
On Thu, 23 May 2019, Jiufu Guo wrote: > Hi, > > Richard Biener writes: > > > On Tue, 21 May 2019, Jiufu Guo wrote: > > > >> Hi, > >> > >> This patch implements a new opportunity of jump threading for PR77820. > >> In this optimization, conditional jumps are merged with unconditional jump. >

Re: [PATCH] A jump threading opportunity for condition branch

2019-05-23 Thread Jiufu Guo
Hi, Richard Biener writes: > On Tue, 21 May 2019, Jiufu Guo wrote: > >> Hi, >> >> This patch implements a new opportunity of jump threading for PR77820. >> In this optimization, conditional jumps are merged with unconditional jump. >> And then moving CMP result to GPR is eliminated. >> >> It

[PATCH] RX: Add rx-*-linux target

2019-05-23 Thread Yoshinori Sato
I ported linux kernel to Renesas RX. rx-*-elf target output a binary different from the standard ELF. It has the same format as the Renesas compiler. But the linux kernel requires the standard ELF format. I want to define a rx-*-linux target so that I can generate a standard ELF binary. diff

[PATCH] PR c++/90592 add missing word "scope" to __func__ docs

2019-05-23 Thread Jonathan Wakely
PR c++/90592 * doc/extend.texi (Function Names): Add missing word. Committed to trunk. commit 85ff756ada9537ba8a24c41dad7e2f1c84c27f06 Author: Jonathan Wakely Date: Thu May 23 11:44:36 2019 +0100 PR c++/90592 add missing word "scope" to __func__ docs PR

Re: [PATCH] Fix PR88440, enable mem* detection at -O[2s]

2019-05-23 Thread Richard Biener
On Wed, 22 May 2019, Richard Biener wrote: > > This enables -ftree-loop-distribute-patterns at -O[2s] and also > arranges cold loops to be still processed but for pattern > recognition to save code-size. > > Bootstrap and regtest running on x86_64-unknown-linux-gnu. > > Martin has done

[PATCH] aarch64: emit .variant_pcs for aarch64_vector_pcs symbol references

2019-05-23 Thread Szabolcs Nagy
A dynamic linker with lazy binding support may need to handle variant PCS function symbols specially, so an ELF symbol table marking was introduced for such symbols. Global symbol references and definitions that follow the vector PCS are marked in the generated assembly and then the

Re: [PATCH] Do not use tree_to_wide_ref that point to a temporary (PR c++/90587).

2019-05-23 Thread Richard Biener
On Thu, May 23, 2019 at 12:51 PM Martin Liška wrote: > > Hi. > > The PR is about use-after-scope issue where: > wi::tree_to_wide_ref andw = wi::to_wide (val) & wi::to_wide (boundary); > > The RHS1 and RHS2 will become out-of-scope after operator& returns a > reference. > andw.val then points to

Re: [PATCH] Improve stack_protect_test_ on x86 (PR target/90568)

2019-05-23 Thread Uros Bizjak
On Thu, May 23, 2019 at 12:41 AM Jakub Jelinek wrote: > > Hi! > > For stack_protect_test_[sd]i we don't use comparison, so that we clear the > content of the register and don't keep the stack canary in any register for > security reasons, but as mentioned in the PR, using sub instead of xor >

Re: [PATCH] rs6000: Entry point generation for functions using PC-relative addressing

2019-05-23 Thread Segher Boessenkool
Hi! On Wed, May 22, 2019 at 06:39:55PM -0500, Bill Schmidt wrote: > @@ -26191,6 +26191,10 @@ rs6000_global_entry_point_needed_p (void) >if (TARGET_SINGLE_PIC_BASE) > return false; > > + /* PC-relative functions never generate a global entry point prologue. */ > + if (rs6000_pcrel_p

Re: [PATCH, X86] Disable mfentry for Darwin and amend testing.

2019-05-23 Thread Uros Bizjak
On Thu, May 23, 2019 at 11:34 AM Iain Sandoe wrote: > > Hi Uros, > > > On 23 May 2019, at 07:33, Uros Bizjak wrote: > > > > On Thu, May 23, 2019 at 1:09 AM Iain Sandoe wrote: > >> > >> Although this is a Darwin-specific change, I need to touch > >> target-supports.exp and several tests in

[PATCH] Do not use tree_to_wide_ref that point to a temporary (PR c++/90587).

2019-05-23 Thread Martin Liška
Hi. The PR is about use-after-scope issue where: wi::tree_to_wide_ref andw = wi::to_wide (val) & wi::to_wide (boundary); The RHS1 and RHS2 will become out-of-scope after operator& returns a reference. andw.val then points to one of RHS1 or RHS2. So that we end up with an use-after-scope. Patch

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-23 Thread Christophe Lyon
On Wed, 22 May 2019 at 13:57, Janne Blomqvist wrote: > > On Wed, May 22, 2019 at 10:58 AM Mark Eggleston > wrote: > > > > On 13/05/2019 10:45, Mark Eggleston wrote: > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89100 see comment 4 > > > > > > Please can someone commit the attached patch as

[Ada] Stabilize sort for -fdump-ada-spec

2019-05-23 Thread Eric Botcazou
Self-explanatory. Tested on x86-64/Lnux, applied on mainline and 9 branch. 2019-05-23 Eric Botcazou * c-ada-spec.c (compare_node): Compare the DECL_UIDs as a last resort. -- Eric BotcazouIndex: c-ada-spec.c === ---

Re: [PATCH] Do not instrument static target_expr for use-after-scope (PR sanitizer/90570).

2019-05-23 Thread Martin Liška
On 5/23/19 9:26 AM, Jakub Jelinek wrote: > On Thu, May 23, 2019 at 09:23:09AM +0200, Martin Liška wrote: >> Hi. >> >> ASAN should skip TREE_STATIC target expression similarly to >> gimplify_decl_expr. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be

[testsuite] Add testcase to gnat.dg testsuite

2019-05-23 Thread Eric Botcazou
This adds the Ada testcase that detected a since then fixed regression on the 8 branch introduced by a backport. Tested on x86_64-suse-linux, applied on mainline, 9 and 8 branches. 2019-05-23 Eric Botcazou * gnat.dg/opt78.ad[sb]: New test. -- Eric Botcazou-- { dg-do compile } --

Re: [PATCH] rs6000: One more bit of PC-relative enablement

2019-05-23 Thread Segher Boessenkool
On Wed, May 22, 2019 at 05:15:05PM -0500, Bill Schmidt wrote: > My last patch was a result of refactoring, and I missed one important line. > Bootstrapped and tested on powerpc64le-unknown-linux-gnu; okay for turnk > with the other patch? Okay for trunk. Thanks! Segher > *

Re: Strenghten aliasing_component_refs_p

2019-05-23 Thread Jan Hubicka
> On Thu, 23 May 2019, Bernhard Reutner-Fischer wrote: > > > On 20 May 2019 11:40:17 CEST, Richard Biener wrote: > > >On Sun, 19 May 2019, Jan Hubicka wrote: > > > > > >> > On Fri, 17 May 2019, Jan Hubicka wrote: > > >> > > > >> > > Hi, > > >> > > this patch cuts walks in

Re: [PATCH, X86] Disable mfentry for Darwin and amend testing.

2019-05-23 Thread Iain Sandoe
Hi Uros, > On 23 May 2019, at 07:33, Uros Bizjak wrote: > > On Thu, May 23, 2019 at 1:09 AM Iain Sandoe wrote: >> >> Although this is a Darwin-specific change, I need to touch >> target-supports.exp and several tests in i386.exp. >> >> tested on x86_64-darwin and x86_64-linux-gnu >> doc

Re: [PATCH] rs6000: Add basic infrastructure for PC-relative addressing

2019-05-23 Thread Segher Boessenkool
Hi! On Wed, May 22, 2019 at 03:29:17PM -0500, Bill Schmidt wrote: > + /* -mpcrel requires the prefixed load/store support on FUTURE systems. */ > + if (!TARGET_FUTURE && TARGET_PCREL) > +{ > + if ((rs6000_isa_flags_explicit & OPTION_MASK_PCREL) != 0) > + error ("%qs requires %qs",

[PATCH v2] rs6000: Infrastructure for future arch

2019-05-23 Thread Bill Schmidt
Hi, This patch introduces the infrastructure to support -mcpu=future, used for features in a future architecture, as yet unnamed. Reworked to incorporate comments from Segher and Alan. Thanks for the reviews! Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no regressions. Is

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Iain Sandoe
Hi Uros. > On 23 May 2019, at 07:23, Uros Bizjak wrote: > > On Wed, May 22, 2019 at 8:41 PM Iain Sandoe wrote: >> >> As Dominque noted in PR 64895, somewhere between revisions >> r244915 and r244957 we see the fuse-caller-save* tests started to >> XPASS on Darwin, which is a PIC target by

Re: Strenghten aliasing_component_refs_p

2019-05-23 Thread Richard Biener
On Thu, 23 May 2019, Bernhard Reutner-Fischer wrote: > On 20 May 2019 11:40:17 CEST, Richard Biener wrote: > >On Sun, 19 May 2019, Jan Hubicka wrote: > > > >> > On Fri, 17 May 2019, Jan Hubicka wrote: > >> > > >> > > Hi, > >> > > this patch cuts walks in aliasing_component_refs_p if the type we

[PATCH] Add whitespace between operator and operand

2019-05-23 Thread Jonathan Wakely
* cp-tree.h (CP_AGGREGATE_TYPE_P): Fix whitespace. Committed to trunk as obvious. commit 2890db66c132b0d79c90c0b54e3f8f9f668b031b Author: Jonathan Wakely Date: Thu May 23 09:50:12 2019 +0100 Add whitespace between operator and operand * cp-tree.h

Re: [PATCH] rs6000: Add basic infrastructure for PC-relative addressing

2019-05-23 Thread Bill Schmidt
On 5/22/19 3:29 PM, Bill Schmidt wrote: > Hi, > > This patch adds basic infrastructure support to enable PC-relative addressing. > It adds the -mpcrel / -mno-pcrel option (defaulted on for -mcpu=future, > otherwise > off), and provides a couple of interfaces to determine whether PC-relative >

[PATCH] Remove conflict marker from ChangeLog

2019-05-23 Thread Jonathan Wakely
Committing as obvious. commit 37084e7223802d5d38729f12fd3e1be3b86246fc Author: Jonathan Wakely Date: Thu May 23 09:43:21 2019 +0100 Remove conflict marker from ChangeLog diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9f0f8893022..d3b4e32325c 100644 --- a/gcc/ChangeLog +++

[PATCH] Remove resolved TODO comment

2019-05-23 Thread Jonathan Wakely
* init.c (std_placement_new_fn_p): Remove outdated TODO comment that was resolved by r254694. Committing to trunk as obvious. Should I bother doing the same thing on the branches where this was resolved? commit 31b5063cfade07089e5856ecf0f08d5f7bef65f9 Author: Jonathan Wakely

Re: [PATCH][RFC] Fix PR90510, VEC_PERM -> BIT_INSERT folding

2019-05-23 Thread Thomas Schwinge
Hi! On Wed, 22 May 2019 15:39:52 +0200, Richard Biener wrote: > On Wed, 22 May 2019, Thomas Schwinge wrote: > > On Tue, 21 May 2019 13:11:54 +0200 (CEST), Richard Biener > > wrote: > > > On Mon, 20 May 2019, Richard Biener wrote: > > > > On Sun, 19 May 2019, Richard Sandiford wrote: > > > > >

[PATCH] PR fortran/89103 - Allow blank format items in format strings

2019-05-23 Thread Mark Eggleston
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89103 see comment 4 Please can some one commit the attached patch for me as I do not have the privileges to do so. Change logs: gcc/fortran     Jim MacArthur      Mark Eggleston      PR fortran/89103     * gfortran.texi: Add

[committed] Add testcase for std::is_constant_evaluated() vs. explicit(bool)

2019-05-23 Thread Jakub Jelinek
Hi! I've noticed we don't have any testcases covering manifestly constant evaluation inside of explicit bool, tested thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2019-05-23 Jakub Jelinek * g++.dg/cpp2a/is-constant-evaluated8.C: New

Re: [PATCH] Do not instrument static target_expr for use-after-scope (PR sanitizer/90570).

2019-05-23 Thread Jakub Jelinek
On Thu, May 23, 2019 at 09:23:09AM +0200, Martin Liška wrote: > Hi. > > ASAN should skip TREE_STATIC target expression similarly to > gimplify_decl_expr. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog:

[PATCH] Do not instrument static target_expr for use-after-scope (PR sanitizer/90570).

2019-05-23 Thread Martin Liška
Hi. ASAN should skip TREE_STATIC target expression similarly to gimplify_decl_expr. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-05-22 Martin Liska PR sanitizer/90570 * gimplify.c

Re: Strenghten aliasing_component_refs_p

2019-05-23 Thread Bernhard Reutner-Fischer
On 20 May 2019 11:40:17 CEST, Richard Biener wrote: >On Sun, 19 May 2019, Jan Hubicka wrote: > >> > On Fri, 17 May 2019, Jan Hubicka wrote: >> > >> > > Hi, >> > > this patch cuts walks in aliasing_component_refs_p if the type we >look for >> > > can not fit into a given type by comparing their

Re: [PATCH, X86] Disable mfentry for Darwin and amend testing.

2019-05-23 Thread Uros Bizjak
On Thu, May 23, 2019 at 1:09 AM Iain Sandoe wrote: > > Although this is a Darwin-specific change, I need to touch > target-supports.exp and several tests in i386.exp. > > tested on x86_64-darwin and x86_64-linux-gnu > doc change tested with “make pdf”, > > OK for trunk? > backports? (where the

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Uros Bizjak
On Wed, May 22, 2019 at 8:41 PM Iain Sandoe wrote: > > As Dominque noted in PR 64895, somewhere between revisions > r244915 and r244957 we see the fuse-caller-save* tests started to > XPASS on Darwin, which is a PIC target by default. > > The XFAILed parts of the tests never seem to be exercised

PING*2: Re: abstract out EH propagation cleanups

2019-05-23 Thread Aldy Hernandez
PING*2 On 5/15/19 12:36 PM, Aldy Hernandez wrote: Sorry, I meant to PING this one. Aldy On Wed, May 8, 2019 at 5:08 PM Aldy Hernandez wrote: On 5/8/19 2:30 AM, Richard Biener wrote: On Tue, May 7, 2019 at 11:55 PM Jeff Law wrote: On 5/7/19 3:45 AM, Richard Biener wrote: On Tue, May 7,