Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-24 Thread Richard Biener
On May 24, 2019 5:49:38 PM GMT+02:00, Alex Henrie wrote: >On Fri, May 24, 2019 at 2:01 AM Richard Biener >wrote: >> >> I'm not sure we really need a new warning for this. > >On Fri, May 24, 2019 at 9:23 AM Martin Sebor wrote: >> >> I don't think GCC makes a formal distinction between function >

[committed] Fix problem reloading floating-point operands in xmpyu patterns on 64-bit parisc

2019-05-24 Thread John David Anglin
On 64-bit targets, 32-bit values are typically extended to 64-bits. So, the 32-bit SImode operands in the xmpyu patterns end up being loaded as 64-bit values into a a floating-point register. The value is then implicitly narrowed to 32 bits by pa_print_operand(). In the case the operand needs

[committed] Implement OpenMP 5.0 lastprivate(conditional:) for #pragma omp for

2019-05-24 Thread Jakub Jelinek
Hi! The following patch implements lastprivate clause with conditional modifier for #pragma omp for (when not combined with parallel). Next week I'll try to address combined parallel for, sections, simd and for simd. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2019

Re: [C++ Patch] PR 89875 ("[7/8/9/10 Regression] invalid typeof reference to a member of an incomplete struct accepted at function scope")

2019-05-24 Thread Paolo Carlini
Hi, gently pinging this... On 10/05/19 16:29, Paolo Carlini wrote: Hi, a while ago Martin noticed that an unintended consequence of an old tweak of mine - which avoided redundant error messages emitted from cp_parser_init_declarator - is that, in some cases, we started accepting ill-formed

Re: C++ PATCH for c++/90572 - wrong disambiguation in friend declaration

2019-05-24 Thread Jason Merrill
On 5/24/19 3:16 PM, Marek Polacek wrote: Here we were parsing template struct C { friend C(T::fn)(); // this }; wrongly in C++2a since my P0634 patch. T::fn is actually a function declaration, but cp_parser_constructor_declarator_p was thinking it's a constructor. That function ac

Re: Question on adding an option control to libcpp

2019-05-24 Thread Qing Zhao
Hi, David, this is helpful. thanks. Qing > On May 24, 2019, at 1:47 PM, David Malcolm wrote: > > On Fri, 2019-05-24 at 11:59 -0500, Qing Zhao wrote: >> Hi, >> >> in order to fix PR90581: (provide an option to adjust the maximum >> depth of nested #include) >> >> https://gcc.gnu.org/bugzilla

C++ PATCH for c++/90572 - wrong disambiguation in friend declaration

2019-05-24 Thread Marek Polacek
Here we were parsing template struct C { friend C(T::fn)(); // this }; wrongly in C++2a since my P0634 patch. T::fn is actually a function declaration, but cp_parser_constructor_declarator_p was thinking it's a constructor. That function actually has code to prevent the compiler from

Re: Question on adding an option control to libcpp

2019-05-24 Thread David Malcolm
On Fri, 2019-05-24 at 11:59 -0500, Qing Zhao wrote: > Hi, > > in order to fix PR90581: (provide an option to adjust the maximum > depth of nested #include) > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 rg/bugzilla/show_bug.cgi?id=90581> > > we need to add a new opt

Re: [PATCH] Commonize anon-name generation

2019-05-24 Thread Iain Buclaw
On Fri, 24 May 2019 at 16:34, Nathan Sidwell wrote: > > Currently gcc/tree.c exports an anonymous name format string, and a > predicate to detect identifiers of that form. The C++ and D FEs use > those functions to create and check anonymous names. > > That seems a little duplicative. This patch

Question on adding an option control to libcpp

2019-05-24 Thread Qing Zhao
Hi, in order to fix PR90581: (provide an option to adjust the maximum depth of nested #include) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 we need to add a new option to preprocessor. where should I put this option? I tried to add

Re: [PATCH] aarch64: emit .variant_pcs for aarch64_vector_pcs symbol references

2019-05-24 Thread Szabolcs Nagy
On 24/05/2019 15:31, Richard Sandiford wrote: > Szabolcs Nagy writes: >> +static void >> +aarch64_asm_output_variant_pcs (FILE *stream, const tree decl, const char* >> name) >> +{ >> + if (TREE_CODE (decl) == FUNCTION_DECL >> + && TREE_PUBLIC (decl) >> + && lookup_attribute ("aarch64_v

Re: [PATCH][GCC][AArch64] Make processing less fragile in config.gcc

2019-05-24 Thread Kyrill Tkachov
Hi Tamar, On 5/21/19 6:00 PM, Tamar Christina wrote: Hi All, Due to config.gcc all the options need to be on one line because of the grep lines which would select only the first line of the option. This causes it not to select the right bits on options that are spread over multiple lines wh

Re: C++ PATCH to implement deferred parsing of noexcept-specifiers (c++/86476, c++/52869)

2019-05-24 Thread Marek Polacek
Ping. On Fri, May 17, 2019 at 10:35:29AM -0400, Marek Polacek wrote: > Ping. > > On Fri, May 10, 2019 at 03:21:33PM -0400, Marek Polacek wrote: > > Coming back to this. I didn't think this was suitable for GCC 9. > > > > On Mon, Jan 07, 2019 at 10:44:37AM -0500, Jason Merrill wrote: > > > On 12

[PATCH V3] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-05-24 Thread Feng Xue OS
Doing aggressive loop removal at early CD-DCE might break OpenACC transformation. To the issue, this version 3 gave a somewhat simpler solution different from previous version 2. It uses a flag to postpone loop removal to late CD-DCE pass. Feng - diff --git a/gcc/ChangeLog b/gcc/Change

Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-24 Thread Alex Henrie
On Fri, May 24, 2019 at 2:01 AM Richard Biener wrote: > > I'm not sure we really need a new warning for this. On Fri, May 24, 2019 at 9:23 AM Martin Sebor wrote: > > I don't think GCC makes a formal distinction between function > attributes that affect only function definitions vs those that > a

[PATCH] Fix std::midpoint(T*, T*) for reversed arguments

2019-05-24 Thread Jonathan Wakely
* include/std/numeric (midpoint(T*, T*)): Fix incorrect result. * testsuite/26_numerics/midpoint/pointer.cc: Change "compile" test to "run". Tested x86_64-linux, committed to trunk. I'll backport to gcc-9-branch too. commit c8993a6a75753f9be84edaa692dc36e50dc9b30f Author

Re: [PATCH] Make any_cast compare typeinfo as well as function pointers

2019-05-24 Thread Jonathan Wakely
On 24/05/19 11:26 +0100, Jonathan Wakely wrote: On 24/05/19 10:57 +0200, Christophe Lyon wrote: Hi Jonathan, On Thu, 23 May 2019 at 16:13, Jonathan Wakely wrote: It's possible for the function pointer comparison to fail even though the type is correct, because the function could be defined m

[committed, amdgcn] Wait for exit value to write before exiting.

2019-05-24 Thread Andrew Stubbs
This patch fixes a bug in which GCN5 devices often fail to return an exit value because it's not yet been written to memory when the program exits. The fix is simply to wait for it properly. GCN3 devices did not demonstrate the problem, but it was technically wrong there also. The bug was intro

Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-24 Thread Martin Sebor
On 5/23/19 9:57 PM, Alex Henrie wrote: --- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86407#c6 --- gcc/c-family/c.opt | 4 gcc/c/c-decl.c | 4 +++- gcc/config/i386/i386-options.c | 12 ++-- gcc/testsuite/c-c++-common/pr8640

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-05-24 Thread Kyrill Tkachov
Hi Jiangning On 3/15/19 4:46 AM, JiangNing OS wrote: This patch is to fix a missing ifcvt opportunity in back-end. For the simple case below, if (...)     x = a;  /* x is memory */ /* no else */ We can generate conditional move and remove the branch as below if the target cost is acceptable.

Re: [PATCH] A jump threading opportunity for condition branch

2019-05-24 Thread Jiufu Guo
Richard Biener writes: > On Thu, 23 May 2019, Jiufu Guo wrote: > >> Richard Biener writes: >> >> > On Thu, 23 May 2019, Jiufu Guo wrote: >> > >> >> Hi, >> >> >> >> Richard Biener writes: >> >> >> >> > On Tue, 21 May 2019, Jiufu Guo wrote: >> >> > >> >> >> Hi, >> >> >> >> >> >> This patch im

Re: [PATCH] Commonize anon-name generation

2019-05-24 Thread Jason Merrill
On Fri, May 24, 2019 at 10:34 AM Nathan Sidwell wrote: > > Currently gcc/tree.c exports an anonymous name format string, and a > predicate to detect identifiers of that form. The C++ and D FEs use > those functions to create and check anonymous names. > > That seems a little duplicative. This pa

Re: [C++ PATCH] PR c++/86485 - -Wmaybe-unused with empty class ?:

2019-05-24 Thread Jason Merrill
On Fri, May 24, 2019 at 10:13 AM Jakub Jelinek wrote: > On Wed, May 22, 2019 at 05:59:56PM -0400, Jason Merrill wrote: > > On Tue, May 7, 2019 at 4:43 PM Jason Merrill wrote: > > > > > > * typeck.c (build_static_cast_1): Use cp_build_addr_expr. > > > > > > For GCC 9 I fixed this bug with

[PATCH] Commonize anon-name generation

2019-05-24 Thread Nathan Sidwell
Currently gcc/tree.c exports an anonymous name format string, and a predicate to detect identifiers of that form. The C++ and D FEs use those functions to create and check anonymous names. That seems a little duplicative. This patch changes tree.c to export an anonymous name generator, and u

Re: [PATCH] aarch64: emit .variant_pcs for aarch64_vector_pcs symbol references

2019-05-24 Thread Richard Sandiford
Szabolcs Nagy writes: > A dynamic linker with lazy binding support may need to handle variant > PCS function symbols specially, so an ELF symbol table marking was > introduced for such symbols. > > Global symbol references and definitions that follow the vector PCS are > marked in the generated as

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-24 Thread Steve Kargl
On Fri, May 24, 2019 at 12:33:51PM +0200, Jakub Jelinek wrote: > On Fri, May 24, 2019 at 11:28:34AM +0100, Mark Eggleston wrote: > > > FAIL: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for > > > errors, line 33) > > > PASS: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for ex

Re: [C++ PATCH] PR c++/86485 - -Wmaybe-unused with empty class ?:

2019-05-24 Thread Jakub Jelinek
On Wed, May 22, 2019 at 05:59:56PM -0400, Jason Merrill wrote: > On Tue, May 7, 2019 at 4:43 PM Jason Merrill wrote: > > > > * typeck.c (build_static_cast_1): Use cp_build_addr_expr. > > > > For GCC 9 I fixed this bug with a patch to gimplify_cond_expr, but this > > function was also doing

Re: [PATCH] rs6000: Call flow implementation for PC-relative addressing

2019-05-24 Thread Bill Schmidt
New test case ICEs, so consider this withdrawn.  Sorry again about this. Bill On 5/23/19 9:17 PM, Bill Schmidt wrote: > Hm, I got ahead of myself on this one.  I haven't done the regstrap yet, > so please hold off reviewing for now. > > Sorry for the noise.  I shouldn't post when I'm tired... > >

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-05-24 Thread Jan Hubicka
> I don't think it works like this, peeling arrays/vectors from > types individually instead of in lock-step? > > I think for better testing coverage you want to force > TYPE_STRUCTURAL_EQUALITY on all types here - this shouldn't > make things invalid but otherwise these code-paths are not > teste

Re: [Patch] [aarch64] Change two function declaration types

2019-05-24 Thread Richard Sandiford
Matthew Malcomson writes: > Commit r271514 missed changing the type of two functions in > aarch64-protos.h. The function definitions had been updated to use > uint64_t while the function declarations had been missed. > They were missed since I only tested the patch on aarch64 where > `unsigned lo

Re: [PATCH,RFC 0/3] Support for CTF in GCC

2019-05-24 Thread Jakub Jelinek
On Fri, May 24, 2019 at 03:24:34PM +0200, Jakub Jelinek wrote: > On Tue, May 21, 2019 at 03:44:47PM -0700, Indu Bhagat wrote: > > Yes and No :) And that is indeed one of the motivation of the project - to > > allow CTF generation where it's most suited aka the toolchain. > > > > There do exist uti

Re: [PATCH,RFC 0/3] Support for CTF in GCC

2019-05-24 Thread Jakub Jelinek
On Tue, May 21, 2019 at 03:44:47PM -0700, Indu Bhagat wrote: > Yes and No :) And that is indeed one of the motivation of the project - to > allow CTF generation where it's most suited aka the toolchain. > > There do exist utilties for generation of CTF from DWARF. For example, one of > them is the

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-05-24 Thread Jan Hubicka
> > so about 5 times increase of alias_components_refs_p disambiguations. > > Note the number of queries also changes so it's "somewhat" comparing > apples and oranges (possibly the alias walk doesn't have to give up > and thus we walk more and do more queries). Yep, I know. If you disambiguate y

Re: [PATCH,RFC 0/3] Support for CTF in GCC

2019-05-24 Thread Michael Matz
Hello, On Thu, 23 May 2019, Indu Bhagat wrote: > > OK. So I wonder how difficult it is to emit CTF by walking dwarf2outs own > > data structures? That is, in my view CTF should be emitted by > > dwarf2out_early_finish () (which is also the point LTO type/decl debug > > is generated from). It

Re: [PATCH] LWG 2996 add rvalue overloads for shared_ptr aliasing and casting

2019-05-24 Thread Jonathan Wakely
On 24/05/19 11:39 +0100, Jonathan Wakely wrote: On 24/05/19 11:02 +0200, Christophe Lyon wrote: Hi Jonathan, On Thu, 23 May 2019 at 23:40, Jonathan Wakely wrote: * doc/xml/manual/intro.xml: Document LWG DR 2996 change. * doc/html/*: Regenerate. * include/bits/shared_ptr.

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-05-24 Thread Richard Biener
On Fri, 24 May 2019, Jan Hubicka wrote: > Hi, > this patch implements basic structura compare so same_type_for_tbaa does > not return -1 for all arrays, vectors and pointers with LTO. > The current TBAA stats for tramp3d are: > > Alias oracle query stats: > refs_may_alias_p: 3016393 disambiguat

[PATCH] PR c/17896 Check for missplaced bitwise op

2019-05-24 Thread Rafael Tsuha
This patch adds a function to warn when there's a bitwise operation between a boolean and any other type. This kind of operation is probably a programmer mistake that may lead to unexpected behavior because possibily the logical operation was intended. The test was adapted from PR c/17896. gcc/c-f

Re: [PATCH] A jump threading opportunity for condition branch

2019-05-24 Thread Richard Biener
On Thu, 23 May 2019, Jiufu Guo wrote: > Richard Biener writes: > > > On Thu, 23 May 2019, Jiufu Guo wrote: > > > >> Hi, > >> > >> Richard Biener writes: > >> > >> > On Tue, 21 May 2019, Jiufu Guo wrote: > >> > > >> >> Hi, > >> >> > >> >> This patch implements a new opportunity of jump thread

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-24 Thread Florian Weimer
* Segher Boessenkool: > On Thu, May 23, 2019 at 10:33:28PM +, Joseph Myers wrote: >> On Tue, 21 May 2019, Segher Boessenkool wrote: >> >> > > I think having author names and email addresses is a basic requirement >> > > of >> > > any reasonable repository conversion >> > >> > Yes, and they

Re: [PATCH] libbacktrace: split test_elf into 32 and 64 bits version

2019-05-24 Thread Ian Lance Taylor
On Fri, May 24, 2019 at 7:37 AM Tom de Vries wrote: > > On 24-05-19 13:10, CHIGOT, CLEMENT wrote: > > Description: > > * This patch splits libbacktrace's test_elf into two new tests: > > test_elf_32 and test_elf_64. > > > > Tests: > > * AIX 7.2: Configure/Build: SUCCESS > > > > Changelog: > >

Re: [PATCH] libbacktrace: split test_elf into 32 and 64 bits version

2019-05-24 Thread Tom de Vries
On 24-05-19 13:10, CHIGOT, CLEMENT wrote: > Description: > * This patch splits libbacktrace's test_elf into two new tests: test_elf_32 > and test_elf_64. > > Tests: > * AIX 7.2: Configure/Build: SUCCESS > > Changelog: > * Makefile.am (BUILDTESTS): Remove test_elf, add test_elf_32 a

Re: Fix alias oracle stats

2019-05-24 Thread Jan Hubicka
> Hi honza, > > On 20 May 2019 11:38:14 CEST, Richard Biener wrote: > >On Mon, 20 May 2019, Jan Hubicka wrote: > > > >> Hi, > >> at the moment the alias stats outputs mostly 0 for res_may_alias_p > >> (which is supposed to be main entry point to the alias oracle). > >> I think this is because of

Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-05-24 Thread Jan Hubicka
Hi, this patch implements basic structura compare so same_type_for_tbaa does not return -1 for all arrays, vectors and pointers with LTO. The current TBAA stats for tramp3d are: Alias oracle query stats: refs_may_alias_p: 3016393 disambiguations, 3316783 queries ref_maybe_used_by_call_p: 7112

[committed, amdgcn] Fix stack initialization bug

2019-05-24 Thread Andrew Stubbs
This patch fixes a 64-bit arithmetic bug in which the wrong instruction was used for the lo-part resulting in an incorrect calculation for the hi-part (signed vs. unsigned add). This causes a Memory Access Fault whenever the launcher happens to choose a problematic address for the stack allocat

[PATCH] libbacktrace: split test_elf into 32 and 64 bits version

2019-05-24 Thread CHIGOT, CLEMENT
Description: * This patch splits libbacktrace's test_elf into two new tests: test_elf_32 and test_elf_64. Tests: * AIX 7.2: Configure/Build: SUCCESS Changelog: * Makefile.am (BUILDTESTS): Remove test_elf, add test_elf_32 and test_elf_64. * Makefile.in: Regenerate. Index: libb

Re: [PATCH] LWG 2996 add rvalue overloads for shared_ptr aliasing and casting

2019-05-24 Thread Jonathan Wakely
On 24/05/19 11:02 +0200, Christophe Lyon wrote: Hi Jonathan, On Thu, 23 May 2019 at 23:40, Jonathan Wakely wrote: * doc/xml/manual/intro.xml: Document LWG DR 2996 change. * doc/html/*: Regenerate. * include/bits/shared_ptr.h (shared_ptr(shared_ptr&&, T*)): Add

Re: [Patch] [aarch64] Change two function declaration types

2019-05-24 Thread Richard Earnshaw (lists)
On 24/05/2019 11:28, Matthew Malcomson wrote: > Commit r271514 missed changing the type of two functions in > aarch64-protos.h. The function definitions had been updated to use > uint64_t while the function declarations had been missed. > They were missed since I only tested the patch on aarch64 w

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-24 Thread Jakub Jelinek
On Fri, May 24, 2019 at 11:28:34AM +0100, Mark Eggleston wrote: > > FAIL: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for > > errors, line 33) > > PASS: gfortran.dg/fmt_f_default_field_width_3.f90 -O (test for excess > > errors) > > > > that is, it seems there's no error message g

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-24 Thread Mark Eggleston
On 24/05/2019 10:06, Christophe Lyon wrote: On Thu, 23 May 2019 at 19:21, Steve Kargl wrote: On Thu, May 23, 2019 at 05:26:53PM +0200, Christophe Lyon wrote: On Thu, 23 May 2019 at 15:54, Mark Eggleston wrote: The logs contain: /gcc/testsuite/gfortran.dg/fmt_f_default_field_width_1.f90:15:11

[Patch] [aarch64] Change two function declaration types

2019-05-24 Thread Matthew Malcomson
Commit r271514 missed changing the type of two functions in aarch64-protos.h. The function definitions had been updated to use uint64_t while the function declarations had been missed. They were missed since I only tested the patch on aarch64 where `unsigned long` is the same as `uint64_t`. This

Re: [PATCH] Make any_cast compare typeinfo as well as function pointers

2019-05-24 Thread Jonathan Wakely
On 24/05/19 10:57 +0200, Christophe Lyon wrote: Hi Jonathan, On Thu, 23 May 2019 at 16:13, Jonathan Wakely wrote: It's possible for the function pointer comparison to fail even though the type is correct, because the function could be defined multiple times with different addresses when share

Re: Patch ping (Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass)

2019-05-24 Thread Richard Biener
On Fri, 24 May 2019, Jakub Jelinek wrote: > On Fri, May 17, 2019 at 12:04:16AM +0200, Jakub Jelinek wrote: > > On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > > > One possibility is to add -fdump-tree-optimized and scan for > > > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\)

Patch ping (Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass)

2019-05-24 Thread Jakub Jelinek
On Fri, May 17, 2019 at 12:04:16AM +0200, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > > One possibility is to add -fdump-tree-optimized and scan for > > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" > > "optimized" } } */ > > re

Re: libbacktrace tests for AIX

2019-05-24 Thread Tom de Vries
[ Add CC gcc-patches ] On 23-05-19 15:22, CHIGOT, CLEMENT wrote: > Hi Ian, Tom,  > > I've some problems with gccgo and libbacktrace so I've tried to run > libbacktrace tests on AIX, to see if everything looks good.  > However, I can't build them...  > > Looking at the code, test_elf is trying to

Re: [PATCH] Handle loop fields in IPA ICF (PR ipa/90555).

2019-05-24 Thread Richard Biener
On Fri, May 24, 2019 at 10:08 AM Jakub Jelinek wrote: > > On Fri, May 24, 2019 at 09:48:03AM +0200, Martin Liška wrote: > > gcc/ChangeLog: > > > > 2019-05-23 Martin Liska > > > > PR ipa/90555 > > * ipa-icf-gimple.c (func_checker::compare_loops): New function. > > * ipa-icf-gim

Re: [PATCH] Add LABEL_REF_P to rtl.h

2019-05-24 Thread Richard Biener
On Thu, May 23, 2019 at 10:59 PM Bill Schmidt wrote: > > Hi, > > This patch just adds a convenience macro to be used in subsequent patches. > > Bootstrapped successfully on powerpc64le-unknown-linux-gnu. Okay for trunk? OK. > Thanks, > Bill > > > 2019-05-23 Michael Meissner > > * rtl

Re: [PATCH,RFC 0/3] Support for CTF in GCC

2019-05-24 Thread Richard Biener
On Thu, May 23, 2019 at 10:31 PM Indu Bhagat wrote: > > > > On 05/22/2019 02:04 AM, Richard Biener wrote: > > The CTF debug information is kept in a CTF container distinct from the > frontend > structures. HashMaps are used to avoid generation of duplicate CTF and to > book-keep the generated CT

[PATCH V2] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-05-24 Thread Feng Xue OS
This version is based on the proposal of Richard. And fix a bug on OpenACC loop when this opt is turned on. Also add some test cases Feng - diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9f0f889..d1c1e3a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,16 @@ +2019-05-23 Feng Xue

Re: *ping* Re: [PATCH] PR fortran/89100 Default widths for i, f and g format specifiers in format strings

2019-05-24 Thread Christophe Lyon
On Thu, 23 May 2019 at 19:21, Steve Kargl wrote: > > On Thu, May 23, 2019 at 05:26:53PM +0200, Christophe Lyon wrote: > > On Thu, 23 May 2019 at 15:54, Mark Eggleston > > wrote: > > > > > > > > The logs contain: > > > > /gcc/testsuite/gfortran.dg/fmt_f_default_field_width_1.f90:15:11: > > > > Err

[committed] Fix libgomp hsa plugin build on x32 (PR libgomp/90585)

2019-05-24 Thread Jakub Jelinek
Hi! The hsa plugin assumes that %lu can be used for uint64_t, which is not always the case. Other spots in libgomp use inttypes.h only conditionally and have fallbacks with casts to unsigned long and using %lu, this patch does the same. Furthermore, libgomp configury prepares gstdint.h which inclu

Re: [PATCH] LWG 2996 add rvalue overloads for shared_ptr aliasing and casting

2019-05-24 Thread Christophe Lyon
Hi Jonathan, On Thu, 23 May 2019 at 23:40, Jonathan Wakely wrote: > > * doc/xml/manual/intro.xml: Document LWG DR 2996 change. > * doc/html/*: Regenerate. > * include/bits/shared_ptr.h (shared_ptr(shared_ptr&&, T*)): Add > rvalue aliasing constructor. > (st

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-24 Thread Segher Boessenkool
On Thu, May 23, 2019 at 10:33:28PM +, Joseph Myers wrote: > On Tue, 21 May 2019, Segher Boessenkool wrote: > > > > I think having author names and email addresses is a basic requirement of > > > any reasonable repository conversion > > > > Yes, and they should be the same as they were in the

Re: [PATCH] Make any_cast compare typeinfo as well as function pointers

2019-05-24 Thread Christophe Lyon
Hi Jonathan, On Thu, 23 May 2019 at 16:13, Jonathan Wakely wrote: > > It's possible for the function pointer comparison to fail even though > the type is correct, because the function could be defined multiple > times with different addresses when shared libraries are in use. > > Retain the funct

[PATCH] Fix PR90607

2019-05-24 Thread Richard Biener
I failed to notice gcc.dg/pr53265.c FAIL after the loop distribution change. The following amends the testcase with the new expected diagnostic and adjusts loop distribution to assign a more sensible location to generated library calls. Bootstrap / regtest in progress on x86_64-unknwon-linux-gn

Re: [PATCH} rs6000: Enable PC-relative by default and test

2019-05-24 Thread Segher Boessenkool
Hi, On Thu, May 23, 2019 at 04:15:26PM -0500, Bill Schmidt wrote: > This is a short patch that enables PC-relative support by default, and > provides a > test case to ensure that the correct .localentry name,1 directive is produced > iff > PC-relative support is enabled. > 2019-05-23 Bill Schm

[C++ PATCH] Fix decltype on a trivial dtor with -flifetime-dse (PR c++/90598)

2019-05-24 Thread Jakub Jelinek
Hi! The following testcase is rejected, because we determine B as void & rather than the expected void when -flifetime-dse. I'd say the main problem is premature folding, that we lower the trivial destructor already at parsing time, rather than cp_fold, I'd say that goes against the intentions of

Re: [PATCH] Handle loop fields in IPA ICF (PR ipa/90555).

2019-05-24 Thread Jakub Jelinek
On Fri, May 24, 2019 at 09:48:03AM +0200, Martin Liška wrote: > gcc/ChangeLog: > > 2019-05-23 Martin Liska > > PR ipa/90555 > * ipa-icf-gimple.c (func_checker::compare_loops): New function. > * ipa-icf-gimple.h (func_checker::compare_loops): Likewise. > * ipa-icf.c (sem

Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-24 Thread Richard Biener
On Thu, 23 May 2019, Alex Henrie wrote: > --- > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86407#c6 > --- > gcc/c-family/c.opt | 4 > gcc/c/c-decl.c | 4 +++- > gcc/config/i386/i386-options.c | 12 ++-- > gcc/testsuite/c-c++-com

Re: [PATCH] Move VEC_PERM_EXPR folding to match.pd

2019-05-24 Thread Richard Biener
On Fri, 24 May 2019, Bernhard Reutner-Fischer wrote: > On 20 May 2019 12:31:46 CEST, Richard Biener wrote: > > > > >So the following is what I have applied. > > Typo in the guard? > > s/GCC_VEC_PERN_INDICES_H/GCC_VEC_PERM_INDICES_H/ > > ? Yeah, but copied that from vec-perm-indices.h ... (ot

Re: Add GCC support to ENQCMD.

2019-05-24 Thread Uros Bizjak
On Fri, May 24, 2019 at 9:43 AM Uros Bizjak wrote: > > On Fri, May 24, 2019 at 7:16 AM Hongtao Liu wrote: > > > > Hi Uros and all: > > This patch is about to enable support for ENQCMD(Enqueue Command) > > which will be in Willow Cove. > > There are two instructions for ENQCMD: ENQCMD and ENQC

[PATCH] Handle loop fields in IPA ICF (PR ipa/90555).

2019-05-24 Thread Martin Liška
Hi. The patch is about more fine comparison of loop fields that are mentioned in the PR. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-05-23 Martin Liska PR ipa/90555 * ipa-icf-gimple.c (func

[PATCH, x86, testsuite] Two tests that need to be native TLS?

2019-05-24 Thread Iain Sandoe
Hi Uros, The following two tests fail on Darwin, which is an emulated TLS target. ISTM that the tests really required native support, so that the right fix is to require that. (I can skip them for Darwin, if this isn’t the right solution). OK? thanks Iain gcc/testsuite/ * gcc.target/i

Re: Add GCC support to ENQCMD.

2019-05-24 Thread Uros Bizjak
On Fri, May 24, 2019 at 7:16 AM Hongtao Liu wrote: > > Hi Uros and all: > This patch is about to enable support for ENQCMD(Enqueue Command) > which will be in Willow Cove. > There are two instructions for ENQCMD: ENQCMD and ENQCMDS. More > details please refer to > https://software.intel.com/s

Re: GCC 9 backports

2019-05-24 Thread Martin Liška
Hi. I'm sending one more patch that I've tested. Martin >From 279c24c2af259c8f3e7668056fcb707bc3c03ad2 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 23 May 2019 10:12:01 + Subject: [PATCH] Backport r271548 gcc/ChangeLog: 2019-05-23 Martin Liska PR sanitizer/90570 * gimplify.c (gim

Re: GCC 8 backports

2019-05-24 Thread Martin Liška
Hi. I'm sending one more patch that I've tested. Martin >From 3a0412967ede61515ce59230580558f5531e63f6 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 23 May 2019 10:12:01 + Subject: [PATCH] Backport r271548 gcc/ChangeLog: 2019-05-23 Martin Liska PR sanitizer/90570 * gimplify.c (gim

[PATCH, Darwin, x86, testsuite] Make match strings more specific.

2019-05-24 Thread Iain Sandoe
Some of the i386.exp tests fail on Darwin (and at least one passes incorrectly on Linux) because their scan-asm match strings are too general. In some cases the strings also match instances in the .file and size directives or in comment output. This patch makes the match strings more specific. t

Re: [PATCH, Darwin, x86, testsuite] Disable tests that cannot pass for Darwin.

2019-05-24 Thread Iain Sandoe
> On 24 May 2019, at 08:29, Iain Sandoe wrote: > > A few of the i386.exp target tests cannot pass on Darwin > because either the port doesn't support a feature, or the > ABI demands sufficiently different codegen that matching > the output with scan-asms would require a different test. > > Dis

[PATCH, Darwin, x86, testsuite] Adjust test labels for Darwin.

2019-05-24 Thread Iain Sandoe
A couple of the i386.exp tests fail because the label spelling used is different between ELF and Mach-O targets. Adjusted here. tested on x86_64-darwin and x86_64-linux (--target_board=unix\{-m32,-m64\}\{,-fpic\}) Applied as obvious to mainline, Iain 2019-05-24 Iain Sandoe * gcc.targ

[PATCH, Darwin, x86, testsuite] Disable tests that cannot pass for Darwin.

2019-05-24 Thread Iain Sandoe
A few of the i386.exp target tests cannot pass on Darwin because either the port doesn't support a feature, or the ABI demands sufficiently different codegen that matching the output with scan-asms would require a different test. Disabling those tests here. tested on x86_64-darwin and x86_64-linu

Re: Fixed: "required ftruncate or chsize support not present" in gfortran testsuite

2019-05-24 Thread Hans-Peter Nilsson
> From: Janne Blomqvist > Date: Thu, 23 May 2019 23:43:23 +0300 > On Thu, May 23, 2019 at 5:21 AM Hans-Peter Nilsson > wrote: > > > > There was a regression for gfortran.dg/fmt_en.f90 for cris-elf > > that on inspection was due to it having acquired a truncation > > call through the runtime. I