[PATCH] asan_test.C: disable -Wstringop-overflow, PR/93058

2020-01-23 Thread slyfox.inbox.ru via gcc-patches
From: Sergei Trofimovich From: Sergei Trofimovich asan's test allocates 2 pages via pvalloc(kPageSize + 100) and makes sure dereference of 'kPageSize + 101' does not trigger asan checks. glibc's and gcc's malloc-like attribute checkers trigger a warning: asan_test.cc:129:22: error:

Re: [PATCH] i386: prefer vpermilpd over vpermpd [PR93395]

2020-01-23 Thread Uros Bizjak
On Thu, Jan 23, 2020 at 10:48 PM Jakub Jelinek wrote: > > Hi! > > In Agner Fog's tables, vpermilp[sd] with immediates seem to be > much faster than vpermpd with immediate, for a good reason, > the former only permute something within the lanes and don't do anything > intra-lane, while vpermpd

Re: [PR47785] COLLECT_AS_OPTIONS

2020-01-23 Thread Prathamesh Kulkarni
On Mon, 20 Jan 2020 at 15:44, Richard Biener wrote: > > On Wed, Jan 8, 2020 at 11:20 AM Prathamesh Kulkarni > wrote: > > > > On Tue, 5 Nov 2019 at 17:38, Richard Biener > > wrote: > > > > > > On Tue, Nov 5, 2019 at 12:17 AM Kugan Vivekanandarajah > > > wrote: > > > > > > > > Hi, > > > >

[PATCH] Suppress deprecation warnings in tbb effective target check

2020-01-23 Thread Thomas Rodgers
From cfd3c2e2a49dd3e29b42baa0f22feffd4b346231 Mon Sep 17 00:00:00 2001 From: Thomas Rodgers Date: Thu, 23 Jan 2020 21:54:44 -0800 Subject: [PATCH] Suppress deprecation warnings in tbb effective target check TBB 2020 added deprecation warnings which produced output not expected by

[committed] analyzer: avoid relying on system in testsuite (PR 93367)

2020-01-23 Thread David Malcolm
PR analyzer/93367 reports a testsuite failure in abort.c on hppa64-hp-hpux11.11 when detecting if the analyzer "knows" that the condition holds after the assert. The root cause is that the assertion failure function in that configuration's is not marked with __attribute__ ((__noreturn__)). This

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

2020-01-23 Thread Jan Hubicka
Hi, it seems that there is additional bug in merging which caused the extra 0 counts. The attached patch imprves the stats on gcc dir of profiledbootstrap: stats for indirect_call: total: 9876 invalid: 705 tracked values: 0 values: 7189 times (72.79%) 1 values: 1890 times

Re: libgo patch committed: Update to Go1.14beta1

2020-01-23 Thread Ian Lance Taylor
On Thu, Jan 23, 2020 at 11:32 AM Maciej W. Rozycki wrote: > > On Tue, 21 Jan 2020, Ian Lance Taylor wrote: > > > I've committed a patch to update libgo to Go 1.14beta1. As usual with > > these updates the patch is far too large to include in this e-mail > > message. I've included the diffs for

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-01-23 Thread Alexandre Oliva
On Jan 22, 2020, Richard Biener wrote: > I think it's fine to make that change now. FTR, the combined patch, to be installed in GCC 11, is commit f798a915a2a00ff7921644d0e08cb88e7db581a2, in refs/users/aoliva/heads/aux-dump-revamp I'm not reposting the monster patch right now. -- Alexandre

Re: [patch, testsuite] Add -fdelete-null-pointer-checks to some C++ testcases

2020-01-23 Thread Jeff Law
On Thu, 2020-01-23 at 14:59 -0700, Sandra Loosemore wrote: > On 1/23/20 1:17 PM, Jeff Law wrote: > > On Tue, 2020-01-21 at 15:00 -0700, Sandra Loosemore wrote: > > > In doing some nios2-elf testing, I ran into a bunch of failures in > > > constexpr-related tests in the C++ testsuite. This target

Re: [PATCH] doc: clarify the situation with pointer arithmetic

2020-01-23 Thread Uecker, Martin
Am Donnerstag, den 23.01.2020, 14:18 +0100 schrieb Richard Biener: > On Wed, Jan 22, 2020 at 12:40 PM Martin Sebor wrote: > > > > On 1/22/20 8:32 AM, Richard Biener wrote: > > > On Tue, 21 Jan 2020, Alexander Monakov wrote: > > > > > > > On Tue, 21 Jan 2020, Richard Biener wrote: > > > > > > >

[committed] [PR translation/90162] Fix diagnostic to better follow guidelines

2020-01-23 Thread Jeff Law
Not a regression, but only affects a diagnostic on the H8 port. As pointed out in the BZ, we should not be emitting an exclamation point in the diagnostic and the capitalization was incorrect. Fixed by the attached patch which I've committed to the trunk. Jeff commit

[committed] [PR target/92269] Fix label for profiling on H8

2020-01-23 Thread Jeff Law
As mentioned in the PR, there's a bug in the H8 profiling support which results in the wrong label name being emitted. Specifically the label is missing a ".". While we're in stage4, this affects just the H8 and only when profiling is enabled, so I went ahead and committed the fix to the

[COMMITTED] libstdc++: Simplify makefile rule for largefile-config.h (PR91947)

2020-01-23 Thread Jonathan Wakely
The previous rule could leave an incomplete file if the build was interrupted, which would then not be remade if make was run again. This makes the rule more robust by writing to a temporary file and only moving it into place as the final step. It also simplifies the rule so that only the

[PATCH] libstdc++: Fix conformance issues in (PR92895)

2020-01-23 Thread Jonathan Wakely
Fix synchronization issues in . Replace shared_ptr with _Stop_state_ref and a reference count embedded in the shared state. Replace std::mutex with spinlock using one bit of a std::atomic<> that also tracks whether a stop request has been made and how many stop_source objects share ownership of

[PATCH] analyzer: fix setjmp-detection and support sigsetjmp

2020-01-23 Thread David Malcolm
On Wed, 2020-01-22 at 20:40 +0100, Jakub Jelinek wrote: > On Wed, Jan 22, 2020 at 02:35:13PM -0500, David Malcolm wrote: > > PR analyzer/93316 reports various testsuite failures where I > > accidentally relied on properties of x86_64-pc-linux-gnu. > > > > The following patch fixes them on

[PATCH] analyzer: fixes to tree_cmp and other comparators

2020-01-23 Thread David Malcolm
On Thu, 2020-01-23 at 18:46 +0300, Alexander Monakov wrote: > On Thu, 23 Jan 2020, David Malcolm wrote: > > > Removing the assertions fixes it for me (a stage1 build, at least, > > and > > it then passes the testsuite). > > > > I've made this blunder in four places in the analyzer: > > > >

[PATCH] diagnostics: Support conversion of tabs to spaces [PR86904]

2020-01-23 Thread Lewis Hyatt
Hello- In the discussion of r279137, which makes diagnostic-show-locus.c aware that characters may take up more than one display column, David suggested that I also look at handling tabs there (expanding into the correct number of spaces): https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00625.html.

Re: [patch, testsuite] Add -fdelete-null-pointer-checks to some C++ testcases

2020-01-23 Thread Sandra Loosemore
On 1/23/20 1:17 PM, Jeff Law wrote: On Tue, 2020-01-21 at 15:00 -0700, Sandra Loosemore wrote: In doing some nios2-elf testing, I ran into a bunch of failures in constexpr-related tests in the C++ testsuite. This target defaults to -fno-delete-null-pointer-checks at the request of

[committed] testsuite: Require lp64 target rather x86_64-*-* in pr93027.c. [PR93027]

2020-01-23 Thread Jakub Jelinek
Hi! I've noticed this test failed on x86_64-linux with -m32 or -mx32 testing, the triplet doesn't really say which actual multilib it is, and the test really works with lp64. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2020-01-23 Jakub

[PATCH] i386: prefer vpermilpd over vpermpd [PR93395]

2020-01-23 Thread Jakub Jelinek
Hi! In Agner Fog's tables, vpermilp[sd] with immediates seem to be much faster than vpermpd with immediate, for a good reason, the former only permute something within the lanes and don't do anything intra-lane, while vpermpd can. So, functionality-wise, vpermilpd is more efficient subset of

[wwwdocs] Fix markup of (to ).

2020-01-23 Thread Gerald Pfeifer
A small fix on top of the last edits to gitwrite.html; spelling "<" and ">" the HTML way is painful, and visually hard to grok. Pushed. Gerald --- htdocs/gitwrite.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/gitwrite.html b/htdocs/gitwrite.html index

[wwwdocs] Abstract away verbal references to SVN in the GOMP project description.

2020-01-23 Thread Gerald Pfeifer
Technically not necessary, but while I was at it this simplified things (and there were no similarly many references anywhere else). Pushed. Gerald --- htdocs/projects/gomp/index.html | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2020 at 09:19:52PM +0100, Rainer Orth wrote: > Unlikely: there's barely any development on the Solaris assemblers these > days, though I prefer to xfail tests if possible to get notified if they > suddenly start to work for some reason. Ok. Jakub

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-23 Thread Rainer Orth
Hi Jakub, > On Thu, Jan 23, 2020 at 09:12:27PM +0100, Rainer Orth wrote: >> +FAIL: gcc.target/i386/pr91298-2.c (test for excess errors) >> >> It only allows letters, digits, '_' and '.' in identifiers: >> https://docs.oracle.com/cd/E37838_01/html/E61064/eqbsx.html#XALRMeoqjw > > So, no way to

Re: [patch, testsuite] Add -fdelete-null-pointer-checks to some C++ testcases

2020-01-23 Thread Jeff Law
On Tue, 2020-01-21 at 15:00 -0700, Sandra Loosemore wrote: > In doing some nios2-elf testing, I ran into a bunch of failures in > constexpr-related tests in the C++ testsuite. This target defaults to > -fno-delete-null-pointer-checks at the request of Altera/Intel, in order > to support some

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2020 at 09:12:27PM +0100, Rainer Orth wrote: > +FAIL: gcc.target/i386/pr91298-2.c (test for excess errors) > > It only allows letters, digits, '_' and '.' in identifiers: > https://docs.oracle.com/cd/E37838_01/html/E61064/eqbsx.html#XALRMeoqjw So, no way to emit other letters in

Re: [PATCH] doc: target.def (flags_regnum): Mention effect on delay slot filling.

2020-01-23 Thread Jeff Law
On Thu, 2020-01-23 at 20:38 +0100, Hans-Peter Nilsson wrote: > gcc: > * target.def (flags_regnum): Also mention effect on delay slot filling. > * doc/tm.texi: Regenerate. > > Noticed the "hard way" dealing with performance fallout for the > CRIS decc0ration. > > Previously, the documentation

Re: [PATCH 2/4] [ARC] Propagate uncached type attribute.

2020-01-23 Thread Jeff Law
On Wed, 2020-01-22 at 10:14 +0200, Claudiu Zissulescu wrote: > Like `packed` type attribute, the ARC's `uncached` type attribute > needs to be propagated to each member of the struct where it is used. > Fix this behavior and add a test. > > gcc/ > -xx-xx Claudiu Zissulescu > > *

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-23 Thread Rainer Orth
Hi Jakub, > In AT syntax leading $ is special, so if we have identifiers that start > with dollar, we usually fail to assemble it (or assemble incorrectly). > As mentioned in the PR, what works is wrapping the identifiers inside of > parens, like: > movl$($a), %eax > leaq

Re: [PATCH] libsanitizer: Add missign file and regen Makefile.in

2020-01-23 Thread Jeff Law
On Wed, 2020-01-22 at 22:23 +0100, Andreas Tobler wrote: > Hi all, > > I'm digginig out old patches and I want to complete the libasan support > for FreeBSD x86_64. The below one was not that obvious when you have > been away for the past years. > > In the last import the

Re: libgo patch committed: Update to Go1.14beta1

2020-01-23 Thread Rainer Orth
Hi Ian, > On Wed, Jan 22, 2020 at 12:18 PM Rainer Orth > wrote: >> >> > I've committed a patch to update libgo to Go 1.14beta1. As usual with >> > these updates the patch is far too large to include in this e-mail >> > message. I've included the diffs for gccgo-specific files. >> >

Re: [PATCH] cprop: Don't replace fixed hard regs with pseudos [PR93124]

2020-01-23 Thread Jeff Law
On Thu, 2020-01-23 at 11:43 +, Richard Sandiford wrote: > Jeff Law writes: > > On Wed, 2020-01-22 at 12:02 +, Richard Sandiford wrote: > > > One consequence of r276318 was that cselib now preserves sp-based > > > values across function calls. This in turn convinced cprop to > > > replace

Re: [PATCH] Do not print params in --help except --help=param.

2020-01-23 Thread Jeff Law
On Thu, 2020-01-23 at 15:26 +0100, Martin Liška wrote: > Hi. > > The patch finishes stripping of params in --help dump > for e.g. --help=joined or --help=separate. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > >

Re: [PATCH] Filter out language specific options from --help=common.

2020-01-23 Thread Jeff Law
On Thu, 2020-01-23 at 15:28 +0100, Martin Liška wrote: > Hi. > > The following is attempt to fix the PR. Idea is such that > all non-driver Common options that are also used in context > of a languages should not be printed in --help=common. An > exception would be an option that will be included

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-01-23 Thread Alexandre Oliva
On Jan 22, 2020, Richard Biener wrote: >> I suppose I might go ahead and install the libiberty follow-up patch >> approved by Joseph, and squash the lto-wrapper portion into the larger >> patch. Please let me know in case you think the libiberty change to >> preserve empty arguments should also

Re: tolerate padding in mbstate_t

2020-01-23 Thread Alexandre Oliva
On Jan 22, 2020, Jonathan Wakely wrote: >>> I don't think so, that wouldn't work. I think pos02 could just be >>> removed from the test. >> Will do. > Thanks, OK to commit. Thanks, here's what I tested and am about to install. tolerate padding in mbstate_t From: Alexandre Oliva Padding

Re: Define HAVE_ for math long double functions declared in vxworks headers

2020-01-23 Thread Alexandre Oliva
On Jan 23, 2020, Jonathan Wakely wrote: > On 23/01/20 00:20 -0300, Alexandre Oliva wrote: >> On Jan 22, 2020, Jonathan Wakely wrote: >> >>> Isn't allowing arithmetic on function pointers a GNU extension? >> >> Does that matter? This test is only supposed to be compiled by GCC. > Maybe if

[PATCH] doc: target.def (flags_regnum): Mention effect on delay slot filling.

2020-01-23 Thread Hans-Peter Nilsson
gcc: * target.def (flags_regnum): Also mention effect on delay slot filling. * doc/tm.texi: Regenerate. Noticed the "hard way" dealing with performance fallout for the CRIS decc0ration. Previously, the documentation blurb only mentioned an effect on compare elimination. The technical contents

Re: libgo patch committed: Update to Go1.14beta1

2020-01-23 Thread Maciej W. Rozycki
On Tue, 21 Jan 2020, Ian Lance Taylor wrote: > I've committed a patch to update libgo to Go 1.14beta1. As usual with > these updates the patch is far too large to include in this e-mail > message. I've included the diffs for gccgo-specific files. It seems to have broken the

Re: [PATCH] postreload: Fix up postreload combine [PR93402]

2020-01-23 Thread Jeff Law
On Thu, 2020-01-23 at 20:05 +0100, Richard Biener wrote: > On January 23, 2020 7:22:02 PM GMT+01:00, Jakub Jelinek > wrote: > > Hi! > > > > The following testcase is miscompiled, because the postreload pass > > changes: > > -(insn 14 13 23 2 (parallel [ > > -(set (reg:DI 1 dx [94])

Re: [C++ Patch] PR 92804 [10 Regression] ICE trying to use concept as a nested-name-specifier

2020-01-23 Thread Jason Merrill
On 1/23/20 4:31 AM, Paolo Carlini wrote: Hi, On 22/01/20 22:32, Jason Merrill wrote: On 1/22/20 3:31 PM, Paolo Carlini wrote: Hi, On 22/01/20 17:27, Jason Merrill wrote: On 1/22/20 10:22 AM, Paolo Carlini wrote: Hi, in this simple issue we either wrongly talked about variable template-id

[PATCH] simplify-rtx: Punt for modes with precision above MAX_BITSIZE_MODE_ANY_INT [PR93376]

2020-01-23 Thread Jakub Jelinek
Hi! The following patch makes sure we punt in the 3 spots if precision is above MAX_BITSIZE_MODE_ANY_INT. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-01-23 Jakub Jelinek PR target/93376 * simplify-rtx.c (simplify_const_unary_operation,

Re: [PATCH] postreload: Fix up postreload combine [PR93402]

2020-01-23 Thread Richard Biener
On January 23, 2020 7:22:02 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The following testcase is miscompiled, because the postreload pass >changes: >-(insn 14 13 23 2 (parallel [ >-(set (reg:DI 1 dx [94]) >-(plus:DI (reg:DI 1 dx [95]) >-(reg:DI 5

[PATCH] postreload: Fix up postreload combine [PR93402]

2020-01-23 Thread Jakub Jelinek
Hi! The following testcase is miscompiled, because the postreload pass changes: -(insn 14 13 23 2 (parallel [ -(set (reg:DI 1 dx [94]) -(plus:DI (reg:DI 1 dx [95]) -(reg:DI 5 di [92]))) -(clobber (reg:CC 17 flags)) -])

[COMMITTED] c++: Avoid ICE when constexpr __builtin_strchr fails.

2020-01-23 Thread Jason Merrill
If we can't change the argument to &"...", use the original arg instead of the partially munged one. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/93331 - ICE with __builtin_strchr. * constexpr.c (cxx_eval_builtin_function_call): Use the original argument if we

[COMMITTED] c++: Fix ICE with defaulted dtor and template (PR93345)

2020-01-23 Thread Jason Merrill
In a template we don't instantiate a deferred noexcept-spec, and we don't need it because we aren't going to do anything with the value of throwing_cleanup in a template anyway. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/93345 - ICE with defaulted dtor and template. PR

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS env var

2020-01-23 Thread Bernd Edlinger
Hi, I just wanted to ask, if there was any progress on this? Thanks Bernd. On 12/21/19 10:50 AM, Bernd Edlinger wrote: > Hi David, > > thanks for fixing this issue. > > Just one comment: > >> +[DIAGNOSTICS_URLS_DEFAULT=DIAGNOSTICS_URL_AUTO]) >> +AC_DEFINE_UNQUOTED(DIAGNOSTICS_URLS_DEFAULT,

[committed] analyzer: avoid ICE with missing arguments (PR 93375)

2020-01-23 Thread David Malcolm
PR analyzer/93375 reports an ICE under certain circumstances involving a call where the number of arguments at the callsite is less than the parameter count of the callee, Specifically, the ICE occurs when pruning a checker_path for a diagnostic, when attempting to maintain which expression is of

Re: [PATCH] wwwdocs: document scripts to access personal and vendor spaces

2020-01-23 Thread Richard Earnshaw (lists)
On 21/01/2020 18:58, Richard Earnshaw (lists) wrote: This patch documents some of the scripts that I've published for managing the personal and vendor spaces on the server.  It also covers some of the other features that those scripts enable, so that it's all in one place.  This is a complete

Re: [RFC c-common PATCH] PR c++/40752 - useless -Wconversion with short +=.

2020-01-23 Thread Jason Merrill
On 1/22/20 5:58 PM, Jason Merrill wrote: On 1/22/20 1:20 PM, Jason Merrill wrote: On 1/22/20 5:14 AM, Martin Liška wrote: Hi. Just for the record, after the change 526.blender_r fails due to: blender/source/blender/blenlib/intern/math_color.c: In function 'rgb_float_to_uchar':

Re: [PATCH] Fix comparison of trees via tree_cmp

2020-01-23 Thread Alexander Monakov
On Thu, 23 Jan 2020, David Malcolm wrote: > Removing the assertions fixes it for me (a stage1 build, at least, and > it then passes the testsuite). > > I've made this blunder in four places in the analyzer: > > call-string.cc:162: call_string::cmp > program-point.cc:461:

Re: [PATCH][AArch64] ACLE 8-bit integer matrix multiply-accumulate intrinsics

2020-01-23 Thread Richard Sandiford
Dennis Zhang writes: > Hi all, > On 16/12/2019 13:53, Dennis Zhang wrote: >> Hi all, >> >> This patch is part of a series adding support for Armv8.6-A features. >> It depends on the Armv8.6-A effective target checking patch, >> https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00857.html. >> >>

Re: [PATCH] Proposal for IPA init() constant propagation

2020-01-23 Thread Erick Ochoa
Forgot to attach the test cases. On 2020-01-23 10:20 a.m., Erick Ochoa wrote: > Hi Jan, > > Here is a patch I just rebased against > > commit 2589beb1d1a065f75a5515c9e2698de12a421913 (origin/master, origin/HEAD, > master) > Author: GCC Administrator > Date: Sun Jan 19 00:16:30 2020 + >

Re: [PATCH] Proposal for IPA init() constant propagation

2020-01-23 Thread Erick Ochoa
Hi Jan, Here is a patch I just rebased against commit 2589beb1d1a065f75a5515c9e2698de12a421913 (origin/master, origin/HEAD, master) Author: GCC Administrator Date: Sun Jan 19 00:16:30 2020 + I also include some test cases. To run test cases, just set your path for the gcc executable

Re: [PATCH] Fix patchable-function-entry on arc

2020-01-23 Thread Jeff Law
On Wed, 2020-01-22 at 17:25 -0800, apin...@marvell.com wrote: > From: Andrew Pinski > > The problem here is arc looks at current_output_insn unconditional > but sometimes current_output_insn is NULL. With patchable-function-entry, > it will be. This is similar to how the nios2, handles "%.". >

Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.

2020-01-23 Thread Jeff Law
On Thu, 2020-01-23 at 10:58 +, Dragan Mladjenovic wrote: > On 07.12.2019. 19:33, Jeff Law wrote: > > On Thu, 2019-11-07 at 17:05 +, Dragan Mladjenovic wrote: > > > On 01.11.2019. 11:32, Dragan Mladjenovic wrote: > > > > On 10.08.2019. 00:15, Joseph Myers wrote: > > > > > On Fri, 9 Aug

Re: [PATCH] Fix comparison of trees via tree_cmp

2020-01-23 Thread David Malcolm
On Wed, 2020-01-22 at 19:02 +0100, Jakub Jelinek wrote: > On Wed, Jan 22, 2020 at 08:08:32PM +0300, Alexander Monakov wrote: > > > > On Wed, 22 Jan 2020, Stefan Schulze Frielinghaus wrote: > > > > > Hi David, > > > > > > In function `tree_cmp` an invariant [1] is assumed which does not > > >

Re: [PATCH] wide-int: i386: Fix ICEs on TImode signed overflow add/sub patterns [PR93376]

2020-01-23 Thread Uros Bizjak
On Thu, Jan 23, 2020 at 2:17 PM Jakub Jelinek wrote: > > On Thu, Jan 23, 2020 at 10:38:31AM +0100, Uros Bizjak wrote: > > On Thu, Jan 23, 2020 at 10:33 AM Jakub Jelinek wrote: > > > > > > On Thu, Jan 23, 2020 at 09:14:42AM +, Richard Sandiford wrote: > > > > > The other patch is something

Re: [PATCH][AArch64] ACLE 8-bit integer matrix multiply-accumulate intrinsics

2020-01-23 Thread Dennis Zhang
Hi all, On 16/12/2019 13:53, Dennis Zhang wrote: > Hi all, > > This patch is part of a series adding support for Armv8.6-A features. > It depends on the Armv8.6-A effective target checking patch, > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00857.html. > > This patch adds intrinsics for

Re: [PATCH] Add OpenACC 2.6 `acc_get_property' support

2020-01-23 Thread Thomas Schwinge
Hi Frederik! On 2020-01-20T15:01:01+0100, "Harwath, Frederik" wrote: > I have attached a patch containing the changes that you suggested. > On 16.01.20 17:00, Thomas Schwinge wrote: >> On 2019-12-20T17:46:57+0100, "Harwath, Frederik" >> wrote: > Ok to push the commit to master? Thanks, OK.

[PATCH] Filter out language specific options from --help=common.

2020-01-23 Thread Martin Liška
Hi. The following is attempt to fix the PR. Idea is such that all non-driver Common options that are also used in context of a languages should not be printed in --help=common. An exception would be an option that will be included in all languages. Patch can bootstrap on x86_64-linux-gnu and

[PATCH] Do not print params in --help except --help=param.

2020-01-23 Thread Martin Liška
Hi. The patch finishes stripping of params in --help dump for e.g. --help=joined or --help=separate. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2020-01-23 Martin Liska * opts.c (print_help): Exclude

[PATCH] tree-optimization/93397 delay converted reduction chain adjustment

2020-01-23 Thread Richard Biener
The following delays adjusting the SLP graph for converted reduction chains to a point where the SLP build no longer can fail since we otherwise fail to undo marking the conversion as a group. Bootstrap & regtest running on x86_64-unknown-linux-gnu. Richard. 2020-01-23 Richard Biener

[COMMITTED] aarch64: Fix -mtrack-speculation for irreversible conditions [PR93341]

2020-01-23 Thread Richard Sandiford
We can't yet represent the inverse of all conditions in rtl (see g:865257c447cc50f5819e), triggering an ICE in the pass that handles -mtrack-speculation. Since we don't expect these insns to be optimised in any way, the easiest fix seemed to be to add an insn that reverses the condition

Re: [PATCH] Make target_clones resolver fn static.

2020-01-23 Thread Alexander Monakov
On Thu, 23 Jan 2020, Martin Liška wrote: > > So this doesn't help review including two different target changes. Making > > ifunc dispatchers of public functions non-public looks like an unrelated > > thing > > to the bug (sorry if I mis-suggested). So I feel comfortable approving the > >

Re: [PATCH] Proposal for IPA init() constant propagation

2020-01-23 Thread Jan Hubicka
> Hi. > > Thank you for the patch. I'm CCing the author of current IPA CP > and IPA maintainer. OK, happy to be in CC, but I wonder where I find the last version of the patch? https://gcc.gnu.org/bugzilla/attachment.cgi?id=47455 Honza > > Martin

Re: Fix false -Wodr warnings

2020-01-23 Thread Thomas Schwinge
Hi! On 2019-04-15T13:55:39+0200, Richard Biener wrote: > On Sun, Apr 14, 2019 at 10:59 PM Jan Hubicka wrote: >> this patch fixes false warning that is output when different -std >> settings are used. In this case C++ FE produces same declaration in >> different representations which differ by 0

Re: [PATCH] Proposal for IPA init() constant propagation

2020-01-23 Thread Martin Liška
Hi. Thank you for the patch. I'm CCing the author of current IPA CP and IPA maintainer. Martin

Re: [PATCH] Make target_clones resolver fn static.

2020-01-23 Thread Martin Liška
On 1/23/20 2:09 PM, Richard Biener wrote: On Tue, Jan 21, 2020 at 1:48 PM Martin Liška wrote: On 1/20/20 3:52 PM, Richard Biener wrote: On Mon, Jan 20, 2020 at 3:46 PM H.J. Lu wrote: On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov wrote: On Mon, 20 Jan 2020, H.J. Lu wrote: Bare

Re: [PATCH] doc: clarify the situation with pointer arithmetic

2020-01-23 Thread Richard Biener
On Wed, Jan 22, 2020 at 12:40 PM Martin Sebor wrote: > > On 1/22/20 8:32 AM, Richard Biener wrote: > > On Tue, 21 Jan 2020, Alexander Monakov wrote: > > > >> On Tue, 21 Jan 2020, Richard Biener wrote: > >> > >>> Fourth. That PNVI (I assume it's the whole pointer-provenance stuff) > >>> wants to

Re: [PATCH] wide-int: i386: Fix ICEs on TImode signed overflow add/sub patterns [PR93376]

2020-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2020 at 10:38:31AM +0100, Uros Bizjak wrote: > On Thu, Jan 23, 2020 at 10:33 AM Jakub Jelinek wrote: > > > > On Thu, Jan 23, 2020 at 09:14:42AM +, Richard Sandiford wrote: > > > > The other patch is something suggested by Richard S., avoid using OImode > > > > for this and

Re: [PATCH] Make target_clones resolver fn static.

2020-01-23 Thread Richard Biener
On Tue, Jan 21, 2020 at 1:48 PM Martin Liška wrote: > > On 1/20/20 3:52 PM, Richard Biener wrote: > > On Mon, Jan 20, 2020 at 3:46 PM H.J. Lu wrote: > >> > >> On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov > >> wrote: > >>> > >>> > >>> > >>> On Mon, 20 Jan 2020, H.J. Lu wrote: > >>> > >

[committed, libgomp,amdgcn] Fix plugin-gcn.c bug

2020-01-23 Thread Andrew Stubbs
I've committed this patch to fix a bug in the OpenMP argument parsing. It was using a value instead of a mask to read from the arguments. Since the value in question happens to be zero, the comparison would always return true. I've not observed any bad behaviour from this, but in theory it

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

2020-01-23 Thread Martin Liška
On 1/23/20 1:41 PM, Jan Hubicka wrote: So my bet is that before the patch we had a bogus code. We detected invalid stated with hiving first counter value == -1. Which could be also reached with decrement of all values (0 - 1 == -1). Maybe we would be interested in usage of a huge negative

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

2020-01-23 Thread Jan Hubicka
> So my bet is that before the patch we had a bogus code. We detected invalid > stated with hiving first counter value == -1. Which could be also reached > with decrement of all values (0 - 1 == -1). > > Maybe we would be interested in usage of a huge negative number to reflect > invalid state?

Re: Define HAVE_ for math long double functions declared in vxworks headers

2020-01-23 Thread Jonathan Wakely
On 23/01/20 00:20 -0300, Alexandre Oliva wrote: On Jan 22, 2020, Jonathan Wakely wrote: Isn't allowing arithmetic on function pointers a GNU extension? Does that matter? This test is only supposed to be compiled by GCC. Maybe if somebody was crazy enough to build GCC with

Re: [PATCH] cprop: Don't replace fixed hard regs with pseudos [PR93124]

2020-01-23 Thread Richard Sandiford
Jeff Law writes: > On Wed, 2020-01-22 at 12:02 +, Richard Sandiford wrote: >> One consequence of r276318 was that cselib now preserves sp-based >> values across function calls. This in turn convinced cprop to >> replace the clobber in: >> >>(set (reg PSUEDO) (reg sp)) >>... >>

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-23 Thread Nathan Sidwell
On 1/23/20 4:54 AM, Martin Liška wrote: On 1/22/20 9:12 AM, Richard Biener wrote: Ah, maybe it's worth to export this functionality to libiberty? That would make sense to me. Can you please Nathan factor out the function to libiberty? you're not the boss of me :) But seriously, I'm not

Re: [PATCH] tree-optimization/93354 FRE redundant store removal validity fix

2020-01-23 Thread Richard Biener
On Wed, 22 Jan 2020, Richard Biener wrote: > > This fixes the validity check for redundant store removal by looking > at the actual stmt that represents the last (relevant) change to > the TBAA state rather than the imperfectly tracked alias set in the > expression hash table which then becomes

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

2020-01-23 Thread Martin Liška
On 1/22/20 2:35 PM, Jan Hubicka wrote: On 1/22/20 12:09 PM, Martin Liška wrote: stats for indirect_call:   total: 9210   invalid: 600   tracked values: 0 values: 6280 times (68.19%) 1 values: 1856 times (20.15%) 2 values:  264 times (2.87%) 3 values:

Re: [PATCH][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2020-01-23 Thread Andrea Corallo
> Andrea Corallo writes: > >> Andrea Corallo writes: >> >>> Andrea Corallo writes: >>> Hi all, yesterday I've found an interesting bug in libgccjit. Seems we have an hard limitation of 200 characters for literal strings. Attempting to create longer strings lead to ICE during

Re: [PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

2020-01-23 Thread Corentin Gay
On 20/12/2019 11:33, Jonathan Wakely wrote: Was it tested on AIX? I think dg-require-gthreads will prevent the tests running for the single-threaded multilib on AIX, so it will work OK. But there's a chance it will need fixing. Let's wait and see (I'm currently unable to build GCC on AIX).

Re: wwwdocs: Document the gcc git repository layout

2020-01-23 Thread Richard Earnshaw (lists)
On 22/01/2020 22:15, Joseph Myers wrote: On Wed, 22 Jan 2020, Richard Earnshaw (lists) wrote: Joseph, have I got all of these right? refs/meta in that list should be refs/meta/config, there isn't anything else under refs/meta/ at present. I've pushed this version... diff --git

Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.

2020-01-23 Thread Dragan Mladjenovic
On 07.12.2019. 19:33, Jeff Law wrote: > On Thu, 2019-11-07 at 17:05 +, Dragan Mladjenovic wrote: >> On 01.11.2019. 11:32, Dragan Mladjenovic wrote: >>> On 10.08.2019. 00:15, Joseph Myers wrote: On Fri, 9 Aug 2019, Jeff Law wrote: >> 2019-08-05 Dragan Mladjenovic >> >>

[committed] update gcc-10/changes.html

2020-01-23 Thread Martin Sebor
I pushed the attached diff to the wwwdocs repository. In links to the manuals that I added I pointed to the upcoming release, 10.1.0, even though the new version directory hasn't been created yet. I also updated existing links pointing to the development version of GCC to point to 10.1.0

Re: [PATCH] analyzer: testsuite: introduce analyzer-torture.exp

2020-01-23 Thread Richard Sandiford
David Malcolm writes: > Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. > > OK for master? I'm working on various followup bugfixes that could > use this for test coverage. > > gcc/testsuite/ChangeLog: > * gcc.dg/analyzer/data-model-3.c: Remove hardcoded "-O2" and move >

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-23 Thread Martin Liška
On 1/22/20 9:12 AM, Richard Biener wrote: Ah, maybe it's worth to export this functionality to libiberty? That would make sense to me. Can you please Nathan factor out the function to libiberty? Thanks, Martin

[COMMITTED] aarch64: Skip whilele_1.C test for ILP32

2020-01-23 Thread Richard Sandiford
The definitions of the integer types for ILP32 newlib make the resolution of some of the bool-related tests ambiguous. Tested on aarch64-linux-gnu and aarch64_be-elf, committed. Richard 2020-01-23 Richard Sandiford gcc/testsuite/ *

Re: [PATCH] wide-int: i386: Fix ICEs on TImode signed overflow add/sub patterns [PR93376]

2020-01-23 Thread Uros Bizjak
On Thu, Jan 23, 2020 at 10:33 AM Jakub Jelinek wrote: > > On Thu, Jan 23, 2020 at 09:14:42AM +, Richard Sandiford wrote: > > > The other patch is something suggested by Richard S., avoid using OImode > > > for this and instead use a partial int mode that is smaller. This is > > > still > >

Re: [PATCH, GCC/ARM] Fix MVE scalar shift tests

2020-01-23 Thread Christophe Lyon
On Mon, 20 Jan 2020 at 19:01, Mihail Ionescu wrote: > > Hi, > > This patch fixes the scalar shifts tests added in: > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01195.html > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01196.html > By adding mthumb and ensuring that the target supports >

Re: [PATCH] wide-int: i386: Fix ICEs on TImode signed overflow add/sub patterns [PR93376]

2020-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2020 at 09:14:42AM +, Richard Sandiford wrote: > > The other patch is something suggested by Richard S., avoid using OImode > > for this and instead use a partial int mode that is smaller. This is still > > playing with fire because even the partial int mode is larger than > >

Re: [C++ Patch] PR 92804 [10 Regression] ICE trying to use concept as a nested-name-specifier

2020-01-23 Thread Paolo Carlini
Hi, On 22/01/20 22:32, Jason Merrill wrote: On 1/22/20 3:31 PM, Paolo Carlini wrote: Hi, On 22/01/20 17:27, Jason Merrill wrote: On 1/22/20 10:22 AM, Paolo Carlini wrote: Hi, in this simple issue we either wrongly talked about variable template-id in c++17 mode or ICEd in c++2a. I think

Re: [PATCH] wide-int: i386: Fix ICEs on TImode signed overflow add/sub patterns [PR93376]

2020-01-23 Thread Richard Sandiford
Jakub Jelinek writes: > Hi! > > The following testcase ICEs, because during try_combine of i3: > (insn 18 17 19 2 (parallel [ > (set (reg:CCO 17 flags) > (eq:CCO (plus:OI (sign_extend:OI (reg:TI 96)) > (const_int 1 [0x1])) >

Re: [PATCH] i386: Use bzhi for x & ((1 << y) - 1) or x & ((1U << y) - 1) [PR93346]

2020-01-23 Thread Uros Bizjak
On Thu, Jan 23, 2020 at 8:56 AM Jakub Jelinek wrote: > > Hi! > > The bzhi patterns are quite complicated because they need to accurately > describe the behavior of the instruction for all input values. > The following patterns are simple and make bzhi recognizable even for > cases where not all

[wwwdocs] Abstract a statement to refer to our infrastructure, no specifics.

2020-01-23 Thread Gerald Pfeifer
Another reference to svn gone - and more abstract in case of another change in 2049. Pushed. --- htdocs/contribute.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/contribute.html b/htdocs/contribute.html index 042ff069..b671354e 100644 ---

[PATCH] wide-int: i386: Fix ICEs on TImode signed overflow add/sub patterns [PR93376]

2020-01-23 Thread Jakub Jelinek
Hi! The following testcase ICEs, because during try_combine of i3: (insn 18 17 19 2 (parallel [ (set (reg:CCO 17 flags) (eq:CCO (plus:OI (sign_extend:OI (reg:TI 96)) (const_int 1 [0x1])) (sign_extend:OI (plus:TI (reg:TI 96)