Re: [PATCH] libstdc++: Fix LWG issues 3389 and 3390

2020-02-11 Thread Jonathan Wakely
On 11/02/20 11:05 -0500, Patrick Palka wrote: On Tue, 11 Feb 2020, Patrick Palka wrote: libstdc++-v3/ChangeLog: DR 3389 and DR 3390 * include/bits/stl_iterator.h (move_move_iterator): Use std::move when constructing the move_iterator with __i.

Re: [PATCH] Hashtable: Add missing std qualification on a forward call

2020-02-11 Thread Jonathan Wakely
On 11/02/20 19:15 +0100, François Dumont wrote: I just notice that in a recent patch I forgot a std:: on a call to forward. * include/bits/hashtable.h (_Hashtable<>(_Hashtable&&, std::allocator_type&)):     Add missing std namespace qualification to forward call. Ok to commit ? Yes please

[PATCH coroutines] Handle component_ref in captures_temporary

2020-02-11 Thread JunMa
Hi In captures_temporary, the current implementation fails to handle component_ref. This causes ice with case co_await A while operator co_await is defined in base class of A. Also it is necessary to capture the object of base class as if it is temporary object. This patch strips component_ref

Re: [PATCH] i386: Fix k*shift* intrinsics [PR93673]

2020-02-11 Thread Uros Bizjak
On Wed, Feb 12, 2020 at 7:33 AM Jakub Jelinek wrote: > > Hi! > > As mentioned in the PR, the intrinsics allow counts from 0 to 255, but > we actually reject values from 128 to 255. That is because QImode > CONST_INTs can be only -128 to 127. Fixed by using const_0_to_255_operand > and adjusting

[cris-decc0 14/14] cris: Enable "neg" to set condition codes.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.c (cris_select_cc_mode): Return CC_NZmode for NEG too. Correct comment. * config/cris/cris.md ("neg2"): Rename from "neg2". While gcc seems to prefer transforming tests on the result of reversible operations, into tests on the original, it also can work with the destination,

[cris-decc0 13/14] cris: Enable single-bit btst/btstq to set condition codes.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris-modes.def (CC_ZnN): New CC_MODE. * config/cris/cris.c (cris_rtx_costs): Handle pre-split bit-test * config/cris/cris.md (ZnNNZSET, ZnNNZUSE): New mode_iterators. (znnCC, rznnCC): New code_attrs. ("*btst"): Iterator over ZnNNZSET instead of NZVCSET. Remove obseolete comment.

[cris-decc0 12/14] cris: Enable 32-bit shifts, clz, bswap, umin to set condition codes.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.md ("si3"): Rename from "si3". ("clzsi2"): Rename from "clzsi2". ("bswapsi2"): Rename from "bswapsi2". ("*uminsi3"): Rename from "*uminsi3". Enables dropping of compares with zero of the result, through any CCmode substitution. --- gcc/config/cris/cris.md | 8 1 file

[cris-decc0 11/14] cris: Enable general "and", "or", "xor", "not" to set condition codes.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.md ("*expanded_andsi"): Rename from "*expanded_andsi". ("*iorsi3"): Similar from "*iorsi3". Decorate "cc" attribute to make "cc". ("*iorhi3"): Similar from "*iorhi3". ("*iorqi3"): Similar from "*iorqi3". ("*expanded_andhi"): Similar from "*expanded_andhi". Add quick cc-setting

[cris-decc0 10/14] cris: Enable additions and subtractions to set condition codes.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.md ("*adddi3"): Rename from "*adddi3". cris: Enable 32-bit addition to set condition codes. ("*subdi3"): Similarly from "*subdi3". ("*addsi3"): Similarly from "*addsi3". ("*subsi3"): Similarly from "*subsi3". ("*addhi3"): Similarly from "*addhi3" and decorate the "cc" attribute

[cris-decc0 9/14] cris: Enable extend operations to SImode to set condition codes.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.md ("extendsi2"): Rename from "extendsi2". ("zero_extendsi2"): Similar, from "zero_extendsi2". Enable dropping of compares with zero of the result, through the three CCmode substitutions and the cmpelim pass. --- gcc/config/cris/cris.md | 4 ++-- 1 file changed, 2

[cris-decc0 8/14] cris: Enable movhi and movqi to set condition codes. Anonymize.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.md ("anz", "anzvc", "acc"): New define_subst_attrs. ("movhi"): Rename from "movhi". Rename "cc" attribute to "cc". ("movqi"): Similar from "movqi". Correct contents of, and rename "cc" attribute to "cc". ("*b"): Rename from "b". ("*b"): Rename from "b". ("*b"): Rename from

[cris-decc0 7/14] cris: Enable *movsi_internal to set condition codes.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.md ("cc"): Comment on new use. ("cc_enabled"): New attribute. ("enabled"): Make default fall back to cc_enabled. ("setnz", "ccnz", "setnzvc", "ccnzvc", "setcc", ""): New default_subst_attrs. ("setnz_subst", "setnzvc_subst", "setcc_subst"): New default_subst.

[cris-decc0 6/14] cris: Introduce CC_NZVCmode and CC_NZmode.

2020-02-11 Thread Hans-Peter Nilsson
Prepare for cmpelim pass to eliminate redundant compare insns. * config/cris/cris-modes.def: New file. * config/cris/cris-protos.h (cris_select_cc_mode): Declare. (cris_notice_update_cc): Remove left-over declaration. * config/cris/cris.c (TARGET_CC_MODES_COMPATIBLE): Define. (cris_select_cc_mode,

[cris-decc0 5/14] cris.md: Post-reload, split/generate clobberless zero source moves

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.md ("movsi"): For a zero-source post-reload, generate a clobberless variant. ("*mov_fromzero_split"): New split. ("*mov_fromzero"): New insn. A separated follow-up to the previous change: Also emit moves from zero as not clobbering condition-codes. --- gcc/config/cris/cris.md

[cris-decc0 4/14] cris.md: Post-reload, split/generate clobberless memory destination moves

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.md ("movsi"): For memory destination post-reload, generate clobberless variant. ("*mov_tomem_split"): New split. ("*mov_tomem"): New insn. ("enabled", mov_tomem_enabled): Define and use to exclude "x" -> "Q>m" for less-than-SImode. In preparation for compare-elimination (for it

[cris-decc0 3/14] config/cris/cris.h (REVERSIBLE_CC_MODE): Define to true.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.h (REVERSIBLE_CC_MODE): Define to true. For some reason (like a buglet in the user in jump.c), defining this makes a beneficial difference in ledf2, thus this is separated to its own commit. Also, add comment on (not defining) REVERSE_CONDITION. --- gcc/config/cris/cris.h | 3

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-02-11 Thread Prathamesh Kulkarni
On Tue, 4 Feb 2020 at 14:54, Prathamesh Kulkarni wrote: > > On Mon, 3 Feb 2020 at 14:56, Prathamesh Kulkarni > wrote: > > > > On Mon, 3 Feb 2020 at 14:41, Prathamesh Kulkarni > > wrote: > > > > > > On Thu, 30 Jan 2020 at 19:17, Richard Biener > > > wrote: > > > > > > > > On Thu, Jan 30, 2020

[cris-decc0 2/14] cris: Define TARGET_FLAGS_REGNUM.

2020-02-11 Thread Hans-Peter Nilsson
* config/cris/cris.c (TARGET_FLAGS_REGNUM): Define. This made a whole lot of difference regarding regressions in the delay-slot filling. Before this, comparing __lshrdi3 for v10 before/after decc0ration and other nearby functions was worse by several missing delay-slot fills; now down to 1.

[cris-decc0 1/14] cris: Emit trivial btstq expected by gcc.target/cris/sync-2i.c, sync-2c.c

2020-02-11 Thread Hans-Peter Nilsson
PR target/93372 * config/cris/cris.md (zcond): New code_iterator. ("*cbranch4_btstq"): New insn_and_split. As the added FIXME says, the new insn_and_split generates only a small subset of the bit-tests that can be matched by "*btst" and that were emitted by the undecc0rated cris.md at

[cris-decc0 0/14] A set of compare-elimination-fixes.

2020-02-11 Thread Hans-Peter Nilsson
I just rebased and updated the vendors/axis branch axis/cris-decc0 with the following commits, which should bring back compare-elimination results to that of cc0 on master. With the exception of the bit-test patterns (btst / btstq which is more of a "combine" matter), everything is centered

[PATCH] i386: Fix k*shift* intrinsics [PR93673]

2020-02-11 Thread Jakub Jelinek
Hi! As mentioned in the PR, the intrinsics allow counts from 0 to 255, but we actually reject values from 128 to 255. That is because QImode CONST_INTs can be only -128 to 127. Fixed by using const_0_to_255_operand and adjusting the modes for those predicate to HImode instead of QImode (the IL

[PATCH] real: Fix roundeven on inf/nan [PR93663]

2020-02-11 Thread Jakub Jelinek
On Fri, Aug 23, 2019 at 08:38:43PM +, Joseph Myers wrote: > > +/* Return true if R is halfway between two integers, else return > > + false. The function is not valid for rvc_inf and rvc_nan classes. */ > > + > > +bool > > +is_halfway_below (const REAL_VALUE_TYPE *r) > > +{ > > +

Re: [PATCH, IRA] Fix PR91052 by skipping multiple_sets insn in combine_and_move_insns

2020-02-11 Thread Kewen.Lin
on 2020/2/12 上午12:24, Vladimir Makarov wrote: > On 2/11/20 3:01 AM, Kewen.Lin wrote: >> Hi, >> >> As PR91052's comments show, commit r272731 exposed one issue in function >> combine_and_move_insns.  Function combine_and_move_insns perform the >> below unexpected transformation. >> >> ** Before: **

[PATCH] libstdc++: Memoize {drop,drop_while,filter,reverse}_view::begin

2020-02-11 Thread Patrick Palka
This patch adds memoization for these four views so that their begin() has the required constant time amortized complexity. In the general case we use std::optional to cache the result. When the underlying range is a random_access_range then we store the cache as an offset from the beginning of

Re: [PATCH 1/2] analyzer: g++ testsuite support

2020-02-11 Thread Mike Stump
On Feb 6, 2020, at 12:27 PM, David Malcolm wrote: > > PR analyzer/93288 reports a C++-specific ICE with -fanalyzer. > > This patch creates the beginnings of a C++ test suite for the analyzer, > so that there's a place to put test coverage for the fix. > It adds a regression test for PR

Re: [PATCH] avoid user-constructible types in reshape_init_array (PR 90938)

2020-02-11 Thread Martin Sebor
On 2/11/20 5:01 PM, Marek Polacek wrote: On Tue, Feb 11, 2020 at 01:00:05PM -0700, Martin Sebor wrote: r270155, committed in GCC 9, introduced a transformation that strips redundant trailing zero initializers from array initializer lists in order to support string literals as template

Re: [PATCH] c++: Fix ICE-on-invalid with broken attribute [PR93684]

2020-02-11 Thread Jason Merrill
On 2/11/20 10:35 PM, Marek Polacek wrote: We crash when parsing [[a:: because we see a CPP_SCOPE and then we're trying to consume a CPP_EOF token. So peek before consuming it. Bootstrapped/regtested on x86_64-linux, ok for trunk? OK. PR c++/93684 - ICE-on-invalid with broken

Re: [PATCH] avoid user-constructible types in reshape_init_array (PR 90938)

2020-02-11 Thread Jason Merrill
On 2/11/20 9:00 PM, Martin Sebor wrote: r270155, committed in GCC 9, introduced a transformation that strips redundant trailing zero initializers from array initializer lists in order to support string literals as template arguments. The transformation neglected to consider the case of array

[committed] c++: Fix implicit friend operator==.

2020-02-11 Thread Jason Merrill
It seems that in writing testcases for the operator<=> proposal I didn't include any tests for implicitly declared friend operator==, and consequently it didn't work. Tested x86_64-pc-linux-gnu, applying to trunk. 2020-02-11 Jason Merrill PR c++/93675 * class.c

Re: [PATCH] avoid user-constructible types in reshape_init_array (PR 90938)

2020-02-11 Thread Marek Polacek
On Tue, Feb 11, 2020 at 01:00:05PM -0700, Martin Sebor wrote: > r270155, committed in GCC 9, introduced a transformation that strips > redundant trailing zero initializers from array initializer lists in > order to support string literals as template arguments. > > The transformation neglected to

Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-02-11 Thread Segher Boessenkool
Hi! On Tue, Feb 11, 2020 at 07:43:31PM +0100, Ulrich Weigand wrote: > 1. If a component flag of -ffast-math (or -funsafe-math-optimizations) >is explicitly set (or reset) on the command line, this should override >any implicit change due to -f(no-)fast-math, no matter in which order >

Re: [PATCH] avoid assuming calloc return value is used (PR 93683)

2020-02-11 Thread Jeff Law
On Tue, 2020-02-11 at 16:01 -0700, Martin Sebor wrote: > Along with some special handling of calloc calls, r272717 introduced > the assumption into stmt_kills_ref_p that the value returned from > the call is used. The code triggers an ICE when invoked during DCE > in an attempt to determine

[PATCH] avoid assuming calloc return value is used (PR 93683)

2020-02-11 Thread Martin Sebor
Along with some special handling of calloc calls, r272717 introduced the assumption into stmt_kills_ref_p that the value returned from the call is used. The code triggers an ICE when invoked during DCE in an attempt to determine whether a calloc call can be eliminated. To avoid the ICE the

[PATCH] c++: Fix ICE-on-invalid with broken attribute [PR93684]

2020-02-11 Thread Marek Polacek
We crash when parsing [[a:: because we see a CPP_SCOPE and then we're trying to consume a CPP_EOF token. So peek before consuming it. Bootstrapped/regtested on x86_64-linux, ok for trunk? PR c++/93684 - ICE-on-invalid with broken attribute. * parser.c

Re: [PING^4][PATCH 0/4] Fix library testsuite compilation for build sysroot

2020-02-11 Thread Maciej W. Rozycki
Hi Chung-Lin, > sorry for the late reply. No worries. > The 'AM_RUNTESTFLAGS = --tool_exec "$(CC)"' does work for us, but only > because you backed out the change > from libgomp-test-support.exp, and our installed testing doesn't use the > libgomp/testsuite/Makefile.* files > (we invoke

Re: [PATCH] configure: Re-disable building cross-gdbserver

2020-02-11 Thread Maciej W. Rozycki
On Tue, 11 Feb 2020, Tom Tromey wrote: > Maciej> Correct fallout from commit 919adfe84092 ("Move gdbserver to top > level") > Maciej> and revert to not building `gdbserver' in a cross-configuration, that > is > Maciej> where host != target, matching the documented behaviour. We have no >

[PATCH] avoid user-constructible types in reshape_init_array (PR 90938)

2020-02-11 Thread Martin Sebor
r270155, committed in GCC 9, introduced a transformation that strips redundant trailing zero initializers from array initializer lists in order to support string literals as template arguments. The transformation neglected to consider the case of array elements of trivial class types with

[PATCH] c++: Fix value-init crash in template [PR93676]

2020-02-11 Thread Marek Polacek
Since we attempt to value-initialize in build_vec_init even when there's no initializer but the type has a constexpr default constructor. But build_value_init doesn't work in templates, so I think let's avoid this scenario; we'll go to

[committed] analyzer: fix ICE due to missing state_change purging (PR 93374)

2020-02-11 Thread David Malcolm
PR analyzer/93374 reports an ICE within state_change::validate due to an m_new_sid in a recorded state-change being out of range of the svalues of the region_model of the new state. During get_or_create_node we attempt to merge the new state with the state of each of the existing enodes at the

[PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-02-11 Thread Ulrich Weigand
Hello, this second version of the patch incorporates all changes discussed in the original mail thread starting here: https://gcc.gnu.org/ml/gcc-patches/2020-01/msg02097.html The patch now implements the following set of changes: 1. If a component flag of -ffast-math (or

[committed] analyzer: fix ICE with equiv_class constant (PR 93649)

2020-02-11 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r10-6580-gcd28b75921354c64fd4c8a1c238991e522abc38e. gcc/analyzer/ChangeLog: PR analyzer/93649 * constraint-manager.cc (constraint_manager::add_constraint): When merging equivalence classes

[committed] analyzer: fix ICE in "__analyzer_dump_exploded_nodes" on non-empty worklist (PR 93669)

2020-02-11 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r10-6581-ga0e4929b0461226722d6d08b1fdc2852b9100b75. gcc/analyzer/ChangeLog: PR analyzer/93669 * engine.cc (exploded_graph::dump_exploded_nodes): Handle missing case of STATUS_WORKLIST in

[committed] analyzer.opt: reword descriptions of two dump options (PR 93657)

2020-02-11 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r10-6579-g5e17c1bdadbbd5606d869b1178ed3e653f931cda. gcc/analyzer/ChangeLog: PR analyzer/93657 * analyzer.opt (fdump-analyzer): Reword description. (fdump-analyzer-stderr): Likewise. ---

Re: [PATCH], Rename and document PowerPC -mprefixed-addr to -mprefixed

2020-02-11 Thread Michael Meissner
On Mon, Feb 10, 2020 at 09:24:07PM -0600, Segher Boessenkool wrote: > Hi! > > On Mon, Feb 10, 2020 at 01:45:42PM -0500, Michael Meissner wrote: > > This patch renames the PowerPC internal switch -mprefixed-addr to be > > -mprefixed. > > > If you use -mpcrel, you must be using the 64-bit ELF v2

Re: [PATCH] Add ppc_ieee128_ok target-supports proc

2020-02-11 Thread Segher Boessenkool
Hi! On Tue, Feb 11, 2020 at 12:10:50PM -0600, will schmidt wrote: > +# See if the __ieee128 keyword is understood. > +proc check_effective_target_ppc_ieee128_ok { } { > +return [check_cached_effective_target ppc_ieee128_ok { > + # disable on AIX. > + if { [istarget *-*-aix*] } { > +

[PATCH] Hashtable: Add missing std qualification on a forward call

2020-02-11 Thread François Dumont
I just notice that in a recent patch I forgot a std:: on a call to forward. * include/bits/hashtable.h (_Hashtable<>(_Hashtable&&, std::allocator_type&)):     Add missing std namespace qualification to forward call. Ok to commit ? François diff --git a/libstdc++-v3/include/bits/hashtable.h

Re: [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling

2020-02-11 Thread Segher Boessenkool
Hi! On Tue, Feb 11, 2020 at 03:46:05PM +0300, Roman Zhuykov wrote: > Hmm, even when trying to move it just few passes earlier many years ago, > got another opinion: > https://gcc.gnu.org/ml/gcc-patches/2011-10/msg01526.html > Although without such a move we still have annoying issues which RTL >

Re: [PATCH] Add ppc_ieee128_ok target-supports proc

2020-02-11 Thread will schmidt
Hi, Thanks for the feedback. Updated below. [v2] - removed some explicit disables that were not necessary. - updated options qualifier for the proc. [V1] Add a target_supports entry to check that the __ieee128 keyword is understood by the target. Also add a dg-requires check to the existing

Re: [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling

2020-02-11 Thread Segher Boessenkool
On Tue, Feb 11, 2020 at 02:58:47PM +0100, Richard Biener wrote: > On Tue, 11 Feb 2020, Roman Zhuykov wrote: > > 11.02.2020 11:01, Richard Biener wrote: > > Sound good, but IMHO modulo scheduler is not the best choice to be the > > first step implementing such a concept. > > True ;) But since

Re: [PATCH] regalloc/debug: fix buggy print_hard_reg_set

2020-02-11 Thread Vladimir Makarov
On 2/11/20 9:54 AM, Hans-Peter Nilsson wrote: I was using ira-conflicts.c:print_hard_reg_set with a local patch to gdbinit.in in a debug-session, and noticed the erroneous output. I see there's an almost identical function in ira-color.c and on top of that, there's another function by the same

Re: [PATCH, IRA] Fix PR91052 by skipping multiple_sets insn in combine_and_move_insns

2020-02-11 Thread Vladimir Makarov
On 2/11/20 3:01 AM, Kewen.Lin wrote: Hi, As PR91052's comments show, commit r272731 exposed one issue in function combine_and_move_insns. Function combine_and_move_insns perform the below unexpected transformation. ** Before: ** 67: NOTE_INSN_BASIC_BLOCK 8 ... 59:

Re: [PATCH v2] c++: Fix ICE with template codes in check_narrowing [PR91465]

2020-02-11 Thread Marek Polacek
On Sun, Feb 09, 2020 at 01:51:13PM +0100, Jason Merrill wrote: > On 2/6/20 7:30 PM, Marek Polacek wrote: > > In ed4f2c001a883b2456fc607a33f1c59f9c4ee65d I changed the call to > > fold_non_dependent_expr in check_narrowing to maybe_constant_value. > > That was the wrong thing to do as these tests

Re: [PATCH] libstdc++: Fix LWG issues 3389 and 3390

2020-02-11 Thread Patrick Palka
On Tue, 11 Feb 2020, Patrick Palka wrote: > libstdc++-v3/ChangeLog: > > DR 3389 and DR 3390 > * include/bits/stl_iterator.h (move_move_iterator): Use std::move when > constructing the move_iterator with __i. > (counted_iterator::counted_iterator): Use std::move when

[PATCH] libstdc++: Fix LWG issues 3389 and 3390

2020-02-11 Thread Patrick Palka
libstdc++-v3/ChangeLog: DR 3389 and DR 3390 * include/bits/stl_iterator.h (move_move_iterator): Use std::move when constructing the move_iterator with __i. (counted_iterator::counted_iterator): Use std::move when initializing M_current with __i. *

New Finnish PO file for 'cpplib' (version 10.1-b20200209)

2020-02-11 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the Finnish team of translators. The file is available at: https://translationproject.org/latest/cpplib/fi.po (This file,

Contents of PO file 'cpplib-10.1-b20200209.fi.po'

2020-02-11 Thread Translation Project Robot
cpplib-10.1-b20200209.fi.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

[9/10 Regression, PATCH] fortran: ICE in gfc_validate_kind(): Got bad kind [PR93580]

2020-02-11 Thread Mark Eggleston
Please find attached a patch, it is based on Steve Kargl's patch in PR93580 adding  a check for %len and test case. The commit message in the patch includes change logs as I believe that is the intended way forward. One thing I'm unsure of it how handle multiple authors, it was easy in the

Re: [PATCH] configure: Re-disable building cross-gdbserver

2020-02-11 Thread Tom Tromey
> "Maciej" == Maciej W Rozycki writes: Maciej> Correct fallout from commit 919adfe84092 ("Move gdbserver to top level") Maciej> and revert to not building `gdbserver' in a cross-configuration, that is Maciej> where host != target, matching the documented behaviour. We have no way

Re: [PATCH] fortran: ICE using undeclared symbol in array constructor, PR93484

2020-02-11 Thread Steve Kargl
On Tue, Feb 11, 2020 at 12:10:41PM +, Mark Eggleston wrote: > Please find attached a patch for PR93484.  The original author is Steve > Kargl. I have added the test cases. > > OK for master? I obviously think the patch is ok, but I'll let someone else review it. >     Steven G. Kargl  > >

Re: [9/10 Regression, PATCH] fortran: ICE in gfc_validate_kind(): Got bad kind [PR93580]

2020-02-11 Thread Mark Eggleston
So it does, I'll have an other go. On 11/02/2020 15:20, Steve Kargl wrote: On Tue, Feb 11, 2020 at 02:41:26PM +, Mark Eggleston wrote: Please find attached a patch, it is based on Steve Kargl's patch in PR93580 adding  a check for %len and test case. Looks like the wrong diff was

Re: [9/10 Regression, PATCH] fortran: ICE in gfc_validate_kind(): Got bad kind [PR93580]

2020-02-11 Thread Steve Kargl
On Tue, Feb 11, 2020 at 02:41:26PM +, Mark Eggleston wrote: > Please find attached a patch, it is based on Steve Kargl's patch in PR93580 > adding  a check for %len and test case. > Looks like the wrong diff was attached. > gcc/fortran/match.c | 4 ++-- >

[PATCH] regalloc/debug: fix buggy print_hard_reg_set

2020-02-11 Thread Hans-Peter Nilsson
I was using ira-conflicts.c:print_hard_reg_set with a local patch to gdbinit.in in a debug-session, and noticed the erroneous output. I see there's an almost identical function in ira-color.c and on top of that, there's another function by the same name and with similar semantics in

Re: [PATCH] issues with configure --enable-checking option

2020-02-11 Thread Roman Zhuykov
07.02.2020 20:20, Richard Sandiford writes: > Roman Zhuykov writes: >> Hi! >> I've investigated a bit, because some of the following confused me while >> working with some local 9.2-based branch. >> >> Documentation issues: >> (0) See patch for install.texi at the bottom, two possible values are

[9/10 Regression, PATCH] fortran: ICE in gfc_validate_kind(): Got bad kind [PR93580]

2020-02-11 Thread Mark Eggleston
Please find attached a patch, it is based on Steve Kargl's patch in PR93580 adding  a check for %len and test case. The commit message in the patch includes change logs as I believe that is the intended way forward. One thing I'm unsure of it how handle multiple authors, it was easy in the

RE: [PATCH V2] Generalized value pass-through for self-recursive function (ipa/pr93203)

2020-02-11 Thread Tamar Christina
Hi Feng, It looks like the option that causes this to trigger is `--param ipa-cp-eval-threshold=1` So on AArch64 I get it to trigger with -mcpu=native -Ofast -fomit-frame-pointer -flto --param ipa-cp-eval-threshold=1 Kind Regards, Tamar > -Original Message- > From: Feng Xue OS >

Re: [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling

2020-02-11 Thread Richard Biener
On Tue, 11 Feb 2020, Roman Zhuykov wrote: > 11.02.2020 11:01, Richard Biener wrote: > > On Tue, 11 Feb 2020, Segher Boessenkool wrote: > > > >> On Tue, Feb 11, 2020 at 08:34:15AM +0100, Richard Biener wrote: > >>> On Mon, 10 Feb 2020, Segher Boessenkool wrote: > Yes, we should decide how

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-11 Thread Andrea Corallo
Hi Richard, "Richard Earnshaw (lists)" writes: >> gcc/ChangeLog: >> 2020-??-?? Andrea Corallo >> 2020-??-?? Mihail-Calin Ionescu >> 2020-??-?? Iain Apreotesei >> * config/arm/arm.c (TARGET_INVALID_WITHIN_DOLOOP): >> (arm_invalid_within_doloop): Implement

Re: [PATCH V2] Generalized value pass-through for self-recursive function (ipa/pr93203)

2020-02-11 Thread Feng Xue OS
Hi Tarmar, Since I could not reproduce this ICE with my local testing on Spec2017, would you share your config, or command line options extracted from compilation of perlbench? Thanks, Feng From: gcc-patches-ow...@gcc.gnu.org on behalf of Tamar

Re: [PATCH] Fix -ffast-math flags handling inconsistencies

2020-02-11 Thread Ulrich Weigand
Joseph Myers wrote: > On Mon, 10 Feb 2020, Ulrich Weigand wrote: > > I'm not sure how this can be implemented in the current option handling > > framework. The -ffast-math handling case would have to check whether > > or not there is any explicit use of -f(no-)finite-math-only; is there > > any

Re: [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling

2020-02-11 Thread Roman Zhuykov
11.02.2020 11:01, Richard Biener wrote: > On Tue, 11 Feb 2020, Segher Boessenkool wrote: > >> On Tue, Feb 11, 2020 at 08:34:15AM +0100, Richard Biener wrote: >>> On Mon, 10 Feb 2020, Segher Boessenkool wrote: Yes, we should decide how often we want to unroll things somewhere before

[PATCH] fortran: ICE using undeclared symbol in array constructor, PR93484

2020-02-11 Thread Mark Eggleston
Please find attached a patch for PR93484.  The original author is Steve Kargl. I have added the test cases. OK for master? running make produces the following for check-fortran gcc-8 and gcc-9 but not master: XPASS: gfortran.dg/typebound_call_22.f03   -O scan-tree-dump-times optimized

[Ping][PATCH][Arm] ACLE 8-bit integer matrix multiply-accumulate intrinsics

2020-02-11 Thread Dennis Zhang
Hi all, On 16/12/2019 13:45, Dennis Zhang wrote: Hi all, This patch is part of a series adding support for Armv8.6-A features. It depends on the Arm Armv8.6-A CLI patch, https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02195.html. It also depends on the Armv8.6-A effective target checking patch,

Re: [Pingx3][GCC][PATCH][ARM]Add ACLE intrinsics for dot product (vusdot - vector, vdot - by element) for AArch32 AdvSIMD ARMv8.6 Extension

2020-02-11 Thread Stam Markianos-Wright
On 2/11/20 10:25 AM, Kyrill Tkachov wrote: Hi Stam, On 2/10/20 1:35 PM, Stam Markianos-Wright wrote: On 2/3/20 11:20 AM, Stam Markianos-Wright wrote: > > > On 1/27/20 3:54 PM, Stam Markianos-Wright wrote: >> >> On 1/16/20 4:05 PM, Stam Markianos-Wright wrote: >>> >>> >>> On 1/10/20 6:48

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-11 Thread Richard Earnshaw (lists)
On 11/02/2020 10:14, Andrea Corallo wrote: Hi all, This patch enables the Armv8.1-M Mainline LOB (low overhead branch) extension low overhead loops (LOL) feature by using the loop-doloop pass that it shares with the Swing Modulo Scheduler. bootstrapped arm-none-linux-gnueabihf, does not

Re: [Pingx3][GCC][PATCH][ARM]Add ACLE intrinsics for dot product (vusdot - vector, vdot - by element) for AArch32 AdvSIMD ARMv8.6 Extension

2020-02-11 Thread Kyrill Tkachov
Hi Stam, On 2/10/20 1:35 PM, Stam Markianos-Wright wrote: On 2/3/20 11:20 AM, Stam Markianos-Wright wrote: > > > On 1/27/20 3:54 PM, Stam Markianos-Wright wrote: >> >> On 1/16/20 4:05 PM, Stam Markianos-Wright wrote: >>> >>> >>> On 1/10/20 6:48 PM, Stam Markianos-Wright wrote:

[PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-11 Thread Andrea Corallo
Hi all, This patch enables the Armv8.1-M Mainline LOB (low overhead branch) extension low overhead loops (LOL) feature by using the loop-doloop pass that it shares with the Swing Modulo Scheduler. bootstrapped arm-none-linux-gnueabihf, does not introduce testsuite regressions. Andrea

RE: [PATCH V2] Generalized value pass-through for self-recursive function (ipa/pr93203)

2020-02-11 Thread Tamar Christina
Hi Feng, This patch (commit a0f6a8cb414b687f22c9011a894d5e8e398c4be0) is causing ICEs in the GCC and perlbench benchmark in Spec2017. during IPA pass: cp lto1: internal compiler error: in find_more_scalar_values_for_callers_subset, at ipa-cp.c:4709 0x1698187

[PATCH] tree-optimization/93661 properly guard tree_to_poly_int64

2020-02-11 Thread Richard Biener
Bootstrapped / tested on x86_64-unknown-linux-gnu, pushed. Richard. 2020-02-11 Richard Biener PR tree-optimization/93661 PR tree-optimization/93662 * tree-ssa-sccvn.c (vn_reference_lookup_3): Properly guard tree_to_poly_int64. * tree-sra.c

Re: [PATCH coroutines] Set side effects flag for BIND_EXPR which build in maybe_promote_captured_temps

2020-02-11 Thread JunMa
在 2020/2/11 上午10:50, JunMa 写道: Hi As title. in maybe_promote_captured_temps, we promote captured temporaries and co_await_expr into a new BIND_EXPR. As the BIND_EXPR contains co_await_expr and maybe other function calls, the side effects flag should be set. This patch fix one mismatch in

Re: [PING^4][PATCH 0/4] Fix library testsuite compilation for build sysroot

2020-02-11 Thread Chung-Lin Tang
Hi Maciej, sorry for the late reply. On 2020/2/1 5:46 AM, Maciej W. Rozycki wrote: On Tue, 21 Jan 2020, Maciej W. Rozycki wrote: I'll give your proposal a shot and I'm lucky enough to have a build configuration where I can have no compiler preinstalled, so at least I can check if testing

[committed] c++: Fix static initialization from <=>.

2020-02-11 Thread Jason Merrill
Constant evaluation of genericize_spaceship produced a CONSTRUCTOR, which we then wanted to bind to a reference, which we can't do. So wrap the result in a TARGET_EXPR so we get something with an address. We also need to handle treating the result of cxx_eval_binary_expression as a glvalue for

Re: [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling

2020-02-11 Thread Richard Biener
On Tue, 11 Feb 2020, Segher Boessenkool wrote: > On Tue, Feb 11, 2020 at 08:34:15AM +0100, Richard Biener wrote: > > On Mon, 10 Feb 2020, Segher Boessenkool wrote: > > > Yes, we should decide how often we want to unroll things somewhere before > > > ivopts already, and just use that info here. >

[PATCH, IRA] Fix PR91052 by skipping multiple_sets insn in combine_and_move_insns

2020-02-11 Thread Kewen.Lin
Hi, As PR91052's comments show, commit r272731 exposed one issue in function combine_and_move_insns. Function combine_and_move_insns perform the below unexpected transformation. ** Before: ** 67: NOTE_INSN_BASIC_BLOCK 8 ... 59: {r184:SF=[sfp:SI-0x190];r121:SI=sfp:SI-0x190;} ==> move