Regression on 32-bit powerpc?

2020-03-04 Thread John Paul Adrian Glaubitz
/build/./prev-gcc/xg++ -B/<>/build/./prev-gcc/ -B/usr/powerpc-linux-gnu/bin/ -nostdinc++ -B/<>/build/prev-powerpc-linux-gnu/libstdc++-v3/src/.libs -B/<>/build/prev-powerpc-linux-gnu/libstdc++-v3/libsupc++/.libs -I/<>/build/prev-powerpc-linux-gnu/libstdc++-v3/include/power

Re: [PATCH] print-rtl: Fix printing of CONST_STRING in DEBUG_INSNs [PR93399]

2020-03-04 Thread Richard Biener
On Thu, 5 Mar 2020, Jakub Jelinek wrote: > Hi! > > The following testcase fails to assemble, as CONST_STRING in the DEBUG_INSNs > is printed as is, so if it contains \n and/or \r, we are in trouble: > .loc 1 14 3 > # DEBUG haystack => [si] > # DEBUG needle => " > " > In

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-04 Thread Richard Biener
On Thu, Mar 5, 2020 at 12:49 AM Jeff Law wrote: > > On Wed, 2020-03-04 at 09:22 -0700, Martin Sebor wrote: > > > > I don't remember why the code in -Wrestrict unconditionally overwrites > > the statement location rather than only when it's not available, but > > I do remember adding conditional

[PATCH] c++: Adjust handling of COMPOUND_EXPRs in cp_build_binary_op [PR91993]

2020-03-04 Thread Jakub Jelinek
Hi! As the testcases shows, the -Wconversion warning behaves quite differently when -fsanitize=undefined vs. when not sanitizing, but in the end it is not something specific to sanitizing, if a user uses return static_cast(static_cast((d++, a) << 1U) | b) | c; instead of return

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Richard Biener
On Wed, Mar 4, 2020 at 8:39 PM Egeyar Bagcioglu wrote: > > > > On 3/4/20 6:23 PM, Martin Liška wrote: > > On 3/4/20 4:25 PM, Egeyar Bagcioglu wrote: > >> Thanks Richard. > >> > >> I do not have write-access to the GCC repo. I'd be glad if someone > >> commits it for me. > > > > Can we please

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-04 Thread Richard Biener
On Wed, Mar 4, 2020 at 5:28 PM Egeyar Bagcioglu wrote: > > > > On 3/4/20 1:18 AM, Fangrui Song wrote: > > On 2020-03-03, Joseph Myers wrote: > >> On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: > >> > >>> Although we discussed after the submission of the first version that > >>> there are several

[PATCH] print-rtl: Fix printing of CONST_STRING in DEBUG_INSNs [PR93399]

2020-03-04 Thread Jakub Jelinek
Hi! The following testcase fails to assemble, as CONST_STRING in the DEBUG_INSNs is printed as is, so if it contains \n and/or \r, we are in trouble: .loc 1 14 3 # DEBUG haystack => [si] # DEBUG needle => " " In the gimple dumps we print those (STRING_CSTs) as # DEBUG

Re: [testsuite] Fix PR94019 to allow one vector char when !vect_hw_misalign

2020-03-04 Thread Kewen.Lin
Hi Richard, on 2020/3/5 上午3:09, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi, >> >> >> --- a/gcc/testsuite/gcc.dg/vect/vect-over-widen-17.c >> +++ b/gcc/testsuite/gcc.dg/vect/vect-over-widen-17.c >> @@ -41,6 +41,10 @@ main (void) >> } >> >> /* { dg-final { scan-tree-dump-not

Re: [testsuite] Fix PR94019 to allow one vector char when !vect_hw_misalign

2020-03-04 Thread Kewen.Lin
Hi Segher, on 2020/3/5 上午2:44, Segher Boessenkool wrote: > Hi! > > On Wed, Mar 04, 2020 at 03:13:51PM +0800, Kewen.Lin wrote: >> As PR94019 shows, without misaligned vector access support but with >> realign load, the vectorized loop will end up with realign scheme. >> It generates mask (control

[PATCH] rs6000: Check -+0 and NaN for smax/smin generation

2020-03-04 Thread Jiufu Guo
Hi, PR93709 mentioned regressions on maxlocval_4.f90 and minlocval_f.f90 which relates to max of '-inf' and 'nan'. This regression occur on P9 which has new instruction 'xsmaxcdp/xsmincdp'. The similar issue also could be find on `a < b ? b : a` which is also generated as `xsmaxcdp` under -O2 for

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-04 Thread binbin
Hi Segher, On 2020/3/5 上午2:35, Segher Boessenkool wrote: On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: * config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the header file for MAX_MACHINE_MODE. The changelog entry should say *what* file is included, and under what

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-04 Thread Martin Sebor
On 3/4/20 4:49 PM, Jeff Law wrote: On Wed, 2020-03-04 at 09:22 -0700, Martin Sebor wrote: I don't remember why the code in -Wrestrict unconditionally overwrites the statement location rather than only when it's not available, but I do remember adding conditional code like in your patch in

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-04 Thread Jeff Law
On Wed, 2020-03-04 at 09:22 -0700, Martin Sebor wrote: > > I don't remember why the code in -Wrestrict unconditionally overwrites > the statement location rather than only when it's not available, but > I do remember adding conditional code like in your patch in r277076 > to deal with missing

Re: [Committed 4/4] IBM Z: zTPF: Include glibc-stdint.h

2020-03-04 Thread Joseph Myers
On Wed, 4 Mar 2020, Andreas Krebbel wrote: > Building a zTPF cross currently fails when building libstdc++ > complaining about the __UINTPTR_TYPE__ to be missing. > > Fixed by including the glibc-stdint.h header. To confirm: TPF provides a header, which uses the same types as glibc's does?

[committed][PR bootstrap/93962] Fix bootstrap issue on freebsd

2020-03-04 Thread Jeff Law
PR 93962 reports a bootstrap failure on FreeBSD 11.3 due to a format warning. Andrew Pinski recommended using std::abs rather than a naked abs. I bootstrapped and regression tested that on x86_64-linux-gnu. I was unable to reproduce the failure in a FreeBSD VM. However Gerald (the reporter)

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 6:33 PM, Jakub Jelinek wrote: On Wed, Mar 04, 2020 at 06:23:10PM +0100, Martin Liška wrote: On 3/4/20 4:25 PM, Egeyar Bagcioglu wrote: Thanks Richard. I do not have write-access to the GCC repo. I'd be glad if someone commits it  for me. Can we please wait? I'm really convinced

[pushed] c++: Fix [[no_unique_address]] and default mem-init [PR90432]

2020-03-04 Thread Jason Merrill
output_constructor doesn't like two consecutive entries with fields at the same position; let's avoid adding the one for the empty field. Tested x86_64-pc-linux-gnu, applying to trunk and 9. gcc/cp/ChangeLog 2020-03-04 Jason Merrill PR c++/90432 * init.c

Re: [PATCH] c++: Backport PR90505 fix to 9

2020-03-04 Thread Jason Merrill
On 3/4/20 4:02 PM, Marek Polacek wrote: While backporting our 90505 fix to 9 I noticed a bunch of concepts regressions. Fortunately I think the following variant of the fix is safe and still fixes the deduction issue. In 9, we want to reject 'auto' when tf_partial before returning

Re: [PATCH] avoid user-constructible types in reshape_init_array (PR 90938)

2020-03-04 Thread Jason Merrill
On 3/4/20 4:14 PM, Martin Sebor wrote: On 3/4/20 10:41 AM, Jason Merrill wrote: On 2/14/20 3:06 PM, Martin Sebor wrote: On 2/13/20 3:59 PM, Jason Merrill wrote: On 2/12/20 9:21 PM, Martin Sebor wrote: On 2/11/20 5:28 PM, Jason Merrill wrote: On 2/11/20 9:00 PM, Martin Sebor wrote: r270155,

[committed] analyzer: validate region subclasses

2020-03-04 Thread David Malcolm
This patch converts region::validate to a vfunc, implementing additional checking per subclass: verifying that various region_id fields within map_region, array_region, stack_region and root_region are valid, rather than just those within the base class. Doing so caught bugs earlier in follow-up

[committed] analyzer: add regression test for fixed ICE [PR94028]

2020-03-04 Thread David Malcolm
The C++ reproducer for PR analyzer/94028 generates a similar ICE to that of the Fortran reproducer for PR analyzer/93993 and, like it, was fixed by r10-7023-g3d66e153b40ed000af30a9e569a05f34d5d576aa. This patch adds the C++ reproducer as a regression test. Successfully regrtested on

Re: GLIBC libmvec status

2020-03-04 Thread GT
‐‐‐ Original Message ‐‐‐ On Monday, March 2, 2020 12:14 PM, Bill Schmidt wrote: > On 3/2/20 11:10 AM, Tulio Magno Quites Machado Filho wrote: > > > Bill Schmidt writes: > > > > > One tiny nit on the document: For the "b" value, let's just say > > > "VSX" rather than > > > "VSX as

Re: [PATCH] issue -Walloca even when alloca is a system header macro [PR94004]

2020-03-04 Thread Jakub Jelinek
On Wed, Mar 04, 2020 at 02:06:58PM -0700, Martin Sebor wrote: > +#ifndef alloca > +// Simulate a definition in a system header. > +# 13 "/usr/include/alloca.h" > +# define alloca(n) __builtin_alloca (n) > +# 15 "Walloca-larger-than-3.c" > +#endif This isn't correct simulation of definition in

Re: [PATCH] avoid user-constructible types in reshape_init_array (PR 90938)

2020-03-04 Thread Martin Sebor
On 3/4/20 10:41 AM, Jason Merrill wrote: On 2/14/20 3:06 PM, Martin Sebor wrote: On 2/13/20 3:59 PM, Jason Merrill wrote: On 2/12/20 9:21 PM, Martin Sebor wrote: On 2/11/20 5:28 PM, Jason Merrill wrote: On 2/11/20 9:00 PM, Martin Sebor wrote: r270155, committed in GCC 9, introduced a

[PATCH] issue -Walloca even when alloca is a system header macro [PR94004]

2020-03-04 Thread Martin Sebor
A 2017 change that propagated call location to GIMPLE statements had the unexpected (though not incorrect) effect of setting the location on calls to __builtin_alloca. When such calls are the result of the expansion of the alloca macro defined in a system header like , the change prevents

[PATCH] c++: Backport PR90505 fix to 9

2020-03-04 Thread Marek Polacek
While backporting our 90505 fix to 9 I noticed a bunch of concepts regressions. Fortunately I think the following variant of the fix is safe and still fixes the deduction issue. In 9, we want to reject 'auto' when tf_partial before returning cp_build_qualified_type_real for TEMPLATE_TYPE_PARM and

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-04 Thread Segher Boessenkool
Hi! On Wed, Mar 04, 2020 at 06:35:23PM +0800, Kewen.Lin wrote: > Another try seems to move it into #ifndef USED_FOR_TARGET hunk. > Since "typedef union section section" is guard by #ifndef USED_FOR_TARGET > in coretypes.h. It can make them consistent. Yes, that should work, good idea. Segher

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-04 Thread Segher Boessenkool
Hi! On Wed, Mar 04, 2020 at 03:24:52PM +0800, binbin wrote: > >>+extern union GTY(()) section *toc_section; > > > >Why does this add "union"? > > If "union" is not added, it reports error showing unknown type name > ‘section’ > in file included from

Re: [PATCH] Handle 'omp declare target' attribute set for both OpenACC and OpenMP 'target' [PR89433, PR93465] (was: [committed] PR89433 "Repeated use of the OpenACC 'routine' directive")

2020-03-04 Thread Jakub Jelinek
On Wed, Mar 04, 2020 at 08:27:10PM +0100, Thomas Schwinge wrote: > ... which as of PR89433 commit b48f44bf77a39fefc238a16cf1225c6464c82406 causes > an ICE. Not sure if this is actually supposed to be valid or invalid code. > Until the interactions between OpenACC and OpenMP 'target' get defined >

Re: [committed] analyzer: detect malloc, free, calloc within "std" [PR93959]

2020-03-04 Thread Bernhard Reutner-Fischer
On Wed, 04 Mar 2020 11:16:35 -0500 David Malcolm wrote: > On Wed, 2020-03-04 at 11:05 -0500, Marek Polacek wrote: > > On Wed, Mar 04, 2020 at 04:54:54PM +0100, Bernhard Reutner-Fischer > > wrote: > > > On Mon, 2 Mar 2020 16:48:26 -0500 > > > David Malcolm wrote: > > > > > > > +static

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 6:23 PM, Martin Liška wrote: On 3/4/20 4:25 PM, Egeyar Bagcioglu wrote: Thanks Richard. I do not have write-access to the GCC repo. I'd be glad if someone commits it for me. Can we please wait? I'm really convinced we do not want one another very similar functionality. I am

[PATCH] Handle 'omp declare target' attribute set for both OpenACC and OpenMP 'target' [PR89433, PR93465] (was: [committed] PR89433 "Repeated use of the OpenACC 'routine' directive")

2020-03-04 Thread Thomas Schwinge
- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter --- Begin Message --- Hi! On 2019-05-17T21:16:57+0200, I wrote: > Now committed to trunk in [...] > r271345

Re: [testsuite] Fix PR94019 to allow one vector char when !vect_hw_misalign

2020-03-04 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi, > > As PR94019 shows, without misaligned vector access support but with > realign load, the vectorized loop will end up with realign scheme. > It generates mask (control vector) with return type vector signed > char which breaks the not check. > > The fix is to

Re: [testsuite] Fix PR94023 to guard case under vect_hw_misalign

2020-03-04 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi, > > As PR94023 shows, the expected SLP requires misaligned vector access > support. This patch is to guard the check under the target condition > vect_hw_misalign to ensure that. > > Verified it on ppc64-redhat-linux (Power7 BE). > > Is it ok for trunk, and backport to

Re: [testsuite] Fix PR94019 to allow one vector char when !vect_hw_misalign

2020-03-04 Thread Segher Boessenkool
Hi! On Wed, Mar 04, 2020 at 03:13:51PM +0800, Kewen.Lin wrote: > As PR94019 shows, without misaligned vector access support but with > realign load, the vectorized loop will end up with realign scheme. > It generates mask (control vector) with return type vector signed > char which breaks the not

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-04 Thread Segher Boessenkool
On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: > >>* config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the header file > >>for MAX_MACHINE_MODE. > > > >The changelog entry should say *what* file is included, and under what > >condition. It doesn't have to say why (that belongs

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Jakub Jelinek
On Wed, Mar 04, 2020 at 06:42:29PM +0100, Martin Liška wrote: > > I must say I don't really see advantages of this over > > -grecord-gcc-switches, recording all options looks very bloaty and will > > include mostly stuff you don't really care about (such as, e.g. the -I > > options without

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Martin Liška
On 3/4/20 6:33 PM, Jakub Jelinek wrote: On Wed, Mar 04, 2020 at 06:23:10PM +0100, Martin Liška wrote: On 3/4/20 4:25 PM, Egeyar Bagcioglu wrote: Thanks Richard. I do not have write-access to the GCC repo. I'd be glad if someone commits it  for me. Can we please wait? I'm really convinced we

Re: [PATCH] avoid user-constructible types in reshape_init_array (PR 90938)

2020-03-04 Thread Jason Merrill
On 2/14/20 3:06 PM, Martin Sebor wrote: On 2/13/20 3:59 PM, Jason Merrill wrote: On 2/12/20 9:21 PM, Martin Sebor wrote: On 2/11/20 5:28 PM, Jason Merrill wrote: On 2/11/20 9:00 PM, Martin Sebor wrote: r270155, committed in GCC 9, introduced a transformation that strips redundant trailing

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Jakub Jelinek
On Wed, Mar 04, 2020 at 06:23:10PM +0100, Martin Liška wrote: > On 3/4/20 4:25 PM, Egeyar Bagcioglu wrote: > > Thanks Richard. > > > > I do not have write-access to the GCC repo. I'd be glad if someone commits  > > it for me. > > Can we please wait? I'm really convinced we do not want one

[COMMITTED] add test for false positive -Wformat-overflow in a loop [PR81401]

2020-03-04 Thread Martin Sebor
The bug has been fixed for a while. I added the two tests from the report in 97bd1d6b513..3ca63e1c76b (attached). Martin commit 3ca63e1c76b7693b5d3f5ba2567421defc764249 (HEAD -> master) Author: Martin Sebor Date: Wed Mar 4 10:23:49 2020 -0700 PR middle-end/81401 - false positive

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Martin Liška
On 3/4/20 4:25 PM, Egeyar Bagcioglu wrote: Thanks Richard. I do not have write-access to the GCC repo. I'd be glad if someone commits it  for me. Can we please wait? I'm really convinced we do not want one another very similar functionality. I would definitely recommend to change the

Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla and vfma for AArch32 AdvSIMD

2020-03-04 Thread Delia Burduv
Hi, This is the latest version of the patch. Thanks, Delia On 2/21/20 11:41 AM, Kyrill Tkachov wrote: Hi Delia, On 2/19/20 5:23 PM, Delia Burduv wrote: Hi, Here is the latest version of the patch. It just has some minor formatting changes that were brought up by Richard Sandiford in the

Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32

2020-03-04 Thread Kyrill Tkachov
Hi Delia, On 3/3/20 5:23 PM, Delia Burduv wrote: Hi, I noticed that the patch doesn't apply cleanly. I fixed it and this is the latest version. Thanks, Delia On 3/3/20 4:23 PM, Delia Burduv wrote: Sorry, I forgot the attachment. On 3/3/20 4:20 PM, Delia Burduv wrote: Hi, I made a

Re: ACLE intrinsics: BFloat16 load intrinsics for AArch32

2020-03-04 Thread Kyrill Tkachov
Hi Delia, On 3/4/20 2:05 PM, Delia Burduv wrote: Hi, The previous version of this patch shared part of its code with the store intrinsics patch (https://gcc.gnu.org/ml/gcc-patches/2020-03/msg00145.html) so I removed any duplicated code. This patch now depends on the previously mentioned store

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 5:28 PM, Egeyar Bagcioglu wrote: On 3/4/20 1:18 AM, Fangrui Song wrote: On 2020-03-03, Joseph Myers wrote: On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: Although we discussed after the submission of the first version that there are several other options performing similar tasks,

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 1:18 AM, Fangrui Song wrote: On 2020-03-03, Joseph Myers wrote: On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: Although we discussed after the submission of the first version that there are several other options performing similar tasks, I believe we established that there is still

Re: [RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-04 Thread Martin Sebor
On 3/4/20 8:54 AM, Jeff Law wrote: Martin, I'd like your thoughts here. As noted in the BZ our #pragmas aren't working to suppress a warning. I did some debugging and ultimately found that the location passed down to the diagnostic code is indeed outside the scope of the pragmas. Further

Re: [committed] analyzer: detect malloc, free, calloc within "std" [PR93959]

2020-03-04 Thread David Malcolm
On Wed, 2020-03-04 at 11:05 -0500, Marek Polacek wrote: > On Wed, Mar 04, 2020 at 04:54:54PM +0100, Bernhard Reutner-Fischer > wrote: > > On Mon, 2 Mar 2020 16:48:26 -0500 > > David Malcolm wrote: > > > > > +static inline bool > > > +is_std_function_p (const_tree fndecl) > > > +{ > > > + tree

Re: [committed] analyzer: detect malloc, free, calloc within "std" [PR93959]

2020-03-04 Thread David Malcolm
On Wed, 2020-03-04 at 16:54 +0100, Bernhard Reutner-Fischer wrote: > On Mon, 2 Mar 2020 16:48:26 -0500 > David Malcolm wrote: > > > +static inline bool > > +is_std_function_p (const_tree fndecl) > > +{ > > + tree name_decl = DECL_NAME (fndecl); > > + if (!name_decl) > > +return false; > >

Re: [committed] analyzer: detect malloc, free, calloc within "std" [PR93959]

2020-03-04 Thread Marek Polacek
On Wed, Mar 04, 2020 at 04:54:54PM +0100, Bernhard Reutner-Fischer wrote: > On Mon, 2 Mar 2020 16:48:26 -0500 > David Malcolm wrote: > > > +static inline bool > > +is_std_function_p (const_tree fndecl) > > +{ > > + tree name_decl = DECL_NAME (fndecl); > > + if (!name_decl) > > +return

[committed] analyzer: handle __builtin_expect [PR93993]

2020-03-04 Thread David Malcolm
The false warning: pr93993.f90:19:0: 19 | allocate (tm) ! { dg-warning "dereference of possibly-NULL" } | Warning: dereference of possibly-NULL ‘_6’ [CWE-690] [-Wanalyzer-possible-null-dereference] in the reproducer for PR analyzer/93993 is due to a BUILTIN_EXPECT in the chain of

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 4:34 PM, Andreas Schwab wrote: On Mär 04 2020, Richard Biener wrote: --record-gcc-command-line is not a FSF GCC option, there's -frecord-gcc-switches though which --record-gcc-command-line is translated to -frecord-gcc-switches by the driver. That happens for all double-dash

[committed] analyzer: fix ICE on non-lvalue in prune_for_sm_diagnostic [PR93993]

2020-03-04 Thread David Malcolm
PR analyzer/93993 reports another ICE within diagnostic_manager::prune_for_sm_diagnostic in which the expression of interest becomes a non-lvalue (similar to PR 93544, PR 93647, and PR 93950), due to attempting to get an lvalue for a non-lvalue with a NULL context, leading to an ICE when the

[committed] analyzer: remove unused private fields

2020-03-04 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as 13e3ba14eccc0b1ccf1ba9de90443ec7e524f2a6. gcc/analyzer/ChangeLog: * engine.cc (worklist::worklist): Remove unused field m_eg. (class viz_callgraph_edge): Remove unused field m_call_sedge.

Re: [committed] analyzer: detect malloc, free, calloc within "std" [PR93959]

2020-03-04 Thread Bernhard Reutner-Fischer
On Mon, 2 Mar 2020 16:48:26 -0500 David Malcolm wrote: > +static inline bool > +is_std_function_p (const_tree fndecl) > +{ > + tree name_decl = DECL_NAME (fndecl); > + if (!name_decl) > +return false; > + if (!DECL_CONTEXT (fndecl)) > +return false; > + if (TREE_CODE (DECL_CONTEXT

[RFA/RFC] [tree-optimization/91890] [P1 Regression] Avoid clobbering useful location in Wrestrict code

2020-03-04 Thread Jeff Law
Martin, I'd like your thoughts here. As noted in the BZ our #pragmas aren't working to suppress a warning. I did some debugging and ultimately found that the location passed down to the diagnostic code is indeed outside the scope of the pragmas. Further digging uncovered that we had a

[PATCH] libstdc++: Workaround is_trivially_copyable (PR 94013)

2020-03-04 Thread Jonathan Wakely
Several algorithms check the is_trivially_copyable trait to decide whether to dispatch to memmove or memcmp as an optimization. Since r271435 (CWG DR 2094) the trait is true for volatile-qualified scalars, but we can't use memmove or memcmp when the type is volatile. We need to also check for

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Andreas Schwab
On Mär 04 2020, Richard Biener wrote: > --record-gcc-command-line is not a FSF GCC option, there's > -frecord-gcc-switches though which --record-gcc-command-line is translated to -frecord-gcc-switches by the driver. That happens for all double-dash options that match an -f option. Andreas. --

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 10:00 AM, Richard Biener wrote: On Tue, Mar 3, 2020 at 5:41 PM Egeyar Bagcioglu wrote: This patch is for .GCC.command.line sections in LTO objects to be copied into the final objects as in the following example: [egeyar@localhost lto]$ gcc -flto -O3 demo.c -c -g

Re: [PING][PATCH][GCC][ARM] Arm generates out of range conditional branches in Thumb2 (PR91816)

2020-03-04 Thread Kyrill Tkachov
On 3/4/20 2:14 PM, Tamar Christina wrote: Hi Kyrill, Ok for backporting this patch to GCC 8 and GCC 9? Ok assuming bootstrap and test shows no problems. Thanks, Kyrill Thanks, Tamar -Original Message- From: gcc-patches-ow...@gcc.gnu.org On Behalf Of Kyrill Tkachov Sent:

RE: [PING][PATCH][GCC][ARM] Arm generates out of range conditional branches in Thumb2 (PR91816)

2020-03-04 Thread Tamar Christina
Hi Kyrill, Ok for backporting this patch to GCC 8 and GCC 9? Thanks, Tamar > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org > On Behalf Of Kyrill Tkachov > Sent: Thursday, January 30, 2020 14:55 > To: Stam Markianos-Wright ; gcc- > patc...@gcc.gnu.org > Cc: ni...@redhat.com;

Re: ACLE intrinsics: BFloat16 load intrinsics for AArch32

2020-03-04 Thread Delia Burduv
Hi, The previous version of this patch shared part of its code with the store intrinsics patch (https://gcc.gnu.org/ml/gcc-patches/2020-03/msg00145.html) so I removed any duplicated code. This patch now depends on the previously mentioned store intrinsics patch. Here is the latest version

RE: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-04 Thread Richard Wai
> -Original Message- > From: Eric Botcazou > Sent: March 4, 2020 6:18 AM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities > > > I'll have to look into this.. Any pointers? This assertion is not a > >

Re: [PATCH] use all same precision in wide_int arguments (PR 93986)

2020-03-04 Thread Richard Biener
On Wed, Mar 4, 2020 at 1:26 AM Martin Sebor wrote: > > On 3/3/20 11:50 AM, Richard Biener wrote: > > On March 3, 2020 4:39:34 PM GMT+01:00, Martin Sebor > > wrote: > >> On 3/3/20 2:42 AM, Richard Biener wrote: > >>> On Tue, Mar 3, 2020 at 12:04 AM Martin Sebor > >> wrote: > > The

[Committed 4/4] IBM Z: zTPF: Include glibc-stdint.h

2020-03-04 Thread Andreas Krebbel
Building a zTPF cross currently fails when building libstdc++ complaining about the __UINTPTR_TYPE__ to be missing. Fixed by including the glibc-stdint.h header. 2020-03-04 Andreas Krebbel * config.gcc: Include the glibc-stdint.h header for zTPF. --- gcc/config.gcc | 2 +- 1 file

[Committed 1/4] IBM Z: zTPF: Add tpf trace customization options

2020-03-04 Thread Andreas Krebbel
The zTPF OS implements a tracing facility for function entry and exit which uses global flags and trace function addresses. The addresses of the flags as well as the trace functions are currently hard-coded in the zTPF specific GCC parts of the IBM Z back-end. With this patch these addresses can

[Committed 3/4] IBM Z: zTPF: Prevent FPR usage

2020-03-04 Thread Andreas Krebbel
For the zTPF we must not use floating point registers. gcc/ChangeLog: 2020-03-04 Andreas Krebbel * config/s390/s390.c (s390_secondary_memory_needed): Disallow direct FPR-GPR copies. (s390_register_info_gprtofpr): Disallow GPR content to be saved in FPRs. ---

[Committed 2/4] IBM Z: zTPF: Build libgcc with -mtpf-trace-skip

2020-03-04 Thread Andreas Krebbel
libgcc is supposed to be built with the trace skip flags and branch targets. Add a zTPF header file fragment and add the -mtpf-trace-skip option. libgcc/ChangeLog: 2020-03-04 Andreas Krebbel * config.host: Include the new makefile fragment. * config/s390/t-tpf: New file. ---

Re: [PATCH] sccvn: Fix handling of POINTER_PLUS_EXPR in memset offset [PR93582]

2020-03-04 Thread Richard Biener
On Wed, 4 Mar 2020, Jakub Jelinek wrote: > Hi! > > On Wed, Mar 04, 2020 at 11:33:06AM +0100, Richard Biener wrote: > > > where POINTER_PLUS_EXPR last operand has sizetype type, thus unsigned, > > > and in the testcase gimple_assign_rhs2 (def) is thus 0xf001ULL > > > which multiplied

[PATCH] sccvn: Fix handling of POINTER_PLUS_EXPR in memset offset [PR93582]

2020-03-04 Thread Jakub Jelinek
Hi! On Wed, Mar 04, 2020 at 11:33:06AM +0100, Richard Biener wrote: > > where POINTER_PLUS_EXPR last operand has sizetype type, thus unsigned, > > and in the testcase gimple_assign_rhs2 (def) is thus 0xf001ULL > > which multiplied by 8 doesn't fit into signed HWI. If it would be

Re: [PATCH] Add -fcommon to a test-case to re-trigger it.

2020-03-04 Thread Jakub Jelinek
On Wed, Mar 04, 2020 at 12:53:58PM +0100, Martin Liška wrote: > Hi. > > I've noticed during working on VEC_COND_EXPR, that code added in > r10-2910-g9151048d854e352a9b83b771c6711b8221c73f7e is not executed. > It's also seen on our LCOV instance: >

[PATCH] Add -fcommon to a test-case to re-trigger it.

2020-03-04 Thread Martin Liška
Hi. I've noticed during working on VEC_COND_EXPR, that code added in r10-2910-g9151048d854e352a9b83b771c6711b8221c73f7e is not executed. It's also seen on our LCOV instance: https://users.suse.com/~mliska/lcov/gcc/optabs.c.gcov.html line 5889. It started with the revision where we changed

Re: [PATCH] inliner: Copy DECL_BY_REFERENCE in copy_decl_to_var [PR93888]

2020-03-04 Thread Richard Biener
On March 3, 2020 9:13:01 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >In the following testcase we emit wrong debug info for the karg >parameter in the DW_TAG_inlined_subroutine into main. >The problem is that the karg PARM_DECL is DECL_BY_REFERENCE and thus >in the IL has const K & type, but in

Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-04 Thread Eric Botcazou
> I'll have to look into this.. Any pointers? This assertion is not a language > rule assertion. Of course, neither of the 117 assertions in gcc-interface is, instead they are assertions meant to prevent wrong-code generation from occuring. > As you see, the assertion being modified already

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-04 Thread Kewen.Lin
on 2020/3/4 下午3:24, binbin wrote: > Hi > > On 2020/3/4 上午8:33, Segher Boessenkool wrote: >> Hi! >> >> On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote: >>> Rewrite the declaration of toc_section from the source file rs6000.c to its >>> header file for standardizing the code. >> >>> diff

Re: [PATCH] sccvn: Avoid overflows in push_partial_def

2020-03-04 Thread Richard Biener
On Tue, 3 Mar 2020, Jakub Jelinek wrote: > Hi! > > The following patch attempts to avoid dangerous overflows in the various > push_partial_def HOST_WIDE_INT computations. > This is achieved by performing the subtraction offset2i - offseti in > the push_partial_def function and before doing that

[PATCH] tree-optimization/93964 - adjust ISL code generation for pointer params

2020-03-04 Thread Richard Biener
Pointers eventually need intermediate conversions in code generation. Allowing them is much easier than fending them off since niter and scev expansion easily drag those in. Bootstrapped / tested on x86_64-unknown-linux-gnu, pushed. Richard. 2020-02-03 Richard Biener PR

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-04 Thread Martin Liška
On 3/3/20 3:44 PM, Egeyar Bagcioglu wrote: Hello, Hi. I would like to propose the second version of the patches which introduce a compile option --record-gcc-command-line. When passed to gcc, it saves the command line invoking gcc into the produced object file. The option makes it

Re: [PATCH 1/3] [ARC] Remove mmixed-code option.

2020-03-04 Thread Richard Biener
On Wed, Mar 4, 2020 at 9:52 AM Claudiu Zissulescu wrote: > > I will rework the patches preserving the option. Shall I add a deprecate > message as well? There's no need for that I think. Richard. > //Claudiu > > From: Jeff Law > Sent: Tuesday, March 3, 2020

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Richard Biener
On Tue, Mar 3, 2020 at 5:41 PM Egeyar Bagcioglu wrote: > > This patch is for .GCC.command.line sections in LTO objects to be copied > into the final objects as in the following example: > > [egeyar@localhost lto]$ gcc -flto -O3 demo.c -c -g --record-gcc-command-line > [egeyar@localhost lto]$ gcc

Re: [PATCH 1/3] [ARC] Remove mmixed-code option.

2020-03-04 Thread Claudiu Zissulescu
I will rework the patches preserving the option. Shall I add a deprecate message as well? //Claudiu From: Jeff Law Sent: Tuesday, March 3, 2020 7:00 PM To: Richard Biener ; Claudiu Zissulescu Cc: GCC Patches ; Francois Bedard ; Claudiu Zissulescu ; Andrew

Re: [PATCH] [COMMITTED] arc: Add ARC entry for gcc-10/changes.html

2020-03-04 Thread Claudiu Zissulescu
Done  Thank you for your review, Claudiu From: Martin Sebor Sent: Tuesday, March 3, 2020 6:47 PM To: Claudiu Zissulescu ; gcc-patches@gcc.gnu.org Cc: ger...@pfeifer.com ; l...@redhat.com ; Francois Bedard ; Claudiu Zissulescu ; andrew.burg...@embecosm.com

[PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-03-04 Thread Yangfei (Felix)
Hi, This is a simple fix for PR94026. With this fix, combine will try make an extraction if we are in a equality comparison and this is an AND with a constant which is power of two minus one. Shift here should be an constant. For example, combine will transform (compare (and