[PATCH] d: Fix missing dependencies in depfile for imported files (PR93038)

2020-03-21 Thread Iain Buclaw via Gcc-patches
Hi, A new field for tracking imported files was added to the front-end, this makes use of it by writing all such files in the make dependency list, fixing PR 93038. Bootstrapped and tested on x86_64-linux-gnu, and committed to trunk. Regards Iain. --- gcc/d/ChangeLog: 2020-03-22 Iain Buclaw

[committed] libstdc++: Fix experimental::path::generic_string (PR 93245)

2020-03-21 Thread Jonathan Wakely via Gcc-patches
This function was unimplemented, simply returning the native format string instead. PR libstdc++/93245 * include/experimental/bits/fs_path.h (path::generic_string()): * testsuite/experimental/filesystem/path/generic/generic_string.cc: Improve test coverage. Tested

[committed] libstdc++: Fix path::generic_string allocator handling (PR 94242)

2020-03-21 Thread Jonathan Wakely via Gcc-patches
It's not possible to construct a path::string_type from an allocator of a different type. Create the correct specialization of basic_string, and adjust path::_S_str_convert to use a basic_string_view so that it is independent of the allocator type. PR libstdc++/94242 *

Re: [PATCH] avoid -Wredundant-tags on a first declaration in use (PR 93824)

2020-03-21 Thread Martin Sebor via Gcc-patches
On 3/20/20 3:53 PM, Jason Merrill wrote: On 3/19/20 7:55 PM, Martin Sebor wrote: On 3/18/20 9:07 PM, Jason Merrill wrote: On 3/12/20 6:38 PM, Martin Sebor wrote: ... + declarations of a class from its uses doesn't work for type aliases + (as in using T = class C;).  */ Good point. 

[committed] Darwin: Handle NULL DECL_SIZE_TYPE in machopic_select_section (PR94237).

2020-03-21 Thread Iain Sandoe
Hi, A recent change in the LTO streaming arrangement means that it is now possible for machopic_select_section () to be called with a NULL value for DECL_SIZE_TYPE - corresponding to an incomplete or not-yet- laid out type. When section anchors are present, and we are generating assembler, we

[committed] Darwin: Address translation comments (PR93694).

2020-03-21 Thread Iain Sandoe
This updates the options descriptions after feedback from a translator. tested on x86_64-darwin16, applied to master, thanks Iain gcc/ChangeLog: 2020-03-21 Iain Sandoe PR target/93694 * gcc/config/darwin.opt: Amend options descriptions. diff --git

[PATCH d] Committed fix for ICE in add_symbol_to_partition_1 at lto/lto-partition.c:215 (PR94920)

2020-03-21 Thread Iain Buclaw via Gcc-patches
Hi, This patch addresses two problems with TypeInfo initializer generation. 1. D array fields pointing to compiler generated data are referencing public symbols with no unique prefix, which can lead to duplicate definition errors in some hard to reduce cases. To avoid name clashes, all symbols

Re: [Patch][LTO] Set proper DECL_ALIGN in offload_handle_link_vars (PR94233)

2020-03-21 Thread Tobias Burnus
On 3/21/20 8:03 AM, Richard Biener wrote: OK for the trunk? It should be TYPE_ALIGN (type). OK with that change. I am confused. The patch has: + SET_DECL_ALIGN (link_ptr_var, TYPE_ALIGN (ptr_type_node)); which looks correct and to uses already TYPE_ALIGN?!? Note this fails to honor

Re: [PATCH] Darwin: Fix i686 bootstrap when the assembler supports GOTOFF in data.

2020-03-21 Thread Uros Bizjak via Gcc-patches
On Sat, Mar 21, 2020 at 3:21 PM Iain Sandoe wrote: > > Hi, > > When we use an assembler that supports " .long XX@GOTOFF", the current > combination of configuration parameters and conditional compilation > (when building an i686-darwin compiler with mdynamic-no-pic) assume that > it's OK to put

[PATCH] Darwin: Fix i686 bootstrap when the assembler supports GOTOFF in data.

2020-03-21 Thread Iain Sandoe
Hi, When we use an assembler that supports " .long XX@GOTOFF", the current combination of configuration parameters and conditional compilation (when building an i686-darwin compiler with mdynamic-no-pic) assume that it's OK to put jump tables in the .const section. However, when we encounter a

[PATCH] c: Fix up cfun->function_end_locus on invalid function bodies [PR94239]

2020-03-21 Thread Jakub Jelinek via Gcc-patches
Hi! On Thu, Mar 19, 2020 at 09:38:30PM +, Joseph Myers wrote: > The second patch is OK. Unfortunately the patch broke +FAIL: gcc.dg/pr20245-1.c (internal compiler error) +FAIL: gcc.dg/pr20245-1.c (test for excess errors) +FAIL: gcc.dg/pr28419.c (internal compiler error) +FAIL:

[commited][PATCH] Fix comma at end of enumerator list seen with -std=c++98.

2020-03-21 Thread Martin Liška
Hi. The following patch fixes many warnings seen with -std=c++98: include/plugin-api.h:144:16: warning: comma at end of enumerator list [-Wpedantic] Installed as obvious. Martin include/ChangeLog: 2020-03-21 Martin Liska * plugin-api.h (enum ld_plugin_symbol_type): Remove

Re: [Patch][LTO] Set proper DECL_ALIGN in offload_handle_link_vars (PR94233)

2020-03-21 Thread Richard Biener
On March 20, 2020 10:10:54 PM GMT+01:00, Tobias Burnus wrote: >When compiling the existing libgomp.c/target-link-1.c with -O3, the >test case was ICEing as DECL_ALIGN was 1 (alias "1U << 0"). > >The reason is that "make_node (VAR_DECL)" calls "SET_DECL_ALIGN (t, 1)" >and unless one overrides