Re: [PATCH 2/2] arm: Improve handling of relocations with small offsets with -mpure-code on v6m (PR96770)

2020-11-01 Thread Christophe Lyon via Gcc-patches
On Tue, 27 Oct 2020 at 17:22, Richard Earnshaw wrote: > > On 28/09/2020 10:09, Christophe Lyon via Gcc-patches wrote: > > With -mpure-code on v6m (thumb-1), we can use small offsets with > > upper/lower relocations to avoid the extra addition of the > > offset. > > > > This patch accepts expressio

Re: ipa-cp: New debug counters for IPA-CP

2020-11-01 Thread Richard Biener via Gcc-patches
On Fri, Oct 30, 2020 at 7:59 PM Martin Jambor wrote: > > Hi, > > Martin Liška has been asking me to add debug counters to the IPA-CP pass so > that testcase reductions are easier. The pass already has one for the bit > value propagation, so this patch adds one for value_range propagation > and on

Re: [PATCH][PR target/97540] Don't extract memory from operand for normal memory constraint.

2020-11-01 Thread Hongtao Liu via Gcc-patches
On Fri, Oct 30, 2020 at 1:00 AM Richard Sandiford wrote: > > I guess my main objection is that we have a special memory constraint > that isn't in fact matching a MEM (at least not directly). That seems > odd and feels like it's going to come back to bite us. > > From an RTL perspective, the MEM

Re: Avoid char[] array in tree_def

2020-11-01 Thread Richard Biener
On October 31, 2020 11:35:01 PM GMT+01:00, Jan Hubicka wrote: >> On 10/29/20 1:40 PM, Richard Biener wrote: >> > On Thu, 29 Oct 2020, Jakub Jelinek wrote: >> > >> > > On Thu, Oct 29, 2020 at 05:00:40PM +0100, Jan Hubicka wrote: >> > > > > >> > > > > That's ugly and will for sure defeat warning /

Re: [patch] Fixing ppc64 test failure after patch dealing with scratches in IRA

2020-11-01 Thread Vladimir Makarov via Gcc-patches
On 2020-10-30 7:36 p.m., Segher Boessenkool wrote: Thanks for the patch! But it has a problem: diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md index 67e4f2fd037..78de85ccbbb 100644 --- a/gcc/config/rs6000/vsx.md +++ b/gcc/config/rs6000/vsx.md @@ -3717,7 +3717,7 @@ (v

Re: [PATCH] mixing of labels and code in C2X

2020-11-01 Thread Uecker, Martin
Am Montag, den 14.09.2020, 20:30 + schrieb Joseph Myers: > On Sun, 13 Sep 2020, Uecker, Martin wrote: > > > Hi Joseph, > > > > here is the (unfinished) patch to support > > mixing of labels in C2X. > > I think there should be explicit tests for old standard versions  > (c11-labels-1.c etc.)

[pushed] Darwin: Adjust the PCH area to allow for 16384byte page size.

2020-11-01 Thread Iain Sandoe
Hi The new version of Darwin report pagesize 16384 which means that we need to adjust the aligment of the PCH area. tested across the Darwin range (32 and 64 bit hosts) and on x86_64-linux-gnu pushed to master thanks Iain gcc/ChangeLog: * config/host-darwin.c: Align pch_address_space to

[pushed] Objective-C : Implement SEL as a built-in typedef.

2020-11-01 Thread Iain Sandoe
Hi The reference implementation for Objective-C provides the SEL typedef (although it is also available from ). tested on x86_64-darwin, x86_64-linux-gnu pushed thanks Iain gcc/objc/ChangeLog: * objc-act.c (synth_module_prologue): Get the SEL identifier. * objc-act.h (enum objc_

[pushed] Objective-C/C++ : Improve '@' keyword locations.

2020-11-01 Thread Iain Sandoe
Hi When we are lexing tokens for Objective-C, we combine '@' tokens with a following keyword (when that keyword is a valid Objective-C one or, for Objective-C, one of the C++ keywords that can appear in this position). The responsibility is passed on to the parser to validate the resulting combin

[PATCH] Add missing gnu-versioned-namespace symbols

2020-11-01 Thread François Dumont via Gcc-patches
Several tests are failing because of those missing symbols. I understand why we need to export symbols relying in the versioned namespace but I don't understand why we need to do it for _GLIBCXX_DEBUG symbols which are not version namespace dependant. Do you want to backport the Debug symbol

Re: [PATCH] x86: Require MMX for __builtin_ia32_maskmovq

2020-11-01 Thread Uros Bizjak via Gcc-patches
> Since "MASKMOVQ mm1, mm2" is an SSE instruction which requires MMX and > MMX/SSE ISAs are handled separately, make __builtin_ia32_maskmovq require > MMX instead of SSE. > > gcc/ > > PR target/97140 > * config/i386/i386-expand.c (ix86_expand_builtin): Require MMX > for __builtin_ia32_maskmovq. > >

Re: [PATCH] Support the new ("v0") mangling scheme in rust-demangle.

2020-11-01 Thread Nikhil Benesch via Gcc-patches
On 11/1/20 6:57 AM, Eduard-Mihai Burtescu wrote: Reading the diff patch, the v0 changes look great. I wouldn't be too worried about the "printable character" aspect, there are similar Unicode-related issues elsewhere, e.g. the "non-control ASCII" comment in decode_legacy_escape (I suppose we co

Re: [PATCH] ipa: Fix segmentation fault in function_summary::get(cgraph_node*) (PR 97660)

2020-11-01 Thread Jan Hubicka
> Hi, > > PR 97660 occurs when cgraph_node::get returns NULL, and this NULL > cgraph_node is then passed to clone_info::get. As the original assert > prior to the regressing change in r11-4587 allowed for the cgraph_node > to be NULL, clone_info::get is now only called when cgraph_node::get > ret

[pushed] testsuite, X86 : Add target requires masm_intel to three tests.

2020-11-01 Thread Iain Sandoe
Hi These tests currently fail on targets without Intel assembler support. Tested that they are now UNSUPPORTED on x86_64-darwin, which does not have -masm=intel support. pushed to master as trivial/obvious. thanks Iain gcc/testsuite/ChangeLog: * gcc.target/i386/amxbf16-asmintel-1.c: R

[PATCH] ipa: Fix segmentation fault in function_summary::get(cgraph_node*) (PR 97660)

2020-11-01 Thread Iain Buclaw via Gcc-patches
Hi, PR 97660 occurs when cgraph_node::get returns NULL, and this NULL cgraph_node is then passed to clone_info::get. As the original assert prior to the regressing change in r11-4587 allowed for the cgraph_node to be NULL, clone_info::get is now only called when cgraph_node::get returns a nonnull

Re: Move clone_info to summary

2020-11-01 Thread H.J. Lu via Gcc-patches
On Sat, Oct 31, 2020 at 2:22 AM Jan Hubicka wrote: > > Hi, > this patch moves clone_info to summary. > Bootstrapped/regtested x86_64-linux, comitted. > > Honza > > 2020-10-31 Jan Hubicka > > * Makefile.in: (OBJS): Add symtab-clones.o > (GTFILES): Add symtab-clones.h > *

Re: Move clone_info to summary

2020-11-01 Thread H.J. Lu via Gcc-patches
On Sat, Oct 31, 2020 at 2:22 AM Jan Hubicka wrote: > > Hi, > this patch moves clone_info to summary. > Bootstrapped/regtested x86_64-linux, comitted. > > Honza > > 2020-10-31 Jan Hubicka > > * Makefile.in: (OBJS): Add symtab-clones.o > (GTFILES): Add symtab-clones.h > *

Re: [PATCH] Support the new ("v0") mangling scheme in rust-demangle.

2020-11-01 Thread Eduard-Mihai Burtescu
Reading the diff patch, the v0 changes look great. I wouldn't be too worried about the "printable character" aspect, there are similar Unicode-related issues elsewhere, e.g. the "non-control ASCII" comment in decode_legacy_escape (I suppose we could make it also go through the "print a non-control

Re: wchar_t does not satisfy std::integral concept on DJGPP MSDOS toolchains

2020-11-01 Thread Jonathan Wakely via Gcc-patches
On 01/11/20 10:03 +, Jonathan Wakely wrote: On 31/10/20 22:21 +, sotrdg sotrdg via Libstdc++ wrote: Please fix it. It's determined by the result of the GLIBCXX_ENABLE_WCHAR_T checks in libstdc++-v3/acinclude.m4 djgpp must be missing some wchar_t library support. This patch makes som

Re: [PATCH] Support the new ("v0") mangling scheme in rust-demangle.

2020-11-01 Thread Nikhil Benesch via Gcc-patches
On 10/29/20 12:16 AM, Nikhil Benesch wrote: On Wed, Oct 28, 2020 at 7:53 PM Eduard-Mihai Burtescu wrote: I agree that landing the extra changes later on top should be fine anyway, though when I make the sprintf -> snprintf change, I could provide the extra changes as well (either as a combine