Re: [C PATCH] Drop qualifiers during lvalue conversion

2020-11-23 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 19 Nov 2020 at 07:34, Uecker, Martin wrote: > > > > Here is another version of the patch. The > only difference is the additional the check > using 'tree_ssa_useless_type_conversion'. > > > Best, > Martin > > > > > C: Drop qualifiers during lvalue conversion. PR97702 > >

Re: [PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-11-23 Thread Iain Sandoe
Jason Merrill wrote: On 11/7/20 10:11 AM, Iain Sandoe wrote: + warning_at (token1->location, OPT_Wattributes, "attributes are" + " only permitted in this position for Objective-C++," + " ignored"); It would be nice for the

[PATCH] middle-end, c++: Treat shifts by negative as undefined [PR96929]

2020-11-23 Thread Jakub Jelinek via Gcc-patches
Hi! The PR38359 change made the -1 >> x to -1 optimization less useful by requiring that the x must be non-negative. Shifts by negative amount are UB, but we for historic reasons had in some (but not all) places some hack to treat shifts by negative value as the other direction shifts by the

[PATCH] fix hybrid SLP discovery debug stmt issue

2020-11-23 Thread Richard Biener
This properly skips debug USE_STMTs when looking for non-SLP sinks. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2020-11-23 Richard Biener * tree-vect-slp.c (maybe_push_to_hybrid_worklist): Skip debug stmts. * g++.dg/vect/simd-12.cc: New

Re: Do not leak memory when streaming in ssa names

2020-11-23 Thread Richard Biener
On Mon, 23 Nov 2020, Jan Hubicka wrote: > > On Mon, 23 Nov 2020, Jan Hubicka wrote: > > > > > > On Mon, 23 Nov 2020, Jan Hubicka wrote: > > > > > > > > > Hi, > > > > > tree-streamer-in currently calls init_tree_ssa that calls > > > > > init_ssanames > > > > > that allocates space in ssa_names

Re: Do not leak memory when streaming in ssa names

2020-11-23 Thread Jan Hubicka
> > On Mon, 23 Nov 2020, Jan Hubicka wrote: > > > > > > On Mon, 23 Nov 2020, Jan Hubicka wrote: > > > > > > > > > Hi, > > > > > tree-streamer-in currently calls init_tree_ssa that calls > > > > > init_ssanames > > > > > that allocates space in ssa_names array for 50 names. Later it > > > > >

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2020-11-23 Thread Martin Liška
On 11/23/20 12:00 PM, Richard Biener wrote: Can you split out the unifying of -[gf]record-gcc-switches processing and the target hook adjustment from the change introducing -frecord-gcc-switches-format? Sure. dwarf2out.c seems to retain its gen_producer_string () even though you duplicate

Re: Do not leak memory when streaming in ssa names

2020-11-23 Thread Jan Hubicka
> On Mon, 23 Nov 2020, Jan Hubicka wrote: > > > > On Mon, 23 Nov 2020, Jan Hubicka wrote: > > > > > > > Hi, > > > > tree-streamer-in currently calls init_tree_ssa that calls init_ssanames > > > > that allocates space in ssa_names array for 50 names. Later it streams > > > > in the count and

Re: Do not leak memory when streaming in ssa names

2020-11-23 Thread Richard Biener
On Mon, 23 Nov 2020, Jan Hubicka wrote: > > On Mon, 23 Nov 2020, Jan Hubicka wrote: > > > > > Hi, > > > tree-streamer-in currently calls init_tree_ssa that calls init_ssanames > > > that allocates space in ssa_names array for 50 names. Later it streams > > > in the count and calls init_tree_ssa

Re: Do not leak memory when streaming in ssa names

2020-11-23 Thread Jan Hubicka
> On Mon, 23 Nov 2020, Jan Hubicka wrote: > > > Hi, > > tree-streamer-in currently calls init_tree_ssa that calls init_ssanames > > that allocates space in ssa_names array for 50 names. Later it streams > > in the count and calls init_tree_ssa again, this time with correct > > count, which is

Re: Do not leak memory when streaming in ssa names

2020-11-23 Thread Richard Biener
On Mon, 23 Nov 2020, Jan Hubicka wrote: > Hi, > tree-streamer-in currently calls init_tree_ssa that calls init_ssanames > that allocates space in ssa_names array for 50 names. Later it streams > in the count and calls init_tree_ssa again, this time with correct > count, which is rounded up to 50

Re: [PATCH] gcov: Add __gcov_info_to_gdca()

2020-11-23 Thread Sebastian Huber
On 20/11/2020 17:14, Sebastian Huber wrote: On 20/11/2020 16:25, Martin Liška wrote: Apart from these 2 hooks, I bet you will also need gcov_position and gcov_seek functions, can be seen in my sent patch. For what do I need them? I prefer the way with the 2 extra hooks. Can you please

Do not leak memory when streaming in ssa names

2020-11-23 Thread Jan Hubicka
Hi, tree-streamer-in currently calls init_tree_ssa that calls init_ssanames that allocates space in ssa_names array for 50 names. Later it streams in the count and calls init_tree_ssa again, this time with correct count, which is rounded up to 50 and allocated again leaking the first array. This

Re: Add -std=c2x, -std=gnu2x, -Wc11-c2x-compat, C2X _Static_assert support

2020-11-23 Thread Martin Liška
On 10/18/18 1:59 AM, Joseph Myers wrote: - || strcmp (language_string, "GNU C17") == 0) + || strcmp (language_string, "GNU C17") == 0 + || strcmp (language_string, "GNU C2X")) Hello Joseph. Shouldn't this hunk be '|| strcmp (language_string, "GNU

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2020-11-23 Thread Richard Biener via Gcc-patches
On Mon, Nov 23, 2020 at 10:00 AM Martin Liška wrote: > > On 11/20/20 10:49 AM, Richard Biener wrote: > > On Fri, Apr 3, 2020 at 8:15 PM Egeyar Bagcioglu > > wrote: > >> > >> > >> > >> On 3/18/20 10:05 AM, Martin Liška wrote: > >>> On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: > Hi Martin, >

RE: testsuite/arm: add missing -mthumb to several tests

2020-11-23 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Gcc-patches On Behalf Of > Christophe Lyon via Gcc-patches > Sent: 23 November 2020 09:20 > To: gcc Patches > Subject: testsuite/arm: add missing -mthumb to several tests > > Some tests force -mcpu=cortex-mXX but do not add -mthumb, causing > errors if GCC

testsuite/arm: add missing -mthumb to several tests

2020-11-23 Thread Christophe Lyon via Gcc-patches
Some tests force -mcpu=cortex-mXX but do not add -mthumb, causing errors if GCC is not configured to default to Thumb code (--with-mode=thumb): cc1: error: target CPU does not support ARM mode This patch adds -mthumb where relevant. 2020-11-23 Christophe Lyon gcc/testsuite/ *

Re: [PATCH] Additional small changes to support opaque modes

2020-11-23 Thread Richard Sandiford via Gcc-patches
Aaron Sawdey writes: >> On Nov 20, 2020, at 4:57 AM, Aaron Sawdey via Gcc-patches >> wrote: >> >> >>> On Nov 20, 2020, at 3:55 AM, Richard Sandiford >>> wrote: >>> >>> acsawdey--- via Gcc-patches writes: @@ -16767,7 +16768,7 @@ loc_descriptor (rtx rtl, machine_mode mode,

test: Update cases for vect_partial_vectors_usage_1

2020-11-23 Thread Kewen.Lin via Gcc-patches
Hi, I adjusted some vectorization test cases for vect_partial_vectors_usage_1 before, but as exposed in the recent testings, some of them need to be adjusted again. The reason is that the commit r11-3393 improved the epilogue loop handling of partial vectors and we won't use partial vectors to

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2020-11-23 Thread Martin Liška
On 11/20/20 10:49 AM, Richard Biener wrote: On Fri, Apr 3, 2020 at 8:15 PM Egeyar Bagcioglu wrote: On 3/18/20 10:05 AM, Martin Liška wrote: On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: Hi Martin, I like the patch. It definitely serves our purposes at Oracle and provides another way to do

Re: [PATCH] Check calls before loop unrolling

2020-11-23 Thread Richard Biener via Gcc-patches
On Fri, Nov 20, 2020 at 7:11 PM Segher Boessenkool wrote: > > Hi! > > On Fri, Nov 20, 2020 at 04:22:47PM +0100, Jan Hubicka wrote: > > As you know I spend quite some time on inliner heuristics but even after > > the years I have no clear idea how the requirements differs from x86-64 > > to ppc,

Re: [PATCH v3 1/2] generate EH info for volatile asm statements (PR93981)

2020-11-23 Thread Richard Biener via Gcc-patches
On Sun, Nov 22, 2020 at 5:38 PM J.W. Jagersma wrote: > > On 2020-11-21 12:27, J.W. Jagersma wrote: > > ... > > Another idea I had is to introduce a new operand modifier, eg. '-', which > > would signify that the output *must* be considered clobbered on exception, > > and it would be an error if a

Re: [Patch 0/X] HWASAN v4

2020-11-23 Thread Martin Liška
On 11/20/20 7:42 PM, Matthew Malcomson wrote: On 13/11/2020 17:22, Martin Liška wrote: On 11/13/20 5:57 PM, Matthew Malcomson wrote: Hi there, Thanks for the heads-up. As it turns out the most recent `libhwasan` crashes when displaying an address on the stack in Linux. Hello. What a bad

Re: [PATCH] vect: Add a “very cheap” cost model

2020-11-23 Thread Richard Biener via Gcc-patches
On Sat, Nov 21, 2020 at 9:30 PM Jan Hubicka wrote: > > > > I tested this by building and running a bunch of workloads for SVE, > > > with three options: > > > > > > (1) -O2 > > > (2) -O2 -ftree-vectorize -fvect-cost-model=very-cheap > > > (3) -O2 -ftree-vectorize [-fvect-cost-model=cheap] >

<    1   2