Re: [PATCH] Port GCC documentation to Sphinx

2021-07-02 Thread Hans-Peter Nilsson
On Wed, 30 Jun 2021, Eli Zaretskii via Gcc-patches wrote: > > Cc: jos...@codesourcery.com, g...@gcc.gnu.org, gcc-patches@gcc.gnu.org > > From: Martin Li?ka > > Date: Wed, 30 Jun 2021 12:11:03 +0200 > > > 4. Menus lost the short descriptions of the sub-sections. Example: > > > > > >*

Re: [PATCH 2/4] allow poisoning input_location in ranges it should not be used

2021-07-02 Thread Trevor Saunders
On Fri, Jul 02, 2021 at 01:20:14PM -0600, Martin Sebor wrote: > On 6/29/21 11:35 PM, Trevor Saunders wrote: > > This makes it possible to assert if input_location is used during the > > lifetime > > of a scope. This will allow us to find places that currently use it within > > a > > function

Re: [PATCH 2/4] allow poisoning input_location in ranges it should not be used

2021-07-02 Thread Trevor Saunders
On Fri, Jul 02, 2021 at 11:46:46AM -0400, Jason Merrill wrote: > On 7/1/21 6:16 AM, Trevor Saunders wrote: > > On Wed, Jun 30, 2021 at 11:13:23AM -0400, David Malcolm wrote: > > > On Wed, 2021-06-30 at 01:35 -0400, Trevor Saunders wrote: > > > > This makes it possible to assert if input_location

[committed] d: RHS value lost when a target_expr modifies LHS in a cond_expr (PR101282)

2021-07-02 Thread Iain Buclaw via Gcc-patches
Hi, This patch forces a target_expr on the RHS of an assignment when it is a non-POD type. To prevent the RHS of an assignment modifying the LHS before the assignment proper, a target_expr is forced so that function calls that return with slot optimization modify the temporary instead. This

Re: [PING][PATCH 2/4] remove %G and %K from calls in front end and middle end (PR 98512)

2021-07-02 Thread Martin Sebor via Gcc-patches
On 7/2/21 2:52 PM, David Malcolm wrote: ... @@ -11425,10 +11425,10 @@ expand_expr_real_1 (tree exp, rtx target, machine_mode tmode, DECL_ATTRIBUTES (fndecl))) != NULL)   {     const char *ident = lang_hooks.decl_printable_name (fndecl,

Re: [Patch] Fortran: Fix bind(C) character length checks

2021-07-02 Thread Sandra Loosemore
On 7/1/21 11:08 AM, Tobias Burnus wrote: Hi all, this patch came up when discussing Sandra's TS29113 patch internally. There is presumably also some overlap with José's patches. This patch tries to rectify the BIND(C) CHARACTER handling on the diagnostic side, only. That is: what to accept and

Re: [PING][PATCH 2/4] remove %G and %K from calls in front end and middle end (PR 98512)

2021-07-02 Thread Jeff Law via Gcc-patches
On 7/2/2021 12:56 AM, Aldy Hernandez via Gcc-patches wrote: On 7/1/21 10:14 PM, Martin Sebor wrote: On 6/30/21 5:35 PM, David Malcolm wrote: On Wed, 2021-06-30 at 13:45 -0600, Martin Sebor wrote: On 6/30/21 9:39 AM, Martin Sebor wrote: @@ -90,8 +90,8 @@ NOIPA void warn_g2 (struct A

Re: [PING][PATCH 2/4] remove %G and %K from calls in front end and middle end (PR 98512)

2021-07-02 Thread David Malcolm via Gcc-patches
On Thu, 2021-07-01 at 14:14 -0600, Martin Sebor wrote: > On 6/30/21 5:35 PM, David Malcolm wrote: > > On Wed, 2021-06-30 at 13:45 -0600, Martin Sebor wrote: > > > On 6/30/21 9:39 AM, Martin Sebor wrote: > > > > Ping.  Attached is the same patch rebased on top the latest > > > > trunk. > > > > > >

openmp: Initial support for OpenMP directives expressed as C++11 attributes

2021-07-02 Thread Jakub Jelinek via Gcc-patches
Hi! This is an OpenMP 5.1 feature, but I think it is something very useful for OpenMP users, so I'm committing it now instead of waiting until all 5.0 work is done. The support is incomplete, only attributes on statements (or block local declarations) are supported right now, while for

[committed] openmp: Reject #pragma omp atomic update, [PR101297]

2021-07-02 Thread Jakub Jelinek via Gcc-patches
Hi! I've noticed that we allow a trailing comma on OpenMP atomic construct if there is at least one clause. Commas should be only allowed to separate the clauses (or in OpenMP 5.1 to separate directive name from the clauses). Bootstrapped/regtested on x86_64-linux and i686-linux, committed to

Backports to gcc 11 branch (analyzer and jit)

2021-07-02 Thread David Malcolm via Gcc-patches
I've cherrypicked the following commits from trunk to the gcc 11 branch: analyzer: fix ICE on NULL change.m_expr [PR100244] analyzer: fix missing leak after call to strsep [PR100615] diagnostic-show-locus: tweak rejection logic analyzer: show types for poisoned_svalue and

[PATCH] handle sanitizer built-ins in -Wuninitialized (PR 101300)

2021-07-02 Thread Martin Sebor via Gcc-patches
To avoid a class of false negatives for sanitized code -Wuninitialized recognizes the ASAN_MARK internal function doesn't modify its argument. But the warning code doesn't do the same for any sanitizer built-ins even though they don't modify user-supplied arguments either. This leaves another

Re: [PATCH 2/4] allow poisoning input_location in ranges it should not be used

2021-07-02 Thread Martin Sebor via Gcc-patches
On 6/29/21 11:35 PM, Trevor Saunders wrote: This makes it possible to assert if input_location is used during the lifetime of a scope. This will allow us to find places that currently use it within a function and its callees, or prevent adding uses within the lifetime of a function after all

Re: [PATCH] rs6000: Add MMA __builtin_vsx_lxvp and __builtin_vsx_stxvp built-ins

2021-07-02 Thread Peter Bergner via Gcc-patches
On 7/1/21 2:48 PM, Peter Bergner wrote: > On 7/1/21 1:01 PM, Segher Boessenkool wrote: >> The patch is okay for trunk. > > Below is the updated patch which is bootstrapping now. I'll commit it > if it shows no regressions. Testing was clean so I pushed it to trunk. >> For the backports it is

[r12-1970 Regression] FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 1 on Linux/x86_64

2021-07-02 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 73494401241b183ca188954a035734fcc53d97de is the first bad commit commit 73494401241b183ca188954a035734fcc53d97de Author: liuhongt Date: Wed Jun 30 17:10:44 2021 +0800 Fix typo in standard pattern name of trunc2. caused FAIL: gcc.target/i386/pr92658-avx512vl.c

Re: [PATCH] add -fmove-loop-stores option to control GIMPLE loop store-motion

2021-07-02 Thread Martin Sebor via Gcc-patches
On 7/2/21 5:55 AM, Richard Biener wrote: This adds the -fmove-loop-stores option, mainly as a way to disable the store-motion part of GIMPLE invariant motion (-ftree-loop-im) which is enabled by default. It might be sensible to turn off -fmove-loop-stores at -O1 since it can result in

[PATCH] Don't use vec_duplicate on vector in CTOR expansion

2021-07-02 Thread H.J. Lu via Gcc-patches
Since vec_duplicate only works on scalar, don't use it on vector in store constructor expansion. gcc/ PR middle-end/101294 * expr.c (store_constructor): Don't use vec_duplicate on vector. gcc/testsuite/ PR middle-end/101294 * gcc.dg/pr101294.c: New test. ---

[RFA] Attach MEM_EXPR information when flushing BLKmode args to the stack

2021-07-02 Thread Jeff Law
This is a minor missed optimization we found with our internal port. Given this code: typedef struct {short a; short b;} T; extern void g1(); void f(T s) {     if (s.a < 0)     g1(); } "s" is passed in a register, but it's still a BLKmode object because the alignment of T

[committed] Use shift instructions to eliminate redundant compare/test instructions on the H8

2021-07-02 Thread Jeff Law via Gcc-patches
Shift instructions set ZN in the expected ways, *but* the H8's shifter, particularly in the older variants is quite limited.   THere's no variable shift and some variants can only shift 2 or even just 1 bit at a time. Naturally the port tries to mitigate the cost of the limited shifter. 

Re: [PATCH 2/4] allow poisoning input_location in ranges it should not be used

2021-07-02 Thread Jason Merrill via Gcc-patches
On 7/1/21 6:16 AM, Trevor Saunders wrote: On Wed, Jun 30, 2021 at 11:13:23AM -0400, David Malcolm wrote: On Wed, 2021-06-30 at 01:35 -0400, Trevor Saunders wrote: This makes it possible to assert if input_location is used during the lifetime of a scope.  This will allow us to find places that

[COMMITTED] tree-optimization/101223 - Fix build_gt and build_lt for signed 1 bit values.

2021-07-02 Thread Andrew MacLeod via Gcc-patches
These 2 routines were adding and subtracting 1 to a range bound, and checking for overflow. Signed 1 bit values have a range of [-1, 0]. Adding or subtracting 1 cannot be properly represented resulting in the overflow being set.  This caused us to set UNDEFINED when we shouldn't. This patch

Re: [PATCH] PING implement pre-c++20 contracts

2021-07-02 Thread Andrew Sutton via Gcc-patches
I think so, yes. On Fri, Jul 2, 2021 at 11:09 AM Jason Merrill wrote: > > On 7/1/21 12:27 PM, Andrew Sutton wrote: > >>> I think this version addresses most of your concerns. > >> > >> Thanks, looking good. I'll fuss with it a bit and commit it soon. > > Do you agree that this testcase should

[committed] Preparing to use shifts to eliminate more redundant test/compare insns on H8

2021-07-02 Thread Jeff Law via Gcc-patches
This is just preparatory work to use shifts to eliminate test/compare insns on the H8.  Like other patches I've recently done on the H8 port, this converts several patterns to use an iterator rather than a match_operator.  It doesn't allow much simplification of shifts, but it does make them

[PATCH] [contrib] Remove broken compareSumTests3 script

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi Matthew, Hi Sebastian, This patch removes compareSumTests3, which appears to be broken. It tries to call compareSumFiles(), which is nowhere to be found and was never present in the GCC repo. OK to remove? Regards, -- Maxim Kuvyrkov https://www.linaro.org

Re: [PATCH] PING implement pre-c++20 contracts

2021-07-02 Thread Jason Merrill via Gcc-patches
On 7/1/21 12:27 PM, Andrew Sutton wrote: I think this version addresses most of your concerns. Thanks, looking good. I'll fuss with it a bit and commit it soon. Do you agree that this testcase should compile? >From 85400e1896a188892b1ebeb0c8e86ff3cd28cfa6 Mon Sep 17 00:00:00 2001 From:

[pushed] Darwin, CTF, BTF: Do not run the DWARF debug link for BTF/CTF [PR101283].

2021-07-02 Thread Iain Sandoe
Hi Darwin uses an efficient two-stage process for debug linking. The static linker (ld64) notes the inputs required but does not link the debug. When required / on demand the debug is linked into a separate package by the debug linker (dsymutil). At present none of the Darwin tools consume or

Re: [PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
> On Jul 2, 2021, at 5:44 PM, Christophe Lyon > wrote: > > > > On Fri, Jul 2, 2021 at 4:29 PM Jakub Jelinek via Gcc-patches > wrote: > On Fri, Jul 02, 2021 at 05:20:33PM +0300, Maxim Kuvyrkov wrote: > > Hi Jakub, > > > > Thanks for helping me on IRC with debugging testsuite problems.

[pushed] Darwin, BTF: Provide a suitable section name for BTF [PR101283].

2021-07-02 Thread Iain Sandoe
Hi, In a similar manner to r12-1960-gcc8453012f75d, this provides a placeholder section name for BTF data. This change groups BTF and CTF debug formats in the same segment, but keeps them in separate sections. As per the CTF section designation, this should be agreed or amended to an agreed

[committed] Fix m32r target specific fallout from recent int->bool changes

2021-07-02 Thread Jeff Law via Gcc-patches
And finally, the same for m32r.  Committed to the trunk, Jeff commit f6aa1c34e4a89c8c93518c49a108f3c43b78ea47 Author: Jeff Law Date: Fri Jul 2 10:48:26 2021 -0400 Fix m32r target specific fallout from recent int->bool changes gcc/ChangeLog *

[committed] Fix frv target specific fallout from recent int->bool changes

2021-07-02 Thread Jeff Law via Gcc-patches
More light fallout from Uros's work. Committed to the trunk. Jeff commit ef9cc434a476954b5ef3493955d4e668338990c2 Author: Jeff Law Date: Fri Jul 2 10:37:52 2021 -0400 Fix frv target specific fallout from recent int->bool changes gcc/ChangeLog *

Re: [PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Christophe Lyon via Gcc-patches
On Fri, Jul 2, 2021 at 4:29 PM Jakub Jelinek via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > On Fri, Jul 02, 2021 at 05:20:33PM +0300, Maxim Kuvyrkov wrote: > > Hi Jakub, > > > > Thanks for helping me on IRC with debugging testsuite problems. Does > this write up look good? > > Hi Maxim,

[committed] Fix xstormy16 target specific fallout from recent int->bool changes

2021-07-02 Thread Jeff Law via Gcc-patches
As expected there is light fallout from the recent int->bool changes from Uros.  This patch fixes the xstormy16 port in the obvious way. Committed to the trunk, Jeff commit a6fef2e1b6d7e8cea0c0489496cc8f96391200c6 Author: Jeff Law Date: Fri Jul 2 10:31:31 2021 -0400 Fix xstormy16 target

Re: [PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Jakub Jelinek via Gcc-patches
On Fri, Jul 02, 2021 at 05:20:33PM +0300, Maxim Kuvyrkov wrote: > Hi Jakub, > > Thanks for helping me on IRC with debugging testsuite problems. Does this > write up look good? LGTM, thanks. Jakub

[PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi Jakub, Thanks for helping me on IRC with debugging testsuite problems. Does this write up look good? Regards, -- Maxim Kuvyrkov https://www.linaro.org 0001-Add-description-of-how-testsuite-parallelization-wor.patch Description: Binary data

Re: [PATCH 0/4] openacc: Async fixes

2021-07-02 Thread Julian Brown
On Wed, 30 Jun 2021 11:40:33 +0100 Julian Brown wrote: > On Wed, 30 Jun 2021 10:28:00 +0200 > Thomas Schwinge wrote: > > > > - The OpenACC profiling-interface implementation did not measure > > >asynchronous operations properly. > > > > We'll need to be careful: (possibly, an older

Re: [PATCH] Port GCC documentation to Sphinx

2021-07-02 Thread Martin Liška
On 7/2/21 12:31 PM, Eli Zaretskii wrote: Cc: jos...@codesourcery.com, g...@gcc.gnu.org, gcc-patches@gcc.gnu.org From: Martin Liška Date: Fri, 2 Jul 2021 11:30:02 +0200 So the purpose of having the comma there is to avoid having a period in the middle of a sentence, which is added by makeinfo

Re: [PATCH 1/2] Implement basic block path solver.

2021-07-02 Thread Andrew MacLeod via Gcc-patches
On 7/2/21 4:13 AM, Aldy Hernandez wrote: + +// Return the range of STMT as it would be seen at the end of the path +// being analyzed.  Anything but the final conditional in a BB will +// return VARYING. + +void +path_solver::range_in_path (irange , gimple *stmt) +{ +  if (gimple_code (stmt) ==

[PATCH] add -fmove-loop-stores option to control GIMPLE loop store-motion

2021-07-02 Thread Richard Biener
This adds the -fmove-loop-stores option, mainly as a way to disable the store-motion part of GIMPLE invariant motion (-ftree-loop-im) which is enabled by default. It might be sensible to turn off -fmove-loop-stores at -O1 since it can result in compile-time as well as memory usage issues but this

[PATCH] tree-optimization/101293 - further enhance LIMs ref canonicalization

2021-07-02 Thread Richard Biener
This makes sure to handle MEM[p + 4] and MEM[p].j with j at offset 4 as the same ref in store motion. For hashing we need to be more restrictive in what we handle since there's no poly-int handlers for inchash. For comparison we can compare poly_offsets directly. Bootstrapped and tested on

Re: [PATCH 58/62] AVX512FP16: Optimize for code like (_Float16) __builtin_ceif ((float) f16).

2021-07-02 Thread Bernhard Reutner-Fischer via Gcc-patches
On 2 July 2021 09:36:54 CEST, Richard Biener via Gcc-patches wrote: >On Thu, Jul 1, 2021 at 11:26 PM Joseph Myers >wrote: >> >> On Thu, 1 Jul 2021, liuhongt via Gcc-patches wrote: >> >> > +/* Optimize for code like (_Float16) __builtin_ceif ((float) f16) >> > + since it's not handled in

[committed] libstdc++: Revert changes to std::unique_ptr::operator[] [PR 101271]

2021-07-02 Thread Jonathan Wakely via Gcc-patches
On 28/06/21 14:24 +0100, Jonathan Wakely wrote: PR libstdc++/101236 shows that LLVM depends on being able to use unique_ptr::operator[] when T is incomplete. This is undefined, but previously worked with libstdc++. When I added the conditional noexcept to that operator we started to diagnose the

Re: [PATCH] [i386] Remove rex64suffix for v?cvtt?(ss|sd)*2si

2021-07-02 Thread Hongyu Wang via Gcc-patches
Uros Bizjak 于2021年7月2日周五 下午7:07写道: > > On Fri, Jul 2, 2021 at 12:48 PM Hongyu Wang wrote: > > > > > > > > On Fri, Jul 2, 2021 at 10:30 AM Hongyu Wang wrote: > > > > > > > > Hi, > > > > > > > > For instructions like cvtss2si, there is no need to output the 'l' > > > > or 'q' suffixes just like

Re: [PATCH] [i386] Remove rex64suffix for v?cvtt?(ss|sd)*2si

2021-07-02 Thread Uros Bizjak via Gcc-patches
On Fri, Jul 2, 2021 at 12:48 PM Hongyu Wang wrote: > > > > > On Fri, Jul 2, 2021 at 10:30 AM Hongyu Wang wrote: > > > > > > Hi, > > > > > > For instructions like cvtss2si, there is no need to output the 'l' > > > or 'q' suffixes just like cvtss2usi, since the output operand is always > > >

Re: [PATCH] [i386] Remove rex64suffix for v?cvtt?(ss|sd)*2si

2021-07-02 Thread Hongyu Wang via Gcc-patches
> > On Fri, Jul 2, 2021 at 10:30 AM Hongyu Wang wrote: > > > > Hi, > > > > For instructions like cvtss2si, there is no need to output the 'l' > > or 'q' suffixes just like cvtss2usi, since the output operand is always > > register and those suffixes are only used to distinguish ambiguous > >

Re: [PATCH] Port GCC documentation to Sphinx

2021-07-02 Thread Eli Zaretskii via Gcc-patches
> Cc: Eli Zaretskii , g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, > jos...@codesourcery.com > From: Martin Liška > Date: Fri, 2 Jul 2021 11:40:06 +0200 > > > It must > > look sensible without that. In this case it seems that already the > > generated .texinfo input to makeinfo is bad, where

Re: [PATCH] Port GCC documentation to Sphinx

2021-07-02 Thread Eli Zaretskii via Gcc-patches
> Cc: jos...@codesourcery.com, g...@gcc.gnu.org, gcc-patches@gcc.gnu.org > From: Martin Liška > Date: Fri, 2 Jul 2021 11:30:02 +0200 > > > So the purpose of having the comma there is to avoid having a period > > in the middle of a sentence, which is added by makeinfo (because the > > Info

[PATCH] gcc: Add vec_select -> subreg RTL simplification

2021-07-02 Thread Jonathan Wright via Gcc-patches
Hi, As subject, this patch adds a new RTL simplification for the case of a VEC_SELECT selecting the low part of a vector. The simplification returns a SUBREG. The primary goal of this patch is to enable better combinations of Neon RTL patterns - specifically allowing generation of 'write-to-

Re: [PATCH] ipa-sra: Fix thinko when overriding safe_to_import_accesses (PR 101066)

2021-07-02 Thread Martin Jambor
Ping. On Mon, Jun 21 2021, Martin Jambor wrote: > Hi, > > The "new" IPA-SRA has a more difficult job than the previous > not-truly-IPA version when identifying situations in which a parameter > passed by reference can be passed into a third function and only thee > converted to one passed by

Re: [PATCH] Port GCC documentation to Sphinx

2021-07-02 Thread Martin Liška
On 7/1/21 5:06 PM, Michael Matz wrote: Hello, On Thu, 1 Jul 2021, Martin Liška wrote: On 7/1/21 3:33 PM, Eli Zaretskii wrote: Cc: jos...@codesourcery.com, g...@gcc.gnu.org, gcc-patches@gcc.gnu.org From: Martin Liška Date: Thu, 1 Jul 2021 14:44:10 +0200 It helps some, but not all of the

Re: [PATCH] Port GCC documentation to Sphinx

2021-07-02 Thread Martin Liška
On 7/1/21 6:58 PM, Eli Zaretskii wrote: Cc: jos...@codesourcery.com, g...@gcc.gnu.org, gcc-patches@gcc.gnu.org From: Martin Liška Date: Thu, 1 Jul 2021 18:04:24 +0200 Emacs doesn't hide the period. But there shouldn't be a period to begin with, since it's the middle of a sentence. The

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-02 Thread Jakub Jelinek via Gcc-patches
On Fri, Jul 02, 2021 at 09:45:46AM +0200, Richard Biener via Gcc-patches wrote: > > > > are? (If it is restricted to SSE, we can of course ensure relevant > > > libgcc > > > > functions are built with SSE enabled, and likewise in glibc if that > > > > gains > > > > _Float16 functions, though

Re: [PATCH 1/2] arm: Fix vcond_mask expander for MVE (PR target/100757)

2021-07-02 Thread Christophe Lyon via Gcc-patches
On Fri, 2 Jul 2021 at 10:53, Christophe Lyon wrote: > > Hi, > > On Wed, 9 Jun 2021 at 17:04, Richard Sandiford > wrote: > > > > Christophe Lyon writes: > > > The problem in this PR is that we call VPSEL with a mask of vector > > > type instead of HImode. This happens because operand 3 in

Re: [PATCH 1/2] arm: Fix vcond_mask expander for MVE (PR target/100757)

2021-07-02 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, 9 Jun 2021 at 17:04, Richard Sandiford wrote: > > Christophe Lyon writes: > > The problem in this PR is that we call VPSEL with a mask of vector > > type instead of HImode. This happens because operand 3 in vcond_mask > > is the pre-computed vector comparison and has vector type.

Re: [PATCH] [i386] Remove rex64suffix for v?cvtt?(ss|sd)*2si

2021-07-02 Thread Uros Bizjak via Gcc-patches
On Fri, Jul 2, 2021 at 10:30 AM Hongyu Wang wrote: > > Hi, > > For instructions like cvtss2si, there is no need to output the 'l' > or 'q' suffixes just like cvtss2usi, since the output operand is always > register and those suffixes are only used to distinguish ambiguous > memory operands. > >

[PATCH] [i386] Remove rex64suffix for v?cvtt?(ss|sd)*2si

2021-07-02 Thread Hongyu Wang via Gcc-patches
Hi, For instructions like cvtss2si, there is no need to output the 'l' or 'q' suffixes just like cvtss2usi, since the output operand is always register and those suffixes are only used to distinguish ambiguous memory operands. Bootstraped and regression tested on x86_64-linux-gnu {,-m32}. OK for

Re: [PATCH 0/2] Initial support for AVX512FP16

2021-07-02 Thread Richard Biener via Gcc-patches
On Fri, Jul 2, 2021 at 10:07 AM Uros Bizjak via Gcc-patches wrote: > > On Fri, Jul 2, 2021 at 8:25 AM Hongtao Liu wrote: > > > > > AVX512FP16 is disclosed, refer to [1]. > > > > There're 100+ instructions for AVX512FP16, 67 gcc patches, for the > > > > convenience of review, we divide the

Re: [PATCH] Fix typo in standard pattern name of trunc2.

2021-07-02 Thread Hongyu Wang via Gcc-patches
This caused XPASS: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovqw 2 FAIL: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 1 XPASS: gcc.target/i386/pr92658-avx512vl.c scan-assembler-times vpmovdw 2 liuhongt via Gcc-patches 于2021年7月1日周四 下午3:45写道: > >

Re: [PATCH 1/2] Implement basic block path solver.

2021-07-02 Thread Aldy Hernandez via Gcc-patches
On 7/2/21 12:20 AM, Jeff Law wrote: On 6/28/2021 10:21 AM, Aldy Hernandez wrote: +// Internal construct to help facilitate debugging of solver. +#define DEBUG_SOLVER getenv("DEBUG") Shouldn't this really be a property of what pass is using the solver and whether or not the appropriate

Re: [PATCH] i386: Disable param ira-consider-dup-in-all-alts [PR100328]

2021-07-02 Thread Uros Bizjak via Gcc-patches
On Fri, Jul 2, 2021 at 4:28 AM Kewen.Lin wrote: > > Hi, > > With Hongtao's help (thanks), we got the SPEC2017 performance > evaluation result on x86_64 (see [1]), this new parameter > ira-consider-dup-in-all-alts has negative effects on i386. > Since we observed it can benefit ports aarch64 and

Re: [PATCH 0/2] Initial support for AVX512FP16

2021-07-02 Thread Uros Bizjak via Gcc-patches
On Fri, Jul 2, 2021 at 8:25 AM Hongtao Liu wrote: > > > AVX512FP16 is disclosed, refer to [1]. > > > There're 100+ instructions for AVX512FP16, 67 gcc patches, for the > > > convenience of review, we divide the 67 patches into 2 major parts. > > > The first part is 2 patches containing

Re: [PATCH] i386: Punt on broadcasts from TImode integers [PR101286]

2021-07-02 Thread Hongtao Liu via Gcc-patches
On Fri, Jul 2, 2021 at 3:32 PM Jakub Jelinek wrote: > > Hi! > > ix86_expand_vector_init_duplicate doesn't handle TImode -> V2TImode > or TImode -> V4TImode broadcasts, so I think we should punt on TImode > inner mode in ix86_broadcast_from_integer_constant, otherwise we ICE > in

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-02 Thread Hongtao Liu via Gcc-patches
On Fri, Jul 2, 2021 at 3:46 PM Richard Biener via llvm-dev wrote: > > On Fri, Jul 2, 2021 at 1:34 AM Jacob Lifshay via Gcc-patches > wrote: > > > > On Thu, Jul 1, 2021, 15:28 H.J. Lu via llvm-dev > > wrote: > > > > > On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers > > > wrote: > > > > > > > > On

Re: [PATCH PR100740]Fix overflow check in simplifying exit cond comparing two IVs.

2021-07-02 Thread Richard Biener via Gcc-patches
On Fri, Jul 2, 2021 at 3:37 AM Bin.Cheng wrote: > > On Thu, Jul 1, 2021 at 8:19 PM Richard Biener > wrote: > > > > On Mon, Jun 7, 2021 at 4:35 PM Richard Biener > > wrote: > > > > > > On Sun, Jun 6, 2021 at 12:01 PM Bin.Cheng wrote: > > > > > > > > On Wed, Jun 2, 2021 at 3:28 PM Richard Biener

Re: [PATCH] Analyze niter for until-wrap condition [PR101145]

2021-07-02 Thread guojiufu via Gcc-patches
On 2021-07-01 20:35, Richard Biener wrote: On Thu, 1 Jul 2021, Jiufu Guo wrote: For code like: unsigned foo(unsigned val, unsigned start) { unsigned cnt = 0; for (unsigned i = start; i > val; ++i) cnt++; return cnt; } The number of iterations should be about UINT_MAX - start. For

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-02 Thread Richard Biener via Gcc-patches
On Fri, Jul 2, 2021 at 1:34 AM Jacob Lifshay via Gcc-patches wrote: > > On Thu, Jul 1, 2021, 15:28 H.J. Lu via llvm-dev > wrote: > > > On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers > > wrote: > > > > > > On Thu, 1 Jul 2021, H.J. Lu via Gcc-patches wrote: > > > > > > > 2. Return _Float16 and

Re: [PATCH 56/62] AVX512FP16: Optimize (_Float16) sqrtf ((float) f16) to sqrtf16 (f16).

2021-07-02 Thread Richard Biener via Gcc-patches
On Thu, Jul 1, 2021 at 11:49 PM Joseph Myers wrote: > > On Thu, 1 Jul 2021, Richard Biener via Gcc-patches wrote: > > > > C++ FE doesn't support _FLoat16, and the place float/double are > > > handled is in convert.c(which is GENERIC?), that's why I decided to do > > > it in the backend. > > I

Re: [PATCH 58/62] AVX512FP16: Optimize for code like (_Float16) __builtin_ceif ((float) f16).

2021-07-02 Thread Richard Biener via Gcc-patches
On Thu, Jul 1, 2021 at 11:26 PM Joseph Myers wrote: > > On Thu, 1 Jul 2021, liuhongt via Gcc-patches wrote: > > > +/* Optimize for code like (_Float16) __builtin_ceif ((float) f16) > > + since it's not handled in frontend. */ > > Much the same comments apply as for sqrt. But in this case, the

[PATCH] i386: Punt on broadcasts from TImode integers [PR101286]

2021-07-02 Thread Jakub Jelinek via Gcc-patches
Hi! ix86_expand_vector_init_duplicate doesn't handle TImode -> V2TImode or TImode -> V4TImode broadcasts, so I think we should punt on TImode inner mode in ix86_broadcast_from_integer_constant, otherwise we ICE in ix86_expand_vector_move when ix86_broadcast_from_integer_constant returns non-NULL

Re: [PATCH] BTF: Support for BTF_KIND_FLOAT

2021-07-02 Thread Richard Biener via Gcc-patches
On Thu, Jul 1, 2021 at 7:54 PM David Faust via Gcc-patches wrote: > > Add BTF_KIND_FLOAT, a new BTF type kind which has recently stabilized in > the linux kernel [1]. This kind is used for encoding floating point > types, and is of particular use when generating BTF for some s390 > arch-specific

Re: [x86] Change EH pointer encodings to PC relative on Windows

2021-07-02 Thread Richard Biener via Gcc-patches
On Thu, Jul 1, 2021 at 6:44 PM Eric Botcazou wrote: > > Hi, > > a big difference between ELF and PE-COFF is that, with the latter, you can > build position-independent executables or DLLs without generating PIC; as a > matter of fact, flag_pic has historically been forced to 0 for 32-bit: > > /*

Re: [PATCH] [DWARF] Fix hierarchy of debug information for offload kernels.

2021-07-02 Thread Richard Biener via Gcc-patches
On Thu, Jul 1, 2021 at 5:17 PM Hafiz Abid Qadeer wrote: > > Currently, if we look at the debug information for offload kernel > regions, it looks something like this: > > void foo (void) > { > #pragma acc kernels > { > > } > } > > DW_TAG_compile_unit > DW_AT_name("") > >

Re: [PING][PATCH 2/4] remove %G and %K from calls in front end and middle end (PR 98512)

2021-07-02 Thread Aldy Hernandez via Gcc-patches
On 7/1/21 10:14 PM, Martin Sebor wrote: On 6/30/21 5:35 PM, David Malcolm wrote: On Wed, 2021-06-30 at 13:45 -0600, Martin Sebor wrote: On 6/30/21 9:39 AM, Martin Sebor wrote: @@ -90,8 +90,8 @@ NOIPA void warn_g2 (struct A *p)     g2 (p);   } -// { dg-message "inlined from 'g2'" "" {

Re: [PATCH] tree-optimization/101280 - revise interchange fix for PR101173

2021-07-02 Thread Richard Biener
On Fri, 2 Jul 2021, Richard Biener wrote: > On Thu, 1 Jul 2021, Michael Matz wrote: > > > Hello, > > > > On Thu, 1 Jul 2021, Richard Biener wrote: > > > > > diff --git a/gcc/gimple-loop-interchange.cc > > > b/gcc/gimple-loop-interchange.cc > > > index 43045c5455e..43ef112a2d0 100644 > > > ---

Re: [PATCH 0/2] Initial support for AVX512FP16

2021-07-02 Thread Hongtao Liu via Gcc-patches
On Thu, Jul 1, 2021 at 7:10 PM Uros Bizjak wrote: > > [Sorry for double post, gcc-patches address was wrong in original post] > > On Thu, Jul 1, 2021 at 7:48 AM liuhongt wrote: > > > > Hi: > > AVX512FP16 is disclosed, refer to [1]. > > There're 100+ instructions for AVX512FP16, 67 gcc

Re: [PATCH] tree-optimization/101280 - revise interchange fix for PR101173

2021-07-02 Thread Richard Biener
On Thu, 1 Jul 2021, Michael Matz wrote: > Hello, > > On Thu, 1 Jul 2021, Richard Biener wrote: > > > diff --git a/gcc/gimple-loop-interchange.cc b/gcc/gimple-loop-interchange.cc > > index 43045c5455e..43ef112a2d0 100644 > > --- a/gcc/gimple-loop-interchange.cc > > +++