Re: [Patch, fortran] PR fortran/100906/100907/100911/100914/100915/100916

2021-07-12 Thread Sandra Loosemore
On 6/13/21 12:36 PM, José Rui Faustino de Sousa via Gcc-patches wrote: Hi All! Proposed patch to: Bug 100906 - Bind(c): failure handling character with len/=1 Bug 100907 - Bind(c): failure handling wide character Bug 100911 - Bind(c): failure handling C_PTR Bug 100914 - Bind(c): errors

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread Michael Meissner via Gcc-patches
On Mon, Jul 12, 2021 at 10:32:47AM -0500, Bill Schmidt wrote: > Hi Mike, > >diff --git a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c > >b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c > >index 1269fe635c6..d5ed700b9bc 100644 > >---

RE: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-12 Thread Wang, Pengfei via Gcc-patches
> Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers. Can you please explain the behavior here? Is there difference between _Float16 and _Complex _Float16 when return? I.e., 1, In which case will _Float16 values return in both %xmm0 and %xmm1? 2, For a single _Float16 value,

Re: [PATCH] [android] Disable large files when unsupported

2021-07-12 Thread Abraão de Santana via Gcc-patches
This could be better achieved by rewriting the libstdc++-v3/configure file to fail the test for _FILE_OFFSET_BITS = 64 when fpos is not defined. But this is kind of an odd spot to be, as this is an oddity from those specific conditions on Bionic and I don't know if it's worth devising a universal

[PATCH] [android] Disable large files when unsupported

2021-07-12 Thread Abraão de Santana via Gcc-patches
If C++ is enabled with Bionic on API Level < 24 ( and with NDK >= r15 as lower versions just ignore the issue ) you get errors of ::fgetpos and ::fsetpos error: 'fsetpos' has not been declared in '::' . The issue is that API Level < 24 doesn't implement large files (64 bit), so when

fix typo in attr_fnspec::verify

2021-07-12 Thread Alexandre Oliva
Odd-numbered indices describing argument access sizes in the fnspec string can only hold 't' or a digit, as tested in the beginning of the case. When checking that the size-supplying argument does not have additional information associated with it, the test that excludes the 't' possibility

sync up new type indices for body adjustments

2021-07-12 Thread Alexandre Oliva
The logic in fill_vector_of_new_param_types may skip some parameters when pushing into m_new_types, but common_initialization doesn't take that into account, and may end up attempting to access the vector past its end when IPA_PARAM_OP_(NEW|SPLIT) operands appear after skipped _COPY ones. This

avoid early reference to debug-only symbol

2021-07-12 Thread Alexandre Oliva
If some IPA pass replaces the only reference to a constant non-public non-automatic variable with its initializer, namely the address of another such variable, the former becomes unreferenced and it's discarded by symbol_table::remove_unreachable_nodes. It calls debug_hooks->late_global_decl

move unreachable user labels to entry point

2021-07-12 Thread Alexandre Oliva
pr42739.C, complicated by some extra wrappers and cleanups from a feature I'm working on, got me very confused because a user label ended up in a cleanup introduced by my pass, where it couldn't possibly have been initially. The current logic may move such an unreachable user label multiple

adjust landing pads when changing main label

2021-07-12 Thread Alexandre Oliva
If an artificial label created for a landing pad ends up being dropped in favor of a user-supplied label, the user-supplied label inherits the landing pad index, but the post_landing_pad field is not adjusted to point to the new label. This patch fixes the problem, and adds verification that we

drop va_list from formals if requested

2021-07-12 Thread Alexandre Oliva
I'm working on a feature that involves creating wrappers for some functions, using alternate means to pass variable argument lists to the wrapped versions. The split-out (wrapped) function shouldn't be stdarg, and though comments in m_always_copy_start in ipa_param_adjustments suggested that

Re: ipa-modref: merge flags when adding escape

2021-07-12 Thread Alexandre Oliva
Ping? https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573137.html On Jun 18, 2021, Alexandre Oliva wrote: > for gcc/ChangeLog > * ipa-modref.c (modref_lattice::add_escape_point): Merge > min_flags into flags. > (modref_lattice::dump): Fix escape_point's min_flags

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 23:53, guojiufu via Gcc-patches wrote: On 2021-07-12 22:46, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 18:02, Richard Biener wrote: > On Mon, 12 Jul 2021, guojiufu wrote: > >> On 2021-07-12 16:57, Richard Biener wrote: >> > On Mon, 12 Jul 2021,

[PATCH v2] x86: Don't enable UINTR in 32-bit mode

2021-07-12 Thread H.J. Lu via Gcc-patches
UINTR is available only in 64-bit mode. Since the codegen target is unknown when the the gcc driver is processing -march=native, to properly handle UINTR for -march=native: 1. Pass arch[32|64] and tune[32|64] to host_detect_local_cpu to indicate 32-bit and 64-bit codegen. 2. Change

Re: [PATCH, rs6000] fix execution failure of parity_1.f90 on P10 [PR100952]

2021-07-12 Thread HAO CHEN GUI via Gcc-patches
Hi,    I refined the patch according to Segher's advice. Is this okay for trunk? Any recommendations? Thanks a lot. On 6/7/2021 上午 11:01, HAO CHEN GUI wrote: Hi,    The patch fixed the wrong "if" fall through in "cstore4" expand, which causes comparison pattern expanded twice on P10.   

[COMMITTED] Add relation processing to ubsan builtins, and EVRP equality.

2021-07-12 Thread Andrew MacLeod via Gcc-patches
Ubsan builtins use the plus,minus and multiply operations under the covers, but they are not relation aware.  This patch queries for a relation between the 2 operands and passes that on to range-ops. This resolves gcc.dg/pr97505.c when operating in ranger-only mode, and with that, ranger-only

Re: [PATCH 4/4] rs6000: Add tests for SSE4.1 "blend" intrinsics

2021-07-12 Thread Segher Boessenkool
On Sun, Jul 11, 2021 at 11:19:56AM -0500, Bill Schmidt wrote: > Please resubmit this when you resubmit 3/4, in case any adjustments are > needed. It is testing if elsewhere-defined functions work according to its specification -- let's hope that doesn't change ;-) Segher

Re: [PATCH 2/4] rs6000: Add tests for SSE4.1 "test" intrinsics

2021-07-12 Thread Segher Boessenkool
On Sun, Jul 11, 2021 at 10:49:27AM -0500, Bill Schmidt wrote: > LGTM.  I can't approve, but recommend approval as is. Okay for trunk. Thanks! Segher > >2021-06-29 Paul A. Clarke > > > >gcc/testsuite/ChangeLog: > > * gcc.target/powerpc/sse4_1-ptest.c: Copy from > >

Re: [PATCH 1/4] rs6000: Add support for SSE4.1 "test" intrinsics

2021-07-12 Thread Segher Boessenkool
Hi! On Sun, Jul 11, 2021 at 10:45:45AM -0500, Bill Schmidt wrote: > On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: > >--- a/gcc/config/rs6000/smmintrin.h > >+++ b/gcc/config/rs6000/smmintrin.h > >@@ -116,4 +116,54 @@ _mm_blendv_epi8 (__m128i __A, __m128i __B, __m128i > >__mask) > >

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread Segher Boessenkool
On Mon, Jul 12, 2021 at 12:47:43PM -0500, Bill Schmidt wrote: > On 7/12/21 12:16 PM, Michael Meissner wrote: > >>Shouldn't this last be { lp64 && has_arch_pwr10 } ? > >Nope. Because the power10 vector multiply is done in the vector unit, it > >can > >generate the vmulld instruction. > > Please

Re: [PATCH 3/4] rs6000: Add support for SSE4.1 "blend" intrinsics

2021-07-12 Thread Paul A. Clarke via Gcc-patches
On Sun, Jul 11, 2021 at 11:29:24AM -0500, Bill Schmidt wrote: > On 7/11/21 11:17 AM, Bill Schmidt wrote: > > On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: > > > _mm_blend_epi16 and _mm_blendv_epi8 were added earlier. > > > Add these four to complete the set. > > > > > > 2021-06-29 

Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514

2021-07-12 Thread Harald Anlauf via Gcc-patches
Hi Tobias, > On 10.06.21 20:52, Harald Anlauf via Fortran wrote: > > +static bool > > +substring_has_constant_len (gfc_expr *e) > > +{ > > + ptrdiff_t istart, iend; > > + size_t length; > > + bool equal_length = false; > > + > > + if (e->ts.type != BT_CHARACTER > > + || !e->ref > > +

Re: [patch] PR jit/87808: Allow libgccjit to work without an external gcc driver

2021-07-12 Thread Matthias Klose
On 3/26/19 12:52 PM, Matthias Klose wrote: > On 22.03.19 23:00, David Malcolm wrote: >> On Thu, 2019-03-21 at 12:26 +0100, Matthias Klose wrote: >>> Fix PR jit/87808, the embedded driver still needing the external gcc >>> driver to >>> find the gcc_lib_dir. This can happen in a packaging context

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread Segher Boessenkool
On Wed, Jul 07, 2021 at 04:03:20PM -0400, Michael Meissner wrote: > This patch updates the various tests in the testsuite to treat plxv > and pstxv as being vector loads/stores. (That is a not a very good description) The reason it is hard to review this patch is there was no rationale

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread Segher Boessenkool
On Mon, Jul 12, 2021 at 10:32:47AM -0500, Bill Schmidt wrote: > > * gcc.target/powerpc/fold-vec-load-builtin_vec_xl-char.c: There should be something after the ":". If you want to say the same thing for many files, you can say somethin like "ditto" for all but the first. > >-/* { dg-final {

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Qing Zhao via Gcc-patches
Hi, Kees, Thanks a lot for your testing on kernel testing cases. I have some question in below: > On Jul 12, 2021, at 12:56 PM, Kees Cook wrote: > > On Wed, Jul 07, 2021 at 05:38:02PM +, Qing Zhao wrote: >> Hi, >> >> This is the 4th version of the patch for the new security feature for

Re: Repost: [PATCH] Fix vec-splati-runnable.c test.

2021-07-12 Thread David Edelsohn via Gcc-patches
On Wed, Jul 7, 2021 at 4:01 PM Michael Meissner wrote: > > [PATCH] Fix vec-splati-runnable.c test. > > I noticed that the vec-splati-runnable.c did not have an abort after one > of the tests. If the test was run with optimization, the optimizer could > delete some of the tests and throw off the

Re: contracts library support (was Re: [PATCH] PING implement pre-c++20 contracts)

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 5 Jul 2021 at 20:07, Jason Merrill wrote: > > On 6/26/21 10:23 AM, Andrew Sutton wrote: > > > > I ended up taking over this work from Jeff (CC'd on his existing email > > address). I scraped all the contracts changes into one big patch > > against master. See attached. The

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread David Edelsohn via Gcc-patches
On Mon, Jul 12, 2021 at 1:47 PM Bill Schmidt wrote: > > On 7/12/21 12:16 PM, Michael Meissner wrote: > > On Sun, Jul 11, 2021 at 02:55:04PM -0500, Bill Schmidt wrote: > >> Hi Mike, > >> > >> On 7/7/21 3:04 PM, Michael Meissner wrote: > >>> [PATCH] PR 100167: Fix vector long long multiply/divide

Re: [PATCH] c++: permit deduction guides at class scope [PR79501]

2021-07-12 Thread Jason Merrill via Gcc-patches
On 7/9/21 6:41 PM, Patrick Palka wrote: On Fri, 9 Jul 2021, Jason Merrill wrote: On 7/9/21 4:18 PM, Patrick Palka wrote: On Fri, 9 Jul 2021, Patrick Palka wrote: On Fri, 9 Jul 2021, Jason Merrill wrote: On 7/9/21 3:18 PM, Patrick Palka wrote: This adds support for declaring (class-scope)

Re: [PATCH V2] coroutines: Adjust outlined function names [PR95520].

2021-07-12 Thread Jason Merrill via Gcc-patches
On 7/11/21 9:03 AM, Iain Sandoe wrote: Hi Jason, On 9 Jul 2021, at 22:40, Jason Merrill wrote: On 7/9/21 2:18 PM, Iain Sandoe wrote: How about handling this in write_encoding, along the lines of the devel/c++-contracts branch? OK, so I took a look at this and implemented as below.

Re: Repost: [PATCH] Change rs6000_const_f32_to_i32 return type.

2021-07-12 Thread David Edelsohn via Gcc-patches
On Mon, Jul 12, 2021 at 12:07 PM Bill Schmidt wrote: > > Hi Mike, > > On 7/7/21 2:59 PM, Michael Meissner wrote: > > [PATCH] Change rs6000_const_f32_to_i32 return type. > > > > The function rs6000_const_f32_to_i32 called REAL_VALUE_TO_TARGET_SINGLE > > with a long long type and returns it. This

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread David Edelsohn via Gcc-patches
On Wed, Jul 7, 2021 at 4:03 PM Michael Meissner wrote: > > [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166 > > This patch updates the various tests in the testsuite to treat plxv > and pstxv as being vector loads/stores. This shows up if you run the > testsuite with a

*Ping* [PATCH] PR fortran/101084 - [10/11/12 Regression] ICE in gfc_typenode_for_spec, at fortran/trans-types.c:1124

2021-07-12 Thread Harald Anlauf via Gcc-patches
*Ping* > Gesendet: Dienstag, 15. Juni 2021 um 21:31 Uhr > Von: "Harald Anlauf" > An: "fortran" , "gcc-patches" > Betreff: [PATCH] PR fortran/101084 - [10/11/12 Regression] ICE in > gfc_typenode_for_spec, at fortran/trans-types.c:1124 > > A recent change to the checking of legacy FORMAT tags

[PATCH v3] IBM Z: Use @PLT symbols for local functions in 64-bit mode

2021-07-12 Thread Ilya Leoshkevich via Gcc-patches
Bootstrapped and regtested on s390x-redhat-linux. Ok for master? v1: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573614.html v1 -> v2: Do not use UNSPEC_PLT in 64-bit code and rename it to UNSPEC_PLT31 (Ulrich, Andreas). Do not append @PLT only to weak symbols in

[PATCH] i386: Fix vec_set expanders [PR101424]

2021-07-12 Thread Uros Bizjak via Gcc-patches
AVX does not support 32-byte integer compares, required by ix86_expand_vector_set_var. The following patch fixes vec_set expanders by introducing new vec_setm_avx2_operand predicate for AVX vector modes. gcc/ 2021-07-12 Uroš Bizjak PR target/101424 * config/i386/predicates.md

[COMMITTED] tree-optimization/101335 - Do not register a cast as an equivalence.

2021-07-12 Thread Andrew MacLeod via Gcc-patches
Registering an equivalence between objects of the same size in a cast can cause other registered relations to be incorrect. Detailed in the PR.  This was an older attempt to solve a problem which has since been resolved by recomputation in the GORI engine. Bootstrapped on  x86_64-pc-linux-gnu

Re: [PATCH] [wwwdocs] Update description of GM2 and document branch

2021-07-12 Thread Gerald Pfeifer
On Mon, 12 Jul 2021, Gaius Mulley wrote: >> Usually I'd just say "subject", which is a header in our mail systems; >> the term "subject line" isn't widely used. > feel free to overrule and use "subject". I copied the text from other > branch descriptions :-) (there are 38 uses). I guess there

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Koning, Paul via Gcc-patches
> On Jul 12, 2021, at 12:36 PM, David Malcolm via Gcc-patches > wrote: > > On Mon, 2021-07-12 at 15:25 +0200, Martin Liška wrote: >> ... > > I think the output formats we need to support are: > - HTML > - PDF > - man page (hardly "modern", but still used) Also info format (for the Emacs

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Qing Zhao via Gcc-patches
Hi, Martin, Thanks a lot for your experiments and examples, they are really helpful. So, based on your study, I will delete the code that handle grp_to_be_debug_replaced accesses in generate_subtree_deferred_init. Let me know if you have further comments on this. Qing > On Jul 12, 2021, at

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread Bill Schmidt via Gcc-patches
On 7/12/21 12:47 PM, Bill Schmidt via Gcc-patches wrote: On 7/12/21 12:16 PM, Michael Meissner wrote: On Sun, Jul 11, 2021 at 02:55:04PM -0500, Bill Schmidt wrote: Hi Mike, On 7/7/21 3:04 PM, Michael Meissner wrote: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10.

PING [PATCH] handle sanitizer built-ins in -Wuninitialized (PR 101300)

2021-07-12 Thread Martin Sebor via Gcc-patches
Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574385.html On 7/2/21 1:21 PM, Martin Sebor wrote: To avoid a class of false negatives for sanitized code -Wuninitialized recognizes the ASAN_MARK internal function doesn't modify its argument.  But the warning code doesn't do the same

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Kees Cook via Gcc-patches
On Wed, Jul 07, 2021 at 05:38:02PM +, Qing Zhao wrote: > Hi, > > This is the 4th version of the patch for the new security feature for GCC. > > I have tested it with bootstrap on both x86 and aarch64, regression testing > on both x86 and aarch64. > Also compile and run CPU2017, without any

Re: [PATCH 10/10] vect: Reuse reduction accumulators between loops

2021-07-12 Thread Richard Sandiford via Gcc-patches
Richard Biener via Gcc-patches writes: > On Fri, Jul 9, 2021 at 3:12 PM Richard Sandiford > wrote: >> >> Thanks for the review. >> >> Richard Biener writes: >> >> @@ -588,6 +600,23 @@ public: >> >>/* Unrolling factor */ >> >>poly_uint64 vectorization_factor; >> >> >> >> + /* If this

[r12-2245 Regression] FAIL: g++.dg/vect/slp-pr87105.cc -std=c++2a scan-tree-dump-times slp2 "optimized: basic block part" 1 on Linux/x86_64

2021-07-12 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, c03cae4e066066278c8435c409829a9bf851e49f is the first bad commit commit c03cae4e066066278c8435c409829a9bf851e49f Author: Richard Biener Date: Wed Jul 7 11:45:43 2021 +0200 Display the number of components BB vectorized caused FAIL: g++.dg/vect/slp-pr87105.cc -std=c++14

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread Bill Schmidt via Gcc-patches
On 7/12/21 12:16 PM, Michael Meissner wrote: On Sun, Jul 11, 2021 at 02:55:04PM -0500, Bill Schmidt wrote: Hi Mike, On 7/7/21 3:04 PM, Michael Meissner wrote: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10. This patch updates the vector long long multiply and

[committed] libstdc++: Constrain std::as_writable_bytes [PR101411]

2021-07-12 Thread Jonathan Wakely via Gcc-patches
The std::as_writable_bytes function should be constrained to only accept writable spans. Currently it can be called but then gives an error in the function body. Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/101411 * include/std/span (as_writable_bytes):

Re: Repost: [PATCH] Fix vec-splati-runnable.c test.

2021-07-12 Thread Bill Schmidt via Gcc-patches
On 7/12/21 12:11 PM, Michael Meissner wrote: On Mon, Jul 12, 2021 at 10:49:26AM -0500, Bill Schmidt wrote: Hi Mike, On 7/7/21 3:00 PM, Michael Meissner wrote: [PATCH] Fix vec-splati-runnable.c test. I noticed that the vec-splati-runnable.c did not have an abort after one of the tests. If

Re: [PATCH] rs6000: Fix restored rs6000_long_double_type_size.

2021-07-12 Thread Segher Boessenkool
On Mon, Jun 28, 2021 at 02:19:03PM +0200, Martin Liška wrote: > On 6/24/21 12:46 AM, Segher Boessenkool wrote: > >>As mentioned in the "Fallout: save/restore target options in > >>handle_optimize_attribute" > >>thread, we need to support target option restore of > >>rs6000_long_double_type_size ==

Re: [PATCH] Port GCC documentation to Sphinx

2021-07-12 Thread Martin Sebor via Gcc-patches
On 6/29/21 4:09 AM, Martin Liška wrote: On 6/28/21 5:33 PM, Joseph Myers wrote: Are formatted manuals (HTML, PDF, man, info) corresponding to this patch version also available for review? I've just uploaded them here: https://splichal.eu/gccsphinx-final/ Martin I think listing the -Wfoo

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread Michael Meissner via Gcc-patches
On Sun, Jul 11, 2021 at 02:55:04PM -0500, Bill Schmidt wrote: > Hi Mike, > > On 7/7/21 3:04 PM, Michael Meissner wrote: > >[PATCH] PR 100167: Fix vector long long multiply/divide tests on power10. > > > >This patch updates the vector long long multiply and divide tests to > >supply the correct

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> From: Jonathan Wakely > Date: Mon, 12 Jul 2021 15:54:49 +0100 > Cc: Martin Liška , > "g...@gcc.gnu.org" , gcc-patches > , > "Joseph S. Myers" > > You like texinfo. We get it. Would you please drop the attitude?

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> Cc: h...@bitrange.com, g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, > jos...@codesourcery.com > From: Martin Liška > Date: Mon, 12 Jul 2021 16:37:00 +0200 > > > 4) The need to learn yet another markup language. > > While this is not a problem for simple text, it does require a > >

Re: Repost: [PATCH] Fix vec-splati-runnable.c test.

2021-07-12 Thread Michael Meissner via Gcc-patches
On Mon, Jul 12, 2021 at 10:49:26AM -0500, Bill Schmidt wrote: > Hi Mike, > > On 7/7/21 3:00 PM, Michael Meissner wrote: > >[PATCH] Fix vec-splati-runnable.c test. > > > >I noticed that the vec-splati-runnable.c did not have an abort after one > >of the tests. If the test was run with

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> Cc: g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, jos...@codesourcery.com > From: Martin Liška > Date: Mon, 12 Jul 2021 16:34:11 +0200 > > > "Texinfo must go" is one possible conclusion from your description. > > But it isn't the only one. An alternative is "the Texinfo source of > > the GCC

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Martin Jambor
Hi, On Mon, Jul 12 2021, Qing Zhao wrote: >> On Jul 12, 2021, at 2:51 AM, Richard Sandiford >> wrote: >> >> Martin Jambor writes: >>> On Thu, Jul 08 2021, Qing Zhao wrote: (Resend this email since the previous one didn’t quote, I changed one setting in my mail client, hopefully that

Re: [PATCH] rs6000: Fix restored rs6000_long_double_type_size.

2021-07-12 Thread Segher Boessenkool
On Mon, Jul 12, 2021 at 06:19:28AM +0200, Martin Liška wrote: > PING^1 I did not notice you attached a new patch. It works a lot better if every patch series is a new thread. Segher

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread David Malcolm via Gcc-patches
On Mon, 2021-07-12 at 15:25 +0200, Martin Liška wrote: > Hello. > > Let's make it a separate sub-thread where we can discuss motivation > why > do I want moving to Sphinx format. > > Benefits: > 1) modern looking HTML output (before: [1], after: [2]): "modern looking" is rather subjective; I'd

Re: [RFA] Some libgcc headers are missing the runtime exception

2021-07-12 Thread Richard Sandiford via Gcc-patches
David Edelsohn writes: > On Mon, Jul 12, 2021 at 11:58 AM Richard Sandiford > wrote: >> >> David Edelsohn writes: >> > On Fri, Jul 9, 2021 at 1:31 PM Richard Sandiford >> > wrote: >> >> >> >> David Edelsohn writes: >> >> > On Fri, Jul 9, 2021 at 12:53 PM Richard Sandiford via Gcc >> >> >

Re: disable -Warray-bounds in libgo (PR 101374)

2021-07-12 Thread Martin Sebor via Gcc-patches
On 7/9/21 7:26 AM, Rainer Orth wrote: Hi Martin, Yesterday's enhancement to -Warray-bounds has exposed a couple of issues in libgo where the code writes into an invalid constant address that the warning is designed to flag. On the assumption that those invalid addresses are deliberate, the

Re: [RFA] Some libgcc headers are missing the runtime exception

2021-07-12 Thread David Edelsohn via Gcc-patches
On Mon, Jul 12, 2021 at 11:58 AM Richard Sandiford wrote: > > David Edelsohn writes: > > On Fri, Jul 9, 2021 at 1:31 PM Richard Sandiford > > wrote: > >> > >> David Edelsohn writes: > >> > On Fri, Jul 9, 2021 at 12:53 PM Richard Sandiford via Gcc > >> > wrote: > >> >> > >> >> Hi, > >> >> > >>

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 17:01, Gavin Smith wrote: > > On Mon, Jul 12, 2021 at 4:04 PM Jonathan Wakely via Gcc > wrote: > > GNU Hello has the same problem with its docs: > > https://www.gnu.org/software/hello/manual/hello.html#index-_002dg > > That URL is garbage because of the URL-encoded %2d

Re: Repost: [PATCH] Change rs6000_const_f32_to_i32 return type.

2021-07-12 Thread Bill Schmidt via Gcc-patches
Hi Mike, On 7/7/21 2:59 PM, Michael Meissner wrote: [PATCH] Change rs6000_const_f32_to_i32 return type. The function rs6000_const_f32_to_i32 called REAL_VALUE_TO_TARGET_SINGLE with a long long type and returns it. This patch changes the type to long which is the proper type for

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Gavin Smith via Gcc-patches
On Mon, Jul 12, 2021 at 4:04 PM Jonathan Wakely via Gcc wrote: > GNU Hello has the same problem with its docs: > https://www.gnu.org/software/hello/manual/hello.html#index-_002dg > That URL is garbage because of the URL-encoded %2d character, and the > fact it links to the wrong place (the

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 23:53, guojiufu via Gcc-patches wrote: On 2021-07-12 22:46, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 18:02, Richard Biener wrote: > On Mon, 12 Jul 2021, guojiufu wrote: > >> On 2021-07-12 16:57, Richard Biener wrote: >> > On Mon, 12 Jul 2021,

[RFA] Some libgcc headers are missing the runtime exception

2021-07-12 Thread Richard Sandiford via Gcc-patches
David Edelsohn writes: > On Fri, Jul 9, 2021 at 1:31 PM Richard Sandiford > wrote: >> >> David Edelsohn writes: >> > On Fri, Jul 9, 2021 at 12:53 PM Richard Sandiford via Gcc >> > wrote: >> >> >> >> Hi, >> >> >> >> It was pointed out to me off-list that config/aarch64/value-unwind.h >> >> is

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 22:46, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 18:02, Richard Biener wrote: > On Mon, 12 Jul 2021, guojiufu wrote: > >> On 2021-07-12 16:57, Richard Biener wrote: >> > On Mon, 12 Jul 2021, guojiufu wrote: >> > >> >> On 2021-07-12 14:20, Richard

Re: Repost: [PATCH] Fix vec-splati-runnable.c test.

2021-07-12 Thread Bill Schmidt via Gcc-patches
Hi Mike, On 7/7/21 3:00 PM, Michael Meissner wrote: [PATCH] Fix vec-splati-runnable.c test. I noticed that the vec-splati-runnable.c did not have an abort after one of the tests. If the test was run with optimization, the optimizer could delete some of the tests and throw off the count.

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread Bill Schmidt via Gcc-patches
Hi Mike, On 7/7/21 3:03 PM, Michael Meissner wrote: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166 This patch updates the various tests in the testsuite to treat plxv and pstxv as being vector loads/stores. This shows up if you run the testsuite with a compiler

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Qing Zhao via Gcc-patches
> On Jul 12, 2021, at 2:51 AM, Richard Sandiford > wrote: > > Martin Jambor writes: >> On Thu, Jul 08 2021, Qing Zhao wrote: >>> (Resend this email since the previous one didn’t quote, I changed one >>> setting in my mail client, hopefully that can fix this issue). >>> >>> Hi, Martin, >>>

Re: [PATCH V2] gcc: Add vec_select -> subreg RTL simplification

2021-07-12 Thread Richard Sandiford via Gcc-patches
Jonathan Wright writes: > Hi, > > Version 2 of this patch adds more code generation tests to show the > benefit of this RTL simplification as well as adding a new helper function > 'rtx_vec_series_p' to reduce code duplication. > > Patch tested as version 1 - ok for master? Sorry for the slow

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
* Florian Weimer: > * Florian Weimer: > >> I tested this on csky-linux-gnuabiv2 with the glibc version that failed >> before, and it works. So I guess your version is fine, too. > > Build on powerpc64-linux-gnu and other targets now fails with: > >

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 15:52, Jonathan Wakely wrote: > > On Mon, 12 Jul 2021 at 15:13, Eli Zaretskii wrote: > > I get it that you dislike the HTML produced by Texinfo, but without > > some examples of such bad HTML it is impossible to know what exactly > > do you dislike and why. > > > > > You

Re: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-07-12 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Monday, July 12, 2021 11:26 AM >> To: Tamar Christina >> Cc: Richard Biener ; nd ; gcc- >> patc...@gcc.gnu.org >> Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product >> where the sign for

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 15:52, Jonathan Wakely wrote: > > On Mon, 12 Jul 2021 at 15:13, Eli Zaretskii wrote: > > > > > From: Jonathan Wakely > > > This is a problem with texinfo too. > > > > Not for someone who already knows Texinfo. We are talking about > > switching away of it, so I'm

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 15:13, Eli Zaretskii wrote: > > > From: Jonathan Wakely > > Date: Mon, 12 Jul 2021 14:53:44 +0100 > > Cc: Martin Liška , > > "g...@gcc.gnu.org" , gcc-patches > > , > > "Joseph S. Myers" > > > > For me, these items are enough justification to switch away from

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread Richard Biener
On Mon, 12 Jul 2021, guojiufu wrote: > On 2021-07-12 18:02, Richard Biener wrote: > > On Mon, 12 Jul 2021, guojiufu wrote: > > > >> On 2021-07-12 16:57, Richard Biener wrote: > >> > On Mon, 12 Jul 2021, guojiufu wrote: > >> > > >> >> On 2021-07-12 14:20, Richard Biener wrote: > >> >> > On Fri, 9

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Martin Liška
On 7/12/21 3:39 PM, Eli Zaretskii wrote: Cc: g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, jos...@codesourcery.com From: Martin Liška Date: Mon, 12 Jul 2021 15:25:47 +0200 Let's make it a separate sub-thread where we can discuss motivation why do I want moving to Sphinx format. Thanks for

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
* Florian Weimer: > I tested this on csky-linux-gnuabiv2 with the glibc version that failed > before, and it works. So I guess your version is fine, too. Build on powerpc64-linux-gnu and other targets now fails with: /home/bmg/src/gcc/libgomp/config/linux/affinity.c: In function

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Martin Liška
On 7/12/21 4:16 PM, Eli Zaretskii wrote: From: Jonathan Wakely Date: Mon, 12 Jul 2021 15:05:11 +0100 Cc: Martin Liška , "g...@gcc.gnu.org" , gcc-patches , "Joseph S. Myers" To be clear, I give links to users frequently (several times a week, every week, for decades) and

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Martin Liška
On 7/12/21 4:12 PM, Eli Zaretskii wrote: From: Jonathan Wakely Date: Mon, 12 Jul 2021 14:53:44 +0100 Cc: Martin Liška , "g...@gcc.gnu.org" , gcc-patches , "Joseph S. Myers" For me, these items are enough justification to switch away from texinfo, which produces crap HTML

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> From: Jonathan Wakely > Date: Mon, 12 Jul 2021 15:05:11 +0100 > Cc: Martin Liška , > "g...@gcc.gnu.org" , gcc-patches > , > "Joseph S. Myers" > > To be clear, I give links to users frequently (several times a week, > every week, for decades) and prefer to give them a link to

Re: [PATCH] [wwwdocs] Update description of GM2 and document branch

2021-07-12 Thread Gaius Mulley via Gcc-patches
Gerald Pfeifer writes: > I realize this predates your patch (which merely changes version numbers), > but a reference to back ends could be misunderstood. I assume GNU Modula-2 > doesn't just use the back ends (x86, aarch64,...), but also the middle-end > and tree optimizers etc.? > > What do

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> From: Jonathan Wakely > Date: Mon, 12 Jul 2021 14:53:44 +0100 > Cc: Martin Liška , > "g...@gcc.gnu.org" , gcc-patches > , > "Joseph S. Myers" > > For me, these items are enough justification to switch away from > texinfo, which produces crap HTML pages with crap anchors. If we

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 18:02, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 16:57, Richard Biener wrote: > On Mon, 12 Jul 2021, guojiufu wrote: > >> On 2021-07-12 14:20, Richard Biener wrote: >> > On Fri, 9 Jul 2021, Segher Boessenkool wrote: >> > >> >> On Fri, Jul 09, 2021

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 14:53, Jonathan Wakely wrote: > For me, these items are enough justification to switch away from > texinfo, which produces crap HTML pages with crap anchors. You can't > find out the anchors without inspecting (and searching) the HTML > source. That's utterly stupid. And

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 14:41, Eli Zaretskii via Gcc wrote: > > > Cc: g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, jos...@codesourcery.com > > From: Martin Liška > > Date: Mon, 12 Jul 2021 15:25:47 +0200 > > > > Let's make it a separate sub-thread where we can discuss motivation why > > do I want

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
* Jakub Jelinek: > On Mon, Jul 12, 2021 at 10:26:47AM +0200, Florian Weimer via Gcc-patches > wrote: >> is included indirectly in the #pragma GCC visibility hidden >> block. With glibc 2.34, needs a declaration of the sysconf >> function, and including it under hidden visibility turns other

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> Cc: g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, jos...@codesourcery.com > From: Martin Liška > Date: Mon, 12 Jul 2021 15:25:47 +0200 > > Let's make it a separate sub-thread where we can discuss motivation why > do I want moving to Sphinx format. Thanks for starting this discussion. >

[PATCH] produce simple DOT graphs from SLP trees

2021-07-12 Thread Richard Biener
This adds a dot_slp_tree debug function producing a simple DOT graph from a starting node down the graph. There's no fancy direct invocation of dot but the output is directed to a specified file. It re-uses vect_print_slp_tree, naming nodes as their address. Bootstrap / regtest running on

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Jakub Jelinek via Gcc-patches
On Mon, Jul 12, 2021 at 10:26:47AM +0200, Florian Weimer via Gcc-patches wrote: > is included indirectly in the #pragma GCC visibility hidden > block. With glibc 2.34, needs a declaration of the sysconf > function, and including it under hidden visibility turns other calls > to sysconf into

Benefits of using Sphinx documentation format

2021-07-12 Thread Martin Liška
Hello. Let's make it a separate sub-thread where we can discuss motivation why do I want moving to Sphinx format. Benefits: 1) modern looking HTML output (before: [1], after: [2]): a) syntax highlighting for examples (code, shell commands, etc.) b) precise anchors, the current Texinfo

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
* Florian Weimer: > is included indirectly in the #pragma GCC visibility hidden > block. With glibc 2.34, needs a declaration of the sysconf > function, and including it under hidden visibility turns other calls > to sysconf into hidden references, leading to a linker failure. > >

[Ada] Implement support for unconstrained array types with FLB

2021-07-12 Thread Pierre-Marie de Rodat
The fixed lower bound also makes it possible to simplify the formula of the upper bound used for unconstrained array types. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * gcc-interface/decl.c (gnat_to_gnu_entity) : Use a fixed lower bound if the index subtype is

[Ada] Clean up Uint fields

2021-07-12 Thread Pierre-Marie de Rodat
We add new field types Valid_Uint, Unat, Upos, Nonzero_Uint, which have predicates that assert the value is a proper Uint value (i.e. not No_Uint), and that the value is appropriate. It is not clear that Nonzero_Uint is needed, but it is useful in testing; we can always remove it later. We use

[Ada] Add DWARF 5 support to System.Dwarf_Line

2021-07-12 Thread Pierre-Marie de Rodat
The encoding of the debugging line information has substantially changed in DWARF 5, so this adds the support for it alongside the existing code. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/s-dwalin.ads: Adjust a few comments left and right.

[Ada] Duplicate Size/Value_Size clause

2021-07-12 Thread Pierre-Marie de Rodat
Give a warning if both Size and Value_Size attributes are specified for the same type. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_ch13.adb (Duplicate_Clause): Add a helper routine Check_One_Attr, with a parameter for the attribute_designator we are

Re: [PATCH take 2] PR tree-optimization/38943: Preserve trapping instructions with -fpreserve-traps

2021-07-12 Thread Richard Biener via Gcc-patches
On Mon, Jul 12, 2021 at 2:22 PM Eric Botcazou wrote: > > > There's still the open question what -fnon-call-exceptions on its > > own should do - IMHO it doesn't make sense to allow unwiding > > from a trapping memory reference but not from the call it resides > > in which means

RE: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-07-12 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Sandiford > Sent: Monday, July 12, 2021 11:26 AM > To: Tamar Christina > Cc: Richard Biener ; nd ; gcc- > patc...@gcc.gnu.org > Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product > where the sign for the multiplicant changes. > >

Re: [PATCH take 2] PR tree-optimization/38943: Preserve trapping instructions with -fpreserve-traps

2021-07-12 Thread Eric Botcazou
> There's still the open question what -fnon-call-exceptions on its > own should do - IMHO it doesn't make sense to allow unwiding > from a trapping memory reference but not from the call it resides > in which means -fnon-call-exceptions should better enable > -fexceptions? Or issue a warning

  1   2   >