Re: [committed] libstdc++: Specialize std::pointer_traits<__normal_iterator>

2021-12-13 Thread François Dumont via Gcc-patches
Hi     Any conclusion regarding this thread ? François On 06/10/21 7:25 pm, François Dumont wrote: I forgot to ask if with this patch this overload:   template     constexpr auto     __to_address(const _Ptr& __ptr, _None...) noexcept     {   if constexpr

Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697] (was: [Patch] Fortran: Handle compare in OpenMP atomic)

2021-12-13 Thread Thomas Schwinge
Hi Tobias! On 2021-12-13T12:19:50+0100, Tobias Burnus wrote: > Implement the 'compare' part in trans-openmp of OpenMP 5.1's atomic changes > plus a couple of bugfixes throughout. Hmm, I wonder why you didn't see the few regressions in your testing? Pushed to master branch commit

Re: [PATCH] [Gimple] Fix ICE. [PR103682]

2021-12-13 Thread Andrew Pinski via Gcc-patches
On Mon, Dec 13, 2021 at 8:59 PM liuhongt via Gcc-patches wrote: > > Check is_gimple_assign before gimple_assign_rhs_code. > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > Ok for trunk? > > gcc/ChangeLog: > > PR target/103682 > * tree-ssa-ccp.c

[PATCH] [Gimple] Fix ICE. [PR103682]

2021-12-13 Thread liuhongt via Gcc-patches
Check is_gimple_assign before gimple_assign_rhs_code. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ok for trunk? gcc/ChangeLog: PR target/103682 * tree-ssa-ccp.c (optimize_atomic_bit_test_and): Check is_gimple_assign before gimple_assign_rhs_code.

Re: [PATCH, rs6000] new split pattern for TI to V1TI move [PR103124]

2021-12-13 Thread HAO CHEN GUI via Gcc-patches
Hi Segher, Thanks for your advice. Please see my comments. On 14/12/2021 上午 6:59, Segher Boessenkool wrote: > Hi! > > On Mon, Dec 13, 2021 at 05:22:06PM -0500, David Edelsohn wrote: >> On Sun, Dec 12, 2021 at 10:00 PM HAO CHEN GUI wrote: >>> --- a/gcc/config/rs6000/vsx.md >>> +++

Re: [PATCH v2] regrename: Skip renaming if instruction is noop move.

2021-12-13 Thread Jojo R via Gcc-patches
Hi, Thank you for your review & help. I could not fetch the merged patch from gcc master of git. Is there any problem for this ? Thanks. — Jojo 在 2021年12月3日 +0800 PM10:57,Jeff Law ,写道: > > > On 12/2/2021 9:26 PM, Jojo R wrote: > > Skip renaming if instruction is noop

Re: [PATCH] rs6000: Some builtins require IBM-128 long double format (PR103623)

2021-12-13 Thread Segher Boessenkool
Hi! On Mon, Dec 13, 2021 at 09:55:17AM -0600, Bill Schmidt wrote: > PR103623 shows that we ICE if __builtin_pack_longdouble or > __builtin_unpack_longdouble > is used when long double is not defined to be the IBM-128 (double-double) > format. > To solve this, I introduce a new built-in function

[r12-5944 Regression] FAIL: gcc.target/i386/pr99531.c scan-assembler-not push on Linux/x86_64

2021-12-13 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, a7acb6dca941db2b1c135107dac3a34a20650d5c is the first bad commit commit a7acb6dca941db2b1c135107dac3a34a20650d5c Author: Vladimir N. Makarov Date: Mon Dec 13 13:48:12 2021 -0500 [PR99531] Modify pseudo class cost calculation when processing move involving the pseudo and

Re: [PATCH] c: Fix ICE on deferred pragma in unknown attribute arguments [PR103587]

2021-12-13 Thread Joseph Myers
On Mon, 13 Dec 2021, Jakub Jelinek via Gcc-patches wrote: > Hi! > > We ICE on the following testcase, because c_parser_balanced_token_sequence > when encountering a deferred pragma will just use c_parser_consume_token > which the FE doesn't allow for CPP_PRAGMA tokens (and if that wasn't > the

SV: SV: [PATCH v2] jit: Add support for global rvalue initialization and ctors

2021-12-13 Thread Petter Tomner via Gcc-patches
Hi! Thanks for the review. Having proper grammar in user facing text is important so I in no way feel it is overzealous. I'll push the patch once I fixed the points mentioned in the review. Regards, Petter Från: David Malcolm Skickat: den 13 december 2021 20:22 Till: Antoni Boucher; Petter

Re: [PATCH] PR target/32803: Add -Oz option for improved clang compatibility.

2021-12-13 Thread Joseph Myers
This is missing an invoke.texi update for the new option. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] rs6000: __builtin_darn[_raw] should be in [power9-64] (PR103624)

2021-12-13 Thread Segher Boessenkool
On Mon, Dec 13, 2021 at 02:37:43PM -0600, Bill Schmidt wrote: > On 12/13/21 10:54 AM, Segher Boessenkool wrote: > > On Mon, Dec 13, 2021 at 11:30:28AM -0500, David Edelsohn wrote: > >> On Mon, Dec 13, 2021 at 10:48 AM Bill Schmidt > >> wrote: > >>> PR103624 observes that we get segfaults for the

Re: [PATCH v3 06/12] LoongArch Port: Builtin macros.

2021-12-13 Thread Joseph Myers
On Fri, 10 Dec 2021, Chenghua Xu wrote: > + /* Macros dependent on the C dialect. */ > + if (preprocessing_asm_p ()) > +{ > + builtin_define_std ("LANGUAGE_ASSEMBLY"); > + builtin_define ("_LANGUAGE_ASSEMBLY"); > +} > + else if (c_dialect_cxx ()) > +{ > +

Re: [PATCH] c++: processing_template_decl vs template depth [PR103408]

2021-12-13 Thread Jason Merrill via Gcc-patches
On 12/13/21 16:28, Patrick Palka wrote: On Sun, 12 Dec 2021, Jason Merrill wrote: On 12/10/21 14:12, Patrick Palka wrote: We use processing_template_decl in two slightly different ways: as a flag to signal that we're dealing with templated trees, and its magnitude is also used as a proxy for

Re: [PATCH RFC] c++: add color to function decl printing

2021-12-13 Thread Jonathan Wakely via Gcc-patches
On Mon, 13 Dec 2021 at 19:22, Martin Sebor wrote: > On 12/11/21 10:39 PM, Jason Merrill via Gcc-patches wrote: > > In reading C++ diagnostics, it's often hard to find the name of the > function > > in the middle of the template header, return type, parameters, and > template > > arguments. So

Re: [PATCH, rs6000] new split pattern for TI to V1TI move [PR103124]

2021-12-13 Thread Segher Boessenkool
Hi! On Mon, Dec 13, 2021 at 05:22:06PM -0500, David Edelsohn wrote: > On Sun, Dec 12, 2021 at 10:00 PM HAO CHEN GUI wrote: > > --- a/gcc/config/rs6000/vsx.md > > +++ b/gcc/config/rs6000/vsx.md > > @@ -6589,3 +6589,19 @@ (define_insn "xxeval" > > [(set_attr "type" "vecperm") > >

Re: [PATCH, rs6000] new split pattern for TI to V1TI move [PR103124]

2021-12-13 Thread David Edelsohn via Gcc-patches
On Sun, Dec 12, 2021 at 10:00 PM HAO CHEN GUI wrote: > > Hi, >This patch defines a new split pattern for TI to V1TI move. The pattern > concatenates two subreg:DI of > a TI to a V2DI, then move the V2DI to V1TI. With the pattern, the subreg pass > can do register split for > TI when there

Re: [PATCH] c++: processing_template_decl vs template depth [PR103408]

2021-12-13 Thread Patrick Palka via Gcc-patches
On Sun, 12 Dec 2021, Jason Merrill wrote: > On 12/10/21 14:12, Patrick Palka wrote: > > We use processing_template_decl in two slightly different ways: as > > a flag to signal that we're dealing with templated trees, and its > > magnitude is also used as a proxy for the current syntactic template

Re: [PATCH] rs6000: Some builtins require IBM-128 long double format (PR103623)

2021-12-13 Thread Bill Schmidt via Gcc-patches
Hi! On 12/13/21 2:15 PM, Martin Sebor wrote: > On 12/13/21 8:55 AM, Bill Schmidt via Gcc-patches wrote: >> Hi! >> >> PR103623 shows that we ICE if __builtin_pack_longdouble or >> __builtin_unpack_longdouble >> is used when long double is not defined to be the IBM-128 (double-double) >> format.

Re: [PATCH] rs6000: __builtin_darn[_raw] should be in [power9-64] (PR103624)

2021-12-13 Thread Bill Schmidt via Gcc-patches
Hi! On 12/13/21 10:54 AM, Segher Boessenkool wrote: > On Mon, Dec 13, 2021 at 11:30:28AM -0500, David Edelsohn wrote: >> On Mon, Dec 13, 2021 at 10:48 AM Bill Schmidt wrote: >>> Hi! >>> >>> PR103624 observes that we get segfaults for the 64-bit darn builtins when >>> compiled >>> on a 32-bit

Re: [PATCH, v2] PR libfortran/103634 - Runtime crash with PACK on zero-sized arrays

2021-12-13 Thread Harald Anlauf via Gcc-patches
Works better with patch attached... Am 13.12.21 um 21:25 schrieb Harald Anlauf via Gcc-patches: Hi Mikael, Am 09.12.21 um 21:37 schrieb Mikael Morin: Hello, On 09/12/2021 21:05, Harald Anlauf via Fortran wrote: Dear all, I had thought that we had fixed this in the past (see PR31001), but

[PATCH, v2] PR libfortran/103634 - Runtime crash with PACK on zero-sized arrays

2021-12-13 Thread Harald Anlauf via Gcc-patches
Hi Mikael, Am 09.12.21 um 21:37 schrieb Mikael Morin: Hello, On 09/12/2021 21:05, Harald Anlauf via Fortran wrote: Dear all, I had thought that we had fixed this in the past (see PR31001), but it did fail for me with all gcc versions I have tried (7-12) for a slightly more elaborate case as

Re: [PATCH] rs6000: Some builtins require IBM-128 long double format (PR103623)

2021-12-13 Thread Martin Sebor via Gcc-patches
On 12/13/21 8:55 AM, Bill Schmidt via Gcc-patches wrote: Hi! PR103623 shows that we ICE if __builtin_pack_longdouble or __builtin_unpack_longdouble is used when long double is not defined to be the IBM-128 (double-double) format. To solve this, I introduce a new built-in function attribute

Re: Results for 12.0.0 20211211 (experimental) [master revision r12-5905-g0bceef1671ad] (GCC) testsuite on x86_64-apple-darwin18

2021-12-13 Thread Iain Sandoe via Gcc-patches
> On 13 Dec 2021, at 20:08, Iain Sandoe via Gcc-patches > wrote: > > LAST_UPDATED: Sat Dec 11 00:18:47 UTC 2021 (revision r12-5905-g0bceef1671ad) > sorrry .. I hate autocompletions… Iain >

Results for 12.0.0 20211211 (experimental) [master revision r12-5905-g0bceef1671ad] (GCC) testsuite on x86_64-apple-darwin18

2021-12-13 Thread Iain Sandoe via Gcc-patches
LAST_UPDATED: Sat Dec 11 00:18:47 UTC 2021 (revision r12-5905-g0bceef1671ad) === acats tests === === acats Summary === # of expected passes2328 # of unexpected failures0 Native configuration is x86_64-apple-darwin18 === g++

[PATCH] testsuite: Robustify aarch64/simd tests against more aggressive DCE

2021-12-13 Thread Marc Poulhiès via Gcc-patches
Hello, We've observed that some aarch64 tests can fail if DCE is made more aggressive as it removes the builtin calls being tested for errors. This patch simply adds a LHS to these builtin calls to make sure DCE does not remove them at -O0. This patch has been tested on aarch64-elf. Ok to

Re: [PATCH RFC] c++: add color to function decl printing

2021-12-13 Thread Martin Sebor via Gcc-patches
On 12/11/21 10:39 PM, Jason Merrill via Gcc-patches wrote: In reading C++ diagnostics, it's often hard to find the name of the function in the middle of the template header, return type, parameters, and template arguments. So let's colorize it, and maybe the template argument bindings while

Re: SV: [PATCH v2] jit: Add support for global rvalue initialization and ctors

2021-12-13 Thread David Malcolm via Gcc-patches
On Sun, 2021-12-12 at 20:39 -0500, Antoni Boucher wrote: > Yes, this patch works for rustc_codegen_gcc perfectly. > It even fixes one issue that was in my patch, so that's nice! Excellent - thanks Antoni. > > Le samedi 11 décembre 2021 à 15:35 +, Petter Tomner a écrit : > > Hi! > > > > >

Re: testsuite: Be more informative for ICEs

2021-12-13 Thread David Malcolm via Gcc-patches
On Mon, 2021-12-13 at 10:53 -0700, Martin Sebor via Gcc-patches wrote: > On 12/10/21 3:42 PM, Thomas Schwinge wrote: > > Hi! > > > > OK to push the attached "testsuite: Be more informative for ICEs"? > > Adding more detail here seems like a useful improvement to me. > > Martin Agreed. I don't

[committed][PR99531] IRA:Modify pseudo class cost calculation when processing move involving the pseudo and a hard register

2021-12-13 Thread Vladimir Makarov via Gcc-patches
The following patch solves https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99531 The patch was successfully bootstrapped and tested on x86-64, aarch64, and ppc64. After some observation, if all is ok, I will commit the patch into gcc release branches mentioned in the PR. [PR99531] Modify

[r12-5926 Regression] FAIL: gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 -O at line 53 (test for warnings, line 28) on Linux/x86_64

2021-12-13 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 494ebfa7c9aacaeb6ec1fccc47a0e49f31eb2bb8 is the first bad commit commit 494ebfa7c9aacaeb6ec1fccc47a0e49f31eb2bb8 Author: Tobias Burnus Date: Mon Dec 13 12:37:40 2021 +0100 Fortran: Handle compare in OpenMP atomic caused FAIL:

Re: [PATCH] vect: Add bias parameter for partial vectorization

2021-12-13 Thread Robin Dapp via Gcc-patches
Hi Richard, I incorporated all your remarks (sorry for the hunk from a different branch) except for this one: > Think it would be better to make it: > > if (use_bias_adjusted_len) > { > gcc_assert (i == 0); > > But do we need to do this? Code should only care

Re: [PATCH] gcc/diagnostic.c: make -Werror message more helpful

2021-12-13 Thread Martin Sebor via Gcc-patches
On 12/12/21 3:13 AM, Andrea Monaco via Gcc-patches wrote: Hello. I propose to make that message more verbose. It sure would have helped me once. You don't always have a Web search available :) Warnings turned into errors have the [-Werror=...] tag at the end so I'm not sure I see when

Re: testsuite: Be more informative for ICEs

2021-12-13 Thread Martin Sebor via Gcc-patches
On 12/10/21 3:42 PM, Thomas Schwinge wrote: Hi! OK to push the attached "testsuite: Be more informative for ICEs"? Adding more detail here seems like a useful improvement to me. Martin Grüße Thomas - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße

[PATCH] Rework VXWORKS_LINK_SPEC for shared objects support

2021-12-13 Thread Olivier Hainque via Gcc-patches
This change reworks the VXWORKS_LINK_SPEC a bit to fix a couple of issues observed while working on improving the support for shared objects, in particular differences between vxworks 7 and earlier regarding the need to pass specific linker options. It also introduces an internal

[PATCH] Remove ppc*-vxworks7* inadequate libgcc Makefile fragments

2021-12-13 Thread Olivier Hainque via Gcc-patches
This change removes a couple of entries from the tmake_file list for ppc-vxworks7*, in particular: t-linux, which assigns .so version numbers to a set of symbols, some of which aren't included the VxWorks libgcc on powerpc (from ibm-ldouble.c, in particular). t-slibgcc-libgcc, which yields a

[PATCH] Remove special case for arm-vxworks on the use of vxcrtstuff

2021-12-13 Thread Olivier Hainque via Gcc-patches
The special case for arm on the use of vxcrtstuff is not needed any more after the previous patches in this area. Cheers, Olivier 2021-12-13 Olivier Hainque libgcc/ * config.host (*vxworks*): Remove special case for arm on the use of vxcrtstuff.

[PATCH] Tigthen libc_internal and vxcrtstuff for VxWorks shared objects

2021-12-13 Thread Olivier Hainque via Gcc-patches
This change tightens and documents the use of libc_internal, then strengthens the VxWorks crtstuff objects for the support of shared libraries. In particular: - Define __dso_handle, which libstdc++.so requires, - Provide _init and _fini functions to run through the init/fini arrays for shared

Ping: [PATCH 3/3] Use absolute switch table addresses for zero cycle moves.

2021-12-13 Thread Michael Meissner via Gcc-patches
Ping patch. | Date: Fri, 19 Nov 2021 09:57:49 -0500 | From: Michael Meissner | Subject: [PATCH 3/3] Use absolute switch table addresses for zero cycle moves. | Message-ID: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585007.html Note, I will on-line through December 20th. I will

Ping: [PATCH 2/3] Set power10 fusion if -mtune=power10.

2021-12-13 Thread Michael Meissner via Gcc-patches
Ping patch. | Date: Fri, 19 Nov 2021 09:55:50 -0500 | From: Michael Meissner | Subject: [PATCH 2/3] Set power10 fusion if -mtune=power10. | Message-ID: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585006.html Note, I will be on-line through December 20th. I will be off-line

Ping: [PATCH 1/3] Add power10 zero cycle moves for switches & indirect jumps

2021-12-13 Thread Michael Meissner via Gcc-patches
Ping patch. | Date: Fri, 19 Nov 2021 09:53:14 -0500 | From: Michael Meissner | Subject: [PATCH 1/3] Add power10 zero cycle moves for switches & indirect jumps | Message-ID: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585005.html Note, I will on-line through December 20th. I will

Ping #2: [PATCH 5/5] Add Power10 XXSPLTIDP for SFmode/DFmode constants.

2021-12-13 Thread Michael Meissner via Gcc-patches
Ping patch #2. | Date: Fri, 5 Nov 2021 00:11:20 -0400 | From: Michael Meissner | Subject: [PATCH 5/5] Add Power10 XXSPLTIDP for SFmode/DFmode constants. | Message-ID: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/583394.html Note, I will be on-line through December 20th. I will be

Ping #2: [PATCH 4/5] Add Power10 XXSPLTIDP for vector constants

2021-12-13 Thread Michael Meissner via Gcc-patches
Ping patch #2. | Date: Fri, 5 Nov 2021 00:10:18 -0400 | From: Michael Meissner | Subject: [PATCH 4/5] Add Power10 XXSPLTIDP for vector constants | Message-ID: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/583393.html Note, I will be on-line through December 20th. I will be off-line

Ping #2: [PATCH 3/5] Add Power10 XXSPLTIW

2021-12-13 Thread Michael Meissner via Gcc-patches
Ping patch #2. | Date: Fri, 5 Nov 2021 00:09:07 -0400 | From: Michael Meissner | Subject: [PATCH 3/5] Add Power10 XXSPLTIW | Message-ID: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/583392.html Note, I will on-line through December 20th. I will be off-line after that until

Ping #2: [PATCH 2/5] Add Power10 XXSPLTI* and LXVKQ instructions (LXVKQ)

2021-12-13 Thread Michael Meissner via Gcc-patches
Ping patch #2. | Date: Fri, 5 Nov 2021 00:07:05 -0400 | From: Michael Meissner | Subject: [PATCH 2/5] Add Power10 XXSPLTI* and LXVKQ instructions (LXVKQ) | Message-ID: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/583391.html Note, I will on-line until December 20th, and then

Ping #2: [PATCH 1/5] Add XXSPLTI* and LXVKQ instructions (new data structure and function)

2021-12-13 Thread Michael Meissner via Gcc-patches
Ping patch. | Date: Fri, 5 Nov 2021 00:04:40 -0400 | From: Michael Meissner | Subject: [PATCH 1/5] Add XXSPLTI* and LXVKQ instructions (new data structure and function) | Message-ID: Note, I will on-line until December 20th, and then I won't be on-line until January. -- Michael Meissner,

[PATCH] VxWorks config fixes for shared objects

2021-12-13 Thread Olivier Hainque via Gcc-patches
This strengthens the VxWorks configuration files on the support of shared objects, which encompasses a VxWorks specific "non-static" mode for RTPs (in addition to -static and -shared). I had good builds and test results with this in-house for gcc-11 based toolchains for a variety of targets,

Re: [PATCH] rs6000: __builtin_darn[_raw] should be in [power9-64] (PR103624)

2021-12-13 Thread Segher Boessenkool
On Mon, Dec 13, 2021 at 11:30:28AM -0500, David Edelsohn wrote: > On Mon, Dec 13, 2021 at 10:48 AM Bill Schmidt wrote: > > > > Hi! > > > > PR103624 observes that we get segfaults for the 64-bit darn builtins when > > compiled > > on a 32-bit architecture. The old built-in infrastructure

Re: [Patch 7/8 V3] Arm: Emit build attributes for PACBTI target feature.

2021-12-13 Thread Andrea Corallo via Gcc-patches
Richard Earnshaw writes: [...] > > Sorry, I've just been looking at this again and noted the following: > > + if (TARGET_HAVE_PACBTI) > + { > + arm_emit_eabi_attribute ("Tag_PAC_extension", 50, 2); > + arm_emit_eabi_attribute ("Tag_BTI_extension", 52, 2); > +

PING 2 [PATCH v2 2/2] add -Wdangling-pointer [PR #63272]

2021-12-13 Thread Martin Sebor via Gcc-patches
Ping. This patch, originally submitted on Nov. 1, has not been reviewed yet. https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585819.html On 12/6/21 5:51 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585819.html On 11/30/21 3:55 PM, Martin Sebor

PING 2 [PATCH v2 1/2] add -Wuse-after-free

2021-12-13 Thread Martin Sebor via Gcc-patches
Ping. Jeff, I addressed your comments in the updated patch. If there are no other changes is the last revision okay to commit? https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585816.html On 12/6/21 5:50 PM, Martin Sebor wrote: Ping:

Re: [vect] Re-analyze all modes for epilogues

2021-12-13 Thread Andre Vieira (lists) via Gcc-patches
Hi, Added an extra step to skip unusable epilogue modes when we know the target does not support predication. This uses a new function 'support_predication_p' that is generated at build time and checks whether the target supports at least one optab that can be used for predicated

Re: Add -fipa-strict-aliasing

2021-12-13 Thread Jakub Jelinek via Gcc-patches
On Mon, Dec 13, 2021 at 05:31:22PM +0100, Jan Hubicka via Gcc-patches wrote: > +@item -fipa-strict-aliasing > +@opindex fipa-strict-aliasing > +Constrols whether rules of @option{-fstrict-aliasing} are applied across s/Constrols/Controls/ > +function boundaries. Note that if multiple functions

Re: Add -fipa-strict-aliasing

2021-12-13 Thread Jan Hubicka via Gcc-patches
Hi, this is a variant I comitted (with updated documentation as Richard requested). Honza gcc/ChangeLog: 2021-12-13 Jan Hubicka * common.opt: Add -fipa-strict-aliasing. * doc/invoke.texi: Document -fipa-strict-aliasing. * ipa-modref.c

Re: [PATCH] rs6000: __builtin_darn[_raw] should be in [power9-64] (PR103624)

2021-12-13 Thread David Edelsohn via Gcc-patches
On Mon, Dec 13, 2021 at 10:48 AM Bill Schmidt wrote: > > Hi! > > PR103624 observes that we get segfaults for the 64-bit darn builtins when > compiled > on a 32-bit architecture. The old built-in infrastructure requires > TARGET_64BIT, and > this was missed in the new support. Moving these two

Re: [PATCH] rs6000: Builtins for doubleword compare should be in [power8-vector] (PR103625)

2021-12-13 Thread David Edelsohn via Gcc-patches
On Mon, Dec 13, 2021 at 11:02 AM Bill Schmidt wrote: > > Hi! > > PR103625 observes that we ICE when doing vector compares on doublewords. > The original built-in function support requires Power8 vector support for > these, but this was missed in the new built-in support. Moving these > functions

[PATCH] rs6000: Skip overload instances with uninitialized fntype (PR103622)

2021-12-13 Thread Bill Schmidt via Gcc-patches
Hi! For some data types like IEEE-128, we determine whether the type is available at built-in function initialization time. If it's not, then we don't provide the function type for function instances that require the data type. PR103622 observes that this can cause us to ICE when running the

Re: Terminate BB analysis on NULL pointer access in ipa-pure-const and ipa-modref

2021-12-13 Thread Jeff Law via Gcc-patches
On 12/12/2021 12:57 PM, Jan Hubicka wrote: On 12/12/2021 3:49 AM, Jan Hubicka via Gcc-patches wrote: Hi, As discussed in the PR, we miss some optimization becuase gimple-ssa-isolate-paths turns NULL memory accesses to volatile and adds __builtin_trap after them. This is seen as a

[PATCH] rs6000: Builtins for doubleword compare should be in [power8-vector] (PR103625)

2021-12-13 Thread Bill Schmidt via Gcc-patches
Hi! PR103625 observes that we ICE when doing vector compares on doublewords. The original built-in function support requires Power8 vector support for these, but this was missed in the new built-in support. Moving these functions to the [power8-vector] stanza solves the problem. Tested the fix

[PATCH] rs6000: Some builtins require IBM-128 long double format (PR103623)

2021-12-13 Thread Bill Schmidt via Gcc-patches
Hi! PR103623 shows that we ICE if __builtin_pack_longdouble or __builtin_unpack_longdouble is used when long double is not defined to be the IBM-128 (double-double) format. To solve this, I introduce a new built-in function attribute "ibmld" that enforces this requirement. Tested the fix on a

[PATCH] rs6000: __builtin_darn[_raw] should be in [power9-64] (PR103624)

2021-12-13 Thread Bill Schmidt via Gcc-patches
Hi! PR103624 observes that we get segfaults for the 64-bit darn builtins when compiled on a 32-bit architecture. The old built-in infrastructure requires TARGET_64BIT, and this was missed in the new support. Moving these two builtins from the [power9] stanza to the [power9-64] stanza solves

Re: [RFC PATCH] tree-ssa-sink: do not sink to in front of setjmp

2021-12-13 Thread Alexander Monakov via Gcc-patches
On Mon, 13 Dec 2021, Richard Biener wrote: > On December 13, 2021 3:25:47 PM GMT+01:00, Alexander Monakov > wrote: > >Greetings! > > > >While testing our patch that reimplements -Wclobbered on GIMPLE we found > >a case where tree-ssa-sink moves a statement to a basic block in front > >of a

Re: [PATCH] c++: remove COMPOUND_EXPR_OVERLOADED flag

2021-12-13 Thread Jason Merrill via Gcc-patches
On 12/10/21 10:48, Patrick Palka wrote: This flag is never set because non-dependent COMPOUND_EXPRs are fully resolved into a CALL_EXPR at template definition time (in build_x_compound_expr) ever since r6-5772. Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk?

Re: [PATCH] c++: don't leak 'arglist' in build_new_op

2021-12-13 Thread Jason Merrill via Gcc-patches
On 12/10/21 11:21, Patrick Palka wrote: 'arglist' can be captured by a conversion within 'candidates', but if we use a releasing_vec then we'll be sure to free it only after 'candidates' is freed by obstack_free. Bootstrapped and regtested in x86_64-pc-linux-gnu, does this look OK for trunk?

Re: GCC 11 backport does not build (no "directly_supported_p") - was: Re: pr103523: Check for PLUS/MINUS support

2021-12-13 Thread Joel Hutton via Gcc-patches
My mistake, reworked patch. Tests are still running. From: Richard Biener Sent: 13 December 2021 14:47 To: gcc-patches@gcc.gnu.org ; Tobias Burnus ; Joel Hutton ; Richard Sandiford Cc: GCC Patches ; Richard Biener Subject: Re: GCC 11 backport does not build

Re: [PATCH] c++: Allow constexpr decltype(auto) [PR102229]

2021-12-13 Thread Jason Merrill via Gcc-patches
On 12/10/21 17:29, Marek Polacek wrote: My r11-2202 was trying to enforce [dcl.type.auto.deduct]/4, which says "If the placeholder-type-specifier is of the form type-constraint[opt] decltype(auto), T shall be the placeholder alone." But this made us reject 'constexpr decltype(auto)', which,

[PATCH v2 RFC] c++: add color to function decl printing

2021-12-13 Thread Jason Merrill via Gcc-patches
On 12/13/21 06:02, Jonathan Wakely wrote: On Sun, 12 Dec 2021 at 05:39, Jason Merrill > wrote: > > In reading C++ diagnostics, it's often hard to find the name of the function > in the middle of the template header, return type, parameters, and template >

Re: [PATCH] PR target/103611: Avoid generating orb $0, %ah on x86.

2021-12-13 Thread Uros Bizjak via Gcc-patches
On Mon, Dec 13, 2021 at 1:09 PM Roger Sayle wrote: > > > I'll post my proposed fix for PR target/103611 shortly, but this patch > fixes another missed optimization opportunity revealed by that PR. > Occasionally, reload materializes integer constants during register > allocation sometimes

Re: GCC 11 backport does not build (no "directly_supported_p") - was: Re: pr103523: Check for PLUS/MINUS support

2021-12-13 Thread Richard Biener via Gcc-patches
On December 13, 2021 3:27:50 PM GMT+01:00, Tobias Burnus wrote: >Hi Joel, > >your patch fails here with: > >../../repos/gcc-11-commit/gcc/tree-vect-loop.c:8000:8: error: >‘directly_supported_p’ was not declared in this scope > 8000 |   if (!directly_supported_p (PLUS_EXPR, step_vectype) >

Re: [RFC PATCH] tree-ssa-sink: do not sink to in front of setjmp

2021-12-13 Thread Richard Biener via Gcc-patches
On December 13, 2021 3:25:47 PM GMT+01:00, Alexander Monakov wrote: >Greetings! > >While testing our patch that reimplements -Wclobbered on GIMPLE we found >a case where tree-ssa-sink moves a statement to a basic block in front >of a setjmp call. > >I am confident that this is unintended and

[PATCH][4/4][committed] aarch64: Add command-line support for Armv8.8-a

2021-12-13 Thread Kyrylo Tkachov via Gcc-patches
Hi all, This final patch in the series is much simpler and adds command-line support for -march=armv8.8-a, making use of the +mops features added in the previous patches. Bootstrapped and tested on aarch64-none-linux-gnu. Pushing to trunk. Thanks, Kyrill gcc/ChangeLog: *

[PATCH][3/4][committed] aarch64: Use +mops to inline memset operations

2021-12-13 Thread Kyrylo Tkachov via Gcc-patches
Hi all, This 3rd patch in the series adds an inline sequence for the memset operation. The aarch64-mops-memset-size-threshold param is added to control the size threshold for the sequence. Its default setting is 256, which may seem a bit high, but it is consistent with the current SIMD memset

[PATCH][2/4][committed] aarch64: Add memmove expansion for +mops

2021-12-13 Thread Kyrylo Tkachov via Gcc-patches
Hi all, This second patch in the series adds an inline movmem expansion for TARGET_MOPS that emits the recommended sequence. A new param aarch64-mops-memmove-size-threshold is added to control the memmove size threshold for this expansion. Its default value is zero to be consistent with the

[PATCH][1/4][committed] aarch64: Add support for Armv8.8-a memory operations and memcpy expansion

2021-12-13 Thread Kyrylo Tkachov via Gcc-patches
Hi all, This patch adds the +mops architecture extension flag from the 2021 Arm Architecture extensions, Armv8.8-a. The +mops extensions introduce instructions to accelerate the memcpy, memset, memmove standard functions. The first patch here uses the instructions in the inline memcpy

GCC 11 backport does not build (no "directly_supported_p") - was: Re: pr103523: Check for PLUS/MINUS support

2021-12-13 Thread Tobias Burnus
Hi Joel, your patch fails here with: ../../repos/gcc-11-commit/gcc/tree-vect-loop.c:8000:8: error: ‘directly_supported_p’ was not declared in this scope 8000 |   if (!directly_supported_p (PLUS_EXPR, step_vectype) |    ^~~~ And "git grep" shows that this is only

[RFC PATCH] tree-ssa-sink: do not sink to in front of setjmp

2021-12-13 Thread Alexander Monakov via Gcc-patches
Greetings! While testing our patch that reimplements -Wclobbered on GIMPLE we found a case where tree-ssa-sink moves a statement to a basic block in front of a setjmp call. I am confident that this is unintended and should be considered invalid GIMPLE. One of the edges incoming to a setjmp BB

[PATCH] x86: PR target/103611: Splitter for DST:DI = (HI:SI<<32)|LO:SI.

2021-12-13 Thread Roger Sayle
A common idiom is to create a DImode value from the "concat" of two SImode values, using "(long long)hi << 32 | (long long)lo", where the operation may be ior, xor or plus. On x86, with -m32, the high and low parts of a DImode register are actually different SImode registers (typically %edx and

[PATCH] Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7

2021-12-13 Thread Olivier Hainque via Gcc-patches
The unconditional assignment performed in t-vxworks to handle include flags currently overrides what specific cpu ports had for the regular (!vxworks) crtstuff objects. This was not done on purpose and the proposed change adjusts the configuration bits to apply the vxworks specific flags on top

Re: [PATCH v4 1/1] [ARM] Add support for TLS register based stack protector canary access

2021-12-13 Thread Ard Biesheuvel via Gcc-patches
On Wed, 17 Nov 2021 at 10:09, Ramana Radhakrishnan wrote: > > Thanks Ard and Qing. > > > > I have been busy with other things in the last few weeks and I don’t work on > GCC as part of my day job : however I’ll try to find some time to review this > patch set in the coming days. > > Hello

[PATCH] Include yvals.h for VxWorks < 7 RTPs as well

2021-12-13 Thread Olivier Hainque via Gcc-patches
Hello, For -mrtp on VxWorks 6.9, at least inttypes.h ends up #including system headers checking that _BITS_BYTES is 8, which the system yvals.h defines. We do pre-include _yvals.h ahead of inttypes.h for this kind of purpose, but it currently assumes that only VxWorks >= 7 provides yvals.h. This

RE: [PATCH][GCC] aarch64: Add LS64 extension and intrinsics

2021-12-13 Thread Przemyslaw Wirkus via Gcc-patches
Hello Richard, I've updated my patch following all your comments. Thank you. Boostrapped on aarch64-linux-gnu and all new ACLE tests pass. OK to install? gcc/ChangeLog: * config/aarch64/aarch64-builtins.c (enum aarch64_builtins): Define AARCH64_LS64_BUILTIN_LD64B,

[committed] libstdc++: Add support for '?' in linker script globs

2021-12-13 Thread Jonathan Wakely via Gcc-patches
Pushed to trunk. The scripts/make_exports.pl script used for darwin only replaces '*' wildcards in globs, it doesn't handle '?'. This means the recent changes to std::__timepunct exports broke darwin. Rather than use mangled names in the linker script, this adds support for '?' to the perl

[PATCH] PR target/103611: Avoid generating orb $0, %ah on x86.

2021-12-13 Thread Roger Sayle
I'll post my proposed fix for PR target/103611 shortly, but this patch fixes another missed optimization opportunity revealed by that PR. Occasionally, reload materializes integer constants during register allocation sometimes resulting in unnecessary instructions such as: (insn 23 31 24 2

[PATCH v3] tree-optimization/101186 - extend FRE with "equivalence map" for condition prediction

2021-12-13 Thread Di Zhao OS via Gcc-patches
A few minor updates on the patch: - Simplify function record_equiv_from_prev_phi_1 by removing an argument. - Fixed two small bugs that can lead to losing optimize opportunities. Thanks, Di Zhao --- Extend FRE with temporary equivalences. 2021-12-13 Di Zhao gcc/ChangeLog: PR

Re: [Patch] Fortran: Handle compare in OpenMP atomic

2021-12-13 Thread Jakub Jelinek via Gcc-patches
On Mon, Dec 13, 2021 at 12:19:50PM +0100, Tobias Burnus wrote: > Some Sunday work ... > Implement the 'compare' part in trans-openmp of OpenMP 5.1's atomic changes > plus a couple of bugfixes throughout. > > OK? > > Tobias > - > Siemens Electronic Design Automation GmbH;

[Patch] Fortran: Handle compare in OpenMP atomic

2021-12-13 Thread Tobias Burnus
Some Sunday work ... Implement the 'compare' part in trans-openmp of OpenMP 5.1's atomic changes plus a couple of bugfixes throughout. OK? Tobias - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung;

[committed] libstdc++: Make ranges::size and ranges::empty check for unbounded arrays

2021-12-13 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux, pushed to trunk. Passing IncompleteType(&)[] to ranges::begin produces an error outside the immediate context, which is fine for ranges::begin, but it means that we fail to enforce the SFINAE-able constraints for ranges::size and ranges::size. They should not be

[committed] libstdc++: Fix std::regex_replace for strings with embedded null [PR103664]

2021-12-13 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux, pushed to trunk. The overload of std::regex_replace that takes a std::basic_string as the fmt argument (for the replacement string) is implemented in terms of the one taking a const C*, which uses std::char_traits to find the length. That means it stops at a null

Re: [PATCH] #undef isblank before def or decl in libstdc++ headers

2021-12-13 Thread Olivier Hainque via Gcc-patches
> On 11 Dec 2021, at 18:09, Jonathan Wakely wrote: > > * config/vxworks.h (VXWORKS_OS_CPP_BUILTINS): Define > _C99 for C++. > > Makes sense? > > Yes. I can't approve patches outside libstdc++, but that looks definitely > correct for C++11 and later, because C++11

Re: [PATCH] ipa: Careful processing ANCESTOR jump functions and NULL pointers (PR 103083)

2021-12-13 Thread Jan Hubicka via Gcc-patches
> >>> + || (only_for_nonzero && !src_lats->bits_lattice.known_nonzero_p ())) > >>> + { > >>> + if (jfunc->bits) > >>> + return dest_lattice->meet_with (jfunc->bits->value, > >>> + jfunc->bits->mask, precision); > >>> + else > >>> + return

Re: [PATCH RFC] c++: add color to function decl printing

2021-12-13 Thread Jonathan Wakely via Gcc-patches
On Sun, 12 Dec 2021 at 05:39, Jason Merrill wrote: > > In reading C++ diagnostics, it's often hard to find the name of the function > in the middle of the template header, return type, parameters, and template > arguments. So let's colorize it, and maybe the template argument bindings > while

Re: [PATCH] ipa: Careful processing ANCESTOR jump functions and NULL pointers (PR 103083)

2021-12-13 Thread Martin Jambor
Hello, I would like to ping the patch below. Martin On Mon, Nov 29 2021, Martin Jambor wrote: > Hi, > > On Sat, Nov 27 2021, Jan Hubicka wrote: >>> Hi, >>> >>> IPA_JF_ANCESTOR jump functions are constructed also when the formal >>> parameter of the caller is first checked whether it is NULL

Re: [PATCH v2][GCC] arm: Add support for dwarf debug directives and pseudo hard-register for PAC feature.

2021-12-13 Thread Srinath Parvathaneni via Gcc-patches
Ping!! From: Srinath Parvathaneni Sent: 12 November 2021 18:03 To: gcc-patches@gcc.gnu.org Cc: Kyrylo Tkachov ; Richard Earnshaw ; Tejas Belagod Subject: [PATCH v2][GCC] arm: Add support for dwarf debug directives and pseudo hard-register for PAC feature.

Re: [PATCH 1/3] loop-invariant: Don't move cold bb instructions to preheader in RTL

2021-12-13 Thread Jan Hubicka via Gcc-patches
> > gcc/ChangeLog: > > > > * loop-invariant.c (find_invariants_bb): Check profile count > > before motion. > > (find_invariants_body): Add argument. > > --- > > gcc/loop-invariant.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git

Re: [PATCH 2/3] Fix incorrect loop exit edge probability [PR103270]

2021-12-13 Thread Jan Hubicka via Gcc-patches
> r12-4526 cancelled jump thread path rotates loop. It exposes a issue in > profile-estimate when predict_extra_loop_exits, outer loop's exit edge > is marked as inner loop's extra loop exit and set with incorrect > prediction, then a hot inner loop will become cold loop finally through >

Re: [PATCH 1/3] loop-invariant: Don't move cold bb instructions to preheader in RTL

2021-12-13 Thread Jan Hubicka via Gcc-patches
> gcc/ChangeLog: > > * loop-invariant.c (find_invariants_bb): Check profile count > before motion. > (find_invariants_body): Add argument. > --- > gcc/loop-invariant.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/gcc/loop-invariant.c

[PATCH] c: Fix ICE on deferred pragma in unknown attribute arguments [PR103587]

2021-12-13 Thread Jakub Jelinek via Gcc-patches
Hi! We ICE on the following testcase, because c_parser_balanced_token_sequence when encountering a deferred pragma will just use c_parser_consume_token which the FE doesn't allow for CPP_PRAGMA tokens (and if that wasn't the case, it could ICE on CPP_PRAGMA_EOL similarly). We don't know in what

Re: [PATCH 3/3] Fix loop split incorrect count and probability

2021-12-13 Thread Xionghu Luo via Gcc-patches
On 2021/12/9 07:47, Jeff Law wrote: >> diff --git a/gcc/tree-ssa-loop-split.c b/gcc/tree-ssa-loop-split.c >> index 3f6ad046623..33128061aab 100644 >> --- a/gcc/tree-ssa-loop-split.c >> +++ b/gcc/tree-ssa-loop-split.c >> >> @@ -607,6 +610,38 @@ split_loop (class loop *loop1) >>   tree