Re: [PATCH v3 06/12] LoongArch Port: Builtin macros.

Hi Joseph, Thanks for your suggestion, Those macros can be removed, we will send the v4 version soon. Are there any problems in this series of patches? In other words, What conditions are required for LoongArch back-end merged? By the way, We are preparing the LoongArch machine to send to

[PATCH] libstdc++, v2: Add %j, %U, %w, %W time_get support, fix %y, %Y, %C, %p [PR77760]

On Thu, Dec 16, 2021 at 03:46:47PM +0100, Jakub Jelinek via Gcc-patches wrote: > glibc strptime passes around some state, what fields in struct tm have been > set and what needs to be finalized through possibly recursive calls, and > at the end performs various finalizations, like applying %p so

Re: [PATCH] [i386][avx512]Add combine splitter to transform vpternlogd/vpcmpeqd/vpxor/vblendvps to vblendvps for ~op0

On Wed, Dec 15, 2021 at 9:26 AM Haochen Jiang via Gcc-patches wrote: > > Hi all, > > This patch fix the regression previously reported on the combine splitter > under '-m32 -march=cascadelake' options. > > Regtested on x86_64-pc-linux-gnu. Ok. > > BRs, > Haochen > > gcc/ChangeLog: > > PR

[pushed] c++: layout of aggregate base with DMI [PR103681]

C++14 changed the definition of 'aggregate' to allow default member initializers, but such classes still need to be considered "non-POD for the purpose of layout" for ABI compatibility with C++11 code. It seems rare to derive from such a class, as evidenced by how long this bug has survived

[PATCH, rs6000] Implement mffscrni pattern

Hi, This patch defines a pattern for mffscrni. If the RN is a constant, it can call gen_rs6000_mffscrni directly. The "rs6000-builtin-new.def" defines prototype for builtin arguments. The pattern "rs6000_set_fpscr_rn" is then broken as the mode of its argument is DI while its corresponding

Re: [RFC] Overflow check in simplifying exit cond comparing two IVs.

Jiufu Guo writes: > Jiufu Guo writes: > >> Richard Biener writes: >> >>> On Mon, 18 Oct 2021, Jiufu Guo wrote: >>> With reference the discussions in: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574334.html https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572006.html

[PATCH, rs6000] new split pattern for TI to V1TI move [PR103124]

Hi, This patch defines a new split pattern for TI to V1TI move. The pattern concatenates two subreg:DI of a TI to a V2DI. With the pattern, the subreg pass can do register split for TI when there is a TI to V1TI move. The patch optimizes one unnecessary "mr" out on P9. The new test case

Re: [PATCH 1/3] loop-invariant: Don't move cold bb instructions to preheader in RTL

On 2021/12/16 19:20, Jan Hubicka wrote: >> >> OK. Comments like? >> >> /* Don't move insn of cold BB out of loop to preheader to reduce calculations >>and register live range in hot loop with cold BB. */ > > Looks good. >> >> >> And maybe some dump log will help tracking in

Re: [PATCH] c++: Improve diagnostic for class tmpl/class redecl [PR103749]

On 12/16/21 17:36, Marek Polacek wrote: For code like template struct bar; struct bar { int baz; }; bar var; we emit a fairly misleading and unwieldy diagnostic: ~ $ g++ -c u.cc u.cc:6:8: error: template argument

[r12-6022 Regression] FAIL: g++.dg/modules/xtreme-header_a.H -std=c++2b (internal compiler error: tree check: expected none of template_decl, have template_decl in add_specializations, at cp/module.cc

On Linux/x86_64, bb2a7f80a98de3febefbb32b1e4898062bdb6af8 is the first bad commit commit bb2a7f80a98de3febefbb32b1e4898062bdb6af8 Author: Patrick Palka Date: Thu Dec 16 13:40:42 2021 -0500 c++: two-stage name lookup for overloaded operators [PR51577] caused FAIL:

[committed] Testsuite: Tweak gcc.dg/20021029-1.c for nios2.

I've checked in the attached patch to fix a testcase that's been failing on nios2 for a while. -Sandra commit 840a22e0fee9e7369a2eb1c9e3c70dcae24a20e4 Author: Sandra Loosemore Date: Thu Dec 16 15:17:14 2021 -0800 Testsuite: Tweak gcc.dg/20021029-1.c for nios2. This test needs

[PATCH] config: Add check whether D compiler works (PR103528)

Hi, This patch extends AC_PROG_GDC so that as well as checking for the existence of a GDC compiler, also validate that it has also been built with libphobos, otherwise warn or fail with the message that GDC is required to build d. Tested on a system running powerpcle-linux both without a D

Re: [PATCH] attribs: Fix wrong error with -Wno-attribute=A::b [PR103649]

On Thu, Dec 16, 2021 at 05:35:55PM -0500, Marek Polacek wrote: > My patch to implement -Wno-attribute=A::b caused a bogus error when > parsing > > [[foo::bar(1, 2)]]; > > when -Wno-attributes=foo::bar was specified on the command line, because > when we create a fake foo::bar attribute and

[PATCH] c++: Improve diagnostic for class tmpl/class redecl [PR103749]

For code like template struct bar; struct bar { int baz; }; bar var; we emit a fairly misleading and unwieldy diagnostic: ~ $ g++ -c u.cc u.cc:6:8: error: template argument required for 'struct bar' 6 | struct bar { |

[PATCH] attribs: Fix wrong error with -Wno-attribute=A::b [PR103649]

My patch to implement -Wno-attribute=A::b caused a bogus error when parsing [[foo::bar(1, 2)]]; when -Wno-attributes=foo::bar was specified on the command line, because when we create a fake foo::bar attribute and insert it into our attribute table, it is created with max_length == 0 which

Re: [patch] Fix PR libfortran/95177, ctype.h functions should not be called with char arguments

Hi Harald, I’m not on the list for now, please keep me in CC so I don’t miss replies. Thought it feels nice to be working on gfortran again :) > However, I am wondering if calling the macros safe_* gives a false > impression of what they actually do. The cases where they are used > with your

Re: [PATCH v4 1/6] tree-object-size: Use trees and support negative offsets

On Fri, Dec 17, 2021 at 12:26:56AM +0530, Siddhesh Poyarekar wrote: > On 12/16/21 21:19, Jakub Jelinek wrote: > > Yes, but please fix up formatting, wholeval should go below old_wholeval. > > Though, perhaps it would be better to: > > > >if (tree_int_cst_compare (oldval, val)) > > return

Re: [PATCH] c++: delayed noexcept in member function template [PR99980]

On 12/16/21 11:00, Marek Polacek wrote: Some time ago I noticed that we don't properly delay parsing of noexcept for member function templates. This patch fixes that. It didn't work because even though we set CP_PARSER_FLAGS_DELAY_NOEXCEPT in cp_parser_member_declaration, member template

Re: [PATCH] c++: nested lambda capturing a capture proxy, part 2 [PR94376]

On 12/16/21 11:28, Patrick Palka wrote: On Wed, 15 Dec 2021, Jason Merrill wrote: On 12/15/21 15:36, Patrick Palka wrote: The r12-5403 fix apparently doesn't handle the case where the inner lambda explicitly rather implicitly captures the capture proxy from the outer lambda, and so we still

Re: [PATCH] c++: ahead-of-time overload set pruning for non-dep calls

On 12/16/21 14:53, Patrick Palka wrote: On Thu, 16 Dec 2021, Patrick Palka wrote: On Wed, 15 Dec 2021, Jason Merrill wrote: On 12/15/21 12:49, Patrick Palka wrote: This patch makes us remember the function selected by overload resolution during ahead of time processing of a non-dependent

Re: [PATCH] i386: simplify cpu_feature handling

Am 15.12.21 um 10:57 schrieb Martin Liška: On 12/14/21 17:12, Jakub Jelinek wrote: I'd use INT_TYPE_SIZE - 1 instead of 31. Otherwise LGTM. Installed with that change, thanks. Moreover, I'm suggesting a simplification: The patch removes unneeded loops for cpu_features2 and CONVERT_EXPR that

[patch] Fix PR libfortran/95177, ctype.h functions should not be called with char arguments

Hi, Functions from should only be called on values that can be represented by unsigned char. On targets where char is a signed type, some of libgfortran calls have undefined behaviour. The solution is to cast the argument to unsigned char type. I’ve defined macros in libgfortran.h to do so,

[PATCH] Use enclosing object size if it's smaller than member [PR 101475]

Enabling vectorization at -O2 caused quite a few tests for warnings to start failing in GCC 12. These tests were xfailed and bugs were opened to track the problems until they can be fully analyzed and ultimately fixed before GCC 12 is released. I've now started going through these and the first

Re: [PATCH] c++: ahead-of-time overload set pruning for non-dep calls

On Thu, 16 Dec 2021, Patrick Palka wrote: > On Wed, 15 Dec 2021, Jason Merrill wrote: > > > On 12/15/21 12:49, Patrick Palka wrote: > > > This patch makes us remember the function selected by overload > > > resolution during ahead of time processing of a non-dependent call > > > expression, so

Re: [PATCH v4 1/6] tree-object-size: Use trees and support negative offsets

On 12/16/21 21:19, Jakub Jelinek wrote: Yes, but please fix up formatting, wholeval should go below old_wholeval. Though, perhaps it would be better to: if (tree_int_cst_compare (oldval, val)) return true; gcc_checking_assert (tree_int_cst_compare (old_wholeval, wholeval) == 0);

Re: [gcc r12-6020] Fixed typo

On Thu, 16 Dec 2021, Martin Liška wrote: > Hello. > > Oh, sorry, it was me and I forgot to send the patch to the mailing list. > I've basically taken it as: https://github.com/gcc-mirror/gcc/pull/57. > > Should I revert the change? Updating both config.sub and config.guess to the latest

Re: [gcc r12-6020] Fixed typo

On 12/16/21 19:32, Joseph Myers wrote: On Thu, 16 Dec 2021, Martin Liska via Gcc-cvs wrote: https://gcc.gnu.org/g:06cd44b4387a9f6ab46f377f42ee5be9cf11bf15 commit r12-6020-g06cd44b4387a9f6ab46f377f42ee5be9cf11bf15 Author: Matthias Seidel Date: Wed Jun 23 20:35:24 2021 +0200 Fixed typo

[PATCH] i386: Enable VxHF vector modes lower ABI levels [PR103571]

Enable VxHF vector modes for SSE2, AVX and AVX512F ABIs. 2021-12-16 Uroš Bizjak gcc/ChangeLog: PR target/103571 * config/i386/i386.h (VALID_AVX256_REG_MODE): Add V16HFmode. (VALID_AVX256_REG_OR_OI_VHF_MODE): Replace with ... (VALID_AVX256_REG_OR_OI_MODE): ... this. Remove

Re: [gcc r12-6020] Fixed typo

On Thu, 16 Dec 2021, Martin Liska via Gcc-cvs wrote: > https://gcc.gnu.org/g:06cd44b4387a9f6ab46f377f42ee5be9cf11bf15 > > commit r12-6020-g06cd44b4387a9f6ab46f377f42ee5be9cf11bf15 > Author: Matthias Seidel > Date: Wed Jun 23 20:35:24 2021 +0200 > > Fixed typo > > ChangeLog: >

Re: [PATCH] testsuite: Robustify aarch64/simd tests against more aggressive DCE

> The calls should still be diagnosed as incorrect, even if we don't > code-generate them. The fact that we don't do that is a known bug > (in aarch64 code). OK, thanks for the explanation. > The new variables seem to be unused, so I think slightly stronger > DCE could remove the calls even

Re: [PATCH] c++: ahead-of-time overload set pruning for non-dep calls

On Wed, 15 Dec 2021, Jason Merrill wrote: > On 12/15/21 12:49, Patrick Palka wrote: > > This patch makes us remember the function selected by overload > > resolution during ahead of time processing of a non-dependent call > > expression, so that we avoid repeating most of the work of overload > >

Re: [patch] Fix libfortran/101255, wrong IOSTAT value for FLUSH

Patch committed, after changing “call abort” to “stop”. Thanks for the review. FX

Re: [patch] Fix libfortran/98507, handling of timezone near year boundaries

> OK after fixing the above, and thanks for the patch! Patch committed, after changing “call abort” to “stop”. Thanks for the review. FX

Re: [PATCH] opts: do not do sanity check when an error is seen

On 12/16/2021 7:37 AM, Martin Liška wrote: Do not check global options modification when an error is seen in parsing of options (pragmas or attributes). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR target/103709

Re: [PATCH] pragma: respect pragma in lambda functions

On 12/16/2021 4:07 AM, Martin Liška wrote: In g:01ad8c54fdca we started supporting target pragma changes that are primarily caused by optimization option. The same can happen in the opposite way and we need to check for changes both in optimization_current_node and target_option_current_node.

Re: [patch] Fix libfortran/98507, handling of timezone near year boundaries

Hi FX, Am 16.12.21 um 15:17 schrieb FX via Fortran: Hi, DATE_AND_TIME can return incorrect values for non-UTC timezones, near the new year, when the local time and UTC time are in different years. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98507 Attached patch fixes the issue by

Re: [patch] Fix libfortran/101255, wrong IOSTAT value for FLUSH

Hi FX, we now use "STOP n" instead of "call abort" in testcases. OK with this change. Am 16.12.21 um 17:34 schrieb FX via Fortran: With correct patch attached, sorry. Hi, Bug reported by Tobias at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101255

Re: [patch] Fix libfortran/101255, wrong IOSTAT value for FLUSH

With correct patch attached, sorry. Hi, Bug reported by Tobias at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101255 Trivial fix, adding a testcase. Bootstrapped and regtested on x86_64-pc-linux-gnu. OK to commit? FX

Re: [PATCH] c++: nested lambda capturing a capture proxy, part 2 [PR94376]

On Wed, 15 Dec 2021, Jason Merrill wrote: > On 12/15/21 15:36, Patrick Palka wrote: > > The r12-5403 fix apparently doesn't handle the case where the inner > > lambda explicitly rather implicitly captures the capture proxy from > > the outer lambda, and so we still reject the first example in the

Re: [patch] Fix libfortran/101255, wrong IOSTAT value for FLUSH

Hi FX, Am 16.12.21 um 15:49 schrieb FX via Fortran: Hi, Bug reported by Tobias at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101255 Trivial fix, adding a testcase. it seems you attached the wrong patch (the one for pr985079). Bootstrapped and regtested on x86_64-pc-linux-gnu. OK to

[PATCH] c++: delayed noexcept in member function template [PR99980]

Some time ago I noticed that we don't properly delay parsing of noexcept for member function templates. This patch fixes that. It didn't work because even though we set CP_PARSER_FLAGS_DELAY_NOEXCEPT in cp_parser_member_declaration, member template declarations take a different path: we call

[Patch][V2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

Hi, This is the 2nd version of the patch. The original patch is at: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586341.html In addition to resolve the two issues mentioned in the original patch, This patch also can be used as a very good workaround for the issue in PR103720

Re: [PATCH v4 1/6] tree-object-size: Use trees and support negative offsets

On Thu, Dec 16, 2021 at 06:11:27AM +0530, Siddhesh Poyarekar wrote: > On 12/16/21 00:13, Jakub Jelinek wrote: > > On Wed, Dec 15, 2021 at 10:42:29PM +0530, Siddhesh Poyarekar wrote: > > > On 12/15/21 20:51, Jakub Jelinek wrote: > > > > Shouldn't this also tree_int_cst_compare (old_wholeval,

[PATCH] vect: Fix multi-vector SLP gather loads [PR103744]

[Repost with address typo fixed] This PR shows that I didn't properly test the multi-vector case when adding support for SLP gather loads. The patch fixes that case using the same approach as we do for non-SLP cases: keep the scalar base the same, but iterate through the (also multi-vector)

Re: [Patch]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

> On Dec 15, 2021, at 11:33 AM, Qing Zhao via Gcc-patches > wrote: > > > >> On Dec 14, 2021, at 4:06 PM, Martin Sebor wrote: >> >> > > Dynamically creating the string seems quite cumbersome here, and > it leaks the allocated block. I wonder if it might be better to

Re: [Patch 8/8, Arm, GCC] Introduce multilibs for PACBTI target feature. [Was RE: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature.]

Richard Earnshaw via Gcc-patches writes: > On 28/10/2021 12:43, Tejas Belagod via Gcc-patches wrote: >> >>> -Original Message- >>> From: Gcc-patches >> bounces+belagod=gcc.gnu@gcc.gnu.org> On Behalf Of Tejas Belagod via >>> Gcc-patches >>> Sent: Friday, October 8, 2021 1:19 PM >>>

[patch] Fix libfortran/101255, wrong IOSTAT value for FLUSH

Hi, Bug reported by Tobias at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101255 Trivial fix, adding a testcase. Bootstrapped and regtested on x86_64-pc-linux-gnu. OK to commit? FX pr98507.patch Description: Binary data

Re: [Patch 9/9, GCC, Arm] Implement arm Function target attribute 'branch-protection'.

Tejas Belagod via Gcc-patches writes: > Hi, > > This patch is part of the series of PACBTI-M patches posted earlier > https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582773.html > > This change adds the target function attribute 'branch-protection'. The > options that it can take are

[PATCH] libstdc++: Add %j, %U, %w, %W time_get support, fix %y, %Y, %C, %p [PR77760]

Hi! glibc strptime passes around some state, what fields in struct tm have been set and what needs to be finalized through possibly recursive calls, and at the end performs various finalizations, like applying %p so that it works for both %I %p and %p %I orders, or applying century so that both

[PATCH] opts: do not do sanity check when an error is seen

Do not check global options modification when an error is seen in parsing of options (pragmas or attributes). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR target/103709 gcc/c-family/ChangeLog: * c-pragma.c

[patch] Fix libfortran/98507, handling of timezone near year boundaries

Hi, DATE_AND_TIME can return incorrect values for non-UTC timezones, near the new year, when the local time and UTC time are in different years. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98507 Attached patch fixes the issue by correcting the logic to account for that wrapping of “day of

[GCC-10 PATCH] aarch64: enable Ampere-1 CPU

This adds support and a basic tuning model for the Ampere Computing "Ampere-1" CPU. The Ampere-1 implements the ARMv8.6 architecture in A64 mode and is modelled as a 4-wide issue (as with all modern micro-architectures, the chosen issue rate is a compromise between the maximum dispatch rate and

[PATCH 40/40] openacc: Adjust testsuite to new "kernels" handling

Adjust the testsuite to changed expectations with the new Graphite-based "kernels" handling. libgomp/ChangeLog: * testsuite/libgomp.oacc-c++/privatized-ref-2.C: Adjust. * testsuite/libgomp.oacc-c++/privatized-ref-3.C: Adjust. *

Re: GCC 11 backports

On 11/8/21 13:26, Martin Liška wrote: On 11/5/21 17:08, Martin Liška wrote: On 8/23/21 10:54, Martin Liška wrote: On 8/16/21 13:13, Martin Liška wrote: I'm going to apply the following 3 tested patches. Martin One more patch I've just tested. Martin And one more backport. Martin One

Re: [PATCH 1/3] loop-invariant: Don't move cold bb instructions to preheader in RTL

> > OK. Comments like? > > /* Don't move insn of cold BB out of loop to preheader to reduce calculations >and register live range in hot loop with cold BB. */ Looks good. > > > And maybe some dump log will help tracking in xxx.c.271r.loop2_invariant. > > --- a/gcc/loop-invariant.c >

Re: [PATCH 2/3] Fix incorrect loop exit edge probability [PR103270]

> > > > > > ./contrib/analyze_brprob.py ~/workspace/tests/spec2017/dump_file_all > > HEURISTICS BRANCHES (REL) BR. HITRATE > > HITRATE COVERAGE COVERAGE (REL) predict.def (REL) HOT > > branches (>10%) > > noreturn call

[PATCH] pragma: respect pragma in lambda functions

In g:01ad8c54fdca we started supporting target pragma changes that are primarily caused by optimization option. The same can happen in the opposite way and we need to check for changes both in optimization_current_node and target_option_current_node. Patch can bootstrap on x86_64-linux-gnu and

RE: [PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729]

> -Original Message- > From: Richard Sandiford > Sent: 16 December 2021 10:46 > To: Przemyslaw Wirkus > Cc: gcc-patches@gcc.gnu.org; christophe.l...@linaro.org; Richard Earnshaw > ; Kyrylo Tkachov ; > Marcus Shawcroft > Subject: Re: [PATCH][GCC] aarch64: fix: ls64 tests fail on

Re: [PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729]

Przemyslaw Wirkus writes: > Hi, > > This patch is sorting issue with LS64 intrinsics tests failing with > AArch64_be targets. > > Regtested on aarch64_be_elf and aarch64_elf, no issues. > > OK to install? > > gcc/ChangeLog: > > PR target/PR103729 > * config/aarch64/aarch64-simd.md

[PATCH] libiberty: support digits in cpp mangled clone names

From: Lancelot SIX Currently libiberty fails to demangle the name of cloned functions if the clone-type-identifier contains numbers. This can be observed with the following example: $ cat > ex.cc

[PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729]

Hi, This patch is sorting issue with LS64 intrinsics tests failing with AArch64_be targets. Regtested on aarch64_be_elf and aarch64_elf, no issues. OK to install? gcc/ChangeLog: PR target/PR103729 * config/aarch64/aarch64-simd.md (aarch64_movv8di): Allow big endian

Re: [Patch] For -foffload= suggest also 'disable' and 'default' [PR103644]

On Thu, Dec 16, 2021 at 10:53:20AM +0100, Tobias Burnus wrote: > On 16.12.21 10:24, Jakub Jelinek wrote: > > Neither default nor disable are valid offload targets, so I think we need > > to reword the note. valid ‘-foffload=’ arguments are: > > or so? > > Granted. For the second line, I concur –

Re: [Patch] For -foffload= suggest also 'disable' and 'default' [PR103644]

On 16.12.21 10:24, Jakub Jelinek wrote: Neither default nor disable are valid offload targets, so I think we need to reword the note. valid ‘-foffload=’ arguments are: or so? Granted. For the second line, I concur – I am not quite sure about the first line, i.e. gcc: error: GCC is not

Re: [Patch] For -foffload= suggest also 'disable' and 'default' [PR103644]

On Thu, Dec 16, 2021 at 10:12:24AM +0100, Tobias Burnus wrote: > I did run into this when misspelling 'disable': > > Currently (with one offload target configured) > > $ gcc -foffload=disabled > gcc: error: GCC is not configured to support 'disabled' as offload target > gcc: note: valid offload

[Patch] For -foffload= suggest also 'disable' and 'default' [PR103644]

I did run into this when misspelling 'disable': Currently (with one offload target configured) $ gcc -foffload=disabled gcc: error: GCC is not configured to support 'disabled' as offload target gcc: note: valid offload targets are: amdgcn-amdhsa or (without offload support) $ gcc

Re: [PATCH] [i386] Add option -mvect-compare-costs

On Thu, Dec 16, 2021 at 5:00 PM Richard Sandiford via Gcc-patches wrote: > > Obviously I'm not in a position to comment on the target bits, but: > > liuhongt via Gcc-patches writes: > > Also with corresponding target attribute, option default disabled. > > > > Bootstrapped and regtested on

Re: [PATCH] [i386] Add option -mvect-compare-costs

Obviously I'm not in a position to comment on the target bits, but: liuhongt via Gcc-patches writes: > Also with corresponding target attribute, option default disabled. > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > Ok for trunk? > > gcc/ChangeLog: > > *