Ping^1 [PATCH] Add attribute hot judgement for INLINE_HINT_known_hot hint.

2022-10-07 Thread Cui, Lili via Gcc-patches
Hi Honza, Gentle ping https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601934.html Thanks, Lili. > -Original Message- > From: Gcc-patches On > Behalf Of Cui, Lili via Gcc-patches > Sent: Wednesday, September 21, 2022 5:22 PM > To: Jan Hubicka > Cc: Lu, Hongjiu ; Liu, Hongtao

[pushed] c++: track whether we expect a TARGET_EXPR to be elided

2022-10-07 Thread Jason Merrill via Gcc-patches
Tested x86_64-pc-linux-gnu, applying to trunk. -- >8 -- A discussion at Cauldron made me think that with the formalization of copy elision in C++17, we should be able to determine before optimization which TARGET_EXPRs will become temporaries and which are initializers. This patch implements

Re: [PATCH v4] c-family: ICE with [[gnu::nocf_check]] [PR106937]

2022-10-07 Thread Marek Polacek via Gcc-patches
On Fri, Oct 07, 2022 at 05:56:18PM -0400, Jason Merrill wrote: > On 10/7/22 17:08, Marek Polacek wrote: > > On Fri, Oct 07, 2022 at 12:17:34PM -0400, Jason Merrill wrote: > > > On 10/6/22 22:12, Marek Polacek wrote: > > > > On Thu, Oct 06, 2022 at 05:42:41PM -0400, Jason Merrill wrote: > > > > >

Re: [PATCH v4] c-family: ICE with [[gnu::nocf_check]] [PR106937]

2022-10-07 Thread Jason Merrill via Gcc-patches
On 10/7/22 17:08, Marek Polacek wrote: On Fri, Oct 07, 2022 at 12:17:34PM -0400, Jason Merrill wrote: On 10/6/22 22:12, Marek Polacek wrote: On Thu, Oct 06, 2022 at 05:42:41PM -0400, Jason Merrill wrote: On 10/4/22 19:06, Marek Polacek wrote: On Fri, Sep 30, 2022 at 09:12:24AM -0400, Jason

Re: [PATCH v5] c++: fixes for derived-to-base reference binding [PR107085]

2022-10-07 Thread Jason Merrill via Gcc-patches
On 10/7/22 17:26, Marek Polacek wrote: On Fri, Oct 07, 2022 at 01:01:35PM -0400, Jason Merrill wrote: On 10/7/22 12:10, Marek Polacek wrote: On Thu, Oct 06, 2022 at 06:03:57PM -0400, Jason Merrill wrote: On 10/6/22 17:43, Marek Polacek wrote: On Thu, Oct 06, 2022 at 02:00:40PM -0400, Jason

Re: [PATCH, v3] Fortran: error recovery for invalid types in array constructors [PR107000]

2022-10-07 Thread Harald Anlauf via Gcc-patches
Hi Mikael, Am 07.10.22 um 22:26 schrieb Mikael Morin: Le 07/10/2022 à 21:47, Mikael Morin a écrit : Let me have a look. The attached patch works with your test, I just moved the checks into the loops. I'm now checking the patch against the full fortran testsuite. I'm (finally) fine with that

[PATCH v5] c++: fixes for derived-to-base reference binding [PR107085]

2022-10-07 Thread Marek Polacek via Gcc-patches
On Fri, Oct 07, 2022 at 01:01:35PM -0400, Jason Merrill wrote: > On 10/7/22 12:10, Marek Polacek wrote: > > On Thu, Oct 06, 2022 at 06:03:57PM -0400, Jason Merrill wrote: > > > On 10/6/22 17:43, Marek Polacek wrote: > > > > On Thu, Oct 06, 2022 at 02:00:40PM -0400, Jason Merrill wrote: > > > > >

[PATCH v4] c-family: ICE with [[gnu::nocf_check]] [PR106937]

2022-10-07 Thread Marek Polacek via Gcc-patches
On Fri, Oct 07, 2022 at 12:17:34PM -0400, Jason Merrill wrote: > On 10/6/22 22:12, Marek Polacek wrote: > > On Thu, Oct 06, 2022 at 05:42:41PM -0400, Jason Merrill wrote: > > > On 10/4/22 19:06, Marek Polacek wrote: > > > > On Fri, Sep 30, 2022 at 09:12:24AM -0400, Jason Merrill wrote: > > > > >

[PATCHv2] libstdc++: Mark pieces of gnu-linux/os_support.h linux-specific

2022-10-07 Thread Samuel Thibault via Gcc-patches
This is notably needed because in glibc 2.34, the move of pthread functions into libc.so happened for Linux only, not GNU/Hurd. The pthread_self() function can also always be used fine as it is on GNU/Hurd. libstdc++-v3/ChangeLog: * config/os/gnu-linux/os_defines.h [!__linux__]

Re: [PATCH] libstdc++: Introduce GNU/Hurd-specific libstdc++ os-defines.h

2022-10-07 Thread Samuel Thibault via Gcc-patches
Hello, Jonathan Wakely, le ven. 07 oct. 2022 12:14:26 +0100, a ecrit: > As documented at https://gcc.gnu.org/lists.html all patches for > libstdc++ need to be CC'd to the libstdc++ list. That's why your patch > has not been reviewed, because I didn't see it. Ah, sorry, I hadn't noticed that. >

[PATCH, v3] Fortran: error recovery for invalid types in array constructors [PR107000]

2022-10-07 Thread Mikael Morin
Le 07/10/2022 à 21:47, Mikael Morin a écrit : Let me have a look. The attached patch works with your test, I just moved the checks into the loops. I'm now checking the patch against the full fortran testsuite. I'm (finally) fine with that version, what do you think of it?From

Re: [PATCH, rs6000] Fix addg6s builtin with long long parameters. (PR100693)

2022-10-07 Thread Segher Boessenkool
Hi! On Thu, Oct 06, 2022 at 04:29:57PM -0500, will schmidt wrote: > As reported in PR 100693, attempts to use __builtin_addg6s > with long long arguments result in truncated results. > > Since the int and long long types can be coerced into each other, > (documented further near the

Re: [PATCH, v2] Fortran: error recovery for invalid types in array constructors [PR107000]

2022-10-07 Thread Mikael Morin
Le 07/10/2022 à 20:46, Harald Anlauf a écrit : OK, that is because reduce_binary dispatches the reduce_binary_*. We could move the check from reduce_binary_aa to the beginning of reduce_binary, as with the following change on top of the patch: diff --git a/gcc/fortran/arith.cc

Re: [PATCH, v2] Fortran: error recovery for invalid types in array constructors [PR107000]

2022-10-07 Thread Harald Anlauf via Gcc-patches
Am 07.10.22 um 10:01 schrieb Mikael Morin: Le 06/10/2022 à 23:36, Harald Anlauf a écrit : For example, for this case: [real :: 2] * [real :: +(.true.)] First there is a "root" invocation of reduce binary with arguments [real :: 2] and [real :: +(.true.)] The root invocation of reduce_binary

Re: [GCC13][Patch][V6][PATCH 1/2] Add a new option -fstrict-flex-arrays[=n] and new attribute strict_flex_array

2022-10-07 Thread Qing Zhao via Gcc-patches
FYI. I just committed the patches to gcc13: https://gcc.gnu.org/pipermail/gcc-cvs/2022-October/372114.html https://gcc.gnu.org/pipermail/gcc-cvs/2022-October/372115.html thanks. Qing > On Oct 6, 2022, at 8:49 AM, Qing Zhao via Gcc-patches > wrote: > > > >> On Oct 5, 2022, at 4:25 PM,

Re: [PATCH v4] c++: fixes for derived-to-base reference binding [PR107085]

2022-10-07 Thread Jason Merrill via Gcc-patches
On 10/7/22 12:10, Marek Polacek wrote: On Thu, Oct 06, 2022 at 06:03:57PM -0400, Jason Merrill wrote: On 10/6/22 17:43, Marek Polacek wrote: On Thu, Oct 06, 2022 at 02:00:40PM -0400, Jason Merrill wrote: On 10/6/22 13:51, Marek Polacek wrote: On Thu, Oct 06, 2022 at 10:58:44AM -0400, Jason

[patch] specialize paths to version.h in _vxworks-versions.h

2022-10-07 Thread Olivier Hainque via Gcc-patches
The _vxworks-versions.h runtime file helps us control the compilation of some library components depending on the OS version extracted out of a system header. The system header name is "version.h", and gcc has a "version.h" file of its own. gcc's version.h is now generated and the current

[committed] analyzer: extract bits from integer constants [PR105783]

2022-10-07 Thread David Malcolm via Gcc-patches
Fix a false positive from -Wanalyzer-null-dereference due to -fanalyzer failing to grok the value of a particular boolean field initialized to a constant. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-3168-gf09b99550a3c6c. gcc/analyzer/ChangeLog:

Re: [PATCH v3] c-family: ICE with [[gnu::nocf_check]] [PR106937]

2022-10-07 Thread Jason Merrill via Gcc-patches
On 10/6/22 22:12, Marek Polacek wrote: On Thu, Oct 06, 2022 at 05:42:41PM -0400, Jason Merrill wrote: On 10/4/22 19:06, Marek Polacek wrote: On Fri, Sep 30, 2022 at 09:12:24AM -0400, Jason Merrill wrote: On 9/29/22 18:49, Marek Polacek wrote: When getting the name of an attribute, we ought

[PATCH v4] c++: fixes for derived-to-base reference binding [PR107085]

2022-10-07 Thread Marek Polacek via Gcc-patches
On Thu, Oct 06, 2022 at 06:03:57PM -0400, Jason Merrill wrote: > On 10/6/22 17:43, Marek Polacek wrote: > > On Thu, Oct 06, 2022 at 02:00:40PM -0400, Jason Merrill wrote: > > > On 10/6/22 13:51, Marek Polacek wrote: > > > > On Thu, Oct 06, 2022 at 10:58:44AM -0400, Jason Merrill wrote: > > > > >

[PATCH] libstdc++: Allow emergency EH alloc pool size to be tuned [PR68606]

2022-10-07 Thread Jonathan Wakely via Gcc-patches
This needs a little more documentation (see the TODO in the manual), rather than just the comments in the source. This isn't final, but I think it's the direction I want to take. -- >8 -- Implement a long-standing request to support tuning the size of the emergency buffer for allocating

Re: [PATCH] c++ modules: ICE with bitfield member in class template

2022-10-07 Thread Patrick Palka via Gcc-patches
On Fri, 7 Oct 2022, Nathan Sidwell wrote: > On 10/7/22 11:09, Patrick Palka wrote: > > According to grokbitfield, DECL_BITFIELD_REPRESENTATIVE may "temporarily" > > contain the width of the bitfield until we layout the class type (after > > which it'll contain a FIELD_DECL). But for a class

Re: [PATCH] IPA: support -flto + -flive-patching=inline-clone

2022-10-07 Thread Qing Zhao via Gcc-patches
> On Oct 7, 2022, at 10:43 AM, Jan Hubicka wrote: > Probably not hard, and the IPA pass adjusting visbility could as well mark the functions as not to be inlined with -flive-patching=inline-only-static. >> >> OTOH inline-only-static could disable WPA inlining and

Re: [PATCH] c++ modules: ICE with bitfield member in class template

2022-10-07 Thread Nathan Sidwell via Gcc-patches
On 10/7/22 11:09, Patrick Palka wrote: According to grokbitfield, DECL_BITFIELD_REPRESENTATIVE may "temporarily" contain the width of the bitfield until we layout the class type (after which it'll contain a FIELD_DECL). But for a class template, it'll always be the width since we don't/can't

Re: c++: Lambda context mangling

2022-10-07 Thread Jason Merrill via Gcc-patches
On 10/7/22 08:27, Nathan Sidwell wrote: VAR and FIELD decls can become part of a lambda context, when the lambda is 'attached' to that entity (It's a C++20 ODR thing that was discovered with modules, but is actually separate.)  We were not marking those decls as substitution candidates, leading

Re: [RFA] Minor improvement to coremark, avoid unconditional jump to return

2022-10-07 Thread Franz Sirl
Am 2022-10-07 um 16:13 schrieb Jeff Law: On 10/7/22 04:51, Franz Sirl wrote: Am 2022-09-25 um 18:28 schrieb Jeff Law: This is a minor improvement for the core_list_find routine in coremark. Basically for riscv, and likely other targets, we can end up with an unconditional jump to a return

[PATCH] c++ modules: ICE with bitfield member in class template

2022-10-07 Thread Patrick Palka via Gcc-patches
According to grokbitfield, DECL_BITFIELD_REPRESENTATIVE may "temporarily" contain the width of the bitfield until we layout the class type (after which it'll contain a FIELD_DECL). But for a class template, it'll always be the width since we don't/can't layout dependent types. Tested on

Re: [PATCH][AArch64] Improve immediate expansion [PR106583]

2022-10-07 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra writes: > Hi Richard, > >>> Yes, with a more general search loop we can get that case too - >>> it doesn't trigger much though. The code that checks for this is >>> now refactored into a new function. Given there are now many >>> more calls to aarch64_bitmask_imm, I added a

Re: [PATCH] IPA: support -flto + -flive-patching=inline-clone

2022-10-07 Thread Jan Hubicka via Gcc-patches
> >> Probably not hard, and the IPA pass adjusting visbility could as well > >> mark the functions > >> as not to be inlined with -flive-patching=inline-only-static. > >> > > OTOH inline-only-static could disable WPA inlining and do all inlining > early ... > >>> > >>>

Re: [PATCH] IPA: support -flto + -flive-patching=inline-clone

2022-10-07 Thread Qing Zhao via Gcc-patches
> On Oct 7, 2022, at 9:03 AM, Jan Hubicka wrote: > >>> WPA is Whole Program Analysis? >> >> Yes. >> >>> Okay, then It will promote all static function to extern functions. That’s >>> reasonable. >> >> No, all extern functions to static functions. >> >>> Is it hard to preserve the

[Patch][v5] libgomp/nvptx: Prepare for reverse-offload callback handling

2022-10-07 Thread Tobias Burnus
Updated patch enclosed. Changes: * Fixes the sm >= 700 issue, I noted before (cf. below) * The < sm_70 code is still in, but disabled at user-compile time, with a warning, if libgomp.a wasn't compiled with sm_70 or higher. (mkoffload strips the nvptx offload code) * Some minor cleanup OK

libiberty: Demangle variadic template lambdas

2022-10-07 Thread Nathan Sidwell via Gcc-patches
Now we have templated lambdas, we can have variadic template lambdas, and this leads to lambda signatures containing parameter packs. But just like 'auto' inside such a signature, we don't have a containing template, and thus fail. The fix is to check is_lambda_arg, just as for a template

Re: [PATCH] Teach vectorizer to deal with bitfield accesses (was: [RFC] Teach vectorizer to deal with bitfield reads)

2022-10-07 Thread Andre Vieira (lists) via Gcc-patches
Hi, Whilst running a bootstrap with extra options to force bitfield vectorization '-O2 -ftree-vectorize -ftree-loop-if-convert -fno-vect-cost-model' I ran into an ICE in vect-patterns where a bit_field_ref had a container that wasn't INTEGRAL_TYPE and had a E_BLKmode, which meant we failed

Re: [PATCH] cselib: Skip BImode while keeping track of subvalue relations [PR107088]

2022-10-07 Thread Jeff Law via Gcc-patches
On 10/6/22 01:06, Stefan Schulze Frielinghaus wrote: On Wed, Oct 05, 2022 at 08:48:13PM -0600, Jeff Law via Gcc-patches wrote: On 10/4/22 05:28, Stefan Schulze Frielinghaus via Gcc-patches wrote: For BImode get_narrowest_mode evaluates to QImode but BImode < QImode. Thus FOR_EACH_MODE_UNTIL

Re: [RFA] Minor improvement to coremark, avoid unconditional jump to return

2022-10-07 Thread Jeff Law
On 10/7/22 04:51, Franz Sirl wrote: Am 2022-09-25 um 18:28 schrieb Jeff Law: This is a minor improvement for the core_list_find routine in coremark. Basically for riscv, and likely other targets, we can end up with an unconditional jump to a return statement.    This is a result of

Re: [PATCH] PR middle-end/88345: Honor -falign-functions=N even optimized for size.

2022-10-07 Thread Palmer Dabbelt
On Fri, 07 Oct 2022 05:56:39 PDT (-0700), hubi...@ucw.cz wrote: On Fri, Oct 7, 2022 at 6:04 AM Kito Cheng wrote: > > From: Monk Chiang > > Currnetly setting of -falign-functions=N will be ignored if the function > is optimized for size or marked as cold function. > > However function alignment

Re: [PATCH] IPA: support -flto + -flive-patching=inline-clone

2022-10-07 Thread Martin Liška
On 10/7/22 15:04, Qing Zhao wrote: On Oct 7, 2022, at 2:34 AM, Richard Biener wrote: On Thu, Oct 6, 2022 at 3:18 PM Qing Zhao wrote: On Oct 6, 2022, at 4:29 AM, Richard Biener wrote: On Wed, Oct 5, 2022 at 8:18 PM Qing Zhao via Gcc-patches wrote: On Oct 5, 2022, at 1:36 PM,

[PATCH] doc: -falign-functions doesn't override the __attribute__((align(N)))

2022-10-07 Thread Palmer Dabbelt
I found this when reading the documentation for Kito's recent patch. >From the discussion it sounds like this is the desired behavior, so let's document it. gcc/doc/ChangeLog * invoke.texi (-falign-functions): Mention __align__ --- gcc/doc/invoke.texi | 4 +++- 1 file changed, 3

Re: [PATCH][AArch64] Improve immediate expansion [PR106583]

2022-10-07 Thread Wilco Dijkstra via Gcc-patches
Hi Richard, >> Yes, with a more general search loop we can get that case too - >> it doesn't trigger much though. The code that checks for this is >> now refactored into a new function. Given there are now many >> more calls to aarch64_bitmask_imm, I added a streamlined internal >> entry point

[PATCH v3] testsuite: Sanitize fails for SP FPU on Arm

2022-10-07 Thread Torbjörn SVENSSON via Gcc-patches
This patch stops reporting fails for Arm targets with single precision floating point unit for types wider than 32 bits (the width of float on arm-none-eabi). As reported in PR102017, fenv is reported as supported in recent versions of newlib. At the same time, for some Arm targets, the

Re: [PATCH][AArch64] Improve immediate expansion [PR106583]

2022-10-07 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra via Gcc-patches writes: > Hi Richard, > >> Did you consider handling the case where the movks aren't for >> consecutive bitranges?  E.g. the patch handles: > >> but it looks like it would be fairly easy to extend it to: >> >>  0x12345678 > > Yes, with a more general search

Re: Re: [PATCH] Add first-order recurrence autovectorization

2022-10-07 Thread 钟居哲
Sorry for late reply. I just got back from vacation (a week). I was planning to finish this patch after vacation. It seems that you almost finished. That's great! Thank you so much. juzhe.zh...@rivai.ai From: Richard Biener Date: 2022-10-07 20:24 To: juzhe.zhong CC: gcc-patches;

Re: [PATCH] IPA: support -flto + -flive-patching=inline-clone

2022-10-07 Thread Qing Zhao via Gcc-patches
> On Oct 7, 2022, at 2:34 AM, Richard Biener wrote: > > On Thu, Oct 6, 2022 at 3:18 PM Qing Zhao wrote: >> >> >> >>> On Oct 6, 2022, at 4:29 AM, Richard Biener >>> wrote: >>> >>> On Wed, Oct 5, 2022 at 8:18 PM Qing Zhao via Gcc-patches >>> wrote: > On Oct 5, 2022,

Re: [PATCH] IPA: support -flto + -flive-patching=inline-clone

2022-10-07 Thread Jan Hubicka via Gcc-patches
> > WPA is Whole Program Analysis? > > Yes. > > > Okay, then It will promote all static function to extern functions. That’s > > reasonable. > > No, all extern functions to static functions. > > > Is it hard to preserve the original “static” visibility in the IR? > > Probably not hard, and

Re: [PATCH] PR middle-end/88345: Honor -falign-functions=N even optimized for size.

2022-10-07 Thread Jan Hubicka via Gcc-patches
> On Fri, Oct 7, 2022 at 6:04 AM Kito Cheng wrote: > > > > From: Monk Chiang > > > > Currnetly setting of -falign-functions=N will be ignored if the function > > is optimized for size or marked as cold function. > > > > However function alignment requirement is needed even optimized for > > size

c++: Lambda context mangling

2022-10-07 Thread Nathan Sidwell via Gcc-patches
VAR and FIELD decls can become part of a lambda context, when the lambda is 'attached' to that entity (It's a C++20 ODR thing that was discovered with modules, but is actually separate.) We were not marking those decls as substitution candidates, leading to demangling failures and compiler

[PATCH] tree-optimization/107153 - autopar SSA update issue

2022-10-07 Thread Richard Biener via Gcc-patches
autopar performs insertion of stores, eventually requiring a virtual loop PHI and assorted LC PHI adjustments which we intend to do once after the pass finishes. But we also perform intermediate update_ssa after loop duplication which can lose this fact. The following forces renaming of the

Re: [PATCH] Add first-order recurrence autovectorization

2022-10-07 Thread Richard Biener via Gcc-patches
On Thu, Oct 6, 2022 at 3:07 PM Richard Biener wrote: > > On Thu, Oct 6, 2022 at 2:13 PM Richard Biener > wrote: > > > > On Fri, Sep 30, 2022 at 10:00 AM wrote: > > > > > > From: Ju-Zhe Zhong > > > > > > Hi, After fixing previous ICE. > > > I add full implementation (insert permutation to get

[committed] libstdc++: Add --disable-libstdcxx-hosted as an alias for hosted-libstdcxx

2022-10-07 Thread Jonathan Wakely via Gcc-patches
Tested x86_64-linux, Pushed to trunk. -- >8 -- Most libstdc++ configure args are of the form --enable-libstdcxx-xxx but the option to build freestanding is --disable-hosted-libstdcxx. If you accidentally type --disable-libstdcxx-hosted then it will be ignored. This adds

[committed] libstdc++: Shuffle header dependencies of

2022-10-07 Thread Jonathan Wakely via Gcc-patches
Tested x86_64-linux, Pushed to trunk. -- >8 -- The header is needed by std::function to use placement new, so include it in instead of in . libstdc++-v3/ChangeLog: * include/bits/std_function.h: Include but do not include . * include/std/functional: Do not include .

Re: [PATCH 2/2] Split edge when edge locus and dest don't match

2022-10-07 Thread Jørgen Kvalsvik via Gcc-patches
On 07/10/2022 08:53, Richard Biener wrote: > On Thu, Oct 6, 2022 at 4:28 PM Jørgen Kvalsvik > wrote: >> >> On 06/10/2022 10:12, Richard Biener wrote: >>> On Wed, Oct 5, 2022 at 2:49 PM Martin Liška wrote: On 10/5/22 14:04, Jørgen Kvalsvik via Gcc-patches wrote: > Edges with locus

[committed] libstdc++: Use bold style for DR titles in the manual

2022-10-07 Thread Jonathan Wakely via Gcc-patches
Pushed to trunk. -- >8-- This matches how the issues are styled in the LWG issues list, and also allows us to use italics for "cv" (e.g. in issue 2487). libstdc++-v3/ChangeLog: * doc/xml/manual/intro.xml: Add role="bold" attribute to emphasis elements for issue titles.

Re: gcc-12: FTBFS on hurd-i386

2022-10-07 Thread Jonathan Wakely via Gcc-patches
On 06/10/22 18:01 +0200, Svante Signell via Gcc-patches wrote: gcc-12-12.2.0-4/5 in sid FTBFS on hurd-i386 due to failing linkage of pthread_once (same error for gcc-11, gcc-12, gcc-snapshot): /<>/build/i686-gnu/libstdc++-v3/include/i686-gnu/bits/gthr- default.h:700: undefined reference to

Re: [RFA] Minor improvement to coremark, avoid unconditional jump to return

2022-10-07 Thread Richard Biener via Gcc-patches
On Fri, Oct 7, 2022 at 12:51 PM Franz Sirl wrote: > > Am 2022-09-25 um 18:28 schrieb Jeff Law: > > This is a minor improvement for the core_list_find routine in coremark. > > > > > > Basically for riscv, and likely other targets, we can end up with an > > unconditional jump to a return statement.

Re: [PATCH] c++ modules: static var in inline function [PR104433]

2022-10-07 Thread Nathan Sidwell via Gcc-patches
On 10/6/22 12:19, Patrick Palka wrote: The below testcase fails to link with the error undefined reference to `f()::y' ultimately because during stream out for the static VAR_DECL y we override DECL_EXTERNAL to true, which later during IPA confuses symbol_table::remove_unreachable_nodes

Re: [committed] Fix comment typos

2022-10-07 Thread Jonathan Wakely via Gcc-patches
On 07/10/22 09:11 +0200, Jakub Jelinek wrote: --- gcc/ipa-prop.h.jj 2022-05-25 11:07:29.516188277 +0200 +++ gcc/ipa-prop.h 2022-10-06 16:12:52.157055672 +0200 @@ -78,7 +78,7 @@ struct ipa_cst_ref_desc; /* Structure holding data required to describe a constant jump function. */ struct

Re: [PATCH] libstdc++: Introduce GNU/Hurd-specific libstdc++ os-defines.h

2022-10-07 Thread Jonathan Wakely via Gcc-patches
As documented at https://gcc.gnu.org/lists.html all patches for libstdc++ need to be CC'd to the libstdc++ list. That's why your patch has not been reviewed, because I didn't see it. On 29/08/22 02:30 +0200, Samuel Thibault wrote: This is notably needed because in glibc 2.34, the move of

Re: [RFA] Minor improvement to coremark, avoid unconditional jump to return

2022-10-07 Thread Franz Sirl
Am 2022-09-25 um 18:28 schrieb Jeff Law: This is a minor improvement for the core_list_find routine in coremark. Basically for riscv, and likely other targets, we can end up with an unconditional jump to a return statement.    This is a result of compensation code created by bb-reorder, and

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-07 Thread Aldy Hernandez via Gcc-patches
On Wed, Oct 5, 2022 at 12:14 PM Aldy Hernandez wrote: > However... I don't think I have the stomach to overhaul the allocators > this late in the release. For this release I may opt to put the > nonzero mask back in a tree, but have it always be set. The NULL == > -1 shortcut was very error

[PATCH][pushed] libdecnumber: remove unused variable

2022-10-07 Thread Martin Liška
Fixes: libdecnumber/dpd/decimal64.c:617:8: warning: variable 'n' set but not used [-Wunused-but-set-variable] libdecnumber/ChangeLog: * dpd/decimal64.c (decDigitsToDPD): Remove unused variable. --- libdecnumber/dpd/decimal64.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH][pushed] fix clang warnings

2022-10-07 Thread Martin Liška
Consulted with Jonathan, I'm going to push that. Martin Fixes: gcc/c-family/name-hint.h:109:66: warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call] gcc/config/i386/i386-expand.cc:1351:9: warning: argument 'operands' of type 'rtx[3]' (aka 'rtx_def *[3]') with mismatched

[PATCH][pushed] remove dead variables

2022-10-07 Thread Martin Liška
Remove unused variables that are modified but not used. gcc/ChangeLog: * auto-profile.cc (get_inline_stack): Remove unused variable. gcc/objc/ChangeLog: * objc-gnu-runtime-abi-01.cc (generate_static_references): Remove unused variable. --- gcc/auto-profile.cc

Re: [PATCH, v2] Fortran: error recovery for invalid types in array constructors [PR107000]

2022-10-07 Thread Mikael Morin
Le 06/10/2022 à 23:36, Harald Anlauf a écrit : For example, for this case: [real :: 2] * [real :: +(.true.)] First there is a "root" invocation of reduce binary with arguments [real :: 2] and [real :: +(.true.)] The root invocation of reduce_binary will call reduce_binary_aa. This is normal.

[committed] Fix comment typos

2022-10-07 Thread Jakub Jelinek via Gcc-patches
Hi! When looking at tree-inline.cc I've noticed a comment typo and grepped for similar typos elsewhere. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2022-10-07 Jakub Jelinek * ipa-prop.h (ipa_constant_data): Fix comment typo. *

[patch] Downgrade DWARF_VERSION_DEFAULT to 3 for VxWorks >= 7

2022-10-07 Thread Olivier Hainque via Gcc-patches
Hello, Using 4 as the DWARF_VERSION_DEFAULT value for VxWorks observably still hangs recent system debuggers on tbreak for some contructs, and downgrading to 3 improves the situation. Committing to mainline shortly. Cheers, Olivier 2022-03-06 Olivier Hainque gcc/ *

Re: [PATCH 2/2] Split edge when edge locus and dest don't match

2022-10-07 Thread Richard Biener via Gcc-patches
On Thu, Oct 6, 2022 at 4:28 PM Jørgen Kvalsvik wrote: > > On 06/10/2022 10:12, Richard Biener wrote: > > On Wed, Oct 5, 2022 at 2:49 PM Martin Liška wrote: > >> > >> On 10/5/22 14:04, Jørgen Kvalsvik via Gcc-patches wrote: > >>> Edges with locus are candidates for splitting so that the edge with

Re: [PATCH] IPA: support -flto + -flive-patching=inline-clone

2022-10-07 Thread Richard Biener via Gcc-patches
On Thu, Oct 6, 2022 at 3:18 PM Qing Zhao wrote: > > > > > On Oct 6, 2022, at 4:29 AM, Richard Biener > > wrote: > > > > On Wed, Oct 5, 2022 at 8:18 PM Qing Zhao via Gcc-patches > > wrote: > >> > >> > >> > >>> On Oct 5, 2022, at 1:36 PM, Martin Liška wrote: > >>> > >>> On 10/5/22 16:50, Qing

Re: [PATCH] PR middle-end/88345: Honor -falign-functions=N even optimized for size.

2022-10-07 Thread Richard Biener via Gcc-patches
On Fri, Oct 7, 2022 at 6:04 AM Kito Cheng wrote: > > From: Monk Chiang > > Currnetly setting of -falign-functions=N will be ignored if the function > is optimized for size or marked as cold function. > > However function alignment requirement is needed even optimized for > size in some

Re: [PATCH RFA] gimplify: prevent some C++ temporary elision

2022-10-07 Thread Richard Biener via Gcc-patches
On Thu, Oct 6, 2022 at 8:23 PM Jason Merrill via Gcc-patches wrote: > > Tested x86_64-pc-linux-gnu, OK for trunk? OK. Thanks, Richard. > -- >8 -- > > In this testcase, we were optimizing away the temporary for f(), but > C++17 and above are clear that there is a temporary, and because its >

Re: [PATCH] Reduce DF computation at -O0

2022-10-07 Thread Richard Biener via Gcc-patches
On Thu, Oct 6, 2022 at 7:27 PM Eric Botcazou via Gcc-patches wrote: > > Hi, > > even at -O0 there may be a fair amount of DF computation performed when > compiling large units and part of it appears to be useless. > > Bootstrapped/regtested on x86-64/Linux, OK for the mainline? OK. > >