Re: [PATCH, V2] PR target/105325, Make load/cmp fusion know about prefixed load

2023-03-27 Thread Michael Meissner via Gcc-patches
On Mon, Mar 27, 2023 at 03:03:17PM +0800, Kewen.Lin wrote: > ... instead I suggested moving these three lines to below else arm for CCUNS, > since the arm for CC already has those variables redefined, so it's something > like: I did those changes in the 3rd version of the patch. | Date: Mon, 27

[PATCH, V3] PR target/105325, Make load/cmp fusion know about prefixed loads

2023-03-27 Thread Michael Meissner via Gcc-patches
I posted a version of patch on March 21st and a second version on March 24th. This patch makes some code changes suggested in the genfusion.pl code from the last 2 patch submissions. The fusion.md that is produced by genfusion.pl is the same in all 3 versions. I changed the genfusion.pl to match

[committed] CRIS: Correct "T" to define_memory_constraint, not define_constraint

2023-03-27 Thread Hans-Peter Nilsson via Gcc-patches
This patch has no effect on builds using reload of libgcc, newlib libc, my own at-a-glance-testsuite and coremark. That somewhat surprisingly also goes for LRA builds, even with all CRIS reload_in_progress augmented to include lra_in_progress. I just noticed it when checking because another port

[committed] CRIS: Add peephole2 to handle gcc.target/cris/rld-legit1.c for LRA

2023-03-27 Thread Hans-Peter Nilsson via Gcc-patches
The test-case gcc.target/cris/rld-legit1.c is a reduced test-case that required defining LEGITIMIZE_RELOAD_ADDRESS to stop the address from being decomposed into several insns by reload. Valid but suboptimal code was generated. (Before implementing that hook for CRIS, the same test-case also

[committed] CRIS: Improve bailing for eliminable compares for "addi" vs. "add"

2023-03-27 Thread Hans-Peter Nilsson via Gcc-patches
This patch affects a post-reload define_split for CRIS that transforms a condition-code-clobbering addition into a non-clobbering addition. (A "two-operand" addition between registers is the only insn that has both a condition-code-clobbering and a non-clobbering variant for CRIS.) Many more

[committed] CRIS: Remove unused constraint "R".

2023-03-27 Thread Hans-Peter Nilsson via Gcc-patches
gcc: * config/cris/constraints.md ("R"): Remove unused constraint. --- gcc/config/cris/constraints.md | 10 -- 1 file changed, 10 deletions(-) diff --git a/gcc/config/cris/constraints.md b/gcc/config/cris/constraints.md index 05a1d24ef5a1..5efb61364f46 100644 ---

[GCC14 QUEUE PATCH] RISC-V: Eliminate redundant vsetvli for duplicate AVL def

2023-03-27 Thread juzhe . zhong
From: Juzhe-Zhong void f (int8_t* base1,int8_t* base2,int8_t* out,int n) { vint8mf4_t v = __riscv_vle8_v_i8mf4 (base1, 32); for (int i = 0; i < n; i++){ v = __riscv_vor_vx_i8mf4 (v, 101, 32); v = __riscv_vle8_v_i8mf4_tu (v, base2, 32); }

[PATCH] RISC-V: Eliminate redundant vsetvli for duplicate AVL def

2023-03-27 Thread juzhe . zhong
From: Juzhe-Zhong void f (int8_t* base1,int8_t* base2,int8_t* out,int n) { vint8mf4_t v = __riscv_vle8_v_i8mf4 (base1, 32); for (int i = 0; i < n; i++){ v = __riscv_vor_vx_i8mf4 (v, 101, 32); v = __riscv_vle8_v_i8mf4_tu (v, base2, 32); }

Re: [PATCH 2/2] Remove Negative(gwarf-) from gdwarf

2023-03-27 Thread Joseph Myers
On Fri, 24 Mar 2023, Richard Biener via Gcc-patches wrote: > Prior to the removal of STABS support the gdwarf, gstabs, ... options > formed a cycle with their Negative(..) option attribute. But that > didn't actually have any effect since most of the options also > are Joined or JoinedOrMissing

Re: [PATCH 1/2] Disallow -gno-dwarf, gno-dwarf-N, -gno-gdb and -gno-vms

2023-03-27 Thread Joseph Myers
On Fri, 24 Mar 2023, Richard Biener via Gcc-patches wrote: > The following adds RejectNegative to the gdwarf, gdwarf-, ggdb and gvms > options since the current behavior is to treat the negative variant > the same as the positive variant. In particular -ggdb -gno-gdb > do not cancel, and plain

Re: [RFC/RFT,V2] CFI: Add support for gcc CFI in aarch64

2023-03-27 Thread Sami Tolvanen via Gcc-patches
On Mon, Mar 27, 2023 at 2:30 AM Peter Zijlstra wrote: > > On Sat, Mar 25, 2023 at 01:54:16AM -0700, Dan Li wrote: > > > In the compiler part[4], most of the content is the same as Sami's > > implementation[3], except for some minor differences, mainly including: > > > > 1. The function typeid is

[PATCH] libstdc++/complex: Remove implicit type casts in complex

2023-03-27 Thread Weslley da Silva Pereira via Gcc-patches
Dear all, Here follows a patch that removes implicit type casts in std::complex. *Description:* The current implementation of `complex<_Tp>` assumes that `int, double, long double` are explicitly convertible to `_Tp`. Moreover, it also assumes that: 1. `int` is implicitly convertible to `_Tp`,

RE: [EXTERNAL] Re: [PATCH] Fix autoprofiledbootstrap build

2023-03-27 Thread Eugene Rozenfeld via Gcc-patches
Ping for https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613974.html Thanks, Eugene -Original Message- From: Eugene Rozenfeld Sent: Tuesday, March 14, 2023 2:21 PM To: Jeff Law ; gcc-patches@gcc.gnu.org; Andi Kleen Subject: RE: [EXTERNAL] Re: [PATCH] Fix autoprofiledbootstrap

[PATCH] [og12] OpenMP: Constructors and destructors for "declare target" static aggregates

2023-03-27 Thread Julian Brown
This patch adds support for running constructors and destructors for static (file-scope) aggregates for C++ objects which are marked with "declare target" directives on OpenMP offload targets. At present, space is allocated on the target for such aggregates, but nothing ever constructs them

[PATCH] fixincludes: Declare memmem if it's not declared in system headers [PR109293]

2023-03-27 Thread Xi Ruoyao via Gcc-patches
memmem is not POSIX so the system may lack it. Then libiberty will provide an implementation, but it's a "supplemental function" and not declared in libiberty.h. We need to declare the prototype to use it then. See libiberty doc at

Re: [PATCH] c++: NTTP constraint depending on outer args [PR109160]

2023-03-27 Thread Patrick Palka via Gcc-patches
On Fri, Mar 17, 2023 at 11:26 AM Patrick Palka wrote: > > Here we're crashing during satisfaction for the NTTP 'C auto' from > do_auto_deduction ultimately because convert_template_argument / unify > don't pass all outer template arguments to do_auto_deduction, and during > satisfaction we need

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 12:48 PM, Qing Zhao via Gcc-patches > wrote: > > > >> On Mar 27, 2023, at 12:31 PM, Jakub Jelinek wrote: >> >> On Mon, Mar 27, 2023 at 04:22:25PM +, Qing Zhao via Gcc-patches wrote: The latter IMHO. Having a warning with completely nonsensical name will

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-27 Thread Costas Argyris via Gcc-patches
The patch attached to this email extends the UTF-8 support of the driver and compiler processes to the 32-bit mingw host.Initially, only the 64-bit host got it. About the changes in sym-mingw32.cc: Even though the 64-bit host was building fine with the symbol being simply declared as a char,

Re: [PATCH] In the ready lists of pipeline, put unrecog insns (such as CLOBBER, USE) at the latest to issue.

2023-03-27 Thread Richard Sandiford via Gcc-patches
Jin Ma via Gcc-patches writes: > Unrecog insns (such as CLOBBER, USE) does not represent real instructions, > but in the > process of pipeline optimization, they will wait for transmission in ready > list like > other insns, without considering resource conflicts and cycles. This results >

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 12:31 PM, Jakub Jelinek wrote: > > On Mon, Mar 27, 2023 at 04:22:25PM +, Qing Zhao via Gcc-patches wrote: >>> The latter IMHO. Having a warning with completely nonsensical name will >>> just confuse users. >> >> Okay. -:) >> How about "-Wstruct-with-fam-not-at-end”?

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 27, 2023 at 04:22:25PM +, Qing Zhao via Gcc-patches wrote: > > The latter IMHO. Having a warning with completely nonsensical name will > > just confuse users. > > Okay. -:) > How about "-Wstruct-with-fam-not-at-end”? Or do you have any suggestion on > the name? Nobody will

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 12:06 PM, Jakub Jelinek wrote: > > On Mon, Mar 27, 2023 at 03:57:58PM +, Qing Zhao wrote: +Please use warning option @option{-Wgnu-variable-sized-type-not-at-end} to >>> This is certainly misnamed. >> >> The name “-Wgnu-variable-sized-type-not-at-end” was

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 27, 2023 at 03:57:58PM +, Qing Zhao wrote: > >> +Please use warning option @option{-Wgnu-variable-sized-type-not-at-end} > >> to > > This is certainly misnamed. > > The name “-Wgnu-variable-sized-type-not-at-end” was just used the warning > name from CLANG. -:) > > Shall we

[PATCH v2][RFC] vect: Verify that GET_MODE_NUNITS is greater than one for vect_grouped_store_supported

2023-03-27 Thread Kevin Lee
This patch is a proper fix to the previous patch https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614463.html vect_grouped_store_supported checks if the count is a power of 2, but doesn't check the size of the GET_MODE_NUNITS. This should handle the riscv case where the mode is VNx1DI since

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 11:43 AM, Jakub Jelinek wrote: > > On Mon, Mar 27, 2023 at 01:38:34PM +, Qing Zhao wrote: >> >> >>> On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: >>> >>> On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: >>> +Wgnu-variable-sized-type-not-at-end

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 27, 2023 at 01:38:34PM +, Qing Zhao wrote: > > > > On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: > > > > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > > > >> +Wgnu-variable-sized-type-not-at-end > >> +C C++ Var(warn_variable_sized_type_not_at_end) Warning > >>

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 10:34 AM, Xi Ruoyao wrote: > > On Mon, 2023-03-27 at 13:38 +, Qing Zhao via Gcc-patches wrote: >> >> >>> On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: >>> >>> On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: >>> +Wgnu-variable-sized-type-not-at-end

Re: [PATCH] Changed vector size

2023-03-27 Thread Richard Biener via Gcc-patches
On Mon, Mar 27, 2023 at 12:37 PM wrote: > > From: Yixuan Chen > > Observed a vint type "ABS_EXPR" followed by extra 3 int type "ABS_EXPR". If > want to test absolute value optimization for vector, maybe don't need 4 times. A better solution would be to scan a dump before the veclower pass? >

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Xi Ruoyao via Gcc-patches
On Mon, 2023-03-27 at 13:38 +, Qing Zhao via Gcc-patches wrote: > > > > On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: > > > > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > > > > > +Wgnu-variable-sized-type-not-at-end > > > +C C++ Var(warn_variable_sized_type_not_at_end)

Re: [PATCH] Modula-2: fix documentation layout

2023-03-27 Thread Gaius Mulley via Gcc-patches
Eric Botcazou writes: > Hi Gaius, > >> yes indeed and thanks for the patch! > > You're welcome. The documentation was slightly broken again in the meantime, > but nothing really serious this time. > > Again tested with a modern and an old version of Makeinfo. OK for mainline? > > > 2023-03-27

Re: [PATCH] sanitizer: missing signed integer overflow errors [PR109107]

2023-03-27 Thread Marek Polacek via Gcc-patches
Ping. On Tue, Mar 14, 2023 at 06:50:26PM -0400, Marek Polacek via Gcc-patches wrote: > Here we're failing to detect a signed overflow with -O because match.pd, > since r8-1516, transforms > > c = (a + 1) - (int) (short int) b; > > into > > c = (int) ((unsigned int) a + 4294946117); > >

Re: [V5][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832]

2023-03-27 Thread Qing Zhao via Gcc-patches
Hi, Jakub, Could you please review the middle end part of the changes of this patch? (The C FE part changes were Okayed by Joseph already). The major change is in tree-object-size.cc (addr_object_size). (To use the new TYPE_INCLUDE_FLEXARRAY info). This patch is to fix

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: > > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > >> +Wgnu-variable-sized-type-not-at-end >> +C C++ Var(warn_variable_sized_type_not_at_end) Warning >> +Warn about structures or unions with C99 flexible array members are not >> +at

Re: [V5][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832]

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 23, 2023, at 2:55 PM, Joseph Myers wrote: > > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > >> gcc/c/ChangeLog: >> >> PR tree-optimization/101832 >> * c-decl.cc (finish_struct): Set TYPE_INCLUDE_FLEXARRAY for >> struct/union type. > > The C front-end

Re: [PATCH 1/2] c++: improve "NTTP argument considered unused" fix [PR53164, PR105848]

2023-03-27 Thread Patrick Palka via Gcc-patches
On Thu, 23 Mar 2023, Patrick Palka wrote: > r13-995-g733a792a2b2e16 worked around the problem of FUNCTION_DECL > template arguments not always getting marked as odr-used by redundantly > calling mark_used on the substituted ADDR_EXPR callee of a CALL_EXPR. > This is just a narrow workaround

[committed] gcov: Fix "subcomand" typos [PR109297]

2023-03-27 Thread Jonathan Wakely via Gcc-patches
Committed as obvious. -- >8 -- gcc/ChangeLog: PR gcov-profile/109297 * gcov-tool.cc (merge_usage): Fix "subcomand" typo. (merge_stream_usage): Likewise. (overlap_usage): Likewise. --- gcc/gcov-tool.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH] tree-optimization/54498 - testcase for the bug

2023-03-27 Thread Richard Biener via Gcc-patches
I realized I never added a testcase for the fix of this bug. Now done after verifying it still fails when reverting the fix. tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/54498 * g++.dg/torture/pr54498.C: New testcase. ---

[PATCH] tree-optimization/108357 - add testcase

2023-03-27 Thread Richard Biener via Gcc-patches
The following adds the testcase for the bug which was recently fixed. Pushed. PR tree-optimization/108357 * gcc.dg/tree-ssa/pr108357.c: New testcase. --- gcc/testsuite/gcc.dg/tree-ssa/pr108357.c | 22 ++ 1 file changed, 22 insertions(+) create mode 100644

Re: [PATCH] target/109296 - riscv: Add missing mode specifiers for XTheadMemPair

2023-03-27 Thread Philipp Tomsich
Applied to master, thanks! Philipp. On Mon, 27 Mar 2023 at 19:55, Kito Cheng wrote: > > OK for trunk, thanks :) > > On Mon, Mar 27, 2023 at 7:04 PM Christoph Muellner > wrote: >> >> From: Christoph Müllner >> >> This patch adds missing mode specifiers for XTheadMemPair INSNs. >> >>

Re: [PATCH v2 0/2] Series of patch to fix PR106594

2023-03-27 Thread Richard Sandiford via Gcc-patches
Ping https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613640.html Richard Sandiford writes: > This series of patches fixes PR106594, an aarch64 regression in which > we fail to combine an extension into an address. The first patch just > refactors code. The second patch contains the

Re: [og12] libgomp: Document OpenMP 'pinned' memory (was: [PATCH] libgomp, openmp: pinned memory)

2023-03-27 Thread Andrew Stubbs
On 27/03/2023 12:26, Thomas Schwinge wrote: Hi! On 2023-03-27T09:27:31+, "Stubbs, Andrew" wrote: -Original Message- From: Thomas Schwinge Sent: 24 March 2023 15:50 On 2022-01-04T15:32:17+, Andrew Stubbs wrote: This patch implements the OpenMP pinned memory trait [...] I

Re: [PATCH] target/109296 - riscv: Add missing mode specifiers for XTheadMemPair

2023-03-27 Thread Kito Cheng via Gcc-patches
OK for trunk, thanks :) On Mon, Mar 27, 2023 at 7:04 PM Christoph Muellner < christoph.muell...@vrull.eu> wrote: > From: Christoph Müllner > > This patch adds missing mode specifiers for XTheadMemPair INSNs. > > gcc/ChangeLog: > PR target/109296 > * config/riscv/thead.md: Add

[og12] libgomp: Document OpenMP 'pinned' memory (was: [PATCH] libgomp, openmp: pinned memory)

2023-03-27 Thread Thomas Schwinge
Hi! On 2023-03-27T09:27:31+, "Stubbs, Andrew" wrote: >> -Original Message- >> From: Thomas Schwinge >> Sent: 24 March 2023 15:50 >> >> On 2022-01-04T15:32:17+, Andrew Stubbs >> wrote: >> > This patch implements the OpenMP pinned memory trait [...] >> >> I figure it may be

Re: [PATCH] Modula-2: fix documentation layout

2023-03-27 Thread Eric Botcazou via Gcc-patches
Hi Gaius, > yes indeed and thanks for the patch! You're welcome. The documentation was slightly broken again in the meantime, but nothing really serious this time. Again tested with a modern and an old version of Makeinfo. OK for mainline? 2023-03-27 Eric Botcazou *

[PATCH] target/109296 - riscv: Add missing mode specifiers for XTheadMemPair

2023-03-27 Thread Christoph Muellner
From: Christoph Müllner This patch adds missing mode specifiers for XTheadMemPair INSNs. gcc/ChangeLog: PR target/109296 * config/riscv/thead.md: Add missing mode specifiers. Signed-off-by: Christoph Müllner --- gcc/config/riscv/thead.md | 16 1 file changed,

[PATCH] Changed vector size

2023-03-27 Thread chenyixuan
From: Yixuan Chen Observed a vint type "ABS_EXPR" followed by extra 3 int type "ABS_EXPR". If want to test absolute value optimization for vector, maybe don't need 4 times. gcc/testsuite/ChangeLog: 2023-03-27 Yixuan Chen * g++.dg/pr94920.C: Declare the vector size as long as int.

Re: [PATCH] [rs6000] Correct match pattern in pr56605.c

2023-03-27 Thread Kewen.Lin via Gcc-patches
Hi Haochen, on 2023/3/27 17:46, HAO CHEN GUI wrote: > Kewen, > The case still fails with trunk. > OK, thanks for checking, the proposed patch can catch the expected pattern accurately (excluding noises), so okay for trunk and branches, thanks! BR, Kewen > FAIL: gcc.target/powerpc/pr56605.c

Re: [PATCH] driver: Treat include path args the same way between cpp_unique_options and asm_options. [PR71850]

2023-03-27 Thread Costas Argyris via Gcc-patches
Would it be possible to make it version-dependent, then? As in, if GNU assembler is greater or equal to the version that supports @FILE, then pass @FILE to it, otherwise fall back to the current behavior. I assume most people nowadays would have a version of Binutils later than 2005, but if we

Re: [PATCH] driver: Treat include path args the same way between cpp_unique_options and asm_options. [PR71850]

2023-03-27 Thread Xi Ruoyao via Gcc-patches
On Mon, 2023-03-27 at 10:36 +0100, Costas Argyris via Gcc-patches wrote: > [ping^3] > > This looks like it fixes the bug and also unifies the way include paths are > passed from the driver to the compiler and assembler (when a @file has > been passed to the driver in the first place). > > That

Re: [PATCH] [rs6000] Correct match pattern in pr56605.c

2023-03-27 Thread HAO CHEN GUI via Gcc-patches
Kewen, The case still fails with trunk. FAIL: gcc.target/powerpc/pr56605.c scan-rtl-dump-times combine "\\(compare:CC \\((?:and|zero_extend):(?:[SD]I) \\((?:sub)?reg:[SD]I" 1 === gcc Summary === # of expected passes1 # of unexpected failures1 With the

Re: [PATCH] driver: Treat include path args the same way between cpp_unique_options and asm_options. [PR71850]

2023-03-27 Thread Costas Argyris via Gcc-patches
[ping^3] This looks like it fixes the bug and also unifies the way include paths are passed from the driver to the compiler and assembler (when a @file has been passed to the driver in the first place). That is, when @file has been passed to the driver, put the include paths in a temp @file and

Re: [PATCH] libstdc++: Fix up experimental/net/timer/waitable/dest.cc testcase

2023-03-27 Thread Jonathan Wakely via Gcc-patches
On Monday, March 27, 2023, Jakub Jelinek via Libstdc++ < libstd...@gcc.gnu.org> wrote: > Hi! > > In Fedora package build I've noticed a failure > /builddir/build/BUILD/gcc-13.0.1-20230324/libstdc++-v3/testsuite/experimental/net/timer/waitable/dest.cc: In function 'void test01()': >

Re: [RFC/RFT,V2] CFI: Add support for gcc CFI in aarch64

2023-03-27 Thread Peter Zijlstra
On Sat, Mar 25, 2023 at 01:54:16AM -0700, Dan Li wrote: > In the compiler part[4], most of the content is the same as Sami's > implementation[3], except for some minor differences, mainly including: > > 1. The function typeid is calculated differently and it is difficult > to be consistent.

RE: [og12] libgomp: Document OpenMP 'pinned' memory (was: [PATCH] libgomp, openmp: pinned memory

2023-03-27 Thread Stubbs, Andrew via Gcc-patches
> -Original Message- > From: Thomas Schwinge > Sent: 24 March 2023 15:50 > To: gcc-patches@gcc.gnu.org; Andrew Stubbs ; > Tobias Burnus > Subject: [og12] libgomp: Document OpenMP 'pinned' memory (was: [PATCH] > libgomp, openmp: pinned memory > > Hi! > > On 2022-01-04T15:32:17+,

RE: [PATCH] aarch64: update ampere1 vectorization cost

2023-03-27 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Philipp Tomsich > Sent: Monday, March 27, 2023 9:50 AM > To: Kyrylo Tkachov > Cc: gcc-patches@gcc.gnu.org; Richard Sandiford > ; Tamar Christina > ; Manolis Tsamis > Subject: Re: [PATCH] aarch64: update ampere1 vectorization cost > > On Mon, 27 Mar 2023

Re: [PATCH] aarch64: update ampere1 vectorization cost

2023-03-27 Thread Philipp Tomsich
Applied to master, thanks! Philipp. On Mon, 27 Mar 2023 at 16:45, Kyrylo Tkachov wrote: > > Hi Philipp, > > > -Original Message- > > From: Gcc-patches > bounces+kyrylo.tkachov=arm@gcc.gnu.org> On Behalf Of Philipp > > Tomsich > > Sent: Monday, March 27, 2023 8:47 AM > > To:

Re: Should -ffp-contract=off the default on GCC?

2023-03-27 Thread Zeson via Gcc-patches
Any update on this thread discussion? And the thread was straying to the document of option and user-friendly stuff. So does the default value of -ffp-contract=fast obey the C/C++ language standard? But why does clang not obey? Or is it just compiler implement-dependent which is not specified

[RFC PATCH] ipa-visibility: Fix ICE in lto-partition caused by incorrect comdat group solving in ipa-visibility

2023-03-27 Thread Xionghu Luo via Gcc-patches
I have a case ICE in lto-partion.c:158 not easy to reduce, this ICE appears some time ago from link: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586290.html. I tried the proposed patch but it doesn't work for me. Then I did some hack and finally got a successful lto link to compare

Re: [PATCH] aarch64: update ampere1 vectorization cost

2023-03-27 Thread Philipp Tomsich
On Mon, 27 Mar 2023 at 16:45, Kyrylo Tkachov wrote: > > Hi Philipp, > > > -Original Message- > > From: Gcc-patches > bounces+kyrylo.tkachov=arm@gcc.gnu.org> On Behalf Of Philipp > > Tomsich > > Sent: Monday, March 27, 2023 8:47 AM > > To: gcc-patches@gcc.gnu.org > > Cc: Richard

RE: [PATCH] aarch64: update ampere1 vectorization cost

2023-03-27 Thread Kyrylo Tkachov via Gcc-patches
Hi Philipp, > -Original Message- > From: Gcc-patches bounces+kyrylo.tkachov=arm@gcc.gnu.org> On Behalf Of Philipp > Tomsich > Sent: Monday, March 27, 2023 8:47 AM > To: gcc-patches@gcc.gnu.org > Cc: Richard Sandiford ; Tamar Christina > ; Philipp Tomsich ; > Manolis Tsamis >

Re: [wwwdocs] Add Ada's GCC13 changelog entry

2023-03-27 Thread Arnaud Charlet via Gcc-patches
OK, thanks. > Hi all, > > a bit belated but just like last year, I've made a patch for the Ada > entry in the changelog. You can find the patch attached to this email. > > If I have forgotten anything relevant or if I have done something > incorrectly, please, say so. > > Best regards, >

[PATCH] libstdc++: Fix up experimental/net/timer/waitable/dest.cc testcase

2023-03-27 Thread Jakub Jelinek via Gcc-patches
Hi! In Fedora package build I've noticed a failure /builddir/build/BUILD/gcc-13.0.1-20230324/libstdc++-v3/testsuite/experimental/net/timer/waitable/dest.cc: In function 'void test01()': /builddir/build/BUILD/gcc-13.0.1-20230324/libstdc++-v3/testsuite/experimental/net/timer/waitable/dest.cc:41:

Re: [PATCH] RISC-V: Add Z*inx incompatible check in gcc.

2023-03-27 Thread Kito Cheng via Gcc-patches
HI Jiawei: Thanks for the fix! Two comments: - Could you add testcase like https://github.com/gcc-mirror/gcc/blob/master/gcc/testsuite/gcc.target/riscv/arch-12.c - And I would prefer those check happened in riscv_subset_list::parse @gcc/common/config/riscv/riscv-common.cc On Sun, Mar 26, 2023

[PATCH] rs6000: Fix predicate for const vector in sldoi_to_mov [PR109069]

2023-03-27 Thread Kewen.Lin via Gcc-patches
Hi, As PR109069 shows, commit r12-6537-g080a06fcb076b3 which introduces define_insn_and_split sldoi_to_mov adopts easy_vector_constant for const vector of interest, but it's wrong since predicate easy_vector_constant doesn't guarantee each byte in the const vector is the same. One counter

[PATCH (pushed)] fix: pytest error

2023-03-27 Thread Martin Liška
Fixes: gcc/testsuite/lib/verify-sarif-file.py:10:27: Q000 Double quotes found but single quotes preferred gcc/testsuite/ChangeLog: * lib/verify-sarif-file.py: Use apostrophes instead of double quotes. --- gcc/testsuite/lib/verify-sarif-file.py | 2 +- 1 file changed, 1

[PATCH] aarch64: update ampere1 vectorization cost

2023-03-27 Thread Philipp Tomsich
The original submission of AmpereOne (-mcpu=ampere1) costs occurred prior to exhaustive testing of vectorizable workloads against hardware. Adjust the vector costs to achieve the best results and more closely match the underlying hardware. gcc/ChangeLog: * config/aarch64/aarch64.cc:

Re: [PATCH] [rs6000] Correct match pattern in pr56605.c

2023-03-27 Thread Kewen.Lin via Gcc-patches
Hi Alexandre and Haochen, on 2023/3/25 16:42, Alexandre Oliva via Gcc-patches wrote: > > Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590958.html > > From: Haochen Gui > > This patch corrects the match pattern in pr56605.c. The former pattern > is wrong and test case fails

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Iain Sandoe
Hi Richard > On 27 Mar 2023, at 12:48, Richard Biener wrote: > > On Mon, Mar 27, 2023 at 8:58 AM Iain Sandoe wrote: >> >> Hi Richard, >> (I’m away from my usual infrastructure, so responses could be slow and >> testing things >> could take a while). >> >>> On 27 Mar 2023, at 12:10, Richard

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Richard Biener via Gcc-patches
On Mon, Mar 27, 2023 at 8:58 AM Iain Sandoe wrote: > > Hi Richard, > (I’m away from my usual infrastructure, so responses could be slow and > testing things > could take a while). > > > On 27 Mar 2023, at 12:10, Richard Biener wrote: > > > > On Sun, Mar 26, 2023 at 6:55 PM Iain Sandoe via

Re: [PATCH, rs6000] rs6000: correct vector sign extend built-ins on Big Endian [PR108812]

2023-03-27 Thread Kewen.Lin via Gcc-patches
Hi Haochen, Thanks for fixing this. on 2023/3/27 14:16, HAO CHEN GUI wrote: > Hi, > This patch removes byte reverse operation before vector integer sign > extension on Big Endian. These built-ins require to sign extend the rightmost > element. So both BE and LE should do the same operation and

Re: [PATCH] [PR99708] [rs6000] don't expect __ibm128 with 64-bit long double

2023-03-27 Thread Kewen.Lin via Gcc-patches
Hi Alexandre, Thanks for fixing this. on 2023/3/25 16:37, Alexandre Oliva via Gcc-patches wrote: > > When long double is 64-bit wide, as on vxworks, the rs6000 backend > defines neither the __ibm128 type nor the __SIZEOF_IBM128__ macro, but > pr99708.c expected both to be always defined.

Re: [PATCH] [testsuite] [ppc] expect vectorization in gen-vect-11c.c

2023-03-27 Thread Kewen.Lin via Gcc-patches
Hi Alexandre, on 2023/3/25 16:35, Alexandre Oliva wrote: > > The first loop in main gets stores "vectorized" on powerpc into > full-word stores, even without any vector instruction support, so the > test's expectation of no loop vectorization is not met. > I think this test issue has been gone

Re: [PATCH, V2] PR target/105325, Make load/cmp fusion know about prefixed load

2023-03-27 Thread Kewen.Lin via Gcc-patches
Hi Mike, on 2023/3/25 07:06, Michael Meissner wrote: > I posted a version of patch on March 21st. This patch makes some code changes > suggested in the genfusion.pl code. The only change is in genfusion.pl. The > fusion.md that it makes is the same. > > The issue with the bug is the power10

[PATCH] RISC-V: Fix PR108279

2023-03-27 Thread juzhe . zhong
From: Juzhe-Zhong PR 108270 Fix bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108270. Consider the following testcase: void f (void * restrict in, void * restrict out, int l, int n, int m) { for (int i = 0; i < l; i++){ for (int j = 0; j < m; j++){ for (int k = 0; k <

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Iain Sandoe
Hi Richard, (I’m away from my usual infrastructure, so responses could be slow and testing things could take a while). > On 27 Mar 2023, at 12:10, Richard Biener wrote: > > On Sun, Mar 26, 2023 at 6:55 PM Iain Sandoe via Gcc-patches > wrote: >> >> Tested on x86_64-darwin21, x86-64-linux-gnu

Re: [PATCH] lto/109263 - lto-wrapper and -g0 -ggdb

2023-03-27 Thread Richard Biener via Gcc-patches
On Thu, 23 Mar 2023, Richard Biener wrote: > The following makes lto-wrapper deal with non-combined debug > disabling / enabling option combinations properly. Interestingly > -gno-dwarf also enables debug. > > Bootstrap / regtest running on x86_64-unknown-linux-gnu. > > OK? Or do we want to

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Richard Biener via Gcc-patches
On Sun, Mar 26, 2023 at 6:55 PM Iain Sandoe via Gcc-patches wrote: > > Tested on x86_64-darwin21, x86-64-linux-gnu > OK for trunk? > Iain > > When we need to 'promote' a value (i.e. store it in the coroutine frame) it > is given a frame entry name. This was based on the DECL_UID for slot vars. >

[PATCH, rs6000] rs6000: correct vector sign extend built-ins on Big Endian [PR108812]

2023-03-27 Thread HAO CHEN GUI via Gcc-patches
Hi, This patch removes byte reverse operation before vector integer sign extension on Big Endian. These built-ins require to sign extend the rightmost element. So both BE and LE should do the same operation and the byte reversion is no need. This patch fixes it. Now these built-ins have the same