Re: [PATCH] combine: Fix simplify_comparison AND handling for WORD_REGISTER_OPERATIONS targets [PR109040]

2023-04-08 Thread Jeff Law via Gcc-patches
On 4/6/23 05:37, Jakub Jelinek wrote: On Thu, Apr 06, 2023 at 12:51:20PM +0200, Eric Botcazou wrote: If we want to fix it in the combiner, I think the fix would be following. The optimization is about (and:SI (subreg:SI (reg:HI xxx) 0) (const_int 0x84c)) and IMHO we can only optimize it into

Re: [PATCH] combine: Fix simplify_comparison AND handling for WORD_REGISTER_OPERATIONS targets [PR109040]

2023-04-08 Thread Jeff Law via Gcc-patches
On 4/6/23 08:21, Eric Botcazou wrote: So, perhaps just in the return op0; case add further code for WORD_REGISTER_OPERATIONS and sub-word modes which will call nonzero_bits again for the word mode and decide if it is still safe. Does it work to just replace mode by word_mode in the calls

[r13-7120 Regression] FAIL: gfortran.dg/gomp/affinity-clause-1.f90 -O scan-tree-dump-times original "#pragma omp task affinity\\(iterator\\(integer\\(kind=4\\) i=D\\.[0-9]+:5:1\\):b\\[\\(.* ?

2023-04-08 Thread haochen.jiang via Gcc-patches
On Linux/x86_64, 46fe32cb4d887d44a62f9c4ff2a72532d4eb5a19 is the first bad commit commit 46fe32cb4d887d44a62f9c4ff2a72532d4eb5a19 Author: Paul Thomas Date: Sat Apr 8 07:49:13 2023 +0100 Fortran: Fix dg directives and remove trailing whitespaces in testsuite caused FAIL:

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

2023-04-08 Thread Ken Matsui via Gcc-patches
I see. Thank you! On Sat, Apr 8, 2023 at 12:52 AM Jonathan Wakely wrote: > > This looks good, thanks, but we're too close to the gcc 13 release now, and > this isn't fixing any bugs. I'll push it after the release. > > > On Thu, 23 Mar 2023, 11:07 Ken Matsui via Libstdc++, > wrote: >> >> In

Re: [RFA][Bug target/108892 ][13 regression] Force re-recognition after changing RTL structure of an insn

2023-04-08 Thread Jeff Law via Gcc-patches
On 4/5/23 13:02, Segher Boessenkool wrote: Hi again, On Wed, Apr 05, 2023 at 11:43:30AM -0600, Jeff Law wrote: On 4/5/23 11:38, Segher Boessenkool wrote: Right. But it seems to me it has been there all those years? Does the new testcase fail on older branches? Even if not, it seems

Re: [PATCH V4] RISC-V: Fix a redefinition bug for the fd-4.c

2023-04-08 Thread Jeff Law via Gcc-patches
On 4/6/23 21:37, shiyul...@iscas.ac.cn wrote: From: yulong This patch fix a redefinition bug. There are have a definition about mode_t in the fd-4.c, but it duplicates the definition in types.h that be included by stdio.h. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/fd-4.c:

Re: [PATCH v3] RISC-V: Fix regression of -fzero-call-used-regs=all

2023-04-08 Thread Jeff Law via Gcc-patches
On 4/7/23 06:32, yanzhang.wang--- via Gcc-patches wrote: From: Yanzhang Wang This patch registers a riscv specific function to TARGET_ZERO_CALL_USED_REGS instead of default in targhooks.cc. It will clean gpr and vector relevant registers. PR 109104 gcc/ChangeLog: *

[committed] [PR tree-optimization/109392] Handle failure from maybe_push_res_to_seq

2023-04-08 Thread Jeff Law via Gcc-patches
I was scanning through the P3s today and saw this patch from Jakub to fix 109392. It looked quite reasonable, so I went ahead and did the bootstrap & regression test. Everything looked good and I've applied it to the trunk. Jeff commit 101380a8394c22a7a2ea70de2060ee93716156e2 Author: Jakub

Re: [PATCH] c++, coroutines: Fix block nests when the function has no top-level bind.

2023-04-08 Thread Jason Merrill via Gcc-patches
On 4/6/23 02:27, Iain Sandoe wrote: I spotted this problem while trying to collate my WIP patches (sorry for not spotting it when the original patch was discussed). Although we do not yet have any regression filed against this (AFAIK), it's only a matter of time - so I'd suggest that we should

[committed] hppa: Fix gcc.dg/long_branch.c on hppa

2023-04-08 Thread John David Anglin
Committed to trunk. Dave --- Fix gcc.dg/long_branch.c on hppa. 2023-04-08 John David Anglin gcc/testsuite/ChangeLog: * gcc.dg/long_branch.c: Use timeout factor 2.0 on hppa*-*-*. diff --git a/gcc/testsuite/gcc.dg/long_branch.c b/gcc/testsuite/gcc.dg/long_branch.c index

Re: [PATCH] PR target/109402: v850 (not v850e) variant of __muldi3() moves sp in reversed direction [PR109402]

2023-04-08 Thread Jeff Law via Gcc-patches
On 4/6/23 23:25, ポニー電機(株) 星野 wrote: Where I talk about is: /libgcc/config/v850/lib1funcs.S L2214, L2259 - in a commit 8b1204d7. There are stack-pointer operations. I think these operations: shrink before, grow after --- may reversed way. There is one more consideration; this version of

Re: [PATCH, V3] PR target/70243 - Do not generate vmaddfp or vnmsubdp

2023-04-08 Thread Segher Boessenkool
Hi! On Sat, Apr 08, 2023 at 09:34:51AM -0400, Michael Meissner wrote: > The Altivec instructions vmaddfp and vnmsubfp have different rounding > behaviors > than the VSX xvmaddsp and xvnmsubsp instructions. In particular, generating > these instructions seems to break Eigen on big endian

Re: Ping! [Patch, fortran] PR87477 - [meta-bug] [F03] issues concerning the ASSOCIATE statement

2023-04-08 Thread Harald Anlauf via Gcc-patches
Hi Paul, On 4/7/23 23:35, Paul Richard Thomas via Gcc-patches wrote: Hi Harald, Well done on noticing the memory leak :-) I have a fix for it that I was going to post separately. Actually, it is a trivial one liner, which I could include with the patch. thanks for addressing this! I can

[PATCH, V3] PR target/70243 - Do not generate vmaddfp or vnmsubdp

2023-04-08 Thread Michael Meissner via Gcc-patches
This is version 3 of the patch. This is essentially version 1 with the removal of changes to altivec.md, and cleanup of the comments. Version 2 generated the vmaddfp and vnmsubfp instructions if -Ofast was used, and those changes are deleted in this patch. The Altivec instructions vmaddfp and

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

2023-04-08 Thread Jonathan Wakely via Gcc-patches
This looks good, thanks, but we're too close to the gcc 13 release now, and this isn't fixing any bugs. I'll push it after the release. On Thu, 23 Mar 2023, 11:07 Ken Matsui via Libstdc++, wrote: > In the type_traits header, both integral_constant and __bool_constant > are used. This patch