Re: [PATCH v2] C, ObjC: Add -Wunterminated-string-initialization

2023-09-30 Thread Alejandro Colomar
Hi David, Sorry for the half-year delay! I have some update. :) On Fri, Mar 24, 2023 at 10:53:22AM -0400, David Malcolm wrote: > On Fri, 2023-03-24 at 14:39 +0100, Alejandro Colomar via Gcc-patches > wrote: > > Warn about the following: > > > >     char  s[3] = "foo"; > > > > Initializing a

Re: [PATCH] Cleanup: Replace UNSPEC_COPYSIGN with copysign RTL

2023-09-30 Thread Segher Boessenkool
On Fri, Sep 29, 2023 at 02:09:12PM -0400, Michael Meissner wrote: > * config/rs6000/rs6000.md (UNSPEC_COPYSIGN): Delete. > (copysign3_fcpsg): Use copysign RTL instead of UNSPEC. (typo, it is _fcpsgn) Nice to see unnecessary unspecs going away :-) Segher

[Committed] RISC-V: Use safe_grow_cleared for vector info [PR111469]

2023-09-30 Thread Patrick O'Neill
Committed. Thanks Juzhe! I had to adjust the changelog's PR formatting to get the pre-commit hooks to accept it. Here's the committed patch: From f446cf5d58568e406cc81f434a63b3045942e9a9 Mon Sep 17 00:00:00 2001 From: Patrick O'Neill Date: Sat, 30 Sep 2023 15:50:11 -0700 Subject: [PATCH]

Re: [PATCH] RISC-V: Use safe_grow_cleared for vector info [PR111469]

2023-09-30 Thread 钟居哲
LGTM. juzhe.zh...@rivai.ai From: Patrick O'Neill Date: 2023-10-01 07:00 To: gcc-patches; juzhe.zhong CC: jakub; pinskia; JeffreyALaw; gnu-toolchain; Patrick O'Neill Subject: [PATCH] RISC-V: Use safe_grow_cleared for vector info [PR111469] Resolves a riscv*-*-* bootstrap failure due to a

[PATCH] RISC-V: Use safe_grow_cleared for vector info [PR111469]

2023-09-30 Thread Patrick O'Neill
Resolves a riscv*-*-* bootstrap failure due to a newly-turned-on assert. 2023-09-30 Jakub Jelinek PR target/111649 gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (vector_infos_manager::vector_infos_manager): Replace safe_grow with safe_grow_cleared. ---

Re: Re: [PATCH] RISC-V: Enable RVV scalable vectorization by default[PR111311]

2023-09-30 Thread 钟居哲
Trunk GCC still has some bugs need to be addressed. A few issues are middld-end related to COND_LEN_xxx (Robin has sent a patch but waiting for Richard's review). A few issues are VSETVL PASS (Lehua is working on refactoring and cleanup up the VSETVL PASS to address all potential issues of

Re: RFA: RISC-V: Make riscv_vector::legitimize_move adjust SRC in the caller. (Was: Remove mem-to-mem VLS move pattern[PR111566])

2023-09-30 Thread 钟居哲
Great! Thanks for fixing it. LGTM. juzhe.zh...@rivai.ai From: Joern Rennecke Date: 2023-10-01 04:30 To: GCC Patches CC: Jeff Law; 钟居哲 Subject: RFA: RISC-V: Make riscv_vector::legitimize_move adjust SRC in the caller. (Was: Remove mem-to-mem VLS move pattern[PR111566]) >On 9/27/23 03:38,

Re: [PATCH] RISC-V: Enable RVV scalable vectorization by default[PR111311]

2023-09-30 Thread Vineet Gupta
On 9/11/23 06:12, Jeff Law via Gcc-patches wrote: On 9/10/23 21:42, juzhe.zh...@rivai.ai wrote: Ping this patch. I think it's time to enable scalable vectorization by default and do the whole regression every time (except vect.exp that we didn't enable yet) Update current FAILs

Re: committed [RISC-V]: Harden test scan patterns

2023-09-30 Thread Joern Rennecke
On Fri, 29 Sept 2023 at 14:54, Jeff Law wrote: > So I recommend we go forward with Joern's approach (so consider that an > ACK for the trunk). Joern can you post a follow-up manual twiddle so > that other ports can follow your example and avoid this problem? The manual... so not in the

[PATCH v2] rtl: fix build failure on -fchecking=2 [PR111642]

2023-09-30 Thread Sergei Trofimovich
From: Sergei Trofimovich Before the change `make bootstrap4` (or `make profiledbootstrap`) failed as: gcc/rtl-tests.cc:249:25: in ‘constexpr’ expansion of ‘poly_int<1, long int>(1, 1)’ gcc/poly-int.h:453:5: error: too many initializers for ‘long int [1]’ The failure happened only in

Re: [PATCH] arm: add -static-pie support

2023-09-30 Thread Ben Wolsieffer
On Tue, Jul 19, 2022 at 02:21:05PM -0600, lancethepants wrote: > The commit mirros code from aarch64 to handle -static-pie. > Tested with uclibc-ng and musl c-standard libraries. > > Signed-off-by: Lance Fredrickson > --- > gcc/config/arm/linux-elf.h | 5 +++-- > 1 file changed, 3

Re: [PATCH] rtl: fix buidl failure on -fchecking=2 [PR111642]

2023-09-30 Thread Andreas Schwab
On Sep 30 2023, Sergei Trofimovich wrote: > @@ -263,7 +253,7 @@ const_poly_int_tests::run () >ASSERT_KNOWN_EQ (rtx_to_poly_int64 (x255), poly_int64 (1, -1)); >ASSERT_MAYBE_NE (rtx_to_poly_int64 (x255), poly_int64 (1, 255)); > > - /* Test plus_constant of a symbol. */ > + /* Test

[PATCH] rtl: fix buidl failure on -fchecking=2 [PR111642]

2023-09-30 Thread Sergei Trofimovich
From: Sergei Trofimovich Before the change `make bootstrap4` (or `make profiledbootstrap`) failed as: gcc/rtl-tests.cc:249:25: in ‘constexpr’ expansion of ‘poly_int<1, long int>(1, 1)’ gcc/poly-int.h:453:5: error: too many initializers for ‘long int [1]’ The failure happened only in

Re: gcc-patches From rewriting mailman settings

2023-09-30 Thread Mark Wielaard
Hi, On Sun, Sep 17, 2023 at 10:04:37PM +0200, Mark Wielaard wrote: > On Tue, Sep 12, 2023 at 05:00:07PM +0200, Mark Wielaard wrote: > > We (Jeff or anyone else with mailman admin privs) could use the same > > settings for gcc-patches. The settings that need to be set are in that > > bug: > > > >

Re: [PATCH v2] ARM: Block predication on atomics [PR111235]

2023-09-30 Thread Ramana Radhakrishnan
+ linaro-toolchain as I don't understand the CI issues on patchwork. On Wed, Sep 27, 2023 at 8:40 PM Wilco Dijkstra wrote: > > Hi Ramana, > > > Hope this helps. > > Yes definitely! > > >> Passes regress/bootstrap, OK for commit? > > > > Target ? armhf ? --with-arch , -with-fpu , -with-float

Re: Ping^2 [PATCH V5 1/4] rs6000: build constant via li;rotldi

2023-09-30 Thread David Edelsohn
On Mon, Sep 25, 2023 at 10:52 PM Jiufu Guo wrote: > Hi, > > Gentle ping... > > BR, > Jeff (Jiufu Guo) > This is okay. Thanks, David > > Jiufu Guo via Gcc-patches writes: > > > Hi, > > > > Gentle ping... > > > > BR, > > Jeff (Jiufu Guo) > > > > Jiufu Guo writes: > > > >> Hi, > >> > >> If a

RFA: RISC-V: Make riscv_vector::legitimize_move adjust SRC in the caller. (Was: Remove mem-to-mem VLS move pattern[PR111566])

2023-09-30 Thread Joern Rennecke
>On 9/27/23 03:38, juzhe.zh...@rivai.ai wrote: >> >> Why add `can_create_pseudo_p ()` here? this will split after reload, but we forbid that pattern between reload and split2? >> >> I have no ideal. Some fortran tests just need recognization of >> mem-to-mem pattern before RA >> I don't know

Re: [PATCH] vec.h: Guard most of static assertions for GCC >= 5

2023-09-30 Thread Patrick O'Neill
Hi Jakub, A follow-up commit of yours (9d249b7e31e) is causing bootstrap failures for riscv*-*-* targets. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111649 Patrick On 9/29/23 03:42, Jakub Jelinek wrote: Hi! As reported by Jonathan on IRC, my vec.h patch broke build with GCC 4.8.x or

Re: [Fortran, Patch, Coarray, PR 37336] Fix crash in finalizer when derived type coarray is already freed.

2023-09-30 Thread Andre Vehreschild
Hi all, back porting to gcc-13 unfortunately caused a regression due to gfc_deallocate_with_status() having a different parameter count. This is fixed as obvious by 874b895fffd921659b37dc05bc94eea48e9a0157. Sorry for breaking gfortran-13. I still don't know why it checkout fine on my system in

[PATCH] mingw-w64: avoid undefining _REENTRANT

2023-09-30 Thread Stephen Kitt
When pthread is used by default, _REENTRANT should be defined in all cases except -no-pthread. When pthread is not used by default, _REENTRANT should only be defined with -pthread. The current spec for mingw-w64 for default pthread is %{!no-pthread:-D_REENTRANT} %{pthread:-U_REENTRANT} and

[PATCH v3 2/2] RISC-V: Add support for XCValu extension in CV32E40P

2023-09-30 Thread Mary Bennett
Spec: github.com/openhwgroup/core-v-sw/blob/master/specifications/corev-builtin-spec.md Contributors: Mary Bennett Nandni Jamnadas Pietra Ferreira Charlie Keaney Jessica Mills Craig Blackmore Simon Cook Jeremy Bennett Helene Chelin gcc/ChangeLog: *

[PATCH v3 1/2] RISC-V: Add support for XCVmac extension in CV32E40P

2023-09-30 Thread Mary Bennett
Spec: github.com/openhwgroup/core-v-sw/blob/master/specifications/corev-builtin-spec.md Contributors: Mary Bennett Nandni Jamnadas Pietra Ferreira Charlie Keaney Jessica Mills Craig Blackmore Simon Cook Jeremy Bennett Helene Chelin gcc/ChangeLog: *

[PATCH v3 0/2] RISC-V: Support CORE-V XCVMAC and XCVALU extensions

2023-09-30 Thread Mary Bennett
Thank you for reviewing this patch. v1->v2: * Add XCValu RTL. * Change assembly mnemonics from mixed case to lower case. v2->v3: * Change commit message from past tense to present. * Add documentation for new dg-effective-targets. This patch series presents the comprehensive

Re: [PATCH] match.pd: Avoid another build_nonstandard_integer_type call [PR111369]

2023-09-30 Thread Jakub Jelinek
On Sat, Sep 30, 2023 at 11:44:59AM +0200, Jakub Jelinek wrote: > I really can't figure out why one would need to add extra casts. > type must be an integral type which has BIT_NOT_EXPR applied on it > which yields all ones and we need a type in which negating 0 or 1 > range will yield 0 or all

[PATCH] match.pd: Avoid another build_nonstandard_integer_type call [PR111369]

2023-09-30 Thread Jakub Jelinek
Hi! I really can't figure out why one would need to add extra casts. type must be an integral type which has BIT_NOT_EXPR applied on it which yields all ones and we need a type in which negating 0 or 1 range will yield 0 or all ones, I think all integral types satisfy that. This fixes PR111369,

[committed] gimple-match-head: Fix a pasto in function comment

2023-09-30 Thread Jakub Jelinek
Hi! This function comment has been pasted from gimple_bitwise_equal_p and haven't been adjusted for different function name. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2023-09-30 Jakub Jelinek * gimple-match-head.cc

[committed] lowerbitint: Fix 2 bitint lowering bugs [PR111625]

2023-09-30 Thread Jakub Jelinek
Hi! This patch fixes 2 issues. One is when we want to get address of an uninitialized large/huge bitint SSA_NAME for multiplication/division/modulo or conversion to floating point (binary or decimal), the code just creates an uninitialized limb sized variable and passes address of that, but I