On Fri, Aug 23, 2019 at 3:13 AM Martin Liška wrote:
> On 8/23/19 6:17 AM, Alex Henrie wrote:
> > +vec ignored_wnoerror_options;
>
> Here you'll need to add a comment.
The declaration of ignored_options in opts-global.c doesn't have a
comment either. What would you like the
* c-c++-common/pr65403-1.c: New test.
* c-c++-common/pr65403-2.c: New test.
---
gcc/testsuite/c-c++-common/pr65403-1.c | 10 ++
gcc/testsuite/c-c++-common/pr65403-2.c | 15 +++
2 files changed, 25 insertions(+)
create mode 100644
From: Manuel López-Ibáñez
* opts-common.c (ignored_wnoerror_options): New global variable.
* opts-global.c (print_ignored_options): Ignore
-Wno-error= except if there are other
diagnostics.
* opts.c (enable_warning_as_error): Record ignored -Wno-error
* c-c++-common/pr65403-1.c: New test.
* c-c++-common/pr65403-2.c: New test.
---
gcc/testsuite/c-c++-common/pr65403-1.c | 10 ++
gcc/testsuite/c-c++-common/pr65403-2.c | 15 +++
2 files changed, 25 insertions(+)
create mode 100644
From: Manuel López-Ibáñez
* opts-common.c (ignored_wnoerror_options): New global variable.
* opts-global.c (print_ignored_options): Ignore
-Wno-error= except if there are other
diagnostics.
* opts.c (enable_warning_as_error): Record ignored -Wno-error
On Wed, Jun 19, 2019 at 11:52 AM Jeff Law wrote:
>
> On 3/18/19 8:46 PM, Alex Henrie wrote:
> > From: Manuel López-Ibáñez
> >
> > * opts.c: Ignore -Wno-error= except if there are
> > other diagnostics.
> That's not a complete ChangeLog entry. Each file/funct
On Fri, May 31, 2019 at 1:38 AM Richard Biener wrote:
>
> On Thu, 30 May 2019, Alex Henrie wrote:
>
> > In Wine we need a way to (without warnings) put ms_hook_prologue into
> > a macro that is applied to functions, function pointers, and function
> > pointer type
On Thu, May 30, 2019 at 6:59 PM Joseph Myers wrote:
>
> On Thu, 30 May 2019, Alex Henrie wrote:
>
> > At this point I think I'm convinced that any attribute that applies to
> > a function should also be allowed on a function pointer without any
> > warnings.
On Tue, May 28, 2019 at 1:05 PM Martin Sebor wrote:
>
> On 5/24/19 9:49 AM, Alex Henrie wrote:
> > Then is it preferable to simply silence Wattributes in this case?
>
> This case being PR86407? I'd say yes.
> Attribute malloc attaches only to fndecl and not its type
On Sat, May 25, 2019 at 12:34 AM Richard Biener wrote:
>
> On May 24, 2019 5:49:38 PM GMT+02:00, Alex Henrie
> wrote:
> >As far as I can tell, "fndecl" is a misnomer: these attributes are
> >more accurately called "function definition attributes", i.
On Fri, May 24, 2019 at 2:01 AM Richard Biener wrote:
>
> I'm not sure we really need a new warning for this.
On Fri, May 24, 2019 at 9:23 AM Martin Sebor wrote:
>
> I don't think GCC makes a formal distinction between function
> attributes that affect only function definitions vs those that
>
---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86407#c6
---
gcc/c-family/c.opt | 4
gcc/c/c-decl.c | 4 +++-
gcc/config/i386/i386-options.c | 12 ++--
gcc/testsuite/c-c++-common/pr86407-1.c | 23 +++
On Tue, Mar 19, 2019 at 10:09 PM Alex Henrie wrote:
>
> On Tue, Mar 19, 2019 at 11:03 AM Martin Liška wrote:
> >
> > What's Joseph telling is that right now the patch can't be approved (and
> > installed).
> > It's due to fact that we are close to the release in s
On Tue, Mar 19, 2019 at 11:03 AM Martin Liška wrote:
>
> What's Joseph telling is that right now the patch can't be approved (and
> installed).
> It's due to fact that we are close to the release in stage4:
> https://www.gnu.org/software/gcc/develop.html#stage4
>
> So that a proper review will
From: Manuel López-Ibáñez
* opts.c: Ignore -Wno-error= except if there are
other diagnostics.
---
gcc/opts-common.c | 2 ++
gcc/opts-global.c | 10 +++---
gcc/opts.c| 5 -
gcc/opts.h| 2 ++
4 files changed, 15 insertions(+), 4 deletions(-)
diff --git
---
gcc/testsuite/c-c++-common/pr65403-1.c | 10 ++
gcc/testsuite/c-c++-common/pr65403-2.c | 15 +++
2 files changed, 25 insertions(+)
create mode 100644 gcc/testsuite/c-c++-common/pr65403-1.c
create mode 100644 gcc/testsuite/c-c++-common/pr65403-2.c
diff --git
On Tue, Mar 19, 2019 at 11:26 AM Martin Sebor wrote:
>
> Please remember to quote the command line options in the message
> (same as in the error below):
I'll send a new version. Thanks for the feedback!
-Alex
On Tue, Mar 19, 2019 at 3:19 AM Martin Liška wrote:
>
> On 3/19/19 3:46 AM, Alex Henrie wrote:
> > Hello,
> >
> > I have received permission to contribute to GCC, but I do not have
> > commit access. Could one of you please merge these patches for me?
>
> Hi.
&
Hello,
I have received permission to contribute to GCC, but I do not have
commit access. Could one of you please merge these patches for me?
-Alex
Alex Henrie (1):
PR c/65403 - Add tests for -Wno-error=
Manuel López-Ibáñez (1):
PR c/65403 - Ignore -Wno-error=
gcc/opts-common.c
From: Manuel López-Ibáñez
* opts.c: Ignore -Wno-error= except if there are
other diagnostics.
---
gcc/opts-common.c | 2 ++
gcc/opts-global.c | 10 +++---
gcc/opts.c| 5 -
gcc/opts.h| 2 ++
4 files changed, 15 insertions(+), 4 deletions(-)
diff --git
---
gcc/testsuite/c-c++-common/pr65403-1.c | 10 ++
gcc/testsuite/c-c++-common/pr65403-2.c | 15 +++
2 files changed, 25 insertions(+)
create mode 100644 gcc/testsuite/c-c++-common/pr65403-1.c
create mode 100644 gcc/testsuite/c-c++-common/pr65403-2.c
diff --git
* opts.c: Ignore -Wno-error=.
---
gcc/opts.c | 5 -
gcc/testsuite/c-c++-common/pr89524.c | 7 +++
2 files changed, 11 insertions(+), 1 deletion(-)
create mode 100644 gcc/testsuite/c-c++-common/pr89524.c
diff --git a/gcc/opts.c b/gcc/opts.c
index
22 matches
Mail list logo
