On Mon, Jul 11, 2016 at 4:27 PM, Ian Lance Taylor <i...@google.com> wrote:
> On Mon, Jul 11, 2016 at 1:05 PM, Brooks Moses <bmo...@google.com> wrote:
>> Ping?
>
> This is fine, but please add a comment explaining why the code avoids
> 0-length VLAs. Thanks.
Ping?
(I suspect I should have added a libiberty maintainer to cc in the first place.)
On Mon, Jun 13, 2016 at 9:05 AM, Brooks Moses <bmo...@google.com> wrote:
> Zero-length variable-length-arrays are not allowed in standard C99,
> and perhaps more importantly, they cause ASAN to com
libiberty/ChangeLog
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,8 @@
+2016-06-12 Brooks Moses <bmo...@google.com>
+
+ * cp-demangle.c (cplus_demangle_print_callback): Avoid zero-length
+ VLAs.
+
2016-05-31 Alan Modra <amo...@
copy)
@@ -1,3 +1,7 @@
+2014-01-31 Brooks Moses bmo...@google.com
+
+ * gcc_update (files_and_dependencies): Add aarch64-tune.md.
+
2013-10-21 Mike Stump mikest...@comcast.net
* gcc_update (configure): Update to handle svn 1.8.1.
Index: contrib/gcc_update
symbols with the old mangling.
Ok to commit?
(An alternate approach would be to force -mabi-version=2, and check
for the presence of both sets of symbols. That seems overkill to me,
but I can alter the test to do that if desired.)
Thanks,
- Brooks
2013-10-11 Brooks Moses bmo...@google.com
On Fri, Oct 11, 2013 at 4:59 PM, Brooks Moses bmo...@google.com wrote:
I committed a patch to update the xfail file for our 32-bit Power
build configuration. As with the others, this ends up being a
significant reorganization, so the diff is less interesting than the
revised file. Thus, I've
This patch updates the powerpc64le xfails file on the google/gcc-4_8
branch to reflect two new failures caused by the addition of a new
vectorization testcase. Committed as obvious.
- Brooks
2013-09-23_powerpc64le-xfails.diff
Description: Binary data
Diego -
In http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00174.html I proposed
a patch to fix PR58312, which is that libssp when cross-compiled
assumes that vnsprintf is broken [1]. This is causing our libssp.so
to be missing some symbols that are referenced by some pre-existing
binaries.
The
On Thu, Sep 12, 2013 at 8:42 AM, Joseph S. Myers
jos...@codesourcery.com wrote:
On Wed, 11 Sep 2013, Brooks Moses wrote:
Joseph, I'd been cc'ing you on this because it's driver-related and I
didn't find a more-obvious reviewer. Is there someone else I should
be asking to review
On Thu, Sep 12, 2013 at 11:19 AM, DJ Delorie d...@redhat.com wrote:
The patch is OK with me from a build machinery point of view.
Thanks, DJ. Based on that and Joseph's comments elsewhere that
removing these binaries is the right thing to do, I've committed the
patch.
At Ian Taylor's
at 9:32 AM, Brooks Moses bmo...@google.com wrote:
Ping^2?
On 08/22/2013 02:00 PM, Brooks Moses wrote:
Ping?
On 08/08/2013 02:10 PM, Brooks Moses wrote:
As discussed in PR/42955, when GCC is built as a cross-compiler, it
will install gcc, g++, c++, and gfortran binaries in
$(target)/bin
On Wed, Sep 4, 2013 at 12:01 AM, Jakub Jelinek ja...@redhat.com wrote:
That looks wrong, the test was intentionally looking for badly implemented
vsnprintf, see
http://www.gnu.org/software/gnulib/manual/html_node/snprintf.html
This function does not return a byte count as specified in C99 on
Ping^2?
On 08/22/2013 02:00 PM, Brooks Moses wrote:
Ping?
On 08/08/2013 02:10 PM, Brooks Moses wrote:
As discussed in PR/42955, when GCC is built as a cross-compiler, it
will install gcc, g++, c++, and gfortran binaries in
$(target)/bin, as well as installing the $target-gcc and so forth
relatively innocuous.
Jakub, I'm cc'ing you in hopes that you're a reasonably appropriate
person to review this.
Ok for trunk?
Thanks,
- Brooks
2013-09-03 Brooks Moses bmo...@google.com
* configure.ac: Replace runtime vsnprintf check with
compile-time
Ping?
On 08/08/2013 02:10 PM, Brooks Moses wrote:
As discussed in PR/42955, when GCC is built as a cross-compiler, it
will install gcc, g++, c++, and gfortran binaries in
$(target)/bin, as well as installing the $target-gcc and so forth in
bin. However, these binaries in $(target)/bin do
I fixed the bits in our DejaGNU powerpc64 board file to transfer
profile output back to the build system from the remote target, which
means that a bunch of test failures now go away, and we uncover a
small handful of new ones.
This patch updates the xfail file accordingly. Committed as obvious.
One of the Fortran failures in the powerpc64le xfail file I committed
to the Google 4.8 branch last week is no longer failing. This patch
removes it from the xfails file.
Committed as obvious.
- Brooks
2013-08-12_xfail-fixup.diff
Description: Binary data
, which simply removes these broken executables.
Tested by building a cross-compiler and confirming that they are gone,
and by building a native compiler and confirming that the expected
bin/gcc, bin/g++, bin/c++, and bin/gfortran are still present.
Ok to commit?
- Brooks
2013-08-08 Brooks
A not-yet-reviewed libtool patch is needed for powerpc64le
shared-library support:
http://lists.gnu.org/archive/html/libtool-patches/2013-06/msg1.html
(See also
http://lists.gnu.org/archive/html/libtool-patches/2013-07/msg1.html)
This patch merges that change into the google/gcc-4_8
Diego -
The attached patch corrects the fact that we were not picking up the
GRTE-specific spec files in our non-x86 GCC builds, and incidentially
simplifies the logic for these spec files since they do not appear to
be changing from one GRTE version to another.
* gcc/configs/linux-grtev2.h:
Diego -
The attached patch adds a little more analysis info to the powerpc64
xfails file. Ok to commit?
Thanks,
- Brooks
2013-07-22_xfail-more-info.diff
Description: Binary data
On 06/04/2013 03:57 PM, Diego Novillo wrote:
OK with this predicate factored into a predicate function (maybe
SummaryLineHasAttributes?)
Thanks! Once I dove into that, I ended up doing a bit more refactoring;
it really makes sense to pull the whole line-splitting into a separate
function
.
This patch fixes the problem: If an entire line is a valid summary line,
we don't try to split it.
Ok to commit?
- Brooks
2013-05-31 Brooks Moses bmo...@google.com
* validate_failures.py: Don't split already-valid summary lines.
The validate_failures.py script in contrib
reviewer to the Write
After Approval section.
Committed.
Index: ChangeLog
===
--- ChangeLog (revision 198467)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2013-04-30 Brooks Moses bmo...@google.com
+
+ * MAINTAINERS: Update
24 matches
Mail list logo
