Re: [PATCH] fixincludes: Update darwin_flt_eval_method for macOS 14

Looks reasonable to me! On 8/16/23 12:20, Rainer Orth wrote: On macOS 14, a guard in changed: -- MacOSX13.3.sdk/usr/include/math.h2023-04-19 01:54:44 +++ MacOSX14.0.sdk/usr/include/math.h 2023-08-01 08:42:43 @@ -22,0 +23 @@ + @@ -43 +44 @@ -#if __FLT_EVAL_METHOD__ == 0 +#if

Vim swap files not ignored

Hi, I don't have the keys for write access anymore. This ought to be applied. Odd that it never has been. :)diff --git a/.gitignore b/.gitignore index 14ee0325176..021a8c74185 100644 --- a/.gitignore +++ b/.gitignore @@ -6,6 +6,7 @@ *~ .#* *# +.*.swp *.flt *.gmo

Re: [PATCH] fixincludes: simplify handling for access() failure [PR21283, PR80047]

Perfect. On 11/12/21 1:58 PM, Xi Ruoyao wrote: diff --git a/fixincludes/fixincl.c b/fixincludes/fixincl.c index 6dba2f6e830..ee57fbf61b4 100644 --- a/fixincludes/fixincl.c +++ b/fixincludes/fixincl.c @@ -1352,11 +1352,10 @@ process (void) if (access (pz_curr_file, R_OK) != 0) { -

Re: [PATCH] fixincludes: fix portability issues about getcwd() [PR21283, PR80047]

If you are going to be excruciatingly, painfully correct, free() is going to be unhappy about freeing a static string in the event getcwd() fails for some inexplicable reason. I'd replace the free() + return with a call to exit. Maybe even: if (VERY_UNLIKELY (access (pz_curr_file, R_OK) !=

Re: [PATCH] fixincludes: don't assume getcwd() can handle NULL argument

On 11/10/21 4:22 AM, Xi Ruoyao wrote: Isn't this warning actually a glibc bug ? However we can't assume the libc we are using is Glibc. Even if the libc supports getcwd() with NULL argument, we are still leaking memory. You could also free

Re: [PATCH v3] fixinc: don't "fix" machine names in __has_include(...) [PR91085]

On 6/28/21 10:26 PM, Xi Ruoyao wrote: v3: use memmem/memchr instead of trivial loops split most of the logic into a static function avoid hardcoded magic number adjust test Looks good to me. :)

Re: [PATCH v2] fixinc: don't "fix" machine names in __has_include(...) [PR91085]

Hi Xi, On 6/27/21 11:07 PM, Xi Ruoyao wrote: diff --git a/fixincludes/fixfixes.c b/fixincludes/fixfixes.c index 5b23a8b640d..147cba716c7 100644 --- a/fixincludes/fixfixes.c +++ b/fixincludes/fixfixes.c @@ -524,7 +524,7 @@ FIX_PROC_HEAD( machine_name_fix ) /* If the 'name_pat' matches in